[GitHub] [lucene] dsmiley commented on a change in pull request #362: LUCENE-9431: UnifiedHighlighter WEIGHT_MATCHES is now true by default

2021-10-21 Thread GitBox
dsmiley commented on a change in pull request #362: URL: https://github.com/apache/lucene/pull/362#discussion_r734210117 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java ## @@ -1168,9 +1174,12 @@ public CacheHelper

[GitHub] [lucene] apanimesh061 commented on a change in pull request #362: LUCENE-9431: UnifiedHighlighter WEIGHT_MATCHES is now true by default

2021-10-21 Thread GitBox
apanimesh061 commented on a change in pull request #362: URL: https://github.com/apache/lucene/pull/362#discussion_r734204016 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java ## @@ -1168,9 +1174,12 @@ public CacheHelper

[GitHub] [lucene] dsmiley commented on a change in pull request #362: LUCENE-9431: UnifiedHighlighter WEIGHT_MATCHES is now true by default

2021-10-21 Thread GitBox
dsmiley commented on a change in pull request #362: URL: https://github.com/apache/lucene/pull/362#discussion_r734203232 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java ## @@ -1168,9 +1174,12 @@ public CacheHelper

[GitHub] [lucene] apanimesh061 commented on a change in pull request #362: LUCENE-9431: UnifiedHighlighter WEIGHT_MATCHES is now true by default

2021-10-21 Thread GitBox
apanimesh061 commented on a change in pull request #362: URL: https://github.com/apache/lucene/pull/362#discussion_r734200431 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java ## @@ -1168,9 +1174,12 @@ public CacheHelper

[GitHub] [lucene] dsmiley commented on pull request #362: LUCENE-9431: UnifiedHighlighter WEIGHT_MATCHES is now true by default

2021-10-21 Thread GitBox
dsmiley commented on pull request #362: URL: https://github.com/apache/lucene/pull/362#issuecomment-949243034 I added your changes but made 3 edits: * Removed your change to the randomized highlighter configuration. It was working before; didn't need anything. Thus we want to continue

[GitHub] [lucene] bruno-roustant commented on a change in pull request #404: LUCENE-10196: Improve IntroSorter with 3-ways partitioning.

2021-10-21 Thread GitBox
bruno-roustant commented on a change in pull request #404: URL: https://github.com/apache/lucene/pull/404#discussion_r734048487 ## File path: lucene/core/src/java/org/apache/lucene/util/IntroSorter.java ## @@ -35,51 +38,102 @@ public final void sort(int from, int to) {

[GitHub] [lucene] dweiss commented on a change in pull request #404: LUCENE-10196: Improve IntroSorter with 3-ways partitioning.

2021-10-21 Thread GitBox
dweiss commented on a change in pull request #404: URL: https://github.com/apache/lucene/pull/404#discussion_r734046039 ## File path: lucene/core/src/java/org/apache/lucene/util/IntroSorter.java ## @@ -35,51 +38,102 @@ public final void sort(int from, int to) {

[GitHub] [lucene] bruno-roustant commented on a change in pull request #404: LUCENE-10196: Improve IntroSorter with 3-ways partitioning.

2021-10-21 Thread GitBox
bruno-roustant commented on a change in pull request #404: URL: https://github.com/apache/lucene/pull/404#discussion_r734039059 ## File path: lucene/core/src/test/org/apache/lucene/util/SorterBenchmark.java ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene] bruno-roustant commented on a change in pull request #404: LUCENE-10196: Improve IntroSorter with 3-ways partitioning.

2021-10-21 Thread GitBox
bruno-roustant commented on a change in pull request #404: URL: https://github.com/apache/lucene/pull/404#discussion_r734035237 ## File path: lucene/core/src/java/org/apache/lucene/util/IntroSorter.java ## @@ -35,51 +38,102 @@ public final void sort(int from, int to) {

[jira] [Updated] (LUCENE-10196) Improve IntroSorter with 3-ways partitioning

2021-10-21 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant updated LUCENE-10196: Description: I added a SorterBenchmark to evaluate the performance of the various Sorter

[jira] [Issue Comment Deleted] (LUCENE-10196) Improve IntroSorter with 3-ways partitioning

2021-10-21 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant updated LUCENE-10196: Comment: was deleted (was: https://github.com/apache/lucene/pull/404) > Improve

[GitHub] [lucene] dweiss commented on a change in pull request #404: LUCENE-10196: Improve IntroSorter with 3-ways partitioning.

2021-10-21 Thread GitBox
dweiss commented on a change in pull request #404: URL: https://github.com/apache/lucene/pull/404#discussion_r734017645 ## File path: lucene/core/src/java/org/apache/lucene/util/IntroSorter.java ## @@ -35,51 +38,102 @@ public final void sort(int from, int to) {

[jira] [Commented] (LUCENE-10196) Improve IntroSorter with 3-ways partitioning

2021-10-21 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432685#comment-17432685 ] Bruno Roustant commented on LUCENE-10196: - https://github.com/apache/lucene/pull/404 > Improve

[jira] [Commented] (LUCENE-8739) ZSTD Compressor support in Lucene

2021-10-21 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432677#comment-17432677 ] Adrien Grand commented on LUCENE-8739: -- You need to download

[jira] [Commented] (LUCENE-10196) Improve IntroSorter with 3-ways partitioning

2021-10-21 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432670#comment-17432670 ] Bruno Roustant commented on LUCENE-10196: - Benchmark run to compare sorters implementations for

[jira] [Created] (LUCENE-10196) Improve IntroSorter with 3-ways partitioning

2021-10-21 Thread Bruno Roustant (Jira)
Bruno Roustant created LUCENE-10196: --- Summary: Improve IntroSorter with 3-ways partitioning Key: LUCENE-10196 URL: https://issues.apache.org/jira/browse/LUCENE-10196 Project: Lucene - Core

[jira] [Commented] (LUCENE-8739) ZSTD Compressor support in Lucene

2021-10-21 Thread Praveen Nishchal (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432590#comment-17432590 ] Praveen Nishchal commented on LUCENE-8739: -- Hi Adrien, Can you please help me by stating the

[jira] [Commented] (LUCENE-8739) ZSTD Compressor support in Lucene

2021-10-21 Thread Praveen Nishchal (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432589#comment-17432589 ] Praveen Nishchal commented on LUCENE-8739: -- Hi Mike, -Dtests.nightly=true ran successfully ,

[GitHub] [lucene-solr] janhoy commented on pull request #1435: SOLR-14410: Switch from SysV init script to systemd service file

2021-10-21 Thread GitBox
janhoy commented on pull request #1435: URL: https://github.com/apache/lucene-solr/pull/1435#issuecomment-948682201 @andreasbolstad Solr 11.0 is not far away. If you have the bandwidth to give this PR a spin on main branch and verify that it works ok, then I'll make sure it is merged in

[jira] [Commented] (LUCENE-10008) CommonGramsFilterFactory doesn't respect ignoreCase=true when default stopwords are used

2021-10-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432518#comment-17432518 ] ASF subversion and git services commented on LUCENE-10008: -- Commit

[jira] [Resolved] (LUCENE-10008) CommonGramsFilterFactory doesn't respect ignoreCase=true when default stopwords are used

2021-10-21 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-10008. - Fix Version/s: 8.11 main (9.0) Resolution: Fixed

[GitHub] [lucene-solr] mikemccand merged pull request #2573: LUCENE-10008: Respect ignoreCase flag in CommonGramsFilterFactory

2021-10-21 Thread GitBox
mikemccand merged pull request #2573: URL: https://github.com/apache/lucene-solr/pull/2573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (LUCENE-8739) ZSTD Compressor support in Lucene

2021-10-21 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432506#comment-17432506 ] Adrien Grand commented on LUCENE-8739: -- You might be interested in the new simple benchmark for

[jira] [Commented] (LUCENE-10165) Implement Lucene90DocValuesProducer#getMergeInstance

2021-10-21 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432502#comment-17432502 ] Adrien Grand commented on LUCENE-10165: --- Merging times for doc values went noticeably down with

[jira] [Resolved] (LUCENE-10093) TestTieredMergePolicy.testForcedMergesUseLeastNumberOfMerges test failure

2021-10-21 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-10093. - Fix Version/s: main (9.0) Resolution: Fixed >

[jira] [Commented] (LUCENE-10093) TestTieredMergePolicy.testForcedMergesUseLeastNumberOfMerges test failure

2021-10-21 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432495#comment-17432495 ] Michael McCandless commented on LUCENE-10093: - The above ^^ fix should resolve this. >

[jira] [Commented] (LUCENE-10093) TestTieredMergePolicy.testForcedMergesUseLeastNumberOfMerges test failure

2021-10-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432460#comment-17432460 ] ASF subversion and git services commented on LUCENE-10093: -- Commit

[GitHub] [lucene] mikemccand merged pull request #375: LUCENE-10093: first cut at fixing conflicting test assert and improving TMP javadocs

2021-10-21 Thread GitBox
mikemccand merged pull request #375: URL: https://github.com/apache/lucene/pull/375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] mikemccand commented on pull request #375: LUCENE-10093: first cut at fixing conflicting test assert and improving TMP javadocs

2021-10-21 Thread GitBox
mikemccand commented on pull request #375: URL: https://github.com/apache/lucene/pull/375#issuecomment-948612756 > > gradlew clean only cleans active modules. packaging has been renamed and no longer exists. Wipe all old cruft with: > > git clean -xfd lucene > > Aha!

[jira] [Commented] (LUCENE-8739) ZSTD Compressor support in Lucene

2021-10-21 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432444#comment-17432444 ] Michael McCandless commented on LUCENE-8739: {quote}My codec passed all test cases with test

[jira] [Commented] (LUCENE-10165) Implement Lucene90DocValuesProducer#getMergeInstance

2021-10-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432315#comment-17432315 ] ASF subversion and git services commented on LUCENE-10165: -- Commit

[jira] [Commented] (LUCENE-8739) ZSTD Compressor support in Lucene

2021-10-21 Thread Praveen Nishchal (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432288#comment-17432288 ] Praveen Nishchal commented on LUCENE-8739: -- Hi Mike, My codec passed all test cases with test

[GitHub] [lucene] jpountz commented on pull request #374: LUCENE-10165: Implement Lucene90DocValuesProducer#getMergeInstance.

2021-10-21 Thread GitBox
jpountz commented on pull request #374: URL: https://github.com/apache/lucene/pull/374#issuecomment-948349796 I didn't observe hotspot confusion when benchmarking locally but I'll be watching nigthlies to check if they see something. -- This is an automated message from the Apache Git

[jira] [Resolved] (LUCENE-10165) Implement Lucene90DocValuesProducer#getMergeInstance

2021-10-21 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10165. --- Fix Version/s: main (9.0) Resolution: Fixed > Implement

[GitHub] [lucene] jpountz merged pull request #374: LUCENE-10165: Implement Lucene90DocValuesProducer#getMergeInstance.

2021-10-21 Thread GitBox
jpountz merged pull request #374: URL: https://github.com/apache/lucene/pull/374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (LUCENE-10165) Implement Lucene90DocValuesProducer#getMergeInstance

2021-10-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432239#comment-17432239 ] ASF subversion and git services commented on LUCENE-10165: -- Commit