[jira] [Updated] (LUCENE-10372) Performance of TaxoFacets in Nightly benchmark decreased

2022-01-10 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Guo updated LUCENE-10372: -- Description: link: https://home.apache.org/~mikemccand/lucenebench/2022.01.10.18.03.12.html

[jira] [Created] (LUCENE-10372) Performance of TaxoFacets in Nightly benchmark decreased

2022-01-10 Thread Feng Guo (Jira)
Feng Guo created LUCENE-10372: - Summary: Performance of TaxoFacets in Nightly benchmark decreased Key: LUCENE-10372 URL: https://issues.apache.org/jira/browse/LUCENE-10372 Project: Lucene - Core

[GitHub] [lucene] spike-liu commented on a change in pull request #464: LUCENE-10251: Add the compliant "Direct" doc-value format

2022-01-10 Thread GitBox
spike-liu commented on a change in pull request #464: URL: https://github.com/apache/lucene/pull/464#discussion_r781808923 ## File path: lucene/codecs/src/java/org/apache/lucene/codecs/memory/DirectDocValuesConsumer.java ## @@ -0,0 +1,980 @@ +/* + * Licensed to the Apache

[GitHub] [lucene] gf2121 commented on pull request #592: LUCENE-10366: Reduce the number of valid checks for ByteBufferIndexInput#readVInt

2022-01-10 Thread GitBox
gf2121 commented on pull request #592: URL: https://github.com/apache/lucene/pull/592#issuecomment-1009656951 I checked some other usage, seeing that for operations like `bytebuffer#readBytes` we also just checked once. If the `length` <= 6, DirectByteBuffer will read byte one by one,

[GitHub] [lucene] gf2121 commented on pull request #592: LUCENE-10366: Reduce the number of valid checks for ByteBufferIndexInput#readVInt

2022-01-10 Thread GitBox
gf2121 commented on pull request #592: URL: https://github.com/apache/lucene/pull/592#issuecomment-1009639460 Thanks @jpountz ! I did not realize that reading ummapped bytebuffer will make JVM crach, sorry! > we should keep calling ensureValid before reading any byte from the

[jira] [Created] (LUCENE-10371) Make IndexRearranger able to arrange segment into a determined order

2022-01-10 Thread Haoyu Zhai (Jira)
Haoyu Zhai created LUCENE-10371: --- Summary: Make IndexRearranger able to arrange segment into a determined order Key: LUCENE-10371 URL: https://issues.apache.org/jira/browse/LUCENE-10371 Project: Lucene

[GitHub] [lucene] gf2121 removed a comment on pull request #592: LUCENE-10366: Reduce the number of valid checks for ByteBufferIndexInput#readVInt

2022-01-10 Thread GitBox
gf2121 removed a comment on pull request #592: URL: https://github.com/apache/lucene/pull/592#issuecomment-1009198243 Thanks @jpountz ! I did not realize that reading ummapped bytebuffer will make JVM crach, sorry! > Separately, this makes me wonder if some of the tasks that get the

[jira] [Resolved] (LUCENE-10245) Allow users to provide DocValues to (some) Facets Implementations

2022-01-10 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller resolved LUCENE-10245. -- Fix Version/s: 9.1 10.0 (main) Resolution: Fixed > Allow users to

[jira] [Commented] (LUCENE-10245) Allow users to provide DocValues to (some) Facets Implementations

2022-01-10 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472345#comment-17472345 ] Greg Miller commented on LUCENE-10245: -- Pushed to {{branch_9x}} / {{{}main{}}}. Resolving.  >

[GitHub] [lucene] gsmiller commented on pull request #543: LUCENE-10245: Addition of MultiDoubleValues(Source) and MultiLongValues(Source) along with faceting capabilities

2022-01-10 Thread GitBox
gsmiller commented on pull request #543: URL: https://github.com/apache/lucene/pull/543#issuecomment-1009386746 Thanks @romseygeek for the rounds of feedback! Much appreciated :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [lucene] jtibshirani commented on pull request #536: Don't store graph offsets for HNSW graph

2022-01-10 Thread GitBox
jtibshirani commented on pull request #536: URL: https://github.com/apache/lucene/pull/536#issuecomment-1009386317 Oh sorry, I didn't see this was merged into the `hnsw` branch. Ignore my comment, I guess we'll handle the new format in another PR. -- This is an automated message from

[jira] [Commented] (LUCENE-10245) Allow users to provide DocValues to (some) Facets Implementations

2022-01-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472341#comment-17472341 ] ASF subversion and git services commented on LUCENE-10245: -- Commit

[jira] [Commented] (LUCENE-10245) Allow users to provide DocValues to (some) Facets Implementations

2022-01-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472336#comment-17472336 ] ASF subversion and git services commented on LUCENE-10245: -- Commit

[GitHub] [lucene] gsmiller merged pull request #543: LUCENE-10245: Addition of MultiDoubleValues(Source) and MultiLongValues(Source) along with faceting capabilities

2022-01-10 Thread GitBox
gsmiller merged pull request #543: URL: https://github.com/apache/lucene/pull/543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (LUCENE-10370) Fix classpath/module path of tests forking their own Java (TestNRTReplication)

2022-01-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472315#comment-17472315 ] ASF subversion and git services commented on LUCENE-10370: -- Commit

[jira] [Commented] (LUCENE-10370) Fix classpath/module path of tests forking their own Java (TestNRTReplication)

2022-01-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472316#comment-17472316 ] ASF subversion and git services commented on LUCENE-10370: -- Commit

[jira] [Updated] (LUCENE-10370) Fix classpath/module path of tests forking their own Java (TestNRTReplication)

2022-01-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-10370: - Description: TestNRTReplication fails because it assumes classpath can just be copied to a

[jira] [Commented] (LUCENE-8739) ZSTD Compressor support in Lucene

2022-01-10 Thread Praveen Nishchal (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472298#comment-17472298 ] Praveen Nishchal commented on LUCENE-8739: -- Hi [~rcmuir]  That is exactly what I am doing :)

[jira] [Updated] (LUCENE-8739) ZSTD Compressor support in Lucene

2022-01-10 Thread Praveen Nishchal (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Praveen Nishchal updated LUCENE-8739: - Attachment: image-2022-01-11-02-18-57-752.png > ZSTD Compressor support in Lucene >

[jira] [Updated] (LUCENE-8739) ZSTD Compressor support in Lucene

2022-01-10 Thread Praveen Nishchal (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Praveen Nishchal updated LUCENE-8739: - Attachment: image-2022-01-11-02-18-11-402.png > ZSTD Compressor support in Lucene >

[jira] [Created] (LUCENE-10370) Fix classpath/module path of tests forking their own Java (TestNRTReplication)

2022-01-10 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-10370: Summary: Fix classpath/module path of tests forking their own Java (TestNRTReplication) Key: LUCENE-10370 URL: https://issues.apache.org/jira/browse/LUCENE-10370

[jira] [Resolved] (LUCENE-10328) Module path for compiling and running tests is wrong

2022-01-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-10328. -- Resolution: Fixed > Module path for compiling and running tests is wrong >

[jira] [Commented] (LUCENE-10328) Module path for compiling and running tests is wrong

2022-01-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472293#comment-17472293 ] Dawid Weiss commented on LUCENE-10328: -- It's failing because it forks its own sub-process (java)

[GitHub] [lucene] grcevski opened a new pull request #596: LUCENE-10369: Move DelegatingCacheHelper to FilterDirectoryReader

2022-01-10 Thread GitBox
grcevski opened a new pull request #596: URL: https://github.com/apache/lucene/pull/596 # Description To support building long-lived readers without IndexReader to delegate caching to, it would be beneficial to refactor SoftDeletesDirectoryReaderWrapper, such that its caching

[jira] [Commented] (LUCENE-10250) Add hierarchical labels to SSDV facets

2022-01-10 Thread Marc D'Mello (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472276#comment-17472276 ] Marc D'Mello commented on LUCENE-10250: --- Thanks [~gsmiller]! > Add hierarchical labels to SSDV

[jira] [Commented] (LUCENE-10157) Add Additional Indri Search Engine Functionality to Lucene

2022-01-10 Thread Cameron VandenBerg (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472274#comment-17472274 ] Cameron VandenBerg commented on LUCENE-10157: - Hi [~jpountz],  I have updated PR

[jira] [Created] (LUCENE-10369) Move DelegatingCacheHelper to FilterDirectoryReader from SoftDeletesDirectoryReaderWrapper

2022-01-10 Thread Nikola Grcevski (Jira)
Nikola Grcevski created LUCENE-10369: Summary: Move DelegatingCacheHelper to FilterDirectoryReader from SoftDeletesDirectoryReaderWrapper Key: LUCENE-10369 URL:

[GitHub] [lucene] cammiemw commented on pull request #463: LUCENE-10157 - Added IndriOr, IndriWeightedSum, and IndriQueryParser

2022-01-10 Thread GitBox
cammiemw commented on pull request #463: URL: https://github.com/apache/lucene/pull/463#issuecomment-1009289345 Hi @cpoerschke! Thank you for your comments. I have made the changes to accept most of your suggestions. For the weight explain methods, I went through and tweaked them so

[GitHub] [lucene] jtibshirani commented on pull request #536: Don't store graph offsets for HNSW graph

2022-01-10 Thread GitBox
jtibshirani commented on pull request #536: URL: https://github.com/apache/lucene/pull/536#issuecomment-1009253260 @mayya-sharipova this looks like a nice improvement. We should make sure it's done in a backwards compatible way though, so we can still read vectors that were written in

[jira] [Resolved] (LUCENE-10356) Special-case singleton doc values for general taxonomy facet counting

2022-01-10 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller resolved LUCENE-10356. -- Fix Version/s: 9.1 10.0 (main) Resolution: Fixed Merged onto

[jira] [Commented] (LUCENE-10356) Special-case singleton doc values for general taxonomy facet counting

2022-01-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472225#comment-17472225 ] ASF subversion and git services commented on LUCENE-10356: -- Commit

[GitHub] [lucene] gf2121 edited a comment on pull request #592: LUCENE-10366: Reduce the number of valid checks for ByteBufferIndexInput#readVInt

2022-01-10 Thread GitBox
gf2121 edited a comment on pull request #592: URL: https://github.com/apache/lucene/pull/592#issuecomment-1009198243 Thanks @jpountz ! I did not realize that reading ummapped bytebuffer will make JVM crach, sorry! > Separately, this makes me wonder if some of the tasks that get the

[GitHub] [lucene] uschindler commented on a change in pull request #579: LUCENE-10283: Bump minimum required Java version to 17.

2022-01-10 Thread GitBox
uschindler commented on a change in pull request #579: URL: https://github.com/apache/lucene/pull/579#discussion_r781443293 ## File path: lucene/core/src/java/org/apache/lucene/util/fst/PositiveIntOutputs.java ## @@ -17,22 +17,19 @@ package org.apache.lucene.util.fst;

[jira] [Commented] (LUCENE-10356) Special-case singleton doc values for general taxonomy facet counting

2022-01-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472212#comment-17472212 ] ASF subversion and git services commented on LUCENE-10356: -- Commit

[GitHub] [lucene] gf2121 edited a comment on pull request #592: LUCENE-10366: Reduce the number of valid checks for ByteBufferIndexInput#readVInt

2022-01-10 Thread GitBox
gf2121 edited a comment on pull request #592: URL: https://github.com/apache/lucene/pull/592#issuecomment-1009198243 Thanks @jpountz ! I did not realize that reading ummapped bytebuffer will make JVM crach, sorry! > Separately, this makes me wonder if some of the tasks that get the

[GitHub] [lucene] gsmiller merged pull request #585: LUCENE-10356: Further optimize facet counting for single-valued TaxonomyFacetCounts

2022-01-10 Thread GitBox
gsmiller merged pull request #585: URL: https://github.com/apache/lucene/pull/585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] gf2121 commented on pull request #592: LUCENE-10366: Reduce the number of valid checks for ByteBufferIndexInput#readVInt

2022-01-10 Thread GitBox
gf2121 commented on pull request #592: URL: https://github.com/apache/lucene/pull/592#issuecomment-1009198243 Thanks @jpountz ! I did not realize that reading ummapped bytebuffer will make JVM crach, sorry! > Separately, this makes me wonder if some of the tasks that get the best

[GitHub] [lucene] jpountz commented on pull request #592: LUCENE-10366: Reduce the number of valid checks for ByteBufferIndexInput#readVInt

2022-01-10 Thread GitBox
jpountz commented on pull request #592: URL: https://github.com/apache/lucene/pull/592#issuecomment-1009182865 I think there is another issue with this PR, which is that if a vInt is written across two ByteBuffers, then your PR would only ensure the validity of one of these ByteBuffers,

[jira] [Commented] (LUCENE-10250) Add hierarchical labels to SSDV facets

2022-01-10 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472179#comment-17472179 ] Greg Miller commented on LUCENE-10250: -- Merged this onto both {{main}} and {{{}branch_9x{}}}.

[jira] [Resolved] (LUCENE-10250) Add hierarchical labels to SSDV facets

2022-01-10 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller resolved LUCENE-10250. -- Fix Version/s: 9.1 10.0 (main) Resolution: Fixed > Add

[jira] [Commented] (LUCENE-10250) Add hierarchical labels to SSDV facets

2022-01-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472178#comment-17472178 ] ASF subversion and git services commented on LUCENE-10250: -- Commit

[jira] [Commented] (LUCENE-10250) Add hierarchical labels to SSDV facets

2022-01-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472174#comment-17472174 ] ASF subversion and git services commented on LUCENE-10250: -- Commit

[GitHub] [lucene] gsmiller merged pull request #595: Add CHANGES entry for LUCENE-10250

2022-01-10 Thread GitBox
gsmiller merged pull request #595: URL: https://github.com/apache/lucene/pull/595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (LUCENE-10250) Add hierarchical labels to SSDV facets

2022-01-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472160#comment-17472160 ] ASF subversion and git services commented on LUCENE-10250: -- Commit

[GitHub] [lucene] gsmiller merged pull request #509: LUCENE-10250: Add support for arbitrary length hierarchical SSDV facets

2022-01-10 Thread GitBox
gsmiller merged pull request #509: URL: https://github.com/apache/lucene/pull/509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (LUCENE-10350) Avoid some null checking for FastTaxonomyFacetCounts#countAll()

2022-01-10 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller resolved LUCENE-10350. -- Fix Version/s: 9.1 10.0 (main) Resolution: Fixed > Avoid some null

[jira] [Commented] (LUCENE-10350) Avoid some null checking for FastTaxonomyFacetCounts#countAll()

2022-01-10 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472159#comment-17472159 ] Greg Miller commented on LUCENE-10350: -- Merged onto {{main}} / {{{}branch_9x{}}}. Thanks [~gf2121]

[jira] [Commented] (LUCENE-10350) Avoid some null checking for FastTaxonomyFacetCounts#countAll()

2022-01-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472158#comment-17472158 ] ASF subversion and git services commented on LUCENE-10350: -- Commit

[GitHub] [lucene] gsmiller merged pull request #594: LUCENE-10350: Avoid some null checking for FastTaxonomyFacetCounts#countAll()

2022-01-10 Thread GitBox
gsmiller merged pull request #594: URL: https://github.com/apache/lucene/pull/594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] mikemccand commented on a change in pull request #579: LUCENE-10283: Bump minimum required Java version to 17.

2022-01-10 Thread GitBox
mikemccand commented on a change in pull request #579: URL: https://github.com/apache/lucene/pull/579#discussion_r781354303 ## File path: lucene/core/src/java/org/apache/lucene/util/fst/PositiveIntOutputs.java ## @@ -17,22 +17,19 @@ package org.apache.lucene.util.fst;

[jira] [Commented] (LUCENE-10350) Avoid some null checking for FastTaxonomyFacetCounts#countAll()

2022-01-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472132#comment-17472132 ] ASF subversion and git services commented on LUCENE-10350: -- Commit

[jira] [Commented] (LUCENE-10291) Only read/write postings when there is at least one indexed field

2022-01-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472130#comment-17472130 ] ASF subversion and git services commented on LUCENE-10291: -- Commit

[jira] [Commented] (LUCENE-10183) KnnVectorsWriter#writeField should take a KnnVectorsReader, not a VectorValues instance

2022-01-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472128#comment-17472128 ] ASF subversion and git services commented on LUCENE-10183: -- Commit

[jira] [Commented] (LUCENE-10353) Add null injection to analyzer integration tests (e.g. TestRandomChains)

2022-01-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472127#comment-17472127 ] ASF subversion and git services commented on LUCENE-10353: -- Commit

[jira] [Commented] (LUCENE-10364) Prepare and update errorprone plugin for Java 17

2022-01-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472129#comment-17472129 ] ASF subversion and git services commented on LUCENE-10364: -- Commit

[jira] [Commented] (LUCENE-10283) Bump minimum required Java version to 17

2022-01-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472131#comment-17472131 ] ASF subversion and git services commented on LUCENE-10283: -- Commit

[GitHub] [lucene] uschindler commented on pull request #579: LUCENE-10283: Bump minimum required Java version to 17.

2022-01-10 Thread GitBox
uschindler commented on pull request #579: URL: https://github.com/apache/lucene/pull/579#issuecomment-1009020821 Thanks! 朗 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [lucene] gsmiller commented on a change in pull request #578: LUCENE-10350: Avoid some null checking for FastTaxonomyFacetCounts#countAll()

2022-01-10 Thread GitBox
gsmiller commented on a change in pull request #578: URL: https://github.com/apache/lucene/pull/578#discussion_r781315189 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java ## @@ -74,11 +74,6 @@ protected boolean

[jira] [Created] (LUCENE-10368) Reduce visibility of IntTaxonomyFacets

2022-01-10 Thread Greg Miller (Jira)
Greg Miller created LUCENE-10368: Summary: Reduce visibility of IntTaxonomyFacets Key: LUCENE-10368 URL: https://issues.apache.org/jira/browse/LUCENE-10368 Project: Lucene - Core Issue Type:

[GitHub] [lucene] gsmiller opened a new pull request #594: LUCENE-10350: Avoid some null checking for FastTaxonomyFacetCounts#countAll()

2022-01-10 Thread GitBox
gsmiller opened a new pull request #594: URL: https://github.com/apache/lucene/pull/594 Just backporting... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (LUCENE-10350) Avoid some null checking for FastTaxonomyFacetCounts#countAll()

2022-01-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472113#comment-17472113 ] ASF subversion and git services commented on LUCENE-10350: -- Commit

[GitHub] [lucene] gsmiller merged pull request #578: LUCENE-10350: Avoid some null checking for FastTaxonomyFacetCounts#countAll()

2022-01-10 Thread GitBox
gsmiller merged pull request #578: URL: https://github.com/apache/lucene/pull/578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] gsmiller commented on pull request #509: LUCENE-10250: Add support for arbitrary length hierarchical SSDV facets

2022-01-10 Thread GitBox
gsmiller commented on pull request #509: URL: https://github.com/apache/lucene/pull/509#issuecomment-1009000807 This looks good to me in its current state. I kicked off the precommit checks again. Assuming they pass successfully, I'll work on merging this today. Thanks! -- This is an

[GitHub] [lucene] gsmiller commented on a change in pull request #509: LUCENE-10250: Add support for arbitrary length hierarchical SSDV facets

2022-01-10 Thread GitBox
gsmiller commented on a change in pull request #509: URL: https://github.com/apache/lucene/pull/509#discussion_r781298962 ## File path: lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java ## @@ -317,10 +345,19 @@ public Number

[GitHub] [lucene] gsmiller commented on a change in pull request #509: LUCENE-10250: Add support for arbitrary length hierarchical SSDV facets

2022-01-10 Thread GitBox
gsmiller commented on a change in pull request #509: URL: https://github.com/apache/lucene/pull/509#discussion_r781298004 ## File path: lucene/facet/src/java/org/apache/lucene/facet/sortedset/DefaultSortedSetDocValuesReaderState.java ## @@ -51,20 +55,42 @@ private final

[GitHub] [lucene] mayya-sharipova merged pull request #536: Don't store graph offsets for HNSW graph

2022-01-10 Thread GitBox
mayya-sharipova merged pull request #536: URL: https://github.com/apache/lucene/pull/536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #536: Don't store graph offsets for HNSW graph

2022-01-10 Thread GitBox
mayya-sharipova commented on a change in pull request #536: URL: https://github.com/apache/lucene/pull/536#discussion_r781281722 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java ## @@ -516,23 +494,20 @@ private void

[jira] [Commented] (LUCENE-10283) Bump minimum required Java version to 17

2022-01-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472070#comment-17472070 ] ASF subversion and git services commented on LUCENE-10283: -- Commit

[jira] [Resolved] (LUCENE-10283) Bump minimum required Java version to 17

2022-01-10 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10283. --- Fix Version/s: 10.0 (main) Resolution: Fixed > Bump minimum required Java version

[GitHub] [lucene] jpountz merged pull request #579: LUCENE-10283: Bump minimum required Java version to 17.

2022-01-10 Thread GitBox
jpountz merged pull request #579: URL: https://github.com/apache/lucene/pull/579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] jpountz merged pull request #589: Simplify some exception handling with try-with-resources.

2022-01-10 Thread GitBox
jpountz merged pull request #589: URL: https://github.com/apache/lucene/pull/589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (LUCENE-10328) Module path for compiling and running tests is wrong

2022-01-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17472064#comment-17472064 ] Dawid Weiss commented on LUCENE-10328: -- Thanks [~jpountz] , I'll take a look. > Module path for

[jira] [Reopened] (LUCENE-10328) Module path for compiling and running tests is wrong

2022-01-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss reopened LUCENE-10328: -- Assignee: Dawid Weiss > Module path for compiling and running tests is wrong >

[jira] [Updated] (LUCENE-10367) Use WANDScorer in CoveringQuery Can accelerate scorer time

2022-01-10 Thread LuYunCheng (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] LuYunCheng updated LUCENE-10367: Description: When using CoveringQuery In Elasticsearch with terms_set query, it takes too much

[jira] [Commented] (LUCENE-10328) Module path for compiling and running tests is wrong

2022-01-10 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17471973#comment-17471973 ] Adrien Grand commented on LUCENE-10328: --- There have been regular failures to TestNRTReplication

[jira] [Updated] (LUCENE-10367) Use WANDScorer in CoveringQuery Can accelerate scorer time

2022-01-10 Thread LuYunCheng (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] LuYunCheng updated LUCENE-10367: Attachment: LUCENE-10367.patch Review Patch?: Yes Description: When using

[jira] [Created] (LUCENE-10367) Use WANDScorer in CoveringQuery Can accelerate scorer time

2022-01-10 Thread LuYunCheng (Jira)
LuYunCheng created LUCENE-10367: --- Summary: Use WANDScorer in CoveringQuery Can accelerate scorer time Key: LUCENE-10367 URL: https://issues.apache.org/jira/browse/LUCENE-10367 Project: Lucene - Core

[jira] [Commented] (LUCENE-10291) Only read/write postings when there is at least one indexed field

2022-01-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17471950#comment-17471950 ] ASF subversion and git services commented on LUCENE-10291: -- Commit

[GitHub] [lucene] romseygeek merged pull request #593: Fix testMinimalCodec

2022-01-10 Thread GitBox
romseygeek merged pull request #593: URL: https://github.com/apache/lucene/pull/593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (LUCENE-10291) Only read/write postings when there is at least one indexed field

2022-01-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17471945#comment-17471945 ] ASF subversion and git services commented on LUCENE-10291: -- Commit

[GitHub] [lucene] ywelsch opened a new pull request #593: Fix testMinimalCodec

2022-01-10 Thread GitBox
ywelsch opened a new pull request #593: URL: https://github.com/apache/lucene/pull/593 Follow-up to LUCENE-10291 This test was occasionally failing on CI, as the test randomly installed a merge policy that would force compound file creation while the goal of the test was not to

[GitHub] [lucene] romseygeek commented on a change in pull request #543: LUCENE-10245: Addition of MultiDoubleValues(Source) and MultiLongValues(Source) along with faceting capabilities

2022-01-10 Thread GitBox
romseygeek commented on a change in pull request #543: URL: https://github.com/apache/lucene/pull/543#discussion_r781053318 ## File path: lucene/facet/src/java/org/apache/lucene/facet/MultiDoubleValues.java ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [lucene] javanna commented on pull request #240: LUCENE-10002: Deprecate IndexSearch#search(Query, Collector) in favor of IndexSearcher#search(Query, CollectorManager)

2022-01-10 Thread GitBox
javanna commented on pull request #240: URL: https://github.com/apache/lucene/pull/240#issuecomment-1008729436 hi @zacharymorn I looked at this issue a long while ago, before you started working on it, and I am now catching up. I see you made great progress on it! I also see that