[GitHub] [lucene-solr] magibney closed pull request #892: LUCENE-8972: Add ICUTransformCharFilter, to support pre-tokenizer ICU text transformation

2022-04-07 Thread GitBox
magibney closed pull request #892: LUCENE-8972: Add ICUTransformCharFilter, to support pre-tokenizer ICU text transformation URL: https://github.com/apache/lucene-solr/pull/892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [lucene-solr] magibney commented on pull request #892: LUCENE-8972: Add ICUTransformCharFilter, to support pre-tokenizer ICU text transformation

2022-04-07 Thread GitBox
magibney commented on PR #892: URL: https://github.com/apache/lucene-solr/pull/892#issuecomment-1092433057 superseded by: https://github.com/apache/lucene/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [lucene] gautamworah96 commented on pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch decide

2022-04-07 Thread GitBox
gautamworah96 commented on PR #762: URL: https://github.com/apache/lucene/pull/762#issuecomment-1092327314 Ooof this new commit was quite a journey. The test case sporadically started failing after I added the two use cases (of testing both the DTR and ARDTR). This led me down to debugging

[GitHub] [lucene] gautamworah96 commented on a diff in pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch d

2022-04-07 Thread GitBox
gautamworah96 commented on code in PR #762: URL: https://github.com/apache/lucene/pull/762#discussion_r845651281 ## lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache

[GitHub] [lucene] gautamworah96 commented on a diff in pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch d

2022-04-07 Thread GitBox
gautamworah96 commented on code in PR #762: URL: https://github.com/apache/lucene/pull/762#discussion_r845651072 ## lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/AlwaysRefreshDirectoryTaxonomyReader.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache

[GitHub] [lucene] gautamworah96 commented on a diff in pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch d

2022-04-07 Thread GitBox
gautamworah96 commented on code in PR #762: URL: https://github.com/apache/lucene/pull/762#discussion_r845651006 ## lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache

[jira] [Comment Edited] (LUCENE-10292) AnalyzingInfixSuggester thread safety: lookup() fails during (re)build()

2022-04-07 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17519232#comment-17519232 ] Chris M. Hostetter edited comment on LUCENE-10292 at 4/8/22 12:11 AM:

[jira] [Updated] (LUCENE-10292) AnalyzingInfixSuggester thread safety: lookup() fails during (re)build()

2022-04-07 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated LUCENE-10292: Attachment: LUCENE-10292-3.patch Status: Open (was: Open) {quote} ...

[jira] [Commented] (LUCENE-10292) AnalyzingInfixSuggester thread safety: lookup() fails during (re)build()

2022-04-07 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17519219#comment-17519219 ] Michael Sokolov commented on LUCENE-10292: -- It's surprising it took so long for someone to

[GitHub] [lucene] Yuti-G commented on pull request #778: LUCENE-10495: Fix return statement of siblingsLoaded() in TaxonomyFacets

2022-04-07 Thread GitBox
Yuti-G commented on PR #778: URL: https://github.com/apache/lucene/pull/778#issuecomment-1092196648 Thanks @gsmiller! I resolved the conflicts and added an entry to CHANGES.txt. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (LUCENE-10495) Fix return statement of siblingsLoaded() in TaxonomyFacets

2022-04-07 Thread Yuting Gan (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuting Gan updated LUCENE-10495: Summary: Fix return statement of siblingsLoaded() in TaxonomyFacets (was: Fix bug in

[GitHub] [lucene] gsmiller commented on pull request #778: LUCENE-10495: Fix bug in TaxonomyFacets

2022-04-07 Thread GitBox
gsmiller commented on PR #778: URL: https://github.com/apache/lucene/pull/778#issuecomment-1091998032 @Yuti-G looks like a conflict needs to be resolved when you get a chance. Also, could you please add an entry to CHANGES.txt noting the bug fix please? We'll backport this to 9.2, so it

[GitHub] [lucene] gsmiller commented on a diff in pull request #778: LUCENE-10495: Fix bug in TaxonomyFacets

2022-04-07 Thread GitBox
gsmiller commented on code in PR #778: URL: https://github.com/apache/lucene/pull/778#discussion_r845387164 ## lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacets.java: ## @@ -109,7 +109,7 @@ public boolean childrenLoaded() { * @lucene.experimental */

[jira] [Commented] (LUCENE-10507) Should it be more likely to search concurrently in tests?

2022-04-07 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17519004#comment-17519004 ] Adrien Grand commented on LUCENE-10507: --- +1 > Should it be more likely to search concurrently in

[jira] [Resolved] (LUCENE-10444) Support alternate aggregation functions in association facets

2022-04-07 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller resolved LUCENE-10444. -- Fix Version/s: 9.2 Resolution: Fixed > Support alternate aggregation functions in

[jira] [Commented] (LUCENE-10488) Optimize Facets#getTopDims across Facets implementations

2022-04-07 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518939#comment-17518939 ] Greg Miller commented on LUCENE-10488: -- Very exciting. Thanks [~yutinggan]! Also, please note that

[jira] [Commented] (LUCENE-10507) Should it be more likely to search concurrently in tests?

2022-04-07 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518935#comment-17518935 ] Greg Miller commented on LUCENE-10507: -- +1. I think this is a great idea! > Should it be more

[jira] [Commented] (LUCENE-10444) Support alternate aggregation functions in association facets

2022-04-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518933#comment-17518933 ] ASF subversion and git services commented on LUCENE-10444: -- Commit

[GitHub] [lucene] gsmiller merged pull request #719: LUCENE-10444 BACKPORT: Support alternate aggregation functions in association facets

2022-04-07 Thread GitBox
gsmiller merged PR #719: URL: https://github.com/apache/lucene/pull/719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] mocobeta opened a new pull request, #801: LUCENE-10493: Unify token Type enum in kuromoji and nori

2022-04-07 Thread GitBox
mocobeta opened a new pull request, #801: URL: https://github.com/apache/lucene/pull/801 Both `JapaneseTokenizer.Type` and `KoreanTokenizer.Type` enums are identical and they should be placed in the `o.a.l.a.morph` package in analysis-common (so that `o.a.l.a.morph.Token` can have the type

[jira] [Commented] (LUCENE-10493) Can we unify the viterbi search logic in the tokenizers of kuromoji and nori?

2022-04-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518852#comment-17518852 ] ASF subversion and git services commented on LUCENE-10493: -- Commit

[jira] [Commented] (LUCENE-10493) Can we unify the viterbi search logic in the tokenizers of kuromoji and nori?

2022-04-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518851#comment-17518851 ] ASF subversion and git services commented on LUCENE-10493: -- Commit

[GitHub] [lucene] mocobeta merged pull request #795: LUCENE-10493: Unify TokenInfoFST in kuromoji and nori

2022-04-07 Thread GitBox
mocobeta merged PR #795: URL: https://github.com/apache/lucene/pull/795 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] mocobeta merged pull request #793: LUCENE-10493: add 'backWordPos' array to JapaneseTokenizer.Position

2022-04-07 Thread GitBox
mocobeta merged PR #793: URL: https://github.com/apache/lucene/pull/793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (LUCENE-10507) Should it be more likely to search concurrently in tests?

2022-04-07 Thread Luca Cavanna (Jira)
Luca Cavanna created LUCENE-10507: - Summary: Should it be more likely to search concurrently in tests? Key: LUCENE-10507 URL: https://issues.apache.org/jira/browse/LUCENE-10507 Project: Lucene - Core

[GitHub] [lucene] mayya-sharipova opened a new pull request, #800: Make constructor for QueryOffsetRange public

2022-04-07 Thread GitBox
mayya-sharipova opened a new pull request, #800: URL: https://github.com/apache/lucene/pull/800 QueryOffsetRange is a public class and is used in other classes (e.g. FieldValueHighlighters needs it). Make it constructor public as well to be used in other packages -- This is an

[GitHub] [lucene] javanna opened a new pull request, #799: LUCENE-10506: change visibility of ProfilerCollector#deriveCollectorName to protected

2022-04-07 Thread GitBox
javanna opened a new pull request, #799: URL: https://github.com/apache/lucene/pull/799 This allows subclasses to extend how the inner collector name is derived. - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/lucene/blob/main/CONTRIBUTING.md)

[jira] [Created] (LUCENE-10506) ProfilerCollector to support customizing how name is derived

2022-04-07 Thread Luca Cavanna (Jira)
Luca Cavanna created LUCENE-10506: - Summary: ProfilerCollector to support customizing how name is derived Key: LUCENE-10506 URL: https://issues.apache.org/jira/browse/LUCENE-10506 Project: Lucene -

[jira] [Updated] (LUCENE-10505) Cleanup oal.util.Constants to use java.lang.Runtime.Version and remove outdated versions

2022-04-07 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-10505: --- Description: In oal.util.Constants we have some constants about the 64 bitness and Java

[jira] [Commented] (LUCENE-10436) Combine DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery into a single FieldExistsQuery?

2022-04-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518661#comment-17518661 ] ASF subversion and git services commented on LUCENE-10436: -- Commit

[GitHub] [lucene] zacharymorn merged pull request #798: LUCENE-10436: (Backport) Remove usage of DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery

2022-04-07 Thread GitBox
zacharymorn merged PR #798: URL: https://github.com/apache/lucene/pull/798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] zacharymorn merged pull request #790: LUCENE-10436: Remove deprecated DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery

2022-04-07 Thread GitBox
zacharymorn merged PR #790: URL: https://github.com/apache/lucene/pull/790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] zacharymorn commented on pull request #790: LUCENE-10436: Remove deprecated DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery

2022-04-07 Thread GitBox
zacharymorn commented on PR #790: URL: https://github.com/apache/lucene/pull/790#issuecomment-1091228578 Thanks @jpountz ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (LUCENE-10505) Cleanup oal.util.Constants to use java.lang.Runtime.Version and remove outdated versions

2022-04-07 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-10505: --- Labels: cleanup (was: ) > Cleanup oal.util.Constants to use java.lang.Runtime.Version and

[jira] [Updated] (LUCENE-10505) Cleanup oal.util.Constants to use java.lang.Runtime.Version and remove outdated versions

2022-04-07 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-10505: --- Affects Version/s: 9.1 9.0 10.0 (main) >

[jira] [Created] (LUCENE-10505) Cleanup oal.util.Constants to use java.lang.Runtime.Version and remove outdated versions

2022-04-07 Thread Uwe Schindler (Jira)
Uwe Schindler created LUCENE-10505: -- Summary: Cleanup oal.util.Constants to use java.lang.Runtime.Version and remove outdated versions Key: LUCENE-10505 URL: https://issues.apache.org/jira/browse/LUCENE-10505

[GitHub] [lucene] zacharymorn commented on a diff in pull request #790: LUCENE-10436: Remove deprecated DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery

2022-04-07 Thread GitBox
zacharymorn commented on code in PR #790: URL: https://github.com/apache/lucene/pull/790#discussion_r844802728 ## lucene/core/src/java/org/apache/lucene/search/UsageTrackingQueryCachingPolicy.java: ## @@ -58,12 +58,6 @@ private static boolean shouldNeverCache(Query query) {

[GitHub] [lucene] jpountz commented on a diff in pull request #790: LUCENE-10436: Remove deprecated DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery

2022-04-07 Thread GitBox
jpountz commented on code in PR #790: URL: https://github.com/apache/lucene/pull/790#discussion_r844759861 ## lucene/core/src/java/org/apache/lucene/search/UsageTrackingQueryCachingPolicy.java: ## @@ -58,12 +58,6 @@ private static boolean shouldNeverCache(Query query) {

[GitHub] [lucene] zacharymorn commented on pull request #790: LUCENE-10436: Remove deprecated DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery

2022-04-07 Thread GitBox
zacharymorn commented on PR #790: URL: https://github.com/apache/lucene/pull/790#issuecomment-1091130105 > Great. We should backport these changes but the actual removals to 9.x to address deprecation warnings. Thanks for the review! I've created the backporting PR for 9.x here

[GitHub] [lucene] zacharymorn opened a new pull request, #798: LUCENE-10436: (Backport) Remove usage of DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery

2022-04-07 Thread GitBox
zacharymorn opened a new pull request, #798: URL: https://github.com/apache/lucene/pull/798 Backporting PR https://github.com/apache/lucene/pull/790 without removal of the deprecated queries. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (LUCENE-10436) Combine DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery into a single FieldExistsQuery?

2022-04-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518601#comment-17518601 ] ASF subversion and git services commented on LUCENE-10436: -- Commit

[GitHub] [lucene] zacharymorn merged pull request #791: LUCENE-10436: (Backporting) Deprecate DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery with FieldExistsQuery

2022-04-07 Thread GitBox
zacharymorn merged PR #791: URL: https://github.com/apache/lucene/pull/791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] zacharymorn commented on a diff in pull request #790: LUCENE-10436: Remove deprecated DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery

2022-04-07 Thread GitBox
zacharymorn commented on code in PR #790: URL: https://github.com/apache/lucene/pull/790#discussion_r844733404 ## lucene/core/src/java/org/apache/lucene/search/UsageTrackingQueryCachingPolicy.java: ## @@ -58,12 +58,6 @@ private static boolean shouldNeverCache(Query query) {

[GitHub] [lucene] zacharymorn commented on pull request #790: LUCENE-10436: Remove deprecated DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery

2022-04-07 Thread GitBox
zacharymorn commented on PR #790: URL: https://github.com/apache/lucene/pull/790#issuecomment-1091119984 > > For the change entry, I assume this should go into version 10.0.0? > > Yes, we need a CHANGES entry under 10.0.0 and a new entry in `lucene/MIGRATE.txt` that recommends