[
https://issues.apache.org/jira/browse/LUCENE-10545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529748#comment-17529748
]
Tomoko Uchida commented on LUCENE-10545:
Note that this does not replace Jira issue with Github
[
https://issues.apache.org/jira/browse/LUCENE-10543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529735#comment-17529735
]
Tomoko Uchida commented on LUCENE-10543:
I opened [LUCENE-10393] and a PR for it. Can you
[
https://issues.apache.org/jira/browse/LUCENE-10543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529735#comment-17529735
]
Tomoko Uchida edited comment on LUCENE-10543 at 4/29/22 3:21 AM:
-
I
mocobeta commented on code in PR #854:
URL: https://github.com/apache/lucene/pull/854#discussion_r861437113
##
lucene/CHANGES.txt:
##
@@ -53,7 +53,7 @@ Other
* LUCENE-10253: The @BadApple annotation has been removed from the test
framework. (Adrien Grand)
-* LUCENE-10393:
mocobeta commented on code in PR #854:
URL: https://github.com/apache/lucene/pull/854#discussion_r861437113
##
lucene/CHANGES.txt:
##
@@ -53,7 +53,7 @@ Other
* LUCENE-10253: The @BadApple annotation has been removed from the test
framework. (Adrien Grand)
-* LUCENE-10393:
[
https://issues.apache.org/jira/browse/LUCENE-10545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529732#comment-17529732
]
Tomoko Uchida commented on LUCENE-10545:
This PR shows a concrete example to show how it'll
[
https://issues.apache.org/jira/browse/LUCENE-10545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida updated LUCENE-10545:
---
Description:
{{changes2html}} already supports links to Github PRs (LUCENE-5383), but the
[
https://issues.apache.org/jira/browse/LUCENE-10545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida updated LUCENE-10545:
---
Description:
{{changes2html}} already supports links to Github PRs ([LUCENE-5383]), but
mocobeta commented on code in PR #854:
URL: https://github.com/apache/lucene/pull/854#discussion_r861432053
##
gradle/documentation/changes-to-html/changes2html.pl:
##
@@ -572,7 +572,7 @@
$item =~ s{((LUCENE|SOLR|INFRA)\s+(\d{3,}))}
{$1}gi;
# Link
mocobeta commented on code in PR #854:
URL: https://github.com/apache/lucene/pull/854#discussion_r861431387
##
lucene/CHANGES.txt:
##
@@ -53,7 +53,7 @@ Other
* LUCENE-10253: The @BadApple annotation has been removed from the test
framework. (Adrien Grand)
-* LUCENE-10393:
mocobeta opened a new pull request, #854:
URL: https://github.com/apache/lucene/pull/854
changes2html already supports links to Github PRs, but the link is obsoleted
so a small modification is needed to make it work again.
With this change, developers can directly link to their pull
Tomoko Uchida created LUCENE-10545:
--
Summary: Allow Github PR link in CHANGES.html
Key: LUCENE-10545
URL: https://issues.apache.org/jira/browse/LUCENE-10545
Project: Lucene - Core
Issue
Yuti-G commented on PR #843:
URL: https://github.com/apache/lucene/pull/843#issuecomment-1112806474
Thanks @gsmiller for confirming! I will create another Jira issue to propose
adding getAllChildren to Facets, and revisit this issue after getting feedback
from the community. Thanks again
[
https://issues.apache.org/jira/browse/LUCENE-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529710#comment-17529710
]
ASF subversion and git services commented on LUCENE-10493:
--
Commit
mocobeta merged PR #846:
URL: https://github.com/apache/lucene/pull/846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mocobeta commented on PR #853:
URL: https://github.com/apache/lucene/pull/853#issuecomment-1112798859
@gautamworah96 This looks good to me!
I wonder if it makes sense to mention the off-the-shelf
https://github.com/apache/lucene/tree/main/lucene/benchmark module here too (I
didn't find
gsmiller commented on PR #843:
URL: https://github.com/apache/lucene/pull/843#issuecomment-1112797399
> Are you suggesting that I add another getAllChildren API to retain the
current behavior of getTopChildren, and then fix getTopChildren by returning
ranges sorted by counts, or do you
gsmiller commented on PR #848:
URL: https://github.com/apache/lucene/pull/848#issuecomment-1112794825
@vigyasharma yeah exactly. So the faceting implementation was summing the
doc values in a different order from the test case. I wish I could do something
similar for the overall
gsmiller commented on code in PR #848:
URL: https://github.com/apache/lucene/pull/848#discussion_r861408137
##
lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyFacetAssociations.java:
##
@@ -500,10 +500,7 @@ private void validateFloats(
mocobeta commented on PR #850:
URL: https://github.com/apache/lucene/pull/850#issuecomment-1112791650
I traced method calls of `BaseTokenStreamTestCase.checkRandomData(Random
random, Analyzer a, int iterations, int maxWordLength)` with larger values than
255 for `maxWordLength`.
Those
[
https://issues.apache.org/jira/browse/LUCENE-10524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529692#comment-17529692
]
Gautam Worah commented on LUCENE-10524:
---
I've submitted a pretty basic patch. It may be better to
[
https://issues.apache.org/jira/browse/LUCENE-10292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529677#comment-17529677
]
ASF subversion and git services commented on LUCENE-10292:
--
Commit
vigyasharma commented on code in PR #848:
URL: https://github.com/apache/lucene/pull/848#discussion_r861353455
##
lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyFacetAssociations.java:
##
@@ -500,10 +500,7 @@ private void validateFloats(
[
https://issues.apache.org/jira/browse/LUCENE-10292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529676#comment-17529676
]
ASF subversion and git services commented on LUCENE-10292:
--
Commit
gautamworah96 opened a new pull request, #853:
URL: https://github.com/apache/lucene/pull/853
Today, new contributors are usually unaware of where luceneutil benchmarks
are and when/how to run them. Committers usually end up pointing contributors
to the benchmarks package when they make
[
https://issues.apache.org/jira/browse/LUCENE-9476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gautam Worah resolved LUCENE-9476.
--
Resolution: Fixed
The PR was merged into the Lucene 9 branch and released in version Lucene
[
https://issues.apache.org/jira/browse/LUCENE-10292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529668#comment-17529668
]
Chris M. Hostetter commented on LUCENE-10292:
-
{quote} I'm still not sure whether these
Yuti-G commented on PR #843:
URL: https://github.com/apache/lucene/pull/843#issuecomment-1112633027
Hi @gsmiller, thanks for your feedback! Yes, I was proposing keeping the
existing behavior of getTopChildren but utilizing the top-n param, as I thought
it would safe because we would not
gsmiller commented on PR #843:
URL: https://github.com/apache/lucene/pull/843#issuecomment-1112602017
Thanks for all your thoughts @Yuti-G! I think I still disagree with changing
the current behavior. If we want to implement the contract of `getTopChildren`
properly, we'd need to sort by
dweiss commented on PR #850:
URL: https://github.com/apache/lucene/pull/850#issuecomment-1112594924
I ran nightly tests as well, they passed.
BUILD SUCCESSFUL in 24m 6s
832 actionable tasks: 480 executed, 352 up-to-date
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/LUCENE-10088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529611#comment-17529611
]
ASF subversion and git services commented on LUCENE-10088:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529603#comment-17529603
]
ASF subversion and git services commented on LUCENE-10088:
--
Commit
dweiss merged PR #851:
URL: https://github.com/apache/lucene/pull/851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dweiss commented on code in PR #850:
URL: https://github.com/apache/lucene/pull/850#discussion_r861243269
##
lucene/test-framework/src/java/org/apache/lucene/tests/analysis/MockTokenizer.java:
##
@@ -66,11 +67,11 @@ public class MockTokenizer extends Tokenizer {
* Limit the
[
https://issues.apache.org/jira/browse/LUCENE-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nhat Nguyen resolved LUCENE-10518.
--
Fix Version/s: 9.1.1
9.2
Resolution: Fixed
> FieldInfos
[
https://issues.apache.org/jira/browse/LUCENE-10542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529580#comment-17529580
]
Robert Muir commented on LUCENE-10542:
--
Hi [~krisden], I think there might be more optimizations
[
https://issues.apache.org/jira/browse/LUCENE-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529578#comment-17529578
]
ASF subversion and git services commented on LUCENE-10518:
--
Commit
dnhatn merged PR #852:
URL: https://github.com/apache/lucene/pull/852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/LUCENE-10542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated LUCENE-10542:
--
Description:
While looking at LUCENE-10534, found that *FieldSource exists implementation
[
https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529572#comment-17529572
]
Kevin Risden commented on LUCENE-10534:
---
Updated metrics - there is a benefit to the new
dnhatn opened a new pull request, #852:
URL: https://github.com/apache/lucene/pull/852
This change relaxes the field consistency check for old indices as we
didn't enforce that in the previous versions. This commit also disables
the optimization that relies on the field consistency for
[
https://issues.apache.org/jira/browse/LUCENE-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529522#comment-17529522
]
ASF subversion and git services commented on LUCENE-10518:
--
Commit
dnhatn merged PR #842:
URL: https://github.com/apache/lucene/pull/842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dnhatn commented on PR #842:
URL: https://github.com/apache/lucene/pull/842#issuecomment-1112420113
@mayya-sharipova @jpountz Thanks for reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dnhatn commented on code in PR #842:
URL: https://github.com/apache/lucene/pull/842#discussion_r861098734
##
lucene/core/src/java/org/apache/lucene/index/FieldInfos.java:
##
@@ -350,6 +360,11 @@ static final class FieldNumbers {
this.omitNorms = new HashMap<>();
[
https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529513#comment-17529513
]
Kevin Risden commented on LUCENE-10534:
---
I reviewed the jmh tests again and realized I didn't
mocobeta commented on code in PR #850:
URL: https://github.com/apache/lucene/pull/850#discussion_r861050340
##
lucene/test-framework/src/java/org/apache/lucene/tests/analysis/MockTokenizer.java:
##
@@ -66,11 +67,11 @@ public class MockTokenizer extends Tokenizer {
* Limit
uschindler commented on code in PR #850:
URL: https://github.com/apache/lucene/pull/850#discussion_r861032318
##
lucene/test-framework/src/java/org/apache/lucene/tests/analysis/MockTokenizer.java:
##
@@ -66,11 +67,11 @@ public class MockTokenizer extends Tokenizer {
* Limit
mocobeta commented on code in PR #850:
URL: https://github.com/apache/lucene/pull/850#discussion_r861028741
##
lucene/test-framework/src/java/org/apache/lucene/tests/analysis/MockTokenizer.java:
##
@@ -66,11 +67,11 @@ public class MockTokenizer extends Tokenizer {
* Limit
[
https://issues.apache.org/jira/browse/LUCENE-10544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529481#comment-17529481
]
Greg Miller commented on LUCENE-10544:
--
Thanks [~jpountz]. One issue with the collector approach
[
https://issues.apache.org/jira/browse/LUCENE-10544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529470#comment-17529470
]
Adrien Grand commented on LUCENE-10544:
---
I suspect that this is due to the fact that the original
[
https://issues.apache.org/jira/browse/LUCENE-10544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller updated LUCENE-10544:
-
Description:
While looking into options for LUCENE-10151, I noticed that
Greg Miller created LUCENE-10544:
Summary: Should ExitableTermsEnum wrap postings and impacts?
Key: LUCENE-10544
URL: https://issues.apache.org/jira/browse/LUCENE-10544
Project: Lucene - Core
mikemccand commented on PR #663:
URL: https://github.com/apache/lucene/pull/663#issuecomment-1112261833
Thanks @spike-liu -- this looks great to me! I'll leave it open for at
least 48 hours to see if anyone else wants to approve/comment, else lazy
consensus kicks in!
--
This is an
[
https://issues.apache.org/jira/browse/LUCENE-10543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529452#comment-17529452
]
Michael McCandless commented on LUCENE-10543:
-
Also, I love this new "Achieve XYZ
[
https://issues.apache.org/jira/browse/LUCENE-10543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529437#comment-17529437
]
Michael McCandless commented on LUCENE-10543:
-
+1 to work out a migration plan to switch to
gsmiller commented on code in PR #849:
URL: https://github.com/apache/lucene/pull/849#discussion_r860876168
##
lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyFacetAssociations.java:
##
@@ -142,6 +146,34 @@ public static void beforeClass() throws Exception {
gsmiller commented on PR #848:
URL: https://github.com/apache/lucene/pull/848#issuecomment-1112187182
@gautamworah96 thanks for looking! The mismatch in the original Jira was a
slightly different check, which is the one now set to a delta of `0`. The fix
proposed here is to ensure the
[
https://issues.apache.org/jira/browse/LUCENE-10541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529416#comment-17529416
]
Michael McCandless commented on LUCENE-10541:
-
{quote}enwiki lines contains 2 million
mocobeta commented on PR #846:
URL: https://github.com/apache/lucene/pull/846#issuecomment-1112127870
@mikemccand thank you for revewing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jpountz commented on PR #780:
URL: https://github.com/apache/lucene/pull/780#issuecomment-1112127776
Why do you sort the index if you need to sort in both directions? Is it for
range queries? Could you use points instead?
Sorry I don't have good ideas for making it less intrusive.
wjp719 commented on PR #780:
URL: https://github.com/apache/lucene/pull/780#issuecomment-1112123414
@jpountz Ok, tanks. As users ofter need to search on both directions but
index data can only be index sorted by one directions. This situation may be
common for users.
> If you can
jpountz commented on PR #780:
URL: https://github.com/apache/lucene/pull/780#issuecomment-1112113792
If you can find an approach that is less intrusive, maybe I would
reconsider, but it still looks to me like we're adding complexity to work
around a bad user decisions, which doesn't feel
jpountz commented on code in PR #842:
URL: https://github.com/apache/lucene/pull/842#discussion_r860789641
##
lucene/core/src/java/org/apache/lucene/index/FieldInfos.java:
##
@@ -350,6 +360,11 @@ static final class FieldNumbers {
this.omitNorms = new HashMap<>();
[
https://issues.apache.org/jira/browse/LUCENE-10543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529343#comment-17529343
]
Tomoko Uchida commented on LUCENE-10543:
I just found that it looks like {{changes2html.pl}}
[
https://issues.apache.org/jira/browse/LUCENE-10543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529333#comment-17529333
]
Tomoko Uchida commented on LUCENE-10543:
bq. Creating a PR still requires signing up for Apache
uschindler commented on code in PR #851:
URL: https://github.com/apache/lucene/pull/851#discussion_r860662889
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/HandleLimitFS.java:
##
@@ -17,16 +17,38 @@
package org.apache.lucene.tests.mockfile;
import
uschindler commented on code in PR #850:
URL: https://github.com/apache/lucene/pull/850#discussion_r860657767
##
lucene/test-framework/src/java/org/apache/lucene/tests/analysis/MockTokenizer.java:
##
@@ -66,11 +67,11 @@ public class MockTokenizer extends Tokenizer {
* Limit
mocobeta commented on code in PR #850:
URL: https://github.com/apache/lucene/pull/850#discussion_r860642306
##
lucene/test-framework/src/java/org/apache/lucene/tests/analysis/MockTokenizer.java:
##
@@ -66,11 +67,11 @@ public class MockTokenizer extends Tokenizer {
* Limit
mocobeta commented on code in PR #850:
URL: https://github.com/apache/lucene/pull/850#discussion_r860642306
##
lucene/test-framework/src/java/org/apache/lucene/tests/analysis/MockTokenizer.java:
##
@@ -66,11 +67,11 @@ public class MockTokenizer extends Tokenizer {
* Limit
dweiss commented on code in PR #850:
URL: https://github.com/apache/lucene/pull/850#discussion_r860641028
##
lucene/test-framework/src/java/org/apache/lucene/tests/analysis/MockTokenizer.java:
##
@@ -66,11 +67,11 @@ public class MockTokenizer extends Tokenizer {
* Limit the
rmuir commented on code in PR #850:
URL: https://github.com/apache/lucene/pull/850#discussion_r860635303
##
lucene/test-framework/src/java/org/apache/lucene/tests/analysis/MockTokenizer.java:
##
@@ -66,11 +67,11 @@ public class MockTokenizer extends Tokenizer {
* Limit the
rmuir commented on code in PR #850:
URL: https://github.com/apache/lucene/pull/850#discussion_r860631960
##
lucene/test-framework/src/java/org/apache/lucene/tests/analysis/MockTokenizer.java:
##
@@ -66,11 +67,11 @@ public class MockTokenizer extends Tokenizer {
* Limit the
rmuir commented on code in PR #850:
URL: https://github.com/apache/lucene/pull/850#discussion_r860628445
##
lucene/test-framework/src/java/org/apache/lucene/tests/analysis/MockTokenizer.java:
##
@@ -66,11 +67,11 @@ public class MockTokenizer extends Tokenizer {
* Limit the
rmuir commented on code in PR #850:
URL: https://github.com/apache/lucene/pull/850#discussion_r860626938
##
lucene/test-framework/src/java/org/apache/lucene/tests/analysis/MockTokenizer.java:
##
@@ -66,11 +67,11 @@ public class MockTokenizer extends Tokenizer {
* Limit the
dweiss commented on code in PR #850:
URL: https://github.com/apache/lucene/pull/850#discussion_r860625375
##
lucene/test-framework/src/java/org/apache/lucene/tests/analysis/MockTokenizer.java:
##
@@ -66,11 +67,11 @@ public class MockTokenizer extends Tokenizer {
* Limit the
uschindler commented on code in PR #851:
URL: https://github.com/apache/lucene/pull/851#discussion_r860623990
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/HandleLimitFS.java:
##
@@ -17,16 +17,38 @@
package org.apache.lucene.tests.mockfile;
import
uschindler commented on code in PR #850:
URL: https://github.com/apache/lucene/pull/850#discussion_r860622081
##
lucene/test-framework/src/java/org/apache/lucene/tests/analysis/MockTokenizer.java:
##
@@ -66,11 +67,11 @@ public class MockTokenizer extends Tokenizer {
* Limit
rmuir commented on code in PR #851:
URL: https://github.com/apache/lucene/pull/851#discussion_r860621619
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/HandleLimitFS.java:
##
@@ -17,16 +17,38 @@
package org.apache.lucene.tests.mockfile;
import
rmuir commented on code in PR #851:
URL: https://github.com/apache/lucene/pull/851#discussion_r860619792
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/HandleLimitFS.java:
##
@@ -17,16 +17,38 @@
package org.apache.lucene.tests.mockfile;
import
uschindler commented on code in PR #851:
URL: https://github.com/apache/lucene/pull/851#discussion_r860618388
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/HandleLimitFS.java:
##
@@ -17,16 +17,38 @@
package org.apache.lucene.tests.mockfile;
import
dweiss commented on code in PR #851:
URL: https://github.com/apache/lucene/pull/851#discussion_r860616950
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/HandleLimitFS.java:
##
@@ -17,16 +17,38 @@
package org.apache.lucene.tests.mockfile;
import
uschindler commented on code in PR #851:
URL: https://github.com/apache/lucene/pull/851#discussion_r860615990
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/HandleLimitFS.java:
##
@@ -17,16 +17,38 @@
package org.apache.lucene.tests.mockfile;
import
uschindler commented on code in PR #851:
URL: https://github.com/apache/lucene/pull/851#discussion_r860615393
##
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/HandleLimitFS.java:
##
@@ -17,16 +17,38 @@
package org.apache.lucene.tests.mockfile;
import
[
https://issues.apache.org/jira/browse/LUCENE-10541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529286#comment-17529286
]
Uwe Schindler commented on LUCENE-10541:
I think another option might be to use
uschindler commented on PR #850:
URL: https://github.com/apache/lucene/pull/850#issuecomment-877517
Maybe we should set the limit to the maximum term size. This would allow us
to test also longer terms.
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/LUCENE-10543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529270#comment-17529270
]
Robert Muir commented on LUCENE-10543:
--
It was entirely too difficult to find the issue! I knew it
[
https://issues.apache.org/jira/browse/LUCENE-9871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529263#comment-17529263
]
Robert Muir commented on LUCENE-9871:
-
just a reminder, haven't forgot about java version
[
https://issues.apache.org/jira/browse/LUCENE-10541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529261#comment-17529261
]
Dawid Weiss commented on LUCENE-10541:
--
Filed a PR at https://github.com/apache/lucene/pull/850.
[
https://issues.apache.org/jira/browse/LUCENE-10543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529255#comment-17529255
]
Dawid Weiss commented on LUCENE-10543:
--
("with progress"... yeah, that's why LUCENE-9871 is still
[
https://issues.apache.org/jira/browse/LUCENE-10543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529245#comment-17529245
]
Robert Muir commented on LUCENE-10543:
--
Believe it or not, there's actually no "link" to the
[
https://issues.apache.org/jira/browse/LUCENE-10543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529240#comment-17529240
]
Robert Muir commented on LUCENE-10543:
--
another idea, add a simple "fork me on github" to the
[
https://issues.apache.org/jira/browse/LUCENE-10543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529236#comment-17529236
]
Robert Muir commented on LUCENE-10543:
--
another idea is to use github wiki functionality vs the
Robert Muir created LUCENE-10543:
Summary: Achieve contribution workflow perfection (with progress)
Key: LUCENE-10543
URL: https://issues.apache.org/jira/browse/LUCENE-10543
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-10292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529223#comment-17529223
]
Dawid Weiss commented on LUCENE-10292:
--
Thanks Chris. I'm still not sure whether these tests make
[
https://issues.apache.org/jira/browse/LUCENE-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529218#comment-17529218
]
Dawid Weiss commented on LUCENE-10531:
--
Fine with me.
> Mark testLukeCanBeLaunched @Nightly test
dweiss commented on code in PR #844:
URL: https://github.com/apache/lucene/pull/844#discussion_r860523184
##
lucene/suggest/src/java/org/apache/lucene/search/suggest/fst/FSTCompletion.java:
##
@@ -184,110 +195,174 @@ public List lookup(CharSequence key, int
num) {
97 matches
Mail list logo
