[jira] [Commented] (SOLR-14472) Autoscaling "cores" preference should count all cores, not just loaded.

2020-05-11 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104913#comment-17104913 ] David Smiley commented on SOLR-14472: - PR: [https://github.com/apache/lucene-solr/pull/1508] CC

[jira] [Commented] (SOLR-13289) Support for BlockMax WAND

2020-05-11 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104768#comment-17104768 ] David Smiley commented on SOLR-13289: - Tomas, while you are modifying getDocListNC, can you consider

[jira] [Commented] (SOLR-13289) Support for BlockMax WAND

2020-05-11 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104757#comment-17104757 ] David Smiley commented on SOLR-13289: - I agree with Ishan on not enabling this by default.  Maybe

[jira] [Commented] (SOLR-13289) Support for BlockMax WAND

2020-05-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103601#comment-17103601 ] David Smiley commented on SOLR-13289: - Should we really add {{numFoundExact="true"}} on responses

[jira] [Commented] (SOLR-14426) forbidden api error during precommit DateMathFunction

2020-05-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103452#comment-17103452 ] David Smiley commented on SOLR-14426: - Moving these classes to within another class disturbed the API

[jira] [Commented] (SOLR-11934) Visit Solr logging, it's too noisy.

2020-05-07 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102019#comment-17102019 ] David Smiley commented on SOLR-11934: - {quote}The one in SolrCore comes after autowarming and can

[jira] [Commented] (SOLR-8394) Luke handler doesn't support FilterLeafReader

2020-05-07 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101984#comment-17101984 ] David Smiley commented on SOLR-8394: I reworked it and submitted a PR. [~ab], you may be interested.

[jira] [Commented] (SOLR-11934) Visit Solr logging, it's too noisy.

2020-05-07 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101692#comment-17101692 ] David Smiley commented on SOLR-11934: - Ugh. Trade-offs. I really value LogUpdateProcessorFactory; I

[jira] [Commented] (SOLR-13612) Error 500 with update extract handler on Solr 7.4.0

2020-05-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101398#comment-17101398 ] David Smiley commented on SOLR-13612: - This may or may not be an issue after SOLR-14461; please try

[jira] [Assigned] (SOLR-12320) Not all multi-part post requests should create tmp files.

2020-05-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley reassigned SOLR-12320: --- Assignee: David Smiley (was: Mark Miller) > Not all multi-part post requests should create

[jira] [Commented] (SOLR-12320) Not all multi-part post requests should create tmp files.

2020-05-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101394#comment-17101394 ] David Smiley commented on SOLR-12320: - I just worked on SOLR-14461 to stop using commons-fileupload

[jira] [Commented] (SOLR-14461) Replace commons-fileupload use with standard Servlet/Jetty

2020-05-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101389#comment-17101389 ] David Smiley commented on SOLR-14461: - BTW It was not my intention to push the feature branch here; I

[jira] [Commented] (SOLR-11934) Visit Solr logging, it's too noisy.

2020-05-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101220#comment-17101220 ] David Smiley commented on SOLR-11934: - Fair point about metrics; no need to log the particular

[jira] [Created] (SOLR-14461) Replace commons-fileupload use with standard Servlet/Jetty

2020-05-06 Thread David Smiley (Jira)
David Smiley created SOLR-14461: --- Summary: Replace commons-fileupload use with standard Servlet/Jetty Key: SOLR-14461 URL: https://issues.apache.org/jira/browse/SOLR-14461 Project: Solr Issue

[jira] [Commented] (SOLR-11934) Visit Solr logging, it's too noisy.

2020-05-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101127#comment-17101127 ] David Smiley commented on SOLR-11934: - The asterisked ones to remove seem mostly reasonable at a

[jira] [Commented] (SOLR-12386) Test fails for "Can't find resource" for files in the _default configset

2020-05-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100807#comment-17100807 ] David Smiley commented on SOLR-12386: - For the case of an incomplete configSet (i.e. one that didn't

[jira] [Commented] (SOLR-14425) Fix ZK sync usage to be synchronous (blocking)

2020-05-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100795#comment-17100795 ] David Smiley commented on SOLR-14425: - ZK sync enqueues a sync into a communication channel and

[jira] [Commented] (SOLR-14454) support for UTF-8 (string) types with DocValuesType.BINARY

2020-05-05 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100284#comment-17100284 ] David Smiley commented on SOLR-14454: - I just took a look at both -- my old patch and what you've

[jira] [Resolved] (SOLR-14425) Fix ZK sync usage to be synchronous (blocking)

2020-05-05 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-14425. - Resolution: Not A Problem Not actually a problem; it was my misunderstanding. > Fix ZK sync

[jira] [Commented] (SOLR-14454) support for UTF-8 (string) types with DocValuesType.BINARY

2020-05-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098625#comment-17098625 ] David Smiley commented on SOLR-14454: - Please see SOLR-10255 which I worked on years ago which seems

[jira] [Commented] (SOLR-14454) support for UTF-8 (string) types with DocValuesType.BINARY

2020-05-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098622#comment-17098622 ] David Smiley commented on SOLR-14454: - The first two seem promising but I don't think the 3rd

[jira] [Commented] (SOLR-14351) Harden MDCLoggingContext.clear depth tracking

2020-05-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098250#comment-17098250 ] David Smiley commented on SOLR-14351: - Looks like I goofed in ZkContainer.java in which I removed the

[jira] [Resolved] (SOLR-14453) Solr proximity search highlighting issue

2020-05-02 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-14453. - Resolution: Won't Fix I think this is probably a bug or limitation in the underlying SpanQuery

[jira] [Commented] (SOLR-13289) Support for BlockMax WAND

2020-05-01 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097689#comment-17097689 ] David Smiley commented on SOLR-13289: - Yeah; lets just go with a simple-to-understand boolean. Even

[jira] [Commented] (SOLR-14453) Solr proximity search highlighting issue

2020-05-01 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097346#comment-17097346 ] David Smiley commented on SOLR-14453: - Try hl.method=unified > Solr proximity search highlighting

[jira] [Commented] (SOLR-13292) Provide extended per-segment status of a collection

2020-04-30 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097141#comment-17097141 ] David Smiley commented on SOLR-13292: - This issue creates a new SolrClientCache instance on

[jira] [Commented] (SOLR-14452) "classloading deadlock" issue with DocSet/SortedIntDocSet

2020-04-30 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097138#comment-17097138 ] David Smiley commented on SOLR-14452: - I think your master branch is out of date. March 17th in

[jira] [Commented] (SOLR-14437) Remove/refactor "ApiSupport" interface? (for V2 API)

2020-04-30 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097137#comment-17097137 ] David Smiley commented on SOLR-14437: - bq. can you explain a bit more on the getApis() Put simply,

[jira] [Commented] (SOLR-13289) Support for BlockMax WAND

2020-04-29 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095935#comment-17095935 ] David Smiley commented on SOLR-13289: - I think “precision” in there is easier to understand and does

[jira] [Commented] (SOLR-14446) Upload configset should use ZkClient.multi()

2020-04-29 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095850#comment-17095850 ] David Smiley commented on SOLR-14446: - Yes, this would be helpful. We shouldn't just address this

[jira] [Updated] (LUCENE-9087) Should the BKD tree use a fixed maxPointsInLeafNode?

2020-04-28 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated LUCENE-9087: - Description: Currently the BKD tree uses a fixed maxPointsInLeafNode provided in the

[jira] [Resolved] (SOLR-14433) Improve default metrics collected by SolrShardReporter

2020-04-27 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-14433. - Fix Version/s: 8.6 Resolution: Fixed > Improve default metrics collected by

[jira] [Commented] (SOLR-14428) FuzzyQuery has severe memory usage in 8.5

2020-04-27 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093979#comment-17093979 ] David Smiley commented on SOLR-14428: - BTW This issue should probably be a Lucene JIRA issue but

[jira] [Commented] (SOLR-14173) Ref Guide Redesign

2020-04-27 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093956#comment-17093956 ] David Smiley commented on SOLR-14173: - You could share on the user-list to get more input. > Ref

[jira] [Closed] (SOLR-12706) CloudSolrClient NPE exception when NOT directUpdatesToLeadersOnly

2020-04-26 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley closed SOLR-12706. --- > CloudSolrClient NPE exception when NOT directUpdatesToLeadersOnly >

[jira] [Resolved] (SOLR-12706) CloudSolrClient NPE exception when NOT directUpdatesToLeadersOnly

2020-04-26 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-12706. - Resolution: Cannot Reproduce Seems to be a non-issue now. I search for buildUrlMap in my mail

[jira] [Commented] (SOLR-13138) Remove deprecated code in master

2020-04-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092515#comment-17092515 ] David Smiley commented on SOLR-13138: - I did merge it and fixed things up so that tests pass. Come

[jira] [Commented] (LUCENE-8638) Remove deprecated code in master

2020-04-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092514#comment-17092514 ] David Smiley commented on LUCENE-8638: -- I fixed up the branch a lot; mostly Solr but I'll leave

[jira] [Commented] (LUCENE-9255) ValueSource Has Generic Typing Issues

2020-04-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092492#comment-17092492 ] David Smiley commented on LUCENE-9255: -- Agreed [~romseygeek]. But Solr's use of something

[jira] [Commented] (SOLR-1302) Fun with Distances - Add Distance functions for a variety of things

2020-04-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092490#comment-17092490 ] David Smiley commented on SOLR-1302: Notice:  This (old) issue introduced {{ghhsin()}} and

[jira] [Created] (SOLR-14437) Remove/refactor "ApiSupport" interface? (for V2 API)

2020-04-24 Thread David Smiley (Jira)
David Smiley created SOLR-14437: --- Summary: Remove/refactor "ApiSupport" interface? (for V2 API) Key: SOLR-14437 URL: https://issues.apache.org/jira/browse/SOLR-14437 Project: Solr Issue Type:

[jira] [Commented] (SOLR-14423) static caches in StreamHandler ought to move to CoreContainer lifecycle

2020-04-23 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091198#comment-17091198 ] David Smiley commented on SOLR-14423: - Great feedback AB. I agree on the dependency injection

[jira] [Updated] (SOLR-14433) Improve default metrics collected by SolrShardReporter

2020-04-23 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-14433: Description: SolrShardReporter's default metric filters have two problems: * "Tlog.\*" should be

[jira] [Created] (SOLR-14433) Improve default metrics collected by SolrShardReporter

2020-04-23 Thread David Smiley (Jira)
David Smiley created SOLR-14433: --- Summary: Improve default metrics collected by SolrShardReporter Key: SOLR-14433 URL: https://issues.apache.org/jira/browse/SOLR-14433 Project: Solr Issue

[jira] [Commented] (SOLR-12690) Regularize LoggerFactory declarations

2020-04-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090250#comment-17090250 ] David Smiley commented on SOLR-12690: - [~erickerickson] looks like you goofed in SolrShardReporter

[jira] [Commented] (LUCENE-9324) Give IDs to SegmentCommitInfo

2020-04-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089975#comment-17089975 ] David Smiley commented on LUCENE-9324: -- I really appreciate that explanation Simon; thanks! > Give

[jira] [Commented] (SOLR-8394) Luke handler doesn't support FilterLeafReader

2020-04-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089964#comment-17089964 ] David Smiley commented on SOLR-8394: Looks pretty good, but I'd like to see you improve the code

[jira] [Commented] (LUCENE-9334) Require consistency between data-structures on a per-field basis

2020-04-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089935#comment-17089935 ] David Smiley commented on LUCENE-9334: -- The scope of this seems to subsume LUCENE-9078, so I'm

[jira] [Commented] (SOLR-12386) Test fails for "Can't find resource" for files in the _default configset

2020-04-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089813#comment-17089813 ] David Smiley commented on SOLR-12386: - I think I know what the problem is: We're not taking care to

[jira] [Commented] (SOLR-14425) Fix ZK sync usage to be synchronous (blocking)

2020-04-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089777#comment-17089777 ] David Smiley commented on SOLR-14425: - Odd; no link from GH so here it is:

[jira] [Created] (SOLR-14425) Fix ZK sync usage to be synchronous (blocking)

2020-04-22 Thread David Smiley (Jira)
David Smiley created SOLR-14425: --- Summary: Fix ZK sync usage to be synchronous (blocking) Key: SOLR-14425 URL: https://issues.apache.org/jira/browse/SOLR-14425 Project: Solr Issue Type: Bug

[jira] [Commented] (SOLR-14423) static caches in StreamHandler ought to move to CoreContainer lifecycle

2020-04-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089726#comment-17089726 ] David Smiley commented on SOLR-14423: - Interesting; I've never seen/heard of {{SolrCloudManager}}

[jira] [Commented] (SOLR-14414) New Admin UI

2020-04-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089170#comment-17089170 ] David Smiley commented on SOLR-14414: - For the record I'm not against this new UI being developed

[jira] [Created] (SOLR-14424) RequestHandler with startup=lazy can't implement SolrCoreAware

2020-04-21 Thread David Smiley (Jira)
David Smiley created SOLR-14424: --- Summary: RequestHandler with startup=lazy can't implement SolrCoreAware Key: SOLR-14424 URL: https://issues.apache.org/jira/browse/SOLR-14424 Project: Solr

[jira] [Commented] (SOLR-14423) static caches in StreamHandler ought to move to CoreContainer lifecycle

2020-04-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089049#comment-17089049 ] David Smiley commented on SOLR-14423: - I propose we add a general purpose enhancement to

[jira] [Created] (SOLR-14423) static caches in StreamHandler ought to move to CoreContainer lifecycle

2020-04-21 Thread David Smiley (Jira)
David Smiley created SOLR-14423: --- Summary: static caches in StreamHandler ought to move to CoreContainer lifecycle Key: SOLR-14423 URL: https://issues.apache.org/jira/browse/SOLR-14423 Project: Solr

[jira] [Commented] (SOLR-14420) Address AuthenticationPlugin TODO redeclare params as HttpServletRequest & HttpServletResponse

2020-04-20 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088197#comment-17088197 ] David Smiley commented on SOLR-14420: - +1 looks good Mike. Thanks for doing this. > Address

[jira] [Updated] (SOLR-14418) MetricsHistoryHandler: don't query .system collection

2020-04-20 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-14418: Description: The MetricsHistoryHandler queries the .system collection on startup with a

[jira] [Created] (SOLR-14418) MetricsHistoryHandler: don't query .system collection

2020-04-20 Thread David Smiley (Jira)
David Smiley created SOLR-14418: --- Summary: MetricsHistoryHandler: don't query .system collection Key: SOLR-14418 URL: https://issues.apache.org/jira/browse/SOLR-14418 Project: Solr Issue Type:

[jira] [Commented] (SOLR-13030) MetricsHistoryHandler appears to never be "close()ed" - causes thread leaks?

2020-04-20 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088133#comment-17088133 ] David Smiley commented on SOLR-13030: - Shouldn't this be Closed for 8.0? > MetricsHistoryHandler

[jira] [Created] (SOLR-14417) Gradle build sometimes fails RE BlockPoolSlice

2020-04-20 Thread David Smiley (Jira)
David Smiley created SOLR-14417: --- Summary: Gradle build sometimes fails RE BlockPoolSlice Key: SOLR-14417 URL: https://issues.apache.org/jira/browse/SOLR-14417 Project: Solr Issue Type: Task

[jira] [Commented] (LUCENE-9280) Add ability to skip non-competitive documents on field sort

2020-04-20 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087772#comment-17087772 ] David Smiley commented on LUCENE-9280: -- Cool! > Add ability to skip non-competitive documents on

[jira] [Commented] (SOLR-14391) Remove getDocSet's manual doc collection logic; remove ScoreFilter

2020-04-18 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086744#comment-17086744 ] David Smiley commented on SOLR-14391: - I confess I did not Shalin. My objective is to remove

[jira] [Resolved] (SOLR-14391) Remove getDocSet's manual doc collection logic; remove ScoreFilter

2020-04-18 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-14391. - Fix Version/s: 8.6 Resolution: Fixed > Remove getDocSet's manual doc collection logic;

[jira] [Commented] (SOLR-14275) Policy calculations are very slow for large clusters and large operations

2020-04-16 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085191#comment-17085191 ] David Smiley commented on SOLR-14275: - [~noble.paul] I recall from a slack message a few weeks ago

[jira] [Commented] (LUCENE-7788) fail precommit on unparameterised log messages and examine for wasted work/objects

2020-04-15 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084424#comment-17084424 ] David Smiley commented on LUCENE-7788: -- Can we skip this for info, warn & error please? These are

[jira] [Commented] (LUCENE-9316) Incorporate all :precommit tasks into :check

2020-04-15 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084410#comment-17084410 ] David Smiley commented on LUCENE-9316: -- Yay! So should I basically assume that {{gradlew check -x

[jira] [Commented] (SOLR-13138) Remove deprecated code in master

2020-04-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083789#comment-17083789 ] David Smiley commented on SOLR-13138: - I'll merge it then. I'll resume this no sooner than this

[jira] [Commented] (LUCENE-7788) fail precommit on unparameterised log messages and examine for wasted work/objects

2020-04-13 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082832#comment-17082832 ] David Smiley commented on LUCENE-7788: -- Lets spare Lucene builds from the overhead given how rare

[jira] [Commented] (SOLR-13138) Remove deprecated code in master

2020-04-13 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082506#comment-17082506 ] David Smiley commented on SOLR-13138: - [~romseygeek] this branch is rather out of date with master

[jira] [Resolved] (SOLR-14396) TaggerRequestHandler Should Not Error on Empty Collection

2020-04-12 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-14396. - Fix Version/s: 8.6 Assignee: David Smiley Resolution: Fixed >

[jira] [Commented] (LUCENE-7788) fail precommit on unparameterised log.trace messages

2020-04-12 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081966#comment-17081966 ] David Smiley commented on LUCENE-7788: -- +0 I'm not plus one because I'm skeptical the problem is

[jira] [Commented] (LUCENE-9077) Gradle build

2020-04-12 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081936#comment-17081936 ] David Smiley commented on LUCENE-9077: -- Thanks Dawid! I tried it out and it'll probably work well

[jira] [Commented] (SOLR-9909) Nuke one of DefaultSolrThreadFactory and SolrjNamedThreadFactory

2020-04-12 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081655#comment-17081655 ] David Smiley commented on SOLR-9909: Cool; thanks. > Nuke one of DefaultSolrThreadFactory and

[jira] [Commented] (SOLR-9909) Nuke one of DefaultSolrThreadFactory and SolrjNamedThreadFactory

2020-04-10 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081134#comment-17081134 ] David Smiley commented on SOLR-9909: +1 I don't love the name "SolrjNamedThreadFactory" for the 'j' in

[jira] [Updated] (LUCENE-9315) redefine (Classic & Standard) QueryParser semantics to be consistent: prioritize prefix op > infix op > default op

2020-04-10 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated LUCENE-9315: - Summary: redefine (Classic & Standard) QueryParser semantics to be consistent: prioritize

[jira] [Commented] (LUCENE-9315) redfine (Classi & Standard) QueryParser semantics to be consistent: prioritize prefix op > infix op > default op

2020-04-10 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081105#comment-17081105 ] David Smiley commented on LUCENE-9315: -- +1 and you rock! > redfine (Classi & Standard) QueryParser

[jira] [Commented] (SOLR-14382) delegating search component

2020-04-10 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081057#comment-17081057 ] David Smiley commented on SOLR-14382: - Ehh; I'm kinda skeptical on the value it brings to add to

[jira] [Resolved] (SOLR-14325) Core status could be improved to not require an IndexSearcher

2020-04-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-14325. - Resolution: Won't Fix [~GoodmanR] in essence, instead of asking core status for indexInfo which

[jira] [Resolved] (SOLR-14385) Add shard name and collection name to split histogram logs

2020-04-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-14385. - Resolution: Not A Problem > Add shard name and collection name to split histogram logs >

[jira] [Closed] (SOLR-14385) Add shard name and collection name to split histogram logs

2020-04-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley closed SOLR-14385. --- > Add shard name and collection name to split histogram logs >

[jira] [Commented] (SOLR-14394) Many request handlers should be startup=lazy

2020-04-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079455#comment-17079455 ] David Smiley commented on SOLR-14394: - The core load latency savings is admittedly small; seems

[jira] [Created] (SOLR-14401) "distrib" request handler metrics should only be tracked on pertinent handlers

2020-04-09 Thread David Smiley (Jira)
David Smiley created SOLR-14401: --- Summary: "distrib" request handler metrics should only be tracked on pertinent handlers Key: SOLR-14401 URL: https://issues.apache.org/jira/browse/SOLR-14401 Project:

[jira] [Commented] (SOLR-14396) TaggerRequestHandler Should Not Error on Empty Collection

2020-04-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078868#comment-17078868 ] David Smiley commented on SOLR-14396: - Ah; skip the header. That could be its own issue for another

[jira] [Closed] (LUCENE-4048) Move getLines out of ResourceLoader and require Charset

2020-04-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley closed LUCENE-4048. > Move getLines out of ResourceLoader and require Charset >

[jira] [Resolved] (LUCENE-4048) Move getLines out of ResourceLoader and require Charset

2020-04-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved LUCENE-4048. -- Fix Version/s: 4.0-BETA Resolution: Duplicate > Move getLines out of ResourceLoader

[jira] [Commented] (SOLR-12005) Solr should have the option of logging all jars loaded

2020-04-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078704#comment-17078704 ] David Smiley commented on SOLR-12005: - Instead of looking for logging as the tool for this need, we

[jira] [Commented] (SOLR-8773) Make blob store usage intuitive and robust

2020-04-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078701#comment-17078701 ] David Smiley commented on SOLR-8773: [~noble.paul] I suppose all this might be Won't-Fix given the

[jira] [Commented] (SOLR-14396) TaggerRequestHandler Should Not Error on Empty Collection

2020-04-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078602#comment-17078602 ] David Smiley commented on SOLR-14396: - Woah; I think it's bad this throws an exception on an empty

[jira] [Commented] (SOLR-13979) Expose separate metrics for distributed and non-distributed requests

2020-04-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078489#comment-17078489 ] David Smiley commented on SOLR-13979: - Also, distributed search long predated SolrCloud so why should

[jira] [Commented] (SOLR-13979) Expose separate metrics for distributed and non-distributed requests

2020-04-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078488#comment-17078488 ] David Smiley commented on SOLR-13979: - bq. These metrics are added to all handlers that inherit from

[jira] [Commented] (SOLR-14394) Many request handlers should be startup=lazy

2020-04-07 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077591#comment-17077591 ] David Smiley commented on SOLR-14394: - When I investigated this last week and ran tests, I found a

[jira] [Created] (SOLR-14394) Many request handlers should be startup=lazy

2020-04-07 Thread David Smiley (Jira)
David Smiley created SOLR-14394: --- Summary: Many request handlers should be startup=lazy Key: SOLR-14394 URL: https://issues.apache.org/jira/browse/SOLR-14394 Project: Solr Issue Type:

[jira] [Resolved] (LUCENE-8050) PerFieldDocValuesFormat's merge should not grab field DVF if DocValuesType.NONE

2020-04-07 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved LUCENE-8050. -- Resolution: Fixed > PerFieldDocValuesFormat's merge should not grab field DVF if >

[jira] [Commented] (SOLR-14391) Remove getDocSet's manual doc collection logic; remove ScoreFilter

2020-04-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076444#comment-17076444 ] David Smiley commented on SOLR-14391: - SOLR-5416 introduced ScoreFilter. I'm really displeased by

[jira] [Created] (SOLR-14391) Remove getDocSet's manual doc collection logic; remove ScoreFilter

2020-04-06 Thread David Smiley (Jira)
David Smiley created SOLR-14391: --- Summary: Remove getDocSet's manual doc collection logic; remove ScoreFilter Key: SOLR-14391 URL: https://issues.apache.org/jira/browse/SOLR-14391 Project: Solr

[jira] [Updated] (LUCENE-8050) PerFieldDocValuesFormat's merge should not grab field DVF if DocValuesType.NONE

2020-04-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated LUCENE-8050: - Fix Version/s: 8.6 Priority: Minor (was: Major) Thanks Juan! I'll merge tomorrow. >

[jira] [Commented] (SOLR-14385) Add shard name and collection name to split histogram logs

2020-04-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17075251#comment-17075251 ] David Smiley commented on SOLR-14385: - BTW be sure to see MDCLoggingContext. I suspect the

[jira] [Closed] (SOLR-7699) Clean up too verbose code in SOLR-7590.

2020-04-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley closed SOLR-7699. -- Assignee: David Smiley (was: Mark Miller) > Clean up too verbose code in SOLR-7590. >

[jira] [Resolved] (SOLR-7699) Clean up too verbose code in SOLR-7590.

2020-04-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-7699. Resolution: Fixed Closing; a trivial thing did in linked issue. The issue title here is terrible,

<    3   4   5   6   7   8   9   10   11   12   >