[jira] [Created] (LUCENE-10168) drop support for 7.0 indexes in 9.0 (master)

2021-10-12 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10168: Summary: drop support for 7.0 indexes in 9.0 (master) Key: LUCENE-10168 URL: https://issues.apache.org/jira/browse/LUCENE-10168 Project: Lucene - Core Issue

[jira] [Commented] (LUCENE-9997) Revisit smoketester for 9.0 build

2021-10-12 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427643#comment-17427643 ] Robert Muir commented on LUCENE-9997: - yes, slowest tests are in backwards, the backwards tests are

[jira] [Commented] (LUCENE-9997) Revisit smoketester for 9.0 build

2021-10-12 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427612#comment-17427612 ] Robert Muir commented on LUCENE-9997: - I'm not knowledgeable on the limits but on my 2-core laptop

[jira] [Commented] (LUCENE-10159) Index corruption: IndexOutOfBoundsException for doc values

2021-10-11 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427352#comment-17427352 ] Robert Muir commented on LUCENE-10159: -- Is there any chance to reproduce the original (presumably

[jira] [Commented] (LUCENE-9997) Revisit smoketester for 9.0 build

2021-10-11 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427342#comment-17427342 ] Robert Muir commented on LUCENE-9997: - Some history: originally we had no smoketester. Every

[jira] [Updated] (LUCENE-10164) lucene/replicator should only have jetty as a test dependency

2021-10-11 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10164: - Fix Version/s: main (9.0) > lucene/replicator should only have jetty as a test dependency >

[jira] [Resolved] (LUCENE-10164) lucene/replicator should only have jetty as a test dependency

2021-10-11 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-10164. -- Resolution: Fixed It was like this before with the ant build, so it was no regression with

[jira] [Commented] (LUCENE-10093) TestTieredMergePolicy.testForcedMergesUseLeastNumberOfMerges test failure

2021-10-11 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427117#comment-17427117 ] Robert Muir commented on LUCENE-10093: -- I feel like the code is correct and the test is buggy

[jira] [Created] (LUCENE-10164) lucene/replicator should only have jetty as a test dependency

2021-10-11 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10164: Summary: lucene/replicator should only have jetty as a test dependency Key: LUCENE-10164 URL: https://issues.apache.org/jira/browse/LUCENE-10164 Project: Lucene -

[jira] [Commented] (LUCENE-10162) Add IntField, LongField, FloatField and DoubleField classes to index both points and doc values

2021-10-11 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427017#comment-17427017 ] Robert Muir commented on LUCENE-10162: -- +1 > Add IntField, LongField, FloatField and DoubleField

[jira] [Resolved] (LUCENE-10155) Refactor TestMultiMMap into a BaseChunkedDirectoryTestCase

2021-10-09 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-10155. -- Fix Version/s: main (9.0) Resolution: Fixed > Refactor TestMultiMMap into a

[jira] [Resolved] (LUCENE-10150) ByteBuffersDataInput should override readLongs?

2021-10-09 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-10150. -- Fix Version/s: main (9.0) Resolution: Fixed > ByteBuffersDataInput should override

[jira] [Created] (LUCENE-10160) TestTieredMergePolicy reproducible failure

2021-10-09 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10160: Summary: TestTieredMergePolicy reproducible failure Key: LUCENE-10160 URL: https://issues.apache.org/jira/browse/LUCENE-10160 Project: Lucene - Core Issue

[jira] [Commented] (LUCENE-10150) ByteBuffersDataInput should override readLongs?

2021-10-06 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17425230#comment-17425230 ] Robert Muir commented on LUCENE-10150: -- Sorry about above typo on the issue number. Ignore that

[jira] [Resolved] (LUCENE-10149) ByteBuffersDataInput should override readShort/Int/Long

2021-10-06 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-10149. -- Resolution: Fixed Committed in ba75dc5e6bf7e90b8c40906ba8ca7b258a5b39c0 (sorry about typo

[jira] [Commented] (LUCENE-10149) ByteBuffersDataInput should override readShort/Int/Long

2021-10-06 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17425208#comment-17425208 ] Robert Muir commented on LUCENE-10149: -- OK i investigated improving the testing, it is possible,

[jira] [Created] (LUCENE-10155) Refactor TestMultiMMap into a BaseChunkedDirectoryTestCase

2021-10-06 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10155: Summary: Refactor TestMultiMMap into a BaseChunkedDirectoryTestCase Key: LUCENE-10155 URL: https://issues.apache.org/jira/browse/LUCENE-10155 Project: Lucene - Core

[jira] [Commented] (LUCENE-10149) ByteBuffersDataInput should override readShort/Int/Long

2021-10-05 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424651#comment-17424651 ] Robert Muir commented on LUCENE-10149: -- I looked at the BaseDirectoryTestCase + subclass. It looks

[jira] [Commented] (LUCENE-10149) ByteBuffersDataInput should override readShort/Int/Long

2021-10-05 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424636#comment-17424636 ] Robert Muir commented on LUCENE-10149: -- I ran tests again with {{gradle coverage}} and it looks

[jira] [Updated] (LUCENE-10149) ByteBuffersDataInput should override readShort/Int/Long

2021-10-05 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10149: - Attachment: Screen_Shot_2021-10-05_at_14.05.42.png > ByteBuffersDataInput should override

[jira] [Commented] (LUCENE-10148) Fix DataInput/Output javadocs, MIGRATE.txt to document endianness

2021-10-05 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424585#comment-17424585 ] Robert Muir commented on LUCENE-10148: -- commit was

[jira] [Resolved] (LUCENE-10148) Fix DataInput/Output javadocs, MIGRATE.txt to document endianness

2021-10-05 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-10148. -- Fix Version/s: main (9.0) Resolution: Fixed > Fix DataInput/Output javadocs,

[jira] [Commented] (LUCENE-10149) ByteBuffersDataInput should override readShort/Int/Long

2021-10-05 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424523#comment-17424523 ] Robert Muir commented on LUCENE-10149: -- Well it internally "casts" the buffers in the constructor.

[jira] [Commented] (LUCENE-10148) Fix DataInput/Output javadocs, MIGRATE.txt to document endianness

2021-10-05 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424503#comment-17424503 ] Robert Muir commented on LUCENE-10148: -- updated patch. I agree it is better with some "inlined"

[jira] [Updated] (LUCENE-10148) Fix DataInput/Output javadocs, MIGRATE.txt to document endianness

2021-10-05 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10148: - Attachment: LUCENE-10148.patch > Fix DataInput/Output javadocs, MIGRATE.txt to document

[jira] [Commented] (LUCENE-10149) ByteBuffersDataInput should override readShort/Int/Long

2021-10-05 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424465#comment-17424465 ] Robert Muir commented on LUCENE-10149: -- {quote} Dawid's hint in the other issue is IMHO not

[jira] [Created] (LUCENE-10150) ByteBuffersDataInput should override readLongs?

2021-10-05 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10150: Summary: ByteBuffersDataInput should override readLongs? Key: LUCENE-10150 URL: https://issues.apache.org/jira/browse/LUCENE-10150 Project: Lucene - Core

[jira] [Commented] (LUCENE-10149) ByteBuffersDataInput should override readShort/Int/Long

2021-10-05 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424463#comment-17424463 ] Robert Muir commented on LUCENE-10149: -- I will open up a separate issue for the readLongs() "with

[jira] [Commented] (LUCENE-10149) ByteBuffersDataInput should override readShort/Int/Long

2021-10-05 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424453#comment-17424453 ] Robert Muir commented on LUCENE-10149: -- These are fashioned to look consistent with the positional

[jira] [Updated] (LUCENE-10149) ByteBuffersDataInput should override readShort/Int/Long

2021-10-05 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10149: - Attachment: LUCENE-10149.patch > ByteBuffersDataInput should override readShort/Int/Long >

[jira] [Created] (LUCENE-10149) ByteBuffersDataInput should override readShort/Int/Long

2021-10-05 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10149: Summary: ByteBuffersDataInput should override readShort/Int/Long Key: LUCENE-10149 URL: https://issues.apache.org/jira/browse/LUCENE-10149 Project: Lucene - Core

[jira] [Updated] (LUCENE-10148) Fix DataInput/Output javadocs, MIGRATE.txt to document endianness

2021-10-05 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10148: - Attachment: LUCENE-10148.patch > Fix DataInput/Output javadocs, MIGRATE.txt to document

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

2021-10-05 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424426#comment-17424426 ] Robert Muir commented on LUCENE-10143: -- I opened LUCENE-10148 to improve the documentation on the

[jira] [Created] (LUCENE-10148) Fix DataInput/Output javadocs, MIGRATE.txt to document endianness

2021-10-05 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10148: Summary: Fix DataInput/Output javadocs, MIGRATE.txt to document endianness Key: LUCENE-10148 URL: https://issues.apache.org/jira/browse/LUCENE-10148 Project: Lucene

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

2021-10-05 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424387#comment-17424387 ] Robert Muir commented on LUCENE-10143: -- I don't think we should make these interfaces. We

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

2021-10-04 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424121#comment-17424121 ] Robert Muir commented on LUCENE-10143: -- I also think the DataInput vs IndexInput causes more

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

2021-10-04 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424104#comment-17424104 ] Robert Muir commented on LUCENE-10143: -- I didn't mean it that way, I mean look at the PR. there

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

2021-10-04 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424075#comment-17424075 ] Robert Muir commented on LUCENE-10143: -- In general, I'm gonna say the "incomplete delegator" case

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

2021-10-04 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424068#comment-17424068 ] Robert Muir commented on LUCENE-10143: -- And none of those issues above are caused by "incomplete

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

2021-10-04 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424063#comment-17424063 ] Robert Muir commented on LUCENE-10143: -- {quote} The issue here is more specific to the rate

[jira] [Commented] (LUCENE-10145) Use VarHandles to speedup byte[] comparisons in some cases

2021-10-04 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424051#comment-17424051 ] Robert Muir commented on LUCENE-10145: -- If you use the jdk Arrays method, it uses the mismatch

[jira] [Commented] (LUCENE-10136) Lift the restriction on using 'var' variables

2021-10-04 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423895#comment-17423895 ] Robert Muir commented on LUCENE-10136: -- +1, we should use the latest language features. A lot of

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

2021-10-04 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423890#comment-17423890 ] Robert Muir commented on LUCENE-10143: -- I really think we need to devise a different strategy on

[jira] [Resolved] (LUCENE-10142) use a better RNG for Hnsw vectors

2021-10-02 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-10142. -- Fix Version/s: main (9.0) Resolution: Fixed thanks for reviewing [~dweiss] > use a

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

2021-10-02 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423588#comment-17423588 ] Robert Muir commented on LUCENE-10143: -- I have a prototype like this. will make a PR. >

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

2021-10-02 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423579#comment-17423579 ] Robert Muir commented on LUCENE-10143: -- Why not just make it abstract, forcing the caller to

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

2021-10-02 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423575#comment-17423575 ] Robert Muir commented on LUCENE-10143: -- if we want to do it, we could also move the current slow

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

2021-10-02 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423574#comment-17423574 ] Robert Muir commented on LUCENE-10143: -- I made DataInput.readInt/readShort/readLong and

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

2021-10-02 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423571#comment-17423571 ] Robert Muir commented on LUCENE-10143: -- That's the solution. Especially since it is now a

[jira] [Updated] (LUCENE-10142) use a better RNG for Hnsw vectors

2021-10-02 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10142: - Attachment: LUCENE-10142.patch > use a better RNG for Hnsw vectors >

[jira] [Commented] (LUCENE-10128) large indexing slowdown after increasing HNSW beam width

2021-10-02 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423529#comment-17423529 ] Robert Muir commented on LUCENE-10128: -- I opened LUCENE-10142 to try to help the large amount of

[jira] [Created] (LUCENE-10142) use a better RNG for Hnsw vectors

2021-10-02 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10142: Summary: use a better RNG for Hnsw vectors Key: LUCENE-10142 URL: https://issues.apache.org/jira/browse/LUCENE-10142 Project: Lucene - Core Issue Type: Task

[jira] [Resolved] (LUCENE-10130) HnswGraph could make use of a SparseFixedBitSet.getAndSet

2021-10-02 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-10130. -- Fix Version/s: main (9.0) Resolution: Fixed > HnswGraph could make use of a

[jira] [Commented] (LUCENE-10130) HnswGraph could make use of a SparseFixedBitSet.getAndSet

2021-10-02 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423508#comment-17423508 ] Robert Muir commented on LUCENE-10130: -- I attached a followup patch to try to give some more love

[jira] [Updated] (LUCENE-10130) HnswGraph could make use of a SparseFixedBitSet.getAndSet

2021-10-02 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10130: - Attachment: LUCENE-10130_round2.patch > HnswGraph could make use of a

[jira] [Commented] (LUCENE-10130) HnswGraph could make use of a SparseFixedBitSet.getAndSet

2021-10-01 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423457#comment-17423457 ] Robert Muir commented on LUCENE-10130: -- Thanks, let's try it out. if it doesn't help our indexing

[jira] [Commented] (LUCENE-10130) HnswGraph could make use of a SparseFixedBitSet.getAndSet

2021-09-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423052#comment-17423052 ] Robert Muir commented on LUCENE-10130: -- btw, being unsure about the data patterns was part of the

[jira] [Commented] (LUCENE-10130) HnswGraph could make use of a SparseFixedBitSet.getAndSet

2021-09-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422574#comment-17422574 ] Robert Muir commented on LUCENE-10130: -- Given those numbers (20k out of a million) I was actually

[jira] [Commented] (LUCENE-10128) increased HNSW beam with causes large indexing perf regression

2021-09-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422218#comment-17422218 ] Robert Muir commented on LUCENE-10128: -- yeah i probably used the wrong terminology. I wasn't sure

[jira] [Commented] (LUCENE-10130) HnswGraph could make use of a SparseFixedBitSet.getAndSet

2021-09-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422059#comment-17422059 ] Robert Muir commented on LUCENE-10130: -- sorry, I don't know much of the data patterns here. maybe

[jira] [Commented] (LUCENE-10126) CompetitiveIterator of NumericComparator can wrongly skip documents

2021-09-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17421894#comment-17421894 ] Robert Muir commented on LUCENE-10126: -- this latest commit caused 45 test failures in jenkins:

[jira] [Updated] (LUCENE-10130) HnswGraph could make use of a SparseFixedBitSet.getAndSet

2021-09-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10130: - Attachment: LUCENE-10130.patch > HnswGraph could make use of a SparseFixedBitSet.getAndSet >

[jira] [Commented] (LUCENE-10129) Add RamUsageEstimator shallowSizeOf(long[]) overload that just calls sizeOf(long[])?

2021-09-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17421493#comment-17421493 ] Robert Muir commented on LUCENE-10129: -- {noformat} public

[jira] [Commented] (LUCENE-10129) Add RamUsageEstimator shallowSizeOf(long[]) overload that just calls sizeOf(long[])?

2021-09-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17421485#comment-17421485 ] Robert Muir commented on LUCENE-10129: -- There is already a fast Object[] one, which is already

[jira] [Commented] (LUCENE-10128) increased HNSW beam with causes large indexing perf regression

2021-09-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17421434#comment-17421434 ] Robert Muir commented on LUCENE-10128: -- I opened LUCENE-10130 related to the bitset usage in

[jira] [Created] (LUCENE-10130) HnswGraph could make use of a SparseFixedBitSet.getAndSet

2021-09-28 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10130: Summary: HnswGraph could make use of a SparseFixedBitSet.getAndSet Key: LUCENE-10130 URL: https://issues.apache.org/jira/browse/LUCENE-10130 Project: Lucene - Core

[jira] [Created] (LUCENE-10129) Add RamUsageEstimator shallowSizeOf(long[]) overload that just calls sizeOf(long[])?

2021-09-28 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10129: Summary: Add RamUsageEstimator shallowSizeOf(long[]) overload that just calls sizeOf(long[])? Key: LUCENE-10129 URL: https://issues.apache.org/jira/browse/LUCENE-10129

[jira] [Commented] (LUCENE-10128) increased HNSW beam with causes large indexing perf regression

2021-09-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17421387#comment-17421387 ] Robert Muir commented on LUCENE-10128: -- attached is a trivial patch to remove reflection from

[jira] [Updated] (LUCENE-10128) increased HNSW beam with causes large indexing perf regression

2021-09-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10128: - Attachment: LUCENE-10128_remove_sparse_fixed_bitset_reflection.patch > increased HNSW beam

[jira] [Commented] (LUCENE-10128) increased HNSW beam with causes large indexing perf regression

2021-09-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17421375#comment-17421375 ] Robert Muir commented on LUCENE-10128: -- The impact on vectorsearch performance is much more

[jira] [Updated] (LUCENE-10128) increased HNSW beam with causes large indexing perf regression

2021-09-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10128: - Attachment: Screen_Shot_2021-09-28_at_09.10.15.png Status: Open (was: Open) >

[jira] [Commented] (LUCENE-10128) increased HNSW beam with causes large indexing perf regression

2021-09-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17421367#comment-17421367 ] Robert Muir commented on LUCENE-10128: -- I also notice in the stacksize=12 cpu profiles a lot of

[jira] [Created] (LUCENE-10128) increased HNSW beam with causes large indexing perf regression

2021-09-28 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10128: Summary: increased HNSW beam with causes large indexing perf regression Key: LUCENE-10128 URL: https://issues.apache.org/jira/browse/LUCENE-10128 Project: Lucene -

[jira] [Commented] (LUCENE-10125) Investigate indexing throughput regression on NYC Taxis between 2021-04-12 and 2021-05-24

2021-09-27 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17420812#comment-17420812 ] Robert Muir commented on LUCENE-10125: -- I agree, but don't think it needs to be {{tryWriteLong}}.

[jira] [Updated] (LUCENE-10125) Investigate indexing throughput regression on NYC Taxis between 2021-04-12 and 2021-05-24

2021-09-27 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10125: - Attachment: LUCENE-10125_hack.patch Status: Open (was: Open) [~uschindler] here is a

[jira] [Commented] (LUCENE-10125) Investigate indexing throughput regression on NYC Taxis between 2021-04-12 and 2021-05-24

2021-09-27 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17420771#comment-17420771 ] Robert Muir commented on LUCENE-10125: -- BufferedOutputStream exposes its buffer and count to

[jira] [Resolved] (LUCENE-5572) JapaneseTokenizer is sensitive to interrupts

2021-09-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-5572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-5572. - Resolution: Won't Fix > JapaneseTokenizer is sensitive to interrupts >

[jira] [Commented] (LUCENE-5572) JapaneseTokenizer is sensitive to interrupts

2021-09-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-5572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17419652#comment-17419652 ] Robert Muir commented on LUCENE-5572: - -1 to retries. don't interrupt threads loading up java

[jira] [Commented] (LUCENE-10112) Improve LZ4 Compression performance with direct primitive read/writes

2021-09-20 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17417571#comment-17417571 ] Robert Muir commented on LUCENE-10112: -- TestBackwardsCompatibility does not address my concerns

[jira] [Commented] (LUCENE-10112) Improve LZ4 Compression performance with direct primitive read/writes

2021-09-20 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17417564#comment-17417564 ] Robert Muir commented on LUCENE-10112: -- {quote} Would be a bad idea regading project Panama when

[jira] [Commented] (LUCENE-10112) Improve LZ4 Compression performance with direct primitive read/writes

2021-09-19 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17417423#comment-17417423 ] Robert Muir commented on LUCENE-10112: -- just to clarify, AFAIK using these varhandle methods

[jira] [Commented] (LUCENE-8638) Remove deprecated code in main

2021-09-13 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17414473#comment-17414473 ] Robert Muir commented on LUCENE-8638: - I do think the bug was the original API: it was missing any

[jira] [Commented] (LUCENE-8638) Remove deprecated code in main

2021-09-13 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17414202#comment-17414202 ] Robert Muir commented on LUCENE-8638: - Yes, please just add {{haversinMeters()}} and deprecate the

[jira] [Resolved] (LUCENE-10098) Add note/link to GermanAnalyzer for decompounding nouns

2021-09-12 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-10098. -- Fix Version/s: 8.11 main (9.0) Resolution: Fixed > Add note/link

[jira] [Resolved] (LUCENE-10096) Tamil Analyzer

2021-09-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-10096. -- Fix Version/s: main (9.0) Resolution: Fixed > Tamil Analyzer > -- > >

[jira] [Resolved] (LUCENE-10095) Nepali Analyzer

2021-09-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-10095. -- Resolution: Fixed > Nepali Analyzer > --- > > Key: LUCENE-10095

[jira] [Commented] (LUCENE-10097) Replace TreeMap use by HashMap when unnecessary

2021-09-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17413275#comment-17413275 ] Robert Muir commented on LUCENE-10097: -- Note: apart from ordering, in some cases this is done

[jira] [Created] (LUCENE-10096) Tamil Analyzer

2021-09-10 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10096: Summary: Tamil Analyzer Key: LUCENE-10096 URL: https://issues.apache.org/jira/browse/LUCENE-10096 Project: Lucene - Core Issue Type: Task

[jira] [Updated] (LUCENE-10095) Nepali Analyzer

2021-09-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10095: - Fix Version/s: main (9.0) > Nepali Analyzer > --- > > Key:

[jira] [Created] (LUCENE-10095) Nepali Analyzer

2021-09-10 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10095: Summary: Nepali Analyzer Key: LUCENE-10095 URL: https://issues.apache.org/jira/browse/LUCENE-10095 Project: Lucene - Core Issue Type: Task

[jira] [Resolved] (LUCENE-10083) Telugu analyzer

2021-09-02 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-10083. -- Fix Version/s: 8.10 main (9.0) Resolution: Fixed Thanks

[jira] [Commented] (LUCENE-10080) Use a bit set to count long-tail of singleton FacetLabels?

2021-09-01 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17408434#comment-17408434 ] Robert Muir commented on LUCENE-10080: -- also the heap cost is already maxOrdinal for all this

[jira] [Commented] (LUCENE-10080) Use a bit set to count long-tail of singleton FacetLabels?

2021-09-01 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17408429#comment-17408429 ] Robert Muir commented on LUCENE-10080: -- I kinda imagined something like this: instead of: {code}

[jira] [Commented] (LUCENE-10068) Switch to a "double barrel" HPPC cache for the taxonomy LRU cache

2021-08-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17406256#comment-17406256 ] Robert Muir commented on LUCENE-10068: -- why do we need a cache on ordinal lookups at all? Maybe

[jira] [Commented] (LUCENE-10074) Remove unneeded default value assignment

2021-08-27 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17406038#comment-17406038 ] Robert Muir commented on LUCENE-10074: -- Well that's just what javac does. if it is really

[jira] [Commented] (LUCENE-10074) Remove unneeded default value assignment

2021-08-27 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17405971#comment-17405971 ] Robert Muir commented on LUCENE-10074: -- I looked thru the checks, don't think such a check exists.

[jira] [Commented] (LUCENE-10067) investigate 6/23/2021 -> 6/24/2021 drop in facets perf

2021-08-26 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17405480#comment-17405480 ] Robert Muir commented on LUCENE-10067: -- Thank you [~jpountz], now we are better off than we

[jira] [Updated] (LUCENE-10067) investigate 6/23/2021 -> 6/24/2021 drop in facets perf

2021-08-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10067: - Summary: investigate 6/23/2021 -> 6/24/2021 drop in facets perf (was: investigate 6/23/2001

[jira] [Commented] (LUCENE-10067) investigate 6/23/2001 -> 6/24/2001 drop in facets perf

2021-08-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17403974#comment-17403974 ] Robert Muir commented on LUCENE-10067: -- here is the commits/diff between the two benchmark runs:

[jira] [Commented] (LUCENE-10067) investigate 6/23/2001 -> 6/24/2001 drop in facets perf

2021-08-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17403971#comment-17403971 ] Robert Muir commented on LUCENE-10067: -- btw, i haven't yet tried to do basic stuff such as

<    1   2   3   4   5   6   7   8   9   10   >