[jira] [Created] (LUCENE-9924) regenerate TLD list from IANA TLD db, rather than root zone db

2021-04-10 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9924: --- Summary: regenerate TLD list from IANA TLD db, rather than root zone db Key: LUCENE-9924 URL: https://issues.apache.org/jira/browse/LUCENE-9924 Project: Lucene - Core

[jira] [Resolved] (LUCENE-9923) remove timestamp from generated ASCIITLD.jflex

2021-04-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9923. - Fix Version/s: main (9.0) Resolution: Fixed > remove timestamp from generated

[jira] [Resolved] (LUCENE-9922) checksums files should use deterministic sort order?

2021-04-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9922. - Fix Version/s: main (9.0) Resolution: Fixed > checksums files should use deterministic

[jira] [Commented] (LUCENE-9921) Can ICU regeneration tasks treat icu version as input?

2021-04-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318579#comment-17318579 ] Robert Muir commented on LUCENE-9921: - Can we point the location of the actual resolved icu jar file

[jira] [Commented] (LUCENE-9923) remove timestamp from generated ASCIITLD.jflex

2021-04-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318578#comment-17318578 ] Robert Muir commented on LUCENE-9923: - I think we just want to remove the {{generated on}} date here

[jira] [Created] (LUCENE-9923) remove timestamp from generated ASCIITLD.jflex

2021-04-10 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9923: --- Summary: remove timestamp from generated ASCIITLD.jflex Key: LUCENE-9923 URL: https://issues.apache.org/jira/browse/LUCENE-9923 Project: Lucene - Core Issue

[jira] [Commented] (LUCENE-9921) Can ICU regeneration tasks treat icu version as input?

2021-04-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318570#comment-17318570 ] Robert Muir commented on LUCENE-9921: - Yes it worked correctly for that task. I'll look into it,

[jira] [Commented] (LUCENE-9922) checksums files should use deterministic sort order?

2021-04-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318569#comment-17318569 ] Robert Muir commented on LUCENE-9922: - I have a PR coming... just wrap with treemap when we pass

[jira] [Commented] (LUCENE-9922) checksums files should use deterministic sort order?

2021-04-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318525#comment-17318525 ] Robert Muir commented on LUCENE-9922: - I tend to also produce random file ordering changes for

[jira] [Created] (LUCENE-9922) checksums files should use deterministic sort order?

2021-04-10 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9922: --- Summary: checksums files should use deterministic sort order? Key: LUCENE-9922 URL: https://issues.apache.org/jira/browse/LUCENE-9922 Project: Lucene - Core

[jira] [Created] (LUCENE-9921) Can ICU regeneration tasks treat icu version as input?

2021-04-10 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9921: --- Summary: Can ICU regeneration tasks treat icu version as input? Key: LUCENE-9921 URL: https://issues.apache.org/jira/browse/LUCENE-9921 Project: Lucene - Core

[jira] [Commented] (LUCENE-9914) Modernize Emoji regeneration scripts

2021-04-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318517#comment-17318517 ] Robert Muir commented on LUCENE-9914: - I don't think we should do this at all. We are generating a

[jira] [Commented] (LUCENE-9917) Reduce block size for BEST_COMPRESSION

2021-04-08 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317379#comment-17317379 ] Robert Muir commented on LUCENE-9917: - do you mean BEST_SPEED here? > Reduce block size for

[jira] [Commented] (LUCENE-9916) generateUnicodeProps doesn't work according to instructions, always SKIPPED

2021-04-08 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317192#comment-17317192 ] Robert Muir commented on LUCENE-9916: - [~dweiss] I realize this looks like just a generic gradle

[jira] [Created] (LUCENE-9916) generateUnicodeProps doesn't work according to instructions, always SKIPPED

2021-04-08 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9916: --- Summary: generateUnicodeProps doesn't work according to instructions, always SKIPPED Key: LUCENE-9916 URL: https://issues.apache.org/jira/browse/LUCENE-9916 Project:

[jira] [Commented] (LUCENE-9914) Modernize Emoji regeneration scripts

2021-04-08 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317145#comment-17317145 ] Robert Muir commented on LUCENE-9914: - yes, that one looks great: I think a similar groovy can work

[jira] [Resolved] (LUCENE-9911) enable ecjLint unusedExceptionParameter

2021-04-08 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9911. - Fix Version/s: main (9.0) Resolution: Fixed > enable ecjLint unusedExceptionParameter >

[jira] [Commented] (LUCENE-9913) TestCompressingTermVectorsFormat.testMergeStability can fail assertion

2021-04-08 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317137#comment-17317137 ] Robert Muir commented on LUCENE-9913: - [~julietibs] I haven't dug into this test/failure yet, but it

[jira] [Commented] (LUCENE-9914) Modernize Emoji regeneration scripts

2021-04-08 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317121#comment-17317121 ] Robert Muir commented on LUCENE-9914: - FYI: For the jflex we want the unicode version to match what

[jira] [Commented] (LUCENE-9914) Modernize Emoji regeneration scripts

2021-04-07 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316744#comment-17316744 ] Robert Muir commented on LUCENE-9914: - This seems to print the current stuff that is needed... or

[jira] [Commented] (LUCENE-9914) Modernize Emoji regeneration scripts

2021-04-07 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316719#comment-17316719 ] Robert Muir commented on LUCENE-9914: - E.g. current file is generated for unicode 11 (that would

[jira] [Commented] (LUCENE-9914) Modernize Emoji regeneration scripts

2021-04-07 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316713#comment-17316713 ] Robert Muir commented on LUCENE-9914: - One little hurdle is that this perl script wants a specific

[jira] [Commented] (LUCENE-9914) Modernize Emoji regeneration scripts

2021-04-07 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316710#comment-17316710 ] Robert Muir commented on LUCENE-9914: - [~dweiss] how hard would it be to depend on ICU jar for this

[jira] [Commented] (LUCENE-9827) Small segments are slower to merge due to stored fields since 8.7

2021-04-07 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316391#comment-17316391 ] Robert Muir commented on LUCENE-9827: - [~jpountz] Oh, that's perfectly fine. I mistakenly assumed

[jira] [Commented] (LUCENE-9827) Small segments are slower to merge due to stored fields since 8.7

2021-04-07 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316254#comment-17316254 ] Robert Muir commented on LUCENE-9827: - [~jpountz] I was thinking about it too, but we changed the

[jira] [Resolved] (LUCENE-9882) better synchronize eclipse formatter with spotless

2021-04-07 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9882. - Fix Version/s: main (9.0) Resolution: Fixed > better synchronize eclipse formatter with

[jira] [Resolved] (LUCENE-9910) maximize javac lint

2021-04-07 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9910. - Fix Version/s: main (9.0) Resolution: Fixed > maximize javac lint > ---

[jira] [Resolved] (LUCENE-9827) Small segments are slower to merge due to stored fields since 8.7

2021-04-07 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9827. - Fix Version/s: main (9.0) Resolution: Fixed > Small segments are slower to merge due to

[jira] [Created] (LUCENE-9911) enable ecjLint unusedExceptionParameter

2021-04-06 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9911: --- Summary: enable ecjLint unusedExceptionParameter Key: LUCENE-9911 URL: https://issues.apache.org/jira/browse/LUCENE-9911 Project: Lucene - Core Issue Type:

[jira] [Created] (LUCENE-9910) maximize javac lint

2021-04-06 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9910: --- Summary: maximize javac lint Key: LUCENE-9910 URL: https://issues.apache.org/jira/browse/LUCENE-9910 Project: Lucene - Core Issue Type: Task

[jira] [Commented] (LUCENE-9855) Reconsider codec name VectorFormat

2021-04-06 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17315813#comment-17315813 ] Robert Muir commented on LUCENE-9855: - {quote} For postings and doc values, we make it relatively

[jira] [Commented] (LUCENE-9855) Reconsider codec name VectorFormat

2021-04-05 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314734#comment-17314734 ] Robert Muir commented on LUCENE-9855: - the "strategy" is a huge antipattern. lets split into

[jira] [Resolved] (LUCENE-9893) Document or fix CodecUtil's codec requirements/limitations

2021-03-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9893. - Resolution: Not A Problem Not a limitation: this is a utility class, either you use it or you

[jira] [Commented] (LUCENE-9890) Retire @lucene.experimental tag and enforce @since tag for public classes

2021-03-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17311454#comment-17311454 ] Robert Muir commented on LUCENE-9890: - I think the api is almost a lost cause at this point.

[jira] [Commented] (LUCENE-9888) Re-instate CheckIndex's attempts to confirm index sort is consistent across all segments

2021-03-27 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309981#comment-17309981 ] Robert Muir commented on LUCENE-9888: - yeah this is a wtf that checker found. i mechanically removed

[jira] [Created] (LUCENE-9882) better synchronize eclipse formatter with spotless

2021-03-26 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9882: --- Summary: better synchronize eclipse formatter with spotless Key: LUCENE-9882 URL: https://issues.apache.org/jira/browse/LUCENE-9882 Project: Lucene - Core

[jira] [Created] (LUCENE-9881) synchronize ECJ linter with eclipse IDE

2021-03-26 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9881: --- Summary: synchronize ECJ linter with eclipse IDE Key: LUCENE-9881 URL: https://issues.apache.org/jira/browse/LUCENE-9881 Project: Lucene - Core Issue Type:

[jira] [Commented] (LUCENE-9880) Task ordering can be incorrect for gradlew clean [...]

2021-03-26 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309391#comment-17309391 ] Robert Muir commented on LUCENE-9880: - I don't know if it helps, but if you pass "-verbose" to ecj

[jira] [Commented] (LUCENE-9868) Verify checksums on generated files

2021-03-26 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309334#comment-17309334 ] Robert Muir commented on LUCENE-9868: - Yeah, probably a few other things we want to do to make this

[jira] [Commented] (LUCENE-9879) errorprone cause large slowdown of compileJava/compileTestJava

2021-03-26 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309312#comment-17309312 ] Robert Muir commented on LUCENE-9879: - {quote} Thanks Robert: this explains why it got so slow over

[jira] [Commented] (LUCENE-9880) Task ordering can be incorrect for gradlew clean [...]

2021-03-26 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309308#comment-17309308 ] Robert Muir commented on LUCENE-9880: - I hit this sometimes too. > Task ordering can be incorrect

[jira] [Commented] (LUCENE-9879) errorprone cause large slowdown of compileJava/compileTestJava

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309138#comment-17309138 ] Robert Muir commented on LUCENE-9879: - Related issue, particularly this comment:

[jira] [Commented] (LUCENE-9879) errorprone cause large slowdown of compileJava/compileTestJava

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309136#comment-17309136 ] Robert Muir commented on LUCENE-9879: - In an ideal world I think, we'd let javac do

[jira] [Created] (LUCENE-9879) errorprone cause large slowdown of compileJava/compileTestJava

2021-03-25 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9879: --- Summary: errorprone cause large slowdown of compileJava/compileTestJava Key: LUCENE-9879 URL: https://issues.apache.org/jira/browse/LUCENE-9879 Project: Lucene - Core

[jira] [Created] (LUCENE-9878) enable redundantNullCheck in ecjLint

2021-03-25 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9878: --- Summary: enable redundantNullCheck in ecjLint Key: LUCENE-9878 URL: https://issues.apache.org/jira/browse/LUCENE-9878 Project: Lucene - Core Issue Type: Task

[jira] [Commented] (LUCENE-9868) Verify checksums on generated files

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308997#comment-17308997 ] Robert Muir commented on LUCENE-9868: - I think hashing could be extremely difficult to debug, if

[jira] [Resolved] (LUCENE-9864) Enforce @Override annotation with ecj static analysis configuration

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9864. - Resolution: Fixed > Enforce @Override annotation with ecj static analysis configuration >

[jira] [Commented] (LUCENE-9864) Enforce @Override annotation with ecj static analysis configuration

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308844#comment-17308844 ] Robert Muir commented on LUCENE-9864: - Thank you [~dweiss]. Congratulations, you made it into

[jira] [Commented] (LUCENE-9864) Enforce @Override annotation with ecj static analysis configuration

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308826#comment-17308826 ] Robert Muir commented on LUCENE-9864: - I'm working on the queryparser pieces. It is just slow

[jira] [Commented] (LUCENE-9864) Enforce @Override annotation with ecj static analysis configuration

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308812#comment-17308812 ] Robert Muir commented on LUCENE-9864: - Sorry, I missed seeing the modified queryparser sources

[jira] [Commented] (LUCENE-9864) Enforce @Override annotation with ecj static analysis configuration

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308794#comment-17308794 ] Robert Muir commented on LUCENE-9864: - I only saw issues with snowball generated code: I updated the

[jira] [Commented] (LUCENE-9867) CorruptIndexException after failed segment merge caused by No space left on device

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308538#comment-17308538 ] Robert Muir commented on LUCENE-9867: - I'm really not worried about XFS yet. I first want to know it

[jira] [Commented] (LUCENE-9866) regenerate kuromoji dict in regenerate

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308512#comment-17308512 ] Robert Muir commented on LUCENE-9866: - [~dweiss] we package mecab by default with lucene in the

[jira] [Commented] (LUCENE-9867) CorruptIndexException after failed segment merge caused by No space left on device

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308510#comment-17308510 ] Robert Muir commented on LUCENE-9867: - [~sqshq] the general problem is files getting deleted that

[jira] [Commented] (LUCENE-9867) CorruptIndexException after failed segment merge caused by No space left on device

2021-03-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308339#comment-17308339 ] Robert Muir commented on LUCENE-9867: - [~sqshq] you really shouldn't see FileNotFoundException from

[jira] [Resolved] (LUCENE-9856) Improve static analysis to catch dead code and other potential bugs

2021-03-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9856. - Resolution: Fixed Thanks [~uschindler] for cleaning up the long tail here! > Improve static

[jira] [Commented] (LUCENE-9862) gradlew regenerate doesnt invoke jflexStandardTokenizerImpl

2021-03-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307951#comment-17307951 ] Robert Muir commented on LUCENE-9862: - Yes, that one triggered the OOM killer on my machine, so I

[jira] [Commented] (LUCENE-9863) run spotless across groovy (e.g. gradle) code too

2021-03-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307946#comment-17307946 ] Robert Muir commented on LUCENE-9863: - I agree, I don't want to sound like a complainer, I really

[jira] [Commented] (LUCENE-9862) gradlew regenerate doesnt invoke jflexStandardTokenizerImpl

2021-03-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307938#comment-17307938 ] Robert Muir commented on LUCENE-9862: - Thank you for the improvements here [~dweiss]! I really did

[jira] [Created] (LUCENE-9866) regenerate kuromoji dict in regenerate

2021-03-24 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9866: --- Summary: regenerate kuromoji dict in regenerate Key: LUCENE-9866 URL: https://issues.apache.org/jira/browse/LUCENE-9866 Project: Lucene - Core Issue Type:

[jira] [Commented] (LUCENE-9863) run spotless across groovy (e.g. gradle) code too

2021-03-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307925#comment-17307925 ] Robert Muir commented on LUCENE-9863: - Also given there is no standard, i tend to lean towards what

[jira] [Commented] (LUCENE-9863) run spotless across groovy (e.g. gradle) code too

2021-03-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307914#comment-17307914 ] Robert Muir commented on LUCENE-9863: - As an example, I opened this issue because of LUCENE-9856 PR.

[jira] [Commented] (LUCENE-9863) run spotless across groovy (e.g. gradle) code too

2021-03-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307909#comment-17307909 ] Robert Muir commented on LUCENE-9863: - I think my issue is that there is no agreed-upon standard of

[jira] [Commented] (LUCENE-9850) Explore PFOR for Doc ID delta encoding (instead of FOR)

2021-03-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307382#comment-17307382 ] Robert Muir commented on LUCENE-9850: - Maybe rather than power of two, try a list something like

[jira] [Reopened] (LUCENE-9856) Improve static analysis to catch dead code and other potential bugs

2021-03-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir reopened LUCENE-9856: - I reverted this due to test failures. I will look into it, I think i angered the attributes. >

[jira] [Commented] (LUCENE-9827) Small segments are slower to merge due to stored fields since 8.7

2021-03-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307177#comment-17307177 ] Robert Muir commented on LUCENE-9827: - [~jpountz] As far as the "1% dirty docs", it was equally

[jira] [Resolved] (LUCENE-9856) Improve static analysis to catch dead code and other potential bugs

2021-03-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9856. - Fix Version/s: main (9.0) Resolution: Fixed > Improve static analysis to catch dead code

[jira] [Commented] (LUCENE-9862) gradlew regenerate doesnt invoke jflexStandardTokenizerImpl

2021-03-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307122#comment-17307122 ] Robert Muir commented on LUCENE-9862: - I must have messed it up the last time I upgraded, that is my

[jira] [Commented] (LUCENE-9862) gradlew regenerate doesnt invoke jflexStandardTokenizerImpl

2021-03-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307111#comment-17307111 ] Robert Muir commented on LUCENE-9862: - Oh man, it is probably a bug. This thing is pretty hacky.

[jira] [Commented] (LUCENE-9863) run spotless across groovy (e.g. gradle) code too

2021-03-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307033#comment-17307033 ] Robert Muir commented on LUCENE-9863: - Does it just need more maturity before it can be used? To me

[jira] [Commented] (LUCENE-9861) speed up precommit

2021-03-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306997#comment-17306997 ] Robert Muir commented on LUCENE-9861: - Thank you [~dweiss], this one really helps my computer. >

[jira] [Created] (LUCENE-9863) run spotless across groovy (e.g. gradle) code too

2021-03-23 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9863: --- Summary: run spotless across groovy (e.g. gradle) code too Key: LUCENE-9863 URL: https://issues.apache.org/jira/browse/LUCENE-9863 Project: Lucene - Core

[jira] [Created] (LUCENE-9862) gradlew regenerate doesnt invoke jflexStandardTokenizerImpl

2021-03-22 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9862: --- Summary: gradlew regenerate doesnt invoke jflexStandardTokenizerImpl Key: LUCENE-9862 URL: https://issues.apache.org/jira/browse/LUCENE-9862 Project: Lucene - Core

[jira] [Commented] (LUCENE-9856) Improve static analysis to catch dead code and other potential bugs

2021-03-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306677#comment-17306677 ] Robert Muir commented on LUCENE-9856: - While wrestling with the PR, I found out about

[jira] [Commented] (LUCENE-9861) speed up precommit

2021-03-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306627#comment-17306627 ] Robert Muir commented on LUCENE-9861: - Another way to look at it, if you see that, you've set gradle

[jira] [Commented] (LUCENE-9861) speed up precommit

2021-03-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306625#comment-17306625 ] Robert Muir commented on LUCENE-9861: - If you have 87 cores, you can afford to spend a bunch of

[jira] [Commented] (LUCENE-9861) speed up precommit

2021-03-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306558#comment-17306558 ] Robert Muir commented on LUCENE-9861: - {quote} But for stuff that works perfectly fine in the Gradle

[jira] [Commented] (LUCENE-9861) speed up precommit

2021-03-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306549#comment-17306549 ] Robert Muir commented on LUCENE-9861: - Also the "-times" can be removed from the patch. I was using

[jira] [Commented] (LUCENE-9861) speed up precommit

2021-03-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306536#comment-17306536 ] Robert Muir commented on LUCENE-9861: - Not forking is fine too. But forking with C2 enabled in order

[jira] [Commented] (LUCENE-9860) explore disabling ecj javadocs processing

2021-03-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306533#comment-17306533 ] Robert Muir commented on LUCENE-9860: - yes, i closed it as won't fix > explore disabling ecj

[jira] [Commented] (LUCENE-9861) speed up precommit

2021-03-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306462#comment-17306462 ] Robert Muir commented on LUCENE-9861: - simple bench of current hack patch before: {noformat} $

[jira] [Updated] (LUCENE-9861) speed up precommit

2021-03-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9861: Attachment: LUCENE-9861_hack.patch Status: Open (was: Open) My current hack patch. Still

[jira] [Commented] (LUCENE-9861) speed up precommit

2021-03-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306439#comment-17306439 ] Robert Muir commented on LUCENE-9861: - For renderJavadoc this is also 2x speedup: Before: {noformat}

[jira] [Created] (LUCENE-9861) speed up precommit

2021-03-22 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9861: --- Summary: speed up precommit Key: LUCENE-9861 URL: https://issues.apache.org/jira/browse/LUCENE-9861 Project: Lucene - Core Issue Type: Task

[jira] [Resolved] (LUCENE-9860) explore disabling ecj javadocs processing

2021-03-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9860. - Resolution: Won't Fix > explore disabling ecj javadocs processing >

[jira] [Commented] (LUCENE-9860) explore disabling ecj javadocs processing

2021-03-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306404#comment-17306404 ] Robert Muir commented on LUCENE-9860: - I played around, even disabling so much javadocs in the

[jira] [Commented] (LUCENE-9860) explore disabling ecj javadocs processing

2021-03-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306312#comment-17306312 ] Robert Muir commented on LUCENE-9860: - This URL didnt work (i think it was expired) but you are

[jira] [Commented] (LUCENE-9860) explore disabling ecj javadocs processing

2021-03-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306302#comment-17306302 ] Robert Muir commented on LUCENE-9860: - I think the change is to simply remove {{-enableJavadoc}}

[jira] [Created] (LUCENE-9860) explore disabling ecj javadocs processing

2021-03-22 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9860: --- Summary: explore disabling ecj javadocs processing Key: LUCENE-9860 URL: https://issues.apache.org/jira/browse/LUCENE-9860 Project: Lucene - Core Issue Type:

[jira] [Commented] (LUCENE-9856) Improve static analysis to catch dead code and other potential bugs

2021-03-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306290#comment-17306290 ] Robert Muir commented on LUCENE-9856: - {quote} This aside, maybe we should return to the idea of the

[jira] [Commented] (LUCENE-9856) Improve static analysis to catch dead code and other potential bugs

2021-03-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306287#comment-17306287 ] Robert Muir commented on LUCENE-9856: - So in pseudocode something like this (similar to how we

[jira] [Commented] (LUCENE-9856) Improve static analysis to catch dead code and other potential bugs

2021-03-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306283#comment-17306283 ] Robert Muir commented on LUCENE-9856: - [~dweiss] i don't want to disable *entire ecj linter* for

[jira] [Commented] (LUCENE-9856) Improve static analysis to catch dead code and other potential bugs

2021-03-21 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17305892#comment-17305892 ] Robert Muir commented on LUCENE-9856: - I enabled the same enforced settings for the IDE in

[jira] [Updated] (LUCENE-9856) Improve static analysis to catch dead code and other potential bugs

2021-03-21 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9856: Attachment: LUCENE-9856.patch > Improve static analysis to catch dead code and other potential

[jira] [Commented] (LUCENE-9856) Improve static analysis to catch dead code and other potential bugs

2021-03-21 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17305873#comment-17305873 ] Robert Muir commented on LUCENE-9856: - We can turn it on in ecjLint with a one-line change, so it

[jira] [Comment Edited] (LUCENE-9827) Small segments are slower to merge due to stored fields since 8.7

2021-03-21 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17305741#comment-17305741 ] Robert Muir edited comment on LUCENE-9827 at 3/22/21, 2:37 AM: --- if we

[jira] [Commented] (LUCENE-9827) Small segments are slower to merge due to stored fields since 8.7

2021-03-21 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17305741#comment-17305741 ] Robert Muir commented on LUCENE-9827: - if we wanted, in the future we could substitute something

[jira] [Commented] (LUCENE-9827) Small segments are slower to merge due to stored fields since 8.7

2021-03-21 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17305712#comment-17305712 ] Robert Muir commented on LUCENE-9827: - The problem for small segments is that we still do wasted

[jira] [Commented] (LUCENE-9827) Small segments are slower to merge due to stored fields since 8.7

2021-03-21 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17305699#comment-17305699 ] Robert Muir commented on LUCENE-9827: - I attached a simple reproducer for the problem: index first

[jira] [Updated] (LUCENE-9827) Small segments are slower to merge due to stored fields since 8.7

2021-03-21 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9827: Attachment: Indexer.java > Small segments are slower to merge due to stored fields since 8.7 >

<    1   2   3   4   5   6   7   8   9   10   >