[GitHub] [lucene-solr] jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-06-16 Thread GitBox
jpountz commented on a change in pull request #1351: URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r440675787 ## File path: lucene/core/src/java/org/apache/lucene/search/FilteringNumericComparator.java ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-05-26 Thread GitBox
jpountz commented on a change in pull request #1351: URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r429949584 ## File path: lucene/core/src/java/org/apache/lucene/search/FilteringNumericComparator.java ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-04-24 Thread GitBox
jpountz commented on a change in pull request #1351: URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r414392251 ## File path: lucene/core/src/java/org/apache/lucene/search/FilterLeafCollector.java ## @@ -53,4 +53,8 @@ public String toString() { return name

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-04-18 Thread GitBox
jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r410690894 ## File path: lucene/core/src/java/org/apache/lucene/search/ScoreMode.java ## @@ -24,37

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-04-18 Thread GitBox
jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r410690540 ## File path: lucene/core/src/java/org/apache/lucene/search/FilteringFieldComparator.java ##

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-04-18 Thread GitBox
jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r410690396 ## File path: lucene/core/src/java/org/apache/lucene/search/FilteringFieldComparator.java ##

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-04-18 Thread GitBox
jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r410689886 ## File path: lucene/core/src/java/org/apache/lucene/search/FilteringFieldComparator.java ##

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-04-18 Thread GitBox
jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r410688181 ## File path: lucene/core/src/java/org/apache/lucene/search/FilteringFieldComparator.java ##

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-04-18 Thread GitBox
jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r410691342 ## File path: lucene/core/src/java/org/apache/lucene/search/Weight.java ## @@ -201,19 +2

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-04-18 Thread GitBox
jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r410692812 ## File path: lucene/core/src/java/org/apache/lucene/search/FilteringFieldComparator.java ##

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-04-18 Thread GitBox
jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r410688437 ## File path: lucene/core/src/java/org/apache/lucene/search/FilteringFieldComparator.java ##

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-04-18 Thread GitBox
jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r410688678 ## File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java ## @@

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-04-15 Thread GitBox
jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r408712107 ## File path: lucene/core/src/java/org/apache/lucene/search/LeafCollector.java ## @@ -93

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-04-15 Thread GitBox
jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r403471265 ## File path: lucene/core/src/java/org/apache/lucene/search/SortField.java ## @@ -91,6 +

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-04-15 Thread GitBox
jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r403471265 ## File path: lucene/core/src/java/org/apache/lucene/search/SortField.java ## @@ -91,6 +

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-04-15 Thread GitBox
jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r408712107 ## File path: lucene/core/src/java/org/apache/lucene/search/LeafCollector.java ## @@ -93

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-03-31 Thread GitBox
jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r400739959 ## File path: lucene/core/src/java/org/apache/lucene/search/LeafCollector.java ## @@ -93

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-03-31 Thread GitBox
jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r400736631 ## File path: lucene/core/src/java/org/apache/lucene/search/ConstantScoreQuery.java ##

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-03-31 Thread GitBox
jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r400741063 ## File path: lucene/core/src/java/org/apache/lucene/search/LeafCollector.java ## @@ -93

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-03-31 Thread GitBox
jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r400739533 ## File path: lucene/core/src/java/org/apache/lucene/search/LeafCollector.java ## @@ -93