Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

vsop-479 commented on code in PR #11888: URL: https://github.com/apache/lucene/pull/11888#discussion_r1574272996 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java: ## @@ -642,6 +651,97 @@ public SeekStatus scanToTermLeaf(BytesRef

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

vsop-479 commented on PR #11888: URL: https://github.com/apache/lucene/pull/11888#issuecomment-2033469573 Glad to know that. Thanks @mikemccand . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

mikemccand commented on PR #11888: URL: https://github.com/apache/lucene/pull/11888#issuecomment-2032280982 Oooh this change gave a nice pop (~5.4%, ~915 -> 964 K lookups/sec) to the primary key lookup nightly benchy: https://home.apache.org/~mikemccand/lucenebench/PKLookup.html

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

vsop-479 commented on code in PR #11888: URL: https://github.com/apache/lucene/pull/11888#discussion_r1546339137 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java: ## @@ -642,6 +651,97 @@ public SeekStatus scanToTermLeaf(BytesRef

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

mikemccand merged PR #11888: URL: https://github.com/apache/lucene/pull/11888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

mikemccand commented on PR #11888: URL: https://github.com/apache/lucene/pull/11888#issuecomment-2029720633 Actually I can just re-merge your prior `CHANGES.txt` entry from [here](https://github.com/apache/lucene/pull/11888/commits/a695c07da8ccdb348c87f98e6b4be6d778d919c3), so no need to

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

mikemccand commented on code in PR #11888: URL: https://github.com/apache/lucene/pull/11888#discussion_r1546290149 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java: ## @@ -642,6 +651,97 @@ public SeekStatus scanToTermLeaf(BytesRef

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

mikemccand commented on code in PR #11888: URL: https://github.com/apache/lucene/pull/11888#discussion_r1546289740 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java: ## @@ -642,6 +651,97 @@ public SeekStatus scanToTermLeaf(BytesRef

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

vsop-479 commented on code in PR #11888: URL: https://github.com/apache/lucene/pull/11888#discussion_r1543957681 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java: ## @@ -642,6 +651,97 @@ public SeekStatus scanToTermLeaf(BytesRef

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

vsop-479 commented on code in PR #11888: URL: https://github.com/apache/lucene/pull/11888#discussion_r1543957681 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java: ## @@ -642,6 +651,97 @@ public SeekStatus scanToTermLeaf(BytesRef

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

vsop-479 commented on code in PR #11888: URL: https://github.com/apache/lucene/pull/11888#discussion_r1543957681 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java: ## @@ -642,6 +651,97 @@ public SeekStatus scanToTermLeaf(BytesRef

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

vsop-479 commented on code in PR #11888: URL: https://github.com/apache/lucene/pull/11888#discussion_r1543070445 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java: ## @@ -642,6 +651,97 @@ public SeekStatus scanToTermLeaf(BytesRef

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

mikemccand commented on code in PR #11888: URL: https://github.com/apache/lucene/pull/11888#discussion_r1542769731 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java: ## @@ -642,6 +651,97 @@ public SeekStatus scanToTermLeaf(BytesRef

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

vsop-479 commented on PR #11888: URL: https://github.com/apache/lucene/pull/11888#issuecomment-2024550150 Thanks for your comments @mikemccand . I have fixed them, and removed the stale change entry about this change. Please take a look when you get a chance. -- This is an automated

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

vsop-479 commented on code in PR #11888: URL: https://github.com/apache/lucene/pull/11888#discussion_r1542387588 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java: ## @@ -642,6 +651,99 @@ public SeekStatus scanToTermLeaf(BytesRef

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

vsop-479 commented on code in PR #11888: URL: https://github.com/apache/lucene/pull/11888#discussion_r1542363416 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java: ## @@ -642,6 +651,99 @@ public SeekStatus scanToTermLeaf(BytesRef

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

vsop-479 commented on code in PR #11888: URL: https://github.com/apache/lucene/pull/11888#discussion_r1542357624 ## lucene/core/src/test/org/apache/lucene/codecs/lucene99/TestLucene99PostingsFormat.java: ## @@ -143,4 +141,13 @@ private void doTestImpactSerialization(List

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

vsop-479 commented on code in PR #11888: URL: https://github.com/apache/lucene/pull/11888#discussion_r1542233210 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java: ## @@ -642,6 +651,99 @@ public SeekStatus scanToTermLeaf(BytesRef

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

vsop-479 commented on code in PR #11888: URL: https://github.com/apache/lucene/pull/11888#discussion_r1542231368 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java: ## @@ -642,6 +651,99 @@ public SeekStatus scanToTermLeaf(BytesRef

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

mikemccand commented on code in PR #11888: URL: https://github.com/apache/lucene/pull/11888#discussion_r1541971598 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java: ## @@ -642,6 +651,99 @@ public SeekStatus scanToTermLeaf(BytesRef

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

mikemccand commented on code in PR #11888: URL: https://github.com/apache/lucene/pull/11888#discussion_r1541892891 ## lucene/core/src/test/org/apache/lucene/codecs/lucene99/TestLucene99PostingsFormat.java: ## @@ -143,4 +141,13 @@ private void doTestImpactSerialization(List

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

vsop-479 commented on PR #11888: URL: https://github.com/apache/lucene/pull/11888#issuecomment-2022219035 @mikemccand Thanks for your review. I measured performance on `wikimediumall`: # iter1 TaskQPS baseline StdDevQPS my_modified_version StdDev

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

vsop-479 commented on code in PR #11888: URL: https://github.com/apache/lucene/pull/11888#discussion_r1540528182 ## lucene/core/src/test/org/apache/lucene/codecs/lucene99/TestLucene99PostingsFormat.java: ## @@ -143,4 +141,13 @@ private void doTestImpactSerialization(List

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

vsop-479 commented on PR #11888: URL: https://github.com/apache/lucene/pull/11888#issuecomment-2021791458 > Was this on wikimediumall? No, this was on `wikimedium10k`. I will measure the performance again on `wikimediumall`. -- This is an automated message from the Apache Git

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

mikemccand commented on code in PR #11888: URL: https://github.com/apache/lucene/pull/11888#discussion_r1539192140 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java: ## @@ -523,7 +526,9 @@ public void scanToSubBlock(long subFP) {

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

mikemccand commented on PR #11888: URL: https://github.com/apache/lucene/pull/11888#issuecomment-2020383140 I like this idea! It seems like it'd especially help primary key lookup against fixed length IDs like UUID? Hmm, the QPS in the `luceneutil` runs are way too high (1000s of

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

vsop-479 commented on PR #11888: URL: https://github.com/apache/lucene/pull/11888#issuecomment-1999256752 @jpountz I want to move `subCheckBinarySearch` to `BasePostingsFormatTestCase` to make this change forward compatible, by judging whether `IndexWriterConfig` is set

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

github-actions[bot] commented on PR #11888: URL: https://github.com/apache/lucene/pull/11888#issuecomment-1953304146 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

vsop-479 commented on PR #11888: URL: https://github.com/apache/lucene/pull/11888#issuecomment-1926589435 @jpountz Can we push on this change by checking whether our test case has covered all the status, that `TermsEnum.seekExact` or `TermsEnum.seekCeil` may emit? -- This is an

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

vsop-479 commented on PR #11888: URL: https://github.com/apache/lucene/pull/11888#issuecomment-1914149013 @jpountz @mikemccand I resolved the conflicts, and moved the test case for target greater than the last entry of matched block from `TestLucene90PostingsFormat` to

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

github-actions[bot] commented on PR #11888: URL: https://github.com/apache/lucene/pull/11888#issuecomment-1907130580 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

jpountz commented on PR #11888: URL: https://github.com/apache/lucene/pull/11888#issuecomment-1881059520 @mikemccand I could use your help to review this change, it's quite deep in the guts of block tree. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

github-actions[bot] commented on PR #11888: URL: https://github.com/apache/lucene/pull/11888#issuecomment-1880904269 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

vsop-479 commented on PR #11888: URL: https://github.com/apache/lucene/pull/11888#issuecomment-1759050886 Append some performance data. Note that the results have quite diversity from different rounds. # round1 Task QPS baseline StdDev QPS