[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098447#comment-17098447
]
Tomoko Uchida commented on LUCENE-9201:
---
To organize issues and avoid confusion, I would like to
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081764#comment-17081764
]
Tomoko Uchida commented on LUCENE-9201:
---
Thank you! I will open an issue for "documentation" task
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081757#comment-17081757
]
Dawid Weiss commented on LUCENE-9201:
-
Yes! And I've just committed a small cleanup that implements
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081756#comment-17081756
]
ASF subversion and git services commented on LUCENE-9201:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081750#comment-17081750
]
Tomoko Uchida commented on LUCENE-9201:
---
Thank you for your feedback, I updated the dependency
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081747#comment-17081747
]
Dawid Weiss commented on LUCENE-9201:
-
On the second thought I think we should keep the convention
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081734#comment-17081734
]
Dawid Weiss commented on LUCENE-9201:
-
Indeed I don't think documentation has been listed in
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081660#comment-17081660
]
Tomoko Uchida commented on LUCENE-9201:
---
Before proceeding this issue, I'd like to reorganize task
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079510#comment-17079510
]
Dawid Weiss commented on LUCENE-9201:
-
Ah - right. Thank you for clarifying.
> Port
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079270#comment-17079270
]
Tomoko Uchida commented on LUCENE-9201:
---
There is one thing not yet ported to gradle: the "broken
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079251#comment-17079251
]
Dawid Weiss commented on LUCENE-9201:
-
Hmm... I'm a bit lost here - is this issue still valid,
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044631#comment-17044631
]
Tomoko Uchida commented on LUCENE-9201:
---
I finally got how the "invoke-module-javadoc" macro
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044439#comment-17044439
]
Robert Muir commented on LUCENE-9201:
-
as a second step you can look at computing package list for a
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044428#comment-17044428
]
Robert Muir commented on LUCENE-9201:
-
for "directly call the javadoc tool" we may want to use the
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043951#comment-17043951
]
Dawid Weiss commented on LUCENE-9201:
-
A custom javadoc invocation is certainly possible and could
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043140#comment-17043140
]
Tomoko Uchida commented on LUCENE-9201:
---
I just merged [^LUCENE-9201-missing-docs.patch] into the
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043128#comment-17043128
]
ASF subversion and git services commented on LUCENE-9201:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043068#comment-17043068
]
Dawid Weiss commented on LUCENE-9201:
-
Sorry, Tomoko - you are right about collect. Apologies for
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042976#comment-17042976
]
Tomoko Uchida commented on LUCENE-9201:
---
I attached [^LUCENE-9201-missing-docs.patch], where the
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042943#comment-17042943
]
Dawid Weiss commented on LUCENE-9201:
-
Sure, the filter is fine. Could be ".collect { it.exists() }"
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042900#comment-17042900
]
Tomoko Uchida commented on LUCENE-9201:
---
[~dweiss] I did some tests with the patch
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17041705#comment-17041705
]
Dawid Weiss commented on LUCENE-9201:
-
If you take a look at defaults-maven.gradle you'll see some
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17041449#comment-17041449
]
Tomoko Uchida commented on LUCENE-9201:
---
Hi Dawid, thanks for your comments! I think I get the
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17041211#comment-17041211
]
Dawid Weiss commented on LUCENE-9201:
-
Hi Tomoko. I'm about to leave but left some half-baked
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17041159#comment-17041159
]
Tomoko Uchida commented on LUCENE-9201:
---
Hi,
there remain two documentation-lint tasks to be
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039152#comment-17039152
]
Dawid Weiss commented on LUCENE-9201:
-
# Feel free to switch to sourceSet.getTaskName.
# The
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039137#comment-17039137
]
Tomoko Uchida commented on LUCENE-9201:
---
Yes, the patch works for me too, with this modification.
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038817#comment-17038817
]
Dawid Weiss commented on LUCENE-9201:
-
bq. Task looks fine, but taskname for the per SourceSet task
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038668#comment-17038668
]
Uwe Schindler commented on LUCENE-9201:
---
bq. There are also some odd warnings printed about
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038667#comment-17038667
]
Uwe Schindler commented on LUCENE-9201:
---
Task looks fine, but taskname for the per SourceSet task
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038656#comment-17038656
]
Dawid Weiss commented on LUCENE-9201:
-
Hi [~tomoko] I think you were onto something because the
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038257#comment-17038257
]
Tomoko Uchida commented on LUCENE-9201:
---
Thanks, I got the current status. I will try to create a
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038132#comment-17038132
]
Dawid Weiss commented on LUCENE-9201:
-
Hi Tomoko. Yes, the task as I included it in the patch won't
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037807#comment-17037807
]
Uwe Schindler commented on LUCENE-9201:
---
To fix the issue completely, we also have to add some
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037805#comment-17037805
]
Uwe Schindler commented on LUCENE-9201:
---
See:
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037803#comment-17037803
]
Uwe Schindler commented on LUCENE-9201:
---
You should be able to add: {{task.inputs.files(srcDirs)}}
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037801#comment-17037801
]
Uwe Schindler commented on LUCENE-9201:
---
For debugging purposes you can force gradle to run all
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037798#comment-17037798
]
Uwe Schindler commented on LUCENE-9201:
---
The problem here looks like that the JavaExec task only
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037794#comment-17037794
]
Uwe Schindler commented on LUCENE-9201:
---
The problem is that the task does not define an Input
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037788#comment-17037788
]
Tomoko Uchida commented on LUCENE-9201:
---
[~dweiss] Thank you for your guidance and detailed
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034840#comment-17034840
]
Dawid Weiss commented on LUCENE-9201:
-
Hi [~tomoko]. Please take a look at the patch I just
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034639#comment-17034639
]
Robert Muir commented on LUCENE-9201:
-
Tomoko thank u for measuring. my cpu is not as good but this
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034462#comment-17034462
]
Tomoko Uchida commented on LUCENE-9201:
---
Just from curiosity, I roughly assessed the penalty of
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034420#comment-17034420
]
Dawid Weiss commented on LUCENE-9201:
-
Files.createSymbolicLink on a directory attempts to create a
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034402#comment-17034402
]
Robert Muir commented on LUCENE-9201:
-
Can we use symbolic links from windows yet? Sorry for the
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034400#comment-17034400
]
Robert Muir commented on LUCENE-9201:
-
{quote}
We might want an independent task to gather all
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034392#comment-17034392
]
Robert Muir commented on LUCENE-9201:
-
I have a proposal that maybe works better. I'll write it
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034375#comment-17034375
]
Tomoko Uchida commented on LUCENE-9201:
---
{quote}It is my personal preference to have a
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034361#comment-17034361
]
Dawid Weiss commented on LUCENE-9201:
-
Yeah, I did see some of it. I didn't look deep into how
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034357#comment-17034357
]
Robert Muir commented on LUCENE-9201:
-
"documentation-lint" checker lints more than just javadocs.
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034343#comment-17034343
]
Robert Muir commented on LUCENE-9201:
-
Dawid, have you looked at how the documentation links across
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034199#comment-17034199
]
Dawid Weiss commented on LUCENE-9201:
-
bq. we would need a special task to collect all javadocs to
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033936#comment-17033936
]
Robert Muir commented on LUCENE-9201:
-
maybe we should try to get the PR in and iterate from there?
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033658#comment-17033658
]
Dawid Weiss commented on LUCENE-9201:
-
Gradle's built-in javadoc task is indeed pretty dumb with
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17032905#comment-17032905
]
Robert Muir commented on LUCENE-9201:
-
If i remember, the problem with "just" converting to
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17032804#comment-17032804
]
Robert Muir commented on LUCENE-9201:
-
{quote}
Package summary: "ant documentation" uses
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17032615#comment-17032615
]
Robert Muir commented on LUCENE-9201:
-
OK, thanks for working on the PR. At a glance it looks good
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17032601#comment-17032601
]
Tomoko Uchida commented on LUCENE-9201:
---
Thank you [~rcmuir] for your work and comments.
I
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17032436#comment-17032436
]
Robert Muir commented on LUCENE-9201:
-
now that overview.html works, i tried investigating
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17032119#comment-17032119
]
Robert Muir commented on LUCENE-9201:
-
FYI I also discovered LUCENE-9210 as a part of investigations
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17032111#comment-17032111
]
ASF subversion and git services commented on LUCENE-9201:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17032110#comment-17032110
]
Robert Muir commented on LUCENE-9201:
-
I will push the obvious fix to master, but it would be great
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17032109#comment-17032109
]
Robert Muir commented on LUCENE-9201:
-
The missing overview.html is caused by bugs in the
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17032105#comment-17032105
]
Robert Muir commented on LUCENE-9201:
-
I looked in more on the package.html/overview.html. This
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17032103#comment-17032103
]
Robert Muir commented on LUCENE-9201:
-
With java 13+, the {{-html4}} option is removed. So we are
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17032100#comment-17032100
]
Robert Muir commented on LUCENE-9201:
-
{quote}
Package summary: "ant documentation" uses
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031858#comment-17031858
]
Robert Muir commented on LUCENE-9201:
-
[~tomoko] has a pull request for this issue already:
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031765#comment-17031765
]
Dawid Weiss commented on LUCENE-9201:
-
Please leave a patch or pull request. I will review and
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031718#comment-17031718
]
Robert Muir commented on LUCENE-9201:
-
I think gradle provides slightly different options to the
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031702#comment-17031702
]
Tomoko Uchida commented on LUCENE-9201:
---
[~erickerickson] I added sub-tasks equivalent to the ant
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17029977#comment-17029977
]
Erick Erickson commented on LUCENE-9201:
Tomoko:
I'm looking at the remaining python tasks, so
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028662#comment-17028662
]
Tomoko Uchida commented on LUCENE-9201:
---
This is WIP branch:
72 matches
Mail list logo
