[jira] [Created] (LUCENE-9358) BKDTree: remove unnecessary tree rotation for the one dimensional case

2020-05-04 Thread Ignacio Vera (Jira)
Ignacio Vera created LUCENE-9358: Summary: BKDTree: remove unnecessary tree rotation for the one dimensional case Key: LUCENE-9358 URL: https://issues.apache.org/jira/browse/LUCENE-9358 Project:

[jira] [Resolved] (SOLR-14431) SegmentsInfoRequestHandler.java does not release IndexWriter

2020-05-04 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki resolved SOLR-14431. - Resolution: Fixed I applied your fix and modified a unit test to ensure the fix works as

[GitHub] [lucene-solr] romseygeek opened a new pull request #1484: LUCENE-7889: Allow grouping on Double/LongValuesSource

2020-05-04 Thread GitBox
romseygeek opened a new pull request #1484: URL: https://github.com/apache/lucene-solr/pull/1484 The grouping module currently allows grouping on a SortedDocValues field, or on a ValueSource. The latter groups only on exact values, and so will not perform well on numeric-valued

[jira] [Commented] (LUCENE-7889) Allow grouping on DoubleValuesSource ranges

2020-05-04 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098908#comment-17098908 ] Alan Woodward commented on LUCENE-7889: --- Bringing this up to date, the refactored base test

[GitHub] [lucene-solr] madrob commented on a change in pull request #1482: LUCENE-7822: CodecUtil#checkFooter should throw a CorruptIndexException as the main exception.

2020-05-04 Thread GitBox
madrob commented on a change in pull request #1482: URL: https://github.com/apache/lucene-solr/pull/1482#discussion_r419467116 ## File path: lucene/core/src/test/org/apache/lucene/util/TestOfflineSorter.java ## @@ -353,12 +352,10 @@ protected void corruptFile() throws

[jira] [Commented] (LUCENE-9361) Consider removing CachingCollector

2020-05-04 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099014#comment-17099014 ] Michael McCandless commented on LUCENE-9361: Does the query cache also cache scores too now?

[GitHub] [lucene-solr] HoustonPutman commented on pull request #1480: SOLR-14456: Fix Content-Type header forwarding on compressed requests

2020-05-04 Thread GitBox
HoustonPutman commented on pull request #1480: URL: https://github.com/apache/lucene-solr/pull/1480#issuecomment-623527178 I think this issue should exist in `Http2SolrClient`, I see similar logic there. This is an

[GitHub] [lucene-solr] juanka588 commented on a change in pull request #1473: LUCENE-9353: Move terms metadata to its own file.

2020-05-04 Thread GitBox
juanka588 commented on a change in pull request #1473: URL: https://github.com/apache/lucene-solr/pull/1473#discussion_r419448277 ## File path: lucene/core/src/java/org/apache/lucene/codecs/blocktree/BlockTreeTermsWriter.java ## @@ -1060,36 +1052,35 @@ public void close()

[jira] [Commented] (LUCENE-9361) Consider removing CachingCollector

2020-05-04 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099020#comment-17099020 ] Alan Woodward commented on LUCENE-9361: --- > Does the query cache also cache scores too now? It

[jira] [Commented] (LUCENE-9361) Consider removing CachingCollector

2020-05-04 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099018#comment-17099018 ] Alan Woodward commented on LUCENE-9361: --- Note that we may want to move the implementation to Solr

[GitHub] [lucene-solr] madrob commented on a change in pull request #341: SOLR-12131: ExternalRoleRuleBasedAuthorizationPlugin

2020-05-04 Thread GitBox
madrob commented on a change in pull request #341: URL: https://github.com/apache/lucene-solr/pull/341#discussion_r419480359 ## File path: solr/core/src/java/org/apache/solr/security/RuleBasedAuthorizationPlugin.java ## @@ -16,329 +16,45 @@ */ package

[GitHub] [lucene-solr] HoustonPutman edited a comment on pull request #1480: SOLR-14456: Fix Content-Type header forwarding on compressed requests

2020-05-04 Thread GitBox
HoustonPutman edited a comment on pull request #1480: URL: https://github.com/apache/lucene-solr/pull/1480#issuecomment-623527178 I think this issue should exist in `Http2SolrClient`, I see similar logic there. That was just a cursory look though.

[jira] [Updated] (SOLR-14458) Solr Replica locked in recovering state after a Zookeeper disconnection

2020-05-04 Thread Endika Posadas (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Endika Posadas updated SOLR-14458: -- Description: In a solr cluster, a Solr instance containing two shards has lost connection

[GitHub] [lucene-solr] madrob commented on pull request #1480: SOLR-14456: Fix Content-Type header forwarding on compressed requests

2020-05-04 Thread GitBox
madrob commented on pull request #1480: URL: https://github.com/apache/lucene-solr/pull/1480#issuecomment-623493855 Sorry, accidentally closed the PR because I misunderstood what a button in the IntelliJ plugin was doing (I thought it was to close a popup, not close the PR).

[jira] [Commented] (SOLR-14400) two small SolrMetricsContext cleanups

2020-05-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099079#comment-17099079 ] ASF subversion and git services commented on SOLR-14400: Commit

[jira] [Commented] (SOLR-14400) two small SolrMetricsContext cleanups

2020-05-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099080#comment-17099080 ] ASF subversion and git services commented on SOLR-14400: Commit

[GitHub] [lucene-solr] madrob commented on pull request #341: SOLR-12131: ExternalRoleRuleBasedAuthorizationPlugin

2020-05-04 Thread GitBox
madrob commented on pull request #341: URL: https://github.com/apache/lucene-solr/pull/341#issuecomment-623502714 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Created] (LUCENE-9361) Consider removing CachingCollector

2020-05-04 Thread Alan Woodward (Jira)
Alan Woodward created LUCENE-9361: - Summary: Consider removing CachingCollector Key: LUCENE-9361 URL: https://issues.apache.org/jira/browse/LUCENE-9361 Project: Lucene - Core Issue Type:

[jira] [Updated] (SOLR-14400) two small SolrMetricsContext cleanups

2020-05-04 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke updated SOLR-14400: --- Fix Version/s: master (9.0) Resolution: Fixed Status: Resolved

[jira] [Commented] (LUCENE-9191) Fix linefiledocs compression or replace in tests

2020-05-04 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098909#comment-17098909 ] Michael McCandless commented on LUCENE-9191: OK, I can repro the above failure! 

[GitHub] [lucene-solr] juanka588 commented on a change in pull request #1473: LUCENE-9353: Move terms metadata to its own file.

2020-05-04 Thread GitBox
juanka588 commented on a change in pull request #1473: URL: https://github.com/apache/lucene-solr/pull/1473#discussion_r419449861 ## File path: lucene/core/src/java/org/apache/lucene/codecs/blocktree/BlockTreeTermsWriter.java ## @@ -1060,36 +1052,35 @@ public void close()

[jira] [Updated] (LUCENE-9191) Fix linefiledocs compression or replace in tests

2020-05-04 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-9191: --- Attachment: LUCENE-9191.patch Status: Reopened (was: Reopened) OK I found

[jira] [Resolved] (LUCENE-9348) Rework grouping tests to make it simpler to add new GroupSelector implementations

2020-05-04 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-9348. --- Fix Version/s: 8.6 Resolution: Fixed > Rework grouping tests to make it simpler to

[jira] [Commented] (LUCENE-9348) Rework grouping tests to make it simpler to add new GroupSelector implementations

2020-05-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098864#comment-17098864 ] ASF subversion and git services commented on LUCENE-9348: - Commit

[jira] [Created] (LUCENE-9360) ToParentDocValues uses advanceExact() of underneath DocValues

2020-05-04 Thread Mikhail Khludnev (Jira)
Mikhail Khludnev created LUCENE-9360: Summary: ToParentDocValues uses advanceExact() of underneath DocValues Key: LUCENE-9360 URL: https://issues.apache.org/jira/browse/LUCENE-9360 Project:

[jira] [Resolved] (SOLR-14450) SegmentsInfoRequestHandler doesn't properly close ref-counted IW

2020-05-04 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki resolved SOLR-14450. - Resolution: Duplicate > SegmentsInfoRequestHandler doesn't properly close ref-counted IW

[jira] [Updated] (SOLR-14431) SegmentsInfoRequestHandler.java does not release IndexWriter

2020-05-04 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-14431: Fix Version/s: 8.6 > SegmentsInfoRequestHandler.java does not release IndexWriter >

[jira] [Assigned] (SOLR-14431) SegmentsInfoRequestHandler.java does not release IndexWriter

2020-05-04 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki reassigned SOLR-14431: --- Assignee: Andrzej Bialecki > SegmentsInfoRequestHandler.java does not release

[jira] [Commented] (LUCENE-9360) ToParentDocValues uses advanceExact() of underneath DocValues

2020-05-04 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098872#comment-17098872 ] Adrien Grand commented on LUCENE-9360: -- I looked at the Jira but it's not clean to me what the

[jira] [Commented] (SOLR-13292) Provide extended per-segment status of a collection

2020-05-04 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098857#comment-17098857 ] Andrzej Bialecki commented on SOLR-13292: - Good point, David - I opened SOLR-14459. > Provide

[jira] [Created] (SOLR-14459) Close SolrClientCache in ColStatus

2020-05-04 Thread Andrzej Bialecki (Jira)
Andrzej Bialecki created SOLR-14459: --- Summary: Close SolrClientCache in ColStatus Key: SOLR-14459 URL: https://issues.apache.org/jira/browse/SOLR-14459 Project: Solr Issue Type: Bug

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1482: LUCENE-7822: CodecUtil#checkFooter should throw a CorruptIndexException as the main exception.

2020-05-04 Thread GitBox
mikemccand commented on a change in pull request #1482: URL: https://github.com/apache/lucene-solr/pull/1482#discussion_r419407888 ## File path: lucene/core/src/java/org/apache/lucene/codecs/CodecUtil.java ## @@ -448,24 +448,27 @@ public static void

[jira] [Commented] (SOLR-14431) SegmentsInfoRequestHandler.java does not release IndexWriter

2020-05-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098901#comment-17098901 ] ASF subversion and git services commented on SOLR-14431: Commit

[jira] [Commented] (SOLR-14431) SegmentsInfoRequestHandler.java does not release IndexWriter

2020-05-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098902#comment-17098902 ] ASF subversion and git services commented on SOLR-14431: Commit

[jira] [Created] (LUCENE-9359) SegmentInfos.readCommit should verify checksums in case of error

2020-05-04 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-9359: Summary: SegmentInfos.readCommit should verify checksums in case of error Key: LUCENE-9359 URL: https://issues.apache.org/jira/browse/LUCENE-9359 Project: Lucene -

[jira] [Commented] (LUCENE-9348) Rework grouping tests to make it simpler to add new GroupSelector implementations

2020-05-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098862#comment-17098862 ] ASF subversion and git services commented on LUCENE-9348: - Commit

[jira] [Commented] (LUCENE-9328) SortingGroupHead to reuse DocValues

2020-05-04 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1709#comment-1709 ] Lucene/Solr QA commented on LUCENE-9328: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[GitHub] [lucene-solr] romseygeek commented on a change in pull request #1462: LUCENE-9328: open group.sort docvalues once per segment.

2020-05-04 Thread GitBox
romseygeek commented on a change in pull request #1462: URL: https://github.com/apache/lucene-solr/pull/1462#discussion_r419289810 ## File path: lucene/grouping/src/test/org/apache/lucene/search/grouping/DocValuesPoolingReaderTest.java ## @@ -0,0 +1,150 @@ +/* + * Licensed to

[jira] [Created] (SOLR-14458) Solr Replica locked in recovering state after a Zookeeper disconnection

2020-05-04 Thread Endika Posadas (Jira)
Endika Posadas created SOLR-14458: - Summary: Solr Replica locked in recovering state after a Zookeeper disconnection Key: SOLR-14458 URL: https://issues.apache.org/jira/browse/SOLR-14458 Project:

[GitHub] [lucene-solr] juanka588 commented on a change in pull request #1473: LUCENE-9353: Move terms metadata to its own file.

2020-05-04 Thread GitBox
juanka588 commented on a change in pull request #1473: URL: https://github.com/apache/lucene-solr/pull/1473#discussion_r419337819 ## File path: lucene/core/src/java/org/apache/lucene/codecs/blocktree/BlockTreeTermsWriter.java ## @@ -1060,36 +1052,35 @@ public void close()

[jira] [Updated] (SOLR-14458) Solr Replica locked in recovering state after a Zookeeper disconnection

2020-05-04 Thread Endika Posadas (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Endika Posadas updated SOLR-14458: -- Attachment: solrrecovering.png > Solr Replica locked in recovering state after a Zookeeper

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1473: LUCENE-9353: Move terms metadata to its own file.

2020-05-04 Thread GitBox
jpountz commented on a change in pull request #1473: URL: https://github.com/apache/lucene-solr/pull/1473#discussion_r419391721 ## File path: lucene/core/src/java/org/apache/lucene/codecs/blocktree/BlockTreeTermsWriter.java ## @@ -1060,36 +1052,35 @@ public void close()

[GitHub] [lucene-solr] jpountz opened a new pull request #1483: LUCENE-9359: Always call checkFooter in SegmentInfos#readCommit.

2020-05-04 Thread GitBox
jpountz opened a new pull request #1483: URL: https://github.com/apache/lucene-solr/pull/1483 See https://issues.apache.org/jira/browse/LUCENE-9359. This builds on top of LUCENE-7822. To make the review easier I'd advise to add `?w=1` to the URL to ignore whitespace changes.

[GitHub] [lucene-solr] MarcusSorealheis commented on pull request #1471: SOLR-14014 PR Against Master

2020-05-04 Thread GitBox
MarcusSorealheis commented on pull request #1471: URL: https://github.com/apache/lucene-solr/pull/1471#issuecomment-623629267 > Here, I take UI instance that was previously started when ADMIN UI was enabled, disabled the admin ui via system property, and then show the result. The first

[jira] [Commented] (SOLR-14423) static caches in StreamHandler ought to move to CoreContainer lifecycle

2020-05-04 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099091#comment-17099091 ] Christine Poerschke commented on SOLR-14423: bq. ... StreamHandler (at "/stream") has several

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099256#comment-17099256 ] Dawid Weiss commented on LUCENE-9321: - Thanks. Could be me just not expressing myself clearly. I

[GitHub] [lucene-solr] samuelgmartinez edited a comment on pull request #1480: SOLR-14456: Fix Content-Type header forwarding on compressed requests

2020-05-04 Thread GitBox
samuelgmartinez edited a comment on pull request #1480: URL: https://github.com/apache/lucene-solr/pull/1480#issuecomment-623599049 > I think this issue should exist in `Http2SolrClient`, I see similar logic there. That was just a cursory look though. I reviewed it and existing code

[GitHub] [lucene-solr] samuelgmartinez commented on pull request #1480: SOLR-14456: Fix Content-Type header forwarding on compressed requests

2020-05-04 Thread GitBox
samuelgmartinez commented on pull request #1480: URL: https://github.com/apache/lucene-solr/pull/1480#issuecomment-623599049 > I think this issue should exist in `Http2SolrClient`, I see similar logic there. That was just a cursory look though. I reviewed it and it's now properly

[jira] [Commented] (LUCENE-9191) Fix linefiledocs compression or replace in tests

2020-05-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099163#comment-17099163 ] ASF subversion and git services commented on LUCENE-9191: - Commit

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-04 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099249#comment-17099249 ] Uwe Schindler commented on LUCENE-9321: --- Hi Dawid, That's my plan. I will work on that. I will

[jira] [Commented] (SOLR-14454) support for UTF-8 (string) types with DocValuesType.BINARY

2020-05-04 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099107#comment-17099107 ] Michael Gibney commented on SOLR-14454: --- I'm sorry I missed SOLR-10255, thanks for calling

[jira] [Commented] (LUCENE-9191) Fix linefiledocs compression or replace in tests

2020-05-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099166#comment-17099166 ] ASF subversion and git services commented on LUCENE-9191: - Commit

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099229#comment-17099229 ] Dawid Weiss commented on LUCENE-9321: - I read your comment in details (the previous time as well,

[jira] [Commented] (LUCENE-9148) Move the BKD index to its own file.

2020-05-04 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099192#comment-17099192 ] Michael McCandless commented on LUCENE-9148: {quote}So I started working on splitting it

[GitHub] [lucene-solr] mkhludnev commented on pull request #1462: LUCENE-9328: open group.sort docvalues once per segment.

2020-05-04 Thread GitBox
mkhludnev commented on pull request #1462: URL: https://github.com/apache/lucene-solr/pull/1462#issuecomment-623695126 @romseygeek tests in the patch are dummy. The key evidence that existing grouping tests keeps passing.

[jira] [Commented] (LUCENE-9357) AssertingSorted(Set|Numeric)DocValues should be unwrappable

2020-05-04 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099311#comment-17099311 ] Adrien Grand commented on LUCENE-9357: -- +1 to this proposal >

[GitHub] [lucene-solr] mkhludnev commented on a change in pull request #1462: LUCENE-9328: open group.sort docvalues once per segment.

2020-05-04 Thread GitBox
mkhludnev commented on a change in pull request #1462: URL: https://github.com/apache/lucene-solr/pull/1462#discussion_r419706467 ## File path: lucene/grouping/src/test/org/apache/lucene/search/grouping/DocValuesPoolingReaderTest.java ## @@ -0,0 +1,150 @@ +/* + * Licensed to

[GitHub] [lucene-solr] mkhludnev commented on a change in pull request #1462: LUCENE-9328: open group.sort docvalues once per segment.

2020-05-04 Thread GitBox
mkhludnev commented on a change in pull request #1462: URL: https://github.com/apache/lucene-solr/pull/1462#discussion_r419713904 ## File path: lucene/grouping/src/java/org/apache/lucene/search/grouping/DocValuesPoolingReader.java ## @@ -0,0 +1,175 @@ +/* + * Licensed to the

[jira] [Commented] (LUCENE-9360) NOT NEEDED. ToParentDocValues uses advanceExact() of underneath DocValues

2020-05-04 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099354#comment-17099354 ] Mikhail Khludnev commented on LUCENE-9360: -- [~jpountz], I were rushing through test failures.

[jira] [Commented] (SOLR-14014) Allow Solr to start with Admin UI disabled

2020-05-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099374#comment-17099374 ] ASF subversion and git services commented on SOLR-14014: Commit

[jira] [Resolved] (SOLR-14014) Allow Solr to start with Admin UI disabled

2020-05-04 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-14014. -- Fix Version/s: master (9.0) Resolution: Fixed Thanks for taking this on, [~marcussorealheis]!

[jira] [Assigned] (SOLR-14014) Allow Solr to start with Admin UI disabled

2020-05-04 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob reassigned SOLR-14014: Assignee: Mike Drob > Allow Solr to start with Admin UI disabled >

[jira] [Commented] (LUCENE-9148) Move the BKD index to its own file.

2020-05-04 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099293#comment-17099293 ] Adrien Grand commented on LUCENE-9148: -- Not one file per field, it would be horrible. :) My current

[GitHub] [lucene-solr] mkhludnev commented on a change in pull request #1462: LUCENE-9328: open group.sort docvalues once per segment.

2020-05-04 Thread GitBox
mkhludnev commented on a change in pull request #1462: URL: https://github.com/apache/lucene-solr/pull/1462#discussion_r419713904 ## File path: lucene/grouping/src/java/org/apache/lucene/search/grouping/DocValuesPoolingReader.java ## @@ -0,0 +1,175 @@ +/* + * Licensed to the

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1473: LUCENE-9353: Move terms metadata to its own file.

2020-05-04 Thread GitBox
jpountz commented on a change in pull request #1473: URL: https://github.com/apache/lucene-solr/pull/1473#discussion_r419694045 ## File path: lucene/core/src/java/org/apache/lucene/codecs/blocktree/BlockTreeTermsWriter.java ## @@ -1060,36 +1052,35 @@ public void close()

[GitHub] [lucene-solr] mkhludnev commented on a change in pull request #1462: LUCENE-9328: open group.sort docvalues once per segment.

2020-05-04 Thread GitBox
mkhludnev commented on a change in pull request #1462: URL: https://github.com/apache/lucene-solr/pull/1462#discussion_r419715037 ## File path: lucene/grouping/src/java/org/apache/lucene/search/grouping/DocValuesPoolingReader.java ## @@ -0,0 +1,175 @@ +/* + * Licensed to the

[jira] [Updated] (LUCENE-9328) SortingGroupHead to reuse DocValues

2020-05-04 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated LUCENE-9328: - Attachment: LUCENE-9328.patch Status: Patch Available (was: Patch Available)

[jira] [Updated] (LUCENE-9360) NOT NEEDED. ToParentDocValues uses advanceExact() of underneath DocValues

2020-05-04 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated LUCENE-9360: - Summary: NOT NEEDED. ToParentDocValues uses advanceExact() of underneath DocValues

[jira] [Commented] (LUCENE-9328) SortingGroupHead to reuse DocValues

2020-05-04 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099444#comment-17099444 ] Lucene/Solr QA commented on LUCENE-9328: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1456: SOLR-13289: Support for BlockMax WAND

2020-05-04 Thread GitBox
tflobbe commented on a change in pull request #1456: URL: https://github.com/apache/lucene-solr/pull/1456#discussion_r419791575 ## File path: solr/core/src/test/org/apache/solr/request/TestFaceting.java ## @@ -931,5 +934,28 @@ public void testListedTermCounts() throws

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1456: SOLR-13289: Support for BlockMax WAND

2020-05-04 Thread GitBox
tflobbe commented on a change in pull request #1456: URL: https://github.com/apache/lucene-solr/pull/1456#discussion_r419791807 ## File path: solr/core/src/test/org/apache/solr/search/SolrIndexSearcherTest.java ## @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (SOLR-13132) Improve JSON "terms" facet performance when sorted by relatedness

2020-05-04 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099437#comment-17099437 ] Chris M. Hostetter commented on SOLR-13132: --- [~mgibney]- beefing up the randomized testing of

[jira] [Resolved] (SOLR-7111) Better handling of relative links for SimplePostTool

2020-05-04 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-7111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-7111. --- Resolution: Won't Fix This is not a full-blown crawler, let's not try to make it one :) > Better

[GitHub] [lucene-solr] iverase opened a new pull request #1481: LUCENE-9358: remove unnecessary tree rotation for the one dimensional case

2020-05-04 Thread GitBox
iverase opened a new pull request #1481: URL: https://github.com/apache/lucene-solr/pull/1481 This commit changes the way the multi-dimensional tree builder generates the intermediate tree representation to be equal to the one dimensional case. Therefore, the index packing logic can be

[GitHub] [lucene-solr] jpountz opened a new pull request #1482: LUCENE-7822: CodecUtil#checkFooter should throw a CorruptIndexException as the main exception.

2020-05-04 Thread GitBox
jpountz opened a new pull request #1482: URL: https://github.com/apache/lucene-solr/pull/1482 See https://issues.apache.org/jira/browse/LUCENE-7822. This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (LUCENE-7822) IllegalArgumentException thrown instead of a CorruptIndexException

2020-05-04 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098750#comment-17098750 ] Adrien Grand commented on LUCENE-7822: -- I opened 

[jira] [Updated] (LUCENE-9328) SortingGroupHead to reuse DocValues

2020-05-04 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated LUCENE-9328: - Attachment: LUCENE-9328.patch Status: Patch Available (was: Patch Available) >

[jira] [Resolved] (SOLR-8579) TLP website identity updates

2020-05-04 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-8579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-8579. --- Resolution: Fixed > TLP website identity updates > > >