[GitHub] [lucene] jtibshirani commented on pull request #656: LUCENE-10382: Support filtering in KnnVectorQuery

2022-02-14 Thread GitBox
jtibshirani commented on pull request #656: URL: https://github.com/apache/lucene/pull/656#issuecomment-1039714498 @msokolov @jpountz @mayya-sharipova this is ready for another look. Notable changes: * When computing the filter results, only include documents that actually contain a

[jira] [Commented] (LUCENE-10084) Rewrite DocValuesFieldExistsQuery to a MatchAllDocsQuery when docCount == maxDoc

2022-02-14 Thread Vigya Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492267#comment-17492267 ] Vigya Sharma commented on LUCENE-10084: --- Hi [~jpountz], I gave this a try -

[jira] [Comment Edited] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-14 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17491871#comment-17491871 ] Uwe Schindler edited comment on LUCENE-10419 at 2/14/22, 8:48 AM: --

[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers

2022-02-14 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17491871#comment-17491871 ] Uwe Schindler commented on LUCENE-10419: When I have seen this in docs, I was thinking about:

[jira] [Commented] (LUCENE-10421) Non-deterministic results from KnnVectorQuery?

2022-02-14 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492056#comment-17492056 ] Michael Sokolov commented on LUCENE-10421: -- Yeah, there is really no value I can see in

[GitHub] [lucene] uschindler commented on pull request #673: LUCENE-10420: Move functional interfaces in IOUtils to top-level interfaces

2022-02-14 Thread GitBox
uschindler commented on pull request #673: URL: https://github.com/apache/lucene/pull/673#issuecomment-1039214098 Followup PR: #680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [lucene] uschindler opened a new pull request #680: LUCENE-10420: Remove deprecated interfaces and methods in IOUtils in main

2022-02-14 Thread GitBox
uschindler opened a new pull request #680: URL: https://github.com/apache/lucene/pull/680 Followup of #673 This removes the interfaces but also removes a method I forgot when cleaning up for module system. Thiscould be a separate issue, but I will do it together with this one.

[jira] [Created] (LUCENE-10421) Non-deterministic results from KnnVectorQuery?

2022-02-14 Thread Michael McCandless (Jira)
Michael McCandless created LUCENE-10421: --- Summary: Non-deterministic results from KnnVectorQuery? Key: LUCENE-10421 URL: https://issues.apache.org/jira/browse/LUCENE-10421 Project: Lucene - Core

[jira] [Commented] (LUCENE-10421) Non-deterministic results from KnnVectorQuery?

2022-02-14 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492022#comment-17492022 ] Michael Sokolov commented on LUCENE-10421: --  I think we have always had this time-dependent

[jira] [Commented] (LUCENE-10421) Non-deterministic results from KnnVectorQuery?

2022-02-14 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492028#comment-17492028 ] Michael Sokolov commented on LUCENE-10421: -- (seems to depend on the query's toString()):  

[jira] [Commented] (LUCENE-10421) Non-deterministic results from KnnVectorQuery?

2022-02-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492034#comment-17492034 ] Robert Muir commented on LUCENE-10421: -- Can we just make this default seed a constant? And let's

[GitHub] [lucene] mocobeta merged pull request #673: LUCENE-10420: Move functional interfaces in IOUtils to top-level interfaces

2022-02-14 Thread GitBox
mocobeta merged pull request #673: URL: https://github.com/apache/lucene/pull/673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (LUCENE-10420) Move functional interfaces in IOUtils to top-level interfaces

2022-02-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492051#comment-17492051 ] ASF subversion and git services commented on LUCENE-10420: -- Commit

[GitHub] [lucene] uschindler commented on pull request #673: LUCENE-10420: Move functional interfaces in IOUtils to top-level interfaces

2022-02-14 Thread GitBox
uschindler commented on pull request #673: URL: https://github.com/apache/lucene/pull/673#issuecomment-1039203047 I can do the main branch cleanup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-10157) Add Additional Indri Search Engine Functionality to Lucene

2022-02-14 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492075#comment-17492075 ] Christine Poerschke commented on LUCENE-10157: -- So on the open "jar question" here –

[jira] [Commented] (LUCENE-10420) Move functional interfaces in IOUtils to top-level interfaces

2022-02-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492076#comment-17492076 ] ASF subversion and git services commented on LUCENE-10420: -- Commit

[GitHub] [lucene] uschindler merged pull request #680: LUCENE-10420: Remove deprecated interfaces and methods in IOUtils in main

2022-02-14 Thread GitBox
uschindler merged pull request #680: URL: https://github.com/apache/lucene/pull/680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (LUCENE-10157) Add Additional Indri Search Engine Functionality to Lucene

2022-02-14 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492075#comment-17492075 ] Christine Poerschke edited comment on LUCENE-10157 at 2/14/22, 4:07 PM:

[GitHub] [lucene] mocobeta commented on pull request #673: LUCENE-10420: Move functional interfaces in IOUtils to top-level interfaces

2022-02-14 Thread GitBox
mocobeta commented on pull request #673: URL: https://github.com/apache/lucene/pull/673#issuecomment-1039190434 Thanks, I will merge this now - then backport it to the 9x branch. I have little time this week... but will be back (maybe next week) and make another PR to remove the

[jira] [Created] (LUCENE-10422) Monitor instantiation configurabilty improvements

2022-02-14 Thread Niko Usai (Jira)
Niko Usai created LUCENE-10422: -- Summary: Monitor instantiation configurabilty improvements Key: LUCENE-10422 URL: https://issues.apache.org/jira/browse/LUCENE-10422 Project: Lucene - Core

[jira] [Commented] (LUCENE-10421) Non-deterministic results from KnnVectorQuery?

2022-02-14 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492026#comment-17492026 ] Michael Sokolov commented on LUCENE-10421: --

[GitHub] [lucene] mogui opened a new pull request #679: Monitor Improvements LUCENE-10422

2022-02-14 Thread GitBox
mogui opened a new pull request #679: URL: https://github.com/apache/lucene/pull/679 # Description Change how Monitor manages it's directory, IndexWriter and IndexReader, giving the possibility to - use a custom Directory implementation - use a readonly QueryIndex in order

[jira] [Commented] (LUCENE-10421) Non-deterministic results from KnnVectorQuery?

2022-02-14 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492040#comment-17492040 ] Tomoko Uchida commented on LUCENE-10421: I think the non-deterministic property (when indexing)

[jira] [Commented] (LUCENE-10421) Non-deterministic results from KnnVectorQuery?

2022-02-14 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492042#comment-17492042 ] Tomoko Uchida commented on LUCENE-10421: Making the default seed a constant would also make

[jira] [Commented] (LUCENE-10420) Move functional interfaces in IOUtils to top-level interfaces

2022-02-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492063#comment-17492063 ] ASF subversion and git services commented on LUCENE-10420: -- Commit

[jira] [Commented] (LUCENE-10157) Add Additional Indri Search Engine Functionality to Lucene

2022-02-14 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492079#comment-17492079 ] Christine Poerschke commented on LUCENE-10157: -- If (and that is an if) the choice is

[GitHub] [lucene] uschindler closed pull request #173: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) Panama APIs (>= JDK-16-ea-b32)

2022-02-14 Thread GitBox
uschindler closed pull request #173: URL: https://github.com/apache/lucene/pull/173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] uschindler commented on pull request #173: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) Panama APIs (>= JDK-16-ea-b32)

2022-02-14 Thread GitBox
uschindler commented on pull request #173: URL: https://github.com/apache/lucene/pull/173#issuecomment-1039342764 This PR is no longer maintained! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene] jtibshirani commented on a change in pull request #649: LUCENE-10408 Better encoding of doc Ids in vectors

2022-02-14 Thread GitBox
jtibshirani commented on a change in pull request #649: URL: https://github.com/apache/lucene/pull/649#discussion_r806160008 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsWriter.java ## @@ -206,14 +203,22 @@ private void writeMeta(