[GitHub] [lucene-solr] MarcusSorealheis commented on a change in pull request #1471: Revised SOLR-14014 PR Against Master

2020-05-03 Thread GitBox
MarcusSorealheis commented on a change in pull request #1471: URL: https://github.com/apache/lucene-solr/pull/1471#discussion_r419210970 ## File path: solr/core/src/java/org/apache/solr/servlet/LoadAdminUiServlet.java ## @@ -24,29 +31,26 @@ import

[GitHub] [lucene-solr] CaoManhDat commented on a change in pull request #1470: SOLR-14354: Async or using threads in better way for HttpShardHandler

2020-05-03 Thread GitBox
CaoManhDat commented on a change in pull request #1470: URL: https://github.com/apache/lucene-solr/pull/1470#discussion_r419198072 ## File path: solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java ## @@ -259,12 +261,10 @@ private ShardResponse

[jira] [Commented] (SOLR-14454) support for UTF-8 (string) types with DocValuesType.BINARY

2020-05-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098625#comment-17098625 ] David Smiley commented on SOLR-14454: - Please see SOLR-10255 which I worked on years ago which seems

[jira] [Commented] (SOLR-14454) support for UTF-8 (string) types with DocValuesType.BINARY

2020-05-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098622#comment-17098622 ] David Smiley commented on SOLR-14454: - The first two seem promising but I don't think the 3rd

[jira] [Commented] (LUCENE-9328) SortingGroupHead to reuse DocValues

2020-05-03 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098619#comment-17098619 ] Lucene/Solr QA commented on LUCENE-9328: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[GitHub] [lucene-solr] janhoy commented on a change in pull request #341: SOLR-12131: ExternalRoleRuleBasedAuthorizationPlugin

2020-05-03 Thread GitBox
janhoy commented on a change in pull request #341: URL: https://github.com/apache/lucene-solr/pull/341#discussion_r419163646 ## File path: solr/core/src/java/org/apache/solr/security/RuleBasedAuthorizationPlugin.java ## @@ -16,329 +16,45 @@ */ package

[jira] [Commented] (SOLR-12131) Authorization plugin support for getting user's roles from the outside

2020-05-03 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098574#comment-17098574 ] Jan Høydahl commented on SOLR-12131: See updated PR * Brought up to date with master branch *

[GitHub] [lucene-solr] janhoy commented on a change in pull request #341: SOLR-12131: ExternalRoleRuleBasedAuthorizationPlugin

2020-05-03 Thread GitBox
janhoy commented on a change in pull request #341: URL: https://github.com/apache/lucene-solr/pull/341#discussion_r418962495 ## File path: solr/core/src/test/org/apache/solr/security/BaseTestRuleBasedAuthorizationPlugin.java ## @@ -43,47 +45,61 @@ import

[jira] [Commented] (LUCENE-9328) SortingGroupHead to reuse DocValues

2020-05-03 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098555#comment-17098555 ] Mikhail Khludnev commented on LUCENE-9328: -- It's better than I expected. * Asserting DVs and

[jira] [Updated] (LUCENE-9328) SortingGroupHead to reuse DocValues

2020-05-03 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated LUCENE-9328: - Attachment: LUCENE-9328.patch Status: Patch Available (was: Patch Available) >

[jira] [Commented] (SOLR-14351) Harden MDCLoggingContext.clear depth tracking

2020-05-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098453#comment-17098453 ] ASF subversion and git services commented on SOLR-14351: Commit

[jira] [Commented] (SOLR-14351) Harden MDCLoggingContext.clear depth tracking

2020-05-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098451#comment-17098451 ] ASF subversion and git services commented on SOLR-14351: Commit

[jira] [Resolved] (LUCENE-9201) Port documentation-lint task to Gradle build

2020-05-03 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida resolved LUCENE-9201. --- Fix Version/s: master (9.0) Resolution: Fixed > Port documentation-lint task to

[jira] [Commented] (LUCENE-9201) Port documentation-lint task to Gradle build

2020-05-03 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098447#comment-17098447 ] Tomoko Uchida commented on LUCENE-9201: --- To organize issues and avoid confusion, I would like to

[jira] [Commented] (LUCENE-7871) false positive match BlockJoinSelector[SortedDV] when child value is absent

2020-05-03 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098430#comment-17098430 ] Mikhail Khludnev commented on LUCENE-7871: -- [~jpountz] Sorry for flashing it back after two

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-03 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098401#comment-17098401 ] Tomoko Uchida commented on LUCENE-9321: --- (It's merely my personal preference, but I really do not

[jira] [Created] (LUCENE-9357) AssertingSorted(Set|Numeric)DocValues should be unwrappable

2020-05-03 Thread Mikhail Khludnev (Jira)
Mikhail Khludnev created LUCENE-9357: Summary: AssertingSorted(Set|Numeric)DocValues should be unwrappable Key: LUCENE-9357 URL: https://issues.apache.org/jira/browse/LUCENE-9357 Project: Lucene

[jira] [Commented] (SOLR-14419) Query DLS {"param":"ref"}

2020-05-03 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098392#comment-17098392 ] Mikhail Khludnev commented on SOLR-14419: - Colleagues, are there any opinions? > Query DLS

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098390#comment-17098390 ] Uwe Schindler commented on LUCENE-9321: --- IMHO: I agree with Dawid, Solr Javadocs should not have

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098388#comment-17098388 ] Uwe Schindler commented on LUCENE-9321: --- The Solr bundle does not have the Lucene javadocs, so

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-03 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098385#comment-17098385 ] Tomoko Uchida commented on LUCENE-9321: --- bq. I would like to prevent that by just having relative

[jira] [Comment Edited] (LUCENE-9321) Port documentation task to gradle

2020-05-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098363#comment-17098363 ] Uwe Schindler edited comment on LUCENE-9321 at 5/3/20, 11:37 AM: - I was

[jira] [Updated] (LUCENE-9321) Port documentation task to gradle

2020-05-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-9321: -- Fix Version/s: master (9.0) > Port documentation task to gradle >

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098384#comment-17098384 ] Uwe Schindler commented on LUCENE-9321: --- [~tomoko]: You have unassigned, I will take this issue.

[jira] [Assigned] (LUCENE-9321) Port documentation task to gradle

2020-05-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler reassigned LUCENE-9321: - Assignee: Uwe Schindler > Port documentation task to gradle >

[jira] [Comment Edited] (LUCENE-9321) Port documentation task to gradle

2020-05-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098363#comment-17098363 ] Uwe Schindler edited comment on LUCENE-9321 at 5/3/20, 11:34 AM: - I was

[jira] [Comment Edited] (LUCENE-9321) Port documentation task to gradle

2020-05-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098368#comment-17098368 ] Uwe Schindler edited comment on LUCENE-9321 at 5/3/20, 11:32 AM: - bq. I

[jira] [Issue Comment Deleted] (LUCENE-9321) Port documentation task to gradle

2020-05-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-9321: -- Comment: was deleted (was: By the way I explained that very detailed in my proposal. Please

[jira] [Assigned] (LUCENE-9321) Port documentation task to gradle

2020-05-03 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida reassigned LUCENE-9321: - Assignee: (was: Tomoko Uchida) > Port documentation task to gradle >

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098369#comment-17098369 ] Uwe Schindler commented on LUCENE-9321: --- By the way I explained that very detailed in my proposal.

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098368#comment-17098368 ] Uwe Schindler commented on LUCENE-9321: --- bq. I wouldn't require a second (independent) build pass.

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098363#comment-17098363 ] Uwe Schindler commented on LUCENE-9321: --- I was talking about historic javadocs with absolute links

[jira] [Resolved] (LUCENE-9087) Should the BKD tree use a fixed maxPointsInLeafNode?

2020-05-03 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera resolved LUCENE-9087. -- Fix Version/s: 8.6 Assignee: Ignacio Vera Resolution: Fixed > Should the BKD

[GitHub] [lucene-solr] samuelgmartinez opened a new pull request #1480: SOLR-14456: Fix Content-Type header forwarding on compressed requests

2020-05-03 Thread GitBox
samuelgmartinez opened a new pull request #1480: URL: https://github.com/apache/lucene-solr/pull/1480 # Description `HttpSolrCall` and `HttpSolrClient` were using `Content-Encoding` header incorrectly, as they were setting the charset as the encoding for the request. This bug

[jira] [Commented] (LUCENE-7822) IllegalArgumentException thrown instead of a CorruptIndexException

2020-05-03 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098298#comment-17098298 ] Adrien Grand commented on LUCENE-7822: -- I'd like to revive this issue since I agree with Martin

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-03 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098273#comment-17098273 ] Tomoko Uchida commented on LUCENE-9321: --- {quote}I don't like it to publish HTML pages on

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-03 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098254#comment-17098254 ] Tomoko Uchida commented on LUCENE-9321: --- bq. Maybe we can dump all links by inserting 'print' and

[jira] [Commented] (SOLR-14351) Harden MDCLoggingContext.clear depth tracking

2020-05-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098250#comment-17098250 ] David Smiley commented on SOLR-14351: - Looks like I goofed in ZkContainer.java in which I removed the