ErickErickson commented on a change in pull request #1535:
URL: https://github.com/apache/lucene-solr/pull/1535#discussion_r429692516
##
File path: solr/core/src/java/org/apache/solr/search/facet/FacetParser.java
##
@@ -16,18 +16,22 @@
*/
package
dsmiley commented on a change in pull request #1535:
URL: https://github.com/apache/lucene-solr/pull/1535#discussion_r429689783
##
File path: solr/core/src/java/org/apache/solr/search/facet/FacetParser.java
##
@@ -16,18 +16,22 @@
*/
package org.apache.solr.search.facet;
[
https://issues.apache.org/jira/browse/SOLR-14474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115599#comment-17115599
]
Erick Erickson commented on SOLR-14474:
---
New PR up, incorporates David's comments. Thanks!
> Fix
ErickErickson opened a new pull request #1535:
URL: https://github.com/apache/lucene-solr/pull/1535
Version 2, incorporating D. Smiley's comments, thanks!
This is an automated message from the Apache Git Service.
To respond
[
https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115553#comment-17115553
]
Michael McCandless commented on LUCENE-9378:
{quote}As an alternative to API changes and
ErickErickson commented on pull request #1533:
URL: https://github.com/apache/lucene-solr/pull/1533#issuecomment-633235060
> Thanks for doing this!
>
> There are subclasses of FacetParser that are located as inner classes
within FacetRequest. I think they should be moved to be inner
ErickErickson closed pull request #1533:
URL: https://github.com/apache/lucene-solr/pull/1533
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
ErickErickson commented on a change in pull request #1533:
URL: https://github.com/apache/lucene-solr/pull/1533#discussion_r429638118
##
File path:
solr/core/src/java/org/apache/solr/handler/component/StatsComponent.java
##
@@ -167,89 +167,91 @@ public void
ErickErickson commented on a change in pull request #1533:
URL: https://github.com/apache/lucene-solr/pull/1533#discussion_r429630097
##
File path: solr/core/src/java/org/apache/solr/update/TransactionLog.java
##
@@ -657,7 +659,8 @@ public LogReader(long startingPos) {
}
ErickErickson commented on a change in pull request #1533:
URL: https://github.com/apache/lucene-solr/pull/1533#discussion_r429629302
##
File path: solr/core/src/java/org/apache/solr/cloud/OverseerElectionContext.java
##
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/SOLR-14504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115157#comment-17115157
]
ASF subversion and git services commented on SOLR-14504:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated SOLR-14280:
--
Attachment: getmessages.txt
Status: Patch Available (was: Patch Available)
It'd be
[
https://issues.apache.org/jira/browse/SOLR-14347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115075#comment-17115075
]
Ilan Ginzburg commented on SOLR-14347:
--
[~ab] I am blocked due to the issue reported above of
[
https://issues.apache.org/jira/browse/SOLR-14469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115034#comment-17115034
]
David Smiley commented on SOLR-14469:
-
I'd prefer we do nothing more than what we're already doing --
14 matches
Mail list logo
