[GitHub] [lucene-solr] dweiss commented on pull request #1816: LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation

2020-09-03 Thread GitBox
dweiss commented on pull request #1816: URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-686928388 I'll take a look later as to why this doesn't build. The problem with individual suppressions remains though - you can go by category but I think there will be still places

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1816: LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation

2020-09-03 Thread GitBox
dweiss commented on a change in pull request #1816: URL: https://github.com/apache/lucene-solr/pull/1816#discussion_r483402573 ## File path: build.gradle ## @@ -127,6 +128,9 @@ apply from: file('gradle/ide/intellij-idea.gradle') apply from: file('gradle/ide/eclipse.gradle')

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1816: LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation

2020-09-03 Thread GitBox
dweiss commented on a change in pull request #1816: URL: https://github.com/apache/lucene-solr/pull/1816#discussion_r483402784 ## File path: gradle/validation/error-prone.gradle ## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[jira] [Commented] (SOLR-13652) Remove update from initParams in example solrconfig files that only mention "df"

2020-09-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190551#comment-17190551 ] David Smiley commented on SOLR-13652: - I'd think your SIP-10 should have this "learning config"

[jira] [Updated] (SOLR-14802) Sorting by min of two geodist functions

2020-09-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-14802: Component/s: (was: query) spatial Affects Version/s: (was:

[jira] [Commented] (SOLR-14802) Sorting by min of two geodist functions

2020-09-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190535#comment-17190535 ] David Smiley commented on SOLR-14802: - I think you're right; this ought to be supported and isn't

[jira] [Commented] (SOLR-12298) Index Full nested document Hierarchy For Queries (umbrella issue)

2020-09-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190530#comment-17190530 ] David Smiley commented on SOLR-12298: - > Question on this work: if a child document is stored in a

[jira] [Updated] (SOLR-14829) Default components are missing facet_module and terms in documentation

2020-09-03 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Rafalovitch updated SOLR-14829: - Component/s: examples > Default components are missing facet_module and terms in

[GitHub] [lucene-solr] chatman commented on a change in pull request #1827: SOLR-14792: Remove VelocityResponseWriter

2020-09-03 Thread GitBox
chatman commented on a change in pull request #1827: URL: https://github.com/apache/lucene-solr/pull/1827#discussion_r483335351 ## File path: solr/example/files/conf/lang/stemdict_nl.txt ## @@ -1,6 +0,0 @@ -# Set of overrides for the dutch stemmer -# TODO: load this as a

[GitHub] [lucene-solr] erikhatcher opened a new pull request #1827: SOLR-14792: Remove VelocityResponseWriter

2020-09-03 Thread GitBox
erikhatcher opened a new pull request #1827: URL: https://github.com/apache/lucene-solr/pull/1827 # Description Remove VelocityResponseWriter and its references and usages. # Solution Removed contrib/velocity and all related uses. # Tests Will

[GitHub] [lucene-solr] noblepaul commented on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
noblepaul commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686839493 I see a consistent theme here. We are always combing through comments with a lens to see if the tone is correct, if somebody uses the correct case in typing or if the

[jira] [Created] (SOLR-14830) Synchronizing reference and master branches

2020-09-03 Thread Ishan Chattopadhyaya (Jira)
Ishan Chattopadhyaya created SOLR-14830: --- Summary: Synchronizing reference and master branches Key: SOLR-14830 URL: https://issues.apache.org/jira/browse/SOLR-14830 Project: Solr Issue

[GitHub] [lucene-solr] tflobbe commented on pull request #1816: LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation

2020-09-03 Thread GitBox
tflobbe commented on pull request #1816: URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-686831857 Hey, just in case you haven't seen it, there is a related email in the dev list about static analysis using a Github App. See

[GitHub] [lucene-solr] vthacker commented on a change in pull request #1816: LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation

2020-09-03 Thread GitBox
vthacker commented on a change in pull request #1816: URL: https://github.com/apache/lucene-solr/pull/1816#discussion_r483318383 ## File path: build.gradle ## @@ -127,6 +128,9 @@ apply from: file('gradle/ide/intellij-idea.gradle') apply from: file('gradle/ide/eclipse.gradle')

[jira] [Commented] (SOLR-14829) Default components are missing facet_module and terms in documentation

2020-09-03 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190430#comment-17190430 ] Ishan Chattopadhyaya commented on SOLR-14829: - Thanks [~jbaiter]. I'll take a look soon

[jira] [Assigned] (SOLR-14829) Default components are missing facet_module and terms in documentation

2020-09-03 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya reassigned SOLR-14829: --- Assignee: Ishan Chattopadhyaya > Default components are missing

[GitHub] [lucene-solr] chatman edited a comment on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
chatman edited a comment on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686808345 > Wow. I'm not even sure that would be polite to say to a junior engineer (that may be presumed to not know concurrency) than a very senior one here. I don't

[GitHub] [lucene-solr] chatman commented on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
chatman commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686808345 > Wow. I'm not even sure that would be polite to say to a junior engineer (that may be presumed to not know concurrency) than a very senior one here. I think you know full

[jira] [Updated] (SOLR-14829) Default components are missing facet_module and terms in documentation

2020-09-03 Thread Johannes Baiter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johannes Baiter updated SOLR-14829: --- Description: In the reference guide, the list of search components that are enabled by

[jira] [Updated] (SOLR-14829) Default components are missing facet_module and terms in documentation

2020-09-03 Thread Johannes Baiter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johannes Baiter updated SOLR-14829: --- Priority: Minor (was: Major) > Default components are missing facet_module and terms in

[jira] [Updated] (SOLR-14829) Default components are missing facet_module and terms in documentation

2020-09-03 Thread Johannes Baiter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johannes Baiter updated SOLR-14829: --- Description: In the reference guide, the list of search components that are enabled by

[jira] [Updated] (SOLR-14829) Default components are missing facet_module and terms in documentation

2020-09-03 Thread Johannes Baiter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johannes Baiter updated SOLR-14829: --- Description: The list of search components that are enabled by default is missing the

[jira] [Updated] (SOLR-14829) Default components are missing facet_module and terms in documentation

2020-09-03 Thread Johannes Baiter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johannes Baiter updated SOLR-14829: --- Attachment: SOLR-14829.patch > Default components are missing facet_module and terms in

[jira] [Created] (SOLR-14829) Default components are missing facet_module and terms in documentation

2020-09-03 Thread Johannes Baiter (Jira)
Johannes Baiter created SOLR-14829: -- Summary: Default components are missing facet_module and terms in documentation Key: SOLR-14829 URL: https://issues.apache.org/jira/browse/SOLR-14829 Project:

[jira] [Comment Edited] (LUCENE-9418) Ordered intervals can give inaccurate hits on interleaved terms

2020-09-03 Thread Brian Coverstone (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190420#comment-17190420 ] Brian Coverstone edited comment on LUCENE-9418 at 9/3/20, 10:46 PM:

[jira] [Comment Edited] (LUCENE-9418) Ordered intervals can give inaccurate hits on interleaved terms

2020-09-03 Thread Brian Coverstone (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190420#comment-17190420 ] Brian Coverstone edited comment on LUCENE-9418 at 9/3/20, 10:46 PM:

[jira] [Comment Edited] (LUCENE-9418) Ordered intervals can give inaccurate hits on interleaved terms

2020-09-03 Thread Brian Coverstone (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190420#comment-17190420 ] Brian Coverstone edited comment on LUCENE-9418 at 9/3/20, 10:44 PM:

[jira] [Comment Edited] (LUCENE-9418) Ordered intervals can give inaccurate hits on interleaved terms

2020-09-03 Thread Brian Coverstone (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190420#comment-17190420 ] Brian Coverstone edited comment on LUCENE-9418 at 9/3/20, 10:44 PM:

[jira] [Comment Edited] (LUCENE-9418) Ordered intervals can give inaccurate hits on interleaved terms

2020-09-03 Thread Brian Coverstone (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190420#comment-17190420 ] Brian Coverstone edited comment on LUCENE-9418 at 9/3/20, 10:43 PM:

[jira] [Commented] (LUCENE-9418) Ordered intervals can give inaccurate hits on interleaved terms

2020-09-03 Thread Brian Coverstone (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190420#comment-17190420 ] Brian Coverstone commented on LUCENE-9418: -- I believe this may still be an issue in 8.6.0, as

[jira] [Commented] (SOLR-14776) Precompute the fingerprint during PeerSync

2020-09-03 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190410#comment-17190410 ] Mike Drob commented on SOLR-14776: -- Thinking about this more, is the big win that we compute our own

[jira] [Commented] (SOLR-14776) Precompute the fingerprint during PeerSync

2020-09-03 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190408#comment-17190408 ] Mike Drob commented on SOLR-14776: -- Is there a chance that the core is changing between subsequent calls

[jira] [Assigned] (LUCENE-9504) DocumentsWriterDeleteQueue.forceApplyGlobalSlice has needless locking

2020-09-03 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob reassigned LUCENE-9504: - Assignee: Mike Drob > DocumentsWriterDeleteQueue.forceApplyGlobalSlice has needless locking >

[jira] [Commented] (SOLR-14579) Comment SolrJ 'Utils' generic map functions

2020-09-03 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190401#comment-17190401 ] Erick Erickson commented on SOLR-14579: --- [~uschindler] bq. why did you re-apply the 8.x comments?

[GitHub] [lucene-solr] vthacker commented on pull request #1816: LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation

2020-09-03 Thread GitBox
vthacker commented on pull request #1816: URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-686774814 Latest change applies errorprone to all modules ( thanks `forbidden-apis.gradle` for the example ) Also explicitly disable all warnings

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1815: SOLR-14151: Bug fixes

2020-09-03 Thread GitBox
tflobbe commented on a change in pull request #1815: URL: https://github.com/apache/lucene-solr/pull/1815#discussion_r483251942 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ## @@ -81,8 +81,7 @@ public final ConfigSet loadConfigSet(CoreDescriptor

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1815: SOLR-14151: Bug fixes

2020-09-03 Thread GitBox
tflobbe commented on a change in pull request #1815: URL: https://github.com/apache/lucene-solr/pull/1815#discussion_r483251942 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ## @@ -81,8 +81,7 @@ public final ConfigSet loadConfigSet(CoreDescriptor

[GitHub] [lucene-solr] vthacker commented on pull request #1816: LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation

2020-09-03 Thread GitBox
vthacker commented on pull request #1816: URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-686719941 > but I'd like to see how to mark valid code with suppressions first so that we can correct the errors, exclude false-positives somehow and then enable this plugin to run

[jira] [Resolved] (SOLR-14658) SolrJ COLSTATUS interface returns all collections when specifying one

2020-09-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-14658. - Fix Version/s: 8.7 Resolution: Fixed Thanks Andy! > SolrJ COLSTATUS interface returns

[jira] [Commented] (SOLR-14658) SolrJ COLSTATUS interface returns all collections when specifying one

2020-09-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190346#comment-17190346 ] ASF subversion and git services commented on SOLR-14658: Commit

[jira] [Commented] (SOLR-14658) SolrJ COLSTATUS interface returns all collections when specifying one

2020-09-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190345#comment-17190345 ] ASF subversion and git services commented on SOLR-14658: Commit

[GitHub] [lucene-solr] dsmiley merged pull request #1687: SOLR-14658: Fix colstatus solrj interfaces to return one or all collections

2020-09-03 Thread GitBox
dsmiley merged pull request #1687: URL: https://github.com/apache/lucene-solr/pull/1687 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Comment Edited] (LUCENE-9444) Need an API to easily fetch facet labels for a field in a document

2020-09-03 Thread Ankur (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190342#comment-17190342 ] Ankur edited comment on LUCENE-9444 at 9/3/20, 6:09 PM: Patch has been available

[jira] [Commented] (LUCENE-9444) Need an API to easily fetch facet labels for a field in a document

2020-09-03 Thread Ankur (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190342#comment-17190342 ] Ankur commented on LUCENE-9444: --- Patch has been available for 1+ day, not sure why automated patch testing

[GitHub] [lucene-solr] madrob opened a new pull request #1826: LUCENE-9504 Remove extra lock in DocumentsWriterDeleteQueue

2020-09-03 Thread GitBox
madrob opened a new pull request #1826: URL: https://github.com/apache/lucene-solr/pull/1826 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Created] (LUCENE-9504) DocumentsWriterDeleteQueue.forceApplyGlobalSlice has needless locking

2020-09-03 Thread Mike Drob (Jira)
Mike Drob created LUCENE-9504: - Summary: DocumentsWriterDeleteQueue.forceApplyGlobalSlice has needless locking Key: LUCENE-9504 URL: https://issues.apache.org/jira/browse/LUCENE-9504 Project: Lucene -

[jira] [Commented] (SOLR-14723) Rremove the class atribute for the caches in the _default/example configsets

2020-09-03 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190318#comment-17190318 ] Erick Erickson commented on SOLR-14723: --- Please do! Find all of the solrconfig.xml files (unix

[jira] [Commented] (SOLR-14723) Rremove the class atribute for the caches in the _default/example configsets

2020-09-03 Thread Shashank Shekhar (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190304#comment-17190304 ] Shashank Shekhar commented on SOLR-14723: - As a newdev I am enthusiastic to take this up. Hoping

[GitHub] [lucene-solr] cpoerschke opened a new pull request #1825: SOLR-14828: reduce 'error' logging noise in BaseCloudSolrClient.requestWithRetryOnStaleState

2020-09-03 Thread GitBox
cpoerschke opened a new pull request #1825: URL: https://github.com/apache/lucene-solr/pull/1825 https://issues.apache.org/jira/browse/SOLR-14828 This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (SOLR-14828) reduce 'error' logging noise in BaseCloudSolrClient.requestWithRetryOnStaleState

2020-09-03 Thread Christine Poerschke (Jira)
Christine Poerschke created SOLR-14828: -- Summary: reduce 'error' logging noise in BaseCloudSolrClient.requestWithRetryOnStaleState Key: SOLR-14828 URL: https://issues.apache.org/jira/browse/SOLR-14828

[GitHub] [lucene-solr] dsmiley commented on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-03 Thread GitBox
dsmiley commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686588314 I am a conflict-avoider (not a good thing) but need to say I fully agree with @sigram 's impression of the tone. I can tell, personally, as a subjective measure in how my

[jira] [Updated] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-9500: -- Affects Version/s: 8.7 8.x > Did we hit a DEFLATE bug? >

[jira] [Updated] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-9500: -- Priority: Critical (was: Minor) > Did we hit a DEFLATE bug? > - > >

[jira] [Updated] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-9500: -- Fix Version/s: 8.7 8.x > Did we hit a DEFLATE bug? >

[jira] [Updated] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-9500: -- Fix Version/s: master (9.0) > Did we hit a DEFLATE bug? > - > >

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190207#comment-17190207 ] Uwe Schindler commented on LUCENE-9500: --- Thanks to all for help! > Did we hit a DEFLATE bug? >

[jira] [Resolved] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler resolved LUCENE-9500. --- Resolution: Fixed > Did we hit a DEFLATE bug? > - > >

[GitHub] [lucene-site] dsmiley commented on pull request #29: Cve 2020 13941

2020-09-03 Thread GitBox
dsmiley commented on pull request #29: URL: https://github.com/apache/lucene-site/pull/29#issuecomment-686556863 Updated. I didn't add "Vendor" which seems pointless. Where did this template/convention come from? This is

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190203#comment-17190203 ] ASF subversion and git services commented on LUCENE-9500: - Commit

[GitHub] [lucene-solr] uschindler commented on pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater

2020-09-03 Thread GitBox
uschindler commented on pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824#issuecomment-686556365 Short info: After backporting to 8.x, of course JDK 8u192 was detected as **non-buggy**. This is an

[jira] [Created] (LUCENE-9503) Fix comment explaining reason for 8KB buffered/chunked writes

2020-09-03 Thread Henning Andersen (Jira)
Henning Andersen created LUCENE-9503: Summary: Fix comment explaining reason for 8KB buffered/chunked writes Key: LUCENE-9503 URL: https://issues.apache.org/jira/browse/LUCENE-9503 Project:

[jira] [Updated] (SOLR-14827) Refactor schema loading to not use XPath

2020-09-03 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-14827: -- Labels: perfomance (was: ) > Refactor schema loading to not use XPath >

[jira] [Created] (SOLR-14827) Refactor schema loading to not use XPath

2020-09-03 Thread Noble Paul (Jira)
Noble Paul created SOLR-14827: - Summary: Refactor schema loading to not use XPath Key: SOLR-14827 URL: https://issues.apache.org/jira/browse/SOLR-14827 Project: Solr Issue Type: Task

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190200#comment-17190200 ] ASF subversion and git services commented on LUCENE-9500: - Commit

[GitHub] [lucene-solr] uschindler merged pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater

2020-09-03 Thread GitBox
uschindler merged pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene-solr] uschindler commented on pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater

2020-09-03 Thread GitBox
uschindler commented on pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824#issuecomment-686528216 Hi, I did further tests (except Java 8, I need to merge first), Results looking fine: - OpenJDK JDK 11.0.2 reports **non-buggy** - AdoptJDK 11.0.5 reports

[jira] [Commented] (LUCENE-9502) Can we remove JaspellLookup?

2020-09-03 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190170#comment-17190170 ] Cassandra Targett commented on LUCENE-9502: --- I linked SOLR-13230, the issue to figure out what

[jira] [Commented] (SOLR-13230) Move JaSpell code into Solr and deprecate the factory

2020-09-03 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190168#comment-17190168 ] Cassandra Targett commented on SOLR-13230: -- Linking a very old issue SOLR-6178 which was for

[jira] [Commented] (SOLR-11875) merge SolrConfigXml wiki into Solr Reference Guide

2020-09-03 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190166#comment-17190166 ] Alexandre Rafalovitch commented on SOLR-11875: -- Could we revisit this issue for 9 and with

[jira] [Assigned] (SOLR-11875) merge SolrConfigXml wiki into Solr Reference Guide

2020-09-03 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Rafalovitch reassigned SOLR-11875: Assignee: Alexandre Rafalovitch > merge SolrConfigXml wiki into Solr

[jira] [Created] (SOLR-14826) Clean up package name conflicts between modules (split packages)

2020-09-03 Thread Tomoko Uchida (Jira)
Tomoko Uchida created SOLR-14826: Summary: Clean up package name conflicts between modules (split packages) Key: SOLR-14826 URL: https://issues.apache.org/jira/browse/SOLR-14826 Project: Solr

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater

2020-09-03 Thread GitBox
jpountz commented on a change in pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824#discussion_r482963038 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene87/BugfixDeflater_JDK8252739.java ## @@ -0,0 +1,102 @@ +/* + * Licensed to the

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater

2020-09-03 Thread GitBox
jpountz commented on a change in pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824#discussion_r482962830 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene87/BugfixDeflater_JDK8252739.java ## @@ -0,0 +1,102 @@ +/* + * Licensed to the

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater

2020-09-03 Thread GitBox
jpountz commented on a change in pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824#discussion_r482960153 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene87/BugfixDeflater_JDK8252739.java ## @@ -0,0 +1,102 @@ +/* + * Licensed to the

[GitHub] [lucene-solr] uschindler commented on pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater

2020-09-03 Thread GitBox
uschindler commented on pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824#issuecomment-686471292 I converted this to a draf, because checks failed with precommit. But this should stay in for doing quick checks by @jpountz like commented before!

[GitHub] [lucene-solr] uschindler commented on pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater

2020-09-03 Thread GitBox
uschindler commented on pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824#issuecomment-686468187 Hi, I added detectction in my latest commit: ``` C:\Users\Uwe Schindler\Projects\lucene\trunk-lusolr1>java -version openjdk version "11.0.2" 2019-01-15

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater

2020-09-03 Thread GitBox
uschindler commented on a change in pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824#discussion_r482952318 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene87/DeflateWithPresetDictCompressionMode.java ## @@ -155,16 +155,15 @@ public

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater

2020-09-03 Thread GitBox
uschindler commented on a change in pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824#discussion_r482923181 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene87/DeflateWithPresetDictCompressionMode.java ## @@ -155,16 +155,15 @@ public

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater

2020-09-03 Thread GitBox
uschindler commented on a change in pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824#discussion_r482923181 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene87/DeflateWithPresetDictCompressionMode.java ## @@ -155,16 +155,15 @@ public

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater

2020-09-03 Thread GitBox
dweiss commented on a change in pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824#discussion_r482922248 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene87/DeflateWithPresetDictCompressionMode.java ## @@ -155,16 +155,15 @@ public

[GitHub] [lucene-solr] uschindler commented on pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater

2020-09-03 Thread GitBox
uschindler commented on pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824#issuecomment-686427056 This effectively reverts @jpountz's hotfix commit, but as he moved classes around in the meantime, I had to do it manually.

[jira] [Assigned] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler reassigned LUCENE-9500: - Assignee: Uwe Schindler > Did we hit a DEFLATE bug? > - > >

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190063#comment-17190063 ] Uwe Schindler commented on LUCENE-9500: --- Here is a pull request that separates the hack from the

[GitHub] [lucene-solr] uschindler opened a new pull request #1824: LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater

2020-09-03 Thread GitBox
uschindler opened a new pull request #1824: URL: https://github.com/apache/lucene-solr/pull/1824 A factory method allows to return a different instance depending on Java version (for now everything after Java 11 is disallowed). We can improve this when we exactly know which versions

[jira] [Commented] (LUCENE-9484) Allow index sorting to happen after the fact

2020-09-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190053#comment-17190053 ] ASF subversion and git services commented on LUCENE-9484: - Commit

[GitHub] [lucene-solr] sigram edited a comment on pull request #1813: SOLR-14613: No new APIs. use the existing APIs

2020-09-03 Thread GitBox
sigram edited a comment on pull request #1813: URL: https://github.com/apache/lucene-solr/pull/1813#issuecomment-686410621 > Honestly nobody will do that. People would rather happily do the computation in client code Really? This is like saying that we only ever need collection

[jira] [Resolved] (LUCENE-9483) Disable per-thread caching of buffers for stored fields

2020-09-03 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-9483. -- Resolution: Fixed > Disable per-thread caching of buffers for stored fields >

[jira] [Resolved] (LUCENE-9486) Explore using preset dictionaries with LZ4 for stored fields

2020-09-03 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-9486. -- Fix Version/s: 8.7 Resolution: Fixed > Explore using preset dictionaries with LZ4 for

[GitHub] [lucene-solr] s1monw merged pull request #1789: LUCENE-9484: Allow sorting an index after the fact

2020-09-03 Thread GitBox
s1monw merged pull request #1789: URL: https://github.com/apache/lucene-solr/pull/1789 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] sigram commented on pull request #1813: SOLR-14613: No new APIs. use the existing APIs

2020-09-03 Thread GitBox
sigram commented on pull request #1813: URL: https://github.com/apache/lucene-solr/pull/1813#issuecomment-686410621 > Honestly nobody will do that. People would rather happily do the computation in client code Really? This is like saying that we only ever need collection admin APIs

[jira] [Commented] (LUCENE-9486) Explore using preset dictionaries with LZ4 for stored fields

2020-09-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190049#comment-17190049 ] ASF subversion and git services commented on LUCENE-9486: - Commit

[jira] [Commented] (LUCENE-9486) Explore using preset dictionaries with LZ4 for stored fields

2020-09-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190048#comment-17190048 ] ASF subversion and git services commented on LUCENE-9486: - Commit

[jira] [Resolved] (SOLR-14819) SOLR has linear log operations that could trivially be linear

2020-09-03 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant resolved SOLR-14819. --- Fix Version/s: 8.7 Resolution: Fixed Thanks Thomas for this fix. Please share the

[GitHub] [lucene-solr] noblepaul commented on pull request #1813: SOLR-14613: No new APIs. use the existing APIs

2020-09-03 Thread GitBox
noblepaul commented on pull request #1813: URL: https://github.com/apache/lucene-solr/pull/1813#issuecomment-686400974 > However, for master/trunk we need a better design anyway. I would say that most users are actually happy if they do not have to implement a bunch of java

[jira] [Commented] (SOLR-14819) SOLR has linear log operations that could trivially be linear

2020-09-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190034#comment-17190034 ] ASF subversion and git services commented on SOLR-14819: Commit

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-09-03 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190033#comment-17190033 ] Ishan Chattopadhyaya commented on SOLR-14588: - bq. Fixed configuration in

[jira] [Commented] (LUCENE-8500) smokeTestRelease still expects KEYS file in distribution

2020-09-03 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190032#comment-17190032 ] Adrien Grand commented on LUCENE-8500: -- Woops, wrong JIRA, this should have been LUCENE-9500. >

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-03 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190030#comment-17190030 ] Adrien Grand commented on LUCENE-9500: -- [~uschindler] This code was backported already but not

[jira] [Commented] (LUCENE-9486) Explore using preset dictionaries with LZ4 for stored fields

2020-09-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190029#comment-17190029 ] ASF subversion and git services commented on LUCENE-9486: - Commit

[GitHub] [lucene-solr] jpountz merged pull request #1793: LUCENE-9486: Use preset dictionaries with LZ4 for BEST_SPEED.

2020-09-03 Thread GitBox
jpountz merged pull request #1793: URL: https://github.com/apache/lucene-solr/pull/1793 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

  1   2   >