[GitHub] [lucene] jpountz commented on pull request #12079: Speed up 1D BKD merging.

[GitBox]

jpountz commented on PR #12079:
URL: https://github.com/apache/lucene/pull/12079#issuecomment-1382690674

   The last data point at 
https://people.apache.org/~mikemccand/lucenebench/sparseResults.html#tot_merge_times
 has a drop for overall merging that I expect to be mostly contributed by this 
change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene] jpountz commented on pull request #12079: Speed up 1D BKD merging.

[GitBox]

jpountz commented on PR #12079:
URL: https://github.com/apache/lucene/pull/12079#issuecomment-1380286154

   I remember thinking about it, and there are legitimate use-cases for 
`Arrays#compareUnsigned` like `BytesRef#compareTo`. Another thing is that 
`ArrayUtil#getUnsignedComparator` only helps if we expect the lengths to 
compare to be commonly 4 or 8, otherwise it just wraps 
`Arrays#compareUnsigned`. But to your point, maybe we could do another round or 
review of all call sites or `Arrays#compareUnsigned` to see if there are some 
of them that should switch to `ArrayUtil#getUnsignedComparator`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org