[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17553142#comment-17553142
]
Tomoko Uchida commented on LUCENE-10610:
I've been thinking about those three options, for what
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17553136#comment-17553136
]
Tomoko Uchida commented on LUCENE-10610:
bq. I would just make the already existing hashCode
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17553133#comment-17553133
]
Dawid Weiss commented on LUCENE-10610:
--
> I do not think we need to discuss if equals/hashCode
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17553131#comment-17553131
]
Uwe Schindler commented on LUCENE-10610:
I looked at the code again:
- Automaton class has no
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17553075#comment-17553075
]
Tomoko Uchida commented on LUCENE-10610:
Sorry if I casually dag up an old discussion. I had a
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17553063#comment-17553063
]
Uwe Schindler commented on LUCENE-10610:
I think the problem may be query caching. This would
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552947#comment-17552947
]
Robert Muir commented on LUCENE-10610:
--
and for the same reason, again, we can do something else
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552943#comment-17552943
]
Robert Muir commented on LUCENE-10610:
--
it is much more complicated. I really don't think we
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552909#comment-17552909
]
Tomoko Uchida commented on LUCENE-10610:
I may completely miss the point so correct me if I'm
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552861#comment-17552861
]
Robert Muir commented on LUCENE-10610:
--
Also i honestly think the current hashcode based on
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552858#comment-17552858
]
Tomoko Uchida commented on LUCENE-10610:
Ah, if my understanding is correct it seems that it's
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552856#comment-17552856
]
Robert Muir commented on LUCENE-10610:
--
A simple/fast improvement might be to incorporate
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552844#comment-17552844
]
Tomoko Uchida commented on LUCENE-10610:
bq. Let's please not go back to trying to implement
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552827#comment-17552827
]
Robert Muir commented on LUCENE-10610:
--
what uses this hashcode (anything?).
Let's please not go
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552733#comment-17552733
]
Uwe Schindler commented on LUCENE-10610:
Thanks for finding this. The solution is:
- Make
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552728#comment-17552728
]
Tomoko Uchida commented on LUCENE-10610:
Right, RunAutomaton has no setters - a cached hash
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552727#comment-17552727
]
Uwe Schindler commented on LUCENE-10610:
I checked the code. If you look at equals you see the
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552725#comment-17552725
]
Uwe Schindler commented on LUCENE-10610:
But the RunAutomaton is not modifiable, right. Then
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552723#comment-17552723
]
Tomoko Uchida commented on LUCENE-10610:
Hmm Automaton is mutable even after calling
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552713#comment-17552713
]
Tomoko Uchida commented on LUCENE-10610:
bq. The problem is that it is expensive to create that
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552710#comment-17552710
]
Uwe Schindler commented on LUCENE-10610:
Yes, but Automaton should cache the hashcode.
>
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552709#comment-17552709
]
Tomoko Uchida commented on LUCENE-10610:
Or, it might be a cleaner approach to have
[
https://issues.apache.org/jira/browse/LUCENE-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552702#comment-17552702
]
Uwe Schindler commented on LUCENE-10610:
The hashCode does not need to be unique. If 2 have
23 matches
Mail list logo
