[jira] [Commented] (SOLR-13892) Add postfilter support to {!join} queries

2020-01-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17027711#comment-17027711 ] ASF subversion and git services commented on SOLR-13892: Commit 6

[jira] [Commented] (SOLR-13892) Add postfilter support to {!join} queries

2020-01-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17027638#comment-17027638 ] ASF subversion and git services commented on SOLR-13892: Commit 7

[jira] [Commented] (SOLR-13892) Add postfilter support to {!join} queries

2020-01-23 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022248#comment-17022248 ] Jason Gerlowski commented on SOLR-13892: The PR has all the changes I wanted to p

[jira] [Commented] (SOLR-13892) Add postfilter support to {!join} queries

2020-01-21 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020206#comment-17020206 ] Jason Gerlowski commented on SOLR-13892: The latest code on the PR removes the po

[jira] [Commented] (SOLR-13892) Add postfilter support to {!join} queries

2020-01-15 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17016075#comment-17016075 ] David Smiley commented on SOLR-13892: - RE branches and "commit spamming", I think you

[jira] [Commented] (SOLR-13892) Add postfilter support to {!join} queries

2020-01-15 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17016072#comment-17016072 ] David Smiley commented on SOLR-13892: - Definitely +1 to "method" as it is consistent

[jira] [Commented] (SOLR-13892) Add postfilter support to {!join} queries

2020-01-15 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17016016#comment-17016016 ] Jason Gerlowski commented on SOLR-13892: *Apologies* I incorrectly named my PR br

[jira] [Commented] (SOLR-13892) Add postfilter support to {!join} queries

2020-01-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17015933#comment-17015933 ] ASF subversion and git services commented on SOLR-13892: Commit 8

[jira] [Commented] (SOLR-13892) Add postfilter support to {!join} queries

2020-01-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17015934#comment-17015934 ] ASF subversion and git services commented on SOLR-13892: Commit 0

[jira] [Commented] (SOLR-13892) Add postfilter support to {!join} queries

2020-01-10 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012945#comment-17012945 ] Jason Gerlowski commented on SOLR-13892: Revisiting this after some time away. I

[jira] [Commented] (SOLR-13892) Add postfilter support to {!join} queries

2020-01-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012909#comment-17012909 ] ASF subversion and git services commented on SOLR-13892: Commit 4

[jira] [Commented] (SOLR-13892) Add postfilter support to {!join} queries

2019-11-05 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968123#comment-16968123 ] Mikhail Khludnev commented on SOLR-13892: - [~jbernste], Thanks for your comments.

[jira] [Commented] (SOLR-13892) Add postfilter support to {!join} queries

2019-11-05 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967960#comment-16967960 ] Joel Bernstein commented on SOLR-13892: --- I think MultiTermQueryConstantScoreWrapper

[jira] [Commented] (SOLR-13892) Add postfilter support to {!join} queries

2019-11-05 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967945#comment-16967945 ] Joel Bernstein commented on SOLR-13892: --- The ..join.TermsQuery also extends MultiTe

[jira] [Commented] (SOLR-13892) Add postfilter support to {!join} queries

2019-11-05 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967880#comment-16967880 ] Joel Bernstein commented on SOLR-13892: --- I read through *JoinUtil* and: {code:java}

[jira] [Commented] (SOLR-13892) Add postfilter support to {!join} queries

2019-11-05 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967842#comment-16967842 ] Joel Bernstein commented on SOLR-13892: --- Ok, this is indeed entirely different impl

[jira] [Commented] (SOLR-13892) Add postfilter support to {!join} queries

2019-11-05 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967840#comment-16967840 ] Joel Bernstein commented on SOLR-13892: --- Ok, now I see it. I missed this implementa

[jira] [Commented] (SOLR-13892) Add postfilter support to {!join} queries

2019-11-05 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967815#comment-16967815 ] Mikhail Khludnev commented on SOLR-13892: - Feel free to check this [condition|ht

[jira] [Commented] (SOLR-13892) Add postfilter support to {!join} queries

2019-11-05 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967785#comment-16967785 ] Joel Bernstein commented on SOLR-13892: --- I'm not sure we're talking about the same

[jira] [Commented] (SOLR-13892) Add postfilter support to {!join} queries

2019-11-05 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967757#comment-16967757 ] Mikhail Khludnev commented on SOLR-13892: - {!join score=none} switches execution

[jira] [Commented] (SOLR-13892) Add postfilter support to {!join} queries

2019-11-05 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967743#comment-16967743 ] Joel Bernstein commented on SOLR-13892: --- Just reviewing the join code. I always ass

[jira] [Commented] (SOLR-13892) Add postfilter support to {!join} queries

2019-11-05 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967736#comment-16967736 ] Joel Bernstein commented on SOLR-13892: --- We tested against \{!join}. Now I'm curiou

[jira] [Commented] (SOLR-13892) Add postfilter support to {!join} queries

2019-11-05 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967734#comment-16967734 ] Mikhail Khludnev commented on SOLR-13892: - {quote} this join has proven to be 700

[jira] [Commented] (SOLR-13892) Add postfilter support to {!join} queries

2019-11-05 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967710#comment-16967710 ] Joel Bernstein commented on SOLR-13892: --- I'm not arguing that this is the best poss

[jira] [Commented] (SOLR-13892) Add postfilter support to {!join} queries

2019-11-05 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967703#comment-16967703 ] Mikhail Khludnev commented on SOLR-13892: - # the attached code doesn't get gain i

[jira] [Commented] (SOLR-13892) Add postfilter support to {!join} queries

2019-11-05 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967658#comment-16967658 ] Joel Bernstein commented on SOLR-13892: --- We've been testing this join and have foun

[jira] [Commented] (SOLR-13892) Add postfilter support to {!join} queries

2019-11-04 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16966891#comment-16966891 ] Mikhail Khludnev commented on SOLR-13892: - Hello, [~gerlowskija]. The concern is