[
https://issues.apache.org/jira/browse/MSHADE-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17005182#comment-17005182
]
Herve Boutemy commented on MSHADE-339:
--
it seems we now agree on changing the PR to not override
[
https://issues.apache.org/jira/browse/MSHADE-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17005051#comment-17005051
]
Peter De Maeyer edited comment on MSHADE-339 at 12/30/19 7:38 AM:
--
romani commented on issue #18: [MCHECKSTYLE-381] remove call to
checker.setClassLoader().
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/18#issuecomment-569548423
> You will start seeing warnings about some internal unused methods.
it is better than live in illusions
[
https://issues.apache.org/jira/browse/MSHADE-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17005051#comment-17005051
]
Peter De Maeyer edited comment on MSHADE-339 at 12/29/19 9:54 PM:
--
[
https://issues.apache.org/jira/browse/MSHADE-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17005051#comment-17005051
]
Peter De Maeyer edited comment on MSHADE-339 at 12/29/19 9:53 PM:
--
[
https://issues.apache.org/jira/browse/MSHADE-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17005051#comment-17005051
]
Peter De Maeyer commented on MSHADE-339:
{quote}
IMHO if we consider that the MavenProjectHelper
bmhm commented on issue #18: [MCHECKSTYLE-381] remove call to
checker.setClassLoader().
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/18#issuecomment-569537715
For users? No. This is really interesting for devs. Imagine you do not
upgrade checkstyle (yet) for various
Tibor17 commented on issue #248: SUREFIRE-1695 Support multiple inheritance of
@Categories
URL: https://github.com/apache/maven-surefire/pull/248#issuecomment-569525999
@YiannisDermitzakis
It looks good but still it is incomplete. Typically the unit tests must be
included in
[
https://issues.apache.org/jira/browse/MSHADE-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter De Maeyer updated MSHADE-342:
---
Description:
Maven invoker plugin supports running ITs in isolation, but many ITs fail when
[
https://issues.apache.org/jira/browse/MSHADE-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17004828#comment-17004828
]
Peter De Maeyer commented on MSHADE-342:
{quote}
this IT should be defined as a setup IT
{quote}
[
https://issues.apache.org/jira/browse/MSHADE-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter De Maeyer updated MSHADE-342:
---
Description:
Maven invoker plugin supports running ITs in isolation, but many ITs fail when
[
https://issues.apache.org/jira/browse/MRESOURCES-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17004798#comment-17004798
]
Michel Schudel commented on MRESOURCES-250:
---
[~khmarbaise] can you shed a light on your or
[
https://issues.apache.org/jira/browse/MSHADE-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter De Maeyer updated MSHADE-342:
---
Description:
Maven invoker plugin supports running ITs in isolation, but many ITs fail when
[
https://issues.apache.org/jira/browse/MSHADE-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter De Maeyer updated MSHADE-342:
---
Summary: Many integration tests fail when run in isolation (was: Many ITs
fail when run in
bmhm commented on issue #18: [MCHECKSTYLE-381] remove call to
checker.setClassLoader().
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/18#issuecomment-569505877
Thanks and agreed about the tests. We may need to refibe existing tests
if/when we use checkstyle 8.24 or newer.
bmhm edited a comment on issue #18: [MCHECKSTYLE-381] remove call to
checker.setClassLoader().
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/18#issuecomment-569505877
Thanks and agreed about the tests. We may need to refine existing tests
if/when we use checkstyle 8.24 or
bmhm commented on issue #18: [MCHECKSTYLE-381] remove call to
checker.setClassLoader().
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/18#issuecomment-569500345
@romani @struberg @rfscholte
Reworked to call the method if it is available by catching a
[
https://issues.apache.org/jira/browse/MSHADE-340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy updated MSHADE-340:
-
Fix Version/s: 3.2.2
> Shaded test jar artifact is not attached
>
[
https://issues.apache.org/jira/browse/MSHADE-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17004732#comment-17004732
]
Herve Boutemy commented on MSHADE-339:
--
thanks [~peterdm]
I had a look at Artifact interface
[
https://issues.apache.org/jira/browse/MSHADE-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17004726#comment-17004726
]
Herve Boutemy edited comment on MSHADE-342 at 12/29/19 9:50 AM:
nice
[
https://issues.apache.org/jira/browse/MSHADE-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17004726#comment-17004726
]
Herve Boutemy commented on MSHADE-342:
--
nice catch: looks like this IT should be defined as a setup
[
https://issues.apache.org/jira/browse/MSHADE-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter De Maeyer updated MSHADE-342:
---
Description:
Maven invoker plugin supports running ITs in isolation, but many ITs fail when
[
https://issues.apache.org/jira/browse/MSHADE-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter De Maeyer updated MSHADE-342:
---
Summary: Many ITs fail when run in isolation (was: Many ITs don't run in
isolation)
> Many
[
https://issues.apache.org/jira/browse/MSHADE-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17004699#comment-17004699
]
Peter De Maeyer commented on MSHADE-342:
It's on my to-do list to fix this, but if someone wants
Peter De Maeyer created MSHADE-342:
--
Summary: Many ITs don't run in isolation
Key: MSHADE-342
URL: https://issues.apache.org/jira/browse/MSHADE-342
Project: Maven Shade Plugin
Issue Type:
25 matches
Mail list logo
