[GitHub] [maven-surefire] cowwoc commented on pull request #299: Added integration test for surefire-1629

2020-05-20 Thread GitBox
cowwoc commented on pull request #299: URL: https://github.com/apache/maven-surefire/pull/299#issuecomment-631878071 The interesting bit is if you remove module1, module2 from the testcase (convert it to a single-module project) then Surefire returns the compiler error to the console

[GitHub] [maven-surefire] cowwoc opened a new pull request #299: Added integration test for surefire-1629

2020-05-20 Thread GitBox
cowwoc opened a new pull request #299: URL: https://github.com/apache/maven-surefire/pull/299 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [maven-surefire] cowwoc commented on pull request #293: [SUREFIRE-1733] Surefire and Failsafe JPMS additions for JUnit 5.x execution

2020-05-20 Thread GitBox
cowwoc commented on pull request #293: URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-631877603 @Tibor17 https://github.com/apache/maven-surefire/pull/299 is now ready for your review. This is an

[jira] [Updated] (MNG-6397) Maven Transitive Dependency Resolution Does Not Respect Repository Definition in pom.xml

2020-05-20 Thread Alan Czajkowski (Jira)
[ https://issues.apache.org/jira/browse/MNG-6397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Czajkowski updated MNG-6397: - Description: _*Note:* I am trying to do a build behind a firewall which means I cannot access the

[jira] [Commented] (MDEP-645) List classes in a given artifact

2020-05-20 Thread John Lin (Jira)
[ https://issues.apache.org/jira/browse/MDEP-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112763#comment-17112763 ] John Lin commented on MDEP-645: --- It's any artifact the user specifies, and it doesn't have to be within the

[jira] [Updated] (SUREFIRE-1794) @TestFactory method succeeds when throwing an exception with Maven Failsafe plugin

2020-05-20 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1794: --- Fix Version/s: (was: 3.0.0-M6) > @TestFactory method succeeds when throwing an

[jira] [Updated] (SUREFIRE-1794) @TestFactory method succeeds when throwing an exception with Maven Failsafe plugin

2020-05-20 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1794: --- Fix Version/s: 3.0.0-M6 > @TestFactory method succeeds when throwing an exception with

[GitHub] [maven-surefire] Tibor17 commented on pull request #293: [SUREFIRE-1733] Surefire and Failsafe JPMS additions for JUnit 5.x execution

2020-05-20 Thread GitBox
Tibor17 commented on pull request #293: URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-631811707 @cowwoc In the module `surefire-its` move the value of `argLine` to a new property `jvm.args.tests`. Then the argLine will reference it via `${jvm.args.tests}`.

[jira] [Commented] (MINVOKER-250) streamLogsOnFailures - parameter/option

2020-05-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MINVOKER-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112617#comment-17112617 ] Hudson commented on MINVOKER-250: - Build succeeded in Jenkins: Maven TLP » maven-invoker-plugin »

[jira] [Commented] (MINVOKER-250) streamLogsOnFailures - parameter/option

2020-05-20 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MINVOKER-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112616#comment-17112616 ] Slawomir Jaranowski commented on MINVOKER-250: -- Also thank you for approval. Now I'm

[jira] [Closed] (MINVOKER-250) streamLogsOnFailures - parameter/option

2020-05-20 Thread Olivier Lamy (Jira)
[ https://issues.apache.org/jira/browse/MINVOKER-250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy closed MINVOKER-250. - Resolution: Fixed awesome job! Thanks! > streamLogsOnFailures - parameter/option >

[jira] [Assigned] (MINVOKER-250) streamLogsOnFailures - parameter/option

2020-05-20 Thread Olivier Lamy (Jira)
[ https://issues.apache.org/jira/browse/MINVOKER-250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy reassigned MINVOKER-250: - Assignee: Olivier Lamy > streamLogsOnFailures - parameter/option >

[jira] [Updated] (MINVOKER-250) streamLogsOnFailures - parameter/option

2020-05-20 Thread Olivier Lamy (Jira)
[ https://issues.apache.org/jira/browse/MINVOKER-250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy updated MINVOKER-250: -- Fix Version/s: 3.2.2 > streamLogsOnFailures - parameter/option >

[GitHub] [maven-invoker-plugin] olamy merged pull request #20: [MINVOKER-250] streamLogsOnFailures

2020-05-20 Thread GitBox
olamy merged pull request #20: URL: https://github.com/apache/maven-invoker-plugin/pull/20 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Updated] (MINVOKER-264) Errors during maven site build

2020-05-20 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MINVOKER-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MINVOKER-264: - Priority: Minor (was: Major) > Errors during maven site build >

[jira] [Created] (MINVOKER-264) Errors during maven site build

2020-05-20 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MINVOKER-264: Summary: Errors during maven site build Key: MINVOKER-264 URL: https://issues.apache.org/jira/browse/MINVOKER-264 Project: Maven Invoker Plugin

[GitHub] [maven-invoker-plugin] slawekjaranowski commented on pull request #20: [MINVOKER-250] streamLogsOnFailures

2020-05-20 Thread GitBox
slawekjaranowski commented on pull request #20: URL: https://github.com/apache/maven-invoker-plugin/pull/20#issuecomment-631711203 Documentation added in exemples. This is an automated message from the Apache Git Service.

[jira] [Commented] (MDEP-645) List classes in a given artifact

2020-05-20 Thread Jonathan Volfson (Jira)
[ https://issues.apache.org/jira/browse/MDEP-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112581#comment-17112581 ] Jonathan Volfson commented on MDEP-645: --- Is this mojo looking for any artifact the user specifies or

[GitHub] [maven-jxr] elharo merged pull request #23: [JXR-151] update commons lang

2020-05-20 Thread GitBox
elharo merged pull request #23: URL: https://github.com/apache/maven-jxr/pull/23 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-jxr] elharo merged pull request #22: [JXR-148] remove unused dependency

2020-05-20 Thread GitBox
elharo merged pull request #22: URL: https://github.com/apache/maven-jxr/pull/22 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-jxr] elharo merged pull request #21: [JXR-147] update doxia

2020-05-20 Thread GitBox
elharo merged pull request #21: URL: https://github.com/apache/maven-jxr/pull/21 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (MNG-6909) Inject objects using CDI in tests

2020-05-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-6909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112543#comment-17112543 ] Hudson commented on MNG-6909: - Build succeeded in Jenkins: Maven TLP » maven » MNG-6909 #6 See

[GitHub] [maven] slachiewicz commented on a change in pull request #346: [MNG-6909] Use CDI to inject objects under tests

2020-05-20 Thread GitBox
slachiewicz commented on a change in pull request #346: URL: https://github.com/apache/maven/pull/346#discussion_r428193862 ## File path: maven-core/src/test/java/org/apache/maven/project/PomConstructionTest.java ## @@ -53,12 +57,24 @@ private static String

[GitHub] [maven-surefire] cowwoc commented on pull request #293: [SUREFIRE-1733] Surefire and Failsafe JPMS additions for JUnit 5.x execution

2020-05-20 Thread GitBox
cowwoc commented on pull request #293: URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-631622526 @Tibor17 FYI, I am still working on this (albeit slowly). I just wanted to let you know I found an unrelated bug in the project. * In the root project, we have

[jira] [Commented] (MNG-5988) Dependency mediation should prioritize transitive dependencies based on scope.

2020-05-20 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MNG-5988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112466#comment-17112466 ] Elliotte Rusty Harold commented on MNG-5988: So is the bug that Maven is not doing what it

[jira] [Created] (MNG-6910) API doc for org.apache.maven.artifact.Artifact

2020-05-20 Thread Elliotte Rusty Harold (Jira)
Elliotte Rusty Harold created MNG-6910: -- Summary: API doc for org.apache.maven.artifact.Artifact Key: MNG-6910 URL: https://issues.apache.org/jira/browse/MNG-6910 Project: Maven Issue

[GitHub] [maven] elharo commented on a change in pull request #346: [MNG-6909] Use CDI to inject objects under tests

2020-05-20 Thread GitBox
elharo commented on a change in pull request #346: URL: https://github.com/apache/maven/pull/346#discussion_r428178523 ## File path: maven-core/src/test/java/org/apache/maven/project/PomConstructionTest.java ## @@ -53,12 +57,24 @@ private static String BASE_MIXIN_DIR =

[jira] [Commented] (MNG-6909) Inject objects using CDI in tests

2020-05-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-6909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112456#comment-17112456 ] Hudson commented on MNG-6909: - Build succeeded in Jenkins: Maven TLP » maven » MNG-6909 #5 See

[GitHub] [maven-dependency-plugin] elharo commented on a change in pull request #53: Moved GetMojo logic to an abstract class. This allows new mojos to im…

2020-05-20 Thread GitBox
elharo commented on a change in pull request #53: URL: https://github.com/apache/maven-dependency-plugin/pull/53#discussion_r428133644 ## File path: src/main/java/org/apache/maven/plugins/dependency/AbstractGetMojo.java ## @@ -0,0 +1,358 @@ +package

[GitHub] [maven-dependency-plugin] jonvolfson commented on a change in pull request #53: Moved GetMojo logic to an abstract class. This allows new mojos to im…

2020-05-20 Thread GitBox
jonvolfson commented on a change in pull request #53: URL: https://github.com/apache/maven-dependency-plugin/pull/53#discussion_r428120564 ## File path: src/main/java/org/apache/maven/plugins/dependency/AbstractGetMojo.java ## @@ -0,0 +1,367 @@ +package

[GitHub] [maven-jxr] elharo closed pull request #20: ignore Eclipse .checkstyle

2020-05-20 Thread GitBox
elharo closed pull request #20: URL: https://github.com/apache/maven-jxr/pull/20 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-jxr] elharo merged pull request #20: ignore Eclipse .checkstyle

2020-05-20 Thread GitBox
elharo merged pull request #20: URL: https://github.com/apache/maven-jxr/pull/20 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Created] (SUREFIRE-1794) @TestFactory method succeeds when throwing an exception with Maven Failsafe plugin

2020-05-20 Thread Zhenxu Ke (Jira)
Zhenxu Ke created SUREFIRE-1794: --- Summary: @TestFactory method succeeds when throwing an exception with Maven Failsafe plugin Key: SUREFIRE-1794 URL: https://issues.apache.org/jira/browse/SUREFIRE-1794

[GitHub] [maven-jxr] elharo opened a new pull request #23: [JXR-151] update commons lang

2020-05-20 Thread GitBox
elharo opened a new pull request #23: URL: https://github.com/apache/maven-jxr/pull/23 @michael-o This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Created] (JXR-151) Update apache commons

2020-05-20 Thread Elliotte Rusty Harold (Jira)
Elliotte Rusty Harold created JXR-151: - Summary: Update apache commons Key: JXR-151 URL: https://issues.apache.org/jira/browse/JXR-151 Project: Maven JXR Issue Type: Improvement

[GitHub] [maven-jxr] elharo opened a new pull request #22: [JXR-148] remove unused dependency

2020-05-20 Thread GitBox
elharo opened a new pull request #22: URL: https://github.com/apache/maven-jxr/pull/22 @michael-o This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Created] (MDEP-697) Specifiy file where bad dependency is found

2020-05-20 Thread Elliotte Rusty Harold (Jira)
Elliotte Rusty Harold created MDEP-697: -- Summary: Specifiy file where bad dependency is found Key: MDEP-697 URL: https://issues.apache.org/jira/browse/MDEP-697 Project: Maven Dependency Plugin

[jira] [Updated] (MDEP-697) Specify file where bad dependency is found

2020-05-20 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MDEP-697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MDEP-697: --- Summary: Specify file where bad dependency is found (was: Specifiy file where bad

[jira] [Updated] (MDEP-697) Specify file where bad dependency is found

2020-05-20 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MDEP-697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MDEP-697: --- Labels: intern (was: ) > Specify file where bad dependency is found >

[jira] [Commented] (MDEP-691) useBaseVersion ignored when resolving artifacts from lolcal repostory (works from remote)

2020-05-20 Thread Jakub Bochenski (Jira)
[ https://issues.apache.org/jira/browse/MDEP-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112271#comment-17112271 ] Jakub Bochenski commented on MDEP-691: -- I think in the end it boils down to the presence of

[jira] [Comment Edited] (MDEP-691) useBaseVersion ignored when resolving artifacts from lolcal repostory (works from remote)

2020-05-20 Thread Jakub Bochenski (Jira)
[ https://issues.apache.org/jira/browse/MDEP-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112271#comment-17112271 ] Jakub Bochenski edited comment on MDEP-691 at 5/20/20, 2:25 PM: I think in

[GitHub] [maven-jxr] elharo opened a new pull request #21: [JXR-147] update doxia

2020-05-20 Thread GitBox
elharo opened a new pull request #21: URL: https://github.com/apache/maven-jxr/pull/21 @hboutemy sitetools are proving a little trickier here but we can easily do this much This is an automated message from the Apache Git

[jira] [Closed] (JXR-149) update JUnit to 4.13

2020-05-20 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/JXR-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed JXR-149. - > update JUnit to 4.13 > > > Key: JXR-149 >

[jira] [Resolved] (JXR-149) update JUnit to 4.13

2020-05-20 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/JXR-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved JXR-149. --- Resolution: Fixed > update JUnit to 4.13 > > >

[jira] [Created] (JXR-150) AbstractJxrReport.java uses or overrides a deprecated API.

2020-05-20 Thread Elliotte Rusty Harold (Jira)
Elliotte Rusty Harold created JXR-150: - Summary: AbstractJxrReport.java uses or overrides a deprecated API. Key: JXR-150 URL: https://issues.apache.org/jira/browse/JXR-150 Project: Maven JXR

[GitHub] [maven-jxr] elharo opened a new pull request #20: ignore Eclipse .checkstyle

2020-05-20 Thread GitBox
elharo opened a new pull request #20: URL: https://github.com/apache/maven-jxr/pull/20 @ian-lavallee This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [maven-jxr] elharo merged pull request #19: [JXR-149] update JUnit

2020-05-20 Thread GitBox
elharo merged pull request #19: URL: https://github.com/apache/maven-jxr/pull/19 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (MNG-6909) Inject objects using CDI in tests

2020-05-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-6909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112211#comment-17112211 ] Hudson commented on MNG-6909: - Build succeeded in Jenkins: Maven TLP » maven » MNG-6909 #4 See

[GitHub] [maven] slachiewicz opened a new pull request #346: [MNG-6909] Use CDI to inject objects under tests

2020-05-20 Thread GitBox
slachiewicz opened a new pull request #346: URL: https://github.com/apache/maven/pull/346 simplify tests - use Guice CDI to inject beans - instead of manually in setup methods This is an automated message from the Apache

[GitHub] [maven-jxr] elharo closed pull request #14: update dependencies

2020-05-20 Thread GitBox
elharo closed pull request #14: URL: https://github.com/apache/maven-jxr/pull/14 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-jxr] elharo merged pull request #18: fix a few generics warnings

2020-05-20 Thread GitBox
elharo merged pull request #18: URL: https://github.com/apache/maven-jxr/pull/18 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-jxr] elharo opened a new pull request #19: [JXR-149] update JUnit

2020-05-20 Thread GitBox
elharo opened a new pull request #19: URL: https://github.com/apache/maven-jxr/pull/19 @michael-o This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Assigned] (JXR-149) update JUnit to 4.13

2020-05-20 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/JXR-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold reassigned JXR-149: - Assignee: Elliotte Rusty Harold > update JUnit to 4.13 > > >

[GitHub] [maven-jxr] elharo commented on a change in pull request #18: fix a few generics warnings

2020-05-20 Thread GitBox
elharo commented on a change in pull request #18: URL: https://github.com/apache/maven-jxr/pull/18#discussion_r427920608 ## File path: maven-jxr-plugin/src/test/java/org/apache/maven/plugin/jxr/stubs/AggregateTestMavenProjectStub.java ## @@ -62,15 +62,15 @@ public

[GitHub] [maven] olamy commented on pull request #301: [MNG-6819] Fix NullPointerException in StringVisitorModelInterpolator$ModelVisitor

2020-05-20 Thread GitBox
olamy commented on pull request #301: URL: https://github.com/apache/maven/pull/301#issuecomment-631399928 easy null check. Thanks for that! This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (MNG-6909) Inject objects using CDI in tests

2020-05-20 Thread Sylwester Lachiewicz (Jira)
Sylwester Lachiewicz created MNG-6909: - Summary: Inject objects using CDI in tests Key: MNG-6909 URL: https://issues.apache.org/jira/browse/MNG-6909 Project: Maven Issue Type: Sub-task

[GitHub] [maven] slachiewicz commented on a change in pull request #301: [MNG-6819] Fix NullPointerException in StringVisitorModelInterpolator$ModelVisitor

2020-05-20 Thread GitBox
slachiewicz commented on a change in pull request #301: URL: https://github.com/apache/maven/pull/301#discussion_r427882396 ## File path: maven-model-builder/src/main/java/org/apache/maven/model/interpolation/StringVisitorModelInterpolator.java ## @@ -1424,7 +1424,7 @@

[GitHub] [maven-resolver] olamy commented on a change in pull request #51: MNG-5583 per endpoint support for PKI authentication to maven repos

2020-05-20 Thread GitBox
olamy commented on a change in pull request #51: URL: https://github.com/apache/maven-resolver/pull/51#discussion_r427855452 ## File path: maven-resolver-transport-wagon/pom.xml ## @@ -56,7 +56,7 @@ org.apache.maven.wagon wagon-provider-api - 3.4.0 +

[GitHub] [maven-resolver] olamy commented on a change in pull request #51: MNG-5583 per endpoint support for PKI authentication to maven repos

2020-05-20 Thread GitBox
olamy commented on a change in pull request #51: URL: https://github.com/apache/maven-resolver/pull/51#discussion_r427855452 ## File path: maven-resolver-transport-wagon/pom.xml ## @@ -56,7 +56,7 @@ org.apache.maven.wagon wagon-provider-api - 3.4.0 +

[jira] [Created] (MANTRUN-227) Upgrade Ant to 1.10.8

2020-05-20 Thread Sylwester Lachiewicz (Jira)
Sylwester Lachiewicz created MANTRUN-227: Summary: Upgrade Ant to 1.10.8 Key: MANTRUN-227 URL: https://issues.apache.org/jira/browse/MANTRUN-227 Project: Maven Antrun Plugin Issue

[GitHub] [maven-ejb-plugin] michael-o commented on a change in pull request #3: [MEJB-129] Refactor - extract method

2020-05-20 Thread GitBox
michael-o commented on a change in pull request #3: URL: https://github.com/apache/maven-ejb-plugin/pull/3#discussion_r427808042 ## File path: src/main/java/org/apache/maven/plugins/ejb/IncludesExcludes.java ## @@ -46,33 +46,27 @@ public IncludesExcludes( List includes, List

[GitHub] [maven-resolver] michael-o commented on a change in pull request #51: MNG-5583 per endpoint support for PKI authentication to maven repos

2020-05-20 Thread GitBox
michael-o commented on a change in pull request #51: URL: https://github.com/apache/maven-resolver/pull/51#discussion_r427807001 ## File path: maven-resolver-transport-wagon/pom.xml ## @@ -56,7 +56,7 @@ org.apache.maven.wagon wagon-provider-api - 3.4.0

[jira] [Commented] (MSITE-857) Jetty engine fails to resolve web.xml DTD behind corporate proxy

2020-05-20 Thread Valentino Pinna (Jira)
[ https://issues.apache.org/jira/browse/MSITE-857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111870#comment-17111870 ] Valentino Pinna commented on MSITE-857: --- I have corrected the command line as you suggested,

[jira] [Closed] (MNG-6908) how to debug maven source code

2020-05-20 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-6908. --- Resolution: Invalid > how to debug maven source code > --- > >

[jira] [Created] (MEJB-129) Refactor IncludesExcludes to reduce code duplication

2020-05-20 Thread Piotr Zygielo (Jira)
Piotr Zygielo created MEJB-129: -- Summary: Refactor IncludesExcludes to reduce code duplication Key: MEJB-129 URL: https://issues.apache.org/jira/browse/MEJB-129 Project: Maven EJB Plugin Issue

[GitHub] [maven-ejb-plugin] pzygielo commented on a change in pull request #3: Refactor - extract method

2020-05-20 Thread GitBox
pzygielo commented on a change in pull request #3: URL: https://github.com/apache/maven-ejb-plugin/pull/3#discussion_r427759810 ## File path: src/main/java/org/apache/maven/plugins/ejb/IncludesExcludes.java ## @@ -46,33 +46,27 @@ public IncludesExcludes( List includes, List

[GitHub] [maven-release] pzygielo commented on pull request #55: Remove unused branch and initialize workDirectory immediately

2020-05-20 Thread GitBox
pzygielo commented on pull request #55: URL: https://github.com/apache/maven-release/pull/55#issuecomment-631255498 > What is the motivation behind this change? To improve code quality. > What is wrong with the current behavior? Nothing, behaviour is not changed with