olamy commented on a change in pull request #51:
URL: https://github.com/apache/maven-resolver/pull/51#discussion_r427855452
##########
File path: maven-resolver-transport-wagon/pom.xml
##########
@@ -56,7 +56,7 @@
<dependency>
<groupId>org.apache.maven.wagon</groupId>
<artifactId>wagon-provider-api</artifactId>
- <version>3.4.0</version>
+ <version>3.4.1-SNAPSHOT</version>
Review comment:
as long as the PR has been merged in wagon I do not see any issues with
that.. we are 100 developers who keep deploying snapshots :) and it's easier to
have this SNAPSHOT dependencies for testing this PR and even within an IDE as
they are integrating such SNAPSHOT and can link projects together which is
definitely so easier for development purpose. Always good to ease contributors
life
##########
File path: maven-resolver-transport-wagon/pom.xml
##########
@@ -56,7 +56,7 @@
<dependency>
<groupId>org.apache.maven.wagon</groupId>
<artifactId>wagon-provider-api</artifactId>
- <version>3.4.0</version>
+ <version>3.4.1-SNAPSHOT</version>
Review comment:
as long as the PR has been merged in wagon I do not see any issues with
that.. we are NOT 100 developers who keep deploying snapshots :) and it's
easier to have this SNAPSHOT dependencies for testing this PR and even within
an IDE as they are integrating such SNAPSHOT and can link projects together
which is definitely so easier for development purpose. Always good to ease
contributors life
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
