mabrarov commented on a change in pull request #19:
URL: https://github.com/apache/maven-ear-plugin/pull/19#discussion_r499204091
##
File path: src/test/java/org/apache/maven/plugins/ear/it/EarMojoIT.java
##
@@ -1,996 +1,963 @@
-package org.apache.maven.plugins.ear.it;
Review
mabrarov commented on a change in pull request #19:
URL: https://github.com/apache/maven-ear-plugin/pull/19#discussion_r499202940
##
File path: src/test/java/org/apache/maven/plugins/ear/it/EarMojoIT.java
##
@@ -1,996 +1,963 @@
-package org.apache.maven.plugins.ear.it;
Review
mabrarov commented on a change in pull request #19:
URL: https://github.com/apache/maven-ear-plugin/pull/19#discussion_r499201646
##
File path: src/test/java/org/apache/maven/plugins/ear/it/EarMojoIT.java
##
@@ -1,996 +1,963 @@
-package org.apache.maven.plugins.ear.it;
Review
mabrarov commented on a change in pull request #19:
URL: https://github.com/apache/maven-ear-plugin/pull/19#discussion_r499201646
##
File path: src/test/java/org/apache/maven/plugins/ear/it/EarMojoIT.java
##
@@ -1,996 +1,963 @@
-package org.apache.maven.plugins.ear.it;
Review
mabrarov commented on pull request #19:
URL: https://github.com/apache/maven-ear-plugin/pull/19#issuecomment-703195593
I added some integration tests but they do not cover all permutations (i.e.
all changed branches) of options like:
1.
[
https://issues.apache.org/jira/browse/MNG-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206897#comment-17206897
]
Michael Osipov commented on MNG-6965:
-
Found it, last issue is gone. All Its pass now.
>
[
https://issues.apache.org/jira/browse/MEAR-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206892#comment-17206892
]
Marat Abrarov commented on MEAR-286:
I believe that I fixed this bug in
mabrarov edited a comment on pull request #19:
URL: https://github.com/apache/maven-ear-plugin/pull/19#issuecomment-703171162
I fixed [2nd root
cause](https://github.com/apache/maven-ear-plugin/pull/19#issuecomment-703167969)
of MEAR-267 in 89816ae:
```bash
$ git clone --branch
mabrarov commented on pull request #19:
URL: https://github.com/apache/maven-ear-plugin/pull/19#issuecomment-703171162
I fixed [2nd root
cause](https://github.com/apache/maven-ear-plugin/pull/19#issuecomment-703167969)
of MEAR-267 in 89816ae
mabrarov edited a comment on pull request #19:
URL: https://github.com/apache/maven-ear-plugin/pull/19#issuecomment-703167969
Hmm... I made one more test:
```bash
$ git clone --branch MEAR-267_Manifest_classpath_modification
https://github.com/mabrarov/MEAR-267-issue-demo.git &&
[
https://issues.apache.org/jira/browse/MNG-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206865#comment-17206865
]
Michael Osipov commented on MNG-6965:
-
I am hanging for ours trying to understand why Plexus Utils is
mabrarov edited a comment on pull request #19:
URL: https://github.com/apache/maven-ear-plugin/pull/19#issuecomment-703167969
Hmm... I made one more test:
```bash
$ git clone --branch MEAR-267_Manifest_classpath_modification
https://github.com/mabrarov/MEAR-267-issue-demo.git &&
mabrarov commented on pull request #19:
URL: https://github.com/apache/maven-ear-plugin/pull/19#issuecomment-703167969
Hmm... I made one more test:
```bash
$ git clone --branch MEAR-267_Manifest_classpath_modification
https://github.com/mabrarov/MEAR-267-issue-demo.git && \
mabrarov commented on pull request #19:
URL: https://github.com/apache/maven-ear-plugin/pull/19#issuecomment-703162560
Taking into account enhancements in `EarMojoIT` made in pull request #17 I
would create tests for this pull request after that pull request is merged,
because it looks
[
https://issues.apache.org/jira/browse/MNG-6991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206854#comment-17206854
]
Hudson commented on MNG-6991:
-
Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6965 #15
See
[
https://issues.apache.org/jira/browse/MNG-6987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206852#comment-17206852
]
Hudson commented on MNG-6987:
-
Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6965 #15
See
[
https://issues.apache.org/jira/browse/MNG-6983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206855#comment-17206855
]
Hudson commented on MNG-6983:
-
Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6965 #15
See
[
https://issues.apache.org/jira/browse/MNG-6772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206851#comment-17206851
]
Hudson commented on MNG-6772:
-
Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6965 #15
See
[
https://issues.apache.org/jira/browse/MNG-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206856#comment-17206856
]
Hudson commented on MNG-6965:
-
Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6965 #15
See
[
https://issues.apache.org/jira/browse/MNG-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206853#comment-17206853
]
Hudson commented on MNG-6949:
-
Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6965 #15
See
mabrarov commented on a change in pull request #17:
URL: https://github.com/apache/maven-ear-plugin/pull/17#discussion_r499178059
##
File path: src/test/java/org/apache/maven/plugins/ear/it/EarMojoIT.java
##
@@ -993,4 +993,24 @@ public void testProject087()
{
[
https://issues.apache.org/jira/browse/MEAR-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206849#comment-17206849
]
Marat Abrarov commented on MEAR-267:
I implemented possible fix for this bug in [pull request
mabrarov opened a new pull request #19:
URL: https://github.com/apache/maven-ear-plugin/pull/19
Fixed detection if JAR module is included into classpath of particular EAR
module manifest (like WAR or EJB module manifest). This is required for correct
modification of Class-Path entry of
[
https://issues.apache.org/jira/browse/MNG-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206844#comment-17206844
]
Michael Osipov commented on MNG-6965:
-
After rebasing, I am down to:
{noformat}
[ERROR] Failures:
[
https://issues.apache.org/jira/browse/MNG-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-6965:
Comment: was deleted
(was: Failure for {{MavenITmng2749ExtensionAvailableToPluginTest}} is now
[
https://issues.apache.org/jira/browse/MNG-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206841#comment-17206841
]
Michael Osipov commented on MNG-6965:
-
Failure for {{MavenITmng2749ExtensionAvailableToPluginTest}} is
[
https://issues.apache.org/jira/browse/MNG-6994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206833#comment-17206833
]
Konrad Windszus commented on MNG-6994:
--
PR at https://github.com/apache/maven-site/pull/205.
>
[
https://issues.apache.org/jira/browse/ARCHETYPE-612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Hutchison updated ARCHETYPE-612:
--
Description:
The interactive archetype project generation attempts to be smart in
mabrarov opened a new pull request #18:
URL: https://github.com/apache/maven-ear-plugin/pull/18
* Moved filtering of resources out of run-its maven profile because this
filtering is needed not just for integration tests
```bash
$ mvn clean install -e -DskipTests && mvn clean
David Hutchison created ARCHETYPE-612:
-
Summary: Required property interactive prompt ordering incorrect
when reassigning default for a "core" property
Key: ARCHETYPE-612
URL:
mabrarov commented on a change in pull request #17:
URL: https://github.com/apache/maven-ear-plugin/pull/17#discussion_r499166379
##
File path: src/test/java/org/apache/maven/plugins/ear/it/EarMojoIT.java
##
@@ -993,4 +993,24 @@ public void testProject087()
{
[
https://issues.apache.org/jira/browse/ARCHETYPE-476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206795#comment-17206795
]
Herve Boutemy commented on ARCHETYPE-476:
-
yes, IIRC, MAVENUSER was never migrated given
elharo commented on a change in pull request #17:
URL: https://github.com/apache/maven-ear-plugin/pull/17#discussion_r499159371
##
File path: src/test/java/org/apache/maven/plugins/ear/it/EarMojoIT.java
##
@@ -993,4 +993,24 @@ public void testProject087()
{
[
https://issues.apache.org/jira/browse/MNG-6985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206732#comment-17206732
]
Hudson commented on MNG-6985:
-
Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6965 #12
See
pzygielo commented on a change in pull request #367:
URL: https://github.com/apache/maven/pull/367#discussion_r499156521
##
File path:
maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginDependenciesResolver.java
##
@@ -145,20 +143,19 @@ public
mabrarov commented on pull request #17:
URL: https://github.com/apache/maven-ear-plugin/pull/17#issuecomment-703117231
@elharo and @hboutemy,
I assume MEAR-287 is a major bug making 3.1.0 release of Maven EAR Plugin
breaking existing workflows. Could we speedup / force review of this
[
https://issues.apache.org/jira/browse/MNG-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206721#comment-17206721
]
Michael Osipov commented on MNG-6965:
-
Pushed an IT branch, down to:
{noformat}
[ERROR] Failures:
[
https://issues.apache.org/jira/browse/ARCHETYPE-476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206715#comment-17206715
]
Michael Boyles commented on ARCHETYPE-476:
--
It used to be
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206710#comment-17206710
]
Michael Boyles edited comment on MCHECKSTYLE-334 at 10/3/20, 2:20 PM:
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206710#comment-17206710
]
Michael Boyles commented on MCHECKSTYLE-334:
Seems like this should be closed.
#
[
https://issues.apache.org/jira/browse/MNG-6983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206709#comment-17206709
]
Hudson commented on MNG-6983:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven » master #29
See
[
https://issues.apache.org/jira/browse/MNG-6983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-6983.
---
Fix Version/s: (was: 3.7.0-candidate)
3.7.0
Resolution: Fixed
Fixed with
asfgit closed pull request #372:
URL: https://github.com/apache/maven/pull/372
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
michaelboyles opened a new pull request #73:
URL: https://github.com/apache/maven-resolver/pull/73
https://issues.apache.org/jira/browse/MRESOLVER-104
```
[INFO] — maven-plugin-plugin:3.5.2:descriptor (default-descriptor) @
maven-resolver-demo-maven-plugin —
[ERROR]
[
https://issues.apache.org/jira/browse/MNG-6983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-6983:
Summary: Plugin key can get out of sync with artifactId and groupId (was:
Plugin not executed when
[
https://issues.apache.org/jira/browse/MNG-6983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned MNG-6983:
---
Assignee: Michael Osipov
> Plugin not executed when using pluginManagement and variable in
[
https://issues.apache.org/jira/browse/MNG-6983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-6983:
Description:
I have a project build with maven where some maven plugins are not executed
without
[
https://issues.apache.org/jira/browse/MNG-6784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206649#comment-17206649
]
Michael Osipov edited comment on MNG-6784 at 10/3/20, 9:11 AM:
---
Can we close
[
https://issues.apache.org/jira/browse/MNG-6994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206650#comment-17206650
]
Konrad Windszus commented on MNG-6994:
--
The order of the profiles is determined by
[
https://issues.apache.org/jira/browse/MNG-6784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-6784:
Fix Version/s: wontfix-candidate
> Create correct SHA512 content
> -
>
>
[
https://issues.apache.org/jira/browse/MNG-6784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206649#comment-17206649
]
Michael Osipov commented on MNG-6784:
-
Can we close this?
> Create correct SHA512 content
>
51 matches
Mail list logo
