[GitHub] [maven] rfscholte commented on a change in pull request #607: [MNG-7129] Import maven caching system

2021-11-16 Thread GitBox
rfscholte commented on a change in pull request #607: URL: https://github.com/apache/maven/pull/607#discussion_r750974819 ## File path: maven-caching/src/main/java/org/apache/maven/caching/ProjectUtils.java ## @@ -0,0 +1,170 @@ +package org.apache.maven.caching; + +/* + *

[GitHub] [maven] rmannibucau commented on a change in pull request #607: [MNG-7129] Import maven caching system

2021-11-16 Thread GitBox
rmannibucau commented on a change in pull request #607: URL: https://github.com/apache/maven/pull/607#discussion_r750951047 ## File path: maven-caching/src/main/java/org/apache/maven/caching/ProjectUtils.java ## @@ -0,0 +1,200 @@ +package org.apache.maven.caching; + +/* + *

[GitHub] [maven] gnodet commented on a change in pull request #607: [MNG-7129] Import maven caching system

2021-11-16 Thread GitBox
gnodet commented on a change in pull request #607: URL: https://github.com/apache/maven/pull/607#discussion_r750900076 ## File path: maven-caching/src/main/java/org/apache/maven/caching/ProjectUtils.java ## @@ -0,0 +1,200 @@ +package org.apache.maven.caching; + +/* + *

[GitHub] [maven-jar-plugin] dependabot[bot] opened a new pull request #30: Bump plexus-archiver from 4.2.5 to 4.2.6

2021-11-16 Thread GitBox
dependabot[bot] opened a new pull request #30: URL: https://github.com/apache/maven-jar-plugin/pull/30 Bumps [plexus-archiver](https://github.com/codehaus-plexus/plexus-archiver) from 4.2.5 to 4.2.6. Release notes Sourced from

[jira] [Closed] (SUREFIRE-1621) package-private class/method supported in JUnit5 is not executed

2021-11-16 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1621. -- Resolution: Cannot Reproduce > package-private class/method supported in JUnit5 is not

[jira] [Assigned] (SUREFIRE-1621) package-private class/method supported in JUnit5 is not executed

2021-11-16 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana reassigned SUREFIRE-1621: -- Assignee: Tibor Digana > package-private class/method supported in JUnit5 is not

[GitHub] [maven-enforcer] timtebeek commented on pull request #125: [MENFORCER-372] Drop PlexusTestCase and junit:junit dependency

2021-11-16 Thread GitBox
timtebeek commented on pull request #125: URL: https://github.com/apache/maven-enforcer/pull/125#issuecomment-970695981 Done! That indeed helps, and seems a nice addition to not have to declare the engine anymore. Would you want to restore the `mockito-core` dependency + management?

[jira] [Comment Edited] (MASSEMBLY-955) dependencySet includes filter with classifier breaks include of artifacts without classifier

2021-11-16 Thread Jira
[ https://issues.apache.org/jira/browse/MASSEMBLY-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444828#comment-17444828 ] Václav Haisman edited comment on MASSEMBLY-955 at 11/16/21, 9:29 PM:

[GitHub] [maven-assembly-plugin] wilx commented on pull request #48: [MASSEMBLY-955] Add invoker test.

2021-11-16 Thread GitBox
wilx commented on pull request #48: URL: https://github.com/apache/maven-assembly-plugin/pull/48#issuecomment-970694400 Cross reference: https://issues.apache.org/jira/browse/MASSEMBLY-955 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [maven-common-artifact-filters] wilx commented on pull request #24: [MASSEMBLY-955] Keep iterating over patterns.

2021-11-16 Thread GitBox
wilx commented on pull request #24: URL: https://github.com/apache/maven-common-artifact-filters/pull/24#issuecomment-970694144 Cross reference: https://issues.apache.org/jira/browse/MASSEMBLY-955 -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (MASSEMBLY-955) dependencySet includes filter with classifier breaks include of artifacts without classifier

2021-11-16 Thread Jira
[ https://issues.apache.org/jira/browse/MASSEMBLY-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444828#comment-17444828 ] Václav Haisman commented on MASSEMBLY-955: -- [~michael-o] I have created a [pull request for

[jira] [Closed] (MRESOLVER-223) Upgrade Ant to 1.10.12

2021-11-16 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MRESOLVER-223. -- Resolution: Not A Problem > Upgrade Ant to 1.10.12 > --

[jira] [Commented] (MRESOLVER-223) Upgrade Ant to 1.10.12

2021-11-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444826#comment-17444826 ] Michael Osipov commented on MRESOLVER-223: -- This does not affect us at all. > Upgrade Ant to

[GitHub] [maven-assembly-plugin] wilx opened a new pull request #48: [MASSEMBLY-955] Add invoker test.

2021-11-16 Thread GitBox
wilx opened a new pull request #48: URL: https://github.com/apache/maven-assembly-plugin/pull/48 The test fails right now due to filtering issues described in [MASSEMBLY-955](https://issues.apache.org/jira/browse/MASSEMBLY-955). Following this checklist to help us incorporate your

[jira] [Created] (MRESOLVER-223) Upgrade Ant to 1.10.12

2021-11-16 Thread Sylwester Lachiewicz (Jira)
Sylwester Lachiewicz created MRESOLVER-223: -- Summary: Upgrade Ant to 1.10.12 Key: MRESOLVER-223 URL: https://issues.apache.org/jira/browse/MRESOLVER-223 Project: Maven Resolver

[jira] [Commented] (MASSEMBLY-955) dependencySet includes filter with classifier breaks include of artifacts without classifier

2021-11-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444799#comment-17444799 ] Michael Osipov commented on MASSEMBLY-955: -- Awesome, here it is:

[jira] [Commented] (MASSEMBLY-955) dependencySet includes filter with classifier breaks include of artifacts without classifier

2021-11-16 Thread Jira
[ https://issues.apache.org/jira/browse/MASSEMBLY-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444796#comment-17444796 ] Václav Haisman commented on MASSEMBLY-955: -- [~michael-o]: It looks like commit

[GitHub] [maven-common-artifact-filters] wilx commented on pull request #24: [MASSEMBLY-955] Keep iterating over patterns.

2021-11-16 Thread GitBox
wilx commented on pull request #24: URL: https://github.com/apache/maven-common-artifact-filters/pull/24#issuecomment-970649621 This PR is from the point after 3.1.1 release. It requires 3.1.1 based branch for merging. -- This is an automated message from the Apache Git Service. To

[GitHub] [maven-scm] michael-o commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-16 Thread GitBox
michael-o commented on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-970649563 I believe that this change is a noop: ```java boolean threadSafe() default false; ``` It will be `false` by default any way Thoughts? -- This is an

[GitHub] [maven-common-artifact-filters] wilx opened a new pull request #24: [MASSEMBLY-955] Keep iterating over patterns.

2021-11-16 Thread GitBox
wilx opened a new pull request #24: URL: https://github.com/apache/maven-common-artifact-filters/pull/24 Keep iterating over patterns when pattern has classifier and artifact does not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Updated] (MRESOLVER-212) Use final variable when is possible - 1

2021-11-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-212: - Component/s: Ant Tasks > Use final variable when is possible - 1 >

[jira] [Assigned] (MRESOLVER-212) Use final variable when is possible - 1

2021-11-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MRESOLVER-212: Assignee: Michael Osipov > Use final variable when is possible - 1 >

[jira] [Assigned] (MRESOLVER-211) Use final variable when is possible

2021-11-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MRESOLVER-211: Assignee: Michael Osipov > Use final variable when is possible >

[GitHub] [maven-enforcer] slawekjaranowski edited a comment on pull request #125: [MENFORCER-372] Drop PlexusTestCase and junit:junit dependency

2021-11-16 Thread GitBox
slawekjaranowski edited a comment on pull request #125: URL: https://github.com/apache/maven-enforcer/pull/125#issuecomment-970645781 hint add to `pluginManagment` in root pom ```xml org.apache.maven.plugins maven-surefire-plugin

[jira] [Updated] (MRESOLVER-211) Use final variable when is possible

2021-11-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-211: - Component/s: Ant Tasks > Use final variable when is possible >

[GitHub] [maven-enforcer] slawekjaranowski commented on pull request #125: [MENFORCER-372] Drop PlexusTestCase and junit:junit dependency

2021-11-16 Thread GitBox
slawekjaranowski commented on pull request #125: URL: https://github.com/apache/maven-enforcer/pull/125#issuecomment-970645781 hint add to `pluginManagment` in root pom ```xml org.apache.maven.plugins maven-surefire-plugin 3.0.0-M5

[GitHub] [maven-resolver-ant-tasks] michael-o commented on pull request #10: MRESOLVER-212 - Use final variable when is possible 1

2021-11-16 Thread GitBox
michael-o commented on pull request #10: URL: https://github.com/apache/maven-resolver-ant-tasks/pull/10#issuecomment-970645648 @arturobernalg Please rebase on top of master... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Closed] (MRESOLVER-213) Use final variable when is possible - 2

2021-11-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRESOLVER-213. Resolution: Won't Fix PR has been closed already. > Use final variable when is

[jira] [Closed] (MRESOLVER-209) Remove redundant local variables

2021-11-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRESOLVER-209. Resolution: Fixed Fixed with

[GitHub] [maven-resolver-ant-tasks] asfgit closed pull request #8: MRESOLVER-209 -Remove redundant local variable

2021-11-16 Thread GitBox
asfgit closed pull request #8: URL: https://github.com/apache/maven-resolver-ant-tasks/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (MRESOLVER-209) Remove redundant local variables

2021-11-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-209: - Component/s: Ant Tasks > Remove redundant local variables >

[jira] [Assigned] (MRESOLVER-209) Remove redundant local variables

2021-11-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MRESOLVER-209: Assignee: Michael Osipov > Remove redundant local variables >

[jira] [Updated] (MRESOLVER-209) Remove redundant local variables

2021-11-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-209: - Fix Version/s: ant-tasks-1.4.0 > Remove redundant local variables >

[jira] [Updated] (MRESOLVER-209) Remove redundant local variables

2021-11-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-209: - Summary: Remove redundant local variables (was: Remove redundant local variable) >

[jira] [Updated] (MRESOLVER-216) [ERROR] Malformed \uxxxx encoding.

2021-11-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-216: - Fix Version/s: waiting-for-feedback (was: Maven Artifact

[jira] [Commented] (MASSEMBLY-955) dependencySet includes filter with classifier breaks include of artifacts without classifier

2021-11-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444775#comment-17444775 ] Michael Osipov commented on MASSEMBLY-955: -- It would be awesome if you could do the git

[jira] [Closed] (MRESOLVER-206) Upgrade Maven to 3.8.3

2021-11-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRESOLVER-206. Assignee: Tamás Cservenák Resolution: Fixed Fixed with

[jira] [Updated] (MRESOLVER-206) Upgrade Maven to 3.8.3

2021-11-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-206: - Summary: Upgrade Maven to 3.8.3 (was: Upgrade Maven to 3.8.4) > Upgrade Maven to

[jira] [Created] (MASSEMBLY-955) dependencySet includes filter with classifier breaks include of artifacts without classifier

2021-11-16 Thread Jira
Václav Haisman created MASSEMBLY-955: Summary: dependencySet includes filter with classifier breaks include of artifacts without classifier Key: MASSEMBLY-955 URL:

[jira] [Commented] (MRESOLVER-222) Upgrade SLF4J to 1.7.30

2021-11-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444770#comment-17444770 ] Michael Osipov commented on MRESOLVER-222: -- Downgraded to 1.7.30 for API consistency:

[jira] [Updated] (MRESOLVER-222) Upgrade SLF4J to 1.7.30

2021-11-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-222: - Summary: Upgrade SLF4J to 1.7.30 (was: Upgrade SLF4J to 1.7.32) > Upgrade SLF4J to

[GitHub] [maven-enforcer] timtebeek commented on a change in pull request #125: [MENFORCER-372] Drop PlexusTestCase and junit:junit dependency

2021-11-16 Thread GitBox
timtebeek commented on a change in pull request #125: URL: https://github.com/apache/maven-enforcer/pull/125#discussion_r750608081 ## File path: pom.xml ## @@ -128,22 +128,15 @@ test - -junit -junit -4.13.2 -test

[jira] [Commented] (SUREFIRE-1621) package-private class/method supported in JUnit5 is not executed

2021-11-16 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444763#comment-17444763 ] Slawomir Jaranowski commented on SUREFIRE-1621: --- Checked with M1 - M5 and is OK. I

[jira] [Closed] (MRESOLVER-222) Upgrade SLF4J to 1.7.32

2021-11-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRESOLVER-222. Resolution: Fixed Fixed with

[jira] [Created] (MRESOLVER-222) Upgrade SLF4J to 1.7.32

2021-11-16 Thread Michael Osipov (Jira)
Michael Osipov created MRESOLVER-222: Summary: Upgrade SLF4J to 1.7.32 Key: MRESOLVER-222 URL: https://issues.apache.org/jira/browse/MRESOLVER-222 Project: Maven Resolver Issue Type:

[jira] [Closed] (MRESOLVER-221) Upgrade Plexus Cipher to 2.0

2021-11-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRESOLVER-221. Resolution: Fixed Fixed with

[jira] [Assigned] (MRESOLVER-221) Upgrade Plexus Cipher to 2.0

2021-11-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MRESOLVER-221: Assignee: Tamás Cservenák (was: Michael Osipov) > Upgrade Plexus Cipher to

[jira] [Created] (MRESOLVER-221) Upgrade Plexus Cipher to 2.0

2021-11-16 Thread Michael Osipov (Jira)
Michael Osipov created MRESOLVER-221: Summary: Upgrade Plexus Cipher to 2.0 Key: MRESOLVER-221 URL: https://issues.apache.org/jira/browse/MRESOLVER-221 Project: Maven Resolver Issue

[GitHub] [maven-enforcer] slawekjaranowski commented on a change in pull request #125: [MENFORCER-372] Drop PlexusTestCase and junit:junit dependency

2021-11-16 Thread GitBox
slawekjaranowski commented on a change in pull request #125: URL: https://github.com/apache/maven-enforcer/pull/125#discussion_r750595602 ## File path: pom.xml ## @@ -128,22 +128,15 @@ test - -junit -junit -4.13.2 -

[GitHub] [maven-resolver-ant-tasks] asfgit closed pull request #6: WIP: [MRESOLVER-181] Upgrade Ant to 1.9.15

2021-11-16 Thread GitBox
asfgit closed pull request #6: URL: https://github.com/apache/maven-resolver-ant-tasks/pull/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-resolver-ant-tasks] asfgit closed pull request #13: Attempt to update Ant to latest 1.10

2021-11-16 Thread GitBox
asfgit closed pull request #13: URL: https://github.com/apache/maven-resolver-ant-tasks/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (MRESOLVER-181) Upgrade Ant to 1.9.16

2021-11-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MRESOLVER-181: Assignee: Tamás Cservenák (was: Michael Osipov) > Upgrade Ant to 1.9.16 >

[jira] [Closed] (MRESOLVER-181) Upgrade Ant to 1.9.16

2021-11-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRESOLVER-181. Resolution: Fixed Fixed with

[jira] [Assigned] (MRESOLVER-181) Upgrade Ant to 1.9.16

2021-11-16 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MRESOLVER-181: Assignee: Michael Osipov > Upgrade Ant to 1.9.16 > - > >

[jira] [Commented] (SUREFIRE-1621) package-private class/method supported in JUnit5 is not executed

2021-11-16 Thread Alex Chachanashvili (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444757#comment-17444757 ] Alex Chachanashvili commented on SUREFIRE-1621: --- Seems to work. > package-private

[GitHub] [maven-enforcer] timtebeek commented on pull request #125: [MENFORCER-372] Drop PlexusTestCase and junit:junit dependency

2021-11-16 Thread GitBox
timtebeek commented on pull request #125: URL: https://github.com/apache/maven-enforcer/pull/125#issuecomment-970553691 Turns out we did need the junit-jupiter-engine [after all](https://github.com/apache/maven-enforcer/pull/113#discussion_r749185199); Time for another quick review

[GitHub] [maven] rmannibucau commented on a change in pull request #607: [MNG-7129] Import maven caching system

2021-11-16 Thread GitBox
rmannibucau commented on a change in pull request #607: URL: https://github.com/apache/maven/pull/607#discussion_r750487797 ## File path: maven-caching/src/main/java/org/apache/maven/caching/ProjectUtils.java ## @@ -0,0 +1,200 @@ +package org.apache.maven.caching; + +/* + *

[jira] [Commented] (SUREFIRE-1621) package-private class/method supported in JUnit5 is not executed

2021-11-16 Thread Alex Chachanashvili (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444667#comment-17444667 ] Alex Chachanashvili commented on SUREFIRE-1621: --- I'll do a full clean and verify

[GitHub] [maven] rmannibucau commented on a change in pull request #607: [MNG-7129] Import maven caching system

2021-11-16 Thread GitBox
rmannibucau commented on a change in pull request #607: URL: https://github.com/apache/maven/pull/607#discussion_r750487238 ## File path: maven-caching/src/main/java/org/apache/maven/caching/ProjectUtils.java ## @@ -0,0 +1,200 @@ +package org.apache.maven.caching; + +/* + *

[jira] [Commented] (SUREFIRE-1621) package-private class/method supported in JUnit5 is not executed

2021-11-16 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444663#comment-17444663 ] Slawomir Jaranowski commented on SUREFIRE-1621: --- [~achacha] from your logs: {code}

[jira] [Commented] (SUREFIRE-1621) package-private class/method supported in JUnit5 is not executed

2021-11-16 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444661#comment-17444661 ] Slawomir Jaranowski commented on SUREFIRE-1621: --- OK, my steps: * download

[GitHub] [maven-scm] rmannibucau edited a comment on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-16 Thread GitBox
rmannibucau edited a comment on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-970459864 @Lonzak agree, just would be great to not see dozens of PR to explicitly set the attribute and let external plugins benefit from it OOTB too - it is not a trivial

[GitHub] [maven-scm] rmannibucau commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-16 Thread GitBox
rmannibucau commented on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-970459864 @Lonzak agree, just would be great to not see dozens of PR to explicitly set the attribute and let external plugins benefit from it OOTB too - it is not a trivial behavior

[GitHub] [maven-scm] Lonzak edited a comment on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-16 Thread GitBox
Lonzak edited a comment on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-970454163 I see. Would make sense then other projects which have the same problem would be solved, too. But I see this as a parallel improvement to this one. If a plugin sets the

[GitHub] [maven-scm] Lonzak commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-16 Thread GitBox
Lonzak commented on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-970454163 I see. Would make sense then other projects which have the same problem would be solved, too. But I see this as a parallel improvement to this one. If a plugin sets the value

[jira] [Comment Edited] (SUREFIRE-1621) package-private class/method supported in JUnit5 is not executed

2021-11-16 Thread Alex Chachanashvili (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444645#comment-17444645 ] Alex Chachanashvili edited comment on SUREFIRE-1621 at 11/16/21, 4:31 PM:

[GitHub] [maven] gnodet commented on pull request #597: [MNG-7129] Incremental build and shared cache feature

2021-11-16 Thread GitBox
gnodet commented on pull request #597: URL: https://github.com/apache/maven/pull/597#issuecomment-970446711 Superseded by #607 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [maven] gnodet closed pull request #597: [MNG-7129] Incremental build and shared cache feature

2021-11-16 Thread GitBox
gnodet closed pull request #597: URL: https://github.com/apache/maven/pull/597 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (SUREFIRE-1621) package-private class/method supported in JUnit5 is not executed

2021-11-16 Thread Alex Chachanashvili (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444645#comment-17444645 ] Alex Chachanashvili commented on SUREFIRE-1621: --- Upgrading from 2.22.2 to 3.0.0-M5

[GitHub] [maven-scm] Lonzak edited a comment on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-16 Thread GitBox
Lonzak edited a comment on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-970411568 Ok I changed it to false. @rmannibucau If you mean the [MojoAnnotationVisitor

[GitHub] [maven-scm] rmannibucau commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-16 Thread GitBox
rmannibucau commented on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-970414909 @Lonzak maven-plugin-tools:

[GitHub] [maven-scm] Lonzak commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-16 Thread GitBox
Lonzak commented on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-970411568 Ok I changed it to false. @michael-o If you mean the [MojoAnnotationVisitor

[GitHub] [maven] gnodet edited a comment on pull request #610: [MNG-7129] - Changes in maven core required to support incremental mave…

2021-11-16 Thread GitBox
gnodet edited a comment on pull request #610: URL: https://github.com/apache/maven/pull/610#issuecomment-970383965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [maven] gnodet edited a comment on pull request #610: [MNG-7129] - Changes in maven core required to support incremental mave…

2021-11-16 Thread GitBox
gnodet edited a comment on pull request #610: URL: https://github.com/apache/maven/pull/610#issuecomment-970383965 > > If this is ultimately going to be an extension, which I agree it should, can one commit be of the interfaces created that will allow the incremental capabilities in the

[GitHub] [maven] gnodet commented on pull request #610: [MNG-7129] - Changes in maven core required to support incremental mave…

2021-11-16 Thread GitBox
gnodet commented on pull request #610: URL: https://github.com/apache/maven/pull/610#issuecomment-970383965 > > If this is ultimately going to be an extension, which I agree it should, can one commit be of the interfaces created that will allow the incremental capabilities in the core,

[GitHub] [maven] maximilian-novikov-db removed a comment on pull request #610: [MNG-7129] - Changes in maven core required to support incremental mave…

2021-11-16 Thread GitBox
maximilian-novikov-db removed a comment on pull request #610: URL: https://github.com/apache/maven/pull/610#issuecomment-970353063 > If this is ultimately going to be an extension, which I agree it should, can one commit be of the interfaces created that will allow the incremental

[GitHub] [maven] maximilian-novikov-db commented on pull request #610: [MNG-7129] - Changes in maven core required to support incremental mave…

2021-11-16 Thread GitBox
maximilian-novikov-db commented on pull request #610: URL: https://github.com/apache/maven/pull/610#issuecomment-970353063 > If this is ultimately going to be an extension, which I agree it should, can one commit be of the interfaces created that will allow the incremental capabilities in

[GitHub] [maven] andrey-petrenko-db commented on pull request #610: [MNG-7129] - Changes in maven core required to support incremental mave…

2021-11-16 Thread GitBox
andrey-petrenko-db commented on pull request #610: URL: https://github.com/apache/maven/pull/610#issuecomment-970350856 > If this is ultimately going to be an extension, which I agree it should, can one commit be of the interfaces created that will allow the incremental capabilities in

[GitHub] [maven] jvanzyl edited a comment on pull request #610: [MNG-7129] - Changes in maven core required to support incremental mave…

2021-11-16 Thread GitBox
jvanzyl edited a comment on pull request #610: URL: https://github.com/apache/maven/pull/610#issuecomment-970297752 If this is ultimately going to be an extension, which I agree it should, can one commit be of the interfaces created that will allow the incremental capabilities in the

[GitHub] [maven] jvanzyl commented on pull request #610: [MNG-7129] - Changes in maven core required to support incremental mave…

2021-11-16 Thread GitBox
jvanzyl commented on pull request #610: URL: https://github.com/apache/maven/pull/610#issuecomment-970297752 If this is ultimately going to be an extension, which I agree it should, can one commit be of the interfaces created that will allow the incremental capabilities in the core, and

[jira] [Resolved] (MNG-7337) Remove usage of plexus logger

2021-11-16 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet resolved MNG-7337. -- Assignee: Guillaume Nodet Resolution: Fixed > Remove usage of plexus logger >

[GitHub] [maven-scm] michael-o commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-16 Thread GitBox
michael-o commented on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-970183541 > > > Shouldn't MojoAnnotationVisitor be changed to ensure there is a safe default to avoid such an issue (instead of just relying on visited value, rely on spec -

[GitHub] [maven-scm] rmannibucau commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-16 Thread GitBox
rmannibucau commented on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-970141490 Shouldn't MojoAnnotationVisitor be changed to ensure there is a safe default to avoid such an issue (instead of just relying on visited value, rely on spec - reflection - +

[GitHub] [maven-scm] michael-o commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-16 Thread GitBox
michael-o commented on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-970131225 > > > There is a big difference: when you set it to false your plugin would not be executed in parallel and the warning would not appear. I mean in case of doubt set

[GitHub] [maven-resolver] cstamas commented on pull request #131: [MRESOLVER-219] File advisory locking based NamedLocks

2021-11-16 Thread GitBox
cstamas commented on pull request #131: URL: https://github.com/apache/maven-resolver/pull/131#issuecomment-970115954 > Refactorings not part of file based locks should be a separate PR and JIRA issue. Since I want to test is separately. Sure, once this merged I can retarget that PR

[GitHub] [maven-scm] Lonzak commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-16 Thread GitBox
Lonzak commented on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-970103048 There is a big difference: when you set it to false your plugin would not be executed in parallel and the warning would not appear. I mean in case of doubt set it to false -

[GitHub] [maven-resolver] michael-o commented on pull request #131: [MRESOLVER-219] File advisory locking based NamedLocks

2021-11-16 Thread GitBox
michael-o commented on pull request #131: URL: https://github.com/apache/maven-resolver/pull/131#issuecomment-970097721 > > > @gnodet @michael-o pls look at this one #134 (to be merged into this PR) Refactorings not part of file based locks should be a separate PR and JIRA

[GitHub] [maven-scm] michael-o commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-16 Thread GitBox
michael-o commented on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-970096072 What is the different between `false` and settings? I don't see any at the moment. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [maven-resolver] cstamas commented on pull request #131: [MRESOLVER-219] File advisory locking based NamedLocks

2021-11-16 Thread GitBox
cstamas commented on pull request #131: URL: https://github.com/apache/maven-resolver/pull/131#issuecomment-970089489 @gnodet @michael-o pls look at this one https://github.com/apache/maven-resolver/pull/134 (to be merged into this PR) -- This is an automated message from the Apache Git

[GitHub] [maven-resolver] cstamas opened a new pull request #134: Refactor source of time

2021-11-16 Thread GitBox
cstamas opened a new pull request #134: URL: https://github.com/apache/maven-resolver/pull/134 It does not belong to selector, moreover, the values should come from session and not system properties. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (MNG-7337) Remove usage of plexus logger

2021-11-16 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MNG-7337: Summary: Remove usage of plexus logger Key: MNG-7337 URL: https://issues.apache.org/jira/browse/MNG-7337 Project: Maven Issue Type: Sub-task

[GitHub] [maven] gnodet commented on pull request #607: [MNG-7129] Import maven caching system

2021-11-16 Thread GitBox
gnodet commented on pull request #607: URL: https://github.com/apache/maven/pull/607#issuecomment-97001 > Can we please not introduce the usage of Plexus Logger here? Just go with SLF4J loggers in new code... I've raised https://issues.apache.org/jira/browse/MNG-7337 and I'll

[GitHub] [maven-scm] Lonzak commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-16 Thread GitBox
Lonzak commented on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-970073979 But what about setting it to false if you or the project is not sure about this? And later if that is clarified change it to true when clarified? And who can say that it is

[GitHub] [maven-resolver] michael-o commented on a change in pull request #131: [MRESOLVER-219] File advisory locking based NamedLocks

2021-11-16 Thread GitBox
michael-o commented on a change in pull request #131: URL: https://github.com/apache/maven-resolver/pull/131#discussion_r750061996 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/SimpleNamedLockFactorySelector.java ## @@

[GitHub] [maven-resolver] cstamas commented on a change in pull request #131: [MRESOLVER-219] File advisory locking based NamedLocks

2021-11-16 Thread GitBox
cstamas commented on a change in pull request #131: URL: https://github.com/apache/maven-resolver/pull/131#discussion_r750053955 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/SimpleNamedLockFactorySelector.java ## @@ -19,36

[GitHub] [maven-scm] michael-o commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-16 Thread GitBox
michael-o commented on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-970061049 No changes so far because on really needs to know that the code is truely threadsafe. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven-resolver] cstamas commented on a change in pull request #131: [MRESOLVER-219] File advisory locking based NamedLocks

2021-11-16 Thread GitBox
cstamas commented on a change in pull request #131: URL: https://github.com/apache/maven-resolver/pull/131#discussion_r750051515 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/NamedLockFactorySelector.java ## @@ -19,22

[GitHub] [maven-resolver] michael-o commented on a change in pull request #131: [MRESOLVER-219] File advisory locking based NamedLocks

2021-11-16 Thread GitBox
michael-o commented on a change in pull request #131: URL: https://github.com/apache/maven-resolver/pull/131#discussion_r750051102 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/SimpleNamedLockFactorySelector.java ## @@

[GitHub] [maven-resolver] michael-o commented on a change in pull request #131: [MRESOLVER-219] File advisory locking based NamedLocks

2021-11-16 Thread GitBox
michael-o commented on a change in pull request #131: URL: https://github.com/apache/maven-resolver/pull/131#discussion_r750050573 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/NamedLockFactorySelector.java ## @@ -19,22

[GitHub] [maven-scm] Lonzak commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

2021-11-16 Thread GitBox
Lonzak commented on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-970059393 Any updates? Can I support you on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

  1   2   >