[GitHub] [maven] gnodet commented on a diff in pull request #1220: [MNG-7866] Improvements to the logging API usage (technical debt)

2023-09-03 Thread via GitHub
gnodet commented on code in PR #1220: URL: https://github.com/apache/maven/pull/1220#discussion_r1314461642 ## maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java: ## @@ -152,14 +150,15 @@ private ClassRealm createRealm( List

[GitHub] [maven-javadoc-plugin] hgschmie commented on a diff in pull request #227: [MJAVADOC-769] fix for transitive filename based modules

2023-09-03 Thread via GitHub
hgschmie commented on code in PR #227: URL: https://github.com/apache/maven-javadoc-plugin/pull/227#discussion_r1314455927 ## src/it/projects/MJAVADOC-769/src/main/java/mavenbugs/mjavadoc769/InternalImportBindingBuilder.java: ## @@ -0,0 +1,116 @@ +package

[GitHub] [maven-javadoc-plugin] hgschmie commented on a diff in pull request #227: [MJAVADOC-769] fix for transitive filename based modules

2023-09-03 Thread via GitHub
hgschmie commented on code in PR #227: URL: https://github.com/apache/maven-javadoc-plugin/pull/227#discussion_r1314451026 ## src/it/projects/MJAVADOC-769/pom.xml: ## @@ -0,0 +1,169 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [maven-javadoc-plugin] hgschmie commented on a diff in pull request #227: [MJAVADOC-769] fix for transitive filename based modules

2023-09-03 Thread via GitHub
hgschmie commented on code in PR #227: URL: https://github.com/apache/maven-javadoc-plugin/pull/227#discussion_r1314450414 ## src/it/projects/MJAVADOC-769/src/test/java/mavenbugs/mjavadoc769/RightTest.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed under the Apache License, Version

[GitHub] [maven-site] oliveryasuna opened a new pull request, #445: Update pom.apt.vm

2023-09-03 Thread via GitHub
oliveryasuna opened a new pull request, #445: URL: https://github.com/apache/maven-site/pull/445 Replaced link to "Maven 2 Pom Demystified". The current link no longer works. I replaced it with the latest working Internet Archive link. -- This is an automated message from the

[GitHub] [maven-javadoc-plugin] slawekjaranowski commented on a diff in pull request #227: [MJAVADOC-769] fix for transitive filename based modules

2023-09-03 Thread via GitHub
slawekjaranowski commented on code in PR #227: URL: https://github.com/apache/maven-javadoc-plugin/pull/227#discussion_r1314315492 ## src/it/projects/MJAVADOC-769/src/main/java/mavenbugs/mjavadoc769/InternalImportBindingBuilder.java: ## @@ -0,0 +1,116 @@ +package

[GitHub] [maven-ear-plugin] slachiewicz commented on pull request #97: [MEAR-327] update to parent pom 39

2023-09-03 Thread via GitHub
slachiewicz commented on PR #97: URL: https://github.com/apache/maven-ear-plugin/pull/97#issuecomment-1704325339 You have duplicate license headers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (MNG-7677) Maven 3.9.0 is ~10% slower than 3.8.7 in large multi-module builds

2023-09-03 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761568#comment-17761568 ] Tamas Cservenak commented on MNG-7677: -- You plan a PR? > Maven 3.9.0 is ~10% slower than 3.8.7 in