Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/179
@jbliznak
Thx for the fix. We have 5 pending branches to accept with conflicts in the
same Java file.
So we will take them first and rebase this one afterwards.
I have assigned
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/176
@eolivelli
done. I did git commit amend so you have to clone the repo again.
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/177
Maybe not necessary to test it again because I downloaded logs from our
Jenkins ans I see the IT
JUnit48TestCategoriesIT_testBadCategoryForkAlways
which has the Warning message
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/177
@eolivelli
Pls check it our with your code. The log should not appear in the dump file.
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/177
@eolivelli
If you know how to do it in CI, just tell me.
You can see CI Mulibranch Pipeline in
https://builds.apache.org/job/maven-wip/job/maven-surefire/
---
GitHub user Tibor17 opened a pull request:
https://github.com/apache/maven-surefire/pull/178
SUREFIRE-1422
Related to JIRA
[SUREFIRE-1422](https://issues.apache.org/jira/browse/SUREFIRE-1422).
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user Tibor17 opened a pull request:
https://github.com/apache/maven-surefire/pull/177
[SUREFIRE-1498] Surefire prints own logs "Couldn't load group class" to
native stream.
Related to JIRA
[SUREFIRE-1498](https://issues.apache.org/jira/browse/SUREFIRE-1498).
You
GitHub user Tibor17 opened a pull request:
https://github.com/apache/maven-surefire/pull/176
[SUREFIRE-1495] Encoding of TXT report file should be configured by
${project.reporting.outputEncoding} and MOJO parameter encoding
Related to JIRA
[SUREFIRE-1495](https
GitHub user Tibor17 opened a pull request:
https://github.com/apache/maven-surefire/pull/175
[SUREFIRE-1490] Change header of the Failsafe Report
Related to JIRA
[SUREFIRE-1490](https://issues.apache.org/jira/browse/SUREFIRE-1490).
You can merge this pull request into a Git
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/163
@shafiullas
Please close this PR: https://github.com/apache/maven-surefire/pull/163
Thx
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/174
@awallgren
You can close this PR. There is already a branch with dedicated fix:
https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=shortlog;h=refs/heads/SUREFIRE-1475
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/174
@awallgren
Are you here?
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/174
Of course you should push only single commit in PR.
`git commit --amend`
and the title must be
`[SUREFIRE-1475] ...here is title as in Jira...`
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/174
First of all do it similar like we do in *NIX.
Resolve `%SystemRoot%\System32\Wbem\wmic.exe` in Java and check that the
file exists.
If it exists use it, otherwise do it as we did
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/173
Thx for your work. I will get back to you soon. Right now I am working on
branch SUREFIRE-1463 which contains few fixes. I plan to finish this,
including build script, and then I would
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/174
Logging errors can be added to the dump file, but right now please add the
Microsoft link, as you said 'yes'.
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/174
Did we take right path here as well? Did Microsoft mention this link in
their documentation?
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
Now there is only one issue to fix related to Windows paths.
Need to investigate.
https://builds.apache.org/job/maven-surefire-pipeline/job/SUREFIRE-1463/121
[windows-jdk9
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
The project has new build script and testing JDK 7-10 in combination of
multiple platforms. That is the main purpose of Version 2.21.0. Sorry that
it takes so long. We are discovering
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/173
@bindul
Then we have to support also other alternatives:
`groupId:artifactId:version`, and
`groupId:artifactId:packaging:version`.
This means you have to, first of all, count
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/173
@binduk
We have modify the maven coordinates to
`groupId:artifactId:packaging:classifier:version`, see the docs:
https://maven.apache.org/pom.html#Maven_Coordinates
Basically
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/173#discussion_r161337637
--- Diff:
maven-surefire-plugin/src/site/apt/examples/inclusion-exclusion.apt.vm ---
@@ -209,4 +209,41 @@ Inclusions and Exclusions of Tests
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/173#discussion_r161336602
--- Diff:
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1004RunTestFromDependencyJarsTypeAndClassifierIT.java
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/173#discussion_r161336480
--- Diff:
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/util/DependenciesScannerTest.java
---
@@ -69,19 +78,141 @@ public
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/173#discussion_r161336057
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
---
@@ -732,7 +732,8
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/173#discussion_r161335367
--- Diff:
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/util/DependenciesScannerTest.java
---
@@ -19,12 +19,17
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/173#discussion_r161334621
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/util/DependencyScanner.java
---
@@ -111,19 +112,46 @@ private static
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/173#discussion_r161333957
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/util/DependencyScanner.java
---
@@ -111,19 +112,46 @@ private static
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/173#discussion_r161333588
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/util/DependencyScanner.java
---
@@ -111,19 +112,46 @@ private static
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/173#discussion_r161333402
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/util/DependencyScanner.java
---
@@ -111,19 +112,46 @@ private static
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/173#discussion_r161332171
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/util/DependencyScanner.java
---
@@ -111,19 +112,46 @@ private static
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/173#discussion_r161331717
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/util/DependencyScanner.java
---
@@ -111,19 +112,46 @@ private static
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/173
I don't want you to remove code. I will try to explain in code.
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/173
The comments like this `// Check version` are not needed because it's
obvious from code.
You may remove them or extract that part to private static methods. It's up
to you.
If you
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/163
@shafiullas
Thx for contributing. The PR was modified and pushed to master. Please
close this PR.
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/163
@shafiullas
I have fixed the checkstyle in your code but I do not see text of
Description in HTML. Did you try to use it in real and saw the Description on
the page?
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@mpkorstanje
Thx for contributing.
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/143
@surli
Thx for contributing. Now you can close the PR.
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/143
@surli
Pls try to use it in your projects. I want to know if it is useful for you
and working. Thx.
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/143
@surli
If there are no objections, I would push the branch SUREFIRE-1416 to master.
Thx.
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/143
@surli
I had to change you code in new branch
https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=shortlog;h=refs/heads/SUREFIRE-1416
Can you build the version
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@mpkorstanje
The build passed successfully. I will refactor little details, I will
squash our commits and then I will push it to master.
I could not find a documentation
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/150#discussion_r158589504
--- Diff:
surefire-providers/surefire-junit4/src/main/java/org/apache/maven/surefire/junit4/JUnit4Provider.java
---
@@ -55,7 +53,8 @@
import
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
The fast way would be to give it a try in a copy of your project apart and
run the local build
"mvn install -P run-its -Dcheckstyle.skip=true".
Even if you copied Fil
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@mpkorstanje
After seen the code of junit4 provider I have realized that `Filter` also
exists in JUnit4. Therefore maybe using a combination of class/method and using
JUnit's Request
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/167
@DaGeRe
Close this PR!
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@mpkorstanje
Can we continue? Do you have spare time?
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/172
@eolivelli
Thx for contributing. The PR was pushed to master and now it can be closed.
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/167
@DaGeRe
Close this PR on GitHub. I have made a fix.
See this Jira issue: https://issues.apache.org/jira/browse/SUREFIRE-1454
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/172
Try to name the commit with brackets:
` [SUREFIRE-1453] Allow to specify non existant classes as groups`
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/172
@eolivelli
Thx for your work. Try to prove it with integration test. We always have to
do it if it technically can be tested.
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@mpkorstanje
I saw you typed version `2.21`. It should be `2.21.0`. Pls fix this as
well. Thx.
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@mpkorstanje
Now I understand the Cucumber internals.
Can you write the documentation?
Fix the checkstyle in your integration test and the classes
`FlakeCucumberTest
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/166
@krmahadevan
Thx for contributing. Now you should close this PR.
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/166
@krmahadevan
There is one failing integration test:
[unix] Failed tests: shouldNotRunExcludedClassesAndMethods[0
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/166
@krmahadevan
I have created a branch `SUREFIRE-1452`, changed your commit [1] according
to our needs and now the build is running [2].
[1]:
https://git1-us-west.apache.org/repos/asf
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@mpkorstanje
I do not have questions yet. I am just reading your comments. I would think
of the code combining together with Cucumber internals and then I would have
maybe some notice.
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/166
@krmahadevan
Do you have a spare time for Surefire?
This is good work but there is only a little to do: checkstyle and Jira
ticket.
---
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@mpkorstanje
I want to ask you few question because I want to make minimum invasive
changes in the code.
Why you have chosen provider `surefire-junit47` and not also the
`surefire
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@mpkorstanje
Additionally, can you write a separate documentation file `cucumber.apt.vm`
for Cucumber with your best practices to setup and use cucumber in terms of
`maven-surefire
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@mpkorstanje
How is `Description` constructed now by Cucumber?
Does it contain the real method name or it is a scenario text?
---
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/150#discussion_r155940679
--- Diff:
surefire-integration-tests/src/test/resources/junit47-rerun-failing-tests-with-cucumber/pom.xml
---
@@ -0,0 +1,79
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
As far as I remember the filter was used in rerun feature where broken
tests were executed several more times after.
Yet let me check your branch because that's better than if you
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@mpkorstanje
@ckurban
@sworisbreathing
I could not merge and release this PR because the class
`FailingMethodFilter.java` in [1] was deleted.
We have to have it back
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@sworisbreathing
Let me go through these changes again.
---
65 matches
Mail list logo
