[GitHub] [maven-shade-plugin] rmannibucau commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin

rmannibucau commented on code in PR #129: URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r844129180 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set

[GitHub] [maven-shade-plugin] rmannibucau commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin

rmannibucau commented on code in PR #129: URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843924166 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set

[GitHub] [maven-shade-plugin] rmannibucau commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin

rmannibucau commented on code in PR #129: URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843918306 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set

[GitHub] [maven-shade-plugin] rmannibucau commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin

rmannibucau commented on code in PR #129: URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843877455 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set

[GitHub] [maven-shade-plugin] rmannibucau commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin

rmannibucau commented on code in PR #129: URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843825833 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set

[GitHub] [maven-shade-plugin] rmannibucau commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin

rmannibucau commented on code in PR #129: URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843695691 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set

[GitHub] [maven-shade-plugin] rmannibucau commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin

rmannibucau commented on code in PR #129: URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843529949 ## src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java: ## @@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set