Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

mkolesnikov commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1627517025 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/util/CiFriendlyVersion.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

mkolesnikov commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1627512879 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/util/CiFriendlyVersion.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

michael-o commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1627504174 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/util/CiFriendlyVersion.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

mkolesnikov commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1627443336 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/util/CiFriendlyVersion.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

mkolesnikov commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1627443336 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/util/CiFriendlyVersion.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

michael-o commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1627389761 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/util/CiFriendlyVersion.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

michael-o commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1627264489 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/util/CiFriendlyVersion.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

mkolesnikov commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1627174008 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/transform/jdom2/JDomModel.java: ## @@ -192,14 +199,13 @@ public void setVersion(String

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

mkolesnikov commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1627174008 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/transform/jdom2/JDomModel.java: ## @@ -192,14 +199,13 @@ public void setVersion(String

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

mkolesnikov commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1627172157 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/util/CiFriendlyVersion.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

michael-o commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1626977980 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/util/CiFriendlyVersion.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

mkolesnikov commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1626755020 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/util/CiFriendlyVersion.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

michael-o commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1626373410 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/transform/jdom2/JDomModel.java: ## @@ -192,14 +199,13 @@ public void setVersion(String

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

michael-o commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1625824649 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/util/CiFriendlyVersion.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

mkolesnikov commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1625802225 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/util/CiFriendlyVersion.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

mkolesnikov commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1625675336 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/transform/jdom2/JDomProperties.java: ## @@ -51,10 +51,13 @@ public

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

michael-o commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1625671167 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/util/CiFriendlyVersion.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

mkolesnikov commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1625665294 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/util/CiFriendlyVersion.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

mkolesnikov commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1625665294 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/util/CiFriendlyVersion.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

michael-o commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1625651831 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/util/CiFriendlyVersion.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

mkolesnikov commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1625646768 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/transform/jdom2/JDomProperties.java: ## @@ -51,10 +51,13 @@ public

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

mkolesnikov commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1625642237 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/util/CiFriendlyVersion.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

michael-o commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1625608386 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/util/CiFriendlyVersion.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

mkolesnikov commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1624586351 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/transform/jdom2/JDomModel.java: ## @@ -198,7 +199,17 @@ public void setVersion(String

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

michael-o commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1421564124 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/transform/jdom2/JDomModel.java: ## @@ -198,7 +199,17 @@ public void setVersion(String

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

mkolesnikov commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1413529992 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java: ## @@ -96,7 +96,7 @@ public abstract class

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

mkolesnikov commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1413529992 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java: ## @@ -96,7 +96,7 @@ public abstract class

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

mkolesnikov commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1413529992 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java: ## @@ -96,7 +96,7 @@ public abstract class

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

mkolesnikov commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1413526292 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/transform/jdom2/JDomModel.java: ## @@ -198,7 +199,17 @@ public void setVersion(String

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

michael-o commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1413214047 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/transform/jdom2/JDomModel.java: ## @@ -198,7 +199,17 @@ public void setVersion(String

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

michael-o commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1413213842 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java: ## @@ -96,7 +96,7 @@ public abstract class

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

mkolesnikov commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1412084550 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/RewritePomsForReleasePhase.java: ## @@ -214,6 +217,15 @@ private boolean

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

michael-o commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1411233842 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/RewritePomsForReleasePhase.java: ## @@ -214,6 +217,15 @@ private boolean

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

kwin commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1410645662 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/RewritePomsForReleasePhase.java: ## @@ -214,6 +217,15 @@ private boolean translateScm(

[PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

mkolesnikov opened a new pull request, #202: URL: https://github.com/apache/maven-release/pull/202 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MRELEASE) filed