hboutemy commented on PR #220:
URL:
https://github.com/apache/maven-shade-plugin/pull/220#issuecomment-2067704248
disagree: tests show reproducible builds independent from TZ = what they are
supposed to be
you are looking for something else: detail what you are looking for and work
rmannibucau commented on PR #220:
URL:
https://github.com/apache/maven-shade-plugin/pull/220#issuecomment-2067699038
* reproducible tests don't check the time is accurate whatever the timezone
is (it is the opposite as shown by the test)
* UTC tests do not use UTC time so they are iso
hboutemy commented on PR #220:
URL:
https://github.com/apache/maven-shade-plugin/pull/220#issuecomment-2067694954
test done with Reproducible Central:
https://github.com/hboutemy/reproducible-central/tree/MSHADE-471/MSHADE-471
tests that using UTC does not any more get a different
hboutemy commented on PR #220:
URL:
https://github.com/apache/maven-shade-plugin/pull/220#issuecomment-2057797095
fyi https://issues.apache.org/jira/browse/MJAR-300 dived recently on DOS
date in zip files that are not timezone aware vs Unix timestamp that are
timezone aware
this is
hboutemy commented on PR #220:
URL:
https://github.com/apache/maven-shade-plugin/pull/220#issuecomment-2054182363
expectation of this PR is Reproducible Builds
the test does not test reproducible builds, it tests what you think is the
timestamp that should be in the zip, ignoring the
hboutemy commented on PR #220:
URL:
https://github.com/apache/maven-shade-plugin/pull/220#issuecomment-2054181874
expectation of this PR is Reproducible Builds
the test does not test reproducible builds, it tests what you think is the
timestamp that should be in the zip, ignoring the
rmannibucau commented on PR #220:
URL:
https://github.com/apache/maven-shade-plugin/pull/220#issuecomment-2054146138
@hboutemy you merged but I didn't see any test showing that it helps, can
you try to work on it - not asking for an IT, no worries.
For example a trivial test has the
hboutemy merged PR #220:
URL: https://github.com/apache/maven-shade-plugin/pull/220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hboutemy commented on PR #220:
URL:
https://github.com/apache/maven-shade-plugin/pull/220#issuecomment-2053950887
I'd love, if you find a way to do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rmannibucau commented on PR #220:
URL:
https://github.com/apache/maven-shade-plugin/pull/220#issuecomment-2053704080
Ultimately it could need some unit test (or it but it is overkill there and
hard to do right) + what about documenting how to not need it (local=utc for
the build)?
--
10 matches
Mail list logo
