cstamas merged PR #953:
URL: https://github.com/apache/maven-mvnd/pull/953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gnodet commented on code in PR #953:
URL: https://github.com/apache/maven-mvnd/pull/953#discussion_r1576253478
##
common/src/main/java/org/mvndaemon/mvnd/common/Environment.java:
##
@@ -224,7 +224,7 @@ public enum Environment {
null,
cstamas commented on PR #953:
URL: https://github.com/apache/maven-mvnd/pull/953#issuecomment-2071802629
Unsure why ubuntu failed, win passed locally also passed w/ same CLI
params as CI invoked :thinking:
--
This is an automated message from the Apache Git Service.
To respond to
cstamas commented on code in PR #953:
URL: https://github.com/apache/maven-mvnd/pull/953#discussion_r1575828803
##
integration-tests/src/test/projects/maven-conf-ignore-ext-def/pom.xml:
##
@@ -0,0 +1,27 @@
gnodet commented on code in PR #953:
URL: https://github.com/apache/maven-mvnd/pull/953#discussion_r1575782068
##
client/src/main/java/org/mvndaemon/mvnd/client/DaemonParameters.java:
##
@@ -491,16 +491,22 @@ private static List
readCoreExtensionsDescriptor(Path multiModule
gnodet commented on PR #953:
URL: https://github.com/apache/maven-mvnd/pull/953#issuecomment-2070825470
> @gnodet If you run this PR locally:
>
> * it will pass ok, but
> * maven-conf-ignore-ext IT is **wrong**: maven.conf where ignore is, is
not observed by mvnd. Also local
cstamas commented on PR #953:
URL: https://github.com/apache/maven-mvnd/pull/953#issuecomment-2070176626
@gnodet If you run this PR locally:
* it will pass ok, but
* maven-conf-ignore-ext IT is **wrong**: maven.conf where ignore is, is not
observed by mvnd. Also local repository will
cstamas commented on PR #953:
URL: https://github.com/apache/maven-mvnd/pull/953#issuecomment-2070153385
Sure, this will be in it. But as i wrote, seems there is something else to
be fixed as IT this PR adds shows...
--
This is an automated message from the Apache Git Service.
To respond
wendigo commented on PR #953:
URL: https://github.com/apache/maven-mvnd/pull/953#issuecomment-2070141407
Can we get this in for alpha14?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
cstamas commented on PR #953:
URL: https://github.com/apache/maven-mvnd/pull/953#issuecomment-2067741336
The code change is OK and fixes issue, but something is wrong.
Created https://github.com/apache/maven-mvnd/issues/957
--
This is an automated message from the Apache Git Service.
cstamas commented on PR #953:
URL: https://github.com/apache/maven-mvnd/pull/953#issuecomment-2067647961
Am adding IT (something I'd done initially would catch this), and will merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
wendigo commented on PR #953:
URL: https://github.com/apache/maven-mvnd/pull/953#issuecomment-2067647580
That works :) Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
12 matches
Mail list logo
