[GitHub] [maven-fluido-skin] michael-o closed pull request #13: [MSKINS-163] Upgrade parent pom 30 -> 34
michael-o closed pull request #13: [MSKINS-163] Upgrade parent pom 30 -> 34 URL: https://github.com/apache/maven-fluido-skin/pull/13 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-fluido-skin] michael-o closed pull request #14: [MSKINS-164] Upgrade maven-invoker-plugin 1.10 -> 3.2.1
michael-o closed pull request #14: [MSKINS-164] Upgrade maven-invoker-plugin 1.10 -> 3.2.1 URL: https://github.com/apache/maven-fluido-skin/pull/14 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MSKINS-163) Upgrade to parent POM 34
[ https://issues.apache.org/jira/browse/MSKINS-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066028#comment-17066028 ] Michael Osipov commented on MSKINS-163: --- Please open separate tickets for separate problems. > Upgrade to parent POM 34 > > > Key: MSKINS-163 > URL: https://issues.apache.org/jira/browse/MSKINS-163 > Project: Maven Skins > Issue Type: Dependency upgrade > Components: Fluido Skin >Affects Versions: fluido-1.8 >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Major > Fix For: fluido-1.9 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MJAVADOC-430) Pick up documentation and integrate it into plugin docs
[ https://issues.apache.org/jira/browse/MJAVADOC-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066189#comment-17066189 ] Robert Scholte commented on MJAVADOC-430: - This is not yet smart enough for "up-for-grabs". What is the issue?(don't use a link, but write/copy the question and refer to SO). What do we expect? Is it as easy as rewriting the answer of SO into /src/site/md/examples/include-centralized-resources.md ? (yes, the first markdown page of this project. We should move away from apt and move to the general accepted md files) > Pick up documentation and integrate it into plugin docs > --- > > Key: MJAVADOC-430 > URL: https://issues.apache.org/jira/browse/MJAVADOC-430 > Project: Maven Javadoc Plugin > Issue Type: Improvement >Reporter: Karl Heinz Marbaise >Priority: Minor > Labels: docs, up-for-grabs > > http://stackoverflow.com/questions/30507476/maven-javadoc-how-to-include-centralized-resources/30668813#30668813 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MJAVADOC-645) Remind user to add Automatic-Module-Name entry when an unnamed module depends on a named module
[
https://issues.apache.org/jira/browse/MJAVADOC-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065421#comment-17065421
]
Michael Osipov commented on MJAVADOC-645:
-
We should fix the root cause, not the symptom: {{javadoc(1)}. Please report
this on the Javadoc mailing list first.
> Remind user to add Automatic-Module-Name entry when an unnamed module depends
> on a named module
> ---
>
> Key: MJAVADOC-645
> URL: https://issues.apache.org/jira/browse/MJAVADOC-645
> Project: Maven Javadoc Plugin
> Issue Type: Improvement
> Components: jar, javadoc
>Affects Versions: 3.2.0
>Reporter: Gili
>Priority: Major
> Attachments: testcase.zip
>
>
> 1. Extract testcase
> 2. Run `mvn clean package`
> 3. Build fails with:
> {code:java}
> Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.2.0:jar (attach-javadocs) on
> project module2: MavenReportException: Error while generating Javadoc:
> Exit code: 1 - javadoc: error - The code being documented uses packages in
> the unnamed module, but the packages defined in
> http://nexus.sonatype.org/oss-repository-hosting.html/root/module1/apidocs/
> are in named modules.
> Command line was: cmd.exe /X /C ""C:\Program
> Files\Java\jdk-14+36-1461\bin\javadoc.exe" @options @packages"
> Refer to the generated Javadoc files in
> 'C:\Users\Gili\Documents\3rdparty\javadoc-jar-mixing-named-and-unnamed-extending-sonatype\module2\target\apidocs'
> dir.
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (MSKINS-160) Broken links to jira - issue management / tracking system with component
[ https://issues.apache.org/jira/browse/MSKINS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MSKINS-160: - Assignee: Michael Osipov > Broken links to jira - issue management / tracking system with component > > > Key: MSKINS-160 > URL: https://issues.apache.org/jira/browse/MSKINS-160 > Project: Maven Skins > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Minor > > In projects issueManagement tag - points to jira project with component, like: > https://issues.apache.org/jira/browse/MSKINS/component/12326472 > But now this is broken - 404 > Some localizations: > [https://maven.apache.org/skins/maven-default-skin/issue-management.html] > [https://maven.apache.org/skins/maven-fluido-skin/issue-tracking.html] > [https://maven.apache.org/skins/index.html] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SUREFIRE-1762) skipAfterFailureCount>0 with testng 7.1.0 resulting in java.lang.NoSuchMethodError: org.testng.TestNG.addListener(Lorg/testng/ITestListener;)V
[
https://issues.apache.org/jira/browse/SUREFIRE-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana closed SUREFIRE-1762.
--
Resolution: Fixed
https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=e23253e555e8c9844abd99e2d51968386c9ead24
> skipAfterFailureCount>0 with testng 7.1.0 resulting in
> java.lang.NoSuchMethodError:
> org.testng.TestNG.addListener(Lorg/testng/ITestListener;)V
> --
>
> Key: SUREFIRE-1762
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1762
> Project: Maven Surefire
> Issue Type: Bug
> Components: TestNG support
>Affects Versions: 3.0.0-M4
>Reporter: Lutz Neugebauer
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M5
>
> Attachments: pom.xml, testng.xml
>
>
> When using maven-surefire-plugin with configuration
> {code:java}
>
>
> testng.xml
>
> 1
>
> {code}
> this results in
> {code:java}
> java.lang.NoSuchMethodError:
> org.testng.TestNG.addListener(Lorg/testng/ITestListener;)V
> at
> org.apache.maven.surefire.testng.TestNGExecutor.postConfigure(TestNGExecutor.java:312)
> at
> org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:280)
> at
> org.apache.maven.surefire.testng.TestNGXmlTestSuite.execute(TestNGXmlTestSuite.java:75)
> at
> org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:120)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:377)
> at
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:138)
> at
> org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:465)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:451)
> {code}
> For reproducing use the attached [^pom.xml] and [^testng.xml] and execute
> {code:java}
> mvn -B -e clean test
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-surefire] Tibor17 commented on issue #278: Surefire 1762
Tibor17 commented on issue #278: Surefire 1762 URL: https://github.com/apache/maven-surefire/pull/278#issuecomment-603157280 Thx for contributing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] Tibor17 merged pull request #278: Surefire 1762
Tibor17 merged pull request #278: Surefire 1762 URL: https://github.com/apache/maven-surefire/pull/278 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (MSKINS-160) Broken links to JIRA
[ https://issues.apache.org/jira/browse/MSKINS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSKINS-160: -- Summary: Broken links to JIRA (was: Broken links to jira - issue management / tracking system with component) > Broken links to JIRA > > > Key: MSKINS-160 > URL: https://issues.apache.org/jira/browse/MSKINS-160 > Project: Maven Skins > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Minor > > In projects issueManagement tag - points to jira project with component, like: > https://issues.apache.org/jira/browse/MSKINS/component/12326472 > But now this is broken - 404 > Some localizations: > [https://maven.apache.org/skins/maven-default-skin/issue-management.html] > [https://maven.apache.org/skins/maven-fluido-skin/issue-tracking.html] > [https://maven.apache.org/skins/index.html] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSKINS-160) Broken links to JIRA
[ https://issues.apache.org/jira/browse/MSKINS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065503#comment-17065503 ] Hudson commented on MSKINS-160: --- Build succeeded in Jenkins: Maven TLP » maven-site » master #225 See https://builds.apache.org/job/maven-box/job/maven-site/job/master/225/ > Broken links to JIRA > > > Key: MSKINS-160 > URL: https://issues.apache.org/jira/browse/MSKINS-160 > Project: Maven Skins > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Minor > > In projects issueManagement tag - points to jira project with component, like: > https://issues.apache.org/jira/browse/MSKINS/component/12326472 > But now this is broken - 404 > Some localizations: > [https://maven.apache.org/skins/maven-default-skin/issue-management.html] > [https://maven.apache.org/skins/maven-fluido-skin/issue-tracking.html] > [https://maven.apache.org/skins/index.html] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SUREFIRE-1763) surefire does not run junit5 tests
[
https://issues.apache.org/jira/browse/SUREFIRE-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065531#comment-17065531
]
Tibor Digana commented on SUREFIRE-1763:
After debuging our class {{TestPlanScannerFilter}} and after [~DenysGalyuk]
found reported issues JUnit5 GH, I have to close this bug as a duplicate.
> surefire does not run junit5 tests
> ---
>
> Key: SUREFIRE-1763
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1763
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support
>Affects Versions: 3.0.0-M4
>Reporter: Jan Hoef
>Priority: Major
> Attachments: user-deposit-store.zip
>
>
> I have a spring boot project (2.2.5.RELEASE) and when running junit5 test
> with maven it does not see any test to execute (run = 0). I have a dependency
> with spring-boot-starter-test. And tried also to exlude the vintage
> dependency.
>
> org.springframework.boot
> spring-boot-starter-test
> test
>
>
> org.junit.vintage
> junit-vintage-engine
>
>
>
> In my idea the tests are running without any problem. If needed I can put
> the project in the attachement.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (SUREFIRE-1763) surefire does not run junit5 tests
[ https://issues.apache.org/jira/browse/SUREFIRE-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1763. -- Assignee: Tibor Digana Resolution: Duplicate > surefire does not run junit5 tests > --- > > Key: SUREFIRE-1763 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1763 > Project: Maven Surefire > Issue Type: Bug > Components: JUnit 5.x support >Affects Versions: 3.0.0-M4 >Reporter: Jan Hoef >Assignee: Tibor Digana >Priority: Major > Attachments: user-deposit-store.zip > > > I have a spring boot project (2.2.5.RELEASE) and when running junit5 test > with maven it does not see any test to execute (run = 0). I have a dependency > with spring-boot-starter-test. And tried also to exlude the vintage > dependency. > > org.springframework.boot > spring-boot-starter-test > test > > > org.junit.vintage > junit-vintage-engine > > > > In my idea the tests are running without any problem. If needed I can put > the project in the attachement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MSKINS-160) Broken links to JIRA
[ https://issues.apache.org/jira/browse/MSKINS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSKINS-160: -- Fix Version/s: fluido-1.9 > Broken links to JIRA > > > Key: MSKINS-160 > URL: https://issues.apache.org/jira/browse/MSKINS-160 > Project: Maven Skins > Issue Type: Improvement > Components: Default Skin, Fluido Skin >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Minor > Fix For: fluido-1.9 > > > In projects issueManagement tag - points to jira project with component, like: > https://issues.apache.org/jira/browse/MSKINS/component/12326472 > But now this is broken - 404 > Some localizations: > [https://maven.apache.org/skins/maven-default-skin/issue-management.html] > [https://maven.apache.org/skins/maven-fluido-skin/issue-tracking.html] > [https://maven.apache.org/skins/index.html] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MSKINS-160) Broken links to JIRA
[ https://issues.apache.org/jira/browse/MSKINS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSKINS-160: -- Component/s: Fluido Skin Default Skin > Broken links to JIRA > > > Key: MSKINS-160 > URL: https://issues.apache.org/jira/browse/MSKINS-160 > Project: Maven Skins > Issue Type: Improvement > Components: Default Skin, Fluido Skin >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Minor > > In projects issueManagement tag - points to jira project with component, like: > https://issues.apache.org/jira/browse/MSKINS/component/12326472 > But now this is broken - 404 > Some localizations: > [https://maven.apache.org/skins/maven-default-skin/issue-management.html] > [https://maven.apache.org/skins/maven-fluido-skin/issue-tracking.html] > [https://maven.apache.org/skins/index.html] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (SUREFIRE-1757) maven-surefire-plugin versions starting from 2.22.0 do not run JUnit5 Test Suites junit-platform-runner
[
https://issues.apache.org/jira/browse/SUREFIRE-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana reopened SUREFIRE-1757:
> maven-surefire-plugin versions starting from 2.22.0 do not run JUnit5 Test
> Suites junit-platform-runner
> ---
>
> Key: SUREFIRE-1757
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1757
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support, Maven Surefire Plugin
>Affects Versions: 2.22.0, 2.22.1, 2.22.2, 3.0.0-M2, 3.0.0-M1, 3.0.0-M3,
> 3.0.0-M4
>Reporter: Denys Galyuk
>Assignee: Tibor Digana
>Priority: Major
> Attachments: Build_Failure.png, Build_Success.png, tag.7z
>
>
> h1. {color:#00875A}plugin works with version 2.19.1 (or 2.20, or
> 2.21.0){color}
> I've attached the project archive to the bug report.
> h2. *Preconditions:*
> h3. pom.xml
> # *{color:#00875A}maven-surefire-plugin 2.19.1{color}* (or 2.20, or 2.21.0)
> # maven-compiler-plugin 3.8.1
> # junit-platform-runner 1.6.0
> # junit-jupiter-engine 5.6.0
> {code:xml}
> http://maven.apache.org/POM/4.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd;>
>4.0.0
>tag
>tag
>1.0-SNAPSHOT
>
>
>
>org.junit.jupiter
>junit-jupiter-engine
>5.6.0
>test
>
>
>
>org.junit.platform
>junit-platform-runner
>1.6.0
>test
>
>
>
>
>
>
>org.apache.maven.plugins
>maven-compiler-plugin
>3.8.1
>
>1.8
>1.8
>UTF-8
>
>
>
>
>org.apache.maven.plugins
>maven-surefire-plugin
>
>
>
>
>
>
>
>
>
>
>2.21.0
>
>
>
>
>
>
> {code}
> h3. Test class base on JUnit5: @Test,@Tag,@Tags
> {code:java}package tests.testsuites.suite1;
> import org.junit.jupiter.api.Tag;
> import org.junit.jupiter.api.Tags;
> import org.junit.jupiter.api.Test;
> import static org.junit.jupiter.api.Assertions.assertTrue;
> public class Suite2TestNameTagsTests {
>@Test
>@Tag("UAT")
>void suite2_1Test() {
>System.out.println("Suite2TestNameTagsTests:suite2_1Test(UAT tag)");
>assertTrue(true);
>}
>@Test
>@Tag("SMOKE")
>void suite2_2Test() {
>System.out.println("Suite2TestNameTagsTests:suite2_2Test(SMOKE tag)");
>assertTrue(true);
>}
>@Test
>@Tags({@Tag("SMOKE"), @Tag("UAT")})
>void suite2_3Test() {
>System.out.println("Suite2TestNameTagsTests:suite2_3Test(SMOKE and UAT
> tags)");
>assertTrue(true);
>}
> }{code}
> h3. JUnit5 Test Suite based on: @RunWith, @SelectPackages, @IncludeTags
> {code:java}package tests.suites;
> import org.junit.platform.runner.JUnitPlatform;
> import org.junit.platform.suite.api.IncludeTags;
> import org.junit.platform.suite.api.SelectPackages;
> import org.junit.runner.RunWith;
> @RunWith(JUnitPlatform.class)
> @SelectPackages("tests")
> @IncludeTags({"SMOKE","UAT"})
> public class SmokeAndUatSuiteTest {
> }{code}
> h3. Steps to reproduce: (Run the created test suite with maven)
> # Open terminal or GitBASH in the project folder
> # Run the command mvn clean test -Dtest=TestSuite
> h4. Actual Result: (something like this)
> {color:#00875A}*BUILD SUCCESS*
> *Tests run: 6, Failures: 0, Errors: 0, Skipped: 0*{color}
> {code}$ mvn clean test -Dtest=SmokeAndUatSuiteTest
> [INFO] Scanning for projects...
> [INFO]
> [INFO] --< tag:tag
> >---
> [INFO] Building tag 1.0-SNAPSHOT
> [INFO] [ jar
> ]-
> [INFO]
> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ tag ---
> [INFO] Deleting C:\Users\galyuk\IdeaProjects\tag\target
> [INFO]
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ tag ---
> [WARNING] Using platform encoding (Cp1252 actually) to copy filtered
> resources, i.e. build is platform dependent!
> [INFO] Copying 0 resource
> [INFO]
> [INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ tag ---
> [INFO] Nothing to compile - all classes are up to date
> [INFO]
> [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @
> tag ---
> [WARNING] Using platform encoding (Cp1252 actually) to copy filtered
> resources, i.e. build is platform dependent!
> [INFO] skip non existing resourceDirectory
[GitHub] [maven-resolver-ant-tasks] snoopyhzy commented on issue #2: [MRESOLVER-98] resolver ant task doesn't obey dependencyManagement
snoopyhzy commented on issue #2: [MRESOLVER-98] resolver ant task doesn't obey dependencyManagement URL: https://github.com/apache/maven-resolver-ant-tasks/pull/2#issuecomment-603256157 @lwr thank you,But I am sure it is the problem of maven-resolver-ant-tasks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MJAVADOC-645) Remind user to add Automatic-Module-Name entry when an unnamed module depends on a named module
[
https://issues.apache.org/jira/browse/MJAVADOC-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065756#comment-17065756
]
Gili commented on MJAVADOC-645:
---
I believe the issue is more involved than this. The javadoc tool expects
both ends to be named or unnamed modules and they don't seem to be willing
to improve this. The maven plugin looks for Automatic-Module-Name and uses
--patch-module to tell the Javadoc tool that the unnamed module is actually
named.
Seeing as the bridge exists in the plugin, the warning would have to be in
the plugin as well. At least that's my interpretation, Robert would know
more.
> Remind user to add Automatic-Module-Name entry when an unnamed module depends
> on a named module
> ---
>
> Key: MJAVADOC-645
> URL: https://issues.apache.org/jira/browse/MJAVADOC-645
> Project: Maven Javadoc Plugin
> Issue Type: Improvement
> Components: jar, javadoc
>Affects Versions: 3.2.0
>Reporter: Gili
>Priority: Major
> Attachments: testcase.zip
>
>
> 1. Extract testcase
> 2. Run `mvn clean package`
> 3. Build fails with:
> {code:java}
> Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.2.0:jar (attach-javadocs) on
> project module2: MavenReportException: Error while generating Javadoc:
> Exit code: 1 - javadoc: error - The code being documented uses packages in
> the unnamed module, but the packages defined in
> http://nexus.sonatype.org/oss-repository-hosting.html/root/module1/apidocs/
> are in named modules.
> Command line was: cmd.exe /X /C ""C:\Program
> Files\Java\jdk-14+36-1461\bin\javadoc.exe" @options @packages"
> Refer to the generated Javadoc files in
> 'C:\Users\Gili\Documents\3rdparty\javadoc-jar-mixing-named-and-unnamed-extending-sonatype\module2\target\apidocs'
> dir.
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MSKINS-161) Upgrade Facebook like button integration
[ https://issues.apache.org/jira/browse/MSKINS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065757#comment-17065757 ] Slawomir Jaranowski commented on MSKINS-161: I will have ready change today evening (CET). I'm waiting for review for other my changes. > Upgrade Facebook like button integration > > > Key: MSKINS-161 > URL: https://issues.apache.org/jira/browse/MSKINS-161 > Project: Maven Skins > Issue Type: Improvement > Components: Fluido Skin >Affects Versions: fluido-1.8 >Reporter: Slawomir Jaranowski >Priority: Major > Attachments: Screenshot 2020-03-22 at 10.31.29.png > > > Current Facebook integration use iframe and "Like button" is cropped. > Upgrading to newer facebook sdk can help in cropping "like button". > > We also have some configurations for "like button" > - action type like or recommend > - share button visibility > - layout > - button size > - ... > some of those should have possibility to configured by site.xml > [https://developers.facebook.com/docs/plugins/like-button/] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSKINS-160) Broken links to JIRA
[ https://issues.apache.org/jira/browse/MSKINS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065551#comment-17065551 ] Hudson commented on MSKINS-160: --- Build succeeded in Jenkins: Maven TLP » maven-fluido-skin » master #42 See https://builds.apache.org/job/maven-box/job/maven-fluido-skin/job/master/42/ > Broken links to JIRA > > > Key: MSKINS-160 > URL: https://issues.apache.org/jira/browse/MSKINS-160 > Project: Maven Skins > Issue Type: Improvement > Components: Default Skin, Fluido Skin >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Minor > Fix For: fluido-1.9, default-1.4 > > > In projects issueManagement tag - points to jira project with component, like: > https://issues.apache.org/jira/browse/MSKINS/component/12326472 > But now this is broken - 404 > Some localizations: > [https://maven.apache.org/skins/maven-default-skin/issue-management.html] > [https://maven.apache.org/skins/maven-fluido-skin/issue-tracking.html] > [https://maven.apache.org/skins/index.html] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSKINS-160) Broken links to JIRA
[ https://issues.apache.org/jira/browse/MSKINS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065550#comment-17065550 ] Hudson commented on MSKINS-160: --- Build succeeded in Jenkins: Maven TLP » maven-default-skin » master #32 See https://builds.apache.org/job/maven-box/job/maven-default-skin/job/master/32/ > Broken links to JIRA > > > Key: MSKINS-160 > URL: https://issues.apache.org/jira/browse/MSKINS-160 > Project: Maven Skins > Issue Type: Improvement > Components: Default Skin, Fluido Skin >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Minor > Fix For: fluido-1.9, default-1.4 > > > In projects issueManagement tag - points to jira project with component, like: > https://issues.apache.org/jira/browse/MSKINS/component/12326472 > But now this is broken - 404 > Some localizations: > [https://maven.apache.org/skins/maven-default-skin/issue-management.html] > [https://maven.apache.org/skins/maven-fluido-skin/issue-tracking.html] > [https://maven.apache.org/skins/index.html] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (MSKINS-160) Broken links to JIRA
[ https://issues.apache.org/jira/browse/MSKINS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSKINS-160. - Resolution: Fixed > Broken links to JIRA > > > Key: MSKINS-160 > URL: https://issues.apache.org/jira/browse/MSKINS-160 > Project: Maven Skins > Issue Type: Improvement > Components: Default Skin, Fluido Skin >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Minor > Fix For: fluido-1.9, default-1.4 > > > In projects issueManagement tag - points to jira project with component, like: > https://issues.apache.org/jira/browse/MSKINS/component/12326472 > But now this is broken - 404 > Some localizations: > [https://maven.apache.org/skins/maven-default-skin/issue-management.html] > [https://maven.apache.org/skins/maven-fluido-skin/issue-tracking.html] > [https://maven.apache.org/skins/index.html] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MSKINS-160) Broken links to JIRA
[ https://issues.apache.org/jira/browse/MSKINS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSKINS-160: -- Fix Version/s: default-1.4 > Broken links to JIRA > > > Key: MSKINS-160 > URL: https://issues.apache.org/jira/browse/MSKINS-160 > Project: Maven Skins > Issue Type: Improvement > Components: Default Skin, Fluido Skin >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Minor > Fix For: fluido-1.9, default-1.4 > > > In projects issueManagement tag - points to jira project with component, like: > https://issues.apache.org/jira/browse/MSKINS/component/12326472 > But now this is broken - 404 > Some localizations: > [https://maven.apache.org/skins/maven-default-skin/issue-management.html] > [https://maven.apache.org/skins/maven-fluido-skin/issue-tracking.html] > [https://maven.apache.org/skins/index.html] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MSKINS-163) Upgrade to parent POM 34
[ https://issues.apache.org/jira/browse/MSKINS-163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSKINS-163: -- Summary: Upgrade to parent POM 34 (was: Upgrade parent pom 30 -> 34) > Upgrade to parent POM 34 > > > Key: MSKINS-163 > URL: https://issues.apache.org/jira/browse/MSKINS-163 > Project: Maven Skins > Issue Type: Dependency upgrade > Components: Fluido Skin >Affects Versions: fluido-1.8 >Reporter: Slawomir Jaranowski >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (MSKINS-163) Upgrade to parent POM 34
[ https://issues.apache.org/jira/browse/MSKINS-163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MSKINS-163: - Assignee: Michael Osipov > Upgrade to parent POM 34 > > > Key: MSKINS-163 > URL: https://issues.apache.org/jira/browse/MSKINS-163 > Project: Maven Skins > Issue Type: Dependency upgrade > Components: Fluido Skin >Affects Versions: fluido-1.8 >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MSKINS-163) Upgrade to parent POM 34
[ https://issues.apache.org/jira/browse/MSKINS-163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSKINS-163: -- Fix Version/s: fluido-1.9 > Upgrade to parent POM 34 > > > Key: MSKINS-163 > URL: https://issues.apache.org/jira/browse/MSKINS-163 > Project: Maven Skins > Issue Type: Dependency upgrade > Components: Fluido Skin >Affects Versions: fluido-1.8 >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Major > Fix For: fluido-1.9 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SUREFIRE-1528) org.apache.maven.surefire.booter.SurefireBooterForkException with maven-surefire-plugin 2.22 with jdk 10.0.1
[
https://issues.apache.org/jira/browse/SUREFIRE-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana closed SUREFIRE-1528.
--
Assignee: Tibor Digana
Resolution: Duplicate
This seems to be a duplicate of SUREFIRE-1757.
> org.apache.maven.surefire.booter.SurefireBooterForkException with
> maven-surefire-plugin 2.22 with jdk 10.0.1
>
>
> Key: SUREFIRE-1528
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1528
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support, Maven Surefire Plugin
>Affects Versions: 2.22.0
> Environment: ubuntu 18.04, openjdk 10.0.1
>Reporter: Christian Bonzelet
>Assignee: Tibor Digana
>Priority: Major
>
> h1. Overview
> Using JUnit 5.2.0
> I build a small sample project to evaluate JDK 10 with maven. Unfortunately i
> am running in several errors with the `maven-surefire-plugin`.
> Here my sample `pom.xml`
> {code:xml}
>
> http://maven.apache.org/POM/4.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd;>
> 4.0.0
> de.onkelpixel.sample-project
> core
> 3.0.0-SNAPSHOT
> jar
> sample-project-core
>
> UTF-8
> UTF-8
> 10
> 10
> 5.2.0
> 6.2
>
>
>
> com.fasterxml.jackson.core
> jackson-databind
> test
> 2.9.4
>
>
> org.projectlombok
> lombok
> 1.18.0
> true
>
>
> org.junit.jupiter
> junit-jupiter-api
> ${junit.jupiter.version}
> test
>
>
>
>
>
> maven-surefire-plugin
> 2.22.0
>
>
> maven-jar-plugin
> 3.1.0
>
>
> org.apache.maven.plugins
> maven-compiler-plugin
> 3.7.0
>
> ${maven.compiler.source}
> ${maven.compiler.target}
>
>
>
> org.ow2.asm
> asm
> ${asm.version}
>
>
>
>
>
>
> org.springframework.build
> aws-maven
> 5.0.0.RELEASE
>
>
>
>
> {code}
> And here is the error after executing `mvn test -e`
> {code:java}
> [INFO] Error stacktraces are turned on.
> [INFO] Scanning for projects...
> [INFO]
> [INFO] < de.onkelpixel.sample-project:core
> >-
> [INFO] Building sample-project-core 3.0.0-SNAPSHOT
> [INFO] [ jar
> ]-
> [INFO]
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ core ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 0 resource
> [INFO]
> [INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @ core ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 11 source files to
> /media/christian/data/workspace/onkelpixel/sample-project/core/target/classes
> [INFO]
> [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @
> core ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] skip non existing resourceDirectory
> /media/christian/data/workspace/onkelpixel/sample-project/core/src/test/resources
> [INFO]
> [INFO] --- maven-compiler-plugin:3.7.0:testCompile (default-testCompile) @
> core ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 3 source files to
> /media/christian/data/workspace/onkelpixel/sample-project/core/target/test-classes
> [INFO]
> [INFO] --- maven-surefire-plugin:2.22.0:test (default-test) @ core ---
> [INFO] Surefire report directory:
> /media/christian/data/workspace/onkelpixel/sample-project/core/target/surefire-reports
> [INFO]
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [WARNING] Corrupted STDOUT by directly writing to native stream in forked JVM
> 1. See FAQ web page and the dump file
> /media/christian/data/workspace/onkelpixel/sample-project/core/target/surefire-reports/2018-06-24T21-07-32_966-jvmRun1.dumpstream
> [INFO]
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 1.886 s
> [INFO] Finished at: 2018-06-24T21:07:33+02:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.22.0:test (default-test) on
> project core: There are test failures.
> [ERROR]
> [ERROR] Please refer to
> /media/christian/data/workspace/onkelpixel/sample-project/core/target/surefire-reports
> for the individual test results.
> [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> [ERROR] The
[jira] [Updated] (SUREFIRE-1757) maven-surefire-plugin versions starting from 2.22.0 do not run JUnit5 Test Suites junit-platform-runner
[
https://issues.apache.org/jira/browse/SUREFIRE-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1757:
---
Fix Version/s: 3.0.0-M5
> maven-surefire-plugin versions starting from 2.22.0 do not run JUnit5 Test
> Suites junit-platform-runner
> ---
>
> Key: SUREFIRE-1757
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1757
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support, Maven Surefire Plugin
>Affects Versions: 2.22.0, 2.22.1, 2.22.2, 3.0.0-M2, 3.0.0-M1, 3.0.0-M3,
> 3.0.0-M4
>Reporter: Denys Galyuk
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M5
>
> Attachments: Build_Failure.png, Build_Success.png, tag.7z
>
>
> h1. {color:#00875A}plugin works with version 2.19.1 (or 2.20, or
> 2.21.0){color}
> I've attached the project archive to the bug report.
> h2. *Preconditions:*
> h3. pom.xml
> # *{color:#00875A}maven-surefire-plugin 2.19.1{color}* (or 2.20, or 2.21.0)
> # maven-compiler-plugin 3.8.1
> # junit-platform-runner 1.6.0
> # junit-jupiter-engine 5.6.0
> {code:xml}
> http://maven.apache.org/POM/4.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd;>
>4.0.0
>tag
>tag
>1.0-SNAPSHOT
>
>
>
>org.junit.jupiter
>junit-jupiter-engine
>5.6.0
>test
>
>
>
>org.junit.platform
>junit-platform-runner
>1.6.0
>test
>
>
>
>
>
>
>org.apache.maven.plugins
>maven-compiler-plugin
>3.8.1
>
>1.8
>1.8
>UTF-8
>
>
>
>
>org.apache.maven.plugins
>maven-surefire-plugin
>
>
>
>
>
>
>
>
>
>
>2.21.0
>
>
>
>
>
>
> {code}
> h3. Test class base on JUnit5: @Test,@Tag,@Tags
> {code:java}package tests.testsuites.suite1;
> import org.junit.jupiter.api.Tag;
> import org.junit.jupiter.api.Tags;
> import org.junit.jupiter.api.Test;
> import static org.junit.jupiter.api.Assertions.assertTrue;
> public class Suite2TestNameTagsTests {
>@Test
>@Tag("UAT")
>void suite2_1Test() {
>System.out.println("Suite2TestNameTagsTests:suite2_1Test(UAT tag)");
>assertTrue(true);
>}
>@Test
>@Tag("SMOKE")
>void suite2_2Test() {
>System.out.println("Suite2TestNameTagsTests:suite2_2Test(SMOKE tag)");
>assertTrue(true);
>}
>@Test
>@Tags({@Tag("SMOKE"), @Tag("UAT")})
>void suite2_3Test() {
>System.out.println("Suite2TestNameTagsTests:suite2_3Test(SMOKE and UAT
> tags)");
>assertTrue(true);
>}
> }{code}
> h3. JUnit5 Test Suite based on: @RunWith, @SelectPackages, @IncludeTags
> {code:java}package tests.suites;
> import org.junit.platform.runner.JUnitPlatform;
> import org.junit.platform.suite.api.IncludeTags;
> import org.junit.platform.suite.api.SelectPackages;
> import org.junit.runner.RunWith;
> @RunWith(JUnitPlatform.class)
> @SelectPackages("tests")
> @IncludeTags({"SMOKE","UAT"})
> public class SmokeAndUatSuiteTest {
> }{code}
> h3. Steps to reproduce: (Run the created test suite with maven)
> # Open terminal or GitBASH in the project folder
> # Run the command mvn clean test -Dtest=TestSuite
> h4. Actual Result: (something like this)
> {color:#00875A}*BUILD SUCCESS*
> *Tests run: 6, Failures: 0, Errors: 0, Skipped: 0*{color}
> {code}$ mvn clean test -Dtest=SmokeAndUatSuiteTest
> [INFO] Scanning for projects...
> [INFO]
> [INFO] --< tag:tag
> >---
> [INFO] Building tag 1.0-SNAPSHOT
> [INFO] [ jar
> ]-
> [INFO]
> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ tag ---
> [INFO] Deleting C:\Users\galyuk\IdeaProjects\tag\target
> [INFO]
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ tag ---
> [WARNING] Using platform encoding (Cp1252 actually) to copy filtered
> resources, i.e. build is platform dependent!
> [INFO] Copying 0 resource
> [INFO]
> [INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ tag ---
> [INFO] Nothing to compile - all classes are up to date
> [INFO]
> [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @
> tag ---
> [WARNING] Using platform encoding (Cp1252 actually) to copy filtered
> resources, i.e. build is
[jira] [Created] (MNG-6879) When the repo with the id of central is configured in settings.xml and the scope = import dependency is included in the project of the project, the central repo has a probl
wuzishu created MNG-6879:
Summary: When the repo with the id of central is configured in
settings.xml and the scope = import dependency is included in the project of
the project, the central repo has a problem
Key: MNG-6879
URL: https://issues.apache.org/jira/browse/MNG-6879
Project: Maven
Issue Type: Bug
Components: Artifacts and Repositories
Affects Versions: 3.6.2
Environment: Mac,maven 3.6.2
Reporter: wuzishu
Attachments: image-2020-03-24-21-39-54-127.png,
image-2020-03-24-21-47-50-561.png, image-2020-03-24-21-49-31-997.png,
image-2020-03-24-21-57-58-635.png, image-2020-03-24-21-58-35-400.png,
image-2020-03-24-22-00-08-867.png, image-2020-03-24-22-01-04-185.png
When the repo with the id of central is configured in settings.xml and the
scope = import dependency is included in the project of the project, the
central repo has a problem
*settings.xml配置如下*:
{code:java}
nexusRep
nexus
Nexus Repository
https://repo.spring.io/libs-release1
true
true
nexus
Nexus pluginRepository
https://repo.spring.io/libs-release1
true
true
central
central
Nexus Repository
https://repo.spring.io/libs-release
true
true
central
Nexus pluginRepository
https://repo.spring.io/libs-release
true
true
nexusRep
central
{code}
*project pom.xml:*
{code:java}
//代码占位符
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
https://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
org.springframework.boot
spring-boot-starter-parent
2.2.5.RELEASE
com.example
demo
0.0.1-SNAPSHOT
demo
Demo project for Spring Boot
1.8
Angel.SR6
org.springframework.boot
spring-boot-starter-web
org.springframework.cloud
spring-cloud-dependencies
${spring-cloud-dependencies.version}
pom
import
org.projectlombok
lombok
compile
true
org.springframework.boot
spring-boot-starter-test
test
org.junit.vintage
junit-vintage-engine
org.springframework.boot
spring-boot-maven-plugin
test
repo
true
true
https://repo.spring.io/libs-release
{code}
The theoretical maven remote repository priority is:
!image-2020-03-24-21-47-50-561.png|width=412,height=237!
However, when resolving a scope = import dependency, such as:
!image-2020-03-24-21-49-31-997.png|width=705,height=185!
The warehouse priority will become as shown in the figure below:
!image-2020-03-24-21-39-54-127.png|width=712,height=379!
Found that the central repository was reset to the default, and all dependent
downloads will become this repo priority in the future.
When resolving scope = import dependencies, this place will cause the resolving
repo to become the default central:
!image-2020-03-24-21-58-35-400.png|width=663,height=194!
!image-2020-03-24-21-57-58-635.png|width=1091,height=538!
Finally at this place, the default modelResoler repo will be replaced with the
default central:
!image-2020-03-24-22-00-08-867.png|width=912,height=194!
!image-2020-03-24-22-01-04-185.png|width=685,height=324!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (MSKINS-164) Upgrade to Maven Invoker Plugin 3.2.1
[ https://issues.apache.org/jira/browse/MSKINS-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MSKINS-164: - Assignee: Michael Osipov > Upgrade to Maven Invoker Plugin 3.2.1 > - > > Key: MSKINS-164 > URL: https://issues.apache.org/jira/browse/MSKINS-164 > Project: Maven Skins > Issue Type: Dependency upgrade > Components: Fluido Skin >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MSKINS-164) Upgrade to Maven Invoker Plugin 3.2.1
[ https://issues.apache.org/jira/browse/MSKINS-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSKINS-164: -- Summary: Upgrade to Maven Invoker Plugin 3.2.1 (was: Upgrade maven-invoker-plugin 1.10 -> 3.2.1) > Upgrade to Maven Invoker Plugin 3.2.1 > - > > Key: MSKINS-164 > URL: https://issues.apache.org/jira/browse/MSKINS-164 > Project: Maven Skins > Issue Type: Dependency upgrade > Components: Fluido Skin >Reporter: Slawomir Jaranowski >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MSKINS-164) Upgrade to Maven Invoker Plugin 3.2.1
[ https://issues.apache.org/jira/browse/MSKINS-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSKINS-164: -- Fix Version/s: fluido-1.9 > Upgrade to Maven Invoker Plugin 3.2.1 > - > > Key: MSKINS-164 > URL: https://issues.apache.org/jira/browse/MSKINS-164 > Project: Maven Skins > Issue Type: Dependency upgrade > Components: Fluido Skin >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Major > Fix For: fluido-1.9 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (MSKINS-164) Upgrade to Maven Invoker Plugin 3.2.1
[ https://issues.apache.org/jira/browse/MSKINS-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSKINS-164. - Resolution: Fixed > Upgrade to Maven Invoker Plugin 3.2.1 > - > > Key: MSKINS-164 > URL: https://issues.apache.org/jira/browse/MSKINS-164 > Project: Maven Skins > Issue Type: Dependency upgrade > Components: Fluido Skin >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Major > Fix For: fluido-1.9 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (MSKINS-163) Upgrade to parent POM 34
[ https://issues.apache.org/jira/browse/MSKINS-163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSKINS-163. - Resolution: Fixed Fixed with [1c13ff357c12f07100b8b29e17fe8ab6dbd6c58e|https://gitbox.apache.org/repos/asf?p=maven-fluido-skin.git=commit=1c13ff357c12f07100b8b29e17fe8ab6dbd6c58e]. > Upgrade to parent POM 34 > > > Key: MSKINS-163 > URL: https://issues.apache.org/jira/browse/MSKINS-163 > Project: Maven Skins > Issue Type: Dependency upgrade > Components: Fluido Skin >Affects Versions: fluido-1.8 >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Major > Fix For: fluido-1.9 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSKINS-163) Upgrade to parent POM 34
[ https://issues.apache.org/jira/browse/MSKINS-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065847#comment-17065847 ] Hudson commented on MSKINS-163: --- Build succeeded in Jenkins: Maven TLP » maven-fluido-skin » master #43 See https://builds.apache.org/job/maven-box/job/maven-fluido-skin/job/master/43/ > Upgrade to parent POM 34 > > > Key: MSKINS-163 > URL: https://issues.apache.org/jira/browse/MSKINS-163 > Project: Maven Skins > Issue Type: Dependency upgrade > Components: Fluido Skin >Affects Versions: fluido-1.8 >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Major > Fix For: fluido-1.9 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSKINS-164) Upgrade to Maven Invoker Plugin 3.2.1
[ https://issues.apache.org/jira/browse/MSKINS-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065936#comment-17065936 ] Slawomir Jaranowski commented on MSKINS-164: Hi [~michael-o] I can't see change for it in https://github.com/apache/maven-fluido-skin/commit/1c13ff357c12f07100b8b29e17fe8ab6dbd6c58e And PR is still open. > Upgrade to Maven Invoker Plugin 3.2.1 > - > > Key: MSKINS-164 > URL: https://issues.apache.org/jira/browse/MSKINS-164 > Project: Maven Skins > Issue Type: Dependency upgrade > Components: Fluido Skin >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Major > Fix For: fluido-1.9 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSKINS-161) Upgrade Facebook like button integration
[
https://issues.apache.org/jira/browse/MSKINS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065958#comment-17065958
]
Slawomir Jaranowski commented on MSKINS-161:
What do you think about replace maven-resources-plugin by maven-assembly-plugin
for copying it tests results to site.
Instead of:
{code}
copy-sidebar
site
copy-resources
${project.build.directory}/it/sidebar/target/site/
${project.build.directory}/site/sidebar/
{code}
in pom.xml we can have (something like) in assembly.xml:
{code}
${project.build.directory}/it/sidebar/target/site/
${project.build.directory}/site/sidebar/
{code}
It will be more readable and easier to maintenance.
> Upgrade Facebook like button integration
>
>
> Key: MSKINS-161
> URL: https://issues.apache.org/jira/browse/MSKINS-161
> Project: Maven Skins
> Issue Type: Improvement
> Components: Fluido Skin
>Affects Versions: fluido-1.8
>Reporter: Slawomir Jaranowski
>Priority: Major
> Attachments: Screenshot 2020-03-22 at 10.31.29.png
>
>
> Current Facebook integration use iframe and "Like button" is cropped.
> Upgrading to newer facebook sdk can help in cropping "like button".
>
> We also have some configurations for "like button"
> - action type like or recommend
> - share button visibility
> - layout
> - button size
> - ...
> some of those should have possibility to configured by site.xml
> [https://developers.facebook.com/docs/plugins/like-button/]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-resolver-ant-tasks] lwr commented on issue #2: [MRESOLVER-98] resolver ant task doesn't obey dependencyManagement
lwr commented on issue #2: [MRESOLVER-98] resolver ant task doesn't obey dependencyManagement URL: https://github.com/apache/maven-resolver-ant-tasks/pull/2#issuecomment-603371433 @snoopyhzy it is problem of retired project maven-ant-tasks not this new project maven-resolver-ant-tasks, they are different and this project is the replacement of the retired one This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MSKINS-163) Upgrade to parent POM 34
[
https://issues.apache.org/jira/browse/MSKINS-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065971#comment-17065971
]
Slawomir Jaranowski commented on MSKINS-163:
Why do you have parent defined as below in it-tests project (not in all - some
projects haven't got parent):
{code:java}
org.apache.maven
maven-parent
@project.parent.version@
{code}
@project.parent.version@ is taken from project which has:
{code:java}
org.apache.maven.skins
maven-skins
34
../../pom/maven/maven-skins/pom.xml
{code}
Generally those are different artifacts and can have different version.
I see that both are build from one project where maven-skins is module.
> Upgrade to parent POM 34
>
>
> Key: MSKINS-163
> URL: https://issues.apache.org/jira/browse/MSKINS-163
> Project: Maven Skins
> Issue Type: Dependency upgrade
> Components: Fluido Skin
>Affects Versions: fluido-1.8
>Reporter: Slawomir Jaranowski
>Assignee: Michael Osipov
>Priority: Major
> Fix For: fluido-1.9
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MSKINS-163) Upgrade to parent POM 34
[
https://issues.apache.org/jira/browse/MSKINS-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065979#comment-17065979
]
Slawomir Jaranowski commented on MSKINS-163:
Next question why you preserve non existing options
{{dependencyLocationsEnabled}} for {{maven-project-info-reports-plugin}} in it
tests.
My IDE mark this as error ... after parent upgrade.
https://issues.apache.org/jira/browse/MPIR-367
> Upgrade to parent POM 34
>
>
> Key: MSKINS-163
> URL: https://issues.apache.org/jira/browse/MSKINS-163
> Project: Maven Skins
> Issue Type: Dependency upgrade
> Components: Fluido Skin
>Affects Versions: fluido-1.8
>Reporter: Slawomir Jaranowski
>Assignee: Michael Osipov
>Priority: Major
> Fix For: fluido-1.9
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-resolver-ant-tasks] snoopyhzy commented on issue #2: [MRESOLVER-98] resolver ant task doesn't obey dependencyManagement
snoopyhzy commented on issue #2: [MRESOLVER-98] resolver ant task doesn't obey dependencyManagement URL: https://github.com/apache/maven-resolver-ant-tasks/pull/2#issuecomment-603385455 @lwr the new one has two other problem that I find. One is it download error version of dependencies. for example,I use springboot test and set mockito version in properties.The version download different with use mvn copy-dependencies and the ant plugin. Another is it do not support Snapshot version with timestamp and serialno This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (MSHARED-868) Upgrade plexus-component-metadata to 2.1.0
Karl Heinz Marbaise created MSHARED-868: --- Summary: Upgrade plexus-component-metadata to 2.1.0 Key: MSHARED-868 URL: https://issues.apache.org/jira/browse/MSHARED-868 Project: Maven Shared Components Issue Type: Dependency upgrade Components: maven-dependency-analyzer Affects Versions: maven-dependency-analyzer-1.11.1 Reporter: Karl Heinz Marbaise Assignee: Karl Heinz Marbaise Fix For: maven-dependency-analyzer-1.11.2 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (MSHARED-868) Upgrade plexus-component-metadata to 2.1.0
[ https://issues.apache.org/jira/browse/MSHARED-868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MSHARED-868. --- Resolution: Done > Upgrade plexus-component-metadata to 2.1.0 > -- > > Key: MSHARED-868 > URL: https://issues.apache.org/jira/browse/MSHARED-868 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-dependency-analyzer >Affects Versions: maven-dependency-analyzer-1.11.1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-dependency-analyzer-1.11.2 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSHARED-868) Upgrade plexus-component-metadata to 2.1.0
[ https://issues.apache.org/jira/browse/MSHARED-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066024#comment-17066024 ] Karl Heinz Marbaise commented on MSHARED-868: - Done in [6c657f8a1b06b561d32a7b8178c6cf41004cd92b|https://gitbox.apache.org/repos/asf?p=maven-dependency-analyzer.git;a=commitdiff;h=6c657f8a1b06b561d32a7b8178c6cf41004cd92b] > Upgrade plexus-component-metadata to 2.1.0 > -- > > Key: MSHARED-868 > URL: https://issues.apache.org/jira/browse/MSHARED-868 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-dependency-analyzer >Affects Versions: maven-dependency-analyzer-1.11.1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-dependency-analyzer-1.11.2 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSHARED-868) Upgrade plexus-component-metadata to 2.1.0
[ https://issues.apache.org/jira/browse/MSHARED-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066038#comment-17066038 ] Hudson commented on MSHARED-868: Build succeeded in Jenkins: Maven TLP » maven-dependency-analyzer » master #34 See https://builds.apache.org/job/maven-box/job/maven-dependency-analyzer/job/master/34/ > Upgrade plexus-component-metadata to 2.1.0 > -- > > Key: MSHARED-868 > URL: https://issues.apache.org/jira/browse/MSHARED-868 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-dependency-analyzer >Affects Versions: maven-dependency-analyzer-1.11.1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-dependency-analyzer-1.11.2 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MSKINS-165) Inconsistent parent pom in IT tests.
Slawomir Jaranowski created MSKINS-165:
--
Summary: Inconsistent parent pom in IT tests.
Key: MSKINS-165
URL: https://issues.apache.org/jira/browse/MSKINS-165
Project: Maven Skins
Issue Type: Improvement
Components: Fluido Skin
Reporter: Slawomir Jaranowski
Why do you have parent defined as below in it-tests project (not in all - some
projects haven't got parent):
{code:java}
org.apache.maven
maven-parent
@project.parent.version@
{code}
@project.parent.version@ is taken from project which has:
{code:java}
org.apache.maven.skins
maven-skins
34
../../pom/maven/maven-skins/pom.xml
{code}
Generally those are different artifacts and can have different version.
I see that both are build from one project where maven-skins is module.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-shade-plugin] rfscholte commented on a change in pull request #39: [MSHADE-353] adding a generic relocation friendly transformer
rfscholte commented on a change in pull request #39: [MSHADE-353] adding a
generic relocation friendly transformer
URL: https://github.com/apache/maven-shade-plugin/pull/39#discussion_r397480229
##
File path: src/site/apt/examples/resource-transformers.apt.vm
##
@@ -601,6 +603,45 @@ Transformers in
<<>>
+-
+* Relocating file content with {RelocationTransformer}
+
+ The <<>> allows to apply relocators before delegating
the processing to other transformers.
+
++-
+
+ ...
+
+
+
+org.apache.maven.plugins
+maven-shade-plugin
+${project.version}
+
+
+
+ shade
+
+
+
+
Review comment:
Maybe I'm missing an important detail, but in this example is no relocation.
So why do it like this?
And I would have expected that defining both transformers after each other
would work, but that requires defining the resource twice. That's probably the
thing you're trying to solve.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (MDEP-677) Suggest BOM updates
[
https://issues.apache.org/jira/browse/MDEP-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066136#comment-17066136
]
Karl Heinz Marbaise commented on MDEP-677:
--
This report belong to https://github.com/mojohaus/versions-maven-plugin
> Suggest BOM updates
> ---
>
> Key: MDEP-677
> URL: https://issues.apache.org/jira/browse/MDEP-677
> Project: Maven Dependency Plugin
> Issue Type: Improvement
>Reporter: Elliotte Rusty Harold
>Priority: Major
>
> mvn versions:display-dependency-updates
>
> only suggests updates for dependencies in the dependencies and
> dependencyManagement sections. It does not suggest updates for BOMs imported
> by the dependencyManagement section. It should.
>
> E.g. when scanning this:
>
> {\{ }}
> \{{ }}
> \{{ }}
> \{{ com.google.cloud}}
> \{{ libraries-bom}}
> \{{ 4.1.0}}
> \{{ pom}}
> \{{ import}}
> \{{ }}
> \{{ }}
> \{{ }}
> It should suggest updating libraries-bom to 4.1.1.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-fluido-skin] slawekjaranowski opened a new pull request #15: [MSKINS-161] Upgrade Facebook like button integration
slawekjaranowski opened a new pull request #15: [MSKINS-161] Upgrade Facebook like button integration URL: https://github.com/apache/maven-fluido-skin/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-fluido-skin] michael-o commented on a change in pull request #15: [MSKINS-161] Upgrade Facebook like button integration
michael-o commented on a change in pull request #15: [MSKINS-161] Upgrade Facebook like button integration URL: https://github.com/apache/maven-fluido-skin/pull/15#discussion_r397451792 ## File path: src/main/resources/META-INF/maven/site-macros.vm ## @@ -678,11 +682,11 @@ $indent ## #* *##if ( $sideBarEnabled ) #**##set( $dataSize = "medium" ) #**##set( $dataAlign = "left" ) - + #* *##else #**##set( $dataSize = "large" ) #**##set( $dataAlign = "right" ) - + Review comment: Why did you modify these? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MJAVADOC-645) Remind user to add Automatic-Module-Name entry when an unnamed module depends on a named module
[
https://issues.apache.org/jira/browse/MJAVADOC-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066174#comment-17066174
]
Robert Scholte commented on MJAVADOC-645:
-
Based on the {{module2/target/apidocs/options}} I don't see anything weird: it
doesn't mention the module path nor other module system related arguments.
The stupid thing is that the pages are generated. IIRC I discussed this on the
javadoc dev list, but I can't find any related issue labelled with
"apache-maven-found" or "apache-maven-interest" (
https://bugs.openjdk.java.net/issues?jql=labels%20%3D%20apache-maven-found /
https://bugs.openjdk.java.net/issues?jql=labels%20%3D%20apache-maven-interest )
The fact that there's an error (breaking the build) AND that the pages are
generated is just not good and IMO should be fixed in the javadoc tool.
The error message is slightly different compared to
https://bugs.openjdk.java.net/browse/JDK-8235202 and
https://bugs.openjdk.java.net/browse/JDK-8212233
> Remind user to add Automatic-Module-Name entry when an unnamed module depends
> on a named module
> ---
>
> Key: MJAVADOC-645
> URL: https://issues.apache.org/jira/browse/MJAVADOC-645
> Project: Maven Javadoc Plugin
> Issue Type: Improvement
> Components: jar, javadoc
>Affects Versions: 3.2.0
>Reporter: Gili
>Priority: Major
> Attachments: testcase.zip
>
>
> 1. Extract testcase
> 2. Run `mvn clean package`
> 3. Build fails with:
> {code:java}
> Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.2.0:jar (attach-javadocs) on
> project module2: MavenReportException: Error while generating Javadoc:
> Exit code: 1 - javadoc: error - The code being documented uses packages in
> the unnamed module, but the packages defined in
> http://nexus.sonatype.org/oss-repository-hosting.html/root/module1/apidocs/
> are in named modules.
> Command line was: cmd.exe /X /C ""C:\Program
> Files\Java\jdk-14+36-1461\bin\javadoc.exe" @options @packages"
> Refer to the generated Javadoc files in
> 'C:\Users\Gili\Documents\3rdparty\javadoc-jar-mixing-named-and-unnamed-extending-sonatype\module2\target\apidocs'
> dir.
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6879) When the repo with the id of central is configured in settings.xml and the scope = import dependency is included in the project of the project, the central repo has a pro
[
https://issues.apache.org/jira/browse/MNG-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066180#comment-17066180
]
Robert Scholte commented on MNG-6879:
-
If you want to reroute central, you should use a mirror, see
https://maven.apache.org/guides/mini/guide-mirror-settings.html
Let me know if this solves the problem.
> When the repo with the id of central is configured in settings.xml and the
> scope = import dependency is included in the project of the project, the
> central repo has a problem
> --
>
> Key: MNG-6879
> URL: https://issues.apache.org/jira/browse/MNG-6879
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories
>Affects Versions: 3.6.2
> Environment: Mac,maven 3.6.2
>Reporter: wuzishu
>Priority: Major
> Attachments: image-2020-03-24-21-39-54-127.png,
> image-2020-03-24-21-47-50-561.png, image-2020-03-24-21-49-31-997.png,
> image-2020-03-24-21-57-58-635.png, image-2020-03-24-21-58-35-400.png,
> image-2020-03-24-22-00-08-867.png, image-2020-03-24-22-01-04-185.png
>
>
> When the repo with the id of central is configured in settings.xml and the
> scope = import dependency is included in the project of the project, the
> central repo has a problem
>
> *settings.xml配置如下*:
> {code:java}
>
> nexusRep
>
>
> nexus
> Nexus Repository
> https://repo.spring.io/libs-release1
> true
> true
>
>
>
>
> nexus
> Nexus pluginRepository
> https://repo.spring.io/libs-release1
> true
> true
>
>
>
>
> central
>
>
> central
> Nexus Repository
> https://repo.spring.io/libs-release
> true
> true
>
>
>
>
> central
> Nexus pluginRepository
> https://repo.spring.io/libs-release
> true
> true
>
>
>
>
>
>
>
>nexusRep
>central
>
> {code}
>
> *project pom.xml:*
> {code:java}
> //代码占位符
>
> http://maven.apache.org/POM/4.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> https://maven.apache.org/xsd/maven-4.0.0.xsd;>
> 4.0.0
>
> org.springframework.boot
> spring-boot-starter-parent
> 2.2.5.RELEASE
>
>
> com.example
> demo
> 0.0.1-SNAPSHOT
> demo
> Demo project for Spring Boot
>
> 1.8
>
> Angel.SR6
>
>
>
> org.springframework.boot
> spring-boot-starter-web
>
>
> org.springframework.cloud
> spring-cloud-dependencies
> ${spring-cloud-dependencies.version}
> pom
> import
>
>
> org.projectlombok
> lombok
> compile
> true
>
>
> org.springframework.boot
> spring-boot-starter-test
> test
>
>
> org.junit.vintage
> junit-vintage-engine
>
>
>
>
>
>
>
> org.springframework.boot
> spring-boot-maven-plugin
>
>
>
>
>
> test
> repo
>
> true
>
>
> true
>
> https://repo.spring.io/libs-release
>
>
>
> {code}
> The theoretical maven remote repository priority is:
> !image-2020-03-24-21-47-50-561.png|width=412,height=237!
> However, when resolving a scope = import dependency, such as:
> !image-2020-03-24-21-49-31-997.png|width=705,height=185!
> The warehouse priority will become as shown in the figure below:
> !image-2020-03-24-21-39-54-127.png|width=712,height=379!
> Found that the central repository was reset to the default, and all
> dependent downloads will become this repo priority in the future.
> When resolving scope =
[GitHub] [maven-fluido-skin] slawekjaranowski commented on a change in pull request #15: [MSKINS-161] Upgrade Facebook like button integration
slawekjaranowski commented on a change in pull request #15: [MSKINS-161] Upgrade Facebook like button integration URL: https://github.com/apache/maven-fluido-skin/pull/15#discussion_r397476454 ## File path: src/main/resources/META-INF/maven/site-macros.vm ## @@ -678,11 +682,11 @@ $indent ## #* *##if ( $sideBarEnabled ) #**##set( $dataSize = "medium" ) #**##set( $dataAlign = "left" ) - + #* *##else #**##set( $dataSize = "large" ) #**##set( $dataAlign = "right" ) - + Review comment: Because Twitter button was start from top without margin. Google search and facebook has some margin from top. It didn't look good. You can see original. eg: https://maven.apache.org/skins/maven-fluido-skin/mskins-24_topbar/index.html This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MJAVADOC-614) "No source files for package" in a directory with accent characters
[
https://issues.apache.org/jira/browse/MJAVADOC-614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066195#comment-17066195
]
Michael Miller commented on MJAVADOC-614:
-
I am seeing the same error but for a different reason. We have a Java 11
project with automatic module names that fails at a package-info.java with no
files. This is also with 3.2.0
```
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-javadoc-plugin:3.2.0:jar (default-cli) on
project accumulo-core: MavenReportException: Error while generating Javadoc:
[ERROR] Exit code: 2 - javadoc: error - No source files for package
org.apache.accumulo.core.spi
[ERROR]
[ERROR] Command line was: /usr/local/lib/jvm/openjdk11/bin/javadoc -J-Xmx512m
@options @packages
[ERROR]
[ERROR] Refer to the generated Javadoc files in
'/home/travis/build/apache/accumulo/core/target/apidocs' dir.
```
https://github.com/apache/accumulo/pull/1438
> "No source files for package" in a directory with accent characters
> ---
>
> Key: MJAVADOC-614
> URL: https://issues.apache.org/jira/browse/MJAVADOC-614
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: javadoc
>Affects Versions: 3.1.0, 3.1.1, 3.2.0
> Environment: Operating System: Windows 7
> Java: OracleJDK12
> Maven: 3.6.1
>Reporter: Alexis Jehan
>Priority: Critical
> Attachments: options, options(3.0.1), packages, packages(3.0.1)
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
>
> Executing "mvn clean javadoc:javadoc" in the "D:\é\foo" produces the
> following error:
> {quote}[ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.1.1:javadoc (default-cli) on
> project foo: An error has occurred in Javadoc report generation:
> [ERROR] Exit code: 2 - javadoc: error - No source files for package foo.bar
> [ERROR]
> [ERROR] Command line was: "C:\Program Files\Java\jdk-12\bin\javadoc.exe"
> @options @packages
> [ERROR]
> [ERROR] Refer to the generated Javadoc files in
> 'D:\é\foo\target\site\apidocs' dir.
> {quote}
> In a directory named "D:\e\foo", the same command does not produce any error.
> The bug does not affect Apache Maven Javadoc Plugin 3.0.1.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (MJAVADOC-614) "No source files for package" in a directory with accent characters
[
https://issues.apache.org/jira/browse/MJAVADOC-614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066195#comment-17066195
]
Michael Miller edited comment on MJAVADOC-614 at 3/24/20, 9:35 PM:
---
I am seeing the same error but for a different reason. We have a Java 11
project with automatic module names that fails at a package-info.java with no
files. This is also with 3.2.0
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-javadoc-plugin:3.2.0:jar (default-cli) on
project accumulo-core: MavenReportException: Error while generating Javadoc:
[ERROR] Exit code: 2 - javadoc: error - No source files for package
org.apache.accumulo.core.spi
[ERROR]
[ERROR] Command line was: /usr/local/lib/jvm/openjdk11/bin/javadoc -J-Xmx512m
@options @packages
[ERROR]
[ERROR] Refer to the generated Javadoc files in
'/home/travis/build/apache/accumulo/core/target/apidocs' dir.
[https://github.com/apache/accumulo/pull/1438]
was (Author: milleruntime):
I am seeing the same error but for a different reason. We have a Java 11
project with automatic module names that fails at a package-info.java with no
files. This is also with 3.2.0
```
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-javadoc-plugin:3.2.0:jar (default-cli) on
project accumulo-core: MavenReportException: Error while generating Javadoc:
[ERROR] Exit code: 2 - javadoc: error - No source files for package
org.apache.accumulo.core.spi
[ERROR]
[ERROR] Command line was: /usr/local/lib/jvm/openjdk11/bin/javadoc -J-Xmx512m
@options @packages
[ERROR]
[ERROR] Refer to the generated Javadoc files in
'/home/travis/build/apache/accumulo/core/target/apidocs' dir.
```
https://github.com/apache/accumulo/pull/1438
> "No source files for package" in a directory with accent characters
> ---
>
> Key: MJAVADOC-614
> URL: https://issues.apache.org/jira/browse/MJAVADOC-614
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: javadoc
>Affects Versions: 3.1.0, 3.1.1, 3.2.0
> Environment: Operating System: Windows 7
> Java: OracleJDK12
> Maven: 3.6.1
>Reporter: Alexis Jehan
>Priority: Critical
> Attachments: options, options(3.0.1), packages, packages(3.0.1)
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
>
> Executing "mvn clean javadoc:javadoc" in the "D:\é\foo" produces the
> following error:
> {quote}[ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.1.1:javadoc (default-cli) on
> project foo: An error has occurred in Javadoc report generation:
> [ERROR] Exit code: 2 - javadoc: error - No source files for package foo.bar
> [ERROR]
> [ERROR] Command line was: "C:\Program Files\Java\jdk-12\bin\javadoc.exe"
> @options @packages
> [ERROR]
> [ERROR] Refer to the generated Javadoc files in
> 'D:\é\foo\target\site\apidocs' dir.
> {quote}
> In a directory named "D:\e\foo", the same command does not produce any error.
> The bug does not affect Apache Maven Javadoc Plugin 3.0.1.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MSKINS-163) Upgrade to parent POM 34
[ https://issues.apache.org/jira/browse/MSKINS-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066093#comment-17066093 ] Slawomir Jaranowski commented on MSKINS-163: Ok, first "parent pom in it test" can be as separate issue. But second question about dependencyLocationsEnabled option I think is connected with this issue. After upgrade parent pom without resolve it - I see many red color / errors in IDE so I think that current project quality made worse. And reason is this upgrade. So is connected. > Upgrade to parent POM 34 > > > Key: MSKINS-163 > URL: https://issues.apache.org/jira/browse/MSKINS-163 > Project: Maven Skins > Issue Type: Dependency upgrade > Components: Fluido Skin >Affects Versions: fluido-1.8 >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Major > Fix For: fluido-1.9 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSKINS-161) Upgrade Facebook like button integration
[ https://issues.apache.org/jira/browse/MSKINS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066155#comment-17066155 ] Slawomir Jaranowski commented on MSKINS-161: PR ready, I'm waiting for your review > Upgrade Facebook like button integration > > > Key: MSKINS-161 > URL: https://issues.apache.org/jira/browse/MSKINS-161 > Project: Maven Skins > Issue Type: Improvement > Components: Fluido Skin >Affects Versions: fluido-1.8 >Reporter: Slawomir Jaranowski >Priority: Major > Attachments: Screenshot 2020-03-22 at 10.31.29.png > > Time Spent: 10m > Remaining Estimate: 0h > > Current Facebook integration use iframe and "Like button" is cropped. > Upgrading to newer facebook sdk can help in cropping "like button". > > We also have some configurations for "like button" > - action type like or recommend > - share button visibility > - layout > - button size > - ... > some of those should have possibility to configured by site.xml > [https://developers.facebook.com/docs/plugins/like-button/] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (MDEP-677) Suggest BOM updates
[
https://issues.apache.org/jira/browse/MDEP-677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte closed MDEP-677.
---
Assignee: Robert Scholte
Resolution: Invalid
> Suggest BOM updates
> ---
>
> Key: MDEP-677
> URL: https://issues.apache.org/jira/browse/MDEP-677
> Project: Maven Dependency Plugin
> Issue Type: Improvement
>Reporter: Elliotte Rusty Harold
>Assignee: Robert Scholte
>Priority: Major
>
> mvn versions:display-dependency-updates
>
> only suggests updates for dependencies in the dependencies and
> dependencyManagement sections. It does not suggest updates for BOMs imported
> by the dependencyManagement section. It should.
>
> E.g. when scanning this:
>
> {\{ }}
> \{{ }}
> \{{ }}
> \{{ com.google.cloud}}
> \{{ libraries-bom}}
> \{{ 4.1.0}}
> \{{ pom}}
> \{{ import}}
> \{{ }}
> \{{ }}
> \{{ }}
> It should suggest updating libraries-bom to 4.1.1.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6879) When the repo with the id of central is configured in settings.xml and the scope = import dependency is included in the project of the project, the central repo has a pro
[
https://issues.apache.org/jira/browse/MNG-6879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066271#comment-17066271
]
wuzishu commented on MNG-6879:
--
I know this solution, but I found this behavior to be a bug when resolving
scope as import dependencies. And when parsing the parent of the project pom,
there is similar behavior, but it does not really replace the central！What do
you think of this？ [~rfscholte]
> When the repo with the id of central is configured in settings.xml and the
> scope = import dependency is included in the project of the project, the
> central repo has a problem
> --
>
> Key: MNG-6879
> URL: https://issues.apache.org/jira/browse/MNG-6879
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories
>Affects Versions: 3.6.2
> Environment: Mac,maven 3.6.2
>Reporter: wuzishu
>Priority: Major
> Attachments: image-2020-03-24-21-39-54-127.png,
> image-2020-03-24-21-47-50-561.png, image-2020-03-24-21-49-31-997.png,
> image-2020-03-24-21-57-58-635.png, image-2020-03-24-21-58-35-400.png,
> image-2020-03-24-22-00-08-867.png, image-2020-03-24-22-01-04-185.png
>
>
> When the repo with the id of central is configured in settings.xml and the
> scope = import dependency is included in the project of the project, the
> central repo has a problem
>
> *settings.xml配置如下*:
> {code:java}
>
> nexusRep
>
>
> nexus
> Nexus Repository
> https://repo.spring.io/libs-release1
> true
> true
>
>
>
>
> nexus
> Nexus pluginRepository
> https://repo.spring.io/libs-release1
> true
> true
>
>
>
>
> central
>
>
> central
> Nexus Repository
> https://repo.spring.io/libs-release
> true
> true
>
>
>
>
> central
> Nexus pluginRepository
> https://repo.spring.io/libs-release
> true
> true
>
>
>
>
>
>
>
>nexusRep
>central
>
> {code}
>
> *project pom.xml:*
> {code:java}
> //代码占位符
>
> http://maven.apache.org/POM/4.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> https://maven.apache.org/xsd/maven-4.0.0.xsd;>
> 4.0.0
>
> org.springframework.boot
> spring-boot-starter-parent
> 2.2.5.RELEASE
>
>
> com.example
> demo
> 0.0.1-SNAPSHOT
> demo
> Demo project for Spring Boot
>
> 1.8
>
> Angel.SR6
>
>
>
> org.springframework.boot
> spring-boot-starter-web
>
>
> org.springframework.cloud
> spring-cloud-dependencies
> ${spring-cloud-dependencies.version}
> pom
> import
>
>
> org.projectlombok
> lombok
> compile
> true
>
>
> org.springframework.boot
> spring-boot-starter-test
> test
>
>
> org.junit.vintage
> junit-vintage-engine
>
>
>
>
>
>
>
> org.springframework.boot
> spring-boot-maven-plugin
>
>
>
>
>
> test
> repo
>
> true
>
>
> true
>
> https://repo.spring.io/libs-release
>
>
>
> {code}
> The theoretical maven remote repository priority is:
> !image-2020-03-24-21-47-50-561.png|width=412,height=237!
> However, when resolving a scope = import dependency, such as:
> !image-2020-03-24-21-49-31-997.png|width=705,height=185!
> The warehouse priority will become as shown in the figure below:
> !image-2020-03-24-21-39-54-127.png|width=712,height=379!
> Found that the central repository was reset to the default, and all
>
[jira] [Updated] (MCOMPILER-410) CI Broken by JDK 15 changes
[
https://issues.apache.org/jira/browse/MCOMPILER-410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte updated MCOMPILER-410:
-
Description:
{noformat}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.8.2-SNAPSHOT:compile
(default-compile) on project error-prone-compiler: Compilation failure
[ERROR]
/home/jenkins/jenkins-slave/workspace/box_maven-compiler-plugin_master@2/linux-jdk15-m3.6.x_build/target/it/error-prone-compiler/src/main/java/MyClass.java:[20,8]
cannot access java.lang.Object
[ERROR] bad class file: /modules/java.base/java/lang/Object.class
[ERROR] class file has wrong version 59.0, should be 53.0
[ERROR] Please remove or make sure it appears in the correct
subdirectory of the classpath.
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.8.2-SNAPSHOT:compile
(default-compile) on project error-prone-compiler: Compilation failure
/home/jenkins/jenkins-slave/workspace/box_maven-compiler-plugin_master@2/linux-jdk15-m3.6.x_build/target/it/error-prone-compiler/src/main/java/MyClass.java:[20,8]
cannot access java.lang.Object
bad class file: /modules/java.base/java/lang/Object.class
class file has wrong version 59.0, should be 53.0
Please remove or make sure it appears in the correct subdirectory of
the classpath.
{noformat}
was:
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.8.2-SNAPSHOT:compile
(default-compile) on project error-prone-compiler: Compilation failure
[ERROR]
/home/jenkins/jenkins-slave/workspace/box_maven-compiler-plugin_master@2/linux-jdk15-m3.6.x_build/target/it/error-prone-compiler/src/main/java/MyClass.java:[20,8]
cannot access java.lang.Object
[ERROR] bad class file: /modules/java.base/java/lang/Object.class
[ERROR] class file has wrong version 59.0, should be 53.0
[ERROR] Please remove or make sure it appears in the correct
subdirectory of the classpath.
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.8.2-SNAPSHOT:compile
(default-compile) on project error-prone-compiler: Compilation failure
/home/jenkins/jenkins-slave/workspace/box_maven-compiler-plugin_master@2/linux-jdk15-m3.6.x_build/target/it/error-prone-compiler/src/main/java/MyClass.java:[20,8]
cannot access java.lang.Object
bad class file: /modules/java.base/java/lang/Object.class
class file has wrong version 59.0, should be 53.0
Please remove or make sure it appears in the correct subdirectory of
the classpath.
> CI Broken by JDK 15 changes
> ---
>
> Key: MCOMPILER-410
> URL: https://issues.apache.org/jira/browse/MCOMPILER-410
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Reporter: Elliotte Rusty Harold
>Priority: Major
>
> {noformat}
>[ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.8.2-SNAPSHOT:compile
> (default-compile) on project error-prone-compiler: Compilation failure
>[ERROR]
> /home/jenkins/jenkins-slave/workspace/box_maven-compiler-plugin_master@2/linux-jdk15-m3.6.x_build/target/it/error-prone-compiler/src/main/java/MyClass.java:[20,8]
> cannot access java.lang.Object
>[ERROR] bad class file: /modules/java.base/java/lang/Object.class
>[ERROR] class file has wrong version 59.0, should be 53.0
>[ERROR] Please remove or make sure it appears in the correct
> subdirectory of the classpath.
>[ERROR] -> [Help 1]
>org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
> execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.8.2-SNAPSHOT:compile
> (default-compile) on project error-prone-compiler: Compilation failure
>
> /home/jenkins/jenkins-slave/workspace/box_maven-compiler-plugin_master@2/linux-jdk15-m3.6.x_build/target/it/error-prone-compiler/src/main/java/MyClass.java:[20,8]
> cannot access java.lang.Object
> bad class file: /modules/java.base/java/lang/Object.class
>class file has wrong version 59.0, should be 53.0
>Please remove or make sure it appears in the correct subdirectory
> of the classpath.
> {noformat}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-javadoc-plugin] elharo commented on issue #42: update qdox
elharo commented on issue #42: update qdox URL: https://github.com/apache/maven-javadoc-plugin/pull/42#issuecomment-603541564 Build failed. Not clear why: [INFO] Passed: 66, Failed: 1, Errors: 0, Skipped: 4 [INFO] - [ERROR] The following builds failed: [ERROR] * detectLinks\pom.xml [INFO] - [INFO] run post-build script verify.groovy [INFO] MJAVADOC-580_detectLinks\pom.xml . SUCCESS (7.9 s) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-shared-utils] elharo merged pull request #24: docs: Java 7 is the target
elharo merged pull request #24: docs: Java 7 is the target URL: https://github.com/apache/maven-shared-utils/pull/24 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
