[jira] [Commented] (DOXIA-409) Upgrade to Apache FOP 1.0
[ https://issues.apache.org/jira/browse/DOXIA-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325387#comment-16325387 ] ASF GitHub Bot commented on DOXIA-409: -- slachiewicz opened a new pull request #7: [DOXIA-409] Upgrade to FOP 2.2 URL: https://github.com/apache/maven-doxia/pull/7 Fix by: Michael SimacekUpgrade to Apache FOP 1.0 > - > > Key: DOXIA-409 > URL: https://issues.apache.org/jira/browse/DOXIA-409 > Project: Maven Doxia > Issue Type: Improvement > Components: Module - FO >Affects Versions: 1.1 >Reporter: Lukas Theussl > > Unfortunately this leads to a test failure in the pdf plugin because of a > regression in FOP: https://issues.apache.org/bugzilla/show_bug.cgi?id=49837 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MPLUGIN-331) Check the existence of plugin.xml rather than project packaging in PluginReport.canGenerateReport()
[ https://issues.apache.org/jira/browse/MPLUGIN-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325382#comment-16325382 ] Hudson commented on MPLUGIN-331: Build succeeded in Jenkins: Maven TLP » maven-plugin-tools » master #12 See https://builds.apache.org/job/maven-box/job/maven-plugin-tools/job/master/12/ > Check the existence of plugin.xml rather than project packaging in > PluginReport.canGenerateReport() > --- > > Key: MPLUGIN-331 > URL: https://issues.apache.org/jira/browse/MPLUGIN-331 > Project: Maven Plugin Tools > Issue Type: Task > Components: Plugin Plugin >Reporter: Peter Palaga >Assignee: Hervé Boutemy > Fix For: 3.5.1 > > > {{org.apache.maven.plugin.plugin.PluginReport.canGenerateReport()}} currently > reads > {code} > return "maven-plugin".equals( project.getPackaging() ); > {code} > I propose to change it to > {code} > return "maven-plugin".equals( project.getPackaging() ) > || "takari-maven-plugin".equals( project.getPackaging() ); > {code} > so that also takari-maven-plugins are supported. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] slachiewicz commented on issue #29: Update to Mockito 2.11
slachiewicz commented on issue #29: Update to Mockito 2.11 URL: https://github.com/apache/maven-enforcer/pull/29#issuecomment-357476092 Fixed with merge for MENFORCER-278 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] slachiewicz closed pull request #29: Update to Mockito 2.11
slachiewicz closed pull request #29: Update to Mockito 2.11 URL: https://github.com/apache/maven-enforcer/pull/29 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/pom.xml b/pom.xml index 1751fc1..66eca52 100644 --- a/pom.xml +++ b/pom.xml @@ -121,7 +121,7 @@ junit junit -4.11 +4.12 org.mockito @@ -202,6 +202,12 @@ + + maven-compiler-plugin + + -Xlint:deprecation + + This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MPLUGIN-331) Check the existence of plugin.xml rather than project packaging in PluginReport.canGenerateReport()
[ https://issues.apache.org/jira/browse/MPLUGIN-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325379#comment-16325379 ] ASF GitHub Bot commented on MPLUGIN-331: hboutemy commented on issue #10: [MPLUGIN-331] Let plugin:report support takari-maven-plugin packaging URL: https://github.com/apache/maven-plugin-tools/pull/10#issuecomment-357475458 ok, I'll mark it as read only This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Check the existence of plugin.xml rather than project packaging in > PluginReport.canGenerateReport() > --- > > Key: MPLUGIN-331 > URL: https://issues.apache.org/jira/browse/MPLUGIN-331 > Project: Maven Plugin Tools > Issue Type: Task > Components: Plugin Plugin >Reporter: Peter Palaga >Assignee: Hervé Boutemy > Fix For: 3.5.1 > > > {{org.apache.maven.plugin.plugin.PluginReport.canGenerateReport()}} currently > reads > {code} > return "maven-plugin".equals( project.getPackaging() ); > {code} > I propose to change it to > {code} > return "maven-plugin".equals( project.getPackaging() ) > || "takari-maven-plugin".equals( project.getPackaging() ); > {code} > so that also takari-maven-plugins are supported. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] hboutemy commented on issue #10: [MPLUGIN-331] Let plugin:report support takari-maven-plugin packaging
hboutemy commented on issue #10: [MPLUGIN-331] Let plugin:report support takari-maven-plugin packaging URL: https://github.com/apache/maven-plugin-tools/pull/10#issuecomment-357475458 ok, I'll mark it as read only This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MPOM-158) Use some sensible defaults with Apache RAT
[ https://issues.apache.org/jira/browse/MPOM-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325377#comment-16325377 ] Hervé Boutemy commented on MPOM-158: default excludes are on by default with rat 0.12 http://creadur.apache.org/rat/apache-rat-plugin/check-mojo.html#useDefaultExcludes do we really need to configure anything in Apache parent pom? > Use some sensible defaults with Apache RAT > -- > > Key: MPOM-158 > URL: https://issues.apache.org/jira/browse/MPOM-158 > Project: Maven POMs > Issue Type: Improvement > Components: asf >Reporter: John D. Ament > Attachments: RAT-CONFIG.patch > > > The rat section in the parent pom doesn't include RAT defaults. Would be > good to use some sensible defaults. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1004) Enhance pattern/wildcard capabilities for dependenciesToScan to GAVT
[ https://issues.apache.org/jira/browse/SUREFIRE-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325376#comment-16325376 ] ASF GitHub Bot commented on SUREFIRE-1004: -- Github user bindul commented on the issue: https://github.com/apache/maven-surefire/pull/173 @Tibor17, Sorry I misunderstood your first comment. Thank you again for taking the time to review the changes and for your patience. I will rework the pull request using your [latest comment](https://github.com/apache/maven-surefire/pull/173#issuecomment-357434597) and the inline review comments. I will get back to you soon. Bindul > Enhance pattern/wildcard capabilities for dependenciesToScan to GAVT > > > Key: SUREFIRE-1004 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1004 > Project: Maven Surefire > Issue Type: Improvement > Components: Maven Failsafe Plugin, Maven Surefire Plugin >Affects Versions: 2.15 >Reporter: Andreas Gudian > > * Enhance what has been built with SUREFIRE-569 to support patterns as in > maven-shade-plugin. Use maven-common-artifact-filters for that. > * Add/Adapt documentation and examples. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] maven-surefire issue #173: [SUREFIRE-1004] Support full gavtc format for dep...
Github user bindul commented on the issue: https://github.com/apache/maven-surefire/pull/173 @Tibor17, Sorry I misunderstood your first comment. Thank you again for taking the time to review the changes and for your patience. I will rework the pull request using your [latest comment](https://github.com/apache/maven-surefire/pull/173#issuecomment-357434597) and the inline review comments. I will get back to you soon. Bindul ---
[jira] [Commented] (MNG-5967) Dependency updates
[ https://issues.apache.org/jira/browse/MNG-5967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325369#comment-16325369 ] ASF GitHub Bot commented on MNG-5967: - GitHub user slachiewicz opened a pull request: https://github.com/apache/maven/pull/154 [MNG-5967] Correct Mockito scope to test You can merge this pull request into a Git repository by running: $ git pull https://github.com/slachiewicz/maven fix/MNG-5967 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/154.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #154 commit 379eeef17134646b6b19bd42517e108de574c04c Author: Sylwester LachiewiczDate: 2018-01-13T23:01:43Z [MNG-5967] Correct Mockito scope to test > Dependency updates > -- > > Key: MNG-5967 > URL: https://issues.apache.org/jira/browse/MNG-5967 > Project: Maven > Issue Type: Dependency upgrade > Components: Dependencies >Reporter: Christian Schulte >Assignee: Michael Osipov >Priority: Trivial > Fix For: 3.5.0-alpha-1, 3.5.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (MPOM-134) Add profile to use a different resource bundle for incubator projects
[ https://issues.apache.org/jira/browse/MPOM-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hervé Boutemy updated MPOM-134: --- Fix Version/s: (was: ASF-19) ASF-20 > Add profile to use a different resource bundle for incubator projects > - > > Key: MPOM-134 > URL: https://issues.apache.org/jira/browse/MPOM-134 > Project: Maven POMs > Issue Type: Improvement >Affects Versions: ASF-18 >Reporter: Christopher Tubbs > Fix For: ASF-20 > > > The {{org.apache:apache-jar-resource-bundle:1.4}} resourceBundle currently > specified in the parent POM does not handle the DISCLAIMER file for incubator > projects. > It would be nice if there were an incubation profile, which could be > activated for incubating projects, to use an incubating resource bundle which > did handle this DISCLAIMER file. > This could be done in several ways: > # An optional second execution of the {{maven-remote-resources-plugin}} could > run when the profile is activated, which handles a second resource bundle for > the DISCLAIMER file. > # The current resourceBundle could be turned into a property, which is > overridden when the profile is activated, using a resourceBundle which > handles everything the current one does, plus the DISCLAIMER file. > # The current {{maven-remote-resources-plugin}} execution could have the > {{}} element changed to {{ combine.children="append">}}, and the profile could specify an additional > {{}} to handle the DISCLAIMER file, for the same execution id > of {{maven-remote-resources-plugin}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MPOM-134) Add profile to use a different resource bundle for incubator projects
[ https://issues.apache.org/jira/browse/MPOM-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325366#comment-16325366 ] Hervé Boutemy commented on MPOM-134: we did not find any solution yet to this issue I'm postponing to ASF-20... > Add profile to use a different resource bundle for incubator projects > - > > Key: MPOM-134 > URL: https://issues.apache.org/jira/browse/MPOM-134 > Project: Maven POMs > Issue Type: Improvement >Affects Versions: ASF-18 >Reporter: Christopher Tubbs > Fix For: ASF-20 > > > The {{org.apache:apache-jar-resource-bundle:1.4}} resourceBundle currently > specified in the parent POM does not handle the DISCLAIMER file for incubator > projects. > It would be nice if there were an incubation profile, which could be > activated for incubating projects, to use an incubating resource bundle which > did handle this DISCLAIMER file. > This could be done in several ways: > # An optional second execution of the {{maven-remote-resources-plugin}} could > run when the profile is activated, which handles a second resource bundle for > the DISCLAIMER file. > # The current resourceBundle could be turned into a property, which is > overridden when the profile is activated, using a resourceBundle which > handles everything the current one does, plus the DISCLAIMER file. > # The current {{maven-remote-resources-plugin}} execution could have the > {{}} element changed to {{ combine.children="append">}}, and the profile could specify an additional > {{}} to handle the DISCLAIMER file, for the same execution id > of {{maven-remote-resources-plugin}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (MPOM-173) Upgrade mave-surefire/failsafe-plugin 2.20.1
[ https://issues.apache.org/jira/browse/MPOM-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hervé Boutemy updated MPOM-173: --- Affects Version/s: (was: ASF-20) ASF-18 > Upgrade mave-surefire/failsafe-plugin 2.20.1 > > > Key: MPOM-173 > URL: https://issues.apache.org/jira/browse/MPOM-173 > Project: Maven POMs > Issue Type: Dependency upgrade > Components: asf >Affects Versions: ASF-18 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: ASF-19 > > > This update is needed to prevent failures on Jenkins based on issue in [Maven > Surefire Plugin|SUREFIRE-1312] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (MPOM-173) Upgrade mave-surefire/failsafe-plugin 2.20.1
[ https://issues.apache.org/jira/browse/MPOM-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hervé Boutemy updated MPOM-173: --- Fix Version/s: (was: ASF-20) ASF-19 > Upgrade mave-surefire/failsafe-plugin 2.20.1 > > > Key: MPOM-173 > URL: https://issues.apache.org/jira/browse/MPOM-173 > Project: Maven POMs > Issue Type: Dependency upgrade > Components: asf >Affects Versions: ASF-18 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: ASF-19 > > > This update is needed to prevent failures on Jenkins based on issue in [Maven > Surefire Plugin|SUREFIRE-1312] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MNG-6337) NPE on usage of DefaultMavenSettingsBuilder
[ https://issues.apache.org/jira/browse/MNG-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325357#comment-16325357 ] Sylwester Lachiewicz commented on MNG-6337: --- Hi [~rfscholte], while looking at Maven sources I found that migration to CDI was not finished. Would this be appropriate to finish migration for other components or is anyone already doing it? > NPE on usage of DefaultMavenSettingsBuilder > --- > > Key: MNG-6337 > URL: https://issues.apache.org/jira/browse/MNG-6337 > Project: Maven > Issue Type: Bug > Components: core >Affects Versions: 3.5.2 >Reporter: Dominic Monroe > Attachments: mng-6337-1.patch > > > Basic usage of the class results in an error. I am not writing java, but I > have tried to translate. > {code:title=Bar.java|borderStyle=solid} > DefaultMavenSettingsBuilder x = new DefaultMavenSettingsBuilder(); > x.buildSettings(); > {code} > This is the stacktrace, sorry that there is frames mixed in: > {code} > java.lang.NullPointerException > at > org.apache.maven.settings.DefaultMavenSettingsBuilder.build(DefaultMavenSettingsBuilder.java:90) > at > org.apache.maven.settings.DefaultMavenSettingsBuilder.buildSettings(DefaultMavenSettingsBuilder.java:76) > at > org.apache.maven.settings.DefaultMavenSettingsBuilder.buildSettings(DefaultMavenSettingsBuilder.java:56) > at user$eval3.invokeStatic(NO_SOURCE_FILE:2) > at user$eval3.invoke(NO_SOURCE_FILE:2) > at clojure.lang.Compiler.eval(Compiler.java:6927) > at clojure.lang.Compiler.eval(Compiler.java:6890) > at clojure.core$eval.invokeStatic(core.clj:3105) > at clojure.core$eval.invoke(core.clj:3101) > at > clojure.main$repl$read_eval_print__7408$fn__7411.invoke(main.clj:240) > at clojure.main$repl$read_eval_print__7408.invoke(main.clj:240) > at clojure.main$repl$fn__7417.invoke(main.clj:258) > at clojure.main$repl.invokeStatic(main.clj:258) > at clojure.main$repl_opt.invokeStatic(main.clj:322) > at clojure.main$main.invokeStatic(main.clj:421) > at clojure.main$main.doInvoke(main.clj:384) > at clojure.lang.RestFn.invoke(RestFn.java:397) > at clojure.lang.Var.invoke(Var.java:375) > at clojure.lang.AFn.applyToHelper(AFn.java:152) > at clojure.lang.Var.applyTo(Var.java:700) > at clojure.main.main(main.java:37) > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MNG-6312) Update Maven Wagon dependency
[ https://issues.apache.org/jira/browse/MNG-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325355#comment-16325355 ] Sylwester Lachiewicz commented on MNG-6312: --- Yours patch shoud be enugh - i run ITs on windows almost with success. Only one error {code} testitReactorShouldResultInExpectedOrder(org.apache.maven.it.MavenITmng6057CheckReactorOrderTest) Time elapsed: 1.699 sec <<< FAILURE! junit.framework.AssertionFailedError: expected:<3> but was:<5> at junit.framework.Assert.fail(Assert.java:47) org.apache.maven.it.MavenITmng6057CheckReactorOrderTest.testitReactorShouldResultInExpectedOrder(MavenITmng6057CheckReactorOrderTest.java:69) {code} Result from test with maven 3.5.3-SNAPSHOT {code} [INFO] Reactor Build Order: [INFO] [INFO] base-project [pom] [INFO] module-1 [pom] [INFO] module-2 [jar] {code} but this looks like related to already fixed MNG-6057 maybe test in ITs should be adjusted? > Update Maven Wagon dependency > - > > Key: MNG-6312 > URL: https://issues.apache.org/jira/browse/MNG-6312 > Project: Maven > Issue Type: Dependency upgrade >Affects Versions: 3.5.0 >Reporter: Sylwester Lachiewicz >Assignee: Karl Heinz Marbaise > Fix For: 3.5.3 > > > Based on OWASP report - update Maven Wagon from 2.12 to 3.0.0 to fix known > vulnerability in shaded jsoup > wagon-http-2.12-shaded.jar\META-INF/maven/org.jsoup/jsoup/pom.xml > (cpe:/a:jsoup:jsoup:1.7.2, org.jsoup:jsoup:1.7.2) : CVE-2015-6748 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (SUREFIRE-1463) integration tests should run on the top of JDK 9
Tibor Digana created SUREFIRE-1463: -- Summary: integration tests should run on the top of JDK 9 Key: SUREFIRE-1463 URL: https://issues.apache.org/jira/browse/SUREFIRE-1463 Project: Maven Surefire Issue Type: Task Reporter: Tibor Digana Assignee: Tibor Digana -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MNG-6069) Migrate to non deprecated parts of Commons CLI
[ https://issues.apache.org/jira/browse/MNG-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325352#comment-16325352 ] Sylwester Lachiewicz commented on MNG-6069: --- Setting SystemProperty in setCliProperty was overwitten later in callinc method in line 1364 > Migrate to non deprecated parts of Commons CLI > -- > > Key: MNG-6069 > URL: https://issues.apache.org/jira/browse/MNG-6069 > Project: Maven > Issue Type: Improvement > Components: Embedding >Affects Versions: 3.3.9, 3.5.0-alpha-1, 3.5.0-beta-1, 3.5.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.5.x-candidate > > > At the moment all parts of {{OptionBuilder...}} are marked deprecated in > {{CLIManager}}. They should be migrated to: > {code:java} > Option.builder( HELP ).longOpt( "help" ).desc( "Display help information" > ).build() > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MDEPLOY-228) Upgrade plexus-utils 3.1.0
[ https://issues.apache.org/jira/browse/MDEPLOY-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325321#comment-16325321 ] Hudson commented on MDEPLOY-228: Build succeeded in Jenkins: Maven TLP » maven-deploy-plugin » master #2 See https://builds.apache.org/job/maven-box/job/maven-deploy-plugin/job/master/2/ > Upgrade plexus-utils 3.1.0 > -- > > Key: MDEPLOY-228 > URL: https://issues.apache.org/jira/browse/MDEPLOY-228 > Project: Maven Deploy Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.0.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.0.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (MDEPLOY-228) Upgrade plexus-utils 3.1.0
Karl Heinz Marbaise created MDEPLOY-228: --- Summary: Upgrade plexus-utils 3.1.0 Key: MDEPLOY-228 URL: https://issues.apache.org/jira/browse/MDEPLOY-228 Project: Maven Deploy Plugin Issue Type: Dependency upgrade Affects Versions: 3.0.0 Reporter: Karl Heinz Marbaise Assignee: Karl Heinz Marbaise Priority: Minor Fix For: 3.0.0 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (MDEPLOY-210) Upgrade of commons-io to 2.5.
[ https://issues.apache.org/jira/browse/MDEPLOY-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MDEPLOY-210: Issue Type: Dependency upgrade (was: Task) > Upgrade of commons-io to 2.5. > - > > Key: MDEPLOY-210 > URL: https://issues.apache.org/jira/browse/MDEPLOY-210 > Project: Maven Deploy Plugin > Issue Type: Dependency upgrade >Reporter: Christian Schulte >Assignee: Christian Schulte >Priority: Trivial > Fix For: 3.0.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (MDEPLOY-208) Upgrade plexus-utils to 3.0.24
[ https://issues.apache.org/jira/browse/MDEPLOY-208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MDEPLOY-208: Issue Type: Dependency upgrade (was: Improvement) > Upgrade plexus-utils to 3.0.24 > -- > > Key: MDEPLOY-208 > URL: https://issues.apache.org/jira/browse/MDEPLOY-208 > Project: Maven Deploy Plugin > Issue Type: Dependency upgrade >Affects Versions: 2.8.2 >Reporter: Karl Heinz Marbaise >Assignee: Christian Schulte > Fix For: 3.0.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (MDEPLOY-192) Upgrade maven-plugin-testing-harness to 1.3
[ https://issues.apache.org/jira/browse/MDEPLOY-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MDEPLOY-192: Issue Type: Dependency upgrade (was: Improvement) > Upgrade maven-plugin-testing-harness to 1.3 > --- > > Key: MDEPLOY-192 > URL: https://issues.apache.org/jira/browse/MDEPLOY-192 > Project: Maven Deploy Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.0.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.0.0 > > > Upgrade to version 1.3 > {code:xml} > > org.apache.maven.plugin-testing > maven-plugin-testing-harness > 1.3 > test > > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (MDEPLOY-219) Upgrade maven-artifact-transfer to version 0.9.1
[ https://issues.apache.org/jira/browse/MDEPLOY-219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MDEPLOY-219: Issue Type: Dependency upgrade (was: Bug) > Upgrade maven-artifact-transfer to version 0.9.1 > > > Key: MDEPLOY-219 > URL: https://issues.apache.org/jira/browse/MDEPLOY-219 > Project: Maven Deploy Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.0.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Blocker > Fix For: 3.0.0 > > > The version 0.9.1 of the maven-artifact-transfer contains a [fix for Maven > 3.0|MSHARED-602] which should be part of this release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1410) Add FAQ and improve Warning message when native stream in forked JVM is corrupted
[ https://issues.apache.org/jira/browse/SUREFIRE-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325242#comment-16325242 ] Hudson commented on SUREFIRE-1410: -- ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/]) [SUREFIRE-1410] Add FAQ and improve Warning message when native stream (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=ead22a3d399a5fd608ebae90a079644ab786eae8]) * (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/ForkingRunListenerTest.java * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkStarter.java * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/output/ForkClient.java * (edit) maven-surefire-plugin/src/site/fml/faq.fml > Add FAQ and improve Warning message when native stream in forked JVM is > corrupted > - > > Key: SUREFIRE-1410 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1410 > Project: Maven Surefire > Issue Type: Improvement > Components: Maven Failsafe Plugin, Maven Surefire Plugin >Reporter: Tibor Digana >Assignee: Tibor Digana > Labels: documentation > Fix For: 2.20.1 > > > Related to the discussion with contributors in SUREFIRE-1359. > The message {{Corrupted stdin stream in forked JVM}} would become more > specific {{Corrupted STDOUT by directly writing to native stream in forked > JVM}}. > Then {{See the dump file}} would be extended to {{See FAQ web page and the > dump file}}. > These messages would appear just once in the console and not per fork as it > was in prior versions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1416) maven-surefire-parser: add new method isError in ReportTestCase
[ https://issues.apache.org/jira/browse/SUREFIRE-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325262#comment-16325262 ] Hudson commented on SUREFIRE-1416: -- ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/]) [SUREFIRE-1416] maven-surefire-parser: add new method isError in (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=869d6f29ff81bf2116a118f8118b63f21de4aa8a]) * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java * (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire260TestWithIdenticalNamesIT.java * (edit) maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/Surefire597Test.java * (edit) surefire-report-parser/src/test/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParserTest.java * (edit) surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportParser.java * (edit) surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java * (edit) maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java * (edit) surefire-report-parser/src/test/java/org/apache/maven/plugins/surefire/report/SurefireReportParserTest.java * (edit) surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/ReportTestCase.java * (edit) surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/ReportTestSuite.java > maven-surefire-parser: add new method isError in ReportTestCase > --- > > Key: SUREFIRE-1416 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1416 > Project: Maven Surefire > Issue Type: Improvement > Components: Maven Surefire Plugin >Reporter: Simon Urli >Assignee: Tibor Digana >Priority: Minor > Fix For: 2.21.0.Jigsaw > > > There is currently no way after parsing test suite to know if a test case is > a failure or an error. I need a boolean isError in ReportTestCase and > associated getter and setter, to be able to use properly the > maven-surefire-parser API to know if a test is considered as an error or as a > failure, without consulting the logs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1262) Add modulepath support
[ https://issues.apache.org/jira/browse/SUREFIRE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325251#comment-16325251 ] Hudson commented on SUREFIRE-1262: -- ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/]) [SUREFIRE-1262] Add modulepath support (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=f337881ff7f47ab35669d9c499213f5a6b9a4d8b]) * (add) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ModularClasspathForkConfiguration.java * (add) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/DefaultForkConfiguration.java * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/InPluginVMSurefireStarter.java * (add) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/AbstractClasspathForkConfiguration.java * (edit) pom.xml * (edit) maven-surefire-plugin/src/test/java/org/apache/maven/plugin/surefire/SurefirePluginTest.java * (edit) maven-surefire-common/src/test/java/org/apache/maven/surefire/util/RelocatorTest.java * (add) surefire-integration-tests/src/test/resources/modulepath/src/test/java/com/app/AppTest.java * (add) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ClasspathForkConfiguration.java * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/util/Relocator.java * (edit) maven-surefire-common/src/main/java/org/apache/maven/surefire/providerapi/ServiceLoader.java * (edit) surefire-booter/src/test/java/org/apache/maven/surefire/booter/SystemUtilsTest.java * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/Platform.java * (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java * (add) surefire-booter/src/main/java/org/apache/maven/surefire/booter/ModularClasspath.java * (add) surefire-booter/src/main/java/org/apache/maven/surefire/booter/ModularClasspathConfiguration.java * (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/StartupConfiguration.java * (add) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/ModulePathIT.java * (edit) maven-surefire-common/src/test/java/org/apache/maven/surefire/JUnit4SuiteTest.java * (add) surefire-integration-tests/src/test/resources/modulepath/pom.xml * (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerStartupConfigurationTest.java * (edit) surefire-api/src/test/java/org/apache/maven/surefire/util/ScanResultTest.java * (add) surefire-booter/src/main/java/org/apache/maven/surefire/booter/AbstractPathConfiguration.java * (add) surefire-integration-tests/src/test/resources/modulepath/src/main/java/module-info.java * (add) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/DefaultForkConfigurationTest.java * (edit) surefire-api/src/main/java/org/apache/maven/surefire/util/DefaultScanResult.java * (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/ClasspathConfiguration.java * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java * (add) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java * (edit) maven-surefire-common/pom.xml * (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/AbstractSurefireMojoTest.java * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/BooterSerializer.java * (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/Classpath.java * (add) surefire-integration-tests/src/test/resources/modulepath/src/main/java/com/app/Main.java * (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/ForkConfigurationTest.java * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkStarter.java added unit test and jsr305 @Nonnull/@Nullable for SUREFIRE-1262 (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=c594ac4c4278e109e2937d2581efc363d7002f75]) * (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/ModularClasspathConfiguration.java * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ModularClasspathForkConfiguration.java * (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/Classpath.java * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java * (add)
[jira] [Commented] (SUREFIRE-1454) Speedup Standard Output if Tests
[ https://issues.apache.org/jira/browse/SUREFIRE-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325259#comment-16325259 ] Hudson commented on SUREFIRE-1454: -- ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/]) [SUREFIRE-1454] Speedup Standard Output if Tests (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=a85d3276dbf6728ec855992352d613142aac41d3]) * (edit) surefire-api/src/test/java/org/apache/maven/surefire/util/internal/StringUtilsTest.java * (edit) surefire-api/src/main/java/org/apache/maven/surefire/util/internal/StringUtils.java * (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/ForkingRunListener.java > Speedup Standard Output if Tests > > > Key: SUREFIRE-1454 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1454 > Project: Maven Surefire > Issue Type: Improvement > Components: Maven Failsafe Plugin, Maven Surefire Plugin, process > forking >Reporter: Tibor Digana >Assignee: Tibor Digana > Fix For: 2.21.0.Jigsaw > > > Currently, surefire creates a new byte array with size of the input *3 for > saving the unescaped input. This made surefire way slower than running a test > directly in eclipse or with gradle, if it used standardout or error heavily. > By using a list for saving the elements and converting them to an array > afterwards, this problem is solved, and stdout-heavy surefire tests get > faster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1411) Improve calls String.length == 0 to Java 1.6 call String.isEmpty
[ https://issues.apache.org/jira/browse/SUREFIRE-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325243#comment-16325243 ] Hudson commented on SUREFIRE-1411: -- ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/]) [SUREFIRE-1411] Improve calls String.length == 0 to Java 1.6 call (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=8a63486f8efc721d0003cb5685e590a98369704a]) * (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fixture/SurefireLauncher.java * (edit) surefire-providers/surefire-testng-utils/src/main/java/org/apache/maven/surefire/testng/utils/GroupMatcherMethodSelector.java * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java * (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/Classpath.java * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/WrappedReportEntry.java * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/util/FileScanner.java * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java * (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/TypeEncodedValue.java * (edit) surefire-api/src/main/java/org/apache/maven/surefire/util/internal/StringUtils.java * (edit) surefire-api/src/main/java/org/apache/maven/surefire/testset/TestListResolver.java * (edit) surefire-providers/common-junit48/src/main/java/org/apache/maven/surefire/common/junit48/RequestedTest.java * (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/JUnitCoreWrapper.java * (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/ForkingRunListener.java * (edit) surefire-grouper/src/main/java/org/apache/maven/surefire/group/match/SingleGroupMatcher.java > Improve calls String.length == 0 to Java 1.6 call String.isEmpty > > > Key: SUREFIRE-1411 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1411 > Project: Maven Surefire > Issue Type: Improvement >Reporter: Tibor Digana >Assignee: Tibor Digana > Fix For: 2.20.1 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1439) NullPointerException on JDK10
[ https://issues.apache.org/jira/browse/SUREFIRE-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325256#comment-16325256 ] Hudson commented on SUREFIRE-1439: -- ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/]) [SUREFIRE-1439] NullPointerException on JDK10 (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=cb5173d0846edb4b83ebf20fe8618bf881ddba0c]) * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java * (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fixture/HelperAssertions.java * (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemUtils.java * (edit) surefire-booter/src/test/java/org/apache/maven/surefire/booter/SystemUtilsTest.java * (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/CheckTestNgListenerReporterIT.java * (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/JUnit47WithCucumberIT.java * (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1211JUnitTestNgIT.java * (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1177TestngParallelSuitesIT.java * (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/AbstractSurefireMojoTest.java * (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/AbstractJigsawIT.java > NullPointerException on JDK10 > - > > Key: SUREFIRE-1439 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1439 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.20.1 >Reporter: Sanne Grinovero >Assignee: Tibor Digana > Fix For: 2.21.0.Jigsaw > > > I'm having a NPE when testing the build on early access version of OpenJDK 10. > * http://jdk.java.net/10/ > {{Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test failed.: > NullPointerException ->}} > more verbose: > {code:java} > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute > goal org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test > (default-test) on project hibernate-search-build-config: Execution > default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test failed. > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81) > at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51) > at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:309) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:194) > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:107) > at org.apache.maven.cli.MavenCli.execute(MavenCli.java:993) > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:345) > at org.apache.maven.cli.MavenCli.main(MavenCli.java:191) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.base/java.lang.reflect.Method.invoke(Method.java:564) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229) > at > org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415) > at > org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356) > Caused by: org.apache.maven.plugin.PluginExecutionException: Execution > default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test failed. > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:145) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > ... 20 more > Caused by:
[jira] [Commented] (SUREFIRE-1183) Custom Test Report Titles and Descriptions
[ https://issues.apache.org/jira/browse/SUREFIRE-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325264#comment-16325264 ] Hudson commented on SUREFIRE-1183: -- ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/]) [SUREFIRE-1183] Custom Test Report Titles and Descriptions (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=7a33fd67b066908ef4aad6eb044c40eb4fe29482]) * (edit) maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/FailsafeReportMojo.java * (edit) maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java * (edit) maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/AbstractSurefireReportMojo.java * (edit) maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportMojo.java * (edit) maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportOnlyMojo.java * (add) maven-surefire-report-plugin/src/test/resources/surefire-1183/acceptancetest-reports/TEST-com.shape.CircleTest.xml * (add) maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/Surefire1183Test.java * (add) maven-surefire-report-plugin/src/test/resources/surefire-1183/plugin-config.xml > Custom Test Report Titles and Descriptions > -- > > Key: SUREFIRE-1183 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1183 > Project: Maven Surefire > Issue Type: Improvement > Components: Maven Surefire Report Plugin >Affects Versions: 2.18.1 >Reporter: Gerald Mücke >Assignee: Tibor Digana >Priority: Minor > Fix For: 2.21.0.Jigsaw > > Time Spent: 16h > Remaining Estimate: 0h > > Hi, > I'd like to add the possibility to customize the name and descriptions of the > test reports, in order to define report sets with not only custom outputNames > but custom titles and descriptions as well so that they appear in the report > with a self-describing name and description. > Motivation: > At a customer project we have several automated tests (unit tests, > integration tests, automated acceptance tests, performance tests) and each of > those are run either using surefire or failsafe. > We have different report sets for each of these tests and separate output > files. But in the Project Reports Overview each Report is named either > "Surefire Report" or "Failsafe Report" with the corresponding default > description. Further, the title of the Report page itself is always "Surefire > Reports" -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1437) Improve unit tests. Call PID parser on all platforms in SystemUtilsTest.
[ https://issues.apache.org/jira/browse/SUREFIRE-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325249#comment-16325249 ] Hudson commented on SUREFIRE-1437: -- ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/]) [SUREFIRE-1437] Improve unit tests. Call PID parser on all platforms in (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=4bf7c39b40ad438fee7160472f282114d5ae57d8]) * (edit) surefire-booter/src/test/java/org/apache/maven/surefire/booter/SystemUtilsTest.java * (add) surefire-booter/src/test/resources/proc/self/stat * (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemUtils.java * (add) surefire-booter/src/test/resources/proc/curproc/status > Improve unit tests. Call PID parser on all platforms in SystemUtilsTest. > > > Key: SUREFIRE-1437 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1437 > Project: Maven Surefire > Issue Type: Test >Reporter: Tibor Digana >Assignee: Tibor Digana > Fix For: 2.21.0.Jigsaw > > > Created additional methods {{pidStatusOnBSD}}, {{pidStatusOnLinux}} with > parameter and mock real system links {{/proc/curproc/status}}, > {{/proc/self/stat}}, respectively. > These methods are parser of PID and should be a subject to test improving > code coverage. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1452) Support filtering of tests from Base Class (TestNG)
[ https://issues.apache.org/jira/browse/SUREFIRE-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325257#comment-16325257 ] Hudson commented on SUREFIRE-1452: -- ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/]) [SUREFIRE-1452] Support filtering of tests from Base Class (TestNG) (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=39acb98a94242149b5a8374a9619eb06f6b3cb6d]) * (add) surefire-providers/surefire-testng-utils/src/test/java/testng/utils/ChildClassSample.java * (add) surefire-providers/surefire-testng-utils/src/test/java/testng/utils/MethodSelectorTest.java * (edit) surefire-providers/surefire-testng-utils/src/main/java/org/apache/maven/surefire/testng/utils/MethodSelector.java * (add) surefire-providers/surefire-testng-utils/src/test/java/testng/utils/BaseClassSample.java > Support filtering of tests from Base Class (TestNG) > --- > > Key: SUREFIRE-1452 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1452 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Failsafe Plugin, Maven Surefire Plugin, TestNG > support >Reporter: Tibor Digana >Assignee: Tibor Digana > Fix For: 2.21.0.Jigsaw > > > User has two test classes. > An abstract base class called {{BaseTest}} which contains an {{@Test}} method > called {{testMethodFromBase}}. A child class called {{ChildTest}} which > extends {{BaseTest}}. > User attempts at running the TestNG test via > {{-Dtest=ChildTest#testMethodFromBase}}. > This PR basically addresses only the TestNG portion of the bug > https://github.com/cbeust/testng/issues/1563 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1413) Javadoc - unknown TAG @noinspection
[ https://issues.apache.org/jira/browse/SUREFIRE-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325245#comment-16325245 ] Hudson commented on SUREFIRE-1413: -- ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/]) [SUREFIRE-1413] Javadoc - unknown TAG @noinspection (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=c8e42d05c8fb0a5b3ac8b14d33cac7ac196bbd60]) * (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/DirectoryScannerParametersAware.java * (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/ProviderPropertiesAware.java * (edit) maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java * (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/SurefireReflector.java * (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/RunOrderParametersAware.java * (edit) maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/AbstractSurefireReportMojo.java * (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/TestRequestAware.java * (edit) surefire-booter/src/test/java/org/apache/maven/surefire/booter/Foo.java * (edit) maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportMojo.java * (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/TestArtifactInfoAware.java * (edit) maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/FailsafeReportMojo.java * (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/ReporterConfigurationAware.java * (edit) surefire-providers/common-junit3/src/test/java/org/apache/maven/surefire/common/junit3/JUnit3TestCheckerTest.java * (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/SurefireClassLoadersAware.java > Javadoc - unknown TAG @noinspection > --- > > Key: SUREFIRE-1413 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1413 > Project: Maven Surefire > Issue Type: Bug >Reporter: Tibor Digana >Assignee: Tibor Digana > Labels: javadoc > Fix For: 2.20.1 > > > After updated {{maven-parent}} Version to 30 this issue became a blocker to > release {{2.20.1}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1448) Clarified specifying multiple categories for JUnit
[ https://issues.apache.org/jira/browse/SUREFIRE-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325252#comment-16325252 ] Hudson commented on SUREFIRE-1448: -- ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/]) [SUREFIRE-1448] Clarified specifying multiple categories for JUnit (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=e27b51e909e8efcc34415a8342901a53a078700c]) * (edit) maven-surefire-plugin/src/site/apt/examples/junit.apt.vm > Clarified specifying multiple categories for JUnit > -- > > Key: SUREFIRE-1448 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1448 > Project: Maven Surefire > Issue Type: Improvement > Components: Junit 4.x support >Reporter: Clay Anderson >Assignee: Tibor Digana >Priority: Trivial > Fix For: 2.21.0.Jigsaw > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1451) Surefire Booter compatibility with NetBSD ps(1) output
[ https://issues.apache.org/jira/browse/SUREFIRE-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325258#comment-16325258 ] Hudson commented on SUREFIRE-1451: -- ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/]) [SUREFIRE-1451] Surefire Booter compatibility with NetBSD ps(1) output (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=d7592d670f98b08d336a8a04bf1f2c55bbc7e858]) * (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/PpidChecker.java * (edit) surefire-booter/src/test/java/org/apache/maven/surefire/booter/PpidCheckerTest.java > Surefire Booter compatibility with NetBSD ps(1) output > -- > > Key: SUREFIRE-1451 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1451 > Project: Maven Surefire > Issue Type: Bug > Components: process forking >Affects Versions: 2.20.1 > Environment: NetBSD >Reporter: Tobias Nygren >Assignee: Tibor Digana >Priority: Minor > Fix For: 2.21.0.Jigsaw > > > On NetBSD The /bin/ps command reports time as 0:01 rather than 00:01 for > intervals shorter than 10 minutes. > The pattern as used [here in SureFire > Booter|https://github.com/apache/maven-surefire/commit/c343cc412b986fd9da839696c709542d03679d68#diff-33826e7c2cc48fb008e88914fd841d10R71] > to parse ps(1) output does not take this into account. > printf(3) logic for ps(1) can be found in the [ps > source|https://github.com/NetBSD/src/blob/9160f3e067c6f959b9ecb4296771d8a6ae9b3ee6/bin/ps/print.c#L832]. > The following patterns are possible and need to be accounted for: > * m:ss > * mm:ss > * h:mm:ss > * hh:mm:ss > * d-hh:mm:ss > * dd-hh:mm:ss -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1424) javax.transaction.TransactionManager not visible with Java9
[ https://issues.apache.org/jira/browse/SUREFIRE-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325254#comment-16325254 ] Hudson commented on SUREFIRE-1424: -- ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/]) [SUREFIRE-1424] javax.transaction.TransactionManager not visible with (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=7ac85f283a08fa8d0b447ca5685f545ae8acdc9d]) * (edit) surefire-integration-tests/src/test/resources/java9-full-api/pom.xml * (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java * (edit) surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9Test.java * (edit) maven-surefire-plugin/src/site/markdown/java9.md * (edit) surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9IT.java * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/AbstractClasspathForkConfiguration.java > javax.transaction.TransactionManager not visible with Java9 > --- > > Key: SUREFIRE-1424 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1424 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.20.1 > Environment: Apache Maven 3.5.0 > (ff8f5e7444045639af65f6095c62210b5713f426; 2017-04-03T21:39:06+02:00) > Maven home: /Users/snicoll/tools/maven > Java version: 9, vendor: Oracle Corporation > Java home: /Library/Java/JavaVirtualMachines/jdk-9.jdk/Contents/Home > Default locale: en_BE, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" >Reporter: Stephane Nicoll >Assignee: Tibor Digana > Fix For: 2.21.0.Jigsaw > > > I am trying to port Spring Boot to Java9 and I am hitting an issue that looks > like Maven specific. I've managed to trim down the problem to [a simple class > that doesn't involve Spring > Boot|https://github.com/snicoll-scratches/test-jta-java9] > If I run this project on the command line, I get the following: > {noformat} > Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.043 s <<< > FAILURE! - in com.example.testjtajava9.TestJtaJava9ApplicationTests > contextLoads(com.example.testjtajava9.TestJtaJava9ApplicationTests) Time > elapsed: 0.006 s <<< ERROR! > java.lang.NoClassDefFoundError: javax/transaction/TransactionManager > at > com.example.testjtajava9.TestJtaJava9ApplicationTests.contextLoads(TestJtaJava9ApplicationTests.java:9) > Caused by: java.lang.ClassNotFoundException: > javax.transaction.TransactionManager > at > com.example.testjtajava9.TestJtaJava9ApplicationTests.contextLoads(TestJtaJava9ApplicationTests.java:9) > {noformat} > If I run that test with IntelliJ IDEA, it passes. This sample project has > also a simple Gradle build that shows it works with Gradle as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1434) Upgrade PowerMock@Java9 to Version 2.0.0-beta.5
[ https://issues.apache.org/jira/browse/SUREFIRE-1434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325247#comment-16325247 ] Hudson commented on SUREFIRE-1434: -- ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/]) [SUREFIRE-1434] Upgrade PowerMock@Java9 to Version 2.0.0-beta.5 (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=cb3f66add503f61997c6c7e6f2d16c394cc30b8a]) * (edit) surefire-booter/src/test/java/org/apache/maven/surefire/booter/SystemUtilsTest.java * (edit) pom.xml * (edit) surefire-booter/pom.xml > Upgrade PowerMock@Java9 to Version 2.0.0-beta.5 > --- > > Key: SUREFIRE-1434 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1434 > Project: Maven Surefire > Issue Type: Dependency upgrade >Affects Versions: 2.20.1 >Reporter: Tibor Digana >Assignee: Tibor Digana > Fix For: 2.21.0.Jigsaw > > > PowerMock 2.0.0-beta.5 works with Java 9. > This means that the embedded test {{SystemUtilsTest.MockTest}} does not have > to be ignored with JUnit annotation @Ignore. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1445) Properties from configuration POM are not passed to Provider on JDK 9
[ https://issues.apache.org/jira/browse/SUREFIRE-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325253#comment-16325253 ] Hudson commented on SUREFIRE-1445: -- ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/]) [SUREFIRE-1445] Explicitly define SurefireProperties#putAll (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=302094ef2a7103d1a72b798443995a7d2b3b6702]) * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java * (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/SurefirePropertiesTest.java > Properties from configuration POM are not passed to Provider on JDK 9 > - > > Key: SUREFIRE-1445 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1445 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Failsafe Plugin, Maven Surefire Plugin >Affects Versions: 2.19.1, 2.20, 2.20.1 > Environment: JDK 9 >Reporter: Marc Philipp >Assignee: Tibor Digana >Priority: Blocker > Fix For: 2.21.0.Jigsaw > > > Given the POM below, the {{JUnitPlatformProvider}} can read {{"excludeTags"}} > = {{"slow"}} from {{ProviderParameters.getProviderProperties()}} when it runs > on JDK 8 but not on JDK 9. > The reason is that the constructor of {{SurefireProperties}} relies on an > implementation detail of the class it extends, namely that {{putAll()}} will > call {{put()}} for each entry. However, while {{Properties}} does that on JDK > 8, it doesn't on JDK 9. > Here's a link to the line in {{SurefireProperties}}: > https://github.com/apache/maven-surefire/blob/master/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java#L62 > {code:xml} > > http://maven.apache.org/POM/4.0.0; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; > xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 > http://maven.apache.org/xsd/maven-4.0.0.xsd;> > 4.0.0 > junit5 > tagging > 1.0-SNAPSHOT > > > > maven-surefire-plugin > 2.19.1 > > > slow > > > > > org.junit.platform > > junit-platform-surefire-provider > 1.0.2 > > > org.junit.jupiter > junit-jupiter-engine > 5.0.2 > > > > > > > > org.junit.jupiter > junit-jupiter-api > 5.0.2 > test > > > > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1412) Findbugs plugin fails - Update maven-parent to Version 30 and downgrade maven-site-plugin
[ https://issues.apache.org/jira/browse/SUREFIRE-1412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325244#comment-16325244 ] Hudson commented on SUREFIRE-1412: -- ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/]) [SUREFIRE-1412] Findbugs plugin fails - Update maven-parent to Version (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=b8eb673627e5d73d0e3d0dfdd639f257e10536ea]) * (edit) pom.xml > Findbugs plugin fails - Update maven-parent to Version 30 and downgrade > maven-site-plugin > - > > Key: SUREFIRE-1412 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1412 > Project: Maven Surefire > Issue Type: Bug >Affects Versions: 2.20 >Reporter: Tibor Digana >Assignee: Tibor Digana > Fix For: 2.20.1 > > > The solution is to Update :maven-parent:26 to Version 30. > Consequently after the update Fluido 1.3.0 fails [1] and the solution is to > downgrage maven-site-plugin:3.5.1 to 3.4. > [1]: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-site-plugin:3.6:site (default-site) on project > surefire: Velocity parsing error while reading the site decoration template > from org.apache.maven.skins:maven-fluido-skin:jar:1.4 skin: Encountered > "source" at META-INF/maven/site.vm[line 1162, column 52] > [ERROR] Was expecting one of: > [ERROR] "," ... > [ERROR] ")" ... > [ERROR] ... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1455) JaCoCo on integration tests
[ https://issues.apache.org/jira/browse/SUREFIRE-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325266#comment-16325266 ] Hudson commented on SUREFIRE-1455: -- ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/]) [SUREFIRE-1455] JaCoCo on integration tests (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=27a5e6aeba83b8a00924a2457652651a298ee0a1]) * (edit) surefire-integration-tests/pom.xml * (edit) pom.xml * (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fixture/SurefireLauncher.java * (edit) surefire-integration-tests/src/test/resources/testng-simple/pom.xml * (edit) surefire-integration-tests/src/test/resources/junit47-parallel/pom.xml > JaCoCo on integration tests > --- > > Key: SUREFIRE-1455 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1455 > Project: Maven Surefire > Issue Type: Task >Reporter: Tibor Digana >Assignee: Tibor Digana > Fix For: 2.21.0.Jigsaw > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1422) Forking fails on Linux if /bin/ps isn't available
[ https://issues.apache.org/jira/browse/SUREFIRE-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325246#comment-16325246 ] Hudson commented on SUREFIRE-1422: -- ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/]) [SUREFIRE-1422] Forking fails on Linux if /bin/ps isn't available (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=1c707717f87c2179fb7a2f650217f70b0edd13e7]) * (edit) surefire-booter/src/test/java/org/apache/maven/surefire/booter/PpidCheckerTest.java * (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/PpidChecker.java > Forking fails on Linux if /bin/ps isn't available > - > > Key: SUREFIRE-1422 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1422 > Project: Maven Surefire > Issue Type: Bug > Components: process forking >Affects Versions: 2.20.1 > Environment: Linux (Debian 9 with OpenJDK 8) >Reporter: Emmanuel Bourg >Assignee: Tibor Digana > Fix For: 2.21.0.Jigsaw > > > Hi, > With the changes introduced by SUREFIRE-1302 I'm now experiencing a failure > on Linux when the fork mode is enabled: > {code} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test (default-test) on > project foo: There are test failures. > [ERROR] > [ERROR] Please refer to /foo/target/surefire-reports for the individual test > results. > [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump, > [date].dumpstream and [date]-jvmRun[N].dumpstream. > [ERROR] The forked VM terminated without properly saying goodbye. VM crash or > System.exit called? > {code} > I traced the issue back to the PpidChecker class, the code assumes that > {{/bin/ps}} or {{/usr/bin/ps}} exist but this isn't guaranteed (especially on > trimmed down containers commonly used for continuous integration). > It would be nice to have a fallback mechanism when ps isn't available, or at > least check its existence and display an explicit message stating that it > must be installed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1409) Parallel runner should not drop away runners that have zero children.
[ https://issues.apache.org/jira/browse/SUREFIRE-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325241#comment-16325241 ] Hudson commented on SUREFIRE-1409: -- ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/]) [SUREFIRE-1409] Parallel runner should not drop away runners that have (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=67c06d5876dcabc037de9b5f4cc226beeedcb379]) * (edit) surefire-providers/surefire-junit47/src/test/java/org/apache/maven/surefire/junitcore/pc/ParallelComputerBuilderTest.java * (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/pc/ParallelComputerBuilder.java > Parallel runner should not drop away runners that have zero children. > - > > Key: SUREFIRE-1409 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1409 > Project: Maven Surefire > Issue Type: Improvement > Components: Junit 4.7+ (parallel) support >Reporter: Tibor Digana >Assignee: Tibor Digana > Fix For: 2.20.1 > > > JUnit does not force runners to include all child tests in Description. > Therefore Parallel Runner should not throw such tests away. > For example Spock does not report parametrized tests. > [https://github.com/spockframework/spock/pull/558] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1436) Increase usability in quiet mode
[ https://issues.apache.org/jira/browse/SUREFIRE-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325250#comment-16325250 ] Hudson commented on SUREFIRE-1436: -- ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/]) [SUREFIRE-1436] Increase usability in quiet mode (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=17c18e5209cf1544f7ace31e99573e65a135bb60]) * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java * (edit) surefire-logger-api/src/main/java/org/apache/maven/plugin/surefire/log/api/NullConsoleLogger.java * (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/report/DefaultReporterFactoryTest.java * (edit) surefire-logger-api/src/main/java/org/apache/maven/plugin/surefire/log/api/PrintStreamLogger.java * (edit) surefire-providers/surefire-junit47/src/test/java/org/apache/maven/surefire/junitcore/DefaultConsoleReporter.java * (edit) surefire-logger-api/src/main/java/org/apache/maven/plugin/surefire/log/api/ConsoleLoggerDecorator.java * (edit) surefire-report-parser/src/test/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParserTest.java * (edit) maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/PluginConsoleLogger.java * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/log/PluginConsoleLogger.java * (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/MockReporter.java * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/output/ForkClient.java * (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/ForkingRunListener.java * (edit) surefire-logger-api/src/main/java/org/apache/maven/plugin/surefire/log/api/ConsoleLogger.java [SUREFIRE-1436] Increase usability in quiet mode (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=660a4cfab8bf78d8db42aa6cfc3366d8806035a0]) * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/log/PluginConsoleLogger.java * (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/MockReporter.java * (edit) surefire-logger-api/src/main/java/org/apache/maven/plugin/surefire/log/api/NullConsoleLogger.java * (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/report/DefaultReporterFactoryTest.java * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkStarter.java * (edit) maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java * (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/ForkingRunListenerTest.java * (edit) surefire-logger-api/src/main/java/org/apache/maven/plugin/surefire/log/api/ConsoleLoggerDecorator.java * (edit) surefire-report-parser/src/test/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParserTest.java * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java * (edit) maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/PluginConsoleLogger.java * (edit) surefire-logger-api/src/main/java/org/apache/maven/plugin/surefire/log/api/PrintStreamLogger.java * (edit) surefire-logger-api/src/main/java/org/apache/maven/plugin/surefire/log/api/ConsoleLogger.java * (delete) surefire-providers/surefire-junit47/src/test/java/org/apache/maven/surefire/junitcore/DefaultConsoleReporter.java * (edit) surefire-api/src/main/java/org/apache/maven/surefire/booter/ForkingRunListener.java * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/output/ForkClient.java * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java > Increase usability in quiet mode > > > Key: SUREFIRE-1436 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1436 > Project: Maven Surefire > Issue Type: Wish >Affects Versions: 2.20, 2.20.1 >Reporter: Zoltan Haindrich >Assignee: Tibor Digana > Fix For: 2.21.0.Jigsaw > > > Prior to SUREFIRE-1436. The messages which were closely related to test > execution were printed directly to the console instead of the logger.info > https://github.com/apache/maven-surefire/commit/6a79127ab63273f0f1f5268c65e4806761871a46#diff-94128f02ad41a51dcab77c0e0756705fL136 > I always execute maven with `-q` because of the high volume of irrelevant > messages it prints out. > I miss the following messages when silent mode is active: > {code} > Running org.apache.hadoop.hive.cli.TestMiniLlapCliDriver > Tests run: 0, Failures: 0, Errors: 0, Skipped: 0,
[jira] [Commented] (SUREFIRE-1443) surefire report: broken links with inner classes
[ https://issues.apache.org/jira/browse/SUREFIRE-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325255#comment-16325255 ] Hudson commented on SUREFIRE-1443: -- ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/]) [SUREFIRE-1443] surefire report: broken links with inner classes (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=47af38f54e20beeac1c98202521157c5e1d4d8df]) * (edit) maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java * (edit) maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/SurefireReportMojoTest.java * (edit) maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/Surefire597Test.java > surefire report: broken links with inner classes > - > > Key: SUREFIRE-1443 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1443 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Report Plugin >Affects Versions: 2.20.1 > Environment: linux >Reporter: Ernst Reissner >Assignee: Tibor Digana >Priority: Minor > Fix For: 2.21.0.Jigsaw > > Attachments: RelanaTest.java, surefire-report.html > > > pom: > > org.apache.maven.plugins > maven-surefire-report-plugin > 2.20.1 > > > false > > > testclass as attached. > Then tying mvn surefire-report:report > yields waning > [warn] [XHTML Sink] Modified invalid anchor name: > 'eu.simuline.relana.sysRelanaTest$TestAll' to > 'eu.simuline.relana.sysRelanaTestTestAll' > and in the created html this can be seen: > dot between sys and RelanaTest missing. > Partially with $ , partially without so that links are broken > I attached also the hmtl. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1372) Rerunning failing tests fails in combination with Description#createSuiteDescription
[ https://issues.apache.org/jira/browse/SUREFIRE-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325263#comment-16325263 ] Hudson commented on SUREFIRE-1372: -- ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/]) [SUREFIRE-1372] Rerunning failing tests fails in combination with (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=0a81c48971e3ee4b79b0858be7b8f4b13ece7287]) * (add) surefire-integration-tests/src/test/resources/junit47-rerun-failing-tests-with-cucumber/src/test/java/org/sample/cucumber/FlakeCucumberTest.java * (add) maven-surefire-plugin/src/site/apt/examples/cucumber.apt.vm * (edit) surefire-providers/common-junit4/src/main/java/org/apache/maven/surefire/common/junit4/JUnit4ProviderUtil.java * (delete) surefire-providers/common-junit48/src/main/java/org/apache/maven/surefire/common/junit48/FailingMethodFilter.java * (edit) surefire-providers/common-junit48/src/main/java/org/apache/maven/surefire/common/junit48/FilterFactory.java * (edit) maven-surefire-plugin/src/site/apt/examples/rerun-failing-tests.apt.vm * (edit) surefire-providers/common-junit4/src/test/java/org/apache/maven/surefire/common/junit4/JUnit4ProviderUtilTest.java * (edit) surefire-providers/surefire-junit4/src/main/java/org/apache/maven/surefire/junit4/JUnit4Provider.java * (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/JUnitCoreProvider.java * (add) surefire-integration-tests/src/test/resources/junit47-rerun-failing-tests-with-cucumber/src/test/resources/org/sample/cucumber/Sample.feature * (add) surefire-integration-tests/src/test/resources/junit47-rerun-failing-tests-with-cucumber/pom.xml * (edit) maven-surefire-plugin/src/site/site.xml * (add) surefire-integration-tests/src/test/resources/junit47-rerun-failing-tests-with-cucumber/src/test/java/org/sample/cucumber/StepDefs.java * (add) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/JUnit47RerunFailingTestWithCucumberIT.java * (add) surefire-providers/common-junit4/src/main/java/org/apache/maven/surefire/common/junit4/MatchDescriptions.java > Rerunning failing tests fails in combination with > Description#createSuiteDescription > > > Key: SUREFIRE-1372 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1372 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.20 >Reporter: M.P. Korstanje >Assignee: Tibor Digana > Fix For: 2.21.0.Jigsaw > > > When using surefire to rerun failing tests created by a Runner that uses > {noformat}Description#createSuiteDescription{noformat} with a human readable > name rather then a class name the following stack trace occurs: > {code} > org.apache.maven.surefire.testset.TestSetFailedException: Unable to create > test class 'Scenario: Fail when running' > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeFailedMethod(JUnit4Provider.java:385) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:292) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:161) > Caused by: java.lang.ClassNotFoundException: Scenario: Fail when running > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeFailedMethod(JUnit4Provider.java:379) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:292) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:161) > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1453) Allow to specify non existant classes as "groups"
[ https://issues.apache.org/jira/browse/SUREFIRE-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325260#comment-16325260 ] Hudson commented on SUREFIRE-1453: -- ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/]) [SUREFIRE-1453] Allow to specify non existant classes as groups (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=9826145dfea0e23894e2df48f64dd20a5d465c85]) * (edit) surefire-grouper/src/test/java/org/apache/maven/surefire/group/match/SingleGroupMatcherTest.java * (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/JUnit48TestCategoriesIT.java * (edit) surefire-grouper/src/main/java/org/apache/maven/surefire/group/match/SingleGroupMatcher.java > Allow to specify non existant classes as "groups" > - > > Key: SUREFIRE-1453 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1453 > Project: Maven Surefire > Issue Type: Improvement > Components: classloading, Junit 4.7+ (parallel) support, Junit 4.x > support, Maven Failsafe Plugin, Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Enrico Olivelli >Assignee: Tibor Digana >Priority: Critical > Fix For: 2.21.0.Jigsaw > > > In a reactor project I would like to run only a subset of JUnit (4.12) tests > tagged with @Category > But the class which defines the category is not present in the dependency > tree of every module. > I get this error. > I would like to simply skip these modules, maybe in conjunction with the > failIfNoTest=false option > {code:java} > rg.apache.maven.surefire.util.SurefireReflectionException: > java.lang.reflect.InvocationTargetException; nested exception is > java.lang.reflect.InvocationTargetException: null > java.lang.reflect.InvocationTargetException > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189) > at > org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165) > at > org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85) > at > org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115) > at > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75) > Caused by: java.lang.RuntimeException: Unable to load category: > magnews.testgroups.MinimumAcceptance > at > org.apache.maven.surefire.group.match.SingleGroupMatcher.loadGroupClasses(SingleGroupMatcher.java:134) > at > org.apache.maven.surefire.common.junit48.FilterFactory.createGroupFilter(FilterFactory.java:92) > at > org.apache.maven.surefire.junitcore.JUnitCoreProvider.createJUnit48Filter(JUnitCoreProvider.java:183) > at > org.apache.maven.surefire.junitcore.JUnitCoreProvider.invoke(JUnitCoreProvider.java:115) > ... 9 more > Caused by: java.lang.ClassNotFoundException: > magnews.testgroups.MinimumAcceptance > at java.net.URLClassLoader.findClass(URLClassLoader.java:381) > at java.lang.ClassLoader.loadClass(ClassLoader.java:424) > at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331) > at java.lang.ClassLoader.loadClass(ClassLoader.java:357) > at > org.apache.maven.surefire.group.match.SingleGroupMatcher.loadGroupClasses(SingleGroupMatcher.java:130) > ... 12 more > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (MNG-6339) Tar gzip binary MD5 sum mismatch
[ https://issues.apache.org/jira/browse/MNG-6339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MNG-6339. Resolution: Not A Problem Hi, no problem. Better checking. So I close the issue. Don't hesitate to open a new issue if you have problems.. > Tar gzip binary MD5 sum mismatch > > > Key: MNG-6339 > URL: https://issues.apache.org/jira/browse/MNG-6339 > Project: Maven > Issue Type: Bug >Affects Versions: 3.5.2 >Reporter: Sam Simmons >Priority: Trivial > > The MD5 sum does not match the tar gzip binary in > http://archive.apache.org/dist/maven/maven-3/3.5.2/binaries/. It looks like > both the md5 and shasum were updated 3 days after the archives were added. > Please upload the correct checksums. > Provided MD5 sum 948110de4aab290033c23bf4894f7d9a > apache-maven-3.5.2-bin.tar.gz.md5 > Actual MD5 sum 6edf85f3e282e248db38b44ceb123bd0 apache-maven-3.5.2-bin.tar.gz > Thanks! -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1461) UnicodeTestNamesIT should be able to run multiple times
[ https://issues.apache.org/jira/browse/SUREFIRE-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325265#comment-16325265 ] Hudson commented on SUREFIRE-1461: -- ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/]) [SUREFIRE-1461] UnicodeTestNamesIT should be able to run multiple times (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=2c5c59452c4034bd06a6d7e0212a4f7ac0ee54d5]) * (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/UnicodeTestNamesIT.java > UnicodeTestNamesIT should be able to run multiple times > --- > > Key: SUREFIRE-1461 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1461 > Project: Maven Surefire > Issue Type: Task >Reporter: Tibor Digana >Assignee: Tibor Digana >Priority: Minor > Labels: integration-test > Fix For: 2.21.0.Jigsaw > > > UnicodeTestNamesIT runs only after {{mvn clean}}. > It should have more assertion statements on XML report. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1435) Improve Thread Dump. Use prefix "surefire-forkedjvm" in daemon Threads in forked JVM
[ https://issues.apache.org/jira/browse/SUREFIRE-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325248#comment-16325248 ] Hudson commented on SUREFIRE-1435: -- ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/]) [SUREFIRE-1435] Improve Thread Dump. Use prefix "surefire-forkedjvm" in (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=198ef48af094e3de7f132e03da9b70d0da5b246e]) * (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java > Improve Thread Dump. Use prefix "surefire-forkedjvm" in daemon Threads in > forked JVM > > > Key: SUREFIRE-1435 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1435 > Project: Maven Surefire > Issue Type: Improvement > Components: process forking >Reporter: Tibor Digana >Assignee: Tibor Digana >Priority: Minor > Fix For: 2.21.0.Jigsaw > > > Thread Dump contains threads but it is not clear which ones belong to > Surefire. > Use prefix "surefire-forkedjvm" in daemon Threads in forked JVM. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1403) [Jigsaw] [Java 9] add "--add-modules java.se.ee" to forked CLI argument
[ https://issues.apache.org/jira/browse/SUREFIRE-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325238#comment-16325238 ] Hudson commented on SUREFIRE-1403: -- ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/]) [SUREFIRE-1403] [Jigsaw] [Java 9] add "--add-modules ALL-SYSTEM" to (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=578ada73b724151f0cbce3b6ae39e55d242ef430]) * (add) surefire-booter/src/test/resources/jdk/bin/java * (edit) maven-surefire-common/pom.xml * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java * (edit) maven-failsafe-plugin/src/test/resources/org/apache/maven/plugin/failsafe/failsafe-summary.xml * (edit) surefire-api/pom.xml * (add) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/JdkAttributes.java * (edit) surefire-booter/pom.xml * (add) surefire-integration-tests/src/test/resources/java9-full-api/pom.xml * (edit) README.md * (add) surefire-booter/src/test/resources/jdk8-oracle/release * (add) surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9IT.java * (delete) maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/JAXB.java * (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerStartupConfigurationTest.java * (add) surefire-booter/src/test/resources/jdk8-IBM/release * (edit) maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java * (edit) pom.xml * (add) surefire-booter/src/test/resources/jdk/jre/bin/java * (edit) maven-surefire-plugin/src/site/site.xml * (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemUtils.java * (delete) maven-surefire-plugin/src/site/resources/xsd/failsafe-summary.xjb * (add) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java * (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1265Java9IT.java * (edit) surefire-setup-integration-tests/pom.xml * (edit) maven-failsafe-plugin/src/test/java/org/apache/maven/plugin/failsafe/MarshallerUnmarshallerTest.java * (edit) maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/FailsafeSummaryXmlUtils.java * (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/ForkConfigurationTest.java * (add) surefire-setup-integration-tests/src/main/resources/toolchains.xml * (add) maven-surefire-plugin/src/site/markdown/java9.md * (add) surefire-integration-tests/src/test/resources/java9-full-api/src/test/java/J9Test.java * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java * (add) surefire-booter/src/test/resources/jdk9-oracle/release * (edit) maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java * (edit) maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/booterclient/BooterDeserializerProviderConfigurationTest.java * (edit) maven-surefire-plugin/pom.xml * (edit) surefire-booter/src/test/java/org/apache/maven/surefire/booter/SystemUtilsTest.java * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java * (edit) maven-failsafe-plugin/pom.xml * (edit) surefire-integration-tests/pom.xml * (edit) maven-failsafe-plugin/src/test/java/org/apache/maven/plugin/failsafe/RunResultTest.java * (add) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/AbstractJigsawIT.java [Agreed with Oracle] [SUREFIRE-1403] [Jigsaw] [Java 9] add (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=0635d25e9d273c48196c1c9cb40eefc38393daba]) * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkConfiguration.java [Agreed with Oracle] [SUREFIRE-1403] [DOC] [Jigsaw] [Java 9] add (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=100f696029a53d57dbacd0f3962f3c305891588c]) * (edit) maven-surefire-plugin/src/site/markdown/java9.md > [Jigsaw] [Java 9] add "--add-modules java.se.ee" to forked CLI argument > --- > > Key: SUREFIRE-1403 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1403 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Failsafe Plugin, Maven Surefire Plugin >Reporter: Tibor Digana >Assignee: Tibor Digana > Fix For: 2.20.1 > > Attachments: surefire-1403.zip > > > Calling *findClass( cls, "java.se.ee")* in *IsolatedClassLoader* does not > help and does not do anything because the module is ignored in Java 9. > In-plugin provider does
[jira] [Commented] (SUREFIRE-1264) Some tests can be lost when running in parallel with parameterized tests
[ https://issues.apache.org/jira/browse/SUREFIRE-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325240#comment-16325240 ] Hudson commented on SUREFIRE-1264: -- ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/]) [SUREFIRE-1264] Some tests can be lost when running in parallel with (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=c8724dd2f992625c355e4817a6b7995d3e88fdb4]) * (add) surefire-integration-tests/src/test/resources/surefire-1264/src/test/java/com/appnexus/viewability/core/surefireJunitTests/ATest.java * (add) surefire-integration-tests/src/test/resources/surefire-1264/src/test/java/com/appnexus/viewability/core/surefireJunitTests/BaseTest.java * (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/TestSet.java * (edit) surefire-integration-tests/src/test/resources/surefire-621-testCounting-junit3-in-parallel/pom.xml * (edit) surefire-api/src/main/java/org/apache/maven/surefire/util/internal/TestClassMethodNameUtils.java * (add) surefire-integration-tests/src/test/resources/surefire-1264/src/test/java/com/appnexus/viewability/core/surefireJunitTests/CTest.java * (add) surefire-integration-tests/src/test/resources/surefire-621-testCounting-junit3-in-parallel/src/it/java/mho/JUnit4AdapterSuiteTest.java * (add) surefire-integration-tests/src/test/resources/surefire-1264/src/test/java/com/appnexus/viewability/core/surefireJunitTests/BTest.java * (edit) surefire-providers/surefire-junit47/src/test/java/org/apache/maven/surefire/junitcore/TestMethodTest.java * (edit) surefire-providers/common-junit4/src/main/java/org/apache/maven/surefire/junit4/MockReporter.java * (add) surefire-integration-tests/src/test/resources/surefire-1264/src/test/java/com/appnexus/viewability/core/surefireJunitTests/DTest.java * (edit) surefire-providers/common-junit4/src/main/java/org/apache/maven/surefire/common/junit4/JUnit4RunListener.java * (add) surefire-integration-tests/src/test/resources/surefire-1264/pom.xml * (add) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1264IT.java * (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/ConcurrentRunListener.java * (edit) surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/JUnitCoreRunListener.java * (edit) surefire-providers/surefire-junit47/src/test/java/org/apache/maven/surefire/junitcore/JUnitCoreRunListenerTest.java * (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire621TestCountingJunit3InParallelIT.java > Some tests can be lost when running in parallel with parameterized tests > > > Key: SUREFIRE-1264 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1264 > Project: Maven Surefire > Issue Type: Bug > Components: Junit 4.7+ (parallel) support >Affects Versions: 2.19.1 > Environment: Maven 3.3.9 > Java 1.8.0_45 (Oracle) > System: OS X > Reproduced on Linux too, with both OpenJDK 7 and Java 7 from Oracle. >Reporter: Jean-Luc Derrien >Assignee: Tibor Digana > Fix For: 2.20.1 > > Attachments: failure-2.21-snapshot-SUREFIRE-1264.zip, pom.xml > > Time Spent: 144h > Remaining Estimate: 24h > > Hello, > It appears some tests can be lost when using the parallel mode with > parameterized tests. Here is a [small > project|https://github.com/jderrien/surefire-junit-tests/tree/simple-1] I've > used to try to reproduce the issue we have seen. > This is not something that happens on every run, but it's quite frequent. > With this loop, the problem should appear in less than 2 minutes, maybe on > the first run when (un)lucky: > {code} > time while true; do mvn clean test > last.log ; tail -25 last.log ; if [ > "$(grep -c 'Tests run: 12' last.log)" == "0" ]; then break; fi ; done > {code} > Normal run: > {noformat} > --- > T E S T S > --- > Running [p2] > com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p2] - p2 - > sleeptime = 1 => start > com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p2] - p2 - > sleeptime = 1 => stop > com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p1] - p1 - > sleeptime = 2 => start > com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p1] - p1 - > sleeptime = 2 => stop > com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p0] - p0 - > sleeptime = 5 => start > com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p0] - p0 - > sleeptime = 5 => stop > Tests run: 6, Failures: 0, Errors: 0,
[jira] [Commented] (SUREFIRE-1396) Provider class path is incorrect for custom provider in Failsafe
[ https://issues.apache.org/jira/browse/SUREFIRE-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325239#comment-16325239 ] Hudson commented on SUREFIRE-1396: -- ABORTED: Integrated in Jenkins build maven-surefire-dev #103 (See [https://builds.apache.org/job/maven-surefire-dev/103/]) [SUREFIRE-1396] Provider class path is incorrect for custom provider in (jon: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=99cd4f65f5f04ed8c98f446850f5f8bd7b98fc64]) * (add) surefire-integration-tests/src/test/resources/surefire-1396-pluggableproviders-classpath-provider/pom.xml * (edit) maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java * (add) surefire-integration-tests/src/test/resources/surefire-1396-pluggableproviders-classpath/src/test/java/pluggableproviders/EmptyTest.java * (edit) maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java * (add) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1396CustomProviderClassPathIT.java * (edit) maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java * (add) surefire-integration-tests/src/test/resources/surefire-1396-pluggableproviders-classpath/pom.xml * (add) surefire-integration-tests/src/test/resources/surefire-1396-pluggableproviders-classpath-provider/src/main/resources/META-INF/services/org.apache.maven.surefire.providerapi.SurefireProvider * (add) surefire-integration-tests/src/test/resources/surefire-1396-pluggableproviders-classpath-provider/src/main/java/org/apache/maven/surefire/testprovider/ClassPathTestProvider.java * (add) surefire-integration-tests/src/test/resources/surefire-1396-pluggableproviders-classpath/src/test/java/pluggableproviders/EmptyIT.java > Provider class path is incorrect for custom provider in Failsafe > > > Key: SUREFIRE-1396 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1396 > Project: Maven Surefire > Issue Type: Bug >Reporter: Jonathan Bell >Assignee: Tibor Digana > Fix For: 2.20.1 > > > Hi, > When using a custom Surefire provider with Surefire (not Failsafe), the > "provider classpath" contains only the provider and surefire-api. However, > when using a custom provider with Failsafe, the provider class path ends up > including a lot more... it seems like perhaps all plugins that are loaded? > This has caused some mayhem for me when using a custom provider in projects > that use a specific version of SLF4J... because then failsafe forces 1.5.6 to > be loaded (from this process of incorrectly finding the custom provider), > causing a crash. > It is a simple fix (3 lines in AbstractSurefireMojo - it had the name of the > Surefire plugin hardcoded, which isn't correct when it's actually Failsafe). > I've got a patched fork of master on GitHub > (https://github.com/jon-bell/maven-surefire/commit/04f66cdd828d131a028eb400d1ed26fe104fe3f2) > that fixes it and an integration test that demonstrates the flaw. I am not > 100% sure on the formatting of the integration test (i.e., I am opening a > JIRA ticket so that I suppose I can name it under the JIRA issue? How should > I specify the current version of surefire in the integration test package?) - > if the fix is welcome against master I'd be happy to open a PR on GitHub. I > am also happy to merge against a different branch if it's more helpful. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MNG-6339) Tar gzip binary MD5 sum mismatch
[ https://issues.apache.org/jira/browse/MNG-6339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325223#comment-16325223 ] Sam Simmons commented on MNG-6339: -- Sorry guys. After restarting my machine it's matching. Also could not reproduce on another machine. Thanks for the quick response! > Tar gzip binary MD5 sum mismatch > > > Key: MNG-6339 > URL: https://issues.apache.org/jira/browse/MNG-6339 > Project: Maven > Issue Type: Bug >Affects Versions: 3.5.2 >Reporter: Sam Simmons >Priority: Trivial > > The MD5 sum does not match the tar gzip binary in > http://archive.apache.org/dist/maven/maven-3/3.5.2/binaries/. It looks like > both the md5 and shasum were updated 3 days after the archives were added. > Please upload the correct checksums. > Provided MD5 sum 948110de4aab290033c23bf4894f7d9a > apache-maven-3.5.2-bin.tar.gz.md5 > Actual MD5 sum 6edf85f3e282e248db38b44ceb123bd0 apache-maven-3.5.2-bin.tar.gz > Thanks! -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MRELEASE-956) Release Strategy Interface
[ https://issues.apache.org/jira/browse/MRELEASE-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325205#comment-16325205 ] Markus Karg commented on MRELEASE-956: -- Understood. But still I have concerns: * Your strategy enforces the paradigm that a release is always flollowing a flat list of phases. In the real world, there might be organizations having rather complex organizational processes which are neither flat nor linear, including branches and loops. For example, there even could be parallel tasks that have be successful before the next step, or a step must be repeated, etc. This seems to be impossible with your model (or at least I it is so complex that I did not understand it by the first look), while it is simple with mine. * * Due to your enforced lilst-of-phases-plus-hints design implementing a custom release strategy becomes a rather complex task: One has to be rather experienced with Maven / Plugin internals and data structures. Implementing my strategy instead is possible even for programming beginners one has to implement "onRelease" and can do what he want; only if he wants to call Maven he has to learn about Maven APIs. > Release Strategy Interface > -- > > Key: MRELEASE-956 > URL: https://issues.apache.org/jira/browse/MRELEASE-956 > Project: Maven Release Plugin > Issue Type: New Feature > Components: perform >Reporter: Markus Karg >Assignee: Robert Scholte > Labels: strategy > Fix For: 3.0.0 > > > The release plugin has built-in strategies for preparation and performing of > a release. For example, the strategy for preparation contains increasing > versions numbers, comitting to SCM, tagging in SCM, and so. > Not all users share the same strategies in real life. For example, some > companies might want to have a tag AND and a branch created in SCM when > preparing a release. Or other companies might want to have tag created for > "prepared-release-1.0.0" at preparation, and replace it by "release-1.0.0" as > part of release:perform. > To provide better flexibility of such company-wide strategies, it might be a > solution to introduce an interface "ReleaseStrategy" which acts as a worker > for the prepare and perform goals (and possibly others). The current built-in > strategy could be refactored to be a default-included > "DefaultReleaseStrategy" for backwards compatibility, while users could > configure a new property "releaseStrategy" to point to an Extension which > provides a differently working strategy. > To make this work, certainly the Strategy implementation needs to get passed > a context which allows to fire actions like "tag version", "create branch", > "change pom version" and so on, just as the current built-in strategy has. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1455) JaCoCo on integration tests
[ https://issues.apache.org/jira/browse/SUREFIRE-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325203#comment-16325203 ] Hudson commented on SUREFIRE-1455: -- SUCCESS: Integrated in Jenkins build maven-surefire #1826 (See [https://builds.apache.org/job/maven-surefire/1826/]) [SUREFIRE-1455] JaCoCo on integration tests (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=27a5e6aeba83b8a00924a2457652651a298ee0a1]) * (edit) surefire-integration-tests/src/test/resources/testng-simple/pom.xml * (edit) pom.xml * (edit) surefire-integration-tests/pom.xml * (edit) surefire-integration-tests/src/test/resources/junit47-parallel/pom.xml * (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fixture/SurefireLauncher.java > JaCoCo on integration tests > --- > > Key: SUREFIRE-1455 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1455 > Project: Maven Surefire > Issue Type: Task >Reporter: Tibor Digana >Assignee: Tibor Digana > Fix For: 2.21.0.Jigsaw > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MRELEASE-956) Release Strategy Interface
[ https://issues.apache.org/jira/browse/MRELEASE-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325186#comment-16325186 ] Robert Scholte commented on MRELEASE-956: - My implementation allows you to define your implementation of ReleasePhases. So you can create a ReleasePhase with the hint "update-issue-tracker", implement it and add it to your custom strategy. > Release Strategy Interface > -- > > Key: MRELEASE-956 > URL: https://issues.apache.org/jira/browse/MRELEASE-956 > Project: Maven Release Plugin > Issue Type: New Feature > Components: perform >Reporter: Markus Karg >Assignee: Robert Scholte > Labels: strategy > Fix For: 3.0.0 > > > The release plugin has built-in strategies for preparation and performing of > a release. For example, the strategy for preparation contains increasing > versions numbers, comitting to SCM, tagging in SCM, and so. > Not all users share the same strategies in real life. For example, some > companies might want to have a tag AND and a branch created in SCM when > preparing a release. Or other companies might want to have tag created for > "prepared-release-1.0.0" at preparation, and replace it by "release-1.0.0" as > part of release:perform. > To provide better flexibility of such company-wide strategies, it might be a > solution to introduce an interface "ReleaseStrategy" which acts as a worker > for the prepare and perform goals (and possibly others). The current built-in > strategy could be refactored to be a default-included > "DefaultReleaseStrategy" for backwards compatibility, while users could > configure a new property "releaseStrategy" to point to an Extension which > provides a differently working strategy. > To make this work, certainly the Strategy implementation needs to get passed > a context which allows to fire actions like "tag version", "create branch", > "change pom version" and so on, just as the current built-in strategy has. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MRELEASE-956) Release Strategy Interface
[ https://issues.apache.org/jira/browse/MRELEASE-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325179#comment-16325179 ] Markus Karg commented on MRELEASE-956: -- Looking at you code I do not see much similarity with what I proposed. Your strategy interface simply allows to customize the phases to perform for each release action. What I proposed was an interface which allows complete freedom, e. g. even running a custom Groovy script which changes issue tracker entries etc. So I think your solution is too narrow. The idea of my ReleaseStrategy was that it is triggered to execute at a given point, and an implementation will in turn ask the Release Plugin to perform some actions in turn. Like "Strategy.onPrepare -> API.bumpVersion(Major + 1) then SQL: INSERT INTO ISSUE DATABASE"... etc. > Release Strategy Interface > -- > > Key: MRELEASE-956 > URL: https://issues.apache.org/jira/browse/MRELEASE-956 > Project: Maven Release Plugin > Issue Type: New Feature > Components: perform >Reporter: Markus Karg >Assignee: Robert Scholte > Labels: strategy > Fix For: 3.0.0 > > > The release plugin has built-in strategies for preparation and performing of > a release. For example, the strategy for preparation contains increasing > versions numbers, comitting to SCM, tagging in SCM, and so. > Not all users share the same strategies in real life. For example, some > companies might want to have a tag AND and a branch created in SCM when > preparing a release. Or other companies might want to have tag created for > "prepared-release-1.0.0" at preparation, and replace it by "release-1.0.0" as > part of release:perform. > To provide better flexibility of such company-wide strategies, it might be a > solution to introduce an interface "ReleaseStrategy" which acts as a worker > for the prepare and perform goals (and possibly others). The current built-in > strategy could be refactored to be a default-included > "DefaultReleaseStrategy" for backwards compatibility, while users could > configure a new property "releaseStrategy" to point to an Extension which > provides a differently working strategy. > To make this work, certainly the Strategy implementation needs to get passed > a context which allows to fire actions like "tag version", "create branch", > "change pom version" and so on, just as the current built-in strategy has. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MRELEASE-956) Release Strategy Interface
[ https://issues.apache.org/jira/browse/MRELEASE-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325178#comment-16325178 ] Hudson commented on MRELEASE-956: - Build succeeded in Jenkins: Maven TLP » maven-release » master #30 See https://builds.apache.org/job/maven-box/job/maven-release/job/master/30/ > Release Strategy Interface > -- > > Key: MRELEASE-956 > URL: https://issues.apache.org/jira/browse/MRELEASE-956 > Project: Maven Release Plugin > Issue Type: New Feature > Components: perform >Reporter: Markus Karg >Assignee: Robert Scholte > Labels: strategy > Fix For: 3.0.0 > > > The release plugin has built-in strategies for preparation and performing of > a release. For example, the strategy for preparation contains increasing > versions numbers, comitting to SCM, tagging in SCM, and so. > Not all users share the same strategies in real life. For example, some > companies might want to have a tag AND and a branch created in SCM when > preparing a release. Or other companies might want to have tag created for > "prepared-release-1.0.0" at preparation, and replace it by "release-1.0.0" as > part of release:perform. > To provide better flexibility of such company-wide strategies, it might be a > solution to introduce an interface "ReleaseStrategy" which acts as a worker > for the prepare and perform goals (and possibly others). The current built-in > strategy could be refactored to be a default-included > "DefaultReleaseStrategy" for backwards compatibility, while users could > configure a new property "releaseStrategy" to point to an Extension which > provides a differently working strategy. > To make this work, certainly the Strategy implementation needs to get passed > a context which allows to fire actions like "tag version", "create branch", > "change pom version" and so on, just as the current built-in strategy has. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (SUREFIRE-1455) JaCoCo on integration tests
[ https://issues.apache.org/jira/browse/SUREFIRE-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1455. -- Resolution: Fixed https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git > JaCoCo on integration tests > --- > > Key: SUREFIRE-1455 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1455 > Project: Maven Surefire > Issue Type: Task >Reporter: Tibor Digana >Assignee: Tibor Digana > Fix For: 2.21.0.Jigsaw > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (MRELEASE-956) Release Strategy Interface
[ https://issues.apache.org/jira/browse/MRELEASE-956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MRELEASE-956. --- Resolution: Fixed Fix Version/s: 3.0.0 I've already implemented it after the huge cleanup for 3.0.0 :) Fixed in [bea23130c9cf66fbc21061822d185b331a2c93b3|https://gitbox.apache.org/repos/asf?p=maven-release.git;a=commit;h=bea23130c9cf66fbc21061822d185b331a2c93b3] > Release Strategy Interface > -- > > Key: MRELEASE-956 > URL: https://issues.apache.org/jira/browse/MRELEASE-956 > Project: Maven Release Plugin > Issue Type: New Feature > Components: perform >Reporter: Markus Karg >Assignee: Robert Scholte > Labels: strategy > Fix For: 3.0.0 > > > The release plugin has built-in strategies for preparation and performing of > a release. For example, the strategy for preparation contains increasing > versions numbers, comitting to SCM, tagging in SCM, and so. > Not all users share the same strategies in real life. For example, some > companies might want to have a tag AND and a branch created in SCM when > preparing a release. Or other companies might want to have tag created for > "prepared-release-1.0.0" at preparation, and replace it by "release-1.0.0" as > part of release:perform. > To provide better flexibility of such company-wide strategies, it might be a > solution to introduce an interface "ReleaseStrategy" which acts as a worker > for the prepare and perform goals (and possibly others). The current built-in > strategy could be refactored to be a default-included > "DefaultReleaseStrategy" for backwards compatibility, while users could > configure a new property "releaseStrategy" to point to an Extension which > provides a differently working strategy. > To make this work, certainly the Strategy implementation needs to get passed > a context which allows to fire actions like "tag version", "create branch", > "change pom version" and so on, just as the current built-in strategy has. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MRELEASE-956) Release Strategy Interface
[ https://issues.apache.org/jira/browse/MRELEASE-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325167#comment-16325167 ] Markus Karg commented on MRELEASE-956: -- Update: Did not find the time for the PR, apparently. If nobody else finds time earlier, I will look into that in May. > Release Strategy Interface > -- > > Key: MRELEASE-956 > URL: https://issues.apache.org/jira/browse/MRELEASE-956 > Project: Maven Release Plugin > Issue Type: New Feature > Components: perform >Reporter: Markus Karg >Assignee: Robert Scholte > Labels: strategy > > The release plugin has built-in strategies for preparation and performing of > a release. For example, the strategy for preparation contains increasing > versions numbers, comitting to SCM, tagging in SCM, and so. > Not all users share the same strategies in real life. For example, some > companies might want to have a tag AND and a branch created in SCM when > preparing a release. Or other companies might want to have tag created for > "prepared-release-1.0.0" at preparation, and replace it by "release-1.0.0" as > part of release:perform. > To provide better flexibility of such company-wide strategies, it might be a > solution to introduce an interface "ReleaseStrategy" which acts as a worker > for the prepare and perform goals (and possibly others). The current built-in > strategy could be refactored to be a default-included > "DefaultReleaseStrategy" for backwards compatibility, while users could > configure a new property "releaseStrategy" to point to an Extension which > provides a differently working strategy. > To make this work, certainly the Strategy implementation needs to get passed > a context which allows to fire actions like "tag version", "create branch", > "change pom version" and so on, just as the current built-in strategy has. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (MRELEASE-956) Release Strategy Interface
[ https://issues.apache.org/jira/browse/MRELEASE-956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte reassigned MRELEASE-956: --- Assignee: Robert Scholte > Release Strategy Interface > -- > > Key: MRELEASE-956 > URL: https://issues.apache.org/jira/browse/MRELEASE-956 > Project: Maven Release Plugin > Issue Type: New Feature > Components: perform >Reporter: Markus Karg >Assignee: Robert Scholte > Labels: strategy > > The release plugin has built-in strategies for preparation and performing of > a release. For example, the strategy for preparation contains increasing > versions numbers, comitting to SCM, tagging in SCM, and so. > Not all users share the same strategies in real life. For example, some > companies might want to have a tag AND and a branch created in SCM when > preparing a release. Or other companies might want to have tag created for > "prepared-release-1.0.0" at preparation, and replace it by "release-1.0.0" as > part of release:perform. > To provide better flexibility of such company-wide strategies, it might be a > solution to introduce an interface "ReleaseStrategy" which acts as a worker > for the prepare and perform goals (and possibly others). The current built-in > strategy could be refactored to be a default-included > "DefaultReleaseStrategy" for backwards compatibility, while users could > configure a new property "releaseStrategy" to point to an Extension which > provides a differently working strategy. > To make this work, certainly the Strategy implementation needs to get passed > a context which allows to fire actions like "tag version", "create branch", > "change pom version" and so on, just as the current built-in strategy has. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1004) Enhance pattern/wildcard capabilities for dependenciesToScan to GAVT
[ https://issues.apache.org/jira/browse/SUREFIRE-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325128#comment-16325128 ] ASF GitHub Bot commented on SUREFIRE-1004: -- Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/173 @bindul Then we have to support also other alternatives: `groupId:artifactId:version`, and `groupId:artifactId:packaging:version`. This means you have to, first of all, count `:` and call different private method/matcher for count=2, 3, 4 or 5. > Enhance pattern/wildcard capabilities for dependenciesToScan to GAVT > > > Key: SUREFIRE-1004 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1004 > Project: Maven Surefire > Issue Type: Improvement > Components: Maven Failsafe Plugin, Maven Surefire Plugin >Affects Versions: 2.15 >Reporter: Andreas Gudian > > * Enhance what has been built with SUREFIRE-569 to support patterns as in > maven-shade-plugin. Use maven-common-artifact-filters for that. > * Add/Adapt documentation and examples. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] maven-surefire issue #173: [SUREFIRE-1004] Support full gavtc format for dep...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/173 @bindul Then we have to support also other alternatives: `groupId:artifactId:version`, and `groupId:artifactId:packaging:version`. This means you have to, first of all, count `:` and call different private method/matcher for count=2, 3, 4 or 5. ---
[jira] [Commented] (SUREFIRE-1004) Enhance pattern/wildcard capabilities for dependenciesToScan to GAVT
[ https://issues.apache.org/jira/browse/SUREFIRE-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325126#comment-16325126 ] ASF GitHub Bot commented on SUREFIRE-1004: -- Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/173 @binduk We have modify the maven coordinates to `groupId:artifactId:packaging:classifier:version`, see the docs: https://maven.apache.org/pom.html#Maven_Coordinates Basically, only the version would be determined last. > Enhance pattern/wildcard capabilities for dependenciesToScan to GAVT > > > Key: SUREFIRE-1004 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1004 > Project: Maven Surefire > Issue Type: Improvement > Components: Maven Failsafe Plugin, Maven Surefire Plugin >Affects Versions: 2.15 >Reporter: Andreas Gudian > > * Enhance what has been built with SUREFIRE-569 to support patterns as in > maven-shade-plugin. Use maven-common-artifact-filters for that. > * Add/Adapt documentation and examples. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] maven-surefire issue #173: [SUREFIRE-1004] Support full gavtc format for dep...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/173 @binduk We have modify the maven coordinates to `groupId:artifactId:packaging:classifier:version`, see the docs: https://maven.apache.org/pom.html#Maven_Coordinates Basically, only the version would be determined last. ---
[jira] [Comment Edited] (MNG-6312) Update Maven Wagon dependency
[ https://issues.apache.org/jira/browse/MNG-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325092#comment-16325092 ] Karl Heinz Marbaise edited comment on MNG-6312 at 1/13/18 11:39 AM: Hi [~slachiewicz] sorry already had created a branch with change for..Sorry to bother you was (Author: khmarbaise): Hi [~slachiewicz] would you like to offer an PR ? > Update Maven Wagon dependency > - > > Key: MNG-6312 > URL: https://issues.apache.org/jira/browse/MNG-6312 > Project: Maven > Issue Type: Dependency upgrade >Affects Versions: 3.5.0 >Reporter: Sylwester Lachiewicz >Assignee: Karl Heinz Marbaise > Fix For: 3.5.3 > > > Based on OWASP report - update Maven Wagon from 2.12 to 3.0.0 to fix known > vulnerability in shaded jsoup > wagon-http-2.12-shaded.jar\META-INF/maven/org.jsoup/jsoup/pom.xml > (cpe:/a:jsoup:jsoup:1.7.2, org.jsoup:jsoup:1.7.2) : CVE-2015-6748 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (SUREFIRE-1462) surefire-plugin's "groups" has conflicts with javadoc-plugin's "groups"
[ https://issues.apache.org/jira/browse/SUREFIRE-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325091#comment-16325091 ] Tibor Digana edited comment on SUREFIRE-1462 at 1/13/18 11:36 AM: -- [~dipakpawar231] We want to break backwards compatibility in version 3.0 and changing properties to {{surefire.\*}} and {{failsafe.\*}} according to plugin name is one of the change. So this was the plan very long time ago. To get there we have to pass through several more releases which includes 2.21.0/Jigsaw, 2.21.1 Bug Fix, 2.22.0/JUnit5 and then 3.0-RC1, 3.0-RC2, ..., 3.0.0. was (Author: tibor17): [~dipakpawar231] We want to break backwards compatibility in version 3.0 and changing properties to {{surefire.\*}} and {{failsafe.\*}} according to plugin name is one of the change. So this was the plan very long time ago. To get there we have to pass through several more releases which includes 2.21.0/Jigsaw, 2.21.1 Bug Fix, 2.22.0 JUnit5 and then 3.0-RC1, 3.0-RC2, ..., 3.0.0. > surefire-plugin's "groups" has conflicts with javadoc-plugin's "groups" > --- > > Key: SUREFIRE-1462 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1462 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.20.1 >Reporter: Dipak Pawar > Fix For: 3.0 > > > *Steps to Reproduce* > * Take a clone of reproducer project using > {code} > git clone https://github.com/dipak-pawar/surefire-groups-reproducer.git > {code} > * Run test using > * {code} mvn clean install {code} or {code} mvn clean verify{code} in case of > failsafe plugin. > *Expected Result* > Test should run fine > *Actual Result* > Getting following error while executing mvn clean install > {code} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-javadoc-plugin:3.0.0-M1:jar (attach-javadocs) > on project category-reproducer: Unable to parse configuration of mojo > org.apache.maven.plugins:maven-javadoc-plugin:3.0.0-M1:jar for parameter #: > Cannot find default setter in class > org.apache.maven.plugins.javadoc.options.Group -> [Help 1] > {code} > References: > http://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#groups > https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-mojo.html#groups -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (SUREFIRE-1462) surefire-plugin's "groups" has conflicts with javadoc-plugin's "groups"
[ https://issues.apache.org/jira/browse/SUREFIRE-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325091#comment-16325091 ] Tibor Digana edited comment on SUREFIRE-1462 at 1/13/18 11:36 AM: -- [~dipakpawar231] We want to break backwards compatibility in version 3.0 and changing properties to {{surefire.\*}} and {{failsafe.\*}} according to plugin name is one of the change. So this was the plan very long time ago. To get there we have to pass through several more releases which includes 2.21.0/Jigsaw, 2.21.1/Bug Fix, 2.22.0/JUnit5 and then 3.0-RC1, 3.0-RC2, ..., 3.0.0. was (Author: tibor17): [~dipakpawar231] We want to break backwards compatibility in version 3.0 and changing properties to {{surefire.\*}} and {{failsafe.\*}} according to plugin name is one of the change. So this was the plan very long time ago. To get there we have to pass through several more releases which includes 2.21.0/Jigsaw, 2.21.1 Bug Fix, 2.22.0/JUnit5 and then 3.0-RC1, 3.0-RC2, ..., 3.0.0. > surefire-plugin's "groups" has conflicts with javadoc-plugin's "groups" > --- > > Key: SUREFIRE-1462 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1462 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.20.1 >Reporter: Dipak Pawar > Fix For: 3.0 > > > *Steps to Reproduce* > * Take a clone of reproducer project using > {code} > git clone https://github.com/dipak-pawar/surefire-groups-reproducer.git > {code} > * Run test using > * {code} mvn clean install {code} or {code} mvn clean verify{code} in case of > failsafe plugin. > *Expected Result* > Test should run fine > *Actual Result* > Getting following error while executing mvn clean install > {code} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-javadoc-plugin:3.0.0-M1:jar (attach-javadocs) > on project category-reproducer: Unable to parse configuration of mojo > org.apache.maven.plugins:maven-javadoc-plugin:3.0.0-M1:jar for parameter #: > Cannot find default setter in class > org.apache.maven.plugins.javadoc.options.Group -> [Help 1] > {code} > References: > http://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#groups > https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-mojo.html#groups -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MNG-6312) Update Maven Wagon dependency
[ https://issues.apache.org/jira/browse/MNG-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325092#comment-16325092 ] Karl Heinz Marbaise commented on MNG-6312: -- Hi [~slachiewicz] would you like to offer an PR ? > Update Maven Wagon dependency > - > > Key: MNG-6312 > URL: https://issues.apache.org/jira/browse/MNG-6312 > Project: Maven > Issue Type: Dependency upgrade >Affects Versions: 3.5.0 >Reporter: Sylwester Lachiewicz >Assignee: Karl Heinz Marbaise > Fix For: 3.5.3 > > > Based on OWASP report - update Maven Wagon from 2.12 to 3.0.0 to fix known > vulnerability in shaded jsoup > wagon-http-2.12-shaded.jar\META-INF/maven/org.jsoup/jsoup/pom.xml > (cpe:/a:jsoup:jsoup:1.7.2, org.jsoup:jsoup:1.7.2) : CVE-2015-6748 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (SUREFIRE-1462) surefire-plugin's "groups" has conflicts with javadoc-plugin's "groups"
[ https://issues.apache.org/jira/browse/SUREFIRE-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325091#comment-16325091 ] Tibor Digana edited comment on SUREFIRE-1462 at 1/13/18 11:35 AM: -- [~dipakpawar231] We want to break backwards compatibility in version 3.0 and changing properties to {{surefire.\*}} and {{failsafe.\*}} according to plugin name is one of the change. So this was the plan very long time ago. To get there we have to pass through several more releases which includes 2.21.0/Jigsaw, 2.21.1 Bug Fix, 2.22.0 JUnit5 and then 3.0-RC1, 3.0-RC2, ..., 3.0.0. was (Author: tibor17): [~dipakpawar231] We want to break backwards compatibility in version 3.0 and changing properties to {{surefire.*}} and {{failsafe.*}} according to plugin name is one of the change. So this was the plan very long time ago. To get there we have to pass through several more releases which includes 2.21.0/Jigsaw, 2.21.1 Bug Fix, 2.22.0 JUnit5 and then 3.0-RC1, 3.0-RC2, ..., 3.0.0. > surefire-plugin's "groups" has conflicts with javadoc-plugin's "groups" > --- > > Key: SUREFIRE-1462 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1462 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.20.1 >Reporter: Dipak Pawar > Fix For: 3.0 > > > *Steps to Reproduce* > * Take a clone of reproducer project using > {code} > git clone https://github.com/dipak-pawar/surefire-groups-reproducer.git > {code} > * Run test using > * {code} mvn clean install {code} or {code} mvn clean verify{code} in case of > failsafe plugin. > *Expected Result* > Test should run fine > *Actual Result* > Getting following error while executing mvn clean install > {code} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-javadoc-plugin:3.0.0-M1:jar (attach-javadocs) > on project category-reproducer: Unable to parse configuration of mojo > org.apache.maven.plugins:maven-javadoc-plugin:3.0.0-M1:jar for parameter #: > Cannot find default setter in class > org.apache.maven.plugins.javadoc.options.Group -> [Help 1] > {code} > References: > http://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#groups > https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-mojo.html#groups -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1462) surefire-plugin's "groups" has conflicts with javadoc-plugin's "groups"
[ https://issues.apache.org/jira/browse/SUREFIRE-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325091#comment-16325091 ] Tibor Digana commented on SUREFIRE-1462: [~dipakpawar231] We want to break backwards compatibility in version 3.0 and changing properties to {{surefire.*}} and {{failsafe.*}} according to plugin name is one of the change. So this was the plan very long time ago. To get there we have to pass through several more releases which includes 2.21.0/Jigsaw, 2.21.1 Bug Fix, 2.22.0 JUnit5 and then 3.0-RC1, 3.0-RC2, ..., 3.0.0. > surefire-plugin's "groups" has conflicts with javadoc-plugin's "groups" > --- > > Key: SUREFIRE-1462 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1462 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.20.1 >Reporter: Dipak Pawar > Fix For: 3.0 > > > *Steps to Reproduce* > * Take a clone of reproducer project using > {code} > git clone https://github.com/dipak-pawar/surefire-groups-reproducer.git > {code} > * Run test using > * {code} mvn clean install {code} or {code} mvn clean verify{code} in case of > failsafe plugin. > *Expected Result* > Test should run fine > *Actual Result* > Getting following error while executing mvn clean install > {code} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-javadoc-plugin:3.0.0-M1:jar (attach-javadocs) > on project category-reproducer: Unable to parse configuration of mojo > org.apache.maven.plugins:maven-javadoc-plugin:3.0.0-M1:jar for parameter #: > Cannot find default setter in class > org.apache.maven.plugins.javadoc.options.Group -> [Help 1] > {code} > References: > http://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#groups > https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-mojo.html#groups -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MNG-6339) Tar gzip binary MD5 sum mismatch
[ https://issues.apache.org/jira/browse/MNG-6339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325087#comment-16325087 ] Michael Osipov commented on MNG-6339: - I cannot confirm this: {noformat} mosipov@mikaw10 MINGW64 ~ $ curl http://archive.apache.org/dist/maven/maven-3/3.5.2/binaries/apache-maven-3.5.2-bin.tar.gz | md5sum.exe % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 100 8533k 100 8533k0 0 5153k 0 0:00:01 0:00:01 --:--:-- 5153k 948110de4aab290033c23bf4894f7d9a *- {noformat} > Tar gzip binary MD5 sum mismatch > > > Key: MNG-6339 > URL: https://issues.apache.org/jira/browse/MNG-6339 > Project: Maven > Issue Type: Bug >Affects Versions: 3.5.2 >Reporter: Sam Simmons >Priority: Trivial > > The MD5 sum does not match the tar gzip binary in > http://archive.apache.org/dist/maven/maven-3/3.5.2/binaries/. It looks like > both the md5 and shasum were updated 3 days after the archives were added. > Please upload the correct checksums. > Provided MD5 sum 948110de4aab290033c23bf4894f7d9a > apache-maven-3.5.2-bin.tar.gz.md5 > Actual MD5 sum 6edf85f3e282e248db38b44ceb123bd0 apache-maven-3.5.2-bin.tar.gz > Thanks! -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MNG-6339) Tar gzip binary MD5 sum mismatch
[ https://issues.apache.org/jira/browse/MNG-6339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325084#comment-16325084 ] Karl Heinz Marbaise commented on MNG-6339: -- Hi first thanks for checking but unfortunately I can't reproduce this issue: I have downloaded all files from both sides the original distribution are https://dist.apache.org/repos/dist/release/maven/maven-3/3.5.2/binaries/ and also from the corresponding SVN repository https://dist.apache.org/repos/dist/release/maven/maven-3/3.5.2/binaries/ and do not get any [differences in checksums|https://github.com/khmarbaise/scripts/blob/master/downloadcheck.sh].. {code} Filename: apache-maven-3.5.2-bin.tar.gz.. SHA1 Checksum : generated : 190dcebb8a080f983af4420cac4f3ece7a47dd64 read : 190dcebb8a080f983af4420cac4f3ece7a47dd64 from file apache-maven-3.5.2-bin.tar.gz.sha1 Compare Result : ok. MD5 Checksum : generated : 948110de4aab290033c23bf4894f7d9a read : 948110de4aab290033c23bf4894f7d9a from file apache-maven-3.5.2-bin.tar.gz.md5 Compare Result : ok. ~/Downloads/Download-From-Dist-Repo$ downloadcheck.sh apache-maven-3.5.2-bin.zip ~/Downloads/Download-From-Dist-Repo$ downloadcheck.sh apache-maven-3.5.2-bin.zip Filename: apache-maven-3.5.2-bin.zip.. SHA1 Checksum : generated : 23adadc90b7f79ad84bd14574581d0145611bfda read : 23adadc90b7f79ad84bd14574581d0145611bfda from file apache-maven-3.5.2-bin.zip.sha1 Compare Result : ok. MD5 Checksum : generated : b8d8d49d8178734124c4ff6f3a409d3d read : b8d8d49d8178734124c4ff6f3a409d3d from file apache-maven-3.5.2-bin.zip.md5 Compare Result : ok. {code} The change which you have mentioned is based on the missing of the checksums at all. This has been fixed (added the checksums) by me which you can check via the history in the svn repository. Have you downloaded those artifacts from the above site or via a mirror ? > Tar gzip binary MD5 sum mismatch > > > Key: MNG-6339 > URL: https://issues.apache.org/jira/browse/MNG-6339 > Project: Maven > Issue Type: Bug >Affects Versions: 3.5.2 >Reporter: Sam Simmons >Priority: Trivial > > The MD5 sum does not match the tar gzip binary in > http://archive.apache.org/dist/maven/maven-3/3.5.2/binaries/. It looks like > both the md5 and shasum were updated 3 days after the archives were added. > Please upload the correct checksums. > Provided MD5 sum 948110de4aab290033c23bf4894f7d9a > apache-maven-3.5.2-bin.tar.gz.md5 > Actual MD5 sum 6edf85f3e282e248db38b44ceb123bd0 apache-maven-3.5.2-bin.tar.gz > Thanks! -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (MCHECKSTYLE-287) checkstyle report throws NPE
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MCHECKSTYLE-287. -- Resolution: Fixed Overcome by events and fixed elsewhere. > checkstyle report throws NPE > > > Key: MCHECKSTYLE-287 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-287 > Project: Maven Checkstyle Plugin > Issue Type: Bug >Affects Versions: 2.13, 2.14 >Reporter: Thomas Scheffler >Assignee: Michael Osipov > Attachments: mcheckstyle-287-demo.tgz, patch1.diff, projects.tar.gz > > > I don't know what triggers this bug. Somehow > org.apache.maven.plugin.checkstyle.AbstractCheckstyleReport.collectArtifacts(String) > produces a List which contains the null object. And therefor an exception is > thrown here (2.14): > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-site-plugin:3.3:site (default-site) on project > oaipmh: Execution default-site of goal > org.apache.maven.plugins:maven-site-plugin:3.3:site failed. > NullPointerException -> [Help 1] > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute > goal org.apache.maven.plugins:maven-site-plugin:3.3:site (default-site) on > project oaipmh: Execution default-site of goal > org.apache.maven.plugins:maven-site-plugin:3.3:site failed. > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:224) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80) > at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51) > at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:355) > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155) > at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584) > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:216) > at org.apache.maven.cli.MavenCli.main(MavenCli.java:160) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229) > at > org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415) > at > org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356) > Caused by: org.apache.maven.plugin.PluginExecutionException: Execution > default-site of goal org.apache.maven.plugins:maven-site-plugin:3.3:site > failed. > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:143) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > ... 19 more > Caused by: java.lang.NullPointerException > at > org.apache.maven.plugin.checkstyle.exec.DefaultCheckstyleExecutor.configureResourceLocator(DefaultCheckstyleExecutor.java:852) > at > org.apache.maven.plugin.checkstyle.exec.DefaultCheckstyleExecutor.executeCheckstyle(DefaultCheckstyleExecutor.java:102) > at > org.apache.maven.plugin.checkstyle.AbstractCheckstyleReport.executeReport(AbstractCheckstyleReport.java:474) > at > org.apache.maven.plugin.checkstyle.CheckstyleReport.executeReport(CheckstyleReport.java:156) > at > org.apache.maven.reporting.AbstractMavenReport.generate(AbstractMavenReport.java:255) > at > org.apache.maven.plugins.site.ReportDocumentRenderer.renderDocument(ReportDocumentRenderer.java:219) > at > org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderModule(DefaultSiteRenderer.java:319) > at > org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render(DefaultSiteRenderer.java:135) > at > org.apache.maven.plugins.site.SiteMojo.renderLocale(SiteMojo.java:175) > at org.apache.maven.plugins.site.SiteMojo.execute(SiteMojo.java:138) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132) > ... 20 more > {noformat} > Looking at the code, you
[jira] [Assigned] (MCHECKSTYLE-287) checkstyle report throws NPE
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MCHECKSTYLE-287: -- Assignee: Michael Osipov > checkstyle report throws NPE > > > Key: MCHECKSTYLE-287 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-287 > Project: Maven Checkstyle Plugin > Issue Type: Bug >Affects Versions: 2.13, 2.14 >Reporter: Thomas Scheffler >Assignee: Michael Osipov > Attachments: mcheckstyle-287-demo.tgz, patch1.diff, projects.tar.gz > > > I don't know what triggers this bug. Somehow > org.apache.maven.plugin.checkstyle.AbstractCheckstyleReport.collectArtifacts(String) > produces a List which contains the null object. And therefor an exception is > thrown here (2.14): > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-site-plugin:3.3:site (default-site) on project > oaipmh: Execution default-site of goal > org.apache.maven.plugins:maven-site-plugin:3.3:site failed. > NullPointerException -> [Help 1] > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute > goal org.apache.maven.plugins:maven-site-plugin:3.3:site (default-site) on > project oaipmh: Execution default-site of goal > org.apache.maven.plugins:maven-site-plugin:3.3:site failed. > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:224) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80) > at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51) > at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:355) > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155) > at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584) > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:216) > at org.apache.maven.cli.MavenCli.main(MavenCli.java:160) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229) > at > org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415) > at > org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356) > Caused by: org.apache.maven.plugin.PluginExecutionException: Execution > default-site of goal org.apache.maven.plugins:maven-site-plugin:3.3:site > failed. > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:143) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > ... 19 more > Caused by: java.lang.NullPointerException > at > org.apache.maven.plugin.checkstyle.exec.DefaultCheckstyleExecutor.configureResourceLocator(DefaultCheckstyleExecutor.java:852) > at > org.apache.maven.plugin.checkstyle.exec.DefaultCheckstyleExecutor.executeCheckstyle(DefaultCheckstyleExecutor.java:102) > at > org.apache.maven.plugin.checkstyle.AbstractCheckstyleReport.executeReport(AbstractCheckstyleReport.java:474) > at > org.apache.maven.plugin.checkstyle.CheckstyleReport.executeReport(CheckstyleReport.java:156) > at > org.apache.maven.reporting.AbstractMavenReport.generate(AbstractMavenReport.java:255) > at > org.apache.maven.plugins.site.ReportDocumentRenderer.renderDocument(ReportDocumentRenderer.java:219) > at > org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderModule(DefaultSiteRenderer.java:319) > at > org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render(DefaultSiteRenderer.java:135) > at > org.apache.maven.plugins.site.SiteMojo.renderLocale(SiteMojo.java:175) > at org.apache.maven.plugins.site.SiteMojo.execute(SiteMojo.java:138) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132) > ... 20 more > {noformat} > Looking at the code, you see a null check is done