[jira] [Commented] (MNG-6410) Add groupId to --resume-from suggestion if artifactId is not unique in reactor

[JIRA]

[ 
https://issues.apache.org/jira/browse/MNG-6410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481411#comment-16481411
 ] 

Hervé Boutemy commented on MNG-6410:


javadoc and method name reworked ("improved" IMHO :) ) 
https://gitbox.apache.org/repos/asf?p=maven.git;a=commitdiff;h=f2084970a30af8c823b98702aa431eac6ae1581a

feedback welcome

> Add groupId to --resume-from suggestion if artifactId is not unique in reactor
> --
>
> Key: MNG-6410
> URL: https://issues.apache.org/jira/browse/MNG-6410
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.5.3
>Reporter: Łukasz Dywicki
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4-candidate
>
>
> In multi module builds same artifact id can be repeated with different group 
> id. For example if project strategy is to use nesting of modules, instead of 
> using long artifact names, {{ap}} or {{model}} module can occur multiple 
> times with different group id.
> By default maven, upon failed build, prints out only {{-rf :artifactId}}. 
> When developer will copy given suggestion and run build again then his build 
> will be started from first module which have given artifact id.
> While severity of this bug is quite low, it affects productivity in bigger 
> projects big time. To improve usability of returned message a Maven should 
> return {{-rf groupId:artifactId}} once artifact id is not unique.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6411) Improve readability of project list returned when --resume-from option value is invalid

[JIRA]

[ 
https://issues.apache.org/jira/browse/MNG-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481410#comment-16481410
 ] 

Hervé Boutemy commented on MNG-6411:


thank you Lukasz
it seems there is a TLS 1.2 issue: as shown in MNG-6411, with Java 8, it works. 
I don't know why it does not work with Java 7 and 
-Dhttps.protocols=TLSv1,TLSv1.1,TLSv1.2
I'll need to investigate, but unrelated to the MNG-6411 improvement :)

now, time to merge MNG-6410...

> Improve readability of project list returned when --resume-from option value 
> is invalid
> ---
>
> Key: MNG-6411
> URL: https://issues.apache.org/jira/browse/MNG-6411
> Project: Maven
>  Issue Type: Improvement
>  Components: Command Line
>Affects Versions: 3.5.3
>Reporter: Łukasz Dywicki
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4
>
>
> When value passed for {{-rf}} option is invalid, a full list of details of 
> all projects in build is returned.
> This list contains too much information. For every project it includes 
> groupId, artifactId, version and pom location. While it is useful for 
> debugging purposes many, if not most, developers are interested in specific 
> coordinate (groupId:artifactId) which should be passed to next execution, and 
> which is valid {{-rf}} optional value.
> *Note that below outputs contain new lines for ease of read*. This could be 
> also added to exception message to make it more readable.
> Assuming, that I've passed -rf :x Current output in case of failure:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
>   MavenProject: com.example:foobar:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/pom.xml,
>   MavenProject: com.example.foobar:parent:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/parent/pom.xml,
>   MavenProject: com.example.foobar:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/api/pom.xml,
>   MavenProject: com.example.foobar:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/model/pom.xml,
>   MavenProject: com.example.foobar:csv:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/pom.xml,
>   MavenProject: com.example.foobar.csv:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/model/pom.xml,
>   MavenProject: com.example.foobar.csv:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/api/pom.xml,
>   MavenProject: com.example.foobar:json:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/pom.xml,
>   MavenProject: com.example.foobar.json:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/model/pom.xml,
>   MavenProject: com.example.foobar.json:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/api/pom.xml,
>   MavenProject: com.example.foobar.json:core:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/core/pom.xml,
>   MavenProject: com.example.foobar:fax:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/pom.xml,
>   MavenProject: com.example.foobar.fax:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/api/pom.xml,
>   MavenProject: com.example.foobar.fax:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/model/pom.xml,
>   MavenProject: com.example.foobar.fax:web:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/pom.xml,
>   MavenProject: com.example.foobar.fax.web:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/api/pom.xml,
>   MavenProject: com.example.foobar.fax.web:core:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/core/pom.xml] -> [Help 1]
> {noformat}
> Additional information about pom locations is irrelevant from message point 
> of view, because valid input for -rf option is presented below:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
>   com.example:foobar,
>   com.example.foobar:parent,
>   com.example.foobar:api,
>   com.example.foobar:model,
>   com.example.foobar:csv,
>   com.example.foobar.csv:model,
>   com.example.foobar.csv:api,
>   com.example.foobar:json,
>   com.example.foobar.json:model,
>   com.example.foobar.json:api,
>   com.example.foobar.json:core,
>   com.example.foobar:fax,
>   com.example.foobar.fax:api,
>   com.example.foobar.fax:model,
>   com.example.foobar.fax:web,
>   com.example.foobar.fax.web:api,
>   com.example.foobar.fax.web:core] -> [Help 1]
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (SCM-868) gitexe add() does not return added files when invoked in subdir

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCM-868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed SCM-868.
--
Resolution: Fixed

Fixed with 
[3b0f2ecb900366564f6ea735302819c3a2c6513f|https://gitbox.apache.org/repos/asf?p=maven-scm.git;a=commit;h=3b0f2ecb900366564f6ea735302819c3a2c6513f].

> gitexe add() does not return added files when invoked in subdir
> ---
>
> Key: SCM-868
> URL: https://issues.apache.org/jira/browse/SCM-868
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5, 1.9.6
>Reporter: Ilya Basin
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.6
>
>
> I'm going to add a wagon-scm test suite for git. One of the test cases is 
> calling the GitAddCommand command with:
> {code:java}
> repo: 
> file:///C:/progs/maven/maven-wagon/wagon-providers/wagon-scm/target/test-classes/test-repo-git-test/
> fileSet: basedir = 
> C:\Users\basin\AppData\Local\Temp\wagon-scm2020146470.checkout\file-list; 
> files = [test-resource.txt]{code}
> After adding the files the command internally calls "git rev-parse 
> --show-toplevel" which prints:
> {code:java}
> C:/Users/basin/AppData/Local/Temp/wagon-scm2020146470.checkout{code}
> And on the next line it tries to do (pseudo code):
> {code:java}
> ("file:/C:/Users/basin/AppData/Local/Temp/wagon-scm1144102340.checkout/file-list/").relativize(URI.create(
> "C:/Users/basin/AppData/Local/Temp/wagon-scm2020146470.checkout")){code}
> This is so wrong! What were those people from SCM-709 trying to get? A double 
> dot ".."? The argument to the relativize() method MUST be a child, not a 
> parent, otherwise the argument is returned unchanged.
> There are so many reasons why getting an absolute path from git is a bad 
> idea: Symlinks, Windows paths.
> Nevertheless, there's a simple solution. The original problem was that "git 
> status --porcelain" printed paths relative to the top level instead of 
> relative to the base dir.
> So we should just call 
> {code}
> git rev-parse --show-prefix
> {code} instead of "show-toplevel" and strip this prefix from the paths 
> printed by "git status"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-868) gitexe add() does not return added files when invoked in subdir

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481329#comment-16481329
 ] 

ASF GitHub Bot commented on SCM-868:


asfgit closed pull request #66: [SCM-868] fix gitexe cannot deduce relative path
URL: https://github.com/apache/maven-scm/pull/66
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/add/GitAddCommand.java
 
b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/add/GitAddCommand.java
index 21ad47607..00da32475 100644
--- 
a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/add/GitAddCommand.java
+++ 
b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/add/GitAddCommand.java
@@ -69,31 +69,12 @@ protected ScmResult executeAddCommand( 
ScmProviderRepository repo, ScmFileSet fi
 {
 return result;
 }
-
+
 // SCM-709: statusCommand uses repositoryRoot instead of 
workingDirectory, adjust it with relativeRepositoryPath
-Commandline clRevparse = 
GitStatusCommand.createRevparseShowToplevelCommand( fileSet );
-
-CommandLineUtils.StringStreamConsumer stdout = new 
CommandLineUtils.StringStreamConsumer();
-CommandLineUtils.StringStreamConsumer stderr = new 
CommandLineUtils.StringStreamConsumer();
+URI relativeRepositoryPath = GitStatusCommand.getRelativeCWD( this, 
fileSet );
 
-URI relativeRepositoryPath = null;
-
 int exitCode;
-
-exitCode = GitCommandLineUtils.execute( clRevparse, stdout, stderr, 
getLogger() );
-if ( exitCode != 0 )
-{
-// git-status returns non-zero if nothing to do
-if ( getLogger().isInfoEnabled() )
-{
-getLogger().info( "Could not resolve toplevel" );
-}
-}
-else
-{
-relativeRepositoryPath =
-GitStatusConsumer.resolveURI( stdout.getOutput().trim(), 
fileSet.getBasedir().toURI() );
-}
+CommandLineUtils.StringStreamConsumer stderr;
 
 // git-add doesn't show single files, but only summary :/
 // so we must run git-status and consume the output
diff --git 
a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/checkin/GitCheckInCommand.java
 
b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/checkin/GitCheckInCommand.java
index 1766acabb..30d6c70ea 100644
--- 
a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/checkin/GitCheckInCommand.java
+++ 
b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/checkin/GitCheckInCommand.java
@@ -121,27 +121,7 @@ protected CheckInScmResult executeCheckInCommand( 
ScmProviderRepository repo, Sc
 
 // SCM-709: statusCommand uses repositoryRoot instead of 
workingDirectory, adjust it with
 // relativeRepositoryPath
-Commandline clRevparse = 
GitStatusCommand.createRevparseShowToplevelCommand( fileSet );
-
-stdout = new CommandLineUtils.StringStreamConsumer();
-stderr = new CommandLineUtils.StringStreamConsumer();
-
-URI relativeRepositoryPath = null;
-
-exitCode = GitCommandLineUtils.execute( clRevparse, stdout, 
stderr, getLogger() );
-if ( exitCode != 0 )
-{
-// git-status returns non-zero if nothing to do
-if ( getLogger().isInfoEnabled() )
-{
-getLogger().info( "Could not resolve toplevel" );
-}
-}
-else
-{
-relativeRepositoryPath =
-GitStatusConsumer.resolveURI( stdout.getOutput().trim(), 
fileSet.getBasedir().toURI() );
-}
+URI relativeRepositoryPath = GitStatusCommand.getRelativeCWD( 
this, fileSet );
 
 // git-commit doesn't show single files, but only summary :/
 // so we must run git-status and consume the output
diff --git 

[GitHub] asfgit closed pull request #66: [SCM-868] fix gitexe cannot deduce relative path

[GitBox]

asfgit closed pull request #66: [SCM-868] fix gitexe cannot deduce relative path
URL: https://github.com/apache/maven-scm/pull/66
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/add/GitAddCommand.java
 
b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/add/GitAddCommand.java
index 21ad47607..00da32475 100644
--- 
a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/add/GitAddCommand.java
+++ 
b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/add/GitAddCommand.java
@@ -69,31 +69,12 @@ protected ScmResult executeAddCommand( 
ScmProviderRepository repo, ScmFileSet fi
 {
 return result;
 }
-
+
 // SCM-709: statusCommand uses repositoryRoot instead of 
workingDirectory, adjust it with relativeRepositoryPath
-Commandline clRevparse = 
GitStatusCommand.createRevparseShowToplevelCommand( fileSet );
-
-CommandLineUtils.StringStreamConsumer stdout = new 
CommandLineUtils.StringStreamConsumer();
-CommandLineUtils.StringStreamConsumer stderr = new 
CommandLineUtils.StringStreamConsumer();
+URI relativeRepositoryPath = GitStatusCommand.getRelativeCWD( this, 
fileSet );
 
-URI relativeRepositoryPath = null;
-
 int exitCode;
-
-exitCode = GitCommandLineUtils.execute( clRevparse, stdout, stderr, 
getLogger() );
-if ( exitCode != 0 )
-{
-// git-status returns non-zero if nothing to do
-if ( getLogger().isInfoEnabled() )
-{
-getLogger().info( "Could not resolve toplevel" );
-}
-}
-else
-{
-relativeRepositoryPath =
-GitStatusConsumer.resolveURI( stdout.getOutput().trim(), 
fileSet.getBasedir().toURI() );
-}
+CommandLineUtils.StringStreamConsumer stderr;
 
 // git-add doesn't show single files, but only summary :/
 // so we must run git-status and consume the output
diff --git 
a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/checkin/GitCheckInCommand.java
 
b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/checkin/GitCheckInCommand.java
index 1766acabb..30d6c70ea 100644
--- 
a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/checkin/GitCheckInCommand.java
+++ 
b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/checkin/GitCheckInCommand.java
@@ -121,27 +121,7 @@ protected CheckInScmResult executeCheckInCommand( 
ScmProviderRepository repo, Sc
 
 // SCM-709: statusCommand uses repositoryRoot instead of 
workingDirectory, adjust it with
 // relativeRepositoryPath
-Commandline clRevparse = 
GitStatusCommand.createRevparseShowToplevelCommand( fileSet );
-
-stdout = new CommandLineUtils.StringStreamConsumer();
-stderr = new CommandLineUtils.StringStreamConsumer();
-
-URI relativeRepositoryPath = null;
-
-exitCode = GitCommandLineUtils.execute( clRevparse, stdout, 
stderr, getLogger() );
-if ( exitCode != 0 )
-{
-// git-status returns non-zero if nothing to do
-if ( getLogger().isInfoEnabled() )
-{
-getLogger().info( "Could not resolve toplevel" );
-}
-}
-else
-{
-relativeRepositoryPath =
-GitStatusConsumer.resolveURI( stdout.getOutput().trim(), 
fileSet.getBasedir().toURI() );
-}
+URI relativeRepositoryPath = GitStatusCommand.getRelativeCWD( 
this, fileSet );
 
 // git-commit doesn't show single files, but only summary :/
 // so we must run git-status and consume the output
diff --git 
a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/status/GitStatusCommand.java
 

[jira] [Commented] (MNG-6411) Improve readability of project list returned when --resume-from option value is invalid

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481300#comment-16481300
 ] 

Michael Osipov commented on MNG-6411:
-

Correct, it looks like a network issue. Thank you for your contribution.

> Improve readability of project list returned when --resume-from option value 
> is invalid
> ---
>
> Key: MNG-6411
> URL: https://issues.apache.org/jira/browse/MNG-6411
> Project: Maven
>  Issue Type: Improvement
>  Components: Command Line
>Affects Versions: 3.5.3
>Reporter: Łukasz Dywicki
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4
>
>
> When value passed for {{-rf}} option is invalid, a full list of details of 
> all projects in build is returned.
> This list contains too much information. For every project it includes 
> groupId, artifactId, version and pom location. While it is useful for 
> debugging purposes many, if not most, developers are interested in specific 
> coordinate (groupId:artifactId) which should be passed to next execution, and 
> which is valid {{-rf}} optional value.
> *Note that below outputs contain new lines for ease of read*. This could be 
> also added to exception message to make it more readable.
> Assuming, that I've passed -rf :x Current output in case of failure:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
>   MavenProject: com.example:foobar:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/pom.xml,
>   MavenProject: com.example.foobar:parent:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/parent/pom.xml,
>   MavenProject: com.example.foobar:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/api/pom.xml,
>   MavenProject: com.example.foobar:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/model/pom.xml,
>   MavenProject: com.example.foobar:csv:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/pom.xml,
>   MavenProject: com.example.foobar.csv:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/model/pom.xml,
>   MavenProject: com.example.foobar.csv:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/api/pom.xml,
>   MavenProject: com.example.foobar:json:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/pom.xml,
>   MavenProject: com.example.foobar.json:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/model/pom.xml,
>   MavenProject: com.example.foobar.json:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/api/pom.xml,
>   MavenProject: com.example.foobar.json:core:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/core/pom.xml,
>   MavenProject: com.example.foobar:fax:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/pom.xml,
>   MavenProject: com.example.foobar.fax:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/api/pom.xml,
>   MavenProject: com.example.foobar.fax:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/model/pom.xml,
>   MavenProject: com.example.foobar.fax:web:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/pom.xml,
>   MavenProject: com.example.foobar.fax.web:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/api/pom.xml,
>   MavenProject: com.example.foobar.fax.web:core:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/core/pom.xml] -> [Help 1]
> {noformat}
> Additional information about pom locations is irrelevant from message point 
> of view, because valid input for -rf option is presented below:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
>   com.example:foobar,
>   com.example.foobar:parent,
>   com.example.foobar:api,
>   com.example.foobar:model,
>   com.example.foobar:csv,
>   com.example.foobar.csv:model,
>   com.example.foobar.csv:api,
>   com.example.foobar:json,
>   com.example.foobar.json:model,
>   com.example.foobar.json:api,
>   com.example.foobar.json:core,
>   com.example.foobar:fax,
>   com.example.foobar.fax:api,
>   com.example.foobar.fax:model,
>   com.example.foobar.fax:web,
>   com.example.foobar.fax.web:api,
>   com.example.foobar.fax.web:core] -> [Help 1]
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6411) Improve readability of project list returned when --resume-from option value is invalid

[JIRA]

[ 
https://issues.apache.org/jira/browse/MNG-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481281#comment-16481281
 ] 

Łukasz Dywicki commented on MNG-6411:
-

Thank you very much, even if build failed, it failed due to other reason! :)

> Improve readability of project list returned when --resume-from option value 
> is invalid
> ---
>
> Key: MNG-6411
> URL: https://issues.apache.org/jira/browse/MNG-6411
> Project: Maven
>  Issue Type: Improvement
>  Components: Command Line
>Affects Versions: 3.5.3
>Reporter: Łukasz Dywicki
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4
>
>
> When value passed for {{-rf}} option is invalid, a full list of details of 
> all projects in build is returned.
> This list contains too much information. For every project it includes 
> groupId, artifactId, version and pom location. While it is useful for 
> debugging purposes many, if not most, developers are interested in specific 
> coordinate (groupId:artifactId) which should be passed to next execution, and 
> which is valid {{-rf}} optional value.
> *Note that below outputs contain new lines for ease of read*. This could be 
> also added to exception message to make it more readable.
> Assuming, that I've passed -rf :x Current output in case of failure:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
>   MavenProject: com.example:foobar:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/pom.xml,
>   MavenProject: com.example.foobar:parent:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/parent/pom.xml,
>   MavenProject: com.example.foobar:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/api/pom.xml,
>   MavenProject: com.example.foobar:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/model/pom.xml,
>   MavenProject: com.example.foobar:csv:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/pom.xml,
>   MavenProject: com.example.foobar.csv:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/model/pom.xml,
>   MavenProject: com.example.foobar.csv:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/api/pom.xml,
>   MavenProject: com.example.foobar:json:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/pom.xml,
>   MavenProject: com.example.foobar.json:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/model/pom.xml,
>   MavenProject: com.example.foobar.json:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/api/pom.xml,
>   MavenProject: com.example.foobar.json:core:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/core/pom.xml,
>   MavenProject: com.example.foobar:fax:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/pom.xml,
>   MavenProject: com.example.foobar.fax:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/api/pom.xml,
>   MavenProject: com.example.foobar.fax:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/model/pom.xml,
>   MavenProject: com.example.foobar.fax:web:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/pom.xml,
>   MavenProject: com.example.foobar.fax.web:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/api/pom.xml,
>   MavenProject: com.example.foobar.fax.web:core:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/core/pom.xml] -> [Help 1]
> {noformat}
> Additional information about pom locations is irrelevant from message point 
> of view, because valid input for -rf option is presented below:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
>   com.example:foobar,
>   com.example.foobar:parent,
>   com.example.foobar:api,
>   com.example.foobar:model,
>   com.example.foobar:csv,
>   com.example.foobar.csv:model,
>   com.example.foobar.csv:api,
>   com.example.foobar:json,
>   com.example.foobar.json:model,
>   com.example.foobar.json:api,
>   com.example.foobar.json:core,
>   com.example.foobar:fax,
>   com.example.foobar.fax:api,
>   com.example.foobar.fax:model,
>   com.example.foobar.fax:web,
>   com.example.foobar.fax.web:api,
>   com.example.foobar.fax.web:core] -> [Help 1]
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (SCM-868) gitexe add() does not return added files when invoked in subdir

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCM-868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov reassigned SCM-868:
--

Assignee: Michael Osipov

> gitexe add() does not return added files when invoked in subdir
> ---
>
> Key: SCM-868
> URL: https://issues.apache.org/jira/browse/SCM-868
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5, 1.9.6
>Reporter: Ilya Basin
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.6
>
>
> I'm going to add a wagon-scm test suite for git. One of the test cases is 
> calling the GitAddCommand command with:
> {code:java}
> repo: 
> file:///C:/progs/maven/maven-wagon/wagon-providers/wagon-scm/target/test-classes/test-repo-git-test/
> fileSet: basedir = 
> C:\Users\basin\AppData\Local\Temp\wagon-scm2020146470.checkout\file-list; 
> files = [test-resource.txt]{code}
> After adding the files the command internally calls "git rev-parse 
> --show-toplevel" which prints:
> {code:java}
> C:/Users/basin/AppData/Local/Temp/wagon-scm2020146470.checkout{code}
> And on the next line it tries to do (pseudo code):
> {code:java}
> ("file:/C:/Users/basin/AppData/Local/Temp/wagon-scm1144102340.checkout/file-list/").relativize(URI.create(
> "C:/Users/basin/AppData/Local/Temp/wagon-scm2020146470.checkout")){code}
> This is so wrong! What were those people from SCM-709 trying to get? A double 
> dot ".."? The argument to the relativize() method MUST be a child, not a 
> parent, otherwise the argument is returned unchanged.
> There are so many reasons why getting an absolute path from git is a bad 
> idea: Symlinks, Windows paths.
> Nevertheless, there's a simple solution. The original problem was that "git 
> status --porcelain" printed paths relative to the top level instead of 
> relative to the base dir.
> So we should just call 
> {code}
> git rev-parse --show-prefix
> {code} instead of "show-toplevel" and strip this prefix from the paths 
> printed by "git status"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCM-868) gitexe add() does not return added files when invoked in subdir

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCM-868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated SCM-868:
---
Fix Version/s: 1.9.6

> gitexe add() does not return added files when invoked in subdir
> ---
>
> Key: SCM-868
> URL: https://issues.apache.org/jira/browse/SCM-868
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5, 1.9.6
>Reporter: Ilya Basin
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.6
>
>
> I'm going to add a wagon-scm test suite for git. One of the test cases is 
> calling the GitAddCommand command with:
> {code:java}
> repo: 
> file:///C:/progs/maven/maven-wagon/wagon-providers/wagon-scm/target/test-classes/test-repo-git-test/
> fileSet: basedir = 
> C:\Users\basin\AppData\Local\Temp\wagon-scm2020146470.checkout\file-list; 
> files = [test-resource.txt]{code}
> After adding the files the command internally calls "git rev-parse 
> --show-toplevel" which prints:
> {code:java}
> C:/Users/basin/AppData/Local/Temp/wagon-scm2020146470.checkout{code}
> And on the next line it tries to do (pseudo code):
> {code:java}
> ("file:/C:/Users/basin/AppData/Local/Temp/wagon-scm1144102340.checkout/file-list/").relativize(URI.create(
> "C:/Users/basin/AppData/Local/Temp/wagon-scm2020146470.checkout")){code}
> This is so wrong! What were those people from SCM-709 trying to get? A double 
> dot ".."? The argument to the relativize() method MUST be a child, not a 
> parent, otherwise the argument is returned unchanged.
> There are so many reasons why getting an absolute path from git is a bad 
> idea: Symlinks, Windows paths.
> Nevertheless, there's a simple solution. The original problem was that "git 
> status --porcelain" printed paths relative to the top level instead of 
> relative to the base dir.
> So we should just call 
> {code}
> git rev-parse --show-prefix
> {code} instead of "show-toplevel" and strip this prefix from the paths 
> printed by "git status"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [GitHub] michael-o commented on issue #165: [MNG-6028] Include current goals in resume suggestion

[Vishal Kumar Gupta]

Apache Software Foundation
>From Wikipedia, the free encyclopedia


Apache Software Foundation
[image: Apache Software Foundation Logo (2016).svg]

Founded June 1999; 18 years ago
Founders Brian Behlendorf , Ken
Coar , Mark Cox, Lars Eilebrecht
, Ralf S. Engelschall

, Roy T. Fielding , Dean
Gaudet

, Ben Hyde
,
 Jim Jagielski , Alexei Kosut

, Martin Kraemer , Ben Laurie
, Doug MacEachern

, Aram Mirzadeh

, Sameer Parekh , Cliff
Skolnick

, Marc Slemko

, William (Bill) Stoddard

, Paul Sutton

, Randy Terbush , Dirk-Willem
van Gulik 
Type 501(c)(3) 
Focus Open-source software

Location

   - Forest Hill, Maryland
   , USA

Method Apache License 
Website www.apache.org

The *Apache Software Foundation* /əˈpætʃi/
 (*ASF*) is an
American non-profit
corporation  (classified
as 501(c)(3)  in the United
States) to support Apache software projects, including the Apache HTTP
Server . The ASF was
formed from the Apache Group and incorporated in Delaware
, U.S., in June 1999.[1]

[2]


The Apache Software Foundation is a decentralized open source community of
developers. The software they produce is distributed under the terms
of the Apache
License  and is free and
open-source software
(FOSS). The
Apache projects are characterized by a collaborative, consensus-based
development process and an open and pragmatic software license. Each
project is managed by a self-selected team of technical experts who are
active contributors to the project. The ASF is a meritocracy
, implying that membership of
the foundation is granted only to volunteers who have actively contributed
to Apache projects. The ASF is considered a second generation[3]

open-source
organization, in that commercial support is provided without the risk
of platform
lock-in .

Among the ASF's objectives are: to provide legal protection[4]
 to
volunteers working on Apache projects; to prevent the *Apache* brand name
from being used by other organizations without permission.

The ASF also holds several ApacheCon[5]

conferences
each year, highlighting Apache projects and related technology.

Contents  [hide]

   - 1History
   
   - 2Projects
   
   - 3Board of directors
   
   - 4Financials
   
   - 5See also
   
   - 6Notes 
   - 7Further reading
   

Re: [GitHub] michael-o commented on issue #165: [MNG-6028] Include current goals in resume suggestion

[Vishal Kumar Gupta]

Apache Software Foundation
>From Wikipedia, the free encyclopedia


Apache Software Foundation
[image: Apache Software Foundation Logo (2016).svg]

Founded June 1999; 18 years ago
Founders Brian Behlendorf , Ken
Coar , Mark Cox, Lars Eilebrecht
, Ralf S. Engelschall

, Roy T. Fielding , Dean
Gaudet

, Ben Hyde
,
 Jim Jagielski , Alexei Kosut

, Martin Kraemer , Ben Laurie
, Doug MacEachern

, Aram Mirzadeh

, Sameer Parekh , Cliff
Skolnick

, Marc Slemko

, William (Bill) Stoddard

, Paul Sutton

, Randy Terbush , Dirk-Willem
van Gulik 
Type 501(c)(3) 
Focus Open-source software

Location

   - Forest Hill, Maryland
   , USA

Method Apache License 
Website www.apache.org

The *Apache Software Foundation* /əˈpætʃi/
 (*ASF*) is an
American non-profit
corporation  (classified
as 501(c)(3)  in the United
States) to support Apache software projects, including the Apache HTTP
Server . The ASF was
formed from the Apache Group and incorporated in Delaware
, U.S., in June 1999.[1]

[2]


The Apache Software Foundation is a decentralized open source community of
developers. The software they produce is distributed under the terms
of the Apache
License  and is free and
open-source software
(FOSS). The
Apache projects are characterized by a collaborative, consensus-based
development process and an open and pragmatic software license. Each
project is managed by a self-selected team of technical experts who are
active contributors to the project. The ASF is a meritocracy
, implying that membership of
the foundation is granted only to volunteers who have actively contributed
to Apache projects. The ASF is considered a second generation[3]

open-source
organization, in that commercial support is provided without the risk
of platform
lock-in .

Among the ASF's objectives are: to provide legal protection[4]
 to
volunteers working on Apache projects; to prevent the *Apache* brand name
from being used by other organizations without permission.

The ASF also holds several ApacheCon[5]

conferences
each year, highlighting Apache projects and related technology.

Contents  [hide]

   - 1History
   
   - 2Projects
   
   - 3Board of directors
   
   - 4Financials
   
   - 5See also
   
   - 6Notes 
   - 7Further reading
   

[jira] [Commented] (MNG-6028) When a reactor build fails maven should include current goals in resume suggestion

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481237#comment-16481237
 ] 

ASF GitHub Bot commented on MNG-6028:
-

michael-o commented on issue #165: [MNG-6028] Include current goals in resume 
suggestion
URL: https://github.com/apache/maven/pull/165#issuecomment-390341341
 
 
   I agree with @hboutemy and would go for `` if we cannot 
guarentee the exact same input.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> When a reactor build fails maven should include current goals in resume 
> suggestion
> --
>
> Key: MNG-6028
> URL: https://issues.apache.org/jira/browse/MNG-6028
> Project: Maven
>  Issue Type: Improvement
>Affects Versions: 3.3.9
>Reporter: Axel Fontaine
>Priority: Major
> Fix For: 3.5.4-candidate
>
>
> Start multiproject build at root with mvn clean install
> if module-a fails you currently get
> {noformat}[ERROR] After correcting the problems, you can resume the build 
> with the command
> [ERROR]   mvn  -rf :module-a{noformat}
> to be able to easily copy-paste this it would be much nicer if the goals were 
> already filled in:
> {noformat}[ERROR] After correcting the problems, you can resume the build 
> with the command
> [ERROR]   mvn clean install -rf :module-a{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] michael-o commented on issue #165: [MNG-6028] Include current goals in resume suggestion

[GitBox]

michael-o commented on issue #165: [MNG-6028] Include current goals in resume 
suggestion
URL: https://github.com/apache/maven/pull/165#issuecomment-390341341
 
 
   I agree with @hboutemy and would go for `` if we cannot 
guarentee the exact same input.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (MNG-6410) Add groupId to --resume-from suggestion if artifactId is not unique in reactor

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MNG-6410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-6410:

Summary: Add groupId to --resume-from suggestion if artifactId is not 
unique in reactor  (was: When a reactor build fails on an artifactId which is 
not unique, Maven should provide the groupId when suggesting where build should 
restart from)

> Add groupId to --resume-from suggestion if artifactId is not unique in reactor
> --
>
> Key: MNG-6410
> URL: https://issues.apache.org/jira/browse/MNG-6410
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.5.3
>Reporter: Łukasz Dywicki
>Priority: Minor
> Fix For: 3.5.4-candidate
>
>
> In multi module builds same artifact id can be repeated with different group 
> id. For example if project strategy is to use nesting of modules, instead of 
> using long artifact names, {{ap}} or {{model}} module can occur multiple 
> times with different group id.
> By default maven, upon failed build, prints out only {{-rf :artifactId}}. 
> When developer will copy given suggestion and run build again then his build 
> will be started from first module which have given artifact id.
> While severity of this bug is quite low, it affects productivity in bigger 
> projects big time. To improve usability of returned message a Maven should 
> return {{-rf groupId:artifactId}} once artifact id is not unique.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (MNG-6410) Add groupId to --resume-from suggestion if artifactId is not unique in reactor

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MNG-6410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov reassigned MNG-6410:
---

Assignee: Michael Osipov

> Add groupId to --resume-from suggestion if artifactId is not unique in reactor
> --
>
> Key: MNG-6410
> URL: https://issues.apache.org/jira/browse/MNG-6410
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.5.3
>Reporter: Łukasz Dywicki
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4-candidate
>
>
> In multi module builds same artifact id can be repeated with different group 
> id. For example if project strategy is to use nesting of modules, instead of 
> using long artifact names, {{ap}} or {{model}} module can occur multiple 
> times with different group id.
> By default maven, upon failed build, prints out only {{-rf :artifactId}}. 
> When developer will copy given suggestion and run build again then his build 
> will be started from first module which have given artifact id.
> While severity of this bug is quite low, it affects productivity in bigger 
> projects big time. To improve usability of returned message a Maven should 
> return {{-rf groupId:artifactId}} once artifact id is not unique.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6411) Improve readability of project list returned when --resume-from option value is invalid

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481184#comment-16481184
 ] 

Hudson commented on MNG-6411:
-

Build failed in Jenkins: Maven TLP » maven » master #14

See https://builds.apache.org/job/maven-box/job/maven/job/master/14/

> Improve readability of project list returned when --resume-from option value 
> is invalid
> ---
>
> Key: MNG-6411
> URL: https://issues.apache.org/jira/browse/MNG-6411
> Project: Maven
>  Issue Type: Improvement
>  Components: Command Line
>Affects Versions: 3.5.3
>Reporter: Łukasz Dywicki
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4
>
>
> When value passed for {{-rf}} option is invalid, a full list of details of 
> all projects in build is returned.
> This list contains too much information. For every project it includes 
> groupId, artifactId, version and pom location. While it is useful for 
> debugging purposes many, if not most, developers are interested in specific 
> coordinate (groupId:artifactId) which should be passed to next execution, and 
> which is valid {{-rf}} optional value.
> *Note that below outputs contain new lines for ease of read*. This could be 
> also added to exception message to make it more readable.
> Assuming, that I've passed -rf :x Current output in case of failure:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
>   MavenProject: com.example:foobar:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/pom.xml,
>   MavenProject: com.example.foobar:parent:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/parent/pom.xml,
>   MavenProject: com.example.foobar:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/api/pom.xml,
>   MavenProject: com.example.foobar:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/model/pom.xml,
>   MavenProject: com.example.foobar:csv:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/pom.xml,
>   MavenProject: com.example.foobar.csv:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/model/pom.xml,
>   MavenProject: com.example.foobar.csv:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/api/pom.xml,
>   MavenProject: com.example.foobar:json:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/pom.xml,
>   MavenProject: com.example.foobar.json:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/model/pom.xml,
>   MavenProject: com.example.foobar.json:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/api/pom.xml,
>   MavenProject: com.example.foobar.json:core:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/core/pom.xml,
>   MavenProject: com.example.foobar:fax:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/pom.xml,
>   MavenProject: com.example.foobar.fax:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/api/pom.xml,
>   MavenProject: com.example.foobar.fax:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/model/pom.xml,
>   MavenProject: com.example.foobar.fax:web:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/pom.xml,
>   MavenProject: com.example.foobar.fax.web:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/api/pom.xml,
>   MavenProject: com.example.foobar.fax.web:core:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/core/pom.xml] -> [Help 1]
> {noformat}
> Additional information about pom locations is irrelevant from message point 
> of view, because valid input for -rf option is presented below:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
>   com.example:foobar,
>   com.example.foobar:parent,
>   com.example.foobar:api,
>   com.example.foobar:model,
>   com.example.foobar:csv,
>   com.example.foobar.csv:model,
>   com.example.foobar.csv:api,
>   com.example.foobar:json,
>   com.example.foobar.json:model,
>   com.example.foobar.json:api,
>   com.example.foobar.json:core,
>   com.example.foobar:fax,
>   com.example.foobar.fax:api,
>   com.example.foobar.fax:model,
>   com.example.foobar.fax:web,
>   com.example.foobar.fax.web:api,
>   com.example.foobar.fax.web:core] -> [Help 1]
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MJLINK-17) Add documentation information for GitHub

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MJLINK-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481178#comment-16481178
 ] 

Hudson commented on MJLINK-17:
--

Build succeeded in Jenkins: Maven TLP » maven-jlink-plugin » master #10

See 
https://builds.apache.org/job/maven-box/job/maven-jlink-plugin/job/master/10/

> Add documentation information for GitHub
> 
>
> Key: MJLINK-17
> URL: https://issues.apache.org/jira/browse/MJLINK-17
> Project: Maven JLink Plugin
>  Issue Type: Dependency upgrade
>Affects Versions: 3.0.0-alpha-2
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.0.0-alpha-2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [GitHub] asfgit closed pull request #164: [MNG-6411] Improve readability of project list for resume option.

[Vishal Kumar Gupta]

On Sat, May 19, 2018, 2:18 AM GitBox  wrote:

> asfgit closed pull request #164: [MNG-6411] Improve readability of project
> list for resume option.
> URL: https://github.com/apache/maven/pull/164
>
>
>
>
> This is a PR merged from a forked repository.
> As GitHub hides the original diff on merge, it is displayed below for
> the sake of provenance:
>
> As this is a foreign pull request (from a fork), the diff is supplied
> below (as it won't show otherwise due to GitHub magic):
>
> diff --git
> a/maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
> b/maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
> index ec72e8d81d..fb7a9f4506 100644
> ---
> a/maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
> +++
> b/maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
> @@ -25,6 +25,7 @@
>  import java.util.Collection;
>  import java.util.Collections;
>  import java.util.HashMap;
> +import java.util.Iterator;
>  import java.util.LinkedHashSet;
>  import java.util.List;
>  import java.util.Map;
> @@ -311,13 +312,29 @@ else if ( StringUtils.isNotEmpty(
> request.getMakeBehavior() ) )
>  if ( !resumed )
>  {
>  throw new MavenExecutionException( "Could not find
> project to resume reactor build from: " + selector
> -+ " vs " + projects, request.getPom() );
> ++ " vs " + formatProjects( projects ),
> request.getPom() );
>  }
>  }
>
>  return result;
>  }
>
> +private String formatProjects( List projects )
> +{
> +StringBuilder projectNames = new StringBuilder();
> +Iterator iterator = projects.iterator();
> +while ( iterator.hasNext() )
> +{
> +MavenProject project = iterator.next();
> +projectNames.append( project.getGroupId() ).append( ":"
> ).append( project.getArtifactId() );
> +if ( iterator.hasNext() )
> +{
> +projectNames.append( ", " );
> +}
> +}
> +return projectNames.toString();
> +}
> +
>  private boolean isMatchingProject( MavenProject project, String
> selector, File reactorDirectory )
>  {
>  // [groupId]:artifactId
>
>
>
>
> 
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> us...@infra.apache.org
>
>
> With regards,
> Apache Git Services
>

[jira] [Closed] (MNG-6411) Improve readability of project list returned when --resume-from option value is invalid

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MNG-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MNG-6411.
---
Resolution: Fixed

Fixed with 
[454a4e7954deb94e8d10f916405a6a5f6137c0fc|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=454a4e7954deb94e8d10f916405a6a5f6137c0fc].

> Improve readability of project list returned when --resume-from option value 
> is invalid
> ---
>
> Key: MNG-6411
> URL: https://issues.apache.org/jira/browse/MNG-6411
> Project: Maven
>  Issue Type: Improvement
>  Components: Command Line
>Affects Versions: 3.5.3
>Reporter: Łukasz Dywicki
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4
>
>
> When value passed for {{-rf}} option is invalid, a full list of details of 
> all projects in build is returned.
> This list contains too much information. For every project it includes 
> groupId, artifactId, version and pom location. While it is useful for 
> debugging purposes many, if not most, developers are interested in specific 
> coordinate (groupId:artifactId) which should be passed to next execution, and 
> which is valid {{-rf}} optional value.
> *Note that below outputs contain new lines for ease of read*. This could be 
> also added to exception message to make it more readable.
> Assuming, that I've passed -rf :x Current output in case of failure:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
>   MavenProject: com.example:foobar:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/pom.xml,
>   MavenProject: com.example.foobar:parent:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/parent/pom.xml,
>   MavenProject: com.example.foobar:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/api/pom.xml,
>   MavenProject: com.example.foobar:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/model/pom.xml,
>   MavenProject: com.example.foobar:csv:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/pom.xml,
>   MavenProject: com.example.foobar.csv:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/model/pom.xml,
>   MavenProject: com.example.foobar.csv:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/api/pom.xml,
>   MavenProject: com.example.foobar:json:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/pom.xml,
>   MavenProject: com.example.foobar.json:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/model/pom.xml,
>   MavenProject: com.example.foobar.json:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/api/pom.xml,
>   MavenProject: com.example.foobar.json:core:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/core/pom.xml,
>   MavenProject: com.example.foobar:fax:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/pom.xml,
>   MavenProject: com.example.foobar.fax:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/api/pom.xml,
>   MavenProject: com.example.foobar.fax:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/model/pom.xml,
>   MavenProject: com.example.foobar.fax:web:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/pom.xml,
>   MavenProject: com.example.foobar.fax.web:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/api/pom.xml,
>   MavenProject: com.example.foobar.fax.web:core:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/core/pom.xml] -> [Help 1]
> {noformat}
> Additional information about pom locations is irrelevant from message point 
> of view, because valid input for -rf option is presented below:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
>   com.example:foobar,
>   com.example.foobar:parent,
>   com.example.foobar:api,
>   com.example.foobar:model,
>   com.example.foobar:csv,
>   com.example.foobar.csv:model,
>   com.example.foobar.csv:api,
>   com.example.foobar:json,
>   com.example.foobar.json:model,
>   com.example.foobar.json:api,
>   com.example.foobar.json:core,
>   com.example.foobar:fax,
>   com.example.foobar.fax:api,
>   com.example.foobar.fax:model,
>   com.example.foobar.fax:web,
>   com.example.foobar.fax.web:api,
>   com.example.foobar.fax.web:core] -> [Help 1]
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6411) Improve readability of project list returned when --resume-from option value is invalid

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481176#comment-16481176
 ] 

ASF GitHub Bot commented on MNG-6411:
-

asfgit closed pull request #164: [MNG-6411] Improve readability of project list 
for resume option.
URL: https://github.com/apache/maven/pull/164
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java 
b/maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
index ec72e8d81d..fb7a9f4506 100644
--- a/maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
+++ b/maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
@@ -25,6 +25,7 @@
 import java.util.Collection;
 import java.util.Collections;
 import java.util.HashMap;
+import java.util.Iterator;
 import java.util.LinkedHashSet;
 import java.util.List;
 import java.util.Map;
@@ -311,13 +312,29 @@ else if ( StringUtils.isNotEmpty( 
request.getMakeBehavior() ) )
 if ( !resumed )
 {
 throw new MavenExecutionException( "Could not find project to 
resume reactor build from: " + selector
-+ " vs " + projects, request.getPom() );
++ " vs " + formatProjects( projects ), request.getPom() );
 }
 }
 
 return result;
 }
 
+private String formatProjects( List projects )
+{
+StringBuilder projectNames = new StringBuilder();
+Iterator iterator = projects.iterator();
+while ( iterator.hasNext() )
+{
+MavenProject project = iterator.next();
+projectNames.append( project.getGroupId() ).append( ":" ).append( 
project.getArtifactId() );
+if ( iterator.hasNext() )
+{
+projectNames.append( ", " );
+}
+}
+return projectNames.toString();
+}
+
 private boolean isMatchingProject( MavenProject project, String selector, 
File reactorDirectory )
 {
 // [groupId]:artifactId


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improve readability of project list returned when --resume-from option value 
> is invalid
> ---
>
> Key: MNG-6411
> URL: https://issues.apache.org/jira/browse/MNG-6411
> Project: Maven
>  Issue Type: Improvement
>  Components: Command Line
>Affects Versions: 3.5.3
>Reporter: Łukasz Dywicki
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4
>
>
> When value passed for {{-rf}} option is invalid, a full list of details of 
> all projects in build is returned.
> This list contains too much information. For every project it includes 
> groupId, artifactId, version and pom location. While it is useful for 
> debugging purposes many, if not most, developers are interested in specific 
> coordinate (groupId:artifactId) which should be passed to next execution, and 
> which is valid {{-rf}} optional value.
> *Note that below outputs contain new lines for ease of read*. This could be 
> also added to exception message to make it more readable.
> Assuming, that I've passed -rf :x Current output in case of failure:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
>   MavenProject: com.example:foobar:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/pom.xml,
>   MavenProject: com.example.foobar:parent:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/parent/pom.xml,
>   MavenProject: com.example.foobar:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/api/pom.xml,
>   MavenProject: com.example.foobar:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/model/pom.xml,
>   MavenProject: com.example.foobar:csv:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/pom.xml,
>   MavenProject: com.example.foobar.csv:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/model/pom.xml,
>   MavenProject: com.example.foobar.csv:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/api/pom.xml,
>   MavenProject: com.example.foobar:json:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/pom.xml,
>   MavenProject: com.example.foobar.json:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/model/pom.xml,
>   MavenProject: com.example.foobar.json:api:1.0.0-SNAPSHOT @ 
> 

[GitHub] asfgit closed pull request #164: [MNG-6411] Improve readability of project list for resume option.

[GitBox]

asfgit closed pull request #164: [MNG-6411] Improve readability of project list 
for resume option.
URL: https://github.com/apache/maven/pull/164
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java 
b/maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
index ec72e8d81d..fb7a9f4506 100644
--- a/maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
+++ b/maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
@@ -25,6 +25,7 @@
 import java.util.Collection;
 import java.util.Collections;
 import java.util.HashMap;
+import java.util.Iterator;
 import java.util.LinkedHashSet;
 import java.util.List;
 import java.util.Map;
@@ -311,13 +312,29 @@ else if ( StringUtils.isNotEmpty( 
request.getMakeBehavior() ) )
 if ( !resumed )
 {
 throw new MavenExecutionException( "Could not find project to 
resume reactor build from: " + selector
-+ " vs " + projects, request.getPom() );
++ " vs " + formatProjects( projects ), request.getPom() );
 }
 }
 
 return result;
 }
 
+private String formatProjects( List projects )
+{
+StringBuilder projectNames = new StringBuilder();
+Iterator iterator = projects.iterator();
+while ( iterator.hasNext() )
+{
+MavenProject project = iterator.next();
+projectNames.append( project.getGroupId() ).append( ":" ).append( 
project.getArtifactId() );
+if ( iterator.hasNext() )
+{
+projectNames.append( ", " );
+}
+}
+return projectNames.toString();
+}
+
 private boolean isMatchingProject( MavenProject project, String selector, 
File reactorDirectory )
 {
 // [groupId]:artifactId


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (MNG-6411) Improve readability of project list returned when --resume-from option value is invalid

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MNG-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-6411:

Summary: Improve readability of project list returned when --resume-from 
option value is invalid  (was: Improve readability of project list returned 
when resume from flag is invalid)

> Improve readability of project list returned when --resume-from option value 
> is invalid
> ---
>
> Key: MNG-6411
> URL: https://issues.apache.org/jira/browse/MNG-6411
> Project: Maven
>  Issue Type: Improvement
>  Components: Command Line
>Affects Versions: 3.5.3
>Reporter: Łukasz Dywicki
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4
>
>
> When value passed for {{-rf}} option is invalid, a full list of details of 
> all projects in build is returned.
> This list contains too much information. For every project it includes 
> groupId, artifactId, version and pom location. While it is useful for 
> debugging purposes many, if not most, developers are interested in specific 
> coordinate (groupId:artifactId) which should be passed to next execution, and 
> which is valid {{-rf}} optional value.
> *Note that below outputs contain new lines for ease of read*. This could be 
> also added to exception message to make it more readable.
> Assuming, that I've passed -rf :x Current output in case of failure:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
>   MavenProject: com.example:foobar:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/pom.xml,
>   MavenProject: com.example.foobar:parent:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/parent/pom.xml,
>   MavenProject: com.example.foobar:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/api/pom.xml,
>   MavenProject: com.example.foobar:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/model/pom.xml,
>   MavenProject: com.example.foobar:csv:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/pom.xml,
>   MavenProject: com.example.foobar.csv:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/model/pom.xml,
>   MavenProject: com.example.foobar.csv:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/api/pom.xml,
>   MavenProject: com.example.foobar:json:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/pom.xml,
>   MavenProject: com.example.foobar.json:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/model/pom.xml,
>   MavenProject: com.example.foobar.json:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/api/pom.xml,
>   MavenProject: com.example.foobar.json:core:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/core/pom.xml,
>   MavenProject: com.example.foobar:fax:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/pom.xml,
>   MavenProject: com.example.foobar.fax:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/api/pom.xml,
>   MavenProject: com.example.foobar.fax:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/model/pom.xml,
>   MavenProject: com.example.foobar.fax:web:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/pom.xml,
>   MavenProject: com.example.foobar.fax.web:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/api/pom.xml,
>   MavenProject: com.example.foobar.fax.web:core:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/core/pom.xml] -> [Help 1]
> {noformat}
> Additional information about pom locations is irrelevant from message point 
> of view, because valid input for -rf option is presented below:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
>   com.example:foobar,
>   com.example.foobar:parent,
>   com.example.foobar:api,
>   com.example.foobar:model,
>   com.example.foobar:csv,
>   com.example.foobar.csv:model,
>   com.example.foobar.csv:api,
>   com.example.foobar:json,
>   com.example.foobar.json:model,
>   com.example.foobar.json:api,
>   com.example.foobar.json:core,
>   com.example.foobar:fax,
>   com.example.foobar.fax:api,
>   com.example.foobar.fax:model,
>   com.example.foobar.fax:web,
>   com.example.foobar.fax.web:api,
>   com.example.foobar.fax.web:core] -> [Help 1]
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (MNG-6411) Improve readability of project list returned when --resume-from option value is invalid

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MNG-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-6411:

Component/s: Command Line

> Improve readability of project list returned when --resume-from option value 
> is invalid
> ---
>
> Key: MNG-6411
> URL: https://issues.apache.org/jira/browse/MNG-6411
> Project: Maven
>  Issue Type: Improvement
>  Components: Command Line
>Affects Versions: 3.5.3
>Reporter: Łukasz Dywicki
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4
>
>
> When value passed for {{-rf}} option is invalid, a full list of details of 
> all projects in build is returned.
> This list contains too much information. For every project it includes 
> groupId, artifactId, version and pom location. While it is useful for 
> debugging purposes many, if not most, developers are interested in specific 
> coordinate (groupId:artifactId) which should be passed to next execution, and 
> which is valid {{-rf}} optional value.
> *Note that below outputs contain new lines for ease of read*. This could be 
> also added to exception message to make it more readable.
> Assuming, that I've passed -rf :x Current output in case of failure:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
>   MavenProject: com.example:foobar:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/pom.xml,
>   MavenProject: com.example.foobar:parent:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/parent/pom.xml,
>   MavenProject: com.example.foobar:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/api/pom.xml,
>   MavenProject: com.example.foobar:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/model/pom.xml,
>   MavenProject: com.example.foobar:csv:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/pom.xml,
>   MavenProject: com.example.foobar.csv:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/model/pom.xml,
>   MavenProject: com.example.foobar.csv:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/api/pom.xml,
>   MavenProject: com.example.foobar:json:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/pom.xml,
>   MavenProject: com.example.foobar.json:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/model/pom.xml,
>   MavenProject: com.example.foobar.json:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/api/pom.xml,
>   MavenProject: com.example.foobar.json:core:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/core/pom.xml,
>   MavenProject: com.example.foobar:fax:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/pom.xml,
>   MavenProject: com.example.foobar.fax:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/api/pom.xml,
>   MavenProject: com.example.foobar.fax:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/model/pom.xml,
>   MavenProject: com.example.foobar.fax:web:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/pom.xml,
>   MavenProject: com.example.foobar.fax.web:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/api/pom.xml,
>   MavenProject: com.example.foobar.fax.web:core:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/core/pom.xml] -> [Help 1]
> {noformat}
> Additional information about pom locations is irrelevant from message point 
> of view, because valid input for -rf option is presented below:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
>   com.example:foobar,
>   com.example.foobar:parent,
>   com.example.foobar:api,
>   com.example.foobar:model,
>   com.example.foobar:csv,
>   com.example.foobar.csv:model,
>   com.example.foobar.csv:api,
>   com.example.foobar:json,
>   com.example.foobar.json:model,
>   com.example.foobar.json:api,
>   com.example.foobar.json:core,
>   com.example.foobar:fax,
>   com.example.foobar.fax:api,
>   com.example.foobar.fax:model,
>   com.example.foobar.fax:web,
>   com.example.foobar.fax.web:api,
>   com.example.foobar.fax.web:core] -> [Help 1]
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (MNG-6411) Improve readability of project list returned when resume from flag is invalid

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MNG-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-6411:

Fix Version/s: (was: 3.5.4-candidate)
   3.5.4

> Improve readability of project list returned when resume from flag is invalid
> -
>
> Key: MNG-6411
> URL: https://issues.apache.org/jira/browse/MNG-6411
> Project: Maven
>  Issue Type: Improvement
>Affects Versions: 3.5.3
>Reporter: Łukasz Dywicki
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4
>
>
> When value passed for {{-rf}} option is invalid, a full list of details of 
> all projects in build is returned.
> This list contains too much information. For every project it includes 
> groupId, artifactId, version and pom location. While it is useful for 
> debugging purposes many, if not most, developers are interested in specific 
> coordinate (groupId:artifactId) which should be passed to next execution, and 
> which is valid {{-rf}} optional value.
> *Note that below outputs contain new lines for ease of read*. This could be 
> also added to exception message to make it more readable.
> Assuming, that I've passed -rf :x Current output in case of failure:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
>   MavenProject: com.example:foobar:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/pom.xml,
>   MavenProject: com.example.foobar:parent:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/parent/pom.xml,
>   MavenProject: com.example.foobar:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/api/pom.xml,
>   MavenProject: com.example.foobar:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/model/pom.xml,
>   MavenProject: com.example.foobar:csv:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/pom.xml,
>   MavenProject: com.example.foobar.csv:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/model/pom.xml,
>   MavenProject: com.example.foobar.csv:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/api/pom.xml,
>   MavenProject: com.example.foobar:json:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/pom.xml,
>   MavenProject: com.example.foobar.json:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/model/pom.xml,
>   MavenProject: com.example.foobar.json:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/api/pom.xml,
>   MavenProject: com.example.foobar.json:core:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/core/pom.xml,
>   MavenProject: com.example.foobar:fax:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/pom.xml,
>   MavenProject: com.example.foobar.fax:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/api/pom.xml,
>   MavenProject: com.example.foobar.fax:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/model/pom.xml,
>   MavenProject: com.example.foobar.fax:web:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/pom.xml,
>   MavenProject: com.example.foobar.fax.web:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/api/pom.xml,
>   MavenProject: com.example.foobar.fax.web:core:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/core/pom.xml] -> [Help 1]
> {noformat}
> Additional information about pom locations is irrelevant from message point 
> of view, because valid input for -rf option is presented below:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
>   com.example:foobar,
>   com.example.foobar:parent,
>   com.example.foobar:api,
>   com.example.foobar:model,
>   com.example.foobar:csv,
>   com.example.foobar.csv:model,
>   com.example.foobar.csv:api,
>   com.example.foobar:json,
>   com.example.foobar.json:model,
>   com.example.foobar.json:api,
>   com.example.foobar.json:core,
>   com.example.foobar:fax,
>   com.example.foobar.fax:api,
>   com.example.foobar.fax:model,
>   com.example.foobar.fax:web,
>   com.example.foobar.fax.web:api,
>   com.example.foobar.fax.web:core] -> [Help 1]
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (MNG-6411) Improve readability of project list returned when resume from flag is invalid

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MNG-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov reassigned MNG-6411:
---

Assignee: Michael Osipov

> Improve readability of project list returned when resume from flag is invalid
> -
>
> Key: MNG-6411
> URL: https://issues.apache.org/jira/browse/MNG-6411
> Project: Maven
>  Issue Type: Improvement
>Affects Versions: 3.5.3
>Reporter: Łukasz Dywicki
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4
>
>
> When value passed for {{-rf}} option is invalid, a full list of details of 
> all projects in build is returned.
> This list contains too much information. For every project it includes 
> groupId, artifactId, version and pom location. While it is useful for 
> debugging purposes many, if not most, developers are interested in specific 
> coordinate (groupId:artifactId) which should be passed to next execution, and 
> which is valid {{-rf}} optional value.
> *Note that below outputs contain new lines for ease of read*. This could be 
> also added to exception message to make it more readable.
> Assuming, that I've passed -rf :x Current output in case of failure:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
>   MavenProject: com.example:foobar:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/pom.xml,
>   MavenProject: com.example.foobar:parent:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/parent/pom.xml,
>   MavenProject: com.example.foobar:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/api/pom.xml,
>   MavenProject: com.example.foobar:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/model/pom.xml,
>   MavenProject: com.example.foobar:csv:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/pom.xml,
>   MavenProject: com.example.foobar.csv:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/model/pom.xml,
>   MavenProject: com.example.foobar.csv:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/api/pom.xml,
>   MavenProject: com.example.foobar:json:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/pom.xml,
>   MavenProject: com.example.foobar.json:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/model/pom.xml,
>   MavenProject: com.example.foobar.json:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/api/pom.xml,
>   MavenProject: com.example.foobar.json:core:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/core/pom.xml,
>   MavenProject: com.example.foobar:fax:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/pom.xml,
>   MavenProject: com.example.foobar.fax:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/api/pom.xml,
>   MavenProject: com.example.foobar.fax:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/model/pom.xml,
>   MavenProject: com.example.foobar.fax:web:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/pom.xml,
>   MavenProject: com.example.foobar.fax.web:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/api/pom.xml,
>   MavenProject: com.example.foobar.fax.web:core:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/core/pom.xml] -> [Help 1]
> {noformat}
> Additional information about pom locations is irrelevant from message point 
> of view, because valid input for -rf option is presented below:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
>   com.example:foobar,
>   com.example.foobar:parent,
>   com.example.foobar:api,
>   com.example.foobar:model,
>   com.example.foobar:csv,
>   com.example.foobar.csv:model,
>   com.example.foobar.csv:api,
>   com.example.foobar:json,
>   com.example.foobar.json:model,
>   com.example.foobar.json:api,
>   com.example.foobar.json:core,
>   com.example.foobar:fax,
>   com.example.foobar.fax:api,
>   com.example.foobar.fax:model,
>   com.example.foobar.fax:web,
>   com.example.foobar.fax.web:api,
>   com.example.foobar.fax.web:core] -> [Help 1]
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6411) Improve readability of project list returned when resume from flag is invalid

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481145#comment-16481145
 ] 

ASF GitHub Bot commented on MNG-6411:
-

michael-o commented on issue #164: [MNG-6411] Improve readability of project 
list for resume option.
URL: https://github.com/apache/maven/pull/164#issuecomment-390320692
 
 
   This PR looks perfectly fine now to me.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improve readability of project list returned when resume from flag is invalid
> -
>
> Key: MNG-6411
> URL: https://issues.apache.org/jira/browse/MNG-6411
> Project: Maven
>  Issue Type: Improvement
>Affects Versions: 3.5.3
>Reporter: Łukasz Dywicki
>Priority: Minor
> Fix For: 3.5.4-candidate
>
>
> When value passed for {{-rf}} option is invalid, a full list of details of 
> all projects in build is returned.
> This list contains too much information. For every project it includes 
> groupId, artifactId, version and pom location. While it is useful for 
> debugging purposes many, if not most, developers are interested in specific 
> coordinate (groupId:artifactId) which should be passed to next execution, and 
> which is valid {{-rf}} optional value.
> *Note that below outputs contain new lines for ease of read*. This could be 
> also added to exception message to make it more readable.
> Assuming, that I've passed -rf :x Current output in case of failure:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
>   MavenProject: com.example:foobar:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/pom.xml,
>   MavenProject: com.example.foobar:parent:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/parent/pom.xml,
>   MavenProject: com.example.foobar:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/api/pom.xml,
>   MavenProject: com.example.foobar:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/model/pom.xml,
>   MavenProject: com.example.foobar:csv:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/pom.xml,
>   MavenProject: com.example.foobar.csv:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/model/pom.xml,
>   MavenProject: com.example.foobar.csv:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/csv/api/pom.xml,
>   MavenProject: com.example.foobar:json:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/pom.xml,
>   MavenProject: com.example.foobar.json:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/model/pom.xml,
>   MavenProject: com.example.foobar.json:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/api/pom.xml,
>   MavenProject: com.example.foobar.json:core:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/json/core/pom.xml,
>   MavenProject: com.example.foobar:fax:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/pom.xml,
>   MavenProject: com.example.foobar.fax:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/api/pom.xml,
>   MavenProject: com.example.foobar.fax:model:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/model/pom.xml,
>   MavenProject: com.example.foobar.fax:web:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/pom.xml,
>   MavenProject: com.example.foobar.fax.web:api:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/api/pom.xml,
>   MavenProject: com.example.foobar.fax.web:core:1.0.0-SNAPSHOT @ 
> ~/sources/foobar/fax/web/core/pom.xml] -> [Help 1]
> {noformat}
> Additional information about pom locations is irrelevant from message point 
> of view, because valid input for -rf option is presented below:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
>   com.example:foobar,
>   com.example.foobar:parent,
>   com.example.foobar:api,
>   com.example.foobar:model,
>   com.example.foobar:csv,
>   com.example.foobar.csv:model,
>   com.example.foobar.csv:api,
>   com.example.foobar:json,
>   com.example.foobar.json:model,
>   com.example.foobar.json:api,
>   com.example.foobar.json:core,
>   com.example.foobar:fax,
>   com.example.foobar.fax:api,
>   com.example.foobar.fax:model,
>   com.example.foobar.fax:web,
>   com.example.foobar.fax.web:api,
>   com.example.foobar.fax.web:core] -> [Help 1]
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] michael-o commented on issue #164: [MNG-6411] Improve readability of project list for resume option.

[GitBox]

michael-o commented on issue #164: [MNG-6411] Improve readability of project 
list for resume option.
URL: https://github.com/apache/maven/pull/164#issuecomment-390320692
 
 
   This PR looks perfectly fine now to me.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481141#comment-16481141
 ] 

ASF GitHub Bot commented on SCM-885:


michael-o commented on issue #74: [SCM-885] third implementation
URL: https://github.com/apache/maven-scm/pull/74#issuecomment-390320081
 
 
   Why did you rename the test repo and have added a new one? What was actually 
wrong with the given one? The are a lot of sample hooks which aren't 
superfluous for the test (they may have existed in the previous repo also).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> GitChangeLogCommand is wrong when only endVersion is set
> 
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.6
>
> Attachments: scm-885-different-behavior-exe-jgit-patch.diff
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has 
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso  ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso  END_REVISION_SHA1 -- PROJECT_PATH}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] michael-o commented on issue #74: [SCM-885] third implementation

[GitBox]

michael-o commented on issue #74: [SCM-885] third implementation
URL: https://github.com/apache/maven-scm/pull/74#issuecomment-390320081
 
 
   Why did you rename the test repo and have added a new one? What was actually 
wrong with the given one? The are a lot of sample hooks which aren't 
superfluous for the test (they may have existed in the previous repo also).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [GitHub] michael-o commented on a change in pull request #74: [SCM-885] third implementation

[Vishal Kumar Gupta]

michael-o commented on a change in pull request #74: [SCM-885] third
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189381717



 ##
 File path: maven-scm-providers/maven-scm-providers-git/maven-scm-
provider-gitexe/src/main/java/org/apache/maven/scm/provider/
git/gitexe/command/changelog/GitChangeLogCommand.java
 ##
 @@ -136,9 +155,18 @@ public static Commandline createCommandLine(
GitScmProviderRepository repository
   null );
 }

+static Commandline createCommandLine( GitScmProviderRepository
repository, File workingDirectory,
+  ScmBranch branch, Date
startDate, Date endDate,
+  ScmVersion startVersion,
ScmVersion endVersion, Integer limit)
+{
+return createCommandLine( repository, workingDirectory, branch,
startDate, endDate, startVersion, endVersion,
+limit, null );

 Review comment:
   indent continuation


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services



On Sat, May 19, 2018 at 1:42 AM, GitBox  wrote:

> michael-o commented on a change in pull request #74: [SCM-885] third
> implementation
> URL: https://github.com/apache/maven-scm/pull/74#discussion_r189381570
>
>
>
>  ##
>  File path: maven-scm-api/src/main/java/org/apache/maven/scm/command/
> changelog/AbstractChangeLogCommand.java
>  ##
>  @@ -76,13 +84,21 @@ public ScmResult executeCommand(
> ScmProviderRepository repository, ScmFileSet fi
>
>  ScmBranch branch = (ScmBranch) parameters.getScmVersion(
> CommandParameter.BRANCH, null );
>
> +ScmVersion version = parameters.getScmVersion(
> CommandParameter.SCM_VERSION, null );
> +
>  ScmVersion startVersion = parameters.getScmVersion(
> CommandParameter.START_SCM_VERSION, null );
>
>  ScmVersion endVersion = parameters.getScmVersion(
> CommandParameter.END_SCM_VERSION, null );
>
>  String datePattern = parameters.getString(
> CommandParameter.CHANGELOG_DATE_PATTERN, null );
>
> -if ( startVersion != null || endVersion != null )
> +boolean fromVersionToStartOfRepository = startVersion == null &&
> endVersion == null && version != null;
> +
> +if (fromVersionToStartOfRepository)
>
>  Review comment:
>spaces please
>
> 
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> us...@infra.apache.org
>
>
> With regards,
> Apache Git Services
>

Re: [GitHub] michael-o commented on a change in pull request #74: [SCM-885] third implementation

[Vishal Kumar Gupta]

michael-o commented on a change in pull request #74: [SCM-885] third
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189381717



 ##
 File path: maven-scm-providers/maven-scm-providers-git/maven-scm-
provider-gitexe/src/main/java/org/apache/maven/scm/provider/
git/gitexe/command/changelog/GitChangeLogCommand.java
 ##
 @@ -136,9 +155,18 @@ public static Commandline createCommandLine(
GitScmProviderRepository repository
   null );
 }

+static Commandline createCommandLine( GitScmProviderRepository
repository, File workingDirectory,
+  ScmBranch branch, Date
startDate, Date endDate,
+  ScmVersion startVersion,
ScmVersion endVersion, Integer limit)
+{
+return createCommandLine( repository, workingDirectory, branch,
startDate, endDate, startVersion, endVersion,
+limit, null );

 Review comment:
   indent continuation


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services



On Sat, May 19, 2018 at 1:42 AM, GitBox  wrote:

> michael-o commented on a change in pull request #74: [SCM-885] third
> implementation
> URL: https://github.com/apache/maven-scm/pull/74#discussion_r189381637
>
>
>
>  ##
>  File path: maven-scm-providers/maven-scm-providers-git/maven-scm-
> provider-gitexe/src/main/java/org/apache/maven/scm/provider/
> git/gitexe/command/changelog/GitChangeLogCommand.java
>  ##
>  @@ -69,14 +69,22 @@ protected ChangeLogScmResult executeChangeLogCommand(
> ScmProviderRepository repo
>  return executeChangeLogCommand( repo, fileSet, startDate,
> endDate, branch, datePattern, null, null );
>  }
>
> -protected ChangeLogScmResult executeChangeLogCommand(
> ScmProviderRepository repo, ScmFileSet fileSet,
> -  Date startDate,
> Date endDate, ScmBranch branch,
> -  String
> datePattern, ScmVersion startVersion,
> -  ScmVersion
> endVersion )
> +@Override
> +protected ChangeLogScmResult executeChangeLogCommand(
> ScmProviderRepository repository, ScmFileSet fileSet,
> +  ScmVersion
> version, String datePattern)
> +throws ScmException
> +{
> +return executeChangeLogCommand( repository, fileSet, null, null,
> null, datePattern, null, null, null, version );
> +}
> +
> +protected ChangeLogScmResult 
> executeChangeLogCommand(ScmProviderRepository
> repo, ScmFileSet fileSet,
>
>  Review comment:
>space please.
>
> 
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> us...@infra.apache.org
>
>
> With regards,
> Apache Git Services
>

[jira] [Commented] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481137#comment-16481137
 ] 

ASF GitHub Bot commented on SCM-885:


michael-o commented on a change in pull request #74: [SCM-885] third 
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189381810
 
 

 ##
 File path: 
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/changelog/JGitChangeLogCommand.java
 ##
 @@ -64,6 +64,14 @@ protected ChangeLogScmResult executeChangeLogCommand( 
ScmProviderRepository repo
 return executeChangeLogCommand( repo, fileSet, null, null, null, 
datePattern, startVersion, endVersion );
 }
 
+@Override
+protected ChangeLogScmResult executeChangeLogCommand( 
ScmProviderRepository repository, ScmFileSet fileSet,
+  ScmVersion version, 
String datePattern)
 
 Review comment:
   space please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> GitChangeLogCommand is wrong when only endVersion is set
> 
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.6
>
> Attachments: scm-885-different-behavior-exe-jgit-patch.diff
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has 
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso  ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso  END_REVISION_SHA1 -- PROJECT_PATH}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481136#comment-16481136
 ] 

ASF GitHub Bot commented on SCM-885:


michael-o commented on a change in pull request #74: [SCM-885] third 
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189381717
 
 

 ##
 File path: 
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommand.java
 ##
 @@ -136,9 +155,18 @@ public static Commandline createCommandLine( 
GitScmProviderRepository repository
   null );
 }
 
+static Commandline createCommandLine( GitScmProviderRepository repository, 
File workingDirectory,
+  ScmBranch branch, Date startDate, 
Date endDate,
+  ScmVersion startVersion, ScmVersion 
endVersion, Integer limit)
+{
+return createCommandLine( repository, workingDirectory, branch, 
startDate, endDate, startVersion, endVersion,
+limit, null );
 
 Review comment:
   indent continuation


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> GitChangeLogCommand is wrong when only endVersion is set
> 
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.6
>
> Attachments: scm-885-different-behavior-exe-jgit-patch.diff
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has 
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso  ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso  END_REVISION_SHA1 -- PROJECT_PATH}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] michael-o commented on a change in pull request #74: [SCM-885] third implementation

[GitBox]

michael-o commented on a change in pull request #74: [SCM-885] third 
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189381810
 
 

 ##
 File path: 
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/changelog/JGitChangeLogCommand.java
 ##
 @@ -64,6 +64,14 @@ protected ChangeLogScmResult executeChangeLogCommand( 
ScmProviderRepository repo
 return executeChangeLogCommand( repo, fileSet, null, null, null, 
datePattern, startVersion, endVersion );
 }
 
+@Override
+protected ChangeLogScmResult executeChangeLogCommand( 
ScmProviderRepository repository, ScmFileSet fileSet,
+  ScmVersion version, 
String datePattern)
 
 Review comment:
   space please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [GitHub] michael-o commented on a change in pull request #74: [SCM-885] third implementation

[Vishal Kumar Gupta]

michael-o commented on a change in pull request #74: [SCM-885] third
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189381717



 ##
 File path: maven-scm-providers/maven-scm-providers-git/maven-scm-
provider-gitexe/src/main/java/org/apache/maven/scm/provider/
git/gitexe/command/changelog/GitChangeLogCommand.java
 ##
 @@ -136,9 +155,18 @@ public static Commandline createCommandLine(
GitScmProviderRepository repository
   null );
 }

+static Commandline createCommandLine( GitScmProviderRepository
repository, File workingDirectory,
+  ScmBranch branch, Date
startDate, Date endDate,
+  ScmVersion startVersion,
ScmVersion endVersion, Integer limit)
+{
+return createCommandLine( repository, workingDirectory, branch,
startDate, endDate, startVersion, endVersion,
+limit, null );

 Review comment:
   indent continuation


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services



On Sat, May 19, 2018 at 1:43 AM, GitBox  wrote:

> michael-o commented on a change in pull request #74: [SCM-885] third
> implementation
> URL: https://github.com/apache/maven-scm/pull/74#discussion_r189381717
>
>
>
>  ##
>  File path: maven-scm-providers/maven-scm-providers-git/maven-scm-
> provider-gitexe/src/main/java/org/apache/maven/scm/provider/
> git/gitexe/command/changelog/GitChangeLogCommand.java
>  ##
>  @@ -136,9 +155,18 @@ public static Commandline createCommandLine(
> GitScmProviderRepository repository
>null );
>  }
>
> +static Commandline createCommandLine( GitScmProviderRepository
> repository, File workingDirectory,
> +  ScmBranch branch, Date
> startDate, Date endDate,
> +  ScmVersion startVersion,
> ScmVersion endVersion, Integer limit)
> +{
> +return createCommandLine( repository, workingDirectory, branch,
> startDate, endDate, startVersion, endVersion,
> +limit, null );
>
>  Review comment:
>indent continuation
>
> 
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> us...@infra.apache.org
>
>
> With regards,
> Apache Git Services
>

Re: [GitHub] michael-o commented on a change in pull request #74: [SCM-885] third implementation

[Vishal Kumar Gupta]

michael-o commented on a change in pull request #74: [SCM-885] third
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189381471



 ##
 File path: maven-scm-api/src/main/java/org/apache/maven/scm/command/
changelog/AbstractChangeLogCommand.java
 ##
 @@ -55,6 +55,14 @@ protected ChangeLogScmResult executeChangeLogCommand(
ScmProviderRepository repo
 throw new ScmException( "Unsupported method for this provider." );
 }

+@Deprecated
+protected ChangeLogScmResult executeChangeLogCommand(
ScmProviderRepository repository, ScmFileSet fileSet,
+  ScmVersion
version, String datePattern )
+throws ScmException

 Review comment:
   4 spaces please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services



On Sat, May 19, 2018 at 1:42 AM, GitBox  wrote:

> michael-o commented on a change in pull request #74: [SCM-885] third
> implementation
> URL: https://github.com/apache/maven-scm/pull/74#discussion_r189381471
>
>
>
>  ##
>  File path: maven-scm-api/src/main/java/org/apache/maven/scm/command/
> changelog/AbstractChangeLogCommand.java
>  ##
>  @@ -55,6 +55,14 @@ protected ChangeLogScmResult executeChangeLogCommand(
> ScmProviderRepository repo
>  throw new ScmException( "Unsupported method for this provider." );
>  }
>
> +@Deprecated
> +protected ChangeLogScmResult executeChangeLogCommand(
> ScmProviderRepository repository, ScmFileSet fileSet,
> +  ScmVersion
> version, String datePattern )
> +throws ScmException
>
>  Review comment:
>4 spaces please.
>
> 
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> us...@infra.apache.org
>
>
> With regards,
> Apache Git Services
>

[GitHub] michael-o commented on a change in pull request #74: [SCM-885] third implementation

[GitBox]

michael-o commented on a change in pull request #74: [SCM-885] third 
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189381717
 
 

 ##
 File path: 
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommand.java
 ##
 @@ -136,9 +155,18 @@ public static Commandline createCommandLine( 
GitScmProviderRepository repository
   null );
 }
 
+static Commandline createCommandLine( GitScmProviderRepository repository, 
File workingDirectory,
+  ScmBranch branch, Date startDate, 
Date endDate,
+  ScmVersion startVersion, ScmVersion 
endVersion, Integer limit)
+{
+return createCommandLine( repository, workingDirectory, branch, 
startDate, endDate, startVersion, endVersion,
+limit, null );
 
 Review comment:
   indent continuation


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481132#comment-16481132
 ] 

ASF GitHub Bot commented on SCM-885:


michael-o commented on a change in pull request #74: [SCM-885] third 
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189381471
 
 

 ##
 File path: 
maven-scm-api/src/main/java/org/apache/maven/scm/command/changelog/AbstractChangeLogCommand.java
 ##
 @@ -55,6 +55,14 @@ protected ChangeLogScmResult executeChangeLogCommand( 
ScmProviderRepository repo
 throw new ScmException( "Unsupported method for this provider." );
 }
 
+@Deprecated
+protected ChangeLogScmResult executeChangeLogCommand( 
ScmProviderRepository repository, ScmFileSet fileSet,
+  ScmVersion version, 
String datePattern )
+throws ScmException
 
 Review comment:
   4 spaces please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> GitChangeLogCommand is wrong when only endVersion is set
> 
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.6
>
> Attachments: scm-885-different-behavior-exe-jgit-patch.diff
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has 
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso  ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso  END_REVISION_SHA1 -- PROJECT_PATH}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481133#comment-16481133
 ] 

ASF GitHub Bot commented on SCM-885:


michael-o commented on a change in pull request #74: [SCM-885] third 
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189381570
 
 

 ##
 File path: 
maven-scm-api/src/main/java/org/apache/maven/scm/command/changelog/AbstractChangeLogCommand.java
 ##
 @@ -76,13 +84,21 @@ public ScmResult executeCommand( ScmProviderRepository 
repository, ScmFileSet fi
 
 ScmBranch branch = (ScmBranch) parameters.getScmVersion( 
CommandParameter.BRANCH, null );
 
+ScmVersion version = parameters.getScmVersion( 
CommandParameter.SCM_VERSION, null );
+
 ScmVersion startVersion = parameters.getScmVersion( 
CommandParameter.START_SCM_VERSION, null );
 
 ScmVersion endVersion = parameters.getScmVersion( 
CommandParameter.END_SCM_VERSION, null );
 
 String datePattern = parameters.getString( 
CommandParameter.CHANGELOG_DATE_PATTERN, null );
 
-if ( startVersion != null || endVersion != null )
+boolean fromVersionToStartOfRepository = startVersion == null && 
endVersion == null && version != null;
+
+if (fromVersionToStartOfRepository)
 
 Review comment:
   spaces please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> GitChangeLogCommand is wrong when only endVersion is set
> 
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.6
>
> Attachments: scm-885-different-behavior-exe-jgit-patch.diff
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has 
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso  ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso  END_REVISION_SHA1 -- PROJECT_PATH}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481134#comment-16481134
 ] 

ASF GitHub Bot commented on SCM-885:


michael-o commented on a change in pull request #74: [SCM-885] third 
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189381637
 
 

 ##
 File path: 
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommand.java
 ##
 @@ -69,14 +69,22 @@ protected ChangeLogScmResult executeChangeLogCommand( 
ScmProviderRepository repo
 return executeChangeLogCommand( repo, fileSet, startDate, endDate, 
branch, datePattern, null, null );
 }
 
-protected ChangeLogScmResult executeChangeLogCommand( 
ScmProviderRepository repo, ScmFileSet fileSet,
-  Date startDate, Date 
endDate, ScmBranch branch,
-  String datePattern, 
ScmVersion startVersion,
-  ScmVersion 
endVersion )
+@Override
+protected ChangeLogScmResult executeChangeLogCommand( 
ScmProviderRepository repository, ScmFileSet fileSet,
+  ScmVersion version, 
String datePattern)
+throws ScmException
+{
+return executeChangeLogCommand( repository, fileSet, null, null, null, 
datePattern, null, null, null, version );
+}
+
+protected ChangeLogScmResult executeChangeLogCommand(ScmProviderRepository 
repo, ScmFileSet fileSet,
 
 Review comment:
   space please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> GitChangeLogCommand is wrong when only endVersion is set
> 
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.6
>
> Attachments: scm-885-different-behavior-exe-jgit-patch.diff
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has 
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso  ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso  END_REVISION_SHA1 -- PROJECT_PATH}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] michael-o commented on a change in pull request #74: [SCM-885] third implementation

[GitBox]

michael-o commented on a change in pull request #74: [SCM-885] third 
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189381637
 
 

 ##
 File path: 
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommand.java
 ##
 @@ -69,14 +69,22 @@ protected ChangeLogScmResult executeChangeLogCommand( 
ScmProviderRepository repo
 return executeChangeLogCommand( repo, fileSet, startDate, endDate, 
branch, datePattern, null, null );
 }
 
-protected ChangeLogScmResult executeChangeLogCommand( 
ScmProviderRepository repo, ScmFileSet fileSet,
-  Date startDate, Date 
endDate, ScmBranch branch,
-  String datePattern, 
ScmVersion startVersion,
-  ScmVersion 
endVersion )
+@Override
+protected ChangeLogScmResult executeChangeLogCommand( 
ScmProviderRepository repository, ScmFileSet fileSet,
+  ScmVersion version, 
String datePattern)
+throws ScmException
+{
+return executeChangeLogCommand( repository, fileSet, null, null, null, 
datePattern, null, null, null, version );
+}
+
+protected ChangeLogScmResult executeChangeLogCommand(ScmProviderRepository 
repo, ScmFileSet fileSet,
 
 Review comment:
   space please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] michael-o commented on a change in pull request #74: [SCM-885] third implementation

[GitBox]

michael-o commented on a change in pull request #74: [SCM-885] third 
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189381570
 
 

 ##
 File path: 
maven-scm-api/src/main/java/org/apache/maven/scm/command/changelog/AbstractChangeLogCommand.java
 ##
 @@ -76,13 +84,21 @@ public ScmResult executeCommand( ScmProviderRepository 
repository, ScmFileSet fi
 
 ScmBranch branch = (ScmBranch) parameters.getScmVersion( 
CommandParameter.BRANCH, null );
 
+ScmVersion version = parameters.getScmVersion( 
CommandParameter.SCM_VERSION, null );
+
 ScmVersion startVersion = parameters.getScmVersion( 
CommandParameter.START_SCM_VERSION, null );
 
 ScmVersion endVersion = parameters.getScmVersion( 
CommandParameter.END_SCM_VERSION, null );
 
 String datePattern = parameters.getString( 
CommandParameter.CHANGELOG_DATE_PATTERN, null );
 
-if ( startVersion != null || endVersion != null )
+boolean fromVersionToStartOfRepository = startVersion == null && 
endVersion == null && version != null;
+
+if (fromVersionToStartOfRepository)
 
 Review comment:
   spaces please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [GitHub] michael-o commented on a change in pull request #74: [SCM-885] third implementation

[Vishal Kumar Gupta]

michael-o commented on a change in pull request #74: [SCM-885] third
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189380195



 ##
 File path: maven-scm-providers/maven-scm-providers-git/maven-scm-
provider-gitexe/src/main/java/org/apache/maven/scm/provider/
git/gitexe/command/changelog/GitChangeLogCommand.java
 ##
 @@ -69,14 +69,22 @@ protected ChangeLogScmResult executeChangeLogCommand(
ScmProviderRepository repo
 return executeChangeLogCommand( repo, fileSet, startDate, endDate,
branch, datePattern, null, null );
 }

+@Override
+protected ChangeLogScmResult executeChangeLogCommand(
ScmProviderRepository repository, ScmFileSet fileSet,
+  ScmVersion
version, String datePattern )
+throws ScmException
+{
+return executeChangeLogCommand( repository, fileSet, null, null,
null, datePattern, null, null, null, version );
+}
+
 protected ChangeLogScmResult executeChangeLogCommand(
ScmProviderRepository repo, ScmFileSet fileSet,
-  Date startDate,
Date endDate, ScmBranch branch,
-  String
datePattern, ScmVersion startVersion,
-  ScmVersion
endVersion )
+ Date startDate,
Date endDate, ScmBranch branch,
+ String
datePattern, ScmVersion startVersion,
+ ScmVersion
endVersion )

 Review comment:
   Indentation looks wrong. `Date` should align on `ScmProviderRepository`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

On Sat, May 19, 2018 at 1:41 AM, GitBox  wrote:

> michael-o commented on a change in pull request #74: [SCM-885] third
> implementation
> URL: https://github.com/apache/maven-scm/pull/74#discussion_r189381372
>
>
>
>  ##
>  File path: maven-scm-api/src/main/java/org/apache/maven/scm/command/
> changelog/ChangeLogScmRequest.java
>  ##
>  @@ -175,4 +175,15 @@ public void setDateRange( Date startDate, Date
> endDate )
>  setEndDate( endDate );
>  }
>
> +public void setRevision(ScmVersion revision)
>
>  Review comment:
>Please add the spaces between parenthesis.
>
> 
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> us...@infra.apache.org
>
>
> With regards,
> Apache Git Services
>

Re: [GitHub] michael-o commented on a change in pull request #74: [SCM-885] third implementation

[Vishal Kumar Gupta]

michael-o commented on a change in pull request #74: [SCM-885] third
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189380195



 ##
 File path: maven-scm-providers/maven-scm-providers-git/maven-scm-
provider-gitexe/src/main/java/org/apache/maven/scm/provider/
git/gitexe/command/changelog/GitChangeLogCommand.java
 ##
 @@ -69,14 +69,22 @@ protected ChangeLogScmResult executeChangeLogCommand(
ScmProviderRepository repo
 return executeChangeLogCommand( repo, fileSet, startDate, endDate,
branch, datePattern, null, null );
 }

+@Override
+protected ChangeLogScmResult executeChangeLogCommand(
ScmProviderRepository repository, ScmFileSet fileSet,
+  ScmVersion
version, String datePattern )
+throws ScmException
+{
+return executeChangeLogCommand( repository, fileSet, null, null,
null, datePattern, null, null, null, version );
+}
+
 protected ChangeLogScmResult executeChangeLogCommand(
ScmProviderRepository repo, ScmFileSet fileSet,
-  Date startDate,
Date endDate, ScmBranch branch,
-  String
datePattern, ScmVersion startVersion,
-  ScmVersion
endVersion )
+ Date startDate,
Date endDate, ScmBranch branch,
+ String
datePattern, ScmVersion startVersion,
+ ScmVersion
endVersion )

 Review comment:
   Indentation looks wrong. `Date` should align on `ScmProviderRepository`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

On Sat, May 19, 2018 at 1:36 AM, GitBox  wrote:

> michael-o commented on a change in pull request #74: [SCM-885] third
> implementation
> URL: https://github.com/apache/maven-scm/pull/74#discussion_r189380195
>
>
>
>  ##
>  File path: maven-scm-providers/maven-scm-providers-git/maven-scm-
> provider-gitexe/src/main/java/org/apache/maven/scm/provider/
> git/gitexe/command/changelog/GitChangeLogCommand.java
>  ##
>  @@ -69,14 +69,22 @@ protected ChangeLogScmResult executeChangeLogCommand(
> ScmProviderRepository repo
>  return executeChangeLogCommand( repo, fileSet, startDate,
> endDate, branch, datePattern, null, null );
>  }
>
> +@Override
> +protected ChangeLogScmResult executeChangeLogCommand(
> ScmProviderRepository repository, ScmFileSet fileSet,
> +  ScmVersion
> version, String datePattern )
> +throws ScmException
> +{
> +return executeChangeLogCommand( repository, fileSet, null, null,
> null, datePattern, null, null, null, version );
> +}
> +
>  protected ChangeLogScmResult executeChangeLogCommand(
> ScmProviderRepository repo, ScmFileSet fileSet,
> -  Date startDate,
> Date endDate, ScmBranch branch,
> -  String
> datePattern, ScmVersion startVersion,
> -  ScmVersion
> endVersion )
> + Date startDate,
> Date endDate, ScmBranch branch,
> + String
> datePattern, ScmVersion startVersion,
> + ScmVersion
> endVersion )
>
>  Review comment:
>Indentation looks wrong. `Date` should align on `ScmProviderRepository`.
>
> 
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> us...@infra.apache.org
>
>
> With regards,
> Apache Git Services
>

[GitHub] michael-o commented on a change in pull request #74: [SCM-885] third implementation

[GitBox]

michael-o commented on a change in pull request #74: [SCM-885] third 
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189381471
 
 

 ##
 File path: 
maven-scm-api/src/main/java/org/apache/maven/scm/command/changelog/AbstractChangeLogCommand.java
 ##
 @@ -55,6 +55,14 @@ protected ChangeLogScmResult executeChangeLogCommand( 
ScmProviderRepository repo
 throw new ScmException( "Unsupported method for this provider." );
 }
 
+@Deprecated
+protected ChangeLogScmResult executeChangeLogCommand( 
ScmProviderRepository repository, ScmFileSet fileSet,
+  ScmVersion version, 
String datePattern )
+throws ScmException
 
 Review comment:
   4 spaces please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481129#comment-16481129
 ] 

ASF GitHub Bot commented on SCM-885:


michael-o commented on a change in pull request #74: [SCM-885] third 
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189381286
 
 

 ##
 File path: 
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/changelog/JGitChangeLogCommand.java
 ##
 @@ -82,12 +82,14 @@ protected ChangeLogScmResult executeChangeLogCommand( 
ScmProviderRepository repo
 throws ScmException
 {
 Git git = null;
+boolean isARangeChangeLog = startVersion != null || endVersion != null;
 
 Review comment:
   Isn't this name inconsistent with the gitexe provider?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> GitChangeLogCommand is wrong when only endVersion is set
> 
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.6
>
> Attachments: scm-885-different-behavior-exe-jgit-patch.diff
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has 
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso  ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso  END_REVISION_SHA1 -- PROJECT_PATH}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481130#comment-16481130
 ] 

ASF GitHub Bot commented on SCM-885:


michael-o commented on a change in pull request #74: [SCM-885] third 
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189381372
 
 

 ##
 File path: 
maven-scm-api/src/main/java/org/apache/maven/scm/command/changelog/ChangeLogScmRequest.java
 ##
 @@ -175,4 +175,15 @@ public void setDateRange( Date startDate, Date endDate )
 setEndDate( endDate );
 }
 
+public void setRevision(ScmVersion revision)
 
 Review comment:
   Please add the spaces between parenthesis.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> GitChangeLogCommand is wrong when only endVersion is set
> 
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.6
>
> Attachments: scm-885-different-behavior-exe-jgit-patch.diff
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has 
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso  ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso  END_REVISION_SHA1 -- PROJECT_PATH}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] michael-o commented on a change in pull request #74: [SCM-885] third implementation

[GitBox]

michael-o commented on a change in pull request #74: [SCM-885] third 
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189381372
 
 

 ##
 File path: 
maven-scm-api/src/main/java/org/apache/maven/scm/command/changelog/ChangeLogScmRequest.java
 ##
 @@ -175,4 +175,15 @@ public void setDateRange( Date startDate, Date endDate )
 setEndDate( endDate );
 }
 
+public void setRevision(ScmVersion revision)
 
 Review comment:
   Please add the spaces between parenthesis.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] michael-o commented on a change in pull request #74: [SCM-885] third implementation

[GitBox]

michael-o commented on a change in pull request #74: [SCM-885] third 
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189381286
 
 

 ##
 File path: 
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/changelog/JGitChangeLogCommand.java
 ##
 @@ -82,12 +82,14 @@ protected ChangeLogScmResult executeChangeLogCommand( 
ScmProviderRepository repo
 throws ScmException
 {
 Git git = null;
+boolean isARangeChangeLog = startVersion != null || endVersion != null;
 
 Review comment:
   Isn't this name inconsistent with the gitexe provider?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481128#comment-16481128
 ] 

ASF GitHub Bot commented on SCM-885:


michael-o commented on a change in pull request #74: [SCM-885] third 
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189380562
 
 

 ##
 File path: 
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommand.java
 ##
 @@ -89,17 +97,28 @@ protected ChangeLogScmResult executeChangeLogCommand( 
ChangeLogScmRequest reques
 final String datePattern = request.getDatePattern();
 return executeChangeLogCommand( 
request.getScmRepository().getProviderRepository(), fileSet,
 request.getStartDate(), request.getEndDate(), 
request.getScmBranch(), datePattern, startVersion,
-endVersion, request.getLimit() );
+endVersion, request.getLimit(), request.getRevision() );
 }
 
+
 protected ChangeLogScmResult executeChangeLogCommand( 
ScmProviderRepository repo, ScmFileSet fileSet,
   Date startDate, Date 
endDate, ScmBranch branch,
   String datePattern, 
ScmVersion startVersion,
   ScmVersion 
endVersion, Integer limit )
+throws ScmException
 
 Review comment:
   throws indents with 4 spaces


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> GitChangeLogCommand is wrong when only endVersion is set
> 
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.6
>
> Attachments: scm-885-different-behavior-exe-jgit-patch.diff
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has 
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso  ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso  END_REVISION_SHA1 -- PROJECT_PATH}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481127#comment-16481127
 ] 

ASF GitHub Bot commented on SCM-885:


michael-o commented on a change in pull request #74: [SCM-885] third 
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189380505
 
 

 ##
 File path: 
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommand.java
 ##
 @@ -89,17 +97,28 @@ protected ChangeLogScmResult executeChangeLogCommand( 
ChangeLogScmRequest reques
 final String datePattern = request.getDatePattern();
 return executeChangeLogCommand( 
request.getScmRepository().getProviderRepository(), fileSet,
 request.getStartDate(), request.getEndDate(), 
request.getScmBranch(), datePattern, startVersion,
-endVersion, request.getLimit() );
+endVersion, request.getLimit(), request.getRevision() );
 
 Review comment:
   Move both to variables for consistency.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> GitChangeLogCommand is wrong when only endVersion is set
> 
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.6
>
> Attachments: scm-885-different-behavior-exe-jgit-patch.diff
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has 
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso  ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso  END_REVISION_SHA1 -- PROJECT_PATH}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] michael-o commented on a change in pull request #74: [SCM-885] third implementation

[GitBox]

michael-o commented on a change in pull request #74: [SCM-885] third 
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189380562
 
 

 ##
 File path: 
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommand.java
 ##
 @@ -89,17 +97,28 @@ protected ChangeLogScmResult executeChangeLogCommand( 
ChangeLogScmRequest reques
 final String datePattern = request.getDatePattern();
 return executeChangeLogCommand( 
request.getScmRepository().getProviderRepository(), fileSet,
 request.getStartDate(), request.getEndDate(), 
request.getScmBranch(), datePattern, startVersion,
-endVersion, request.getLimit() );
+endVersion, request.getLimit(), request.getRevision() );
 }
 
+
 protected ChangeLogScmResult executeChangeLogCommand( 
ScmProviderRepository repo, ScmFileSet fileSet,
   Date startDate, Date 
endDate, ScmBranch branch,
   String datePattern, 
ScmVersion startVersion,
   ScmVersion 
endVersion, Integer limit )
+throws ScmException
 
 Review comment:
   throws indents with 4 spaces


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] michael-o commented on a change in pull request #74: [SCM-885] third implementation

[GitBox]

michael-o commented on a change in pull request #74: [SCM-885] third 
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189380505
 
 

 ##
 File path: 
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommand.java
 ##
 @@ -89,17 +97,28 @@ protected ChangeLogScmResult executeChangeLogCommand( 
ChangeLogScmRequest reques
 final String datePattern = request.getDatePattern();
 return executeChangeLogCommand( 
request.getScmRepository().getProviderRepository(), fileSet,
 request.getStartDate(), request.getEndDate(), 
request.getScmBranch(), datePattern, startVersion,
-endVersion, request.getLimit() );
+endVersion, request.getLimit(), request.getRevision() );
 
 Review comment:
   Move both to variables for consistency.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481125#comment-16481125
 ] 

ASF GitHub Bot commented on SCM-885:


michael-o commented on a change in pull request #74: [SCM-885] third 
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189380195
 
 

 ##
 File path: 
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommand.java
 ##
 @@ -69,14 +69,22 @@ protected ChangeLogScmResult executeChangeLogCommand( 
ScmProviderRepository repo
 return executeChangeLogCommand( repo, fileSet, startDate, endDate, 
branch, datePattern, null, null );
 }
 
+@Override
+protected ChangeLogScmResult executeChangeLogCommand( 
ScmProviderRepository repository, ScmFileSet fileSet,
+  ScmVersion version, 
String datePattern )
+throws ScmException
+{
+return executeChangeLogCommand( repository, fileSet, null, null, null, 
datePattern, null, null, null, version );
+}
+
 protected ChangeLogScmResult executeChangeLogCommand( 
ScmProviderRepository repo, ScmFileSet fileSet,
-  Date startDate, Date 
endDate, ScmBranch branch,
-  String datePattern, 
ScmVersion startVersion,
-  ScmVersion 
endVersion )
+ Date startDate, Date 
endDate, ScmBranch branch,
+ String datePattern, 
ScmVersion startVersion,
+ ScmVersion endVersion 
)
 
 Review comment:
   Indentation looks wrong. `Date` should align on `ScmProviderRepository`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> GitChangeLogCommand is wrong when only endVersion is set
> 
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.6
>
> Attachments: scm-885-different-behavior-exe-jgit-patch.diff
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has 
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso  ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso  END_REVISION_SHA1 -- PROJECT_PATH}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] michael-o commented on a change in pull request #74: [SCM-885] third implementation

[GitBox]

michael-o commented on a change in pull request #74: [SCM-885] third 
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189380195
 
 

 ##
 File path: 
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommand.java
 ##
 @@ -69,14 +69,22 @@ protected ChangeLogScmResult executeChangeLogCommand( 
ScmProviderRepository repo
 return executeChangeLogCommand( repo, fileSet, startDate, endDate, 
branch, datePattern, null, null );
 }
 
+@Override
+protected ChangeLogScmResult executeChangeLogCommand( 
ScmProviderRepository repository, ScmFileSet fileSet,
+  ScmVersion version, 
String datePattern )
+throws ScmException
+{
+return executeChangeLogCommand( repository, fileSet, null, null, null, 
datePattern, null, null, null, version );
+}
+
 protected ChangeLogScmResult executeChangeLogCommand( 
ScmProviderRepository repo, ScmFileSet fileSet,
-  Date startDate, Date 
endDate, ScmBranch branch,
-  String datePattern, 
ScmVersion startVersion,
-  ScmVersion 
endVersion )
+ Date startDate, Date 
endDate, ScmBranch branch,
+ String datePattern, 
ScmVersion startVersion,
+ ScmVersion endVersion 
)
 
 Review comment:
   Indentation looks wrong. `Date` should align on `ScmProviderRepository`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481124#comment-16481124
 ] 

ASF GitHub Bot commented on SCM-885:


michael-o commented on a change in pull request #74: [SCM-885] third 
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189379912
 
 

 ##
 File path: 
maven-scm-api/src/main/java/org/apache/maven/scm/command/changelog/AbstractChangeLogCommand.java
 ##
 @@ -76,13 +84,21 @@ public ScmResult executeCommand( ScmProviderRepository 
repository, ScmFileSet fi
 
 ScmBranch branch = (ScmBranch) parameters.getScmVersion( 
CommandParameter.BRANCH, null );
 
+ScmVersion version = parameters.getScmVersion( 
CommandParameter.SCM_VERSION, null );
+
 ScmVersion startVersion = parameters.getScmVersion( 
CommandParameter.START_SCM_VERSION, null );
 
 ScmVersion endVersion = parameters.getScmVersion( 
CommandParameter.END_SCM_VERSION, null );
 
 String datePattern = parameters.getString( 
CommandParameter.CHANGELOG_DATE_PATTERN, null );
 
-if ( startVersion != null || endVersion != null )
+boolean fromVersionToStartOfRepository = startVersion == null && 
endVersion == null && version != null;
 
 Review comment:
   The variable name is a bit confusing because we have `startVersion` and the 
name contains `start` too.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> GitChangeLogCommand is wrong when only endVersion is set
> 
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.6
>
> Attachments: scm-885-different-behavior-exe-jgit-patch.diff
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has 
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso  ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso  END_REVISION_SHA1 -- PROJECT_PATH}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] michael-o commented on a change in pull request #74: [SCM-885] third implementation

[GitBox]

michael-o commented on a change in pull request #74: [SCM-885] third 
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189379912
 
 

 ##
 File path: 
maven-scm-api/src/main/java/org/apache/maven/scm/command/changelog/AbstractChangeLogCommand.java
 ##
 @@ -76,13 +84,21 @@ public ScmResult executeCommand( ScmProviderRepository 
repository, ScmFileSet fi
 
 ScmBranch branch = (ScmBranch) parameters.getScmVersion( 
CommandParameter.BRANCH, null );
 
+ScmVersion version = parameters.getScmVersion( 
CommandParameter.SCM_VERSION, null );
+
 ScmVersion startVersion = parameters.getScmVersion( 
CommandParameter.START_SCM_VERSION, null );
 
 ScmVersion endVersion = parameters.getScmVersion( 
CommandParameter.END_SCM_VERSION, null );
 
 String datePattern = parameters.getString( 
CommandParameter.CHANGELOG_DATE_PATTERN, null );
 
-if ( startVersion != null || endVersion != null )
+boolean fromVersionToStartOfRepository = startVersion == null && 
endVersion == null && version != null;
 
 Review comment:
   The variable name is a bit confusing because we have `startVersion` and the 
name contains `start` too.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Assigned] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov reassigned SCM-885:
--

Assignee: Michael Osipov

> GitChangeLogCommand is wrong when only endVersion is set
> 
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9.6
>
> Attachments: scm-885-different-behavior-exe-jgit-patch.diff
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has 
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso  ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso  END_REVISION_SHA1 -- PROJECT_PATH}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] marcphilipp commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

marcphilipp commented on a change in pull request #184: Donate current sources 
from junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#discussion_r189373822
 
 

 ##
 File path: maven-surefire-plugin/src/site/apt/examples/junit-platform.apt.vm
 ##
 @@ -0,0 +1,206 @@
+ --
+ Using JUnit Platform
+ --
+ JUnit Lambda Team 
+ --
+ 2018-05-14
+ --
+ 
+ ~~ Licensed to the Apache Software Foundation (ASF) under one
+ ~~ or more contributor license agreements.  See the NOTICE file
+ ~~ distributed with this work for additional information
+ ~~ regarding copyright ownership.  The ASF licenses this file
+ ~~ to you under the Apache License, Version 2.0 (the
+ ~~ "License"); you may not use this file except in compliance
+ ~~ with the License.  You may obtain a copy of the License at
+ ~~
+ ~~   http://www.apache.org/licenses/LICENSE-2.0
+ ~~
+ ~~ Unless required by applicable law or agreed to in writing,
+ ~~ software distributed under the License is distributed on an
+ ~~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~~ KIND, either express or implied.  See the License for the
+ ~~ specific language governing permissions and limitations
+ ~~ under the License.
+
+ ~~ NOTE: For help with the syntax of this file, see:
+ ~~ http://maven.apache.org/doxia/references/apt-format.html 
+
+Using JUnit Platform
+
+* Configuring JUnit Platform
+
+  To get started with JUnit Platform, you need to add at least a single 
<<>> implementation
+  to your project. For example, if you want to write tests with Jupiter, you 
must add the
+  <<>> to the dependencies like:
+
++---+
+
+  [...]
+
+  org.junit.jupiter
+  junit-jupiter-engine
+  5.2.0
+  test
+
+  [...]
+
++---+
+
+  This will pull in all required dependencies. Among those dependencies is 
<<>> which contains
+  the classes and interfaces your test source requires to compile. 
<<>> is also resolved and
+  added.
+
+  This is the only step that is required to get started - you can now create 
tests in your test source directory
+  (e.g., <<>>).
+
+  If you want to write and execute JUnit 3 or 4 tests via the JUnit Platform 
add the Vintage Engine to your projects'
+  dependencies:
+
++---+
+
+  [...]
+
+  org.junit.vintage
+  junit-vintage-engine
+  5.2.0
+  test
+
+  [...]
+
++---+
+
+* Provider Selection
+
+   If nothing is configured, Surefire detects which JUnit version to use by 
the following algorithm:
+
++---+
+if the JUnit Platform Engine is present in the project
+use junit-platform
+if the JUnit version in the project >= 4.7 and the parallel attribute has ANY 
value
+use junit47 provider
+if JUnit >= 4.0 is present
+use junit4 provider
+else
+use junit3.8.1
++---+
+
+  When using this technique there is no check that the proper test-frameworks 
are present on your project's
+  classpath. Failing to add the proper test-frameworks will result in a build 
failure.
+
+* Running Tests in Parallel
+
+  From JUnit Platform does not support running tests in parallel.
+
+* Running a Single Test Class
+
+   The JUnit Platform Provider supports the <<>> JVM system property 
supported by
+   the Maven Surefire Plugin. For example, to run only test methods in the 
<<>> test class
+   you can execute <<>> from the command 
line.
+
+
+* Filtering by Test Class Names
+
+   The Maven Surefire Plugin will scan for test classes whose fully qualified 
names match
+   the following patterns.
+
+   * <<<**/Test*.java>>>
+
+   * <<<**/*Test.java>>>
+
+   * <<<**/*Tests.java>>>
+
+   * <<<**/*TestCase.java>>>
+
+Moreover, it will exclude all nested classes (including static member classes) 
by default.
+
+Note, however, that you can override this default behavior by configuring 
explicit
+`include` and `exclude` rules in your `pom.xml` file. For example, to keep 
Maven Surefire
+from excluding static member classes, you can override its exclude rules.
+
+Overriding exclude rules of Maven Surefire
+
++---+
+...
+
+
+...
+
+maven-surefire-plugin
+{surefire-version}
+
+
+
+
+
+...
+
+
+
+...
++---+
+
+
+* Filtering by Tags
+
+You can filter tests by tags or tag expressions using the following 
configuration properties.
+
+* to include <<>> or <<>>, use either <<>> 
or <<>>.
+
+* to exclude <<>> or <<>>, use either 
<<>> or <<>>.
+
++---+
+...
+
+
+...
+
+maven-surefire-plugin
+{surefire-version}
+
+
+acceptance | !feature-a
+integration, regression
+
+
+
+...
+
+
+
+
+...
++---+
+
+
+* Configuration Parameters
+
+   You can set JUnit Platform configuration parameters to 

[GitHub] marcphilipp commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

marcphilipp commented on a change in pull request #184: Donate current sources 
from junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#discussion_r189372895
 
 

 ##
 File path: maven-surefire-plugin/src/site/apt/featurematrix.apt.vm
 ##
 @@ -27,19 +27,19 @@ Feature Matrix
 Not all features are supported for all test frameworks, and the following 
table gives a brief overview
 of support status:
 
-*-+---+---++---+--+
-|| <>
||<>||<>||<>||<>||<> |
-*-++--++---+--+
-| groups/category support | N  |N |  Y 
|Y  |  N   |
-*-++--++---+--+
-| security manager support| Y  |N |  N 
|N  |  N   |
-*-++--++---+--+
-| runOrder support| Y  |Y |  Y 
|?  |  Y   |
-*-++--++---+--+
-| run >1 individual test method in a class| N  |Y |  Y 
|Y  |  N   |
-*-++--++---+--+
-| parallel support| N  |N |  Y 
|Y  |  N   |
-*-++--++---+--+
+*-+---+---++---+--++
+|| <>
||<>||<>||<>||<>||<> ||<> |
+*-++--++---+--++
+| groups/category/tags support| N  |N |  Y 
|Y  |  N   |  Y |
+*-++--++---+--++
+| security manager support| Y  |N |  N 
|N  |  N   |  N |
+*-++--++---+--++
+| runOrder support| Y  |Y |  Y 
|?  |  Y   |  N |
+*-++--++---+--++
+| run >1 individual test method in a class| N  |Y |  Y 
|Y  |  N   |  ? |
 
 Review comment:
   Yes, but there are some corner cases that are not supported, yet (see 
https://github.com/junit-team/junit5/issues/1343 and 
https://github.com/junit-team/junit5/issues/1406).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] marcphilipp commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

marcphilipp commented on a change in pull request #184: Donate current sources 
from junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#discussion_r189372365
 
 

 ##
 File path: maven-surefire-plugin/src/site/apt/featurematrix.apt.vm
 ##
 @@ -27,19 +27,19 @@ Feature Matrix
 Not all features are supported for all test frameworks, and the following 
table gives a brief overview
 of support status:
 
-*-+---+---++---+--+
-|| <>
||<>||<>||<>||<>||<> |
-*-++--++---+--+
-| groups/category support | N  |N |  Y 
|Y  |  N   |
-*-++--++---+--+
-| security manager support| Y  |N |  N 
|N  |  N   |
-*-++--++---+--+
-| runOrder support| Y  |Y |  Y 
|?  |  Y   |
-*-++--++---+--+
-| run >1 individual test method in a class| N  |Y |  Y 
|Y  |  N   |
-*-++--++---+--+
-| parallel support| N  |N |  Y 
|Y  |  N   |
-*-++--++---+--+
+*-+---+---++---+--++
+|| <>
||<>||<>||<>||<>||<> ||<> |
+*-++--++---+--++
+| groups/category/tags support| N  |N |  Y 
|Y  |  N   |  Y |
+*-++--++---+--++
+| security manager support| Y  |N |  N 
|N  |  N   |  N |
+*-++--++---+--++
+| runOrder support| Y  |Y |  Y 
|?  |  Y   |  N |
+*-++--++---+--++
+| run >1 individual test method in a class| N  |Y |  Y 
|Y  |  N   |  ? |
+*-++--++---+--++
+| parallel support| N  |N |  Y 
|Y  |  N   |  N |
 
 Review comment:
   No, `ParallelComputer` cannot be reused. Jupiter currently does not have 
support for parallel execution, that will be added in 
https://github.com/junit-team/junit5/issues/60.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] marcphilipp commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

marcphilipp commented on a change in pull request #184: Donate current sources 
from junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#discussion_r189371541
 
 

 ##
 File path: maven-surefire-plugin/src/site/apt/examples/junit-platform.apt.vm
 ##
 @@ -0,0 +1,206 @@
+ --
+ Using JUnit Platform
+ --
+ JUnit Lambda Team 
+ --
+ 2018-05-14
+ --
+ 
+ ~~ Licensed to the Apache Software Foundation (ASF) under one
+ ~~ or more contributor license agreements.  See the NOTICE file
+ ~~ distributed with this work for additional information
+ ~~ regarding copyright ownership.  The ASF licenses this file
+ ~~ to you under the Apache License, Version 2.0 (the
+ ~~ "License"); you may not use this file except in compliance
+ ~~ with the License.  You may obtain a copy of the License at
+ ~~
+ ~~   http://www.apache.org/licenses/LICENSE-2.0
+ ~~
+ ~~ Unless required by applicable law or agreed to in writing,
+ ~~ software distributed under the License is distributed on an
+ ~~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~~ KIND, either express or implied.  See the License for the
+ ~~ specific language governing permissions and limitations
+ ~~ under the License.
+
+ ~~ NOTE: For help with the syntax of this file, see:
+ ~~ http://maven.apache.org/doxia/references/apt-format.html 
+
+Using JUnit Platform
+
+* Configuring JUnit Platform
+
+  To get started with JUnit Platform, you need to add at least a single 
<<>> implementation
+  to your project. For example, if you want to write tests with Jupiter, you 
must add the
+  <<>> to the dependencies like:
+
++---+
+
+  [...]
+
+  org.junit.jupiter
+  junit-jupiter-engine
+  5.2.0
+  test
+
+  [...]
+
++---+
+
+  This will pull in all required dependencies. Among those dependencies is 
<<>> which contains
+  the classes and interfaces your test source requires to compile. 
<<>> is also resolved and
+  added.
+
+  This is the only step that is required to get started - you can now create 
tests in your test source directory
+  (e.g., <<>>).
+
+  If you want to write and execute JUnit 3 or 4 tests via the JUnit Platform 
add the Vintage Engine to your projects'
+  dependencies:
+
++---+
+
+  [...]
+
+  org.junit.vintage
+  junit-vintage-engine
+  5.2.0
+  test
+
+  [...]
+
++---+
+
+* Provider Selection
+
+   If nothing is configured, Surefire detects which JUnit version to use by 
the following algorithm:
+
++---+
+if the JUnit Platform Engine is present in the project
+use junit-platform
+if the JUnit version in the project >= 4.7 and the parallel attribute has ANY 
value
+use junit47 provider
+if JUnit >= 4.0 is present
+use junit4 provider
+else
+use junit3.8.1
++---+
+
+  When using this technique there is no check that the proper test-frameworks 
are present on your project's
+  classpath. Failing to add the proper test-frameworks will result in a build 
failure.
+
+* Running Tests in Parallel
+
+  From JUnit Platform does not support running tests in parallel.
+
+* Running a Single Test Class
+
+   The JUnit Platform Provider supports the <<>> JVM system property 
supported by
+   the Maven Surefire Plugin. For example, to run only test methods in the 
<<>> test class
+   you can execute <<>> from the command 
line.
+
+
+* Filtering by Test Class Names
+
+   The Maven Surefire Plugin will scan for test classes whose fully qualified 
names match
+   the following patterns.
+
+   * <<<**/Test*.java>>>
+
+   * <<<**/*Test.java>>>
+
+   * <<<**/*Tests.java>>>
+
+   * <<<**/*TestCase.java>>>
+
+Moreover, it will exclude all nested classes (including static member classes) 
by default.
+
+Note, however, that you can override this default behavior by configuring 
explicit
+`include` and `exclude` rules in your `pom.xml` file. For example, to keep 
Maven Surefire
+from excluding static member classes, you can override its exclude rules.
+
+Overriding exclude rules of Maven Surefire
+
++---+
+...
+
+
+...
+
+maven-surefire-plugin
+{surefire-version}
+
+
+
+
+
+...
+
+
+
+...
++---+
+
+
+* Filtering by Tags
+
+You can filter tests by tags or tag expressions using the following 
configuration properties.
+
+* to include <<>> or <<>>, use either <<>> 
or <<>>.
+
+* to exclude <<>> or <<>>, use either 
<<>> or <<>>.
+
++---+
+...
+
+
+...
+
+maven-surefire-plugin
+{surefire-version}
+
+
+acceptance | !feature-a
 
 Review comment:
   I think we should indeed do that, cf. 
https://github.com/junit-team/junit5/issues/1425#issuecomment-390308206


This is an automated message from the Apache Git 

[jira] [Created] (MJLINK-17) Add documentation information for GitHub

[Karl Heinz Marbaise (JIRA)]

Karl Heinz Marbaise created MJLINK-17:
-

 Summary: Add documentation information for GitHub
 Key: MJLINK-17
 URL: https://issues.apache.org/jira/browse/MJLINK-17
 Project: Maven JLink Plugin
  Issue Type: Dependency upgrade
Affects Versions: 3.0.0-alpha-2
Reporter: Karl Heinz Marbaise
Assignee: Karl Heinz Marbaise
 Fix For: 3.0.0-alpha-2






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] khmarbaise commented on issue #1: Added option for generating jlink launcher.

[GitBox]

khmarbaise commented on issue #1: Added option for generating jlink launcher.
URL: https://github.com/apache/maven-jlink-plugin/pull/1#issuecomment-390275912
 
 
   Two things. First create a [JIRA 
issue](http://issues.apache.org/jira/browse/MJLINK) and mentioned that in your 
commit message like:
   ```
   [MLINK-XXX] - Title
   supplemental explanation if needed
   ```
   Apart from that I would appreciate to merge this enhancement...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] skapral opened a new pull request #1: Added option for generating jlink launcher.

[GitBox]

skapral opened a new pull request #1: Added option for generating jlink 
launcher.
URL: https://github.com/apache/maven-jlink-plugin/pull/1
 
 
   Subj.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (SUREFIRE-1522) IndexOutOfBoundsException for System.out.write

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480837#comment-16480837
 ] 

ASF GitHub Bot commented on SUREFIRE-1522:
--

docrjp commented on issue #185: [SUREFIRE-1522] fix escapeBytesToPrintable 
bounds check
URL: https://github.com/apache/maven-surefire/pull/185#issuecomment-390253454
 
 
   @Tibor17 now passes on a mvn install:
   
   ```
   Results :
   
   Tests run: 756, Failures: 0, Errors: 0, Skipped: 138
   
   [INFO]
   [INFO] --- maven-checkstyle-plugin:2.15:check (checkstyle-check) @ 
surefire-its ---
   [INFO]
   [INFO] --- maven-failsafe-plugin:2.12.4:verify (default) @ surefire-its ---
   [INFO] Failsafe report directory: [redacted]
   [INFO]
   [INFO] --- maven-install-plugin:2.5.2:install (default-install) @ 
surefire-its ---
   [INFO] Skipping artifact installation
   [INFO] 

   [INFO] Reactor Summary:
   [INFO]
   [INFO] Apache Maven Surefire .. SUCCESS [  5.148 
s]
   [INFO] SureFire Logger API  SUCCESS [  2.049 
s]
   [INFO] SureFire API ... SUCCESS [  7.176 
s]
   [INFO] ShadeFire JUnit3 Provider .. SUCCESS [  2.075 
s]
   [INFO] SureFire Booter  SUCCESS [ 13.905 
s]
   [INFO] Maven Surefire Test-Grouping Support ... SUCCESS [  4.905 
s]
   [INFO] SureFire Providers . SUCCESS [  0.671 
s]
   [INFO] Shared JUnit3 Provider Code  SUCCESS [  4.368 
s]
   [INFO] Shared Java 5 Provider Base  SUCCESS [  4.546 
s]
   [INFO] Shared JUnit4 Provider Code  SUCCESS [  4.797 
s]
   [INFO] Shared JUnit48 Provider Code ... SUCCESS [  5.353 
s]
   [INFO] SureFire JUnit Runner .. SUCCESS [  4.266 
s]
   [INFO] SureFire JUnit4 Runner . SUCCESS [  5.803 
s]
   [INFO] Maven Surefire Common .. SUCCESS [ 28.821 
s]
   [INFO] SureFire JUnitCore Runner .. SUCCESS [02:12 
min]
   [INFO] SureFire TestNG Utils .. SUCCESS [  3.989 
s]
   [INFO] SureFire TestNG Runner . SUCCESS [  4.324 
s]
   [INFO] Surefire Report Parser . SUCCESS [  4.411 
s]
   [INFO] Maven Surefire Plugin .. SUCCESS [  8.950 
s]
   [INFO] Maven Failsafe Plugin .. SUCCESS [ 11.370 
s]
   [INFO] Maven Surefire Report Plugin ... SUCCESS [ 13.593 
s]
   [INFO] Maven Surefire Integration Test Setup .. SUCCESS [ 35.182 
s]
   [INFO] Maven Surefire Integration Tests ... SUCCESS [  01:04 
h]
   [INFO] 

   [INFO] BUILD SUCCESS
   [INFO] 

   [INFO] Total time: 01:09 h
   [INFO] Finished at: 2018-05-18T15:01:40+01:00
   [INFO] Final Memory: 52M/663M
   [INFO] 

   ```
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> IndexOutOfBoundsException for System.out.write
> --
>
> Key: SUREFIRE-1522
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1522
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin, process 
> forking
>Affects Versions: 2.21.0
>Reporter: Rob Platt
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 2.22.0
>
>
> There is a regression, I believe caused by -SUREFIRE-1454-. Git blame seems 
> to confirm this; and there was a related regression for empty arrays 
> SUREFIRE-1515.
> It can be easily reproduced with the following test:
>  
> {code:java}
> import org.junit.jupiter.api.Test;
> import java.nio.charset.StandardCharsets;
> public class SurefireLoggingTest {
> private final byte[] aNiceString = "what fun times, standard out is 
> broken\n".getBytes(StandardCharsets.US_ASCII);
> @Test
> public void fun() {
> System.out.write(aNiceString, 5, 3);
> }
> @Test
> public void fun_times() {
> System.out.write(aNiceString, 5, 9);
> }
> }
> {code}
>  
> Both tests will pass under Intellij, writing "fun" and "fun times" to 
> System.out. 

[GitHub] docrjp commented on issue #185: [SUREFIRE-1522] fix escapeBytesToPrintable bounds check

[GitBox]

docrjp commented on issue #185: [SUREFIRE-1522] fix escapeBytesToPrintable 
bounds check
URL: https://github.com/apache/maven-surefire/pull/185#issuecomment-390253454
 
 
   @Tibor17 now passes on a mvn install:
   
   ```
   Results :
   
   Tests run: 756, Failures: 0, Errors: 0, Skipped: 138
   
   [INFO]
   [INFO] --- maven-checkstyle-plugin:2.15:check (checkstyle-check) @ 
surefire-its ---
   [INFO]
   [INFO] --- maven-failsafe-plugin:2.12.4:verify (default) @ surefire-its ---
   [INFO] Failsafe report directory: [redacted]
   [INFO]
   [INFO] --- maven-install-plugin:2.5.2:install (default-install) @ 
surefire-its ---
   [INFO] Skipping artifact installation
   [INFO] 

   [INFO] Reactor Summary:
   [INFO]
   [INFO] Apache Maven Surefire .. SUCCESS [  5.148 
s]
   [INFO] SureFire Logger API  SUCCESS [  2.049 
s]
   [INFO] SureFire API ... SUCCESS [  7.176 
s]
   [INFO] ShadeFire JUnit3 Provider .. SUCCESS [  2.075 
s]
   [INFO] SureFire Booter  SUCCESS [ 13.905 
s]
   [INFO] Maven Surefire Test-Grouping Support ... SUCCESS [  4.905 
s]
   [INFO] SureFire Providers . SUCCESS [  0.671 
s]
   [INFO] Shared JUnit3 Provider Code  SUCCESS [  4.368 
s]
   [INFO] Shared Java 5 Provider Base  SUCCESS [  4.546 
s]
   [INFO] Shared JUnit4 Provider Code  SUCCESS [  4.797 
s]
   [INFO] Shared JUnit48 Provider Code ... SUCCESS [  5.353 
s]
   [INFO] SureFire JUnit Runner .. SUCCESS [  4.266 
s]
   [INFO] SureFire JUnit4 Runner . SUCCESS [  5.803 
s]
   [INFO] Maven Surefire Common .. SUCCESS [ 28.821 
s]
   [INFO] SureFire JUnitCore Runner .. SUCCESS [02:12 
min]
   [INFO] SureFire TestNG Utils .. SUCCESS [  3.989 
s]
   [INFO] SureFire TestNG Runner . SUCCESS [  4.324 
s]
   [INFO] Surefire Report Parser . SUCCESS [  4.411 
s]
   [INFO] Maven Surefire Plugin .. SUCCESS [  8.950 
s]
   [INFO] Maven Failsafe Plugin .. SUCCESS [ 11.370 
s]
   [INFO] Maven Surefire Report Plugin ... SUCCESS [ 13.593 
s]
   [INFO] Maven Surefire Integration Test Setup .. SUCCESS [ 35.182 
s]
   [INFO] Maven Surefire Integration Tests ... SUCCESS [  01:04 
h]
   [INFO] 

   [INFO] BUILD SUCCESS
   [INFO] 

   [INFO] Total time: 01:09 h
   [INFO] Finished at: 2018-05-18T15:01:40+01:00
   [INFO] Final Memory: 52M/663M
   [INFO] 

   ```
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (SUREFIRE-1522) IndexOutOfBoundsException for System.out.write

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480835#comment-16480835
 ] 

ASF GitHub Bot commented on SUREFIRE-1522:
--

docrjp commented on issue #185: [SUREFIRE-1522] fix escapeBytesToPrintable 
bounds check
URL: https://github.com/apache/maven-surefire/pull/185#issuecomment-390253454
 
 
   @Tibor17 now passes on a mvn install:
   
   Results :
   
   Tests run: 756, Failures: 0, Errors: 0, Skipped: 138
   
   [INFO]
   [INFO] --- maven-checkstyle-plugin:2.15:check (checkstyle-check) @ 
surefire-its ---
   [INFO]
   [INFO] --- maven-failsafe-plugin:2.12.4:verify (default) @ surefire-its ---
   [INFO] Failsafe report directory: [redacted]
   [INFO]
   [INFO] --- maven-install-plugin:2.5.2:install (default-install) @ 
surefire-its ---
   [INFO] Skipping artifact installation
   [INFO] 

   [INFO] Reactor Summary:
   [INFO]
   [INFO] Apache Maven Surefire .. SUCCESS [  5.148 
s]
   [INFO] SureFire Logger API  SUCCESS [  2.049 
s]
   [INFO] SureFire API ... SUCCESS [  7.176 
s]
   [INFO] ShadeFire JUnit3 Provider .. SUCCESS [  2.075 
s]
   [INFO] SureFire Booter  SUCCESS [ 13.905 
s]
   [INFO] Maven Surefire Test-Grouping Support ... SUCCESS [  4.905 
s]
   [INFO] SureFire Providers . SUCCESS [  0.671 
s]
   [INFO] Shared JUnit3 Provider Code  SUCCESS [  4.368 
s]
   [INFO] Shared Java 5 Provider Base  SUCCESS [  4.546 
s]
   [INFO] Shared JUnit4 Provider Code  SUCCESS [  4.797 
s]
   [INFO] Shared JUnit48 Provider Code ... SUCCESS [  5.353 
s]
   [INFO] SureFire JUnit Runner .. SUCCESS [  4.266 
s]
   [INFO] SureFire JUnit4 Runner . SUCCESS [  5.803 
s]
   [INFO] Maven Surefire Common .. SUCCESS [ 28.821 
s]
   [INFO] SureFire JUnitCore Runner .. SUCCESS [02:12 
min]
   [INFO] SureFire TestNG Utils .. SUCCESS [  3.989 
s]
   [INFO] SureFire TestNG Runner . SUCCESS [  4.324 
s]
   [INFO] Surefire Report Parser . SUCCESS [  4.411 
s]
   [INFO] Maven Surefire Plugin .. SUCCESS [  8.950 
s]
   [INFO] Maven Failsafe Plugin .. SUCCESS [ 11.370 
s]
   [INFO] Maven Surefire Report Plugin ... SUCCESS [ 13.593 
s]
   [INFO] Maven Surefire Integration Test Setup .. SUCCESS [ 35.182 
s]
   [INFO] Maven Surefire Integration Tests ... SUCCESS [  01:04 
h]
   [INFO] 

   [INFO] BUILD SUCCESS
   [INFO] 

   [INFO] Total time: 01:09 h
   [INFO] Finished at: 2018-05-18T15:01:40+01:00
   [INFO] Final Memory: 52M/663M
   [INFO] 

   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> IndexOutOfBoundsException for System.out.write
> --
>
> Key: SUREFIRE-1522
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1522
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin, process 
> forking
>Affects Versions: 2.21.0
>Reporter: Rob Platt
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 2.22.0
>
>
> There is a regression, I believe caused by -SUREFIRE-1454-. Git blame seems 
> to confirm this; and there was a related regression for empty arrays 
> SUREFIRE-1515.
> It can be easily reproduced with the following test:
>  
> {code:java}
> import org.junit.jupiter.api.Test;
> import java.nio.charset.StandardCharsets;
> public class SurefireLoggingTest {
> private final byte[] aNiceString = "what fun times, standard out is 
> broken\n".getBytes(StandardCharsets.US_ASCII);
> @Test
> public void fun() {
> System.out.write(aNiceString, 5, 3);
> }
> @Test
> public void fun_times() {
> System.out.write(aNiceString, 5, 9);
> }
> }
> {code}
>  
> Both tests will pass under Intellij, writing "fun" and "fun times" to 
> System.out. Whereas, with 

[GitHub] docrjp commented on issue #185: [SUREFIRE-1522] fix escapeBytesToPrintable bounds check

[GitBox]

docrjp commented on issue #185: [SUREFIRE-1522] fix escapeBytesToPrintable 
bounds check
URL: https://github.com/apache/maven-surefire/pull/185#issuecomment-390253454
 
 
   @Tibor17 now passes on a mvn install:
   
   Results :
   
   Tests run: 756, Failures: 0, Errors: 0, Skipped: 138
   
   [INFO]
   [INFO] --- maven-checkstyle-plugin:2.15:check (checkstyle-check) @ 
surefire-its ---
   [INFO]
   [INFO] --- maven-failsafe-plugin:2.12.4:verify (default) @ surefire-its ---
   [INFO] Failsafe report directory: [redacted]
   [INFO]
   [INFO] --- maven-install-plugin:2.5.2:install (default-install) @ 
surefire-its ---
   [INFO] Skipping artifact installation
   [INFO] 

   [INFO] Reactor Summary:
   [INFO]
   [INFO] Apache Maven Surefire .. SUCCESS [  5.148 
s]
   [INFO] SureFire Logger API  SUCCESS [  2.049 
s]
   [INFO] SureFire API ... SUCCESS [  7.176 
s]
   [INFO] ShadeFire JUnit3 Provider .. SUCCESS [  2.075 
s]
   [INFO] SureFire Booter  SUCCESS [ 13.905 
s]
   [INFO] Maven Surefire Test-Grouping Support ... SUCCESS [  4.905 
s]
   [INFO] SureFire Providers . SUCCESS [  0.671 
s]
   [INFO] Shared JUnit3 Provider Code  SUCCESS [  4.368 
s]
   [INFO] Shared Java 5 Provider Base  SUCCESS [  4.546 
s]
   [INFO] Shared JUnit4 Provider Code  SUCCESS [  4.797 
s]
   [INFO] Shared JUnit48 Provider Code ... SUCCESS [  5.353 
s]
   [INFO] SureFire JUnit Runner .. SUCCESS [  4.266 
s]
   [INFO] SureFire JUnit4 Runner . SUCCESS [  5.803 
s]
   [INFO] Maven Surefire Common .. SUCCESS [ 28.821 
s]
   [INFO] SureFire JUnitCore Runner .. SUCCESS [02:12 
min]
   [INFO] SureFire TestNG Utils .. SUCCESS [  3.989 
s]
   [INFO] SureFire TestNG Runner . SUCCESS [  4.324 
s]
   [INFO] Surefire Report Parser . SUCCESS [  4.411 
s]
   [INFO] Maven Surefire Plugin .. SUCCESS [  8.950 
s]
   [INFO] Maven Failsafe Plugin .. SUCCESS [ 11.370 
s]
   [INFO] Maven Surefire Report Plugin ... SUCCESS [ 13.593 
s]
   [INFO] Maven Surefire Integration Test Setup .. SUCCESS [ 35.182 
s]
   [INFO] Maven Surefire Integration Tests ... SUCCESS [  01:04 
h]
   [INFO] 

   [INFO] BUILD SUCCESS
   [INFO] 

   [INFO] Total time: 01:09 h
   [INFO] Finished at: 2018-05-18T15:01:40+01:00
   [INFO] Final Memory: 52M/663M
   [INFO] 

   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MCOMPILER-323) Support multi-release jars

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MCOMPILER-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480806#comment-16480806
 ] 

Hudson commented on MCOMPILER-323:
--

Build succeeded in Jenkins: Maven TLP » maven-compiler-plugin » MCOMPILER-323 #2

See 
https://builds.apache.org/job/maven-box/job/maven-compiler-plugin/job/MCOMPILER-323/2/

> Support multi-release jars
> --
>
> Key: MCOMPILER-323
> URL: https://issues.apache.org/jira/browse/MCOMPILER-323
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mike Drob
>Assignee: Robert Scholte
>Priority: Major
>
> Java 9 allows for JRE version specific code in the form of "multi-release 
> jars"
> Older JREs will treat them as normal jars, while newer JREs will load the 
> appropriate specific classes. AFAICT, maven does not currently support this.
> Compiler plugin should automatically detect when there are multiple source 
> levels and set MRJAR=True in the manifest.
> Source directories could potentially be src/main/java, src/main/java9, 
> src/main/java10, etc. These probably need to be configurable as well, or some 
> deeper discussion about what makes sense and is intuitive for users.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480779#comment-16480779
 ] 

ASF GitHub Bot commented on SCM-885:


McFoggy opened a new pull request #74: [SCM-885] third implementation
URL: https://github.com/apache/maven-scm/pull/74
 
 
   as discussed in https://issues.apache.org/jira/browse/SCM-885, I have done 
my best to remain backward compatible while providing the new feature, tck 
tests & aligning both git implementations.
   
   The incompatible changes are contained in #69152d3 and correspond to 
corrections/alignement of the jgit implementation towards the exe one.
   
   At that time I have kept all the commits separated but I can squash on 
demand.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> GitChangeLogCommand is wrong when only endVersion is set
> 
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Priority: Major
> Fix For: 1.9.6
>
> Attachments: scm-885-different-behavior-exe-jgit-patch.diff
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has 
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso  ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso  END_REVISION_SHA1 -- PROJECT_PATH}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] McFoggy opened a new pull request #74: [SCM-885] third implementation

[GitBox]

McFoggy opened a new pull request #74: [SCM-885] third implementation
URL: https://github.com/apache/maven-scm/pull/74
 
 
   as discussed in https://issues.apache.org/jira/browse/SCM-885, I have done 
my best to remain backward compatible while providing the new feature, tck 
tests & aligning both git implementations.
   
   The incompatible changes are contained in #69152d3 and correspond to 
corrections/alignement of the jgit implementation towards the exe one.
   
   At that time I have kept all the commits separated but I can squash on 
demand.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Closed] (MASSEMBLY-882) Upgrade mave-surefire/failsafe-plugin 2.21.0

[Karl Heinz Marbaise (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MASSEMBLY-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed MASSEMBLY-882.
-
Resolution: Fixed

Done in 
[c71fdf873320d293000609345ce7e59c8ae13728|https://gitbox.apache.org/repos/asf?p=maven-assembly-plugin.git;a=commitdiff;h=c71fdf873320d293000609345ce7e59c8ae13728]

> Upgrade mave-surefire/failsafe-plugin 2.21.0
> 
>
> Key: MASSEMBLY-882
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-882
> Project: Maven Assembly Plugin
>  Issue Type: Dependency upgrade
>Affects Versions: 3.1.1
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.1.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (MASSEMBLY-884) Upgrade plexus-archiver to 3.6.0

[Karl Heinz Marbaise (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MASSEMBLY-884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed MASSEMBLY-884.
-
Resolution: Fixed

Done in 
[5ccac8837d80a0651c26d95c45892135e1a12097|https://gitbox.apache.org/repos/asf?p=maven-assembly-plugin.git;a=commitdiff;h=5ccac8837d80a0651c26d95c45892135e1a12097]

> Upgrade plexus-archiver to 3.6.0
> 
>
> Key: MASSEMBLY-884
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-884
> Project: Maven Assembly Plugin
>  Issue Type: Dependency upgrade
>Affects Versions: 3.1.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Critical
> Fix For: 3.1.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (MJAR-252) Upgrade plexus-archiver to 3.6.0

[Karl Heinz Marbaise (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MJAR-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed MJAR-252.

Resolution: Fixed

Done in 
[a5c9a86a0c5e5a04a70819f85126dc650d49abf9|https://gitbox.apache.org/repos/asf?p=maven-jar-plugin.git;a=commitdiff;h=a5c9a86a0c5e5a04a70819f85126dc650d49abf9]

> Upgrade plexus-archiver to 3.6.0
> 
>
> Key: MJAR-252
> URL: https://issues.apache.org/jira/browse/MJAR-252
> Project: Maven JAR Plugin
>  Issue Type: Dependency upgrade
>Affects Versions: 3.1.1
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.1.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SUREFIRE-1520) ClassNotFoundException with forkCount>1 and junit5

[Paul Vorbach (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480692#comment-16480692
 ] 

Paul Vorbach commented on SUREFIRE-1520:


I also see the same error when running

{code}
mvn -DforkCount=0 verify
{code}

with both Surefire and Failsafe. [~djarnis73]'s workaround also works in my 
case.

> ClassNotFoundException with forkCount>1 and junit5
> --
>
> Key: SUREFIRE-1520
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1520
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: JUnit 5.x support, Maven Surefire Plugin
>Affects Versions: 2.21.0
>Reporter: Stefan Küttner
>Priority: Major
>
> maven-version: 3.2.5 / 3.3.9
> OS: Windows 7
> Java 8 (compiler level & runtime)
> {code:xml|title=pom.xml (effective-pom)|collapse=true}
>   
> maven-surefire-plugin
> 2.21.0
> 
>   
> default-test
> test
> 
>   test
> 
> 
>   
> **/*IntegrationTest.java
>   
>   false
>   2
>   true
>   
> 3600
>   
> -Djava.util.logging.config.file=${project.base.dir}logging.properties
>   alphabetical
>   
> **/*Test.java
>   
> 
>   
> 
> 
>   
> org.junit.platform
> junit-platform-surefire-provider
> 1.2.0
> compile
>   
>   
> org.junit.vintage
> junit-vintage-engine
> 5.2.0
> compile
>   
>   
> org.junit.jupiter
> junit-jupiter-engine
> 5.2.0
> compile
>   
> 
> 
>   2
>   true
>   3600
>   
> -Djava.util.logging.config.file=${project.base.dir}logging.properties
>   alphabetical
>   false
>   
> **/*Test.java
>   
>   
> **/*PerfTest.java
> **/*IntegrationTest.java
>   
> 
>   
> {code}
> result is 
> {code:java|title=java.lang.ClassNotFoundException: 
> org.apache.maven.plugin.surefire.log.api.ConsoleLogger|collapse=true}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.21.0:test (default-test) on 
> project mts.ctsm: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.21.0:test failed: 
> java.lang.ClassNotFoundException: 
> org.apache.maven.plugin.surefire.log.api.ConsoleLogger -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-surefire-plugin:2.21.0:test 
> (default-test) on project mts.ctsm: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.21.0:test failed: 
> java.lang.ClassNotFoundException: 
> org.apache.maven.plugin.surefire.log.api.ConsoleLogger
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:224)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:355)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:216)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:160)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
>   at 
> 

[jira] [Commented] (SUREFIRE-1522) IndexOutOfBoundsException for System.out.write

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480625#comment-16480625
 ] 

ASF GitHub Bot commented on SUREFIRE-1522:
--

docrjp commented on issue #185: [SUREFIRE-1522] fix escapeBytesToPrintable 
bounds check
URL: https://github.com/apache/maven-surefire/pull/185#issuecomment-390201339
 
 
   @Tibor17 whoops sorry, that's my bad for being impatient! I've amended the 
commit as requested, and the tests are now progressing through surefire-its. 
This bit was taking hours when I first checked out the project, but so far so 
good.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> IndexOutOfBoundsException for System.out.write
> --
>
> Key: SUREFIRE-1522
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1522
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin, process 
> forking
>Affects Versions: 2.21.0
>Reporter: Rob Platt
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 2.22.0
>
>
> There is a regression, I believe caused by -SUREFIRE-1454-. Git blame seems 
> to confirm this; and there was a related regression for empty arrays 
> SUREFIRE-1515.
> It can be easily reproduced with the following test:
>  
> {code:java}
> import org.junit.jupiter.api.Test;
> import java.nio.charset.StandardCharsets;
> public class SurefireLoggingTest {
> private final byte[] aNiceString = "what fun times, standard out is 
> broken\n".getBytes(StandardCharsets.US_ASCII);
> @Test
> public void fun() {
> System.out.write(aNiceString, 5, 3);
> }
> @Test
> public void fun_times() {
> System.out.write(aNiceString, 5, 9);
> }
> }
> {code}
>  
> Both tests will pass under Intellij, writing "fun" and "fun times" to 
> System.out. Whereas, with Surefire capturing standard out when running from 
> maven, only fun_times() passes. fun() will fail with:
>  
> {noformat}
> java.lang.IndexOutOfBoundsException: off < 0 || len < 0 || off >= 
> input.length || len > input.length || off > len{noformat}
>  
> If you look at the Javadoc contract for PrintStream.write(byte buf[], int 
> off, int len), you can see that len is "Number of bytes to write", so you can 
> see that it should be fine to print the substring "fun", of length 3, at 
> offset 5. And indeed that is what happens in Intellij.
>  
> I suspect that the failing test isolates the problem to when the offset 
> "exceeds" the length of the substring. The wrong length is being checked in 
> StringUtils.escapeBytesToPrintable(). I think that the check intended to 
> ensure the offset didn't exceed the end of the byte array, not the length of 
> the slice. But that is already covered by "off >= input.length". So there is 
> no benefit to also checking "off > len".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] docrjp commented on issue #185: [SUREFIRE-1522] fix escapeBytesToPrintable bounds check

[GitBox]

docrjp commented on issue #185: [SUREFIRE-1522] fix escapeBytesToPrintable 
bounds check
URL: https://github.com/apache/maven-surefire/pull/185#issuecomment-390201339
 
 
   @Tibor17 whoops sorry, that's my bad for being impatient! I've amended the 
commit as requested, and the tests are now progressing through surefire-its. 
This bit was taking hours when I first checked out the project, but so far so 
good.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (MASSEMBLY-887) Magically merged conflicting classpath

[JIRA]

 [ 
https://issues.apache.org/jira/browse/MASSEMBLY-887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michał updated MASSEMBLY-887:
-
Description: 
I have found this issue, while migrating a project from Maven to SBT.

To describe the problem I have created an example project with dependencies 
that I found to behave differently, depending on the build tool.

[https://github.com/atais/mvn-sbt-assembly]

 

The only dependencies are (sbt style)
{code:java}
"com.netflix.astyanax" % "astyanax-cassandra" % "3.9.0", 
"org.apache.cassandra" % "cassandra-all" % "3.4",{code}
and what I do not understand is, why {{mvn package}} creates the fat jar 
successfully, while {{sbt assembly}} gives conflicts:
{code:java}
[error] 39 errors were encountered during merge [error] 
java.lang.RuntimeException: deduplicate: different file contents found in the 
following: [error] 
/home/siatkowskim/.ivy2/cache/org.slf4j/jcl-over-slf4j/jars/jcl-over-slf4j-1.7.7.jar:org/apache/commons/logging/ [error] 
/home/siatkowskim/.ivy2/cache/commons-logging/commons-logging/jars/commons-logging-1.1.1.jar:org/apache/commons/logging/ ... [error] 
/home/siatkowskim/.ivy2/cache/com.github.stephenc.high-scale-lib/high-scale-lib/jars/high-scale-lib-1.1.2.jar:org/cliffc/high_scale_lib/ [error] 
/home/siatkowskim/.ivy2/cache/com.boundary/high-scale-lib/jars/high-scale-lib-1.0.6.jar:org/cliffc/high_scale_lib/ ...{code}
*{{So I wonder, how come this plugin overcomes this conflicts?}}*

{{I have also created a SO question, if one would like to earn some points: 
[https://stackoverflow.com/questions/50249818/why-maven-assembly-works-when-sbt-assembly-find-conflicts]}}

{{ }}

  was:
I have found this issue, while migrating a project from Maven to SBT.

To describe the problem I have created an example project with dependencies 
that I found to behave differently, depending on the build tool.

[https://github.com/atais/mvn-sbt-assembly]

 

The only dependencies are (sbt style)
{code:java}
"com.netflix.astyanax" % "astyanax-cassandra" % "3.9.0", "org.apache.cassandra" 
% "cassandra-all" % "3.4",{code}
and what I do not understand is, why {{mvn package}} creates the fat jar 
successfully, while {{sbt assembly}} gives conflicts:
{code:java}
[error] 39 errors were encountered during merge [error] 
java.lang.RuntimeException: deduplicate: different file contents found in the 
following: [error] 
/home/siatkowskim/.ivy2/cache/org.slf4j/jcl-over-slf4j/jars/jcl-over-slf4j-1.7.7.jar:org/apache/commons/logging/ [error] 
/home/siatkowskim/.ivy2/cache/commons-logging/commons-logging/jars/commons-logging-1.1.1.jar:org/apache/commons/logging/ ... [error] 
/home/siatkowskim/.ivy2/cache/com.github.stephenc.high-scale-lib/high-scale-lib/jars/high-scale-lib-1.1.2.jar:org/cliffc/high_scale_lib/ [error] 
/home/siatkowskim/.ivy2/cache/com.boundary/high-scale-lib/jars/high-scale-lib-1.0.6.jar:org/cliffc/high_scale_lib/ ...{code}
*{{So I wonder, how come this plugin overcomes this conflicts?}}*

{{I have also created a SO question, if one would like to earn some points: 
[https://stackoverflow.com/questions/50249818/why-maven-assembly-works-when-sbt-assembly-find-conflicts]}}

{{ }}


> Magically merged conflicting classpath 
> ---
>
> Key: MASSEMBLY-887
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-887
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>  Components: component descriptor
>Affects Versions: 3.1.0
>Reporter: Michał
>Priority: Major
>
> I have found this issue, while migrating a project from Maven to SBT.
> To describe the problem I have created an example project with dependencies 
> that I found to behave differently, depending on the build tool.
> [https://github.com/atais/mvn-sbt-assembly]
>  
> The only dependencies are (sbt style)
> {code:java}
> "com.netflix.astyanax" % "astyanax-cassandra" % "3.9.0", 
> "org.apache.cassandra" % "cassandra-all" % "3.4",{code}
> and what I do not understand is, why {{mvn package}} creates the fat jar 
> successfully, while {{sbt assembly}} gives conflicts:
> {code:java}
> [error] 39 errors were encountered during merge [error] 
> java.lang.RuntimeException: deduplicate: different file contents found in the 
> following: [error] 
> /home/siatkowskim/.ivy2/cache/org.slf4j/jcl-over-slf4j/jars/jcl-over-slf4j-1.7.7.jar:org/apache/commons/logging/  classes> [error] 
> /home/siatkowskim/.ivy2/cache/commons-logging/commons-logging/jars/commons-logging-1.1.1.jar:org/apache/commons/logging/  classes> ... [error] 
> /home/siatkowskim/.ivy2/cache/com.github.stephenc.high-scale-lib/high-scale-lib/jars/high-scale-lib-1.1.2.jar:org/cliffc/high_scale_lib/  classes> [error] 
> /home/siatkowskim/.ivy2/cache/com.boundary/high-scale-lib/jars/high-scale-lib-1.0.6.jar:org/cliffc/high_scale_lib/  classes> ...{code}
> *{{So I wonder, how come this plugin 

[jira] [Created] (MASSEMBLY-887) Magically merged conflicting classpath

[JIRA]

Michał created MASSEMBLY-887:


 Summary: Magically merged conflicting classpath 
 Key: MASSEMBLY-887
 URL: https://issues.apache.org/jira/browse/MASSEMBLY-887
 Project: Maven Assembly Plugin
  Issue Type: Bug
  Components: component descriptor
Affects Versions: 3.1.0
Reporter: Michał


I have found this issue, while migrating a project from Maven to SBT.

To describe the problem I have created an example project with dependencies 
that I found to behave differently, depending on the build tool.

[https://github.com/atais/mvn-sbt-assembly]

 

The only dependencies are (sbt style)
{code:java}
"com.netflix.astyanax" % "astyanax-cassandra" % "3.9.0", "org.apache.cassandra" 
% "cassandra-all" % "3.4",{code}
and what I do not understand is, why {{mvn package}} creates the fat jar 
successfully, while {{sbt assembly}} gives conflicts:
{code:java}
[error] 39 errors were encountered during merge [error] 
java.lang.RuntimeException: deduplicate: different file contents found in the 
following: [error] 
/home/siatkowskim/.ivy2/cache/org.slf4j/jcl-over-slf4j/jars/jcl-over-slf4j-1.7.7.jar:org/apache/commons/logging/ [error] 
/home/siatkowskim/.ivy2/cache/commons-logging/commons-logging/jars/commons-logging-1.1.1.jar:org/apache/commons/logging/ ... [error] 
/home/siatkowskim/.ivy2/cache/com.github.stephenc.high-scale-lib/high-scale-lib/jars/high-scale-lib-1.1.2.jar:org/cliffc/high_scale_lib/ [error] 
/home/siatkowskim/.ivy2/cache/com.boundary/high-scale-lib/jars/high-scale-lib-1.0.6.jar:org/cliffc/high_scale_lib/ ...{code}
*{{So I wonder, how come this plugin overcomes this conflicts?}}*

{{I have also created a SO question, if one would like to earn some points: 
[https://stackoverflow.com/questions/50249818/why-maven-assembly-works-when-sbt-assembly-find-conflicts]}}

{{ }}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6281) ArrayIndexOutOfBoundsException caused by pom.xml with invalid/duplicate XML

[Robert Scholte (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480569#comment-16480569
 ] 

Robert Scholte commented on MNG-6281:
-

No, this is not a duplicate of MNG-6216, but a subtask. The MNG-6216 shows the 
issue, however there are multiple causes, each requires their own solution. In 
this case the {{pom.xml}} is corrupt, but Maven doesn't show which pom is 
causing the issue.

> ArrayIndexOutOfBoundsException caused by pom.xml with invalid/duplicate XML
> ---
>
> Key: MNG-6281
> URL: https://issues.apache.org/jira/browse/MNG-6281
> Project: Maven
>  Issue Type: Sub-task
>  Components: POM
>Affects Versions: 3.5.0
>Reporter: Robert Scholte
>Priority: Major
> Fix For: 3.5.x-candidate
>
>
> This is a hard one to recognize and to reproduce, but there are cases where 
> (for unknown reasons) that the content of the XML is duplicated in the pom 
> file.
> Up until version 3.5.0 this was not an issue, because the XML parser stopped 
> parsing once hitting the closing project-tag, ignoring any content afterwards.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MENFORCER-185) Require Release Dependencies ignorant about aggregator build

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MENFORCER-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480558#comment-16480558
 ] 

ASF GitHub Bot commented on MENFORCER-185:
--

gmshake closed pull request #34: [MENFORCER-185] [WIP] Excludes take 
reactorProjects into account
URL: https://github.com/apache/maven-enforcer/pull/34
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/AbstractBanDependencies.java
 
b/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/AbstractBanDependencies.java
index 489bb7c..5faf344 100644
--- 
a/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/AbstractBanDependencies.java
+++ 
b/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/AbstractBanDependencies.java
@@ -30,6 +30,7 @@
 import 
org.codehaus.plexus.component.configurator.expression.ExpressionEvaluationException;
 import 
org.codehaus.plexus.component.repository.exception.ComponentLookupException;
 import java.util.HashSet;
+import java.util.List;
 import java.util.Set;
 
 /**
@@ -47,6 +48,11 @@
 
 private transient DependencyGraphBuilder graphBuilder;
 
+/**
+ * Contains the full list of projects in the reactor.
+ */
+private List reactorProjects;
+
 @Override
 public void execute( EnforcerRuleHelper helper )
 throws EnforcerRuleException
@@ -63,6 +69,16 @@ public void execute( EnforcerRuleHelper helper )
 throw new EnforcerRuleException( "Unable to retrieve the 
MavenProject: ", eee );
 }
 
+// get the reactor projects
+try
+{
+reactorProjects = (List) helper.evaluate( 
"${reactorProjects}" );
+}
+catch ( ExpressionEvaluationException eee )
+{
+throw new EnforcerRuleException( "Unable to retrieve the reactor 
MavenProject: ", eee );
+}
+
 try
 {
 graphBuilder = (DependencyGraphBuilder) helper.getComponent( 
DependencyGraphBuilder.class );
@@ -119,7 +135,7 @@ protected CharSequence getErrorMessage( Artifact artifact )
 Set dependencies = null;
 try
 {
-DependencyNode node = graphBuilder.buildDependencyGraph( project, 
null );
+DependencyNode node = graphBuilder.buildDependencyGraph( project, 
null, reactorProjects );
 if ( searchTransitive )
 {
 dependencies = getAllDescendants( node );
@@ -191,4 +207,19 @@ public void setSearchTransitive( boolean 
theSearchTransitive )
 this.searchTransitive = theSearchTransitive;
 }
 
+/**
+ * @return the reactorProjects
+ */
+public List getReactorProjects()
+{
+return reactorProjects;
+}
+
+/**
+ * @param reactorProjects the reactorProjects to set
+ */
+public void setReactorProjects( List reactorProjects )
+{
+this.reactorProjects = reactorProjects;
+}
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Require Release Dependencies ignorant about aggregator build
> 
>
> Key: MENFORCER-185
> URL: https://issues.apache.org/jira/browse/MENFORCER-185
> Project: Maven Enforcer Plugin
>  Issue Type: Bug
>  Components: Standard Rules
>Affects Versions: 1.3.1
>Reporter: Thomas Diesler
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: MENFORCER-185.patch, seuss.zip
>
>
> If A depends on B it is ok for A-1.0.0-SNAPSHOT to have snapshot dependency 
> on B-1.0.0-SNAPSHOT if B was build before A during the same reactor build.
> Using the requireReleaseDeps rule it seems that SNAPSHOTS are generally not 
> allowed even when they belong to the same project and were built during the 
> same reactor build.
> We have a complex project with 100+ modules. I want to enforce that no module 
> has dependencies on project SNAPSHOTS that were not included in the build. In 
> such case A would use a stale version of B that happened to be available in 
> the local/remote maven repository.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MENFORCER-185) Require Release Dependencies ignorant about aggregator build

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MENFORCER-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480557#comment-16480557
 ] 

ASF GitHub Bot commented on MENFORCER-185:
--

gmshake commented on issue #34: [MENFORCER-185] [WIP] Excludes take 
reactorProjects into account
URL: https://github.com/apache/maven-enforcer/pull/34#issuecomment-390185857
 
 
   Closed in favor of https://github.com/apache/maven-enforcer/pull/35


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Require Release Dependencies ignorant about aggregator build
> 
>
> Key: MENFORCER-185
> URL: https://issues.apache.org/jira/browse/MENFORCER-185
> Project: Maven Enforcer Plugin
>  Issue Type: Bug
>  Components: Standard Rules
>Affects Versions: 1.3.1
>Reporter: Thomas Diesler
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: MENFORCER-185.patch, seuss.zip
>
>
> If A depends on B it is ok for A-1.0.0-SNAPSHOT to have snapshot dependency 
> on B-1.0.0-SNAPSHOT if B was build before A during the same reactor build.
> Using the requireReleaseDeps rule it seems that SNAPSHOTS are generally not 
> allowed even when they belong to the same project and were built during the 
> same reactor build.
> We have a complex project with 100+ modules. I want to enforce that no module 
> has dependencies on project SNAPSHOTS that were not included in the build. In 
> such case A would use a stale version of B that happened to be available in 
> the local/remote maven repository.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6281) ArrayIndexOutOfBoundsException caused by pom.xml with invalid/duplicate XML

[Joseph Walton (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480556#comment-16480556
 ] 

Joseph Walton commented on MNG-6281:


Duplicate of MNG-6216?

> ArrayIndexOutOfBoundsException caused by pom.xml with invalid/duplicate XML
> ---
>
> Key: MNG-6281
> URL: https://issues.apache.org/jira/browse/MNG-6281
> Project: Maven
>  Issue Type: Sub-task
>  Components: POM
>Affects Versions: 3.5.0
>Reporter: Robert Scholte
>Priority: Major
> Fix For: 3.5.x-candidate
>
>
> This is a hard one to recognize and to reproduce, but there are cases where 
> (for unknown reasons) that the content of the XML is duplicated in the pom 
> file.
> Up until version 3.5.0 this was not an issue, because the XML parser stopped 
> parsing once hitting the closing project-tag, ignoring any content afterwards.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] gmshake commented on issue #34: [MENFORCER-185] [WIP] Excludes take reactorProjects into account

[GitBox]

gmshake commented on issue #34: [MENFORCER-185] [WIP] Excludes take 
reactorProjects into account
URL: https://github.com/apache/maven-enforcer/pull/34#issuecomment-390185857
 
 
   Closed in favor of https://github.com/apache/maven-enforcer/pull/35


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] gmshake closed pull request #34: [MENFORCER-185] [WIP] Excludes take reactorProjects into account

[GitBox]

gmshake closed pull request #34: [MENFORCER-185] [WIP] Excludes take 
reactorProjects into account
URL: https://github.com/apache/maven-enforcer/pull/34
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/AbstractBanDependencies.java
 
b/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/AbstractBanDependencies.java
index 489bb7c..5faf344 100644
--- 
a/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/AbstractBanDependencies.java
+++ 
b/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/AbstractBanDependencies.java
@@ -30,6 +30,7 @@
 import 
org.codehaus.plexus.component.configurator.expression.ExpressionEvaluationException;
 import 
org.codehaus.plexus.component.repository.exception.ComponentLookupException;
 import java.util.HashSet;
+import java.util.List;
 import java.util.Set;
 
 /**
@@ -47,6 +48,11 @@
 
 private transient DependencyGraphBuilder graphBuilder;
 
+/**
+ * Contains the full list of projects in the reactor.
+ */
+private List reactorProjects;
+
 @Override
 public void execute( EnforcerRuleHelper helper )
 throws EnforcerRuleException
@@ -63,6 +69,16 @@ public void execute( EnforcerRuleHelper helper )
 throw new EnforcerRuleException( "Unable to retrieve the 
MavenProject: ", eee );
 }
 
+// get the reactor projects
+try
+{
+reactorProjects = (List) helper.evaluate( 
"${reactorProjects}" );
+}
+catch ( ExpressionEvaluationException eee )
+{
+throw new EnforcerRuleException( "Unable to retrieve the reactor 
MavenProject: ", eee );
+}
+
 try
 {
 graphBuilder = (DependencyGraphBuilder) helper.getComponent( 
DependencyGraphBuilder.class );
@@ -119,7 +135,7 @@ protected CharSequence getErrorMessage( Artifact artifact )
 Set dependencies = null;
 try
 {
-DependencyNode node = graphBuilder.buildDependencyGraph( project, 
null );
+DependencyNode node = graphBuilder.buildDependencyGraph( project, 
null, reactorProjects );
 if ( searchTransitive )
 {
 dependencies = getAllDescendants( node );
@@ -191,4 +207,19 @@ public void setSearchTransitive( boolean 
theSearchTransitive )
 this.searchTransitive = theSearchTransitive;
 }
 
+/**
+ * @return the reactorProjects
+ */
+public List getReactorProjects()
+{
+return reactorProjects;
+}
+
+/**
+ * @param reactorProjects the reactorProjects to set
+ */
+public void setReactorProjects( List reactorProjects )
+{
+this.reactorProjects = reactorProjects;
+}
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MENFORCER-304) Improve dependency resolving in multiple modules project

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MENFORCER-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480521#comment-16480521
 ] 

ASF GitHub Bot commented on MENFORCER-304:
--

gmshake opened a new pull request #35:  [MENFORCER-304] Improve dependency 
resolving in multiple modules project
URL: https://github.com/apache/maven-enforcer/pull/35
 
 
   see 
[https://issues.apache.org/jira/browse/MENFORCER-304](https://issues.apache.org/jira/browse/MENFORCER-304)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improve dependency resolving in multiple modules project
> 
>
> Key: MENFORCER-304
> URL: https://issues.apache.org/jira/browse/MENFORCER-304
> Project: Maven Enforcer Plugin
>  Issue Type: Improvement
>  Components: Standard Rules
>Affects Versions: 3.0.0-M1
>Reporter: Zhenlei Huang
>Priority: Minor
>
> In a multiple modules project,  some enforcer rule can not get sufficient 
> dependency info with default phase validate, causing issues like 
> [https://issues.apache.org/jira/browse/MENFORCER-168|https://issues.apache.org/jira/browse/MENFORCER-168],
>  and probable 
> [https://issues.apache.org/jira/browse/MNG-3283|https://issues.apache.org/jira/browse/MNG-3283]
> Proposal: Include dependencies of reactor projects (not yet compiled) during 
> rule dependency resolving.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] gmshake opened a new pull request #35: [MENFORCER-304] Improve dependency resolving in multiple modules project

[GitBox]

gmshake opened a new pull request #35:  [MENFORCER-304] Improve dependency 
resolving in multiple modules project
URL: https://github.com/apache/maven-enforcer/pull/35
 
 
   see 
[https://issues.apache.org/jira/browse/MENFORCER-304](https://issues.apache.org/jira/browse/MENFORCER-304)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (MENFORCER-304) Improve dependency resolving in multiple modules project

[Zhenlei Huang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MENFORCER-304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhenlei Huang updated MENFORCER-304:

Summary: Improve dependency resolving in multiple modules project  (was: 
Improvement dependency resolving in multiple modules project)

> Improve dependency resolving in multiple modules project
> 
>
> Key: MENFORCER-304
> URL: https://issues.apache.org/jira/browse/MENFORCER-304
> Project: Maven Enforcer Plugin
>  Issue Type: Improvement
>  Components: Standard Rules
>Affects Versions: 3.0.0-M1
>Reporter: Zhenlei Huang
>Priority: Minor
>
> In a multiple modules project,  some enforcer rule can not get sufficient 
> dependency info with default phase validate, causing issues like 
> [https://issues.apache.org/jira/browse/MENFORCER-168|https://issues.apache.org/jira/browse/MENFORCER-168],
>  and probable 
> [https://issues.apache.org/jira/browse/MNG-3283|https://issues.apache.org/jira/browse/MNG-3283]
> Proposal: Include dependencies of reactor projects (not yet compiled) during 
> rule dependency resolving.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (MENFORCER-304) Improvement dependency resolving in multiple modules project

[Zhenlei Huang (JIRA)]

Zhenlei Huang created MENFORCER-304:
---

 Summary: Improvement dependency resolving in multiple modules 
project
 Key: MENFORCER-304
 URL: https://issues.apache.org/jira/browse/MENFORCER-304
 Project: Maven Enforcer Plugin
  Issue Type: Improvement
  Components: Standard Rules
Affects Versions: 3.0.0-M1
Reporter: Zhenlei Huang


In a multiple modules project,  some enforcer rule can not get sufficient 
dependency info with default phase validate, causing issues like 
[https://issues.apache.org/jira/browse/MENFORCER-168|https://issues.apache.org/jira/browse/MENFORCER-168],
 and probable 
[https://issues.apache.org/jira/browse/MNG-3283|https://issues.apache.org/jira/browse/MNG-3283]

Proposal: Include dependencies of reactor projects (not yet compiled) during 
rule dependency resolving.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated SCM-885:
---
Fix Version/s: (was: waiting-for-feedback)
   1.9.6

> GitChangeLogCommand is wrong when only endVersion is set
> 
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Priority: Major
> Fix For: 1.9.6
>
> Attachments: scm-885-different-behavior-exe-jgit-patch.diff
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has 
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso  ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso  END_REVISION_SHA1 -- PROJECT_PATH}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480476#comment-16480476
 ] 

Michael Osipov commented on SCM-885:


Great thank you. I'd also appreciate if this will work for both gitexe and jgit 
provider.

> GitChangeLogCommand is wrong when only endVersion is set
> 
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Priority: Major
> Fix For: waiting-for-feedback
>
> Attachments: scm-885-different-behavior-exe-jgit-patch.diff
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has 
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso  ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso  END_REVISION_SHA1 -- PROJECT_PATH}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set

[Matthieu Brouillard (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480425#comment-16480425
 ] 

Matthieu Brouillard edited comment on SCM-885 at 5/18/18 9:50 AM:
--

there is not problem ; I fully undertsand you could have been confused. And 
finally such confusion & discussions were good because in the end we will get a 
better impl because using the cases described in above table we will be 
backward compatible (expect for the bug fixes I will provide) and still offer 
the possibility to have history fom the beginning of the repository.
 I am working on the PR. As I really add more IT tests it takes more time to 
me, stay tuned...


was (Author: mcfoggy):
there is not problem ; I fully undertsand you could have been confused. And 
finally such confusion & discussions wree good because in the end we will get a 
better impl because using the cases described in above table we will be 
backward compatible (expect for the bug fixes I will provide) and still offer 
the possibility to have history fom the beginning of the repository.
I am working on the PR. As I really add more IT tests it takes more time to me, 
stay tuned...

> GitChangeLogCommand is wrong when only endVersion is set
> 
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Priority: Major
> Fix For: waiting-for-feedback
>
> Attachments: scm-885-different-behavior-exe-jgit-patch.diff
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has 
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso  ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso  END_REVISION_SHA1 -- PROJECT_PATH}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set

[Matthieu Brouillard (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480425#comment-16480425
 ] 

Matthieu Brouillard commented on SCM-885:
-

there is not problem ; I fully undertsand you could have been confused. And 
finally such confusion & discussions wree good because in the end we will get a 
better impl because using the cases described in above table we will be 
backward compatible (expect for the bug fixes I will provide) and still offer 
the possibility to have history fom the beginning of the repository.
I am working on the PR. As I really add more IT tests it takes more time to me, 
stay tuned...

> GitChangeLogCommand is wrong when only endVersion is set
> 
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Priority: Major
> Fix For: waiting-for-feedback
>
> Attachments: scm-885-different-behavior-exe-jgit-patch.diff
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has 
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso  ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso  END_REVISION_SHA1 -- PROJECT_PATH}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480391#comment-16480391
 ] 

Michael Osipov commented on SCM-885:


Sorry for the confusion I have caused. I did not intend to. I was trying to 
tailor a generic API to the Git approach, even it breaks behavior because I 
have come to the conclusion that your initial PR isn't that wrong after all.

I do agree, the table makes really sense and crystal clear. Looking forward to 
your new PR.

> GitChangeLogCommand is wrong when only endVersion is set
> 
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
>  Issue Type: Bug
>  Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Priority: Major
> Fix For: waiting-for-feedback
>
> Attachments: scm-885-different-behavior-exe-jgit-patch.diff
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has 
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso  ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso  END_REVISION_SHA1 -- PROJECT_PATH}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (MCOMPILER-323) Support multi-release jars

[Robert Scholte (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MCOMPILER-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte reassigned MCOMPILER-323:


Assignee: Robert Scholte

> Support multi-release jars
> --
>
> Key: MCOMPILER-323
> URL: https://issues.apache.org/jira/browse/MCOMPILER-323
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mike Drob
>Assignee: Robert Scholte
>Priority: Major
>
> Java 9 allows for JRE version specific code in the form of "multi-release 
> jars"
> Older JREs will treat them as normal jars, while newer JREs will load the 
> appropriate specific classes. AFAICT, maven does not currently support this.
> Compiler plugin should automatically detect when there are multiple source 
> levels and set MRJAR=True in the manifest.
> Source directories could potentially be src/main/java, src/main/java9, 
> src/main/java10, etc. These probably need to be configurable as well, or some 
> deeper discussion about what makes sense and is intuitive for users.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (MCOMPILER-336) Dependency that should be on modulepath sometime put on classpath

[Robert Scholte (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MCOMPILER-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte closed MCOMPILER-336.

   Resolution: Fixed
Fix Version/s: 3.7.1

Fixed in 
[bc99395b15f2b3062431c41269fb97efa9df5671|https://gitbox.apache.org/repos/asf?p=maven-compiler-plugin.git;a=commit;h=bc99395b15f2b3062431c41269fb97efa9df5671]

> Dependency that should be on modulepath sometime put on classpath
> -
>
> Key: MCOMPILER-336
> URL: https://issues.apache.org/jira/browse/MCOMPILER-336
> Project: Maven Compiler Plugin
>  Issue Type: Task
>Affects Versions: 3.7.0
>Reporter: Martin Desruisseaux
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 3.7.1
>
> Attachments: module-vs-classpath.zip
>
>
> {{maven-compiler-plugin}} sometime puts modularized dependencies on the 
> {{javac}} {{-classpath}} option instead than {{-modulepath}}, which cause 
> compilation failure. A test case is attached. Step to reproduce:
> {noformat}
> cd module-vs-classpath
> cd a
> mvn install
> cd ../b
> mvn clean install
> mvn install
> {noformat}
> The last command fail with the following error message:
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile 
> (default-compile) on project b: Compilation failure
> [ERROR] module not found: test.a
> {noformat}
> Execution with the {{-X}} option shows that the {{test.a}} dependency is 
> correctly declared in {{-modulepath}} when executing {{mvn clean install}}, 
> but is wrongly declared in {{-classpath}} when executing {{mvn install}}.
> A workaround is to remove the 
> {{false}} option in 
> the {{pom.xml}} files, or to execute {{touch src/main/java/module-info.java}} 
> before {{mvn install}}. However the same error message occurs when attempting 
> to execute {{mvn site}}, for which case I have found no workaround yet (note: 
> the {{mvn site}} problem is not reproduced by the attached 
> {{module-vs-classpath.zip}} file).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MCOMPILER-336) Dependency that should be on modulepath sometime put on classpath

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MCOMPILER-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480349#comment-16480349
 ] 

Hudson commented on MCOMPILER-336:
--

Build succeeded in Jenkins: Maven TLP » maven-compiler-plugin » master #22

See 
https://builds.apache.org/job/maven-box/job/maven-compiler-plugin/job/master/22/

> Dependency that should be on modulepath sometime put on classpath
> -
>
> Key: MCOMPILER-336
> URL: https://issues.apache.org/jira/browse/MCOMPILER-336
> Project: Maven Compiler Plugin
>  Issue Type: Task
>Affects Versions: 3.7.0
>Reporter: Martin Desruisseaux
>Assignee: Robert Scholte
>Priority: Major
> Attachments: module-vs-classpath.zip
>
>
> {{maven-compiler-plugin}} sometime puts modularized dependencies on the 
> {{javac}} {{-classpath}} option instead than {{-modulepath}}, which cause 
> compilation failure. A test case is attached. Step to reproduce:
> {noformat}
> cd module-vs-classpath
> cd a
> mvn install
> cd ../b
> mvn clean install
> mvn install
> {noformat}
> The last command fail with the following error message:
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile 
> (default-compile) on project b: Compilation failure
> [ERROR] module not found: test.a
> {noformat}
> Execution with the {{-X}} option shows that the {{test.a}} dependency is 
> correctly declared in {{-modulepath}} when executing {{mvn clean install}}, 
> but is wrongly declared in {{-classpath}} when executing {{mvn install}}.
> A workaround is to remove the 
> {{false}} option in 
> the {{pom.xml}} files, or to execute {{touch src/main/java/module-info.java}} 
> before {{mvn install}}. However the same error message occurs when attempting 
> to execute {{mvn site}}, for which case I have found no workaround yet (note: 
> the {{mvn site}} problem is not reproduced by the attached 
> {{module-vs-classpath.zip}} file).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)