[GitHub] [maven-ear-plugin] mabrarov commented on issue #1: [MEAR-271] added support for property
mabrarov commented on issue #1: [MEAR-271] added support for property URL: https://github.com/apache/maven-ear-plugin/pull/1#issuecomment-546652880 @khmarbaise, do you know any plans about release of Maven EAR Plugin 3.0.2? I need this fix for enforcement of initialization order b/w resources provided by Java EE container and applications deployed into that container. Refer to [WFLY-944](https://issues.jboss.org/browse/WFLY-944) for details. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] Tibor17 edited a comment on issue #240: [SUREFIRE-1658] TCP/IP Channel for forked Surefire JVM. Extensions API and SPI. Polymorphism for remote and local process communicatio
Tibor17 edited a comment on issue #240: [SUREFIRE-1658] TCP/IP Channel for forked Surefire JVM. Extensions API and SPI. Polymorphism for remote and local process communication. URL: https://github.com/apache/maven-surefire/pull/240#issuecomment-546646901 @jon-bell Here is TCP connector however still incomplete. It would need to have some abstraction as well. https://github.com/Tibor17/surefire-tcp-connector/blob/master/surefire-connector/src/main/java/org/apache/maven/surefire/Connector.java Question. Can we also use UDP connector since the dataflow will happen on local loopback address `127.0.0.1` and physical NIC which does not lose data? We used this approach on set top boxes and it worked reliably. It will be even faster data transport. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] Tibor17 edited a comment on issue #240: [SUREFIRE-1658] TCP/IP Channel for forked Surefire JVM. Extensions API and SPI. Polymorphism for remote and local process communicatio
Tibor17 edited a comment on issue #240: [SUREFIRE-1658] TCP/IP Channel for forked Surefire JVM. Extensions API and SPI. Polymorphism for remote and local process communication. URL: https://github.com/apache/maven-surefire/pull/240#issuecomment-546646901 @jon-bell Here is TCP connector however still incomplete. It would need to have some abstraction as well. https://github.com/Tibor17/surefire-tcp-connector/blob/master/surefire-connector/src/main/java/org/apache/maven/surefire/Connector.java Question. Can we also use UDP connector since the dataflow will happen on local loopback address `127.0.0.1` and physical NIC which does not lose data? We used this approach on set top boxes and it worked reliably. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on issue #240: [SUREFIRE-1658] TCP/IP Channel for forked Surefire JVM. Extensions API and SPI. Polymorphism for remote and local process communication.
Tibor17 commented on issue #240: [SUREFIRE-1658] TCP/IP Channel for forked Surefire JVM. Extensions API and SPI. Polymorphism for remote and local process communication. URL: https://github.com/apache/maven-surefire/pull/240#issuecomment-546646901 @jon-bell Here is TCP connector however still incomplete. It would need to have some abstraction as well. https://github.com/Tibor17/surefire-tcp-connector/blob/master/surefire-connector/src/main/java/org/apache/maven/surefire/Connector.java Question. Can we also use UDP connector since the dataflow will happen on local loopback address `127.0.0.1` and physical NIC which does not lose data? We used this approach on set top boxes and it worked safely. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] eolivelli commented on a change in pull request #297: MNG-6771 Fix license issues on binary distribution
eolivelli commented on a change in pull request #297: MNG-6771 Fix license
issues on binary distribution
URL: https://github.com/apache/maven/pull/297#discussion_r339316904
##
File path: apache-maven/src/main/assembly/component.xml
##
@@ -29,6 +29,7 @@ under the License.
false
lib
+
${artifact.artifactId}-${artifact.version}.${artifact.extension}
Review comment:
This is to have a cleaner and consistent naming of jars in LICENSE file and
in 'lib' directory.
We should add 'classifier' in both or drop it in both, actually it seems
simpler to do drop
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] eolivelli commented on a change in pull request #297: MNG-6771 Fix license issues on binary distribution
eolivelli commented on a change in pull request #297: MNG-6771 Fix license issues on binary distribution URL: https://github.com/apache/maven/pull/297#discussion_r339316869 ## File path: apache-maven/src/main/appended-resources/META-INF/LICENSE.vm ## @@ -22,21 +22,18 @@ Apache Maven includes a number of components and libraries with separate copyright notices and license terms. Your use of those components are subject to the terms and conditions of the following licenses: ## -#set ( $apacheLicenseNames = [ "Apache License, Version 2.0", "The Apache Software License, Version 2.0", -"ASLv2", "Apache Public License 2.0", "Apache 2.0" ] ) +#set ( $apacheMavenGroupIds = [ "org.apache.maven", "org.apache.maven.wagon", "org.apache.maven.resolver", +"org.apache.maven.shared" ] ) #set ( $MITLicenseNames = [ "MIT License", "MIT license", "The MIT License" ] ) #foreach ( $project in $projects ) #**##foreach ( $license in $project.licenses) -#* *##if ( !$apacheLicenseNames.contains( $license.name ) ) +#* *##set ( $groupId = $project.artifact.groupId ) +#* *##if ( !$apacheMavenGroupIds.contains( $groupId ) ) #**##set ( $artId = $project.artifact.artifactId ) #**##set ( $url = $license.url ) #**##set ( $spdx = false ) #**##set ( $includeLicense = true ) #**### -#**##if ( $project.artifact.artifactId == "jcl-over-slf4j" ) Review comment: this is to be discussed, if we should really report a different license other the one that is reported on Maven Central This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] eolivelli commented on a change in pull request #297: MNG-6771 Fix license issues on binary distribution
eolivelli commented on a change in pull request #297: MNG-6771 Fix license issues on binary distribution URL: https://github.com/apache/maven/pull/297#discussion_r339316853 ## File path: apache-maven/src/main/appended-resources/META-INF/LICENSE.vm ## @@ -22,21 +22,18 @@ Apache Maven includes a number of components and libraries with separate copyright notices and license terms. Your use of those components are subject to the terms and conditions of the following licenses: ## -#set ( $apacheLicenseNames = [ "Apache License, Version 2.0", "The Apache Software License, Version 2.0", -"ASLv2", "Apache Public License 2.0", "Apache 2.0" ] ) +#set ( $apacheMavenGroupIds = [ "org.apache.maven", "org.apache.maven.wagon", "org.apache.maven.resolver", Review comment: Skip our stuff, and all ASLv2 stuff from anyone see http://www.apache.org/dev/licensing-howto.html#alv2-dep This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] eolivelli commented on a change in pull request #297: MNG-6771 Fix license issues on binary distribution
eolivelli commented on a change in pull request #297: MNG-6771 Fix license
issues on binary distribution
URL: https://github.com/apache/maven/pull/297#discussion_r339317029
##
File path: dev/check-binary-license
##
@@ -0,0 +1,117 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Script to check licenses on a binary tarball.
+# It extracts the list of bundled jars, the NOTICE, and the LICENSE
+# files. It checked that every non-maven jar bundled is mentioned in the
+# LICENSE file. It checked that all jar files mentioned in NOTICE and
+# LICENSE are actually bundled.
+
+# all error fatal
+set -e
+
+TARBALL="$1"
+if [ -z $TARBALL ]; then
+echo "Usage: $0 "
+exit -1
+fi
+
+TAR='tar'
+unamestr=`uname`
+if [[ "$unamestr" == 'Linux' ]]; then
+ TAR='tar --wildcards'
+fi
+
+JARS=$(${TAR} -tf $TARBALL '*.jar' | sed 's!.*/!!' | sort)
+LICENSEPATH=$(${TAR} -tf $TARBALL | awk '/^[^\/]*\/LICENSE/')
+LICENSE=$(${TAR} -O -xf $TARBALL "$LICENSEPATH")
+NOTICEPATH=$(${TAR} -tf $TARBALL | awk '/^[^\/]*\/NOTICE/')
+NOTICE=$(${TAR} -O -xf $TARBALL $NOTICEPATH)
+LICENSEJARS=$(echo "$LICENSE" | sed -nE 's!.*lib/(.*\.jar).*!\1!gp')
+NOTICEJARS=$(echo "$NOTICE" | sed -nE 's!.*lib/(.*\.jar).*!\1!gp')
+
+LINKEDINLICENSE=$(echo "$LICENSE" | sed -nE
's!.*(lib/[[:graph:]]*.license).*!\1!gp' | sed 's!\.$!!' | sed 's/lib[/]//g')
+# errors not fatal
+set +e
+
+# this can error if there's no deps directory in tarball, we still want to
continue with checks
+BUNDLEDLICENSES=$(${TAR} -tf $TARBALL '*.license' | sed 's!^[^/]*/!!' | sed
's/lib[/]//g' | grep -v /$)
+EXIT=0
+
+# Check all bundled jars are mentioned in LICENSE
+for J in $JARS; do
+echo $J | grep -q "^maven"
+if [ $? == 0 ]; then
+continue
+fi
+echo $J | grep -q "^wagon"
+if [ $? == 0 ]; then
+continue
+fi
+
+echo "$LICENSE" | grep -q $J
+if [ $? != 0 ]; then
+echo $J unaccounted for in LICENSE
+EXIT=1
+fi
+done
+
+# Check all jars mentioned in LICENSE are bundled
+for J in $LICENSEJARS; do
+echo "$JARS" | grep -q $J
+if [ $? != 0 ]; then
+echo $J mentioned in LICENSE, but not bundled
+EXIT=2
+fi
+done
+
+# Check all jars mentioned in NOTICE are bundled
+for J in $NOTICEJARS; do
+echo "$JARS" | grep -q $J
+if [ $? != 0 ]; then
+echo $J mentioned in NOTICE, but not bundled
+EXIT=3
+fi
+done
+
+# Check all linked LICENSE files are in tarball
+for L in $LINKEDINLICENSE; do
+echo "$BUNDLEDLICENSES" | grep -q $L
+if [ $? != 0 ]; then
+echo $L linked from LICENSE, but not found in tarball
+EXIT=4
+fi
+done
+
+# Check all LICENSE files bundled are linked from LICENSE
+for L in $BUNDLEDLICENSES; do
+echo "$LINKEDINLICENSE" | grep -q $L
+if [ $? != 0 ]; then
+echo $L bundled, but not linked from LICENSE
+EXIT=5
+fi
+done
+
+if [ $EXIT != 0 ]; then
+echo
+echo "It looks like there are issues with the LICENSE/NOTICE (error
$EXIT)".
+echo See http://bookkeeper.apache.org/community/licensing for details on
how to fix.
Review comment:
this is to be changed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] eolivelli commented on a change in pull request #297: MNG-6771 Fix license issues on binary distribution
eolivelli commented on a change in pull request #297: MNG-6771 Fix license issues on binary distribution URL: https://github.com/apache/maven/pull/297#discussion_r339317020 ## File path: dev/check-binary-license ## @@ -0,0 +1,117 @@ +#!/usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# Script to check licenses on a binary tarball. +# It extracts the list of bundled jars, the NOTICE, and the LICENSE +# files. It checked that every non-maven jar bundled is mentioned in the +# LICENSE file. It checked that all jar files mentioned in NOTICE and +# LICENSE are actually bundled. + +# all error fatal +set -e + +TARBALL="$1" +if [ -z $TARBALL ]; then Review comment: This is just the adaptation of https://github.com/apache/bookkeeper/blob/master/dev/check-binary-license That in turn verifies for http://bookkeeper.apache.org/community/licensing We will adapt it to whatever rules we decide for Maven we could also convert to a Groovy/Python script, honestly I would love to see these kind of checks in the "Apache RAT" project This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-6771) Fix license issues on binary distribution
[
https://issues.apache.org/jira/browse/MNG-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960439#comment-16960439
]
Enrico Olivelli commented on MNG-6771:
--
Thank you [~vladimirsitnikov] for reporting these problems.
Prelimitar thoughts from me:
This is the guide I am following: http://www.apache.org/dev/licensing-howto.html
The first fact I see, in addition to [~vladimirsitnikov] and [~hboutemy]
comments is that we should cite also other ASLv2 artifacts of products not from
ASF, for instance Plexus.
I am working in this direction:
- understand our dependencies from LICENSE point of view
- have LICENSE files consistent with "lib" and "boot" directories
- add LICENSE refererences for all non ASF products. see
http://www.apache.org/dev/licensing-howto.html#alv2-dep
- setup some automatic check of the contents (I am picking up the work we did
in BookKeeper project), that I will adapt to whatever decision we do with the
expected contents
- fix erroneus LICENSE attributions and links
- verify NOTICE file and fix it, adding missing parts
*Hidden third party code*
for ASM, as it is included from a non Maven depedency, I think that it is not
our problem, it is a problem of the owner of Sisu, that it is actually
re-distributing the file. Yes we are also re-distributing it, but I don't know
to which extent we should dig into the bits of third party libs.
for JSoup we must fix the problem as it is in Wagon, that is a direct part of
Apache Maven project.
*Automatic download*
we are downloading links to other licenses directly from the poms, so as far as
they (maintainers of the third party libs) provide invalid links, any of the
link we provide it could break at any point in time, even if I find valid links
that work today. So I don't think it is worth to override links taken from
other sources.
the same discussion should also apply to the "license" we find in public poms,
if the owner published to Maven Central such license that the artifact is
released with that license, even if the website is saying differently.
By the way, these is only to share my current thoughts, I really have to dig
into every single dependency and see problems as [~vladimirsitnikov] already
did.
> Fix license issues on binary distribution
> -
>
> Key: MNG-6771
> URL: https://issues.apache.org/jira/browse/MNG-6771
> Project: Maven
> Issue Type: Bug
> Components: General
>Affects Versions: 3.6.2
>Reporter: Vladimir Sitnikov
>Assignee: Enrico Olivelli
>Priority: Major
> Labels: licenses
>
> Please feel free to adjust the priority, however
> [http://www.apache.org/legal/release-policy.html#licensing] says that license
> clearance is a must, thus I report this as a Blocker.
> {quote}Every ASF release MUST comply with ASF licensing policy. This
> requirement is of utmost importance
> {quote}
> I downloaded apache-maven-3.6.2-bin.zip, and I see the following issues with
> it (note: there might be more):
> h2. 1) jcl-over-slf4j:1.7.25
> in apache-maven-3.6.2/LICENSE:
> {quote} - JCL 1.2 implemented over SLF4J
> ([http://www.slf4j.org|http://www.slf4j.org/])
> org.slf4j:jcl-over-slf4j:jar:1.7.25
> License: MIT License (MIT)
> [http://www.opensource.org/licenses/mit-license.php]
> (lib/jcl-over-slf4j.license){quote}
> The license for the artifact is most likely Apache 2.0 rather than MIT:
> [https://github.com/qos-ch/slf4j/tree/master/jcl-over-slf4j]
> h2. 2) slf4j-api:1.7.25
> in apache-maven-3.6.2/LICENSE:
> {quote} - SLF4J API Module ([http://www.slf4j.org|http://www.slf4j.org/])
> org.slf4j:slf4j-api:jar:1.7.25
> License: MIT License (MIT)
> [http://www.opensource.org/licenses/mit-license.php]
> (lib/slf4j-api.license){quote}
> Maven does not comply with SLF4j license.
> Here's license for SLF4j: [https://www.slf4j.org/license.html]
> It requires to include slf4j copyright notice, however, Maven fails to do
> that
> h2. 3) MIT license
> [http://www.opensource.org/licenses/mit-license.php] must not be used as it
> almost never points to a true license. It is extremely unlucky that someone
> would copyright their work as "Copyright (c) "
> h2. 4) org.eclipse.sisu.inject:0.3.3
> in apache-maven-3.6.2/LICENSE:
> {quote} - org.eclipse.sisu.inject
> ([http://www.eclipse.org/sisu/org.eclipse.sisu.inject/])
> org.eclipse.sisu:org.eclipse.sisu.inject:eclipse-plugin:0.3.3
> License: Eclipse Public License, Version 1.0 (EPL-1.0)
> [http://www.eclipse.org/legal/epl-v10.html]
> (lib/org.eclipse.sisu.inject.license){quote}
> The link to eclipse.org/sisu responds with 404.
> sisu might have their own copyright notices that should be retained, however
> Maven re-distributes none of them (org.eclipse.sisu.inject.site-0.3.3.zip has
> notice.html file which is not present in
[GitHub] [maven] eolivelli opened a new pull request #297: MNG-6771 Fix license issues on binary distribution
eolivelli opened a new pull request #297: MNG-6771 Fix license issues on binary distribution URL: https://github.com/apache/maven/pull/297 - Start fixing the template for LICENSE file - Have consistent naming for LICENSE file and final jars by removing 'classifier' from the name of jars - Introduce a script to check for license, from Apache BookKeeper project, original author iv...@apache.org Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (MNG-6771) Fix license issues on binary distribution
[
https://issues.apache.org/jira/browse/MNG-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Enrico Olivelli updated MNG-6771:
-
Summary: Fix license issues on binary distribution (was: Please fix
license issues on binary distribution)
> Fix license issues on binary distribution
> -
>
> Key: MNG-6771
> URL: https://issues.apache.org/jira/browse/MNG-6771
> Project: Maven
> Issue Type: Bug
> Components: General
>Affects Versions: 3.6.2
>Reporter: Vladimir Sitnikov
>Assignee: Enrico Olivelli
>Priority: Major
> Labels: licenses
>
> Please feel free to adjust the priority, however
> [http://www.apache.org/legal/release-policy.html#licensing] says that license
> clearance is a must, thus I report this as a Blocker.
> {quote}Every ASF release MUST comply with ASF licensing policy. This
> requirement is of utmost importance
> {quote}
> I downloaded apache-maven-3.6.2-bin.zip, and I see the following issues with
> it (note: there might be more):
> h2. 1) jcl-over-slf4j:1.7.25
> in apache-maven-3.6.2/LICENSE:
> {quote} - JCL 1.2 implemented over SLF4J
> ([http://www.slf4j.org|http://www.slf4j.org/])
> org.slf4j:jcl-over-slf4j:jar:1.7.25
> License: MIT License (MIT)
> [http://www.opensource.org/licenses/mit-license.php]
> (lib/jcl-over-slf4j.license){quote}
> The license for the artifact is most likely Apache 2.0 rather than MIT:
> [https://github.com/qos-ch/slf4j/tree/master/jcl-over-slf4j]
> h2. 2) slf4j-api:1.7.25
> in apache-maven-3.6.2/LICENSE:
> {quote} - SLF4J API Module ([http://www.slf4j.org|http://www.slf4j.org/])
> org.slf4j:slf4j-api:jar:1.7.25
> License: MIT License (MIT)
> [http://www.opensource.org/licenses/mit-license.php]
> (lib/slf4j-api.license){quote}
> Maven does not comply with SLF4j license.
> Here's license for SLF4j: [https://www.slf4j.org/license.html]
> It requires to include slf4j copyright notice, however, Maven fails to do
> that
> h2. 3) MIT license
> [http://www.opensource.org/licenses/mit-license.php] must not be used as it
> almost never points to a true license. It is extremely unlucky that someone
> would copyright their work as "Copyright (c) "
> h2. 4) org.eclipse.sisu.inject:0.3.3
> in apache-maven-3.6.2/LICENSE:
> {quote} - org.eclipse.sisu.inject
> ([http://www.eclipse.org/sisu/org.eclipse.sisu.inject/])
> org.eclipse.sisu:org.eclipse.sisu.inject:eclipse-plugin:0.3.3
> License: Eclipse Public License, Version 1.0 (EPL-1.0)
> [http://www.eclipse.org/legal/epl-v10.html]
> (lib/org.eclipse.sisu.inject.license){quote}
> The link to eclipse.org/sisu responds with 404.
> sisu might have their own copyright notices that should be retained, however
> Maven re-distributes none of them (org.eclipse.sisu.inject.site-0.3.3.zip has
> notice.html file which is not present in Maven re-distribution)
> h2. 5) ASM in org.eclipse.sisu.inject-0.3.3.jar
> lib/org.eclipse.sisu.inject-0.3.3.jar bundles ASM. ASM is MIT licensed, thus
> every re-distribution MUST retain ASM copyright notice.
> Maven re-distributes ASM and fails to comply with ASM license.
> h2. 6) jsoup in wagon-http-3.3.3-shaded.jar
> lib/wagon-http-3.3.3-shaded.jar bundles jsoup ([https://jsoup.org/license])
> which is MIT-licensed. Maven fails to comply with jsoup license.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SUREFIRE-1700) @Disabled is not honored for JUnit5 tests having a single @Test method
[
https://issues.apache.org/jira/browse/SUREFIRE-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960381#comment-16960381
]
Tibor Digana commented on SUREFIRE-1700:
[~tfalabella]
Pls check my answers for you on the Stackoverflow. I replied to you there as
well. Pls try to use the snapshot version and let us know how it is.
Additionally you can write integration test in Surefire on GitHub. I would be
very glad because this vould be transparent. Talking about issues on
Stackoverflow about new issues does not solve anything. You have to tell us!
Without it, nothing would be possible.
If the issue would be visible, I will ask you to contribute on GitHub with
integration test at least.
if the issue does not exist with snapshot version, then tell me and I will
close this issue in Jira.
> @Disabled is not honored for JUnit5 tests having a single @Test method
> --
>
> Key: SUREFIRE-1700
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1700
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Affects Versions: 2.22.2, 3.0.0-M3
>Reporter: Tony Falabella
>Priority: Minor
> Labels: junit5
>
> JUnit5's {{@Disabled}} should ignore/skip running any test method with that
> annotation. It seems however that if there is a single {{@Test}} method with
> {{@Disabled}} that test method will still be run.
> Similar issue noted on StackOverflow:
> [https://stackoverflow.com/questions/52602351/junit-5-disabled-is-ignored]
> Sample class:
> package xxx;
> import org.junit.jupiter.api.Disabled;
> import org.junit.jupiter.api.Test;
> import org.junit.jupiter.api.extension.ExtendWith;
> import org.springframework.boot.test.context.SpringBootTest;
> import org.springframework.test.context.junit.jupiter.SpringExtension;
> import static org.assertj.core.api.Assertions.assertThat;
> @ExtendWith(SpringExtension.class)
> @SpringBootTest(classes = XyzBoot.class)
> public class MyTest {
> @Test
> @Disabled
> public void testSomething()
> { assertThat(true).isTrue(); }
> }
>
> Sample pom.xml (this is a multi-module pom that also has child modules of a
> parent). The test above is in a child project.
>
>
>
>
>
>
>
> org.apache.maven.plugins
> maven-surefire-plugin
>
> 2.22.0
> ...
>
>
> ...
>
> org.junit.jupiter
> junit-jupiter-engine
>
> compile
>
>
> org.mockito
> mockito-junit-jupiter
> test
>
>
>
> org.junit.platform
> junit-platform-launcher
> test
>
>
>
> org.junit.vintage
> junit-vintage-engine
> test
>
>
>
> Note that I've also tried this both with{{ junit-vintage-engine}} and without
> it (not sure if it would matter) and the issue still happens.
> This is affecting IntelliJ as well as noted here:
> [https://intellij-support.jetbrains.com/hc/en-us/community/posts/360006399720-IDEA-2019-2-2-Ultimate-Edition-ignores-Disabled-for-JUnit5-tests-having-a-single-Test-method]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-deploy-plugin] crewmanmud commented on issue #2: Remove dead link from examples
crewmanmud commented on issue #2: Remove dead link from examples URL: https://github.com/apache/maven-deploy-plugin/pull/2#issuecomment-546613829 @khmarbaise - possible to get this merged in? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SUREFIRE-1650) Running multiple xml using suiteXmlFiles resulting in 0 test count
[
https://issues.apache.org/jira/browse/SUREFIRE-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960367#comment-16960367
]
Tibor Digana commented on SUREFIRE-1650:
This must be user error. See this command
{{mvn test "-Dsurefire.suiteXmlFiles=path/to/suite1.xml,path/to/suite2.xml"}}
There is a rule how not to ask but how to always write successful commandline.
First of all see the list of configuration parameters on the documentation of
Surefire. You will see the parameter {{suiteXmlFiles}} and the {{User
Property}} which is the key for system property.
http://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#suiteXmlFiles
and see the documentation for the Faisale and see that we defined another
prefis for the parameter
http://maven.apache.org/surefire/maven-failsafe-plugin/integration-test-mojo.html#suiteXmlFiles
Finally, you can google some exmaple:
https://www.seleniumeasy.com/maven-tutorials/choose-selected-testng-xml-files-to-execute-using-maven
> Running multiple xml using suiteXmlFiles resulting in 0 test count
> --
>
> Key: SUREFIRE-1650
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1650
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin, TestNG support
>Affects Versions: 3.0.0-M3
>Reporter: Gavrila Budiwijaya
>Assignee: Tibor Digana
>Priority: Major
> Attachments: Zero Test Count.png
>
>
> POM setup:
> {code:java}
>
> org.apache.maven.plugins
> maven-surefire-plugin
> 3.0.0-M3
>
>
>
> -javaagent:"${settings.localRepository}/org/aspectj/aspectjweaver/${aspectj.version}/aspectjweaver-${aspectj.version}.jar"
> -Dcucumber.options="--plugin
> io.qameta.allure.cucumber4jvm.AllureCucumber4Jvm"
>
>
> ${suiteXmlFile}
>
>
> ${config}
>
>
>
> {code}
> Run using command line and multiple xml will results in 0 test count
> {code:java}
> mvn clean test -Dconfig="D:\configs\api\Automation - API - Staging.cfg"
> -DsuiteXmlFile="xml/regression/fintech/TestMain.xml","xml/regression/loyalty/TestMain.xml","xml/regression/payment/TestMain.xml"
> {code}
> The results will display correct counter when I run single xml file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (SUREFIRE-1650) Running multiple xml using suiteXmlFiles resulting in 0 test count
[
https://issues.apache.org/jira/browse/SUREFIRE-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana reassigned SUREFIRE-1650:
--
Assignee: Tibor Digana
> Running multiple xml using suiteXmlFiles resulting in 0 test count
> --
>
> Key: SUREFIRE-1650
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1650
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin, TestNG support
>Affects Versions: 3.0.0-M3
>Reporter: Gavrila Budiwijaya
>Assignee: Tibor Digana
>Priority: Major
> Attachments: Zero Test Count.png
>
>
> POM setup:
> {code:java}
>
> org.apache.maven.plugins
> maven-surefire-plugin
> 3.0.0-M3
>
>
>
> -javaagent:"${settings.localRepository}/org/aspectj/aspectjweaver/${aspectj.version}/aspectjweaver-${aspectj.version}.jar"
> -Dcucumber.options="--plugin
> io.qameta.allure.cucumber4jvm.AllureCucumber4Jvm"
>
>
> ${suiteXmlFile}
>
>
> ${config}
>
>
>
> {code}
> Run using command line and multiple xml will results in 0 test count
> {code:java}
> mvn clean test -Dconfig="D:\configs\api\Automation - API - Staging.cfg"
> -DsuiteXmlFile="xml/regression/fintech/TestMain.xml","xml/regression/loyalty/TestMain.xml","xml/regression/payment/TestMain.xml"
> {code}
> The results will display correct counter when I run single xml file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-surefire] Tibor17 commented on issue #240: [SUREFIRE-1658] TCP/IP Channel for forked Surefire JVM. Extensions API and SPI. Polymorphism for remote and local process communication.
Tibor17 commented on issue #240: [SUREFIRE-1658] TCP/IP Channel for forked Surefire JVM. Extensions API and SPI. Polymorphism for remote and local process communication. URL: https://github.com/apache/maven-surefire/pull/240#issuecomment-546610039 > > > @Tibor17 This current PR that we are commenting on [is currently not compilable](https://travis-ci.org/apache/maven-surefire/builds/578466293?utm_source=github_status_medium=notification). I would like to write a connector that is compatible with the interface that you've built here, but I can't compile the interface that you've built here. @jon-bell Now the branch can be compiled. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (MNG-6759) [REGRESSION] Maven fails to use section from dependency when resolving transitive dependencies in some cases
[
https://issues.apache.org/jira/browse/MNG-6759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960335#comment-16960335
]
Tibor Digana edited comment on MNG-6759 at 10/26/19 12:53 PM:
--
[~rfscholte]
At the conference I met Karl [~khmarbaise] and we said that Maven did not
behave according the spec. The users rely on a behavior as usually whether it
is right or wrong behavior. We said that the resolver might be buggy but it is
hard to fix it since the resolver is complex project. One of the hypothesis we
had in our mind was that the repository written in the POM of B dependency
should stay only within the resolver of B and should not be transitively
inherited into A (if A depends on B). Personally, i would expect parent's repo
used with higher priority and resolver should falback to B's repo if dependency
is not found in parent's repo but not vice versa. Did the Maven behave like
this in 3.6.1?
was (Author: tibor17):
[~rfscholte]
At the conference I met Karl [~khmarbaise] and we said that Maven did not
behave according the spec. The users rely on a behavior as usually whether it
is right or wrong behavior. We said that the resolver might be buggy but it is
hard to fix it since the resolver is complex project. One of the hypothesis we
had in our mind was that the repository written in the POM of B dependency
should stay only within the resolver of B and should not be transitively
inherited into A (if A depends on B).
> [REGRESSION] Maven fails to use section from dependency when
> resolving transitive dependencies in some cases
> ---
>
> Key: MNG-6759
> URL: https://issues.apache.org/jira/browse/MNG-6759
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.6.2
>Reporter: Stig Rohde Døssing
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 3.6.3
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> With Maven 3.6.2, I get the following error on a project using the ASF parent
> POM version 21:
> {quote}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process
> (process-resource-bundles) on project ChildA: Failed to resolve dependencies
> for one or more projects in the reactor. Reason: Missing:
> [ERROR] --
> [ERROR] 1) io.confluent:kafka-avro-serializer:jar:1.0
> [ERROR]
> [ERROR] Try downloading the file manually from the project website.
> [ERROR]
> [ERROR] Then, install it using the command:
> [ERROR] mvn install:install-file -DgroupId=io.confluent
> -DartifactId=kafka-avro-serializer -Dversion=1.0 -Dpackaging=jar
> -Dfile=/path/to/file
> [ERROR]
> [ERROR] Alternatively, if you host your own repository you can deploy the
> file there:
> [ERROR] mvn deploy:deploy-file -DgroupId=io.confluent
> -DartifactId=kafka-avro-serializer -Dversion=1.0 -Dpackaging=jar
> -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
> [ERROR]
> [ERROR] Path to dependency:
> [ERROR] 1) io.github.srdo:ChildA:jar:0.0.1-SNAPSHOT
> [ERROR] 2) io.github.srdo:ChildB:jar:0.0.1-SNAPSHOT
> [ERROR] 3) io.confluent:kafka-avro-serializer:jar:1.0
> [ERROR] --
> [ERROR] 1 required artifact is missing.
> [ERROR]
> [ERROR] for artifact:
> [ERROR] io.github.srdo:ChildA:jar:0.0.1-SNAPSHOT
> [ERROR]
> [ERROR] from the specified remote repositories:
> [ERROR] apache.snapshots (https://repository.apache.org/snapshots,
> releases=false, snapshots=true),
> [ERROR] central (https://repo.maven.apache.org/maven2, releases=true,
> snapshots=false)
> {quote}
> This build works on Maven 3.6.1. I've put up a reproduction at
> https://github.com/srdo/Maven362RepositoriesRegression
> I've found the following workarounds:
> * Dropping the ASF parent POM. Maybe there's a plugin version in there Maven
> 3.6.2 doesn't like?
> * Copying the section from ChildB into ChildA
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6759) [REGRESSION] Maven fails to use section from dependency when resolving transitive dependencies in some cases
[
https://issues.apache.org/jira/browse/MNG-6759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960335#comment-16960335
]
Tibor Digana commented on MNG-6759:
---
[~rfscholte]
At the conference I met Karl [~khmarbaise] and we said that Maven did not
behave according the spec. The users rely on a behavior as usually whether it
is right or wrong behavior. We said that the resolver might be buggy but it is
hard to fix it since the resolver is complex project. One of the hypothesis we
had in our mind was that the repository written in the POM of B dependency
should stay only within the resolver of B and should not be transitively
inherited into A (if A depends on B).
> [REGRESSION] Maven fails to use section from dependency when
> resolving transitive dependencies in some cases
> ---
>
> Key: MNG-6759
> URL: https://issues.apache.org/jira/browse/MNG-6759
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.6.2
>Reporter: Stig Rohde Døssing
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 3.6.3
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> With Maven 3.6.2, I get the following error on a project using the ASF parent
> POM version 21:
> {quote}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process
> (process-resource-bundles) on project ChildA: Failed to resolve dependencies
> for one or more projects in the reactor. Reason: Missing:
> [ERROR] --
> [ERROR] 1) io.confluent:kafka-avro-serializer:jar:1.0
> [ERROR]
> [ERROR] Try downloading the file manually from the project website.
> [ERROR]
> [ERROR] Then, install it using the command:
> [ERROR] mvn install:install-file -DgroupId=io.confluent
> -DartifactId=kafka-avro-serializer -Dversion=1.0 -Dpackaging=jar
> -Dfile=/path/to/file
> [ERROR]
> [ERROR] Alternatively, if you host your own repository you can deploy the
> file there:
> [ERROR] mvn deploy:deploy-file -DgroupId=io.confluent
> -DartifactId=kafka-avro-serializer -Dversion=1.0 -Dpackaging=jar
> -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
> [ERROR]
> [ERROR] Path to dependency:
> [ERROR] 1) io.github.srdo:ChildA:jar:0.0.1-SNAPSHOT
> [ERROR] 2) io.github.srdo:ChildB:jar:0.0.1-SNAPSHOT
> [ERROR] 3) io.confluent:kafka-avro-serializer:jar:1.0
> [ERROR] --
> [ERROR] 1 required artifact is missing.
> [ERROR]
> [ERROR] for artifact:
> [ERROR] io.github.srdo:ChildA:jar:0.0.1-SNAPSHOT
> [ERROR]
> [ERROR] from the specified remote repositories:
> [ERROR] apache.snapshots (https://repository.apache.org/snapshots,
> releases=false, snapshots=true),
> [ERROR] central (https://repo.maven.apache.org/maven2, releases=true,
> snapshots=false)
> {quote}
> This build works on Maven 3.6.1. I've put up a reproduction at
> https://github.com/srdo/Maven362RepositoriesRegression
> I've found the following workarounds:
> * Dropping the ASF parent POM. Maybe there's a plugin version in there Maven
> 3.6.2 doesn't like?
> * Copying the section from ChildB into ChildA
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-ear-plugin] khmarbaise commented on issue #1: [MEAR-271] added support for property
khmarbaise commented on issue #1: [MEAR-271] added support for property URL: https://github.com/apache/maven-ear-plugin/pull/1#issuecomment-546586370 I simply missed to close this PR here on Github. If you take a look into the code https://gitbox.apache.org/repos/asf?p=maven-ear-plugin.git;a=commitdiff;h=f002918d6cad2e607572a5049fe2b8e078a04979 you see two things the pr with the code and author ship has been taken and has been integrated into a release. The last commits on [maven-ear-pugin](https://github.com/apache/maven-ear-plugin/commits/master) have been done two weeks ago ... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-ear-plugin] mabrarov commented on issue #1: [MEAR-271] added support for property
mabrarov commented on issue #1: [MEAR-271] added support for property URL: https://github.com/apache/maven-ear-plugin/pull/1#issuecomment-546583234 Does anybody know what is the plan for this pull request? [MEAR-271](https://issues.apache.org/jira/browse/MEAR-271) JIRA issue is closed but this pull request is not merged and last commit is done a year ago. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (MNG-6794) Add mvn add groupId/artifactId feature like NPM to maven
gaurav created MNG-6794:
---
Summary: Add mvn add groupId/artifactId feature like NPM to maven
Key: MNG-6794
URL: https://issues.apache.org/jira/browse/MNG-6794
Project: Maven
Issue Type: Wish
Reporter: gaurav
The article 10 myths about java in
2019(https://developer.okta.com/blog/2019/07/15/java-myths-2019) list a nice
feature which maven could add to it.
For NPM, Want to add a new dependency? Just run {{npm i groupId/artifactId}}.
do think it would be cool if Maven had something like {{mvn add
groupId/artifactId}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
