[jira] [Commented] (MRESOLVER-554) Support configuration of upload/download threads individually
[
https://issues.apache.org/jira/browse/MRESOLVER-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842795#comment-17842795
]
ASF GitHub Bot commented on MRESOLVER-554:
--
slawekjaranowski commented on code in PR #489:
URL: https://github.com/apache/maven-resolver/pull/489#discussion_r1586890309
##
maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java:
##
@@ -97,15 +100,17 @@ final class BasicRepositoryConnector implements
RepositoryConnector {
private final ChecksumPolicyProvider checksumPolicyProvider;
-private final int maxThreads;
+private final int maxDownstreamThreads;
+
+private final int maxUpstreamThreads;
private final boolean smartChecksums;
private final boolean parallelPut;
private final boolean persistedChecksums;
-private Executor executor;
+private final ConcurrentHashMap executors;
Review Comment:
Enum will be more descriptive in methods calls than only simply true or
false as parameter.
> Support configuration of upload/download threads individually
> -
>
> Key: MRESOLVER-554
> URL: https://issues.apache.org/jira/browse/MRESOLVER-554
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
>Reporter: Matt Nelson
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-beta-1
>
>
> Parallel deploys were introduced in MRESOLVER-32. The thread pool
> configuration is shared for uploads and downloads. It has been observed in
> our environment that uploads frequently error out when attempting to upload
> with the default thread pool size(5), but conversely we don't see the same
> errors for downloads.
> The proposal is to support configuration of upload/download thread pools
> individually.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MRESOLVER-554] Split thread counts for up and downstream ops [maven-resolver]
slawekjaranowski commented on code in PR #489:
URL: https://github.com/apache/maven-resolver/pull/489#discussion_r1586890309
##
maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java:
##
@@ -97,15 +100,17 @@ final class BasicRepositoryConnector implements
RepositoryConnector {
private final ChecksumPolicyProvider checksumPolicyProvider;
-private final int maxThreads;
+private final int maxDownstreamThreads;
+
+private final int maxUpstreamThreads;
private final boolean smartChecksums;
private final boolean parallelPut;
private final boolean persistedChecksums;
-private Executor executor;
+private final ConcurrentHashMap executors;
Review Comment:
Enum will be more descriptive in methods calls than only simply true or
false as parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Set both maven.compiler.source and maven.compiler.target to 1.8 [maven-site]
kosbe opened a new pull request, #520: URL: https://github.com/apache/maven-site/pull/520 Since Maven 3.9.6 does not support 1.7 compiler, the sample project cannot be built as is. This is frustrating for an inexperienced user. The proposed fix was tested on Java 21.0.3, Win7 sp1+. P.S. Notice, the problem is not only with the docs. The code issue is known but still unresolved: https://issues.apache.org/jira/projects/MARCHETYPES/issues/MARCHETYPES-82?filter=allopenissues Even though the updated version was pushed to Maven Central Repository years ago: https://github.com/ywchang/maven-archetype-quickstart https://central.sonatype.com/artifact/com.github.ywchang/maven-archetype-quickstart In a meantime, the new user gets a build failure trying Maven for their first time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Remove info about old versions [maven-compiler-plugin]
elharo opened a new pull request, #237: URL: https://github.com/apache/maven-compiler-plugin/pull/237 Java 1.8 is now minimum, not Java 1.6. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSITE-1003) Upgrade plugins and components (in ITs)
[ https://issues.apache.org/jira/browse/MSITE-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842756#comment-17842756 ] ASF GitHub Bot commented on MSITE-1003: --- michael-o closed pull request #185: [MSITE-1003] Upgrade plugins and components (in ITs) URL: https://github.com/apache/maven-site-plugin/pull/185 > Upgrade plugins and components (in ITs) > --- > > Key: MSITE-1003 > URL: https://issues.apache.org/jira/browse/MSITE-1003 > Project: Maven Site Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0, 4.0.0-M14 > > > * Upgrade to Doxia 2.0.0-M10 > * Upgrade to Doxia Sitetools 2.0.0-M18 > * Upgrade to Maven Reporting API 4.0.0-M11 > * Upgrade to Maven Reporting Impl 4.0.0-M14 > * Upgrade to Maven Reporting Exec 4.0.0-M13 > * Upgrade to Maven Plugin Tools 3.12.0 > * Upgrade to Commons IO 2.16.1 > * Upgrade to Jetty 9.4.54.v20240208 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSITE-1003) Upgrade plugins and components (in ITs)
[ https://issues.apache.org/jira/browse/MSITE-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842757#comment-17842757 ] ASF GitHub Bot commented on MSITE-1003: --- michael-o commented on PR #185: URL: https://github.com/apache/maven-site-plugin/pull/185#issuecomment-2088999372 Merged manually. > Upgrade plugins and components (in ITs) > --- > > Key: MSITE-1003 > URL: https://issues.apache.org/jira/browse/MSITE-1003 > Project: Maven Site Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0, 4.0.0-M14 > > > * Upgrade to Doxia 2.0.0-M10 > * Upgrade to Doxia Sitetools 2.0.0-M18 > * Upgrade to Maven Reporting API 4.0.0-M11 > * Upgrade to Maven Reporting Impl 4.0.0-M14 > * Upgrade to Maven Reporting Exec 4.0.0-M13 > * Upgrade to Maven Plugin Tools 3.12.0 > * Upgrade to Commons IO 2.16.1 > * Upgrade to Jetty 9.4.54.v20240208 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MSITE-1003] Upgrade plugins and components (in ITs) [maven-site-plugin]
michael-o closed pull request #185: [MSITE-1003] Upgrade plugins and components (in ITs) URL: https://github.com/apache/maven-site-plugin/pull/185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MSITE-1003] Upgrade plugins and components (in ITs) [maven-site-plugin]
michael-o commented on PR #185: URL: https://github.com/apache/maven-site-plugin/pull/185#issuecomment-2088999372 Merged manually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MSITE-1003) Upgrade plugins and components (in ITs)
[ https://issues.apache.org/jira/browse/MSITE-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSITE-1003. - Resolution: Fixed Fixed with [1bbad2d356a4ede8ebbe3a523533b660d66d9b58|https://gitbox.apache.org/repos/asf?p=maven-site-plugin.git;a=commit;h=1bbad2d356a4ede8ebbe3a523533b660d66d9b58]. > Upgrade plugins and components (in ITs) > --- > > Key: MSITE-1003 > URL: https://issues.apache.org/jira/browse/MSITE-1003 > Project: Maven Site Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0, 4.0.0-M14 > > > * Upgrade to Doxia 2.0.0-M10 > * Upgrade to Doxia Sitetools 2.0.0-M18 > * Upgrade to Maven Reporting API 4.0.0-M11 > * Upgrade to Maven Reporting Impl 4.0.0-M14 > * Upgrade to Maven Reporting Exec 4.0.0-M13 > * Upgrade to Maven Plugin Tools 3.12.0 > * Upgrade to Commons IO 2.16.1 > * Upgrade to Jetty 9.4.54.v20240208 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MBUILDCACHE-86) Bugfix and enhancements with the restoration of outputs on disk
[ https://issues.apache.org/jira/browse/MBUILDCACHE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842747#comment-17842747 ] ASF GitHub Bot commented on MBUILDCACHE-86: --- nobesio commented on PR #104: URL: https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2088939166 Thank you, @kbuntrock! > Bugfix and enhancements with the restoration of outputs on disk > --- > > Key: MBUILDCACHE-86 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-86 > Project: Maven Build Cache Extension > Issue Type: Improvement >Reporter: Kevin Buntrock >Assignee: Olivier Lamy >Priority: Major > Labels: pull-request-available > Fix For: 1.2.0 > > > *Fixes :* > * Files containing an underscore in their name can't be restored in the > cache directory correctly (not in the same directory location). > * The cache is able to extract/restore files in locations outside the > project. I guess the extraction part is not a vulnerability since someone > with commit permissions can guess other ways to extract data. But the > possibility of restoring at any place on the disk looks pretty dangerous to > me if a remote cache server is compromised. > *Enhancements :* > * Possibility to restore artefacts on disk, with a dedicated property : > maven.build.cache.restoreOnDiskArtefacts (default to true). Meaning in the > project directory, as opposed to the cache directory. > ** IDE integration and use of the cache locally in developement is way > easier. It is now possible to retrieve a cached jar in the "target" directory. > * Introduce "globs" to filter extra attached outputs by filenames. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MBUILDCACHE-86] bugfix / enhancements restoration of outputs on disk [maven-build-cache-extension]
nobesio commented on PR #104: URL: https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2088939166 Thank you, @kbuntrock! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-519) Update to Parent POM 42, prerequisite 3.6.3
[
https://issues.apache.org/jira/browse/MPLUGIN-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842744#comment-17842744
]
ASF GitHub Bot commented on MPLUGIN-519:
slawekjaranowski commented on code in PR #280:
URL:
https://github.com/apache/maven-plugin-tools/pull/280#discussion_r1586636233
##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/metadata/AddPluginArtifactMetadataMojo.java:
##
@@ -69,25 +69,33 @@ public class AddPluginArtifactMetadataMojo extends
AbstractMojo {
@Parameter(defaultValue = "false", property = "maven.plugin.skip")
private boolean skip;
+@Component
+private RuntimeInformation runtimeInformation;
+
+private final VersionScheme versionScheme = new GenericVersionScheme();
+
/** {@inheritDoc} */
@Override
public void execute() throws MojoExecutionException {
if (skip) {
getLog().warn("Execution skipped");
return;
}
-Artifact projectArtifact = project.getArtifact();
-
-Versioning versioning = new Versioning();
-versioning.setLatest(projectArtifact.getVersion());
-versioning.updateTimestamp();
-ArtifactRepositoryMetadata metadata = new
ArtifactRepositoryMetadata(projectArtifact, versioning);
-projectArtifact.addMetadata(metadata);
-
-GroupRepositoryMetadata groupMetadata = new
GroupRepositoryMetadata(project.getGroupId());
-groupMetadata.addPluginMapping(getGoalPrefix(),
project.getArtifactId(), project.getName());
+// nothing if Maven is 3.9+
+try {
+if (versionScheme
+.parseVersion("3.9.0")
+
.compareTo(versionScheme.parseVersion(runtimeInformation.getMavenVersion()))
+< 1) {
+getLog().info("This Mojo is not used in Maven version 3.9.0
and above");
+return;
+}
+} catch (InvalidVersionSpecificationException e) {
+// not happening with generic
+throw new MojoExecutionException(e);
+}
-projectArtifact.addMetadata(groupMetadata);
+LegacySupport.execute(project, getGoalPrefix());
Review Comment:
We will see how many people use nexus-staging
> Update to Parent POM 42, prerequisite 3.6.3
> ---
>
> Key: MPLUGIN-519
> URL: https://issues.apache.org/jira/browse/MPLUGIN-519
> Project: Maven Plugin Tools
> Issue Type: Dependency upgrade
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.12.1
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MPLUGIN-519][MPLUGIN-520] Parent POM 42, prerequisite of 3.6.3, get rid of maven-compat [maven-plugin-tools]
slawekjaranowski commented on code in PR #280:
URL:
https://github.com/apache/maven-plugin-tools/pull/280#discussion_r1586636233
##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/metadata/AddPluginArtifactMetadataMojo.java:
##
@@ -69,25 +69,33 @@ public class AddPluginArtifactMetadataMojo extends
AbstractMojo {
@Parameter(defaultValue = "false", property = "maven.plugin.skip")
private boolean skip;
+@Component
+private RuntimeInformation runtimeInformation;
+
+private final VersionScheme versionScheme = new GenericVersionScheme();
+
/** {@inheritDoc} */
@Override
public void execute() throws MojoExecutionException {
if (skip) {
getLog().warn("Execution skipped");
return;
}
-Artifact projectArtifact = project.getArtifact();
-
-Versioning versioning = new Versioning();
-versioning.setLatest(projectArtifact.getVersion());
-versioning.updateTimestamp();
-ArtifactRepositoryMetadata metadata = new
ArtifactRepositoryMetadata(projectArtifact, versioning);
-projectArtifact.addMetadata(metadata);
-
-GroupRepositoryMetadata groupMetadata = new
GroupRepositoryMetadata(project.getGroupId());
-groupMetadata.addPluginMapping(getGoalPrefix(),
project.getArtifactId(), project.getName());
+// nothing if Maven is 3.9+
+try {
+if (versionScheme
+.parseVersion("3.9.0")
+
.compareTo(versionScheme.parseVersion(runtimeInformation.getMavenVersion()))
+< 1) {
+getLog().info("This Mojo is not used in Maven version 3.9.0
and above");
+return;
+}
+} catch (InvalidVersionSpecificationException e) {
+// not happening with generic
+throw new MojoExecutionException(e);
+}
-projectArtifact.addMetadata(groupMetadata);
+LegacySupport.execute(project, getGoalPrefix());
Review Comment:
We will see how many people use nexus-staging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MPLUGIN-519) Update to Parent POM 42, prerequisite 3.6.3
[
https://issues.apache.org/jira/browse/MPLUGIN-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842741#comment-17842741
]
ASF GitHub Bot commented on MPLUGIN-519:
slawekjaranowski commented on code in PR #280:
URL:
https://github.com/apache/maven-plugin-tools/pull/280#discussion_r1586630365
##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/metadata/AddPluginArtifactMetadataMojo.java:
##
@@ -69,25 +69,33 @@ public class AddPluginArtifactMetadataMojo extends
AbstractMojo {
@Parameter(defaultValue = "false", property = "maven.plugin.skip")
private boolean skip;
+@Component
+private RuntimeInformation runtimeInformation;
+
+private final VersionScheme versionScheme = new GenericVersionScheme();
+
/** {@inheritDoc} */
@Override
public void execute() throws MojoExecutionException {
if (skip) {
getLog().warn("Execution skipped");
return;
}
-Artifact projectArtifact = project.getArtifact();
-
-Versioning versioning = new Versioning();
-versioning.setLatest(projectArtifact.getVersion());
-versioning.updateTimestamp();
-ArtifactRepositoryMetadata metadata = new
ArtifactRepositoryMetadata(projectArtifact, versioning);
-projectArtifact.addMetadata(metadata);
-
-GroupRepositoryMetadata groupMetadata = new
GroupRepositoryMetadata(project.getGroupId());
-groupMetadata.addPluginMapping(getGoalPrefix(),
project.getArtifactId(), project.getName());
+// nothing if Maven is 3.9+
+try {
+if (versionScheme
+.parseVersion("3.9.0")
+
.compareTo(versionScheme.parseVersion(runtimeInformation.getMavenVersion()))
+< 1) {
+getLog().info("This Mojo is not used in Maven version 3.9.0
and above");
+return;
+}
+} catch (InvalidVersionSpecificationException e) {
+// not happening with generic
+throw new MojoExecutionException(e);
+}
-projectArtifact.addMetadata(groupMetadata);
+LegacySupport.execute(project, getGoalPrefix());
Review Comment:
> Update to Parent POM 42, prerequisite 3.6.3
> ---
>
> Key: MPLUGIN-519
> URL: https://issues.apache.org/jira/browse/MPLUGIN-519
> Project: Maven Plugin Tools
> Issue Type: Dependency upgrade
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.12.1
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MPLUGIN-519][MPLUGIN-520] Parent POM 42, prerequisite of 3.6.3, get rid of maven-compat [maven-plugin-tools]
slawekjaranowski commented on code in PR #280:
URL:
https://github.com/apache/maven-plugin-tools/pull/280#discussion_r1586630365
##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/metadata/AddPluginArtifactMetadataMojo.java:
##
@@ -69,25 +69,33 @@ public class AddPluginArtifactMetadataMojo extends
AbstractMojo {
@Parameter(defaultValue = "false", property = "maven.plugin.skip")
private boolean skip;
+@Component
+private RuntimeInformation runtimeInformation;
+
+private final VersionScheme versionScheme = new GenericVersionScheme();
+
/** {@inheritDoc} */
@Override
public void execute() throws MojoExecutionException {
if (skip) {
getLog().warn("Execution skipped");
return;
}
-Artifact projectArtifact = project.getArtifact();
-
-Versioning versioning = new Versioning();
-versioning.setLatest(projectArtifact.getVersion());
-versioning.updateTimestamp();
-ArtifactRepositoryMetadata metadata = new
ArtifactRepositoryMetadata(projectArtifact, versioning);
-projectArtifact.addMetadata(metadata);
-
-GroupRepositoryMetadata groupMetadata = new
GroupRepositoryMetadata(project.getGroupId());
-groupMetadata.addPluginMapping(getGoalPrefix(),
project.getArtifactId(), project.getName());
+// nothing if Maven is 3.9+
+try {
+if (versionScheme
+.parseVersion("3.9.0")
+
.compareTo(versionScheme.parseVersion(runtimeInformation.getMavenVersion()))
+< 1) {
+getLog().info("This Mojo is not used in Maven version 3.9.0
and above");
+return;
+}
+} catch (InvalidVersionSpecificationException e) {
+// not happening with generic
+throw new MojoExecutionException(e);
+}
-projectArtifact.addMetadata(groupMetadata);
+LegacySupport.execute(project, getGoalPrefix());
Review Comment:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Bump org.xmlunit:xmlunit-core from 2.9.1 to 2.10.0 [maven]
dependabot[bot] opened a new pull request, #1494: URL: https://github.com/apache/maven/pull/1494 Bumps [org.xmlunit:xmlunit-core](https://github.com/xmlunit/xmlunit) from 2.9.1 to 2.10.0. Release notes Sourced from https://github.com/xmlunit/xmlunit/releases;>org.xmlunit:xmlunit-core's releases. XMLUnit for Java 2.10.0 add a new ElementSelectors.byNameAndAllAttributes variant that filters attributes before deciding whether elements can be compared. Inspired by Issue https://redirect.github.com/xmlunit/xmlunit/issues/259;>#259 By default the TransformerFactorys created will now try to disable extension functions. If you need extension functions for your transformations you may want to pass in your own instance of TransformerFactory and TransformerFactoryConfigurer may help with that. Inspired by Issue https://redirect.github.com/xmlunit/xmlunit/issues/264;>#264 JAXPXPathEngine will now try to disable the execution of extension functions by default but uses XPathFactory#setProperty which is not available prior to Java 18. You may want to enable secure processing on an XPathFactory instance you pass to JAXPXPathEngine instead - and XPathFactoryConfigurer may help with that. Changelog Sourced from https://github.com/xmlunit/xmlunit/blob/main/RELEASE_NOTES.md;>org.xmlunit:xmlunit-core's changelog. XMLUnit for Java 2.10.0 - /Released 2024-04-28/ add a new ElementSelectors.byNameAndAllAttributes variant that filters attributes before deciding whether elements can be compared. Inspired by Issue https://redirect.github.com/xmlunit/xmlunit/issues/259;>#259 By default the TransformerFactorys created will now try to disable extension functions. If you need extension functions for your transformations you may want to pass in your own instance of TransformerFactory and TransformerFactoryConfigurer may help with that. Inspired by Issue https://redirect.github.com/xmlunit/xmlunit/issues/264;>#264 This is tracked as https://github.com/xmlunit/xmlunit/security/advisories/GHSA-chfm-68vv-pvw5;>CVE-2024-31573. JAXPXPathEngine will now try to disable the execution of extension functions by default but uses XPathFactory#setProperty which is not available prior to Java 18. You may want to enable secure processing on an XPathFactory instance you pass to JAXPXPathEngine instead - and XPathFactoryConfigurer may help with that. Commits https://github.com/xmlunit/xmlunit/commit/33a5d6a28712878fc1355802571aab074d2145c1;>33a5d6a fix release number https://github.com/xmlunit/xmlunit/commit/eceec4ab6f1edce3138e32a12bf3d2e1755ba73b;>eceec4a javadocs https://github.com/xmlunit/xmlunit/commit/75828fdc6952da5d8e4ae3ef509d15cfb8f2b728;>75828fd Create SECURITY.md https://github.com/xmlunit/xmlunit/commit/dcaafe9174e69d18c9bcf27b9a40862f3bab360a;>dcaafe9 record extension function changes https://github.com/xmlunit/xmlunit/commit/611f6beb4dbce136d4ef608239695b07d7bd7006;>611f6be try to disable extension functions for XPaths https://github.com/xmlunit/xmlunit/commit/b81d48b71dfd2868bdfc30a3e17ff973f32bc15b;>b81d48b disable XSLT extension functions by default, add more configurers https://github.com/xmlunit/xmlunit/commit/ba149098c97c9c845a0877c905d6b9d84e6568d0;>ba14909 XMLUnit 1.x is no longer maintained https://github.com/xmlunit/xmlunit/commit/cd6731e34ab7f6dbe0c7cf6b22c85af16ac3ff8e;>cd6731e this is going to be a feature release, not a bugfix release https://github.com/xmlunit/xmlunit/commit/c47d390d36d81708b9f3ebb196a6c7391198d6c1;>c47d390 record last changes https://github.com/xmlunit/xmlunit/commit/514191511f2ade5078a4fea02e37d0d281368e78;>5141915 add byNameAndAllAttributes that uses an attrbute filter Additional commits viewable in https://github.com/xmlunit/xmlunit/compare/v2.9.1...v2.10.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it -
[PR] Bump org.xmlunit:xmlunit-core from 2.9.1 to 2.10.0 [maven-antrun-plugin]
dependabot[bot] opened a new pull request, #98: URL: https://github.com/apache/maven-antrun-plugin/pull/98 Bumps [org.xmlunit:xmlunit-core](https://github.com/xmlunit/xmlunit) from 2.9.1 to 2.10.0. Release notes Sourced from https://github.com/xmlunit/xmlunit/releases;>org.xmlunit:xmlunit-core's releases. XMLUnit for Java 2.10.0 add a new ElementSelectors.byNameAndAllAttributes variant that filters attributes before deciding whether elements can be compared. Inspired by Issue https://redirect.github.com/xmlunit/xmlunit/issues/259;>#259 By default the TransformerFactorys created will now try to disable extension functions. If you need extension functions for your transformations you may want to pass in your own instance of TransformerFactory and TransformerFactoryConfigurer may help with that. Inspired by Issue https://redirect.github.com/xmlunit/xmlunit/issues/264;>#264 JAXPXPathEngine will now try to disable the execution of extension functions by default but uses XPathFactory#setProperty which is not available prior to Java 18. You may want to enable secure processing on an XPathFactory instance you pass to JAXPXPathEngine instead - and XPathFactoryConfigurer may help with that. Changelog Sourced from https://github.com/xmlunit/xmlunit/blob/main/RELEASE_NOTES.md;>org.xmlunit:xmlunit-core's changelog. XMLUnit for Java 2.10.0 - /Released 2024-04-28/ add a new ElementSelectors.byNameAndAllAttributes variant that filters attributes before deciding whether elements can be compared. Inspired by Issue https://redirect.github.com/xmlunit/xmlunit/issues/259;>#259 By default the TransformerFactorys created will now try to disable extension functions. If you need extension functions for your transformations you may want to pass in your own instance of TransformerFactory and TransformerFactoryConfigurer may help with that. Inspired by Issue https://redirect.github.com/xmlunit/xmlunit/issues/264;>#264 This is tracked as https://github.com/xmlunit/xmlunit/security/advisories/GHSA-chfm-68vv-pvw5;>CVE-2024-31573. JAXPXPathEngine will now try to disable the execution of extension functions by default but uses XPathFactory#setProperty which is not available prior to Java 18. You may want to enable secure processing on an XPathFactory instance you pass to JAXPXPathEngine instead - and XPathFactoryConfigurer may help with that. Commits https://github.com/xmlunit/xmlunit/commit/33a5d6a28712878fc1355802571aab074d2145c1;>33a5d6a fix release number https://github.com/xmlunit/xmlunit/commit/eceec4ab6f1edce3138e32a12bf3d2e1755ba73b;>eceec4a javadocs https://github.com/xmlunit/xmlunit/commit/75828fdc6952da5d8e4ae3ef509d15cfb8f2b728;>75828fd Create SECURITY.md https://github.com/xmlunit/xmlunit/commit/dcaafe9174e69d18c9bcf27b9a40862f3bab360a;>dcaafe9 record extension function changes https://github.com/xmlunit/xmlunit/commit/611f6beb4dbce136d4ef608239695b07d7bd7006;>611f6be try to disable extension functions for XPaths https://github.com/xmlunit/xmlunit/commit/b81d48b71dfd2868bdfc30a3e17ff973f32bc15b;>b81d48b disable XSLT extension functions by default, add more configurers https://github.com/xmlunit/xmlunit/commit/ba149098c97c9c845a0877c905d6b9d84e6568d0;>ba14909 XMLUnit 1.x is no longer maintained https://github.com/xmlunit/xmlunit/commit/cd6731e34ab7f6dbe0c7cf6b22c85af16ac3ff8e;>cd6731e this is going to be a feature release, not a bugfix release https://github.com/xmlunit/xmlunit/commit/c47d390d36d81708b9f3ebb196a6c7391198d6c1;>c47d390 record last changes https://github.com/xmlunit/xmlunit/commit/514191511f2ade5078a4fea02e37d0d281368e78;>5141915 add byNameAndAllAttributes that uses an attrbute filter Additional commits viewable in https://github.com/xmlunit/xmlunit/compare/v2.9.1...v2.10.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes
[PR] Bump org.xmlunit:xmlunit-core from 2.9.1 to 2.10.0 [maven-doxia]
dependabot[bot] opened a new pull request, #213: URL: https://github.com/apache/maven-doxia/pull/213 Bumps [org.xmlunit:xmlunit-core](https://github.com/xmlunit/xmlunit) from 2.9.1 to 2.10.0. Release notes Sourced from https://github.com/xmlunit/xmlunit/releases;>org.xmlunit:xmlunit-core's releases. XMLUnit for Java 2.10.0 add a new ElementSelectors.byNameAndAllAttributes variant that filters attributes before deciding whether elements can be compared. Inspired by Issue https://redirect.github.com/xmlunit/xmlunit/issues/259;>#259 By default the TransformerFactorys created will now try to disable extension functions. If you need extension functions for your transformations you may want to pass in your own instance of TransformerFactory and TransformerFactoryConfigurer may help with that. Inspired by Issue https://redirect.github.com/xmlunit/xmlunit/issues/264;>#264 JAXPXPathEngine will now try to disable the execution of extension functions by default but uses XPathFactory#setProperty which is not available prior to Java 18. You may want to enable secure processing on an XPathFactory instance you pass to JAXPXPathEngine instead - and XPathFactoryConfigurer may help with that. Changelog Sourced from https://github.com/xmlunit/xmlunit/blob/main/RELEASE_NOTES.md;>org.xmlunit:xmlunit-core's changelog. XMLUnit for Java 2.10.0 - /Released 2024-04-28/ add a new ElementSelectors.byNameAndAllAttributes variant that filters attributes before deciding whether elements can be compared. Inspired by Issue https://redirect.github.com/xmlunit/xmlunit/issues/259;>#259 By default the TransformerFactorys created will now try to disable extension functions. If you need extension functions for your transformations you may want to pass in your own instance of TransformerFactory and TransformerFactoryConfigurer may help with that. Inspired by Issue https://redirect.github.com/xmlunit/xmlunit/issues/264;>#264 This is tracked as https://github.com/xmlunit/xmlunit/security/advisories/GHSA-chfm-68vv-pvw5;>CVE-2024-31573. JAXPXPathEngine will now try to disable the execution of extension functions by default but uses XPathFactory#setProperty which is not available prior to Java 18. You may want to enable secure processing on an XPathFactory instance you pass to JAXPXPathEngine instead - and XPathFactoryConfigurer may help with that. Commits https://github.com/xmlunit/xmlunit/commit/33a5d6a28712878fc1355802571aab074d2145c1;>33a5d6a fix release number https://github.com/xmlunit/xmlunit/commit/eceec4ab6f1edce3138e32a12bf3d2e1755ba73b;>eceec4a javadocs https://github.com/xmlunit/xmlunit/commit/75828fdc6952da5d8e4ae3ef509d15cfb8f2b728;>75828fd Create SECURITY.md https://github.com/xmlunit/xmlunit/commit/dcaafe9174e69d18c9bcf27b9a40862f3bab360a;>dcaafe9 record extension function changes https://github.com/xmlunit/xmlunit/commit/611f6beb4dbce136d4ef608239695b07d7bd7006;>611f6be try to disable extension functions for XPaths https://github.com/xmlunit/xmlunit/commit/b81d48b71dfd2868bdfc30a3e17ff973f32bc15b;>b81d48b disable XSLT extension functions by default, add more configurers https://github.com/xmlunit/xmlunit/commit/ba149098c97c9c845a0877c905d6b9d84e6568d0;>ba14909 XMLUnit 1.x is no longer maintained https://github.com/xmlunit/xmlunit/commit/cd6731e34ab7f6dbe0c7cf6b22c85af16ac3ff8e;>cd6731e this is going to be a feature release, not a bugfix release https://github.com/xmlunit/xmlunit/commit/c47d390d36d81708b9f3ebb196a6c7391198d6c1;>c47d390 record last changes https://github.com/xmlunit/xmlunit/commit/514191511f2ade5078a4fea02e37d0d281368e78;>5141915 add byNameAndAllAttributes that uses an attrbute filter Additional commits viewable in https://github.com/xmlunit/xmlunit/compare/v2.9.1...v2.10.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
Re: [PR] Bump org.apache.maven.plugins:maven-install-plugin from 3.1.1 to 3.1.2 [maven-apache-parent]
CrazyHZM commented on PR #222: URL: https://github.com/apache/maven-apache-parent/pull/222#issuecomment-2088567028 @slawekjaranowski Thanks for the reminder. If a next-release milestone doesn't exist, do we need to create one? I found that some plugins don't have milestones. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-519) Update to Parent POM 42, prerequisite 3.6.3
[
https://issues.apache.org/jira/browse/MPLUGIN-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842665#comment-17842665
]
ASF GitHub Bot commented on MPLUGIN-519:
michael-o commented on code in PR #280:
URL:
https://github.com/apache/maven-plugin-tools/pull/280#discussion_r1586351295
##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/metadata/AddPluginArtifactMetadataMojo.java:
##
@@ -69,25 +69,33 @@ public class AddPluginArtifactMetadataMojo extends
AbstractMojo {
@Parameter(defaultValue = "false", property = "maven.plugin.skip")
private boolean skip;
+@Component
+private RuntimeInformation runtimeInformation;
+
+private final VersionScheme versionScheme = new GenericVersionScheme();
+
/** {@inheritDoc} */
@Override
public void execute() throws MojoExecutionException {
if (skip) {
getLog().warn("Execution skipped");
return;
}
-Artifact projectArtifact = project.getArtifact();
-
-Versioning versioning = new Versioning();
-versioning.setLatest(projectArtifact.getVersion());
-versioning.updateTimestamp();
-ArtifactRepositoryMetadata metadata = new
ArtifactRepositoryMetadata(projectArtifact, versioning);
-projectArtifact.addMetadata(metadata);
-
-GroupRepositoryMetadata groupMetadata = new
GroupRepositoryMetadata(project.getGroupId());
-groupMetadata.addPluginMapping(getGoalPrefix(),
project.getArtifactId(), project.getName());
+// nothing if Maven is 3.9+
+try {
+if (versionScheme
+.parseVersion("3.9.0")
+
.compareTo(versionScheme.parseVersion(runtimeInformation.getMavenVersion()))
+< 1) {
+getLog().info("This Mojo is not used in Maven version 3.9.0
and above");
+return;
+}
+} catch (InvalidVersionSpecificationException e) {
+// not happening with generic
+throw new MojoExecutionException(e);
+}
-projectArtifact.addMetadata(groupMetadata);
+LegacySupport.execute(project, getGoalPrefix());
Review Comment:
I fully agree with @cstamas and ignore it.
> Update to Parent POM 42, prerequisite 3.6.3
> ---
>
> Key: MPLUGIN-519
> URL: https://issues.apache.org/jira/browse/MPLUGIN-519
> Project: Maven Plugin Tools
> Issue Type: Dependency upgrade
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.12.1
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPLUGIN-519) Update to Parent POM 42, prerequisite 3.6.3
[ https://issues.apache.org/jira/browse/MPLUGIN-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842666#comment-17842666 ] ASF GitHub Bot commented on MPLUGIN-519: michael-o commented on PR #280: URL: https://github.com/apache/maven-plugin-tools/pull/280#issuecomment-2088537450 This will constitute a great 3.13.0 release. > Update to Parent POM 42, prerequisite 3.6.3 > --- > > Key: MPLUGIN-519 > URL: https://issues.apache.org/jira/browse/MPLUGIN-519 > Project: Maven Plugin Tools > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.12.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MPLUGIN-519][MPLUGIN-520] Parent POM 42, prerequisite of 3.6.3, get rid of maven-compat [maven-plugin-tools]
michael-o commented on PR #280: URL: https://github.com/apache/maven-plugin-tools/pull/280#issuecomment-2088537450 This will constitute a great 3.13.0 release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPLUGIN-519][MPLUGIN-520] Parent POM 42, prerequisite of 3.6.3, get rid of maven-compat [maven-plugin-tools]
michael-o commented on code in PR #280:
URL:
https://github.com/apache/maven-plugin-tools/pull/280#discussion_r1586351295
##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/metadata/AddPluginArtifactMetadataMojo.java:
##
@@ -69,25 +69,33 @@ public class AddPluginArtifactMetadataMojo extends
AbstractMojo {
@Parameter(defaultValue = "false", property = "maven.plugin.skip")
private boolean skip;
+@Component
+private RuntimeInformation runtimeInformation;
+
+private final VersionScheme versionScheme = new GenericVersionScheme();
+
/** {@inheritDoc} */
@Override
public void execute() throws MojoExecutionException {
if (skip) {
getLog().warn("Execution skipped");
return;
}
-Artifact projectArtifact = project.getArtifact();
-
-Versioning versioning = new Versioning();
-versioning.setLatest(projectArtifact.getVersion());
-versioning.updateTimestamp();
-ArtifactRepositoryMetadata metadata = new
ArtifactRepositoryMetadata(projectArtifact, versioning);
-projectArtifact.addMetadata(metadata);
-
-GroupRepositoryMetadata groupMetadata = new
GroupRepositoryMetadata(project.getGroupId());
-groupMetadata.addPluginMapping(getGoalPrefix(),
project.getArtifactId(), project.getName());
+// nothing if Maven is 3.9+
+try {
+if (versionScheme
+.parseVersion("3.9.0")
+
.compareTo(versionScheme.parseVersion(runtimeInformation.getMavenVersion()))
+< 1) {
+getLog().info("This Mojo is not used in Maven version 3.9.0
and above");
+return;
+}
+} catch (InvalidVersionSpecificationException e) {
+// not happening with generic
+throw new MojoExecutionException(e);
+}
-projectArtifact.addMetadata(groupMetadata);
+LegacySupport.execute(project, getGoalPrefix());
Review Comment:
I fully agree with @cstamas and ignore it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MSITE-1000) Allow parametrisation of Doxia parser per file
[
https://issues.apache.org/jira/browse/MSITE-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842664#comment-17842664
]
ASF GitHub Bot commented on MSITE-1000:
---
michael-o commented on PR #177:
URL:
https://github.com/apache/maven-site-plugin/pull/177#issuecomment-2088535907
Here is a fix: https://github.com/apache/maven-plugin-tools/pull/281
> Allow parametrisation of Doxia parser per file
> --
>
> Key: MSITE-1000
> URL: https://issues.apache.org/jira/browse/MSITE-1000
> Project: Maven Site Plugin
> Issue Type: New Feature
> Components: doxia integration
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently only the attributes used for rendering the site can be
> parameterized in
> https://maven.apache.org/plugins/maven-site-plugin/site-mojo.html#attributes.
> There is no possibility to configure the parser in
> https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L322
> per document.
> This would be nice in the context of
> https://issues.apache.org/jira/browse/DOXIA-722 where generation of anchors
> should be switched on/off for certain documents. Also generation of comments
> may be desirable for certain documents.
> I propose the following additional plugin goal parameter:
> {code}
>
>
>
> **/apt/**
>
> false
> true
>
>
> {code}
> where {{parserConfigurations}} is an array of a complex type with (include)
> patterns on the source path (String array) and boolean methods for features.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPLUGIN-521) Nested types not properly extracted cause exception while generating Javadoc URLs
[
https://issues.apache.org/jira/browse/MPLUGIN-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842663#comment-17842663
]
ASF GitHub Bot commented on MPLUGIN-521:
michael-o opened a new pull request, #281:
URL: https://github.com/apache/maven-plugin-tools/pull/281
…le generating Javadoc URLs
This closes #281
> Nested types not properly extracted cause exception while generating Javadoc
> URLs
> -
>
> Key: MPLUGIN-521
> URL: https://issues.apache.org/jira/browse/MPLUGIN-521
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
>Affects Versions: 3.12.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.12.1
>
>
> Details:
> https://github.com/apache/maven-site-plugin/pull/177#pullrequestreview-2033188399
> If you have a type like {{Map>}} the generator will extract
> {{List}} instead of just {{Foo}}. We should recursively go down to the
> type.
> This is likely an edge case.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSITE-1000] Introduce parser configuration parameter [maven-site-plugin]
michael-o commented on PR #177: URL: https://github.com/apache/maven-site-plugin/pull/177#issuecomment-2088535907 Here is a fix: https://github.com/apache/maven-plugin-tools/pull/281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [MPLUGIN-521] Nested types not properly extracted cause exception whi… [maven-plugin-tools]
michael-o opened a new pull request, #281: URL: https://github.com/apache/maven-plugin-tools/pull/281 …le generating Javadoc URLs This closes #281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MPLUGIN-521) Nested types not properly extracted cause exception while generating Javadoc URLs
Michael Osipov created MPLUGIN-521:
--
Summary: Nested types not properly extracted cause exception while
generating Javadoc URLs
Key: MPLUGIN-521
URL: https://issues.apache.org/jira/browse/MPLUGIN-521
Project: Maven Plugin Tools
Issue Type: Bug
Components: Plugin Plugin
Affects Versions: 3.12.0
Reporter: Michael Osipov
Assignee: Michael Osipov
Fix For: 3.12.1
Details:
https://github.com/apache/maven-site-plugin/pull/177#pullrequestreview-2033188399
If you have a type like {{Map>}} the generator will extract
{{List}} instead of just {{Foo}}. We should recursively go down to the
type.
This is likely an edge case.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHARED-1382) Maven-invoker: support '--no-snapshot-updates'
[
https://issues.apache.org/jira/browse/MSHARED-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842656#comment-17842656
]
ASF GitHub Bot commented on MSHARED-1382:
-
lrozenblyum commented on code in PR #74:
URL: https://github.com/apache/maven-invoker/pull/74#discussion_r1586330276
##
src/test/java/org/apache/maven/shared/invoker/MavenCommandLineBuilderTest.java:
##
@@ -299,6 +299,33 @@ public void testShouldSetUpdateSnapshotsFlagFromRequest() {
assertArgumentsPresent(cli, Collections.singleton("-U"));
}
+// JUnit5: test methods don't need to be public
Review Comment:
Actually the `test` prefix is also redundant for `@Test` methods, yet here I
kept the project-wide convention...
> Maven-invoker: support '--no-snapshot-updates'
> --
>
> Key: MSHARED-1382
> URL: https://issues.apache.org/jira/browse/MSHARED-1382
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-invoker
>Affects Versions: maven-invoker-3.2.0
>Reporter: Leonid Rozenblyum
>Priority: Major
>
> Let's add support for *{{--no-snapshot-updates}}* in
> *{{org.apache.maven.shared.invoker.InvocationRequest}}*
>
> Currently *{{InvocationRequest}}* supports just the *{{-U}}* *mvn* option
> which is not enough: it's possible to force the snapshots update or keep
> default maven policy on this.
>
> But it's not possible to prevent snapshots updates which is highly desired
> under some circumstances (e.g. for CI reproducibility).
>
> NOTE: I may contribute a PR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSHARED-1382] support a possibility to disable snapshots update. [maven-invoker]
lrozenblyum commented on code in PR #74:
URL: https://github.com/apache/maven-invoker/pull/74#discussion_r1586330276
##
src/test/java/org/apache/maven/shared/invoker/MavenCommandLineBuilderTest.java:
##
@@ -299,6 +299,33 @@ public void testShouldSetUpdateSnapshotsFlagFromRequest() {
assertArgumentsPresent(cli, Collections.singleton("-U"));
}
+// JUnit5: test methods don't need to be public
Review Comment:
Actually the `test` prefix is also redundant for `@Test` methods, yet here I
kept the project-wide convention...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MSITE-1000) Allow parametrisation of Doxia parser per file
[
https://issues.apache.org/jira/browse/MSITE-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842648#comment-17842648
]
ASF GitHub Bot commented on MSITE-1000:
---
michael-o commented on PR #177:
URL:
https://github.com/apache/maven-site-plugin/pull/177#issuecomment-2088483641
The bug is in
`org.apache.maven.tools.plugin.generator.PluginDescriptorFilesGenerator.getJavadocUrlForType(JavadocLinkGenerator,
String)`. I guess it should until all generics are resolved.
> Allow parametrisation of Doxia parser per file
> --
>
> Key: MSITE-1000
> URL: https://issues.apache.org/jira/browse/MSITE-1000
> Project: Maven Site Plugin
> Issue Type: New Feature
> Components: doxia integration
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently only the attributes used for rendering the site can be
> parameterized in
> https://maven.apache.org/plugins/maven-site-plugin/site-mojo.html#attributes.
> There is no possibility to configure the parser in
> https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L322
> per document.
> This would be nice in the context of
> https://issues.apache.org/jira/browse/DOXIA-722 where generation of anchors
> should be switched on/off for certain documents. Also generation of comments
> may be desirable for certain documents.
> I propose the following additional plugin goal parameter:
> {code}
>
>
>
> **/apt/**
>
> false
> true
>
>
> {code}
> where {{parserConfigurations}} is an array of a complex type with (include)
> patterns on the source path (String array) and boolean methods for features.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSITE-1000] Introduce parser configuration parameter [maven-site-plugin]
michael-o commented on PR #177: URL: https://github.com/apache/maven-site-plugin/pull/177#issuecomment-2088483641 The bug is in `org.apache.maven.tools.plugin.generator.PluginDescriptorFilesGenerator.getJavadocUrlForType(JavadocLinkGenerator, String)`. I guess it should until all generics are resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-1382) Maven-invoker: support '--no-snapshot-updates'
[
https://issues.apache.org/jira/browse/MSHARED-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842645#comment-17842645
]
ASF GitHub Bot commented on MSHARED-1382:
-
lrozenblyum commented on PR #74:
URL: https://github.com/apache/maven-invoker/pull/74#issuecomment-2088473729
@slawekjaranowski fixed. The cause of the difference was JAVA_HOME pointing
to JDK1.8, but we need JDK17 for building as in CI to get the `spotless` errors.
> Maven-invoker: support '--no-snapshot-updates'
> --
>
> Key: MSHARED-1382
> URL: https://issues.apache.org/jira/browse/MSHARED-1382
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-invoker
>Affects Versions: maven-invoker-3.2.0
>Reporter: Leonid Rozenblyum
>Priority: Major
>
> Let's add support for *{{--no-snapshot-updates}}* in
> *{{org.apache.maven.shared.invoker.InvocationRequest}}*
>
> Currently *{{InvocationRequest}}* supports just the *{{-U}}* *mvn* option
> which is not enough: it's possible to force the snapshots update or keep
> default maven policy on this.
>
> But it's not possible to prevent snapshots updates which is highly desired
> under some circumstances (e.g. for CI reproducibility).
>
> NOTE: I may contribute a PR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSHARED-1382] support a possibility to disable snapshots update. [maven-invoker]
lrozenblyum commented on PR #74: URL: https://github.com/apache/maven-invoker/pull/74#issuecomment-2088473729 @slawekjaranowski fixed. The cause of the difference was JAVA_HOME pointing to JDK1.8, but we need JDK17 for building as in CI to get the `spotless` errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-1382) Maven-invoker: support '--no-snapshot-updates'
[
https://issues.apache.org/jira/browse/MSHARED-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842639#comment-17842639
]
ASF GitHub Bot commented on MSHARED-1382:
-
lrozenblyum commented on PR #74:
URL: https://github.com/apache/maven-invoker/pull/74#issuecomment-2088460111
@slawekjaranowski thx I'll check it.
`mvn verify` was green at my PC (and `mvn -Prun-its verify` which is
suggested by README issues a warning about a not-existing profile).
I'll check what is run in CI and simulate it locally.
> Maven-invoker: support '--no-snapshot-updates'
> --
>
> Key: MSHARED-1382
> URL: https://issues.apache.org/jira/browse/MSHARED-1382
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-invoker
>Affects Versions: maven-invoker-3.2.0
>Reporter: Leonid Rozenblyum
>Priority: Major
>
> Let's add support for *{{--no-snapshot-updates}}* in
> *{{org.apache.maven.shared.invoker.InvocationRequest}}*
>
> Currently *{{InvocationRequest}}* supports just the *{{-U}}* *mvn* option
> which is not enough: it's possible to force the snapshots update or keep
> default maven policy on this.
>
> But it's not possible to prevent snapshots updates which is highly desired
> under some circumstances (e.g. for CI reproducibility).
>
> NOTE: I may contribute a PR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSHARED-1382] support a possibility to disable snapshots update. [maven-invoker]
lrozenblyum commented on PR #74: URL: https://github.com/apache/maven-invoker/pull/74#issuecomment-2088460111 @slawekjaranowski thx I'll check it. `mvn verify` was green at my PC (and `mvn -Prun-its verify` which is suggested by README issues a warning about a not-existing profile). I'll check what is run in CI and simulate it locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-1382) Maven-invoker: support '--no-snapshot-updates'
[
https://issues.apache.org/jira/browse/MSHARED-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842632#comment-17842632
]
ASF GitHub Bot commented on MSHARED-1382:
-
slawekjaranowski commented on PR #74:
URL: https://github.com/apache/maven-invoker/pull/74#issuecomment-2088449184
@lrozenblyum - pleach check build result the same should be when you build
locally
> Maven-invoker: support '--no-snapshot-updates'
> --
>
> Key: MSHARED-1382
> URL: https://issues.apache.org/jira/browse/MSHARED-1382
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-invoker
>Affects Versions: maven-invoker-3.2.0
>Reporter: Leonid Rozenblyum
>Priority: Major
>
> Let's add support for *{{--no-snapshot-updates}}* in
> *{{org.apache.maven.shared.invoker.InvocationRequest}}*
>
> Currently *{{InvocationRequest}}* supports just the *{{-U}}* *mvn* option
> which is not enough: it's possible to force the snapshots update or keep
> default maven policy on this.
>
> But it's not possible to prevent snapshots updates which is highly desired
> under some circumstances (e.g. for CI reproducibility).
>
> NOTE: I may contribute a PR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSHARED-1382] support a possibility to disable snapshots update. [maven-invoker]
slawekjaranowski commented on PR #74: URL: https://github.com/apache/maven-invoker/pull/74#issuecomment-2088449184 @lrozenblyum - pleach check build result the same should be when you build locally -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-1382) Maven-invoker: support '--no-snapshot-updates'
[
https://issues.apache.org/jira/browse/MSHARED-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842629#comment-17842629
]
ASF GitHub Bot commented on MSHARED-1382:
-
slawekjaranowski commented on code in PR #74:
URL: https://github.com/apache/maven-invoker/pull/74#discussion_r1586278359
##
src/test/java/org/apache/maven/shared/invoker/MavenCommandLineBuilderTest.java:
##
@@ -299,6 +299,33 @@ public void testShouldSetUpdateSnapshotsFlagFromRequest() {
assertArgumentsPresent(cli, Collections.singleton("-U"));
}
+// JUnit5: test methods don't need to be public
Review Comment:
you can drop `public` modifier from other methods also
now on separate PR
> Maven-invoker: support '--no-snapshot-updates'
> --
>
> Key: MSHARED-1382
> URL: https://issues.apache.org/jira/browse/MSHARED-1382
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-invoker
>Affects Versions: maven-invoker-3.2.0
>Reporter: Leonid Rozenblyum
>Priority: Major
>
> Let's add support for *{{--no-snapshot-updates}}* in
> *{{org.apache.maven.shared.invoker.InvocationRequest}}*
>
> Currently *{{InvocationRequest}}* supports just the *{{-U}}* *mvn* option
> which is not enough: it's possible to force the snapshots update or keep
> default maven policy on this.
>
> But it's not possible to prevent snapshots updates which is highly desired
> under some circumstances (e.g. for CI reproducibility).
>
> NOTE: I may contribute a PR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSHARED-1382] support a possibility to disable snapshots update. [maven-invoker]
slawekjaranowski commented on code in PR #74:
URL: https://github.com/apache/maven-invoker/pull/74#discussion_r1586278359
##
src/test/java/org/apache/maven/shared/invoker/MavenCommandLineBuilderTest.java:
##
@@ -299,6 +299,33 @@ public void testShouldSetUpdateSnapshotsFlagFromRequest() {
assertArgumentsPresent(cli, Collections.singleton("-U"));
}
+// JUnit5: test methods don't need to be public
Review Comment:
you can drop `public` modifier from other methods also
now on separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MSHARED-1382) Maven-invoker: support '--no-snapshot-updates'
[
https://issues.apache.org/jira/browse/MSHARED-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842614#comment-17842614
]
ASF GitHub Bot commented on MSHARED-1382:
-
lrozenblyum opened a new pull request, #74:
URL: https://github.com/apache/maven-invoker/pull/74
Added a possibility to request Maven not to execute the snapshots updates.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
> Maven-invoker: support '--no-snapshot-updates'
> --
>
> Key: MSHARED-1382
> URL: https://issues.apache.org/jira/browse/MSHARED-1382
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-invoker
>Affects Versions: maven-invoker-3.2.0
>Reporter: Leonid Rozenblyum
>Priority: Major
>
> Let's add support for *{{--no-snapshot-updates}}* in
> *{{org.apache.maven.shared.invoker.InvocationRequest}}*
>
> Currently *{{InvocationRequest}}* supports just the *{{-U}}* *mvn* option
> which is not enough: it's possible to force the snapshots update or keep
> default maven policy on this.
>
> But it's not possible to prevent snapshots updates which is highly desired
> under some circumstances (e.g. for CI reproducibility).
>
> NOTE: I may contribute a PR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MINVOKER-335) Symlinks from source project are copied as file
[
https://issues.apache.org/jira/browse/MINVOKER-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842611#comment-17842611
]
ASF GitHub Bot commented on MINVOKER-335:
-
slawekjaranowski opened a new pull request, #231:
URL: https://github.com/apache/maven-invoker-plugin/pull/231
https://issues.apache.org/jira/browse/MINVOKER-335
> Symlinks from source project are copied as file
> ---
>
> Key: MINVOKER-335
> URL: https://issues.apache.org/jira/browse/MINVOKER-335
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Labels: up-for-grabs
> Fix For: 3.6.2
>
>
> Source project:
> {noformat}
> -rw-r--r-- 1 xxx 40 May 1 18:44 test.txt
> drwxr-xr-x 2 xxx 64 May 1 19:26 testDir
> lrwxr-xr-x 1 xxx 7 May 1 19:27 testDirLink -> testDir
> lrwxr-xr-x 1 xxx 8 May 1 19:29 testLink.txt -> test.txt
> {noformat}
> after copy in {{target/it/..}}
> {noformat}
> -rw-r--r-- 1 xxx 40 May 1 18:44 test.txt
> drwxr-xr-x 2 xxx 64 May 1 19:30 testDir
> lrwxr-xr-x 1 xxx 7 May 1 19:30 testDirLink -> testDir
> -rw-r--r-- 1 xxx 40 May 1 18:44 testLink.txt
> {noformat}
> symlinks for directory are preserved only symlinks for file are broken
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MINVOKER-335) Symlinks from source project are copied as file
[
https://issues.apache.org/jira/browse/MINVOKER-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski reassigned MINVOKER-335:
Assignee: Slawomir Jaranowski
> Symlinks from source project are copied as file
> ---
>
> Key: MINVOKER-335
> URL: https://issues.apache.org/jira/browse/MINVOKER-335
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Labels: up-for-grabs
> Fix For: 3.6.2
>
>
> Source project:
> {noformat}
> -rw-r--r-- 1 xxx 40 May 1 18:44 test.txt
> drwxr-xr-x 2 xxx 64 May 1 19:26 testDir
> lrwxr-xr-x 1 xxx 7 May 1 19:27 testDirLink -> testDir
> lrwxr-xr-x 1 xxx 8 May 1 19:29 testLink.txt -> test.txt
> {noformat}
> after copy in {{target/it/..}}
> {noformat}
> -rw-r--r-- 1 xxx 40 May 1 18:44 test.txt
> drwxr-xr-x 2 xxx 64 May 1 19:30 testDir
> lrwxr-xr-x 1 xxx 7 May 1 19:30 testDirLink -> testDir
> -rw-r--r-- 1 xxx 40 May 1 18:44 testLink.txt
> {noformat}
> symlinks for directory are preserved only symlinks for file are broken
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump org.apache.maven.plugins:maven-install-plugin from 3.1.1 to 3.1.2 [maven-apache-parent]
slawekjaranowski commented on PR #222: URL: https://github.com/apache/maven-apache-parent/pull/222#issuecomment-2088297990 @CrazyHZM thanks for merge, please remember to add milestone to merged PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump resolverVersion from 1.9.18 to 1.9.20 [maven-resolver-ant-tasks]
CrazyHZM merged PR #39: URL: https://github.com/apache/maven-resolver-ant-tasks/pull/39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump resolver.version from 1.9.18 to 1.9.20 [maven-indexer]
CrazyHZM merged PR #362: URL: https://github.com/apache/maven-indexer/pull/362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.plugins:maven-install-plugin from 3.1.1 to 3.1.2 [maven-apache-parent]
CrazyHZM merged PR #222: URL: https://github.com/apache/maven-apache-parent/pull/222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump commons-codec:commons-codec from 1.16.1 to 1.17.0 [maven-artifact-plugin]
CrazyHZM merged PR #41: URL: https://github.com/apache/maven-artifact-plugin/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump resolverVersion from 1.9.18 to 1.9.20 [maven-artifact-plugin]
CrazyHZM commented on PR #42: URL: https://github.com/apache/maven-artifact-plugin/pull/42#issuecomment-2088253733 @dependabot close -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump resolverVersion from 1.9.18 to 1.9.20 [maven-artifact-plugin]
dependabot[bot] closed pull request #42: Bump resolverVersion from 1.9.18 to 1.9.20 URL: https://github.com/apache/maven-artifact-plugin/pull/42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-8113) Inconsistent way of overriding core components from extensions
Tamas Cservenak created MNG-8113:
Summary: Inconsistent way of overriding core components from
extensions
Key: MNG-8113
URL: https://issues.apache.org/jira/browse/MNG-8113
Project: Maven
Issue Type: Bug
Components: Core
Reporter: Tamas Cservenak
Problem: "let's have a (core) extension that is overriding some component X in
Maven Core".
Doing this is very inconsistent, and depends HOW core component is defined in
the first place.
IF core component is JSR330, then is simple: just define an own JSR330
component (w/ some higher than zero Priority) and done. This can be loaded from
{{.mvn/extensions.xml}} just fine.
IF core component is Plexus, then is not simple:
* using JSR330 – could not do it
* using Plexus annotation + XML – does not works when JAR is in
{{.mvn/extensions.xml}} !
* using Plexus annotation + XML – works only when using
{{-Dmaven.ext.class.path}} w/ JAR enlisted here.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MARTIFACT-66) Upgrade maven resolver version 1.9.18 to 1.9.20
[ https://issues.apache.org/jira/browse/MARTIFACT-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated MARTIFACT-66: Labels: pull-request-available (was: ) > Upgrade maven resolver version 1.9.18 to 1.9.20 > --- > > Key: MARTIFACT-66 > URL: https://issues.apache.org/jira/browse/MARTIFACT-66 > Project: Maven Artifact Plugin > Issue Type: Task >Reporter: Zhongming Hua >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MARTIFACT-66) Upgrade maven resolver version 1.9.18 to 1.9.20
[ https://issues.apache.org/jira/browse/MARTIFACT-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842599#comment-17842599 ] ASF GitHub Bot commented on MARTIFACT-66: - CrazyHZM opened a new pull request, #43: URL: https://github.com/apache/maven-artifact-plugin/pull/43 (no comment) > Upgrade maven resolver version 1.9.18 to 1.9.20 > --- > > Key: MARTIFACT-66 > URL: https://issues.apache.org/jira/browse/MARTIFACT-66 > Project: Maven Artifact Plugin > Issue Type: Task >Reporter: Zhongming Hua >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MINVOKER-362) Use properties from parent for plugins versions in ITs
[ https://issues.apache.org/jira/browse/MINVOKER-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MINVOKER-362. Resolution: Fixed > Use properties from parent for plugins versions in ITs > -- > > Key: MINVOKER-362 > URL: https://issues.apache.org/jira/browse/MINVOKER-362 > Project: Maven Invoker Plugin > Issue Type: Task >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.6.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump org.mockito:mockito-junit-jupiter from 4.11.0 to 5.11.0 [maven-invoker-plugin]
dependabot[bot] commented on PR #230: URL: https://github.com/apache/maven-invoker-plugin/pull/230#issuecomment-2088248602 OK, I won't notify you about version 5.x.x again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.mockito:mockito-junit-jupiter from 4.11.0 to 5.11.0 [maven-invoker-plugin]
dependabot[bot] closed pull request #230: Bump org.mockito:mockito-junit-jupiter from 4.11.0 to 5.11.0 URL: https://github.com/apache/maven-invoker-plugin/pull/230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.mockito:mockito-junit-jupiter from 4.11.0 to 5.11.0 [maven-invoker-plugin]
slawekjaranowski commented on PR #230: URL: https://github.com/apache/maven-invoker-plugin/pull/230#issuecomment-2088248550 @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MINVOKER-362) Use properties from parent for plugins versions in ITs
[ https://issues.apache.org/jira/browse/MINVOKER-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842598#comment-17842598 ] ASF GitHub Bot commented on MINVOKER-362: - slawekjaranowski merged PR #229: URL: https://github.com/apache/maven-invoker-plugin/pull/229 > Use properties from parent for plugins versions in ITs > -- > > Key: MINVOKER-362 > URL: https://issues.apache.org/jira/browse/MINVOKER-362 > Project: Maven Invoker Plugin > Issue Type: Task >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.6.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MINVOKER-362] Use properties from parent for plugins versions in ITs [maven-invoker-plugin]
slawekjaranowski merged PR #229: URL: https://github.com/apache/maven-invoker-plugin/pull/229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MARTIFACT-66) Upgrade maven resolver version 1.9.18 to 1.9.20
Zhongming Hua created MARTIFACT-66: -- Summary: Upgrade maven resolver version 1.9.18 to 1.9.20 Key: MARTIFACT-66 URL: https://issues.apache.org/jira/browse/MARTIFACT-66 Project: Maven Artifact Plugin Issue Type: Task Reporter: Zhongming Hua -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSITE-1000) Allow parametrisation of Doxia parser per file
[
https://issues.apache.org/jira/browse/MSITE-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842597#comment-17842597
]
ASF GitHub Bot commented on MSITE-1000:
---
michael-o commented on PR #177:
URL:
https://github.com/apache/maven-site-plugin/pull/177#issuecomment-2088245135
It also fails with: `Error generating
maven-plugin-report-plugin:3.12.0:report report:`
> Allow parametrisation of Doxia parser per file
> --
>
> Key: MSITE-1000
> URL: https://issues.apache.org/jira/browse/MSITE-1000
> Project: Maven Site Plugin
> Issue Type: New Feature
> Components: doxia integration
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently only the attributes used for rendering the site can be
> parameterized in
> https://maven.apache.org/plugins/maven-site-plugin/site-mojo.html#attributes.
> There is no possibility to configure the parser in
> https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L322
> per document.
> This would be nice in the context of
> https://issues.apache.org/jira/browse/DOXIA-722 where generation of anchors
> should be switched on/off for certain documents. Also generation of comments
> may be desirable for certain documents.
> I propose the following additional plugin goal parameter:
> {code}
>
>
>
> **/apt/**
>
> false
> true
>
>
> {code}
> where {{parserConfigurations}} is an array of a complex type with (include)
> patterns on the source path (String array) and boolean methods for features.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSITE-1000] Introduce parser configuration parameter [maven-site-plugin]
michael-o commented on PR #177: URL: https://github.com/apache/maven-site-plugin/pull/177#issuecomment-2088245135 It also fails with: `Error generating maven-plugin-report-plugin:3.12.0:report report:` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.resolver:maven-resolver-api from 1.9.18 to 1.9.20 [maven-wrapper]
CrazyHZM merged PR #136: URL: https://github.com/apache/maven-wrapper/pull/136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-86) Bugfix and enhancements with the restoration of outputs on disk
[ https://issues.apache.org/jira/browse/MBUILDCACHE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842589#comment-17842589 ] ASF GitHub Bot commented on MBUILDCACHE-86: --- martincekodhima commented on PR #104: URL: https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2088170053 Thanks everyone! > Bugfix and enhancements with the restoration of outputs on disk > --- > > Key: MBUILDCACHE-86 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-86 > Project: Maven Build Cache Extension > Issue Type: Improvement >Reporter: Kevin Buntrock >Assignee: Olivier Lamy >Priority: Major > Labels: pull-request-available > Fix For: 1.2.0 > > > *Fixes :* > * Files containing an underscore in their name can't be restored in the > cache directory correctly (not in the same directory location). > * The cache is able to extract/restore files in locations outside the > project. I guess the extraction part is not a vulnerability since someone > with commit permissions can guess other ways to extract data. But the > possibility of restoring at any place on the disk looks pretty dangerous to > me if a remote cache server is compromised. > *Enhancements :* > * Possibility to restore artefacts on disk, with a dedicated property : > maven.build.cache.restoreOnDiskArtefacts (default to true). Meaning in the > project directory, as opposed to the cache directory. > ** IDE integration and use of the cache locally in developement is way > easier. It is now possible to retrieve a cached jar in the "target" directory. > * Introduce "globs" to filter extra attached outputs by filenames. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MBUILDCACHE-86] bugfix / enhancements restoration of outputs on disk [maven-build-cache-extension]
martincekodhima commented on PR #104: URL: https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2088170053 Thanks everyone! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSKINS-245) Maven Site 4 will break code highlight of site generated by Markdown
[ https://issues.apache.org/jira/browse/MSKINS-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842581#comment-17842581 ] ASF GitHub Bot commented on MSKINS-245: --- michael-o commented on code in PR #58: URL: https://github.com/apache/maven-fluido-skin/pull/58#discussion_r1586012833 ## src/main/resources/META-INF/maven/site.vm: ## @@ -239,7 +239,7 @@ #**##set( $sourceStyle = "prettyprint" ) #* *##end ## -#* *#$bodyContent.replaceAll( '(\r?\n)?', '' ).replaceAll( 'class="bodyTable"', 'class="table table-striped"' ).replaceAll( 'class="bodyTable bodyTableBorder"', 'class="table table-bordered table-striped"' ) +#* *#$bodyContent.replaceAll( '', '' ).replaceAll( 'class="bodyTable"', 'class="table table-striped"' ).replaceAll( 'class="bodyTable bodyTableBorder"', 'class="table table-bordered table-striped"' ) Review Comment: Since we don't need regex anymore, we can resort to just `replace()` here. > Maven Site 4 will break code highlight of site generated by Markdown > > > Key: MSKINS-245 > URL: https://issues.apache.org/jira/browse/MSKINS-245 > Project: Maven Skins > Issue Type: Bug > Components: Fluido Skin >Reporter: Xavi Lee >Assignee: Konrad Windszus >Priority: Major > Fix For: fluido-2.0.0-M9, fluido-2.0.0 > > Attachments: maven-site-3.png, maven-site-4.png, test-v3.html, > test-v4.html > > > repro repo https://github.com/awxiaoxian2020/code-render-bug > master branch is Maven Site 3 with Fluido skin 1 > v4 branch is Maven Site 4 with Fluido skin 2. > Open their respective `target/site/test.html` files in local to see the > rendered result. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MSKINS-245] Add code highlighting class to every combination [maven-fluido-skin]
michael-o commented on code in PR #58: URL: https://github.com/apache/maven-fluido-skin/pull/58#discussion_r1586012833 ## src/main/resources/META-INF/maven/site.vm: ## @@ -239,7 +239,7 @@ #**##set( $sourceStyle = "prettyprint" ) #* *##end ## -#* *#$bodyContent.replaceAll( '(\r?\n)?', '' ).replaceAll( 'class="bodyTable"', 'class="table table-striped"' ).replaceAll( 'class="bodyTable bodyTableBorder"', 'class="table table-bordered table-striped"' ) +#* *#$bodyContent.replaceAll( '', '' ).replaceAll( 'class="bodyTable"', 'class="table table-striped"' ).replaceAll( 'class="bodyTable bodyTableBorder"', 'class="table table-bordered table-striped"' ) Review Comment: Since we don't need regex anymore, we can resort to just `replace()` here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSITE-1000) Allow parametrisation of Doxia parser per file
[
https://issues.apache.org/jira/browse/MSITE-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842573#comment-17842573
]
ASF GitHub Bot commented on MSITE-1000:
---
michael-o commented on code in PR #177:
URL: https://github.com/apache/maven-site-plugin/pull/177#discussion_r1585980633
##
src/main/java/org/apache/maven/plugins/site/render/ParserConfiguratorImpl.java:
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.site.render;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.nio.file.FileSystem;
+import java.nio.file.FileSystems;
+import java.nio.file.Path;
+import java.nio.file.PathMatcher;
+import java.util.Collection;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.stream.Collectors;
+
+import org.apache.maven.doxia.parser.Parser;
+import org.apache.maven.doxia.siterenderer.ParserConfigurator;
+import org.apache.maven.plugin.descriptor.MojoDescriptor;
+import org.codehaus.plexus.PlexusContainer;
+import
org.codehaus.plexus.component.configurator.ComponentConfigurationException;
+import org.codehaus.plexus.component.configurator.ComponentConfigurator;
+import
org.codehaus.plexus.component.repository.exception.ComponentLifecycleException;
+import
org.codehaus.plexus.component.repository.exception.ComponentLookupException;
+import org.codehaus.plexus.configuration.PlexusConfiguration;
+
+/**
+ * Configures a parser based on a {@link PlexusConfiguration} for a particular
parser id and optionally matching one of multiple patterns.
+ * It internally leverages the {@link ComponentConfigurator} for calling the
right methods inside the parser implementation.
+ */
+public class ParserConfiguratorImpl implements ParserConfigurator, Closeable {
+
+private static final class ParserConfigurationKey {
+
+ParserConfigurationKey(String parserId, PlexusConfiguration
patternsConfiguration) {
+this(parserId,
PlexusConfigurationUtils.getStringArrayValues(patternsConfiguration));
+}
+
+ParserConfigurationKey(String parserId, Collection patterns) {
+this.parserId = parserId;
+// lazily populate all matchers
+matchers = patterns.stream()
+.map(p -> FileSystems.getDefault().getPathMatcher(p))
+.collect(Collectors.toList());
Review Comment:
I am fine with that.
> Allow parametrisation of Doxia parser per file
> --
>
> Key: MSITE-1000
> URL: https://issues.apache.org/jira/browse/MSITE-1000
> Project: Maven Site Plugin
> Issue Type: New Feature
> Components: doxia integration
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently only the attributes used for rendering the site can be
> parameterized in
> https://maven.apache.org/plugins/maven-site-plugin/site-mojo.html#attributes.
> There is no possibility to configure the parser in
> https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L322
> per document.
> This would be nice in the context of
> https://issues.apache.org/jira/browse/DOXIA-722 where generation of anchors
> should be switched on/off for certain documents. Also generation of comments
> may be desirable for certain documents.
> I propose the following additional plugin goal parameter:
> {code}
>
>
>
> **/apt/**
>
> false
> true
>
>
> {code}
> where {{parserConfigurations}} is an array of a complex type with (include)
> patterns on the source path (String array) and boolean methods for features.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSITE-1000] Introduce parser configuration parameter [maven-site-plugin]
michael-o commented on code in PR #177:
URL: https://github.com/apache/maven-site-plugin/pull/177#discussion_r1585980633
##
src/main/java/org/apache/maven/plugins/site/render/ParserConfiguratorImpl.java:
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.site.render;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.nio.file.FileSystem;
+import java.nio.file.FileSystems;
+import java.nio.file.Path;
+import java.nio.file.PathMatcher;
+import java.util.Collection;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.stream.Collectors;
+
+import org.apache.maven.doxia.parser.Parser;
+import org.apache.maven.doxia.siterenderer.ParserConfigurator;
+import org.apache.maven.plugin.descriptor.MojoDescriptor;
+import org.codehaus.plexus.PlexusContainer;
+import
org.codehaus.plexus.component.configurator.ComponentConfigurationException;
+import org.codehaus.plexus.component.configurator.ComponentConfigurator;
+import
org.codehaus.plexus.component.repository.exception.ComponentLifecycleException;
+import
org.codehaus.plexus.component.repository.exception.ComponentLookupException;
+import org.codehaus.plexus.configuration.PlexusConfiguration;
+
+/**
+ * Configures a parser based on a {@link PlexusConfiguration} for a particular
parser id and optionally matching one of multiple patterns.
+ * It internally leverages the {@link ComponentConfigurator} for calling the
right methods inside the parser implementation.
+ */
+public class ParserConfiguratorImpl implements ParserConfigurator, Closeable {
+
+private static final class ParserConfigurationKey {
+
+ParserConfigurationKey(String parserId, PlexusConfiguration
patternsConfiguration) {
+this(parserId,
PlexusConfigurationUtils.getStringArrayValues(patternsConfiguration));
+}
+
+ParserConfigurationKey(String parserId, Collection patterns) {
+this.parserId = parserId;
+// lazily populate all matchers
+matchers = patterns.stream()
+.map(p -> FileSystems.getDefault().getPathMatcher(p))
+.collect(Collectors.toList());
Review Comment:
I am fine with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MRESOLVER-554) Support configuration of upload/download threads individually
[
https://issues.apache.org/jira/browse/MRESOLVER-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842564#comment-17842564
]
ASF GitHub Bot commented on MRESOLVER-554:
--
michael-o commented on code in PR #489:
URL: https://github.com/apache/maven-resolver/pull/489#discussion_r1585969952
##
maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java:
##
@@ -97,15 +100,17 @@ final class BasicRepositoryConnector implements
RepositoryConnector {
private final ChecksumPolicyProvider checksumPolicyProvider;
-private final int maxThreads;
+private final int maxDownstreamThreads;
+
+private final int maxUpstreamThreads;
private final boolean smartChecksums;
private final boolean parallelPut;
private final boolean persistedChecksums;
-private Executor executor;
+private final ConcurrentHashMap executors;
Review Comment:
Just a remark. An Enum would read better than just a boolean...
> Support configuration of upload/download threads individually
> -
>
> Key: MRESOLVER-554
> URL: https://issues.apache.org/jira/browse/MRESOLVER-554
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
>Reporter: Matt Nelson
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-beta-1
>
>
> Parallel deploys were introduced in MRESOLVER-32. The thread pool
> configuration is shared for uploads and downloads. It has been observed in
> our environment that uploads frequently error out when attempting to upload
> with the default thread pool size(5), but conversely we don't see the same
> errors for downloads.
> The proposal is to support configuration of upload/download thread pools
> individually.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MRESOLVER-554] Split thread counts for up and downstream ops [maven-resolver]
michael-o commented on code in PR #489:
URL: https://github.com/apache/maven-resolver/pull/489#discussion_r1585969952
##
maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java:
##
@@ -97,15 +100,17 @@ final class BasicRepositoryConnector implements
RepositoryConnector {
private final ChecksumPolicyProvider checksumPolicyProvider;
-private final int maxThreads;
+private final int maxDownstreamThreads;
+
+private final int maxUpstreamThreads;
private final boolean smartChecksums;
private final boolean parallelPut;
private final boolean persistedChecksums;
-private Executor executor;
+private final ConcurrentHashMap executors;
Review Comment:
Just a remark. An Enum would read better than just a boolean...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
