[GitHub] [maven-compiler-plugin] cstamas commented on pull request #151: Move away from legacy maven-compat

2023-01-18 Thread GitBox
cstamas commented on PR #151: URL: https://github.com/apache/maven-compiler-plugin/pull/151#issuecomment-1396571932 Am fine if anyone (@psiroky ?) picks up these changes and continue with them (as there is no need for else branch for example), no need for any attribution, just go on with

[GitHub] [maven-resolver] cstamas commented on pull request #230: MRESOLVER-307 - Support listing of workspace artifacts

2023-01-18 Thread GitBox
cstamas commented on PR #230: URL: https://github.com/apache/maven-resolver/pull/230#issuecomment-1396567377 After reconsidering this change, I am -1 on it (now or 2.x), reasons: * I see no point of adding new methods to resolver interface that resolver itself is NOT going to use *

[GitHub] [maven] cstamas commented on pull request #913: MNG-7630 - Support listing of workspace models

2023-01-18 Thread GitBox
cstamas commented on PR #913: URL: https://github.com/apache/maven/pull/913#issuecomment-1396562822 pls rebase against latest maven-3.9.x branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven] cstamas commented on pull request #913: MNG-7630 - Support listing of workspace models

2023-01-18 Thread GitBox
cstamas commented on PR #913: URL: https://github.com/apache/maven/pull/913#issuecomment-1396560239 Am fine with this go into 3.9 and not impose any change in resolver, and here is why: * there is already this MavenWorkspaceReader that already extends resolver WorkspaceReader by adding

[GitHub] [maven-compiler-plugin] psiroky commented on pull request #151: Move away from legacy maven-compat

2023-01-18 Thread GitBox
psiroky commented on PR #151: URL: https://github.com/apache/maven-compiler-plugin/pull/151#issuecomment-1396108191 @cstamas @laeubi Hello! It would be great to get this one merged. Is there anything I can help with? It seems like getting rid of `AbstractMojoTestCase` might be

[GitHub] [maven-compiler-plugin] psiroky commented on a diff in pull request #151: Move away from legacy maven-compat

2023-01-18 Thread GitBox
psiroky commented on code in PR #151: URL: https://github.com/apache/maven-compiler-plugin/pull/151#discussion_r1080568677 ## src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java: ## @@ -1841,29 +1838,36 @@ private List resolveProcessorPathEntries()

[GitHub] [maven-archetypes] slawekjaranowski merged pull request #6: [MARCHETYPES-75] Bump web archetype deployment descriptor to v4, portlet to v3

2023-01-18 Thread GitBox
slawekjaranowski merged PR #6: URL: https://github.com/apache/maven-archetypes/pull/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-enforcer] slawekjaranowski opened a new pull request, #237: [MENFORCER-460] Deprecate display-info mojo

2023-01-18 Thread GitBox
slawekjaranowski opened a new pull request, #237: URL: https://github.com/apache/maven-enforcer/pull/237 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER)

[GitHub] [maven-enforcer] slawekjaranowski merged pull request #235: [MENFORCER-457] Bump assertj-core from 3.24.1 to 3.24.2

2023-01-18 Thread GitBox
slawekjaranowski merged PR #235: URL: https://github.com/apache/maven-enforcer/pull/235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-compiler-plugin] ajarmoniuk commented on pull request #151: Move away from legacy maven-compat

2023-01-18 Thread GitBox
ajarmoniuk commented on PR #151: URL: https://github.com/apache/maven-compiler-plugin/pull/151#issuecomment-1387479684 Hey, I can do that! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven] gnodet commented on a diff in pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-18 Thread GitBox
gnodet commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r1073764622 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -324,4 +273,185 @@ private static boolean isTestArtifact(Artifact artifact) { return

[GitHub] [maven] gnodet commented on a diff in pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-18 Thread GitBox
gnodet commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r1073701518 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -324,4 +273,185 @@ private static boolean isTestArtifact(Artifact artifact) { return

[GitHub] [maven] cstamas commented on a diff in pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-18 Thread GitBox
cstamas commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r1073687908 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -324,4 +273,185 @@ private static boolean isTestArtifact(Artifact artifact) { return

[GitHub] [maven] gnodet commented on a diff in pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-18 Thread GitBox
gnodet commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r1073679949 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -324,4 +273,185 @@ private static boolean isTestArtifact(Artifact artifact) { return

[GitHub] [maven] cstamas commented on a diff in pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-18 Thread GitBox
cstamas commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r1073675245 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -324,4 +273,185 @@ private static boolean isTestArtifact(Artifact artifact) { return

[GitHub] [maven] cstamas commented on a diff in pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-18 Thread GitBox
cstamas commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r1073670208 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -324,4 +273,185 @@ private static boolean isTestArtifact(Artifact artifact) { return

[GitHub] [maven-mvnd] gzm55 commented on a diff in pull request #717: Try native image then fallback to pure java version

2023-01-18 Thread GitBox
gzm55 commented on code in PR #717: URL: https://github.com/apache/maven-mvnd/pull/717#discussion_r1073667250 ## dist/src/main/provisio/maven-distro.xml: ## @@ -97,6 +97,7 @@ mvnd mvnd.exe + Review Comment: the flag file is used

[GitHub] [maven] gnodet commented on a diff in pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-18 Thread GitBox
gnodet commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r107336 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -324,4 +273,185 @@ private static boolean isTestArtifact(Artifact artifact) { return

[GitHub] [maven-mvnd] gnodet commented on issue #770: Threads parameter is not working on Apple Silicon

2023-01-18 Thread GitBox
gnodet commented on issue #770: URL: https://github.com/apache/maven-mvnd/issues/770#issuecomment-1387225150 Can you reproduce the issue ? Are you sure you don't have the `mvnd.threads` property set in [one of the configuration file](https://github.com/apache/maven-mvnd#configuration) ?

[GitHub] [maven] cstamas commented on a diff in pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-18 Thread GitBox
cstamas commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r1073658196 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -324,4 +273,185 @@ private static boolean isTestArtifact(Artifact artifact) { return

[GitHub] [maven] cstamas commented on a diff in pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-18 Thread GitBox
cstamas commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r1073654940 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -324,4 +273,185 @@ private static boolean isTestArtifact(Artifact artifact) { return

[GitHub] [maven] cstamas commented on a diff in pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-18 Thread GitBox
cstamas commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r1073654940 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -324,4 +273,185 @@ private static boolean isTestArtifact(Artifact artifact) { return

[GitHub] [maven-mvnd] gnodet closed issue #762: Support for Maven 3.8.7?

2023-01-18 Thread GitBox
gnodet closed issue #762: Support for Maven 3.8.7? URL: https://github.com/apache/maven-mvnd/issues/762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven] gnodet commented on pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-18 Thread GitBox
gnodet commented on PR #954: URL: https://github.com/apache/maven/pull/954#issuecomment-1387205641 In the internal project local repository structure, I've added a child directory with the version of a given artifact. This gives a structure which is closer to the maven local repository,

[GitHub] [maven-mvnd] gnodet commented on a diff in pull request #717: Try native image then fallback to pure java version

2023-01-18 Thread GitBox
gnodet commented on code in PR #717: URL: https://github.com/apache/maven-mvnd/pull/717#discussion_r1073627453 ## dist/src/main/provisio/maven-distro.xml: ## @@ -97,6 +97,7 @@ mvnd mvnd.exe + Review Comment: What is the purpose of

[GitHub] [maven-integration-testing] gnodet closed pull request #219: [MNG-7629] Add an IT

2023-01-18 Thread GitBox
gnodet closed pull request #219: [MNG-7629] Add an IT URL: https://github.com/apache/maven-integration-testing/pull/219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [maven] gnodet commented on pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-18 Thread GitBox
gnodet commented on PR #954: URL: https://github.com/apache/maven/pull/954#issuecomment-1387156322 > > > ... in order to be able to partially run mvn test. > > > > > > I'm not sure I understand. You mean "run `mvn test` on a multi-module project without requiring the user to have

[GitHub] [maven] gnodet commented on a diff in pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-18 Thread GitBox
gnodet commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r1073602143 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -117,18 +105,19 @@ public File findArtifact(Artifact artifact) { } public List

[GitHub] [maven] gnodet commented on a diff in pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-18 Thread GitBox
gnodet commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r1073601881 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -324,4 +309,130 @@ private static boolean isTestArtifact(Artifact artifact) { return

[GitHub] [maven-mvnd] ppalaga commented on pull request #764: Fix core export provider

2023-01-18 Thread GitBox
ppalaga commented on PR #764: URL: https://github.com/apache/maven-mvnd/pull/764#issuecomment-1386681460 @oehme, BTW if you now send some dummy PR, it will publish the distribution zips for 3 (of 4, excl. Apple M1) supported platforms under Checks > Artifacts. You could perhaps use those

[GitHub] [maven] hboutemy commented on pull request #949: [MNG-7664] consolidate Velocity templates used to generate code from models

2023-01-17 Thread GitBox
hboutemy commented on PR #949: URL: https://github.com/apache/maven/pull/949#issuecomment-1386603257 done: I'm now happy with the result: - `.mdo` files stay at their original location, reuse from the 3 api-oriented ones is done without attach but direct access - `.vm` files are used

[GitHub] [maven] MartinKanters commented on a diff in pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-17 Thread GitBox
MartinKanters commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r1073152217 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -324,4 +309,130 @@ private static boolean isTestArtifact(Artifact artifact) { return

[GitHub] [maven-mvnd] gnodet opened a new pull request, #776: Upgrade dependencies to latest version

2023-01-17 Thread GitBox
gnodet opened a new pull request, #776: URL: https://github.com/apache/maven-mvnd/pull/776 - Upgrade maven wrapper to 3.1.1 and latest maven - Upgrade maven resolver to 1.9.4 - Upgrade dependencies -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven-integration-testing] gnodet commented on a diff in pull request #234: MNG-7629

2023-01-17 Thread GitBox
gnodet commented on code in PR #234: URL: https://github.com/apache/maven-integration-testing/pull/234#discussion_r1072876317 ## core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3043BestEffortReactorResolutionTest.java: ## @@ -25,6 +25,7 @@ import java.io.File;

[GitHub] [maven] gnodet commented on pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-17 Thread GitBox
gnodet commented on PR #954: URL: https://github.com/apache/maven/pull/954#issuecomment-1386130672 > > ... in order to be able to partially run mvn test. > > I'm not sure I understand. You mean "run `mvn test` on a multi-module project without requiring the user to have ran `mvn

[GitHub] [maven-fluido-skin] michael-o opened a new pull request, #45: [MSKINS-101] Remove decorationModel/custom/publishDate from skin-macr…

2023-01-17 Thread GitBox
michael-o opened a new pull request, #45: URL: https://github.com/apache/maven-fluido-skin/pull/45 …os.vm This can fully be replaced with MSITE-921. IF this custom value should be retained, I'd recommend to evaluate it *before* `$customDate` otherwise in reproducible builds it will

[GitHub] [maven-enforcer] slawekjaranowski opened a new pull request, #236: [MENFORCER-458] Move Build-in rules to new API

2023-01-17 Thread GitBox
slawekjaranowski opened a new pull request, #236: URL: https://github.com/apache/maven-enforcer/pull/236 Moved rules: - bannedDependencies - banTransitiveDependencies - dependencyConvergence - requireReleaseDeps - requireUpperBoundDeps --- Following this

[GitHub] [maven-site-plugin] asfgit merged pull request #122: [MSITE-220] site:run mojo will not display Javadoc or JXR report results

2023-01-17 Thread GitBox
asfgit merged PR #122: URL: https://github.com/apache/maven-site-plugin/pull/122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-site-plugin] asfgit merged pull request #121: [MSITE-920] Remove Maven 2 compat code

2023-01-17 Thread GitBox
asfgit merged PR #121: URL: https://github.com/apache/maven-site-plugin/pull/121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven] mthmulders commented on pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-17 Thread GitBox
mthmulders commented on PR #954: URL: https://github.com/apache/maven/pull/954#issuecomment-1385937080 > ... in order to be able to partially run mvn test. I'm not sure I understand. You mean "run `mvn test` on a multi-module project without requiring the user to have ran `mvn

[GitHub] [maven-enforcer] slawekjaranowski merged pull request #233: [MENFORCER-458] Move Build-in rules to new API

2023-01-17 Thread GitBox
slawekjaranowski merged PR #233: URL: https://github.com/apache/maven-enforcer/pull/233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-integration-testing] mthmulders commented on a diff in pull request #234: MNG-7629

2023-01-17 Thread GitBox
mthmulders commented on code in PR #234: URL: https://github.com/apache/maven-integration-testing/pull/234#discussion_r1072692671 ## core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3043BestEffortReactorResolutionTest.java: ## @@ -25,6 +25,7 @@ import java.io.File;

[GitHub] [maven] mthmulders commented on a diff in pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-17 Thread GitBox
mthmulders commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r1072684739 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -324,4 +300,113 @@ private static boolean isTestArtifact(Artifact artifact) { return

[GitHub] [maven] slawekjaranowski merged pull request #960: Execute IT tests with clean local repository

2023-01-17 Thread GitBox
slawekjaranowski merged PR #960: URL: https://github.com/apache/maven/pull/960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-mvnd] gnodet merged pull request #775: Upgrade jline to 3.22.0

2023-01-17 Thread GitBox
gnodet merged PR #775: URL: https://github.com/apache/maven-mvnd/pull/775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-enforcer] dependabot[bot] opened a new pull request, #235: Bump assertj-core from 3.24.1 to 3.24.2

2023-01-17 Thread GitBox
dependabot[bot] opened a new pull request, #235: URL: https://github.com/apache/maven-enforcer/pull/235 Bumps assertj-core from 3.24.1 to 3.24.2. [![Dependabot compatibility

[GitHub] [maven-mvnd] ppalaga merged pull request #774: Publish the binaries produced by the Early Access job again

2023-01-17 Thread GitBox
ppalaga merged PR #774: URL: https://github.com/apache/maven-mvnd/pull/774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven] gnodet closed pull request #962: [MNG-7646] Do not parse all projects in the reactor when building a subtree

2023-01-17 Thread GitBox
gnodet closed pull request #962: [MNG-7646] Do not parse all projects in the reactor when building a subtree URL: https://github.com/apache/maven/pull/962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [maven] gnodet commented on pull request #962: [MNG-7646] Do not parse all projects in the reactor when building a subtree

2023-01-17 Thread GitBox
gnodet commented on PR #962: URL: https://github.com/apache/maven/pull/962#issuecomment-1385486839 Wrong PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [maven] gnodet opened a new pull request, #963: [MNG-7646] Do not parse all projects in the reactor when building a subtree

2023-01-17 Thread GitBox
gnodet opened a new pull request, #963: URL: https://github.com/apache/maven/pull/963 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the

[GitHub] [maven] gnodet opened a new pull request, #962: [MNG-7646] Do not parse all projects in the reactor when building a subtree"

2023-01-17 Thread GitBox
gnodet opened a new pull request, #962: URL: https://github.com/apache/maven/pull/962 - [MNG-7642] Restore compatibility with flatten-maven-plugin - Add some comment about deprecation and remove the unused field - [MNG-7652] switch to Modello Velocity (#944) - [MNG-7642] Explicit

[GitHub] [maven] gnodet commented on a diff in pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-17 Thread GitBox
gnodet commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r1072176566 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -237,21 +223,11 @@ private boolean isPackagedArtifactUpToDate(MavenProject project, File packagedAr

[GitHub] [maven-mvnd] gnodet merged pull request #764: Fix core export provider

2023-01-17 Thread GitBox
gnodet merged PR #764: URL: https://github.com/apache/maven-mvnd/pull/764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-mvnd] ppalaga commented on pull request #764: Fix core export provider

2023-01-17 Thread GitBox
ppalaga commented on PR #764: URL: https://github.com/apache/maven-mvnd/pull/764#issuecomment-1385154223 Here is a fix for GH Actions not publishing the PR's binaries https://github.com/apache/maven-mvnd/pull/774 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [maven-mvnd] gnodet commented on pull request #764: Fix core export provider

2023-01-17 Thread GitBox
gnodet commented on PR #764: URL: https://github.com/apache/maven-mvnd/pull/764#issuecomment-1385151917 > Would it be possible to get an m2 for this? I'd love to run our extensions full CI build against this to make sure we work properly when 1.0 comes out. Yes, though I'd like to

[GitHub] [maven] laeubi commented on pull request #913: MNG-7630 - Support listing of workspace models

2023-01-17 Thread GitBox
laeubi commented on PR #913: URL: https://github.com/apache/maven/pull/913#issuecomment-1385135621 @cstamas @olamy can we include this in 3.9.0 release? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [maven-mvnd] ppalaga commented on pull request #764: Fix core export provider

2023-01-17 Thread GitBox
ppalaga commented on PR #764: URL: https://github.com/apache/maven-mvnd/pull/764#issuecomment-1385134715 We actually used to publish the binaries produced by the given PR's CI run via Checks -> Artifacts

[GitHub] [maven] laeubi commented on pull request #950: [MNG-7662] Use proxies for session scoped beans

2023-01-17 Thread GitBox
laeubi commented on PR #950: URL: https://github.com/apache/maven/pull/950#issuecomment-1385133727 @gnodet @cstamas @rmannibucau It would be great to finish this before 3.9.0 release! Seems a good opportunity for a minor release increment! -- This is an automated message from the Apache

[GitHub] [maven-mvnd] oehme commented on pull request #764: Fix core export provider

2023-01-17 Thread GitBox
oehme commented on PR #764: URL: https://github.com/apache/maven-mvnd/pull/764#issuecomment-1385112808 Would it be possible to get an m2 for this? I'd love to run our extensions full CI build against this to make sure we work properly when 1.0 comes out. -- This is an automated message

[GitHub] [maven-mvnd] oehme commented on pull request #764: Fix core export provider

2023-01-17 Thread GitBox
oehme commented on PR #764: URL: https://github.com/apache/maven-mvnd/pull/764#issuecomment-1385098837 @ppalaga this should be good to go :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven] cstamas merged pull request #961: [3.9.x][MNG-7608] Make native transport the default

2023-01-17 Thread GitBox
cstamas merged PR #961: URL: https://github.com/apache/maven/pull/961 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-integration-testing] cstamas merged pull request #237: [MNG-7608] Adjust IT for default transport

2023-01-17 Thread GitBox
cstamas merged PR #237: URL: https://github.com/apache/maven-integration-testing/pull/237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven] hboutemy commented on pull request #949: [MNG-7664] consolidate Velocity templates used to generate code from models

2023-01-17 Thread GitBox
hboutemy commented on PR #949: URL: https://github.com/apache/maven/pull/949#issuecomment-138421 thinking again at Modello Velocity Plugin, instead of magically reusing existing `basedir` parameter, probably creating a new dedicated `velocityBasedir` directory could make things more

[GitHub] [maven] hboutemy commented on a diff in pull request #949: [MNG-7664] consolidate Velocity templates used to generate code from models

2023-01-17 Thread GitBox
hboutemy commented on code in PR #949: URL: https://github.com/apache/maven/pull/949#discussion_r1071880277 ## maven-plugin-api/pom.xml: ## @@ -92,6 +94,7 @@ under the License. pre-site + ${basedir} Review Comment: given

[GitHub] [maven-integration-testing] cstamas commented on a diff in pull request #237: [MNG-7608] Adjust IT for default transport

2023-01-16 Thread GitBox
cstamas commented on code in PR #237: URL: https://github.com/apache/maven-integration-testing/pull/237#discussion_r1071868777 ## core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7470ResolverTransportTest.java: ## @@ -105,14 +105,7 @@ private void performTest( /*

[GitHub] [maven-integration-testing] michael-o commented on a diff in pull request #237: [MNG-7608] Adjust IT for default transport

2023-01-16 Thread GitBox
michael-o commented on code in PR #237: URL: https://github.com/apache/maven-integration-testing/pull/237#discussion_r1071867128 ## core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7470ResolverTransportTest.java: ## @@ -105,14 +105,7 @@ private void performTest( /*

[GitHub] [maven] cstamas commented on pull request #961: [MNG-7608] Make native transport the default

2023-01-16 Thread GitBox
cstamas commented on PR #961: URL: https://github.com/apache/maven/pull/961#issuecomment-1384957103 This change breaks one IT adjusted in https://github.com/apache/maven-integration-testing/pull/237 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [maven-integration-testing] cstamas opened a new pull request, #237: [MNG-7608] Adjust IT for default transport

2023-01-16 Thread GitBox
cstamas opened a new pull request, #237: URL: https://github.com/apache/maven-integration-testing/pull/237 If 3.9 uses native as default as well, there is no need anymore to distinguish between 3.9 and 4+. --- https://issues.apache.org/jira/browse/MNG-7608 -- This is an

[GitHub] [maven] gnodet commented on pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-16 Thread GitBox
gnodet commented on PR #954: URL: https://github.com/apache/maven/pull/954#issuecomment-1384932632 > Left a couple of questions. > > Also, I wonder if this change allows us to remove the fallbacks that were previously on line 150 - 159. Since those lines aren't changed, it seems

[GitHub] [maven] gnodet commented on a diff in pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-16 Thread GitBox
gnodet commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r1071816860 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -20,41 +20,33 @@ import javax.inject.Inject; import javax.inject.Named; +import

[GitHub] [maven] cstamas opened a new pull request, #961: [MNG-7608] Make native transport the default

2023-01-16 Thread GitBox
cstamas opened a new pull request, #961: URL: https://github.com/apache/maven/pull/961 This immediately cuts in "half" the count of HTTP requests against Maven Central or any major MRM. Altering the meaning of "default": is now same as "auto", but still leaving it in place for

[GitHub] [maven] gnodet commented on a diff in pull request #954: [MNG-7629] Change reactor reader to copy packaged artifacts and reuse them across builds if needed

2023-01-16 Thread GitBox
gnodet commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r1071812263 ## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ## @@ -324,4 +300,113 @@ private static boolean isTestArtifact(Artifact artifact) { return

[GitHub] [maven-verifier] dependabot[bot] closed pull request #64: Bump maven-resolver-connector-basic from 1.6.3 to 1.9.2

2023-01-16 Thread GitBox
dependabot[bot] closed pull request #64: Bump maven-resolver-connector-basic from 1.6.3 to 1.9.2 URL: https://github.com/apache/maven-verifier/pull/64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven-verifier] dependabot[bot] commented on pull request #64: Bump maven-resolver-connector-basic from 1.6.3 to 1.9.2

2023-01-16 Thread GitBox
dependabot[bot] commented on PR #64: URL: https://github.com/apache/maven-verifier/pull/64#issuecomment-1384835799 Superseded by #69. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [maven-verifier] dependabot[bot] opened a new pull request, #69: Bump maven-resolver-connector-basic from 1.6.3 to 1.9.4

2023-01-16 Thread GitBox
dependabot[bot] opened a new pull request, #69: URL: https://github.com/apache/maven-verifier/pull/69 Bumps [maven-resolver-connector-basic](https://github.com/apache/maven-resolver) from 1.6.3 to 1.9.4. Release notes Sourced from

[GitHub] [maven-verifier] dependabot[bot] closed pull request #65: Bump maven-resolver-transport-http from 1.6.3 to 1.9.2

2023-01-16 Thread GitBox
dependabot[bot] closed pull request #65: Bump maven-resolver-transport-http from 1.6.3 to 1.9.2 URL: https://github.com/apache/maven-verifier/pull/65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-verifier] dependabot[bot] commented on pull request #65: Bump maven-resolver-transport-http from 1.6.3 to 1.9.2

2023-01-16 Thread GitBox
dependabot[bot] commented on PR #65: URL: https://github.com/apache/maven-verifier/pull/65#issuecomment-1384835727 Superseded by #68. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [maven-verifier] dependabot[bot] opened a new pull request, #68: Bump maven-resolver-transport-http from 1.6.3 to 1.9.4

2023-01-16 Thread GitBox
dependabot[bot] opened a new pull request, #68: URL: https://github.com/apache/maven-verifier/pull/68 Bumps [maven-resolver-transport-http](https://github.com/apache/maven-resolver) from 1.6.3 to 1.9.4. Release notes Sourced from

[GitHub] [maven-gpg-plugin] dependabot[bot] closed pull request #32: Bump maven-resolver-util from 1.4.1 to 1.9.2

2023-01-16 Thread GitBox
dependabot[bot] closed pull request #32: Bump maven-resolver-util from 1.4.1 to 1.9.2 URL: https://github.com/apache/maven-gpg-plugin/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-gpg-plugin] dependabot[bot] commented on pull request #32: Bump maven-resolver-util from 1.4.1 to 1.9.2

2023-01-16 Thread GitBox
dependabot[bot] commented on PR #32: URL: https://github.com/apache/maven-gpg-plugin/pull/32#issuecomment-1384810467 Superseded by #35. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-gpg-plugin] dependabot[bot] opened a new pull request, #35: Bump maven-resolver-util from 1.4.1 to 1.9.4

2023-01-16 Thread GitBox
dependabot[bot] opened a new pull request, #35: URL: https://github.com/apache/maven-gpg-plugin/pull/35 Bumps [maven-resolver-util](https://github.com/apache/maven-resolver) from 1.4.1 to 1.9.4. Release notes Sourced from

[GitHub] [maven-resources-plugin] dependabot[bot] closed pull request #42: Bump maven-resolver-api from 1.6.3 to 1.9.2

2023-01-16 Thread GitBox
dependabot[bot] closed pull request #42: Bump maven-resolver-api from 1.6.3 to 1.9.2 URL: https://github.com/apache/maven-resources-plugin/pull/42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-resources-plugin] dependabot[bot] commented on pull request #42: Bump maven-resolver-api from 1.6.3 to 1.9.2

2023-01-16 Thread GitBox
dependabot[bot] commented on PR #42: URL: https://github.com/apache/maven-resources-plugin/pull/42#issuecomment-1384806913 Superseded by #45. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-resources-plugin] dependabot[bot] opened a new pull request, #45: Bump maven-resolver-api from 1.6.3 to 1.9.4

2023-01-16 Thread GitBox
dependabot[bot] opened a new pull request, #45: URL: https://github.com/apache/maven-resources-plugin/pull/45 Bumps [maven-resolver-api](https://github.com/apache/maven-resolver) from 1.6.3 to 1.9.4. Release notes Sourced from

[GitHub] [maven-jlink-plugin] dependabot[bot] closed pull request #123: Bump maven-plugin-plugin from 3.6.2 to 3.7.0

2023-01-16 Thread GitBox
dependabot[bot] closed pull request #123: Bump maven-plugin-plugin from 3.6.2 to 3.7.0 URL: https://github.com/apache/maven-jlink-plugin/pull/123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-jlink-plugin] dependabot[bot] commented on pull request #123: Bump maven-plugin-plugin from 3.6.2 to 3.7.0

2023-01-16 Thread GitBox
dependabot[bot] commented on PR #123: URL: https://github.com/apache/maven-jlink-plugin/pull/123#issuecomment-1384804504 Superseded by #135. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-jlink-plugin] dependabot[bot] opened a new pull request, #135: Bump maven-plugin-plugin from 3.6.2 to 3.7.1

2023-01-16 Thread GitBox
dependabot[bot] opened a new pull request, #135: URL: https://github.com/apache/maven-jlink-plugin/pull/135 Bumps [maven-plugin-plugin](https://github.com/apache/maven-plugin-tools) from 3.6.2 to 3.7.1. Release notes Sourced from

[GitHub] [maven-jlink-plugin] dependabot[bot] closed pull request #131: Bump assertj-core from 3.21.0 to 3.24.1

2023-01-16 Thread GitBox
dependabot[bot] closed pull request #131: Bump assertj-core from 3.21.0 to 3.24.1 URL: https://github.com/apache/maven-jlink-plugin/pull/131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-jlink-plugin] dependabot[bot] commented on pull request #131: Bump assertj-core from 3.21.0 to 3.24.1

2023-01-16 Thread GitBox
dependabot[bot] commented on PR #131: URL: https://github.com/apache/maven-jlink-plugin/pull/131#issuecomment-1384804208 Superseded by #134. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-jlink-plugin] dependabot[bot] opened a new pull request, #134: Bump assertj-core from 3.21.0 to 3.24.2

2023-01-16 Thread GitBox
dependabot[bot] opened a new pull request, #134: URL: https://github.com/apache/maven-jlink-plugin/pull/134 Bumps assertj-core from 3.21.0 to 3.24.2. [![Dependabot compatibility

[GitHub] [maven-help-plugin] dependabot[bot] closed pull request #78: Bump mavenPluginToolsVersion from 3.6.4 to 3.7.0

2023-01-16 Thread GitBox
dependabot[bot] closed pull request #78: Bump mavenPluginToolsVersion from 3.6.4 to 3.7.0 URL: https://github.com/apache/maven-help-plugin/pull/78 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-help-plugin] dependabot[bot] commented on pull request #78: Bump mavenPluginToolsVersion from 3.6.4 to 3.7.0

2023-01-16 Thread GitBox
dependabot[bot] commented on PR #78: URL: https://github.com/apache/maven-help-plugin/pull/78#issuecomment-1384804008 Superseded by #83. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-help-plugin] dependabot[bot] opened a new pull request, #83: Bump mavenPluginToolsVersion from 3.6.4 to 3.7.1

2023-01-16 Thread GitBox
dependabot[bot] opened a new pull request, #83: URL: https://github.com/apache/maven-help-plugin/pull/83 Bumps `mavenPluginToolsVersion` from 3.6.4 to 3.7.1. Updates `maven-plugin-tools-generators` from 3.6.4 to 3.7.1 Release notes Sourced from

[GitHub] [maven-apache-parent] dependabot[bot] opened a new pull request, #125: Bump maven.plugin.tools.version from 3.7.0 to 3.7.1

2023-01-16 Thread GitBox
dependabot[bot] opened a new pull request, #125: URL: https://github.com/apache/maven-apache-parent/pull/125 Bumps `maven.plugin.tools.version` from 3.7.0 to 3.7.1. Updates `maven-plugin-annotations` from 3.7.0 to 3.7.1 Release notes Sourced from

[GitHub] [maven-invoker-plugin] dependabot[bot] closed pull request #165: Bump assertj-core from 3.23.1 to 3.24.1

2023-01-16 Thread GitBox
dependabot[bot] closed pull request #165: Bump assertj-core from 3.23.1 to 3.24.1 URL: https://github.com/apache/maven-invoker-plugin/pull/165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-invoker-plugin] dependabot[bot] commented on pull request #165: Bump assertj-core from 3.23.1 to 3.24.1

2023-01-16 Thread GitBox
dependabot[bot] commented on PR #165: URL: https://github.com/apache/maven-invoker-plugin/pull/165#issuecomment-1384803743 Superseded by #168. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-invoker-plugin] dependabot[bot] opened a new pull request, #168: Bump assertj-core from 3.23.1 to 3.24.2

2023-01-16 Thread GitBox
dependabot[bot] opened a new pull request, #168: URL: https://github.com/apache/maven-invoker-plugin/pull/168 Bumps assertj-core from 3.23.1 to 3.24.2. [![Dependabot compatibility

[GitHub] [maven-indexer] dependabot[bot] closed pull request #278: Bump resolver.version from 1.8.2 to 1.9.2

2023-01-16 Thread GitBox
dependabot[bot] closed pull request #278: Bump resolver.version from 1.8.2 to 1.9.2 URL: https://github.com/apache/maven-indexer/pull/278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-indexer] dependabot[bot] commented on pull request #278: Bump resolver.version from 1.8.2 to 1.9.2

2023-01-16 Thread GitBox
dependabot[bot] commented on PR #278: URL: https://github.com/apache/maven-indexer/pull/278#issuecomment-1384803281 Superseded by #289. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-indexer] dependabot[bot] opened a new pull request, #289: Bump resolver.version from 1.9.2 to 1.9.4

2023-01-16 Thread GitBox
dependabot[bot] opened a new pull request, #289: URL: https://github.com/apache/maven-indexer/pull/289 Bumps `resolver.version` from 1.9.2 to 1.9.4. Updates `maven-resolver-api` from 1.9.2 to 1.9.4 Release notes Sourced from

<    1   2   3   4   5   6   7   8   9   10   >