Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/173
Thx for your work. I will get back to you soon. Right now I am working on
branch SUREFIRE-1463 which contains few fixes. I plan to finish this,
including build script, and then I would
Github user bindul commented on the issue:
https://github.com/apache/maven-surefire/pull/173
@Tibor17
I have reviewed the Maven Coordinates documentation you mentioned, and I
can switch the order of elements in the parameter easily. However, I think I
would disagree with
Github user bindul commented on the issue:
https://github.com/apache/maven-surefire/pull/173
@Tibor17,
Sorry I misunderstood your first comment. Thank you again for taking the
time to review the changes and for your patience.
I will rework the pull request using your
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/173
@bindul
Then we have to support also other alternatives:
`groupId:artifactId:version`, and
`groupId:artifactId:packaging:version`.
This means you have to, first of all, count
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/173
@binduk
We have modify the maven coordinates to
`groupId:artifactId:packaging:classifier:version`, see the docs:
https://maven.apache.org/pom.html#Maven_Coordinates
Basically,
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/173
I don't want you to remove code. I will try to explain in code.
---
Github user bindul commented on the issue:
https://github.com/apache/maven-surefire/pull/173
@Tibor17 Thank you for your review.
I agree with you that `version` check is not really useful in this use
case, I put it in there as the JIRA ticket called for GAVT support and also
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/173
The comments like this `// Check version` are not needed because it's
obvious from code.
You may remove them or extract that part to private static methods. It's up
to you.
If you
