[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-05-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843577#comment-17843577
 ] 

ASF GitHub Bot commented on MCOMPILER-588:
--

slawekjaranowski merged PR #236:
URL: https://github.com/apache/maven-compiler-plugin/pull/236




> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-23 Thread Mikhail Deviatov (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840161#comment-17840161
 ] 

Mikhail Deviatov commented on MCOMPILER-588:


[~sjaranowski] hi! Could you please provide a feedback? :) 

> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-18 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838760#comment-17838760
 ] 

ASF GitHub Bot commented on MCOMPILER-588:
--

MidNight-er closed pull request #234: [MCOMPILER-588-compiler-test] JUnit4 test 
framework to JUnit5 migration
URL: https://github.com/apache/maven-compiler-plugin/pull/234




> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-18 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838759#comment-17838759
 ] 

ASF GitHub Bot commented on MCOMPILER-588:
--

MidNight-er opened a new pull request, #236:
URL: https://github.com/apache/maven-compiler-plugin/pull/236

   Hi! I created a solution using approach that is implemented in 
maven-testing-harness plugin
   
   




> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-14 Thread Mikhail Deviatov (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836913#comment-17836913
 ] 

Mikhail Deviatov commented on MCOMPILER-588:


you right. I'm back on the track with the native implementation :)

> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836865#comment-17836865
 ] 

ASF GitHub Bot commented on MCOMPILER-588:
--

slawekjaranowski commented on code in PR #234:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/234#discussion_r1564254632


##
src/test/java/org/apache/maven/plugin/compiler/CompilerTest.java:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugin.compiler;
+
+import java.io.File;
+
+import org.apache.maven.api.plugin.testing.InjectMojo;

Review Comment:
   Please use - `org.apache.maven.plugin.testing.junit5.InjectMojo`
   and other from `org.apache.maven.plugin.testing.junit5...`
   
   Package `org.apache.maven.api.plugin.testing` is for Maven 4





> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread Mikhail Deviatov (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836863#comment-17836863
 ] 

Mikhail Deviatov commented on MCOMPILER-588:


[~sjaranowski] sure
[https://github.com/apache/maven-compiler-plugin/pull/234|https://github.com/apache/maven-compiler-plugin/pull/234]

> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836860#comment-17836860
 ] 

ASF GitHub Bot commented on MCOMPILER-588:
--

MidNight-er opened a new pull request, #234:
URL: https://github.com/apache/maven-compiler-plugin/pull/234

   plexus-xml dependency didn't solve the problem




> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836859#comment-17836859
 ] 

Slawomir Jaranowski commented on MCOMPILER-588:
---

Please create a PR even with simple one test ... I will can checkout and test 

> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836858#comment-17836858
 ] 

Slawomir Jaranowski commented on MCOMPILER-588:
---

to resolve {{java.lang.NoClassDefFoundError: org/apache/maven/api/xml/XmlNode}} 
- please add:
{code:xml}

  org.codehaus.plexus
  plexus-xml
  3.0.0
  test

{code}

> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread Mikhail Deviatov (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836854#comment-17836854
 ] 

Mikhail Deviatov commented on MCOMPILER-588:


I faced with a problem trying to apply native solution.
{code:java}
@MojoTest
public class CompilerTest {

@Test
@InjectMojo(goal = "compile", pom = 
"classpath:/target/test-classes/unit/compiler-basic-test/plugin-config.xml")
void testCompilerBasic(CompilerMojo compileMojo) throws Exception {         
 Log log = mock(Log.class);

compileMojo.setLog(log);

compileMojo.execute();

File testClass = new File(compileMojo.getOutputDirectory(), 
"foo/TestCompile0.class");

assertTrue(testClass.exists());
}
}
{code}
produce an error
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.015 s 
<<< FAILURE! – in org.apache.maven.plugin.compiler.CompilerTest
[ERROR] org.apache.maven.plugin.compiler.CompilerTest – Time elapsed: 0.015 s 
<<< ERROR!
java.lang.NoClassDefFoundError: org/apache/maven/api/xml/XmlNode

package with this class was intoduce in 4.0.0-alpha-2 version of maven
[https://mvnrepository.com/artifact/org.apache.maven/maven-api-xml|http://example.com/]

 

internal Maven API is still subject to change
switch to JUnit5 support was introduce in Maven version 3.5.4
later minimum version of Maven was increased to 3.6.3
now it requires 4.0.0-alpha-2 just to start a simple test.

do we really need to wait when API is stabilized?
my solution binds to internal API *maven-plugin-testing-harness* that is not 
gonna be subject to change for a very long time. Applying it we get JUnit5 
support right away. when internal maven API can be applied we can drop my 
solution in favor of native support.
what do you think about this approach?

 

> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836841#comment-17836841
 ] 

ASF GitHub Bot commented on MCOMPILER-588:
--

MidNight-er commented on PR #233:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/233#issuecomment-2053705057

   maven-plugin-testing-harness has native JUnit5 support




> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836840#comment-17836840
 ] 

ASF GitHub Bot commented on MCOMPILER-588:
--

MidNight-er closed pull request #233: [MCOMPILER-588] JUnit4 test framework to 
JUnit5 migration
URL: https://github.com/apache/maven-compiler-plugin/pull/233




> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836837#comment-17836837
 ] 

Slawomir Jaranowski commented on MCOMPILER-588:
---

[~midnighter] you should be able to close your PR by yourself

We can split such work for some a few smaller PRs.
We can have - simple unit test which can be migrated first.
We can use both JUnit4 and JUnit 5 i one project, so we ca do it step by step.

By the way thanks for the effort and contributions.
 

> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread Mikhail Deviatov (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836836#comment-17836836
 ] 

Mikhail Deviatov commented on MCOMPILER-588:


yeah, there is realy native JUnit5 suport. please close my PR in favor of their 
solution

> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836832#comment-17836832
 ] 

Slawomir Jaranowski commented on MCOMPILER-588:
---

*maven-plugin-testing-harness* since 4.0.0-alpha-2 - MPLUGINTESTING-84 support 
Junit 5 for Maven 3 

Please look at example: https://github.com/apache/maven-clean-plugin/pull/27

yes ... documentation is missing, so I created issue to not forget 
MPLUGINTESTING-93

> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-04-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836831#comment-17836831
 ] 

ASF GitHub Bot commented on MCOMPILER-588:
--

MidNight-er opened a new pull request, #233:
URL: https://github.com/apache/maven-compiler-plugin/pull/233

   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [x ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MCOMPILER) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [ x] Each commit in the pull request should have a meaningful subject 
line and body.
- [ x] Format the pull request title like `[MCOMPILER-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MCOMPILER-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [x ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [ x] You have run the integration tests successfully (`mvn -Prun-its 
clean verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [x ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   




> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Priority: Major
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)