[jira] [Commented] (METRON-1552) Add gzip file validation check to the geo loader

2018-05-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472853#comment-16472853 ] ASF GitHub Bot commented on METRON-1552: Github user cestella commented on a diff in the pull

[GitHub] metron pull request #1011: METRON-1552: Add gzip file validation check to th...

2018-05-11 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/1011#discussion_r187759693 --- Diff: metron-platform/metron-data-management/src/main/java/org/apache/metron/dataloads/nonbulk/geo/GeoEnrichmentLoader.java --- @@ -167,26 +184,38 @@

[GitHub] metron pull request #1011: METRON-1552: Add gzip file validation check to th...

2018-05-11 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/1011#discussion_r187759685 --- Diff: metron-platform/metron-data-management/src/main/java/org/apache/metron/dataloads/nonbulk/geo/GeoEnrichmentLoader.java --- @@ -167,26 +184,38 @@

[jira] [Commented] (METRON-1552) Add gzip file validation check to the geo loader

2018-05-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472851#comment-16472851 ] ASF GitHub Bot commented on METRON-1552: Github user cestella commented on a diff in the pull

[jira] [Commented] (METRON-1552) Add gzip file validation check to the geo loader

2018-05-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472828#comment-16472828 ] ASF GitHub Bot commented on METRON-1552: Github user cestella commented on a diff in the pull

[jira] [Commented] (METRON-1552) Add gzip file validation check to the geo loader

2018-05-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472827#comment-16472827 ] ASF GitHub Bot commented on METRON-1552: Github user cestella commented on a diff in the pull

[jira] [Commented] (METRON-1552) Add gzip file validation check to the geo loader

2018-05-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472826#comment-16472826 ] ASF GitHub Bot commented on METRON-1552: Github user cestella commented on a diff in the pull

[jira] [Commented] (METRON-1552) Add gzip file validation check to the geo loader

2018-05-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472829#comment-16472829 ] ASF GitHub Bot commented on METRON-1552: Github user cestella commented on a diff in the pull

[GitHub] metron pull request #1011: METRON-1552: Add gzip file validation check to th...

2018-05-11 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/1011#discussion_r187757695 --- Diff: metron-platform/metron-data-management/src/main/java/org/apache/metron/dataloads/nonbulk/geo/GeoEnrichmentLoader.java --- @@ -167,26 +184,38 @@

[GitHub] metron pull request #1011: METRON-1552: Add gzip file validation check to th...

2018-05-11 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/1011#discussion_r187757704 --- Diff: metron-platform/metron-data-management/src/main/java/org/apache/metron/dataloads/nonbulk/geo/GeoEnrichmentLoader.java --- @@ -167,26 +184,38 @@

[GitHub] metron pull request #1011: METRON-1552: Add gzip file validation check to th...

2018-05-11 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/1011#discussion_r187757683 --- Diff: metron-platform/metron-data-management/src/main/java/org/apache/metron/dataloads/nonbulk/geo/GeoEnrichmentLoader.java --- @@ -167,26 +184,38 @@

[GitHub] metron pull request #1011: METRON-1552: Add gzip file validation check to th...

2018-05-11 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/1011#discussion_r187757615 --- Diff: metron-platform/metron-data-management/src/main/java/org/apache/metron/dataloads/nonbulk/geo/GeoEnrichmentLoader.java --- @@ -146,7 +156,14 @@

[jira] [Commented] (METRON-1552) Add gzip file validation check to the geo loader

2018-05-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472823#comment-16472823 ] ASF GitHub Bot commented on METRON-1552: GitHub user mmiklavc opened a pull request:

[GitHub] metron pull request #1011: METRON-1552: Add gzip file validation check to th...

2018-05-11 Thread mmiklavc
GitHub user mmiklavc opened a pull request: https://github.com/apache/metron/pull/1011 METRON-1552: Add gzip file validation check to the geo loader ## Contributor Comments https://issues.apache.org/jira/browse/METRON-1552 We don't have retries implemented in the

[jira] [Created] (METRON-1552) Add gzip file validation check to the geo loader

2018-05-11 Thread Michael Miklavcic (JIRA)
Michael Miklavcic created METRON-1552: - Summary: Add gzip file validation check to the geo loader Key: METRON-1552 URL: https://issues.apache.org/jira/browse/METRON-1552 Project: Metron

[jira] [Commented] (METRON-1421) Create a SolrMetaAlertDao

2018-05-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472670#comment-16472670 ] ASF GitHub Bot commented on METRON-1421: Github user justinleet commented on the issue:

[GitHub] metron issue #970: METRON-1421: Create a SolrMetaAlertDao

2018-05-11 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/970 Pulled in https://github.com/justinleet/metron/pull/18 from @merrimanr to address the reported bugs when metaalerts become empty. Thanks for digging into the bug you found, it's super helpful!

[jira] [Created] (METRON-1551) Profiler Should Not Use Java Serialization

2018-05-11 Thread Nick Allen (JIRA)
Nick Allen created METRON-1551: -- Summary: Profiler Should Not Use Java Serialization Key: METRON-1551 URL: https://issues.apache.org/jira/browse/METRON-1551 Project: Metron Issue Type: Bug

[jira] [Commented] (METRON-1549) Add empty object test to WriterBoltIntegrationTest implementation

2018-05-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472380#comment-16472380 ] ASF GitHub Bot commented on METRON-1549: Github user asfgit closed the pull request at:

[GitHub] metron pull request #1009: METRON-1549: Add empty object test to WriterBoltI...

2018-05-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1009 ---

[jira] [Commented] (METRON-1548) Alerts UI: Remove hardcoded source:type and other fields that may vary

2018-05-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471944#comment-16471944 ] ASF GitHub Bot commented on METRON-1548: GitHub user sardell opened a pull request:

[GitHub] metron pull request #1010: METRON-1548: Remove hardcoded source:type from Al...

2018-05-11 Thread sardell
GitHub user sardell opened a pull request: https://github.com/apache/metron/pull/1010 METRON-1548: Remove hardcoded source:type from Alerts UI ## Contributor Comments Instead of 'source:type' being hard coded as a string in the Alerts UI, we now use a global-config service to

[jira] [Commented] (METRON-1549) Add empty object test to WriterBoltIntegrationTest implementation

2018-05-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471852#comment-16471852 ] ASF GitHub Bot commented on METRON-1549: Github user ottobackwards commented on the issue:

[GitHub] metron issue #1009: METRON-1549: Add empty object test to WriterBoltIntegrat...

2018-05-11 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/1009 +1 ---

[jira] [Commented] (METRON-1549) Add empty object test to WriterBoltIntegrationTest implementation

2018-05-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471846#comment-16471846 ] ASF GitHub Bot commented on METRON-1549: Github user nickwallen commented on the issue:

[GitHub] metron issue #1009: METRON-1549: Add empty object test to WriterBoltIntegrat...

2018-05-11 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1009 +1 This looks good. Thanks! ---

[jira] [Commented] (METRON-1549) Add empty object test to WriterBoltIntegrationTest implementation

2018-05-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471790#comment-16471790 ] ASF GitHub Bot commented on METRON-1549: Github user ottobackwards commented on the issue:

[GitHub] metron issue #1009: METRON-1549: Add empty object test to WriterBoltIntegrat...

2018-05-11 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/1009 I think this is good. My work on the builder/Processor stuff was a decent attempt to reduce duplicate code in the integration tests without a total rethink. I think what we see across the