[jira] [Commented] (METRON-1555) Update REST to run YARN and MR jobs

[ https://issues.apache.org/jira/browse/METRON-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522984#comment-16522984 ] ASF GitHub Bot commented on METRON-1555: Github user mmiklavc commented on the issue:

[GitHub] metron issue #1019: METRON-1555: Update REST to run YARN and MR jobs

Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1019 Thanks for the adjustments @merrimanr. Looks good, +1. ---

[GitHub] metron issue #1064: METRON-1619: Stellar empty collections should be conside...

Github user cestella commented on the issue: https://github.com/apache/metron/pull/1064 @merrimanr would you mind taking a look at this one since you looked at the last one that subsumes. ---

[jira] [Commented] (METRON-1619) Stellar empty collections should be considered false in boolean expressions

[ https://issues.apache.org/jira/browse/METRON-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522922#comment-16522922 ] ASF GitHub Bot commented on METRON-1619: Github user cestella commented on the issue:

[GitHub] metron issue #1064: METRON-1619: Stellar empty collections should be conside...

Github user cestella commented on the issue: https://github.com/apache/metron/pull/1064 Ok, @simonellistonball I've updated the docs appropriately and @ottobackwards I added tests for match as well as cleaning up the documentation. This PR should be interpreted to contain both empty

[jira] [Commented] (METRON-1619) Stellar empty collections should be considered false in boolean expressions

[ https://issues.apache.org/jira/browse/METRON-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522921#comment-16522921 ] ASF GitHub Bot commented on METRON-1619: Github user cestella commented on the issue:

[GitHub] metron pull request #1063: METRON-1618: Stellar boolean expressions should t...

Github user cestella closed the pull request at: https://github.com/apache/metron/pull/1063 ---

[jira] [Commented] (METRON-1618) Stellar boolean expressions should treat missing variables as false

[ https://issues.apache.org/jira/browse/METRON-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522914#comment-16522914 ] ASF GitHub Bot commented on METRON-1618: Github user cestella closed the pull request at:

[jira] [Commented] (METRON-1425) Test and run Solr deployment in multinode environment

[ https://issues.apache.org/jira/browse/METRON-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522903#comment-16522903 ] James Sirota commented on METRON-1425: -- Going to run this up as soon as the Solr branch is merged

[jira] [Commented] (METRON-1634) Alerts UI add comment doesn't immediately show up.

[ https://issues.apache.org/jira/browse/METRON-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522839#comment-16522839 ] ASF GitHub Bot commented on METRON-1634: Github user justinleet commented on the issue:

[GitHub] metron issue #1077: METRON-1634: Alerts UI add comment doesn't immediately s...

Github user justinleet commented on the issue: https://github.com/apache/metron/pull/1077 +1 by inspection, assuming Travis succeeds and @tiborm is good with the most recent changes. ---

[jira] [Commented] (METRON-1637) Wrong path to escalate alert REST endpoint

[ https://issues.apache.org/jira/browse/METRON-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522836#comment-16522836 ] ASF GitHub Bot commented on METRON-1637: GitHub user merrimanr opened a pull request:

[GitHub] metron pull request #1078: METRON-1637: Wrong path to escalate alert REST en...

GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/1078 METRON-1637: Wrong path to escalate alert REST endpoint ## Contributor Comments This PR corrects a small bug where the escalate endpoint in the Alerts UI doesn't match the actual path in

[jira] [Created] (METRON-1637) Wrong path to escalate alert REST endpoint

Ryan Merriman created METRON-1637: - Summary: Wrong path to escalate alert REST endpoint Key: METRON-1637 URL: https://issues.apache.org/jira/browse/METRON-1637 Project: Metron Issue Type:

[jira] [Commented] (METRON-1634) Alerts UI add comment doesn't immediately show up.

[ https://issues.apache.org/jira/browse/METRON-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522825#comment-16522825 ] ASF GitHub Bot commented on METRON-1634: Github user merrimanr commented on the issue:

[GitHub] metron issue #1077: METRON-1634: Alerts UI add comment doesn't immediately s...

Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1077 @justinleet I changed the logic to reverse the operation rather than reverting back to a copy. This means that a comment will be removed from the list on a failed add and a comment will be added

[jira] [Commented] (METRON-1618) Stellar boolean expressions should treat missing variables as false

[ https://issues.apache.org/jira/browse/METRON-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522781#comment-16522781 ] ASF GitHub Bot commented on METRON-1618: Github user cestella commented on the issue:

[GitHub] metron issue #1063: METRON-1618: Stellar boolean expressions should treat mi...

Github user cestella commented on the issue: https://github.com/apache/metron/pull/1063 I think I'm going to move this discussion to #1064 as it's getting kinda hard to treat this and #1064 as separate without incurring merge conflicts. I'll be closing this once I've addressed

[jira] [Commented] (METRON-1619) Stellar empty collections should be considered false in boolean expressions

[ https://issues.apache.org/jira/browse/METRON-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522766#comment-16522766 ] ASF GitHub Bot commented on METRON-1619: Github user cestella commented on a diff in the pull

[GitHub] metron pull request #1064: METRON-1619: Stellar empty collections should be ...

Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/1064#discussion_r197929046 --- Diff: metron-stellar/stellar-common/README.md --- @@ -54,6 +54,12 @@ The Stellar language supports the following: * The ability to have

[jira] [Commented] (METRON-1634) Alerts UI add comment doesn't immediately show up.

[ https://issues.apache.org/jira/browse/METRON-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522652#comment-16522652 ] ASF GitHub Bot commented on METRON-1634: Github user justinleet commented on the issue:

[GitHub] metron issue #1077: METRON-1634: Alerts UI add comment doesn't immediately s...

Github user justinleet commented on the issue: https://github.com/apache/metron/pull/1077 What happens in the case where two comments are optimistically added, then the first one fails? e.g. 1. User adds comment_1 2. User adds comment_2 3. Some failure occurs and

[GitHub] metron issue #1076: METRON-1416: Upgrade Solr

Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1076 +1 Merge looks good. I ran the development environment up just to be sure. ---

[jira] [Commented] (METRON-1416) Upgrade Solr

[ https://issues.apache.org/jira/browse/METRON-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522582#comment-16522582 ] ASF GitHub Bot commented on METRON-1416: Github user nickwallen commented on the issue:

[jira] [Commented] (METRON-1416) Upgrade Solr

[ https://issues.apache.org/jira/browse/METRON-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522488#comment-16522488 ] ASF GitHub Bot commented on METRON-1416: Github user cestella commented on the issue:

[GitHub] metron issue #1076: METRON-1416: Upgrade Solr

Github user cestella commented on the issue: https://github.com/apache/metron/pull/1076 I'm +1, but I also have commits in there, so I'd wait for someone else to merge. ---

[jira] [Commented] (METRON-1634) Alerts UI add comment doesn't immediately show up.

[ https://issues.apache.org/jira/browse/METRON-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522334#comment-16522334 ] ASF GitHub Bot commented on METRON-1634: Github user tiborm commented on the issue:

[GitHub] metron issue #1077: METRON-1634: Alerts UI add comment doesn't immediately s...

Github user tiborm commented on the issue: https://github.com/apache/metron/pull/1077 +1 ---

[jira] [Commented] (METRON-1634) Alerts UI add comment doesn't immediately show up.

[ https://issues.apache.org/jira/browse/METRON-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522316#comment-16522316 ] ASF GitHub Bot commented on METRON-1634: Github user merrimanr commented on the issue:

[GitHub] metron issue #1077: METRON-1634: Alerts UI add comment doesn't immediately s...

Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1077 Ok latest commit should do it. ---

[jira] [Commented] (METRON-1634) Alerts UI add comment doesn't immediately show up.

[ https://issues.apache.org/jira/browse/METRON-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522307#comment-16522307 ] ASF GitHub Bot commented on METRON-1634: Github user tiborm commented on a diff in the pull

[jira] [Commented] (METRON-1634) Alerts UI add comment doesn't immediately show up.

[ https://issues.apache.org/jira/browse/METRON-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522306#comment-16522306 ] ASF GitHub Bot commented on METRON-1634: Github user tiborm commented on a diff in the pull

[GitHub] metron pull request #1077: METRON-1634: Alerts UI add comment doesn't immedi...

Github user tiborm commented on a diff in the pull request: https://github.com/apache/metron/pull/1077#discussion_r197804645 --- Diff: metron-interface/metron-alerts/src/app/alerts/alert-details/alert-details.component.ts --- @@ -223,21 +222,23 @@ export class

[GitHub] metron pull request #1077: METRON-1634: Alerts UI add comment doesn't immedi...

Github user tiborm commented on a diff in the pull request: https://github.com/apache/metron/pull/1077#discussion_r197804428 --- Diff: metron-interface/metron-alerts/src/app/alerts/alert-details/alert-details.component.ts --- @@ -223,21 +222,23 @@ export class

[jira] [Commented] (METRON-1634) Alerts UI add comment doesn't immediately show up.

[ https://issues.apache.org/jira/browse/METRON-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522281#comment-16522281 ] ASF GitHub Bot commented on METRON-1634: Github user merrimanr commented on the issue:

[GitHub] metron issue #1077: METRON-1634: Alerts UI add comment doesn't immediately s...

Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1077 Latest commit should address your comments. Let me know what you think. ---

[jira] [Commented] (METRON-1634) Alerts UI add comment doesn't immediately show up.

[ https://issues.apache.org/jira/browse/METRON-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522271#comment-16522271 ] ASF GitHub Bot commented on METRON-1634: Github user merrimanr commented on a diff in the pull

[GitHub] metron pull request #1077: METRON-1634: Alerts UI add comment doesn't immedi...

Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1077#discussion_r197793823 --- Diff: metron-interface/metron-alerts/src/app/alerts/alert-details/alert-details.component.ts --- @@ -99,16 +99,15 @@ export class

[jira] [Commented] (METRON-1634) Alerts UI add comment doesn't immediately show up.

[ https://issues.apache.org/jira/browse/METRON-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522270#comment-16522270 ] ASF GitHub Bot commented on METRON-1634: Github user merrimanr commented on a diff in the pull

[GitHub] metron pull request #1077: METRON-1634: Alerts UI add comment doesn't immedi...

Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1077#discussion_r197793776 --- Diff: metron-interface/metron-alerts/src/app/alerts/alert-details/alert-details.component.ts --- @@ -224,20 +223,22 @@ export class

[jira] [Commented] (METRON-1634) Alerts UI add comment doesn't immediately show up.

[ https://issues.apache.org/jira/browse/METRON-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522268#comment-16522268 ] ASF GitHub Bot commented on METRON-1634: Github user tiborm commented on a diff in the pull

[GitHub] metron pull request #1077: METRON-1634: Alerts UI add comment doesn't immedi...

Github user tiborm commented on a diff in the pull request: https://github.com/apache/metron/pull/1077#discussion_r197785684 --- Diff: metron-interface/metron-alerts/src/app/alerts/alert-details/alert-details.component.ts --- @@ -224,20 +223,22 @@ export class

[jira] [Commented] (METRON-1634) Alerts UI add comment doesn't immediately show up.

[ https://issues.apache.org/jira/browse/METRON-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522269#comment-16522269 ] ASF GitHub Bot commented on METRON-1634: Github user tiborm commented on a diff in the pull

[GitHub] metron pull request #1077: METRON-1634: Alerts UI add comment doesn't immedi...

Github user tiborm commented on a diff in the pull request: https://github.com/apache/metron/pull/1077#discussion_r197785973 --- Diff: metron-interface/metron-alerts/src/app/alerts/alert-details/alert-details.component.ts --- @@ -99,16 +99,15 @@ export class AlertDetailsComponent

[jira] [Created] (METRON-1636) Fix broken unit test setup in metron-alerts

Tibor Meller created METRON-1636: Summary: Fix broken unit test setup in metron-alerts Key: METRON-1636 URL: https://issues.apache.org/jira/browse/METRON-1636 Project: Metron Issue Type: Bug