[jira] [Commented] (METRON-1501) Parser messages that fail to validate are dropped silently

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424096#comment-16424096
 ] 

ASF GitHub Bot commented on METRON-1501:


Github user asfgit closed the pull request at:

https://github.com/apache/metron/pull/972


> Parser messages that fail to validate are dropped silently
> --
>
> Key: METRON-1501
> URL: https://issues.apache.org/jira/browse/METRON-1501
> Project: Metron
>  Issue Type: Bug
>Reporter: Casey Stella
>Priority: Major
>
> Currently we have two concepts of dealing with messages that are not going to 
> be passed through:
>  * Messages that fail global validation
>  * Messages that fail the parser's validation function
>  * Messages that are filtered out
>  
> Currently in the case of messages that fail global validation, we send them 
> to the error queue.
> In the case of messages that fail the parser's validation function, we drop 
> them silently.
> In the case of messages that are filtered out, we drop them silently as well.
>  
> Given the use-cases behind filtering (e.g. a kafka topic with multiple types 
> of messages where we want to pass along only one type), it makes sense to 
> drop them silently.  However, in the case of the messages that fail the 
> parser's validation function, we should like to know that and treat those 
> similarly to those messages that fail global validation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] metron pull request #972: METRON-1501: Parser messages that fail to validate...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/metron/pull/972


---

[GitHub] metron pull request #968: METRON-1497: Rest endpoint '/api/v1/search/search'...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/metron/pull/968


---

[jira] [Commented] (METRON-1497) Rest endpoint '/api/v1/search/search' needs to handle null when elastic search response return null for getAggregations

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424094#comment-16424094
 ] 

ASF GitHub Bot commented on METRON-1497:


Github user asfgit closed the pull request at:

https://github.com/apache/metron/pull/968


> Rest endpoint '/api/v1/search/search' needs to handle null when elastic 
> search response return null for getAggregations   
> --
>
> Key: METRON-1497
> URL: https://issues.apache.org/jira/browse/METRON-1497
> Project: Metron
>  Issue Type: Bug
>Reporter: Mohan
>Assignee: Mohan
>Priority: Major
>
> /api/v1/search/search throws null pointer exception as below when you have 
> fresh deployment with no indices created . 
> {code:java}
> {
>   "timestamp": "2018-03-19 11:42:11",
>   "status": 500,
>   "error": "Internal Server Error",
>   "exception": "java.lang.NullPointerException",
>   "message": "No message available",
>   "path": "/api/v1/search/search"
> }
> {code}
> below is the pay load 
> {code:java}
> {
> "indices": [],
> "query": "*",
> "from": 0,
> "size": 10,
> "sort": [
>   {
> "field": "timestamp",
> "sortOrder": "desc"
>   }
> ],
> "facetFields": []
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] metron issue #970: METRON-1421: Create a SolrMetaAlertDao

[nickwallen]

Github user nickwallen commented on the issue:

https://github.com/apache/metron/pull/970
  
> @justinleet Are you more interested into breaking things out into more 
classes than that, just breaking apart functions more so they're more easily 
tested, some combination of both?

> @justinleet Is breaking the meta alert dao into the various sub functions 
(Search, Update, etc.) + pulling out the calculate logic + at least a 
refactoring pass for testability a good first step in moving this forward?"

Yes, I like it; that works.  I will be happy if we get better unit test 
coverage on all of this. 




---

[GitHub] metron issue #687: METRON-1090 Add Assignment to Stellar Language

[ottobackwards]

Github user ottobackwards commented on the issue:

https://github.com/apache/metron/pull/687
  
Bump


---

[jira] [Commented] (METRON-1212) Bundles and Maven Plugin

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424288#comment-16424288
 ] 

ASF GitHub Bot commented on METRON-1212:


Github user ottobackwards commented on the issue:

https://github.com/apache/metron/pull/865
  
I'm going to bump this, because it is on my todo list, but I am not 
optimistic


> Bundles and Maven Plugin
> 
>
> Key: METRON-1212
> URL: https://issues.apache.org/jira/browse/METRON-1212
> Project: Metron
>  Issue Type: Sub-task
>Reporter: Otto Fowler
>Assignee: Otto Fowler
>Priority: Major
>  Labels: metron-feature-canidate, 
> metron-feature-extensions-parsers
>
> The first effort will be to land the bundle system and supporting maven 
> plugin on master



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (METRON-1367) Stellar should optionally instrument function calls

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424295#comment-16424295
 ] 

ASF GitHub Bot commented on METRON-1367:


Github user ottobackwards commented on the issue:

https://github.com/apache/metron/pull/873
  
I think I'm actually going to get to create a new commons- component to 
house this.  Will this pr beat that one?  Who knows?


> Stellar should optionally instrument function calls
> ---
>
> Key: METRON-1367
> URL: https://issues.apache.org/jira/browse/METRON-1367
> Project: Metron
>  Issue Type: Improvement
>Reporter: Otto Fowler
>Assignee: Otto Fowler
>Priority: Major
>
> It would be nice if stellar processor(s) could optionally instrument function 
> calls to test performance.
> The result would be some structure with the calls, the times and maybe some 
> context as a list or map



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (METRON-1339) Stellar Shell: Should have a way to validate deployed functions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424292#comment-16424292
 ] 

ASF GitHub Bot commented on METRON-1339:


Github user ottobackwards commented on the issue:

https://github.com/apache/metron/pull/856
  
Should I close this?  


> Stellar Shell: Should have a way to validate deployed functions
> ---
>
> Key: METRON-1339
> URL: https://issues.apache.org/jira/browse/METRON-1339
> Project: Metron
>  Issue Type: New Feature
>Reporter: Otto Fowler
>Assignee: Otto Fowler
>Priority: Major
>
> It is possible that the Stellar Language is changed during a release, meaning 
> stellar expressions that are in zookeeper are now invalid, and will not run.
> Currently users cannot verify this without just letting them fail and hunting 
> the errors down.
> The Stellar Shell should expose a '%' function that will verify that all 
> stellar functions compile and are syntactically correct.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] metron issue #873: METRON-1367 Stellar should have some instrumentation of f...

[ottobackwards]

Github user ottobackwards commented on the issue:

https://github.com/apache/metron/pull/873
  
I think I'm actually going to get to create a new commons- component to 
house this.  Will this pr beat that one?  Who knows?


---

[jira] [Commented] (METRON-1465) X-pack support for Elasticsearch

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424186#comment-16424186
 ] 

ASF GitHub Bot commented on METRON-1465:


Github user wardbekker commented on a diff in the pull request:

https://github.com/apache/metron/pull/946#discussion_r178870634
  
--- Diff: 
metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/components/ElasticSearchComponent.java
 ---
@@ -277,7 +277,7 @@ public boolean hasIndex(String indexName) {
 @Override
 public void stop() {
   try {
-node.close();
+  node.close();
--- End diff --

Done @nickwallen 


> X-pack support for Elasticsearch
> 
>
> Key: METRON-1465
> URL: https://issues.apache.org/jira/browse/METRON-1465
> Project: Metron
>  Issue Type: Bug
>Affects Versions: 0.4.2
>Reporter: Ward Bekker
>Priority: Major
> Fix For: 0.4.3
>
>
> Provide support for X-pack secured Elasticsearch clusters for the 
> Elasticsearch writer and the DAO used by the rest service.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (METRON-1090) STELLAR Add Assignment capability to Stellar language

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424290#comment-16424290
 ] 

ASF GitHub Bot commented on METRON-1090:


Github user ottobackwards commented on the issue:

https://github.com/apache/metron/pull/687
  
Bump


> STELLAR Add Assignment capability to Stellar language
> -
>
> Key: METRON-1090
> URL: https://issues.apache.org/jira/browse/METRON-1090
> Project: Metron
>  Issue Type: New Feature
>Reporter: Otto Fowler
>Assignee: Otto Fowler
>Priority: Major
>
> Add support for =, +=, -=, *=, /= for variables in stellar.
> foo = 5  returns 5 AND sets foo to 5 if the VariableResolver supports it.
> The shell should be changed to assign variables using this syntax, because 
> exposing the left side to stellar allows catching errors for invalid keywords 
> in left side.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] metron issue #856: METRON-1339 Stellar Shell functionality to verify stored ...

[ottobackwards]

Github user ottobackwards commented on the issue:

https://github.com/apache/metron/pull/856
  
Should I close this?  


---

[jira] [Commented] (METRON-1421) Create a SolrMetaAlertDao

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424176#comment-16424176
 ] 

ASF GitHub Bot commented on METRON-1421:


Github user nickwallen commented on the issue:

https://github.com/apache/metron/pull/970
  
> @justinleet Are you more interested into breaking things out into more 
classes than that, just breaking apart functions more so they're more easily 
tested, some combination of both?

> @justinleet Is breaking the meta alert dao into the various sub functions 
(Search, Update, etc.) + pulling out the calculate logic + at least a 
refactoring pass for testability a good first step in moving this forward?"

Yes, I like it; that works.  I will be happy if we get better unit test 
coverage on all of this. 




> Create a SolrMetaAlertDao
> -
>
> Key: METRON-1421
> URL: https://issues.apache.org/jira/browse/METRON-1421
> Project: Metron
>  Issue Type: Sub-task
>Reporter: Justin Leet
>Assignee: Justin Leet
>Priority: Major
>
> Create an implementation of the MetaAlertDao for Solr. This will involve 
> implementing the various MetaAlertDao methods using the SolrJ library and 
> also providing a SolrMetaAlertIntegrationTest (similar to 
> ElasticsearchMetaAlertIntegrationTest).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] metron pull request #946: METRON-1465:Support for Elasticsearch X-pack

[wardbekker]

Github user wardbekker commented on a diff in the pull request:

https://github.com/apache/metron/pull/946#discussion_r178870634
  
--- Diff: 
metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/components/ElasticSearchComponent.java
 ---
@@ -277,7 +277,7 @@ public boolean hasIndex(String indexName) {
 @Override
 public void stop() {
   try {
-node.close();
+  node.close();
--- End diff --

Done @nickwallen 


---

[GitHub] metron issue #865: METRON-1212 The bundle System and Maven Plugin (Feature B...

[ottobackwards]

Github user ottobackwards commented on the issue:

https://github.com/apache/metron/pull/865
  
I'm going to bump this, because it is on my todo list, but I am not 
optimistic


---

[GitHub] metron pull request #946: METRON-1465:Support for Elasticsearch X-pack

[mmiklavc]

Github user mmiklavc commented on a diff in the pull request:

https://github.com/apache/metron/pull/946#discussion_r178923287
  
--- Diff: 
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/utils/ElasticsearchUtils.java
 ---
@@ -107,32 +113,94 @@ public static String getBaseIndexName(String 
indexName) {
 return parts[0];
   }
 
-  public static TransportClient getClient(Map 
globalConfiguration, Map optionalSettings) {
+  /**
+   * Instantiates an Elasticsearch client based on es.client.class, if 
set. Defaults to
+   * org.elasticsearch.transport.client.PreBuiltTransportClient.
+   *
+   * @param globalConfiguration Metron global config
+   * @return
+   */
+  public static TransportClient getClient(Map 
globalConfiguration) {
+Set customESSettings = new HashSet<>();
+customESSettings.addAll(Arrays.asList("es.client.class", 
"es.xpack.username", "es.xpack.password.file"));
 Settings.Builder settingsBuilder = Settings.builder();
-settingsBuilder.put("cluster.name", 
globalConfiguration.get("es.clustername"));
-settingsBuilder.put("client.transport.ping_timeout","500s");
-if (optionalSettings != null) {
-  settingsBuilder.put(optionalSettings);
+Map esSettings = getEsSettings(globalConfiguration);
+for (Map.Entry entry : esSettings.entrySet()) {
+  String key = entry.getKey();
+  String value = entry.getValue();
+  if (!customESSettings.contains(key)) {
+settingsBuilder.put(key, value);
+  }
 }
-Settings settings = settingsBuilder.build();
-TransportClient client;
-try{
+settingsBuilder.put("cluster.name", 
globalConfiguration.get("es.clustername"));
+settingsBuilder.put("client.transport.ping_timeout", 
esSettings.getOrDefault("client.transport.ping_timeout","500s"));
+setXPackSecurityOrNone(settingsBuilder, esSettings);
+
+try {
   LOG.info("Number of available processors in Netty: {}", 
NettyRuntimeWrapper.availableProcessors());
   // Netty sets available processors statically and if an attempt is 
made to set it more than
   // once an IllegalStateException is thrown by 
NettyRuntime.setAvailableProcessors(NettyRuntime.java:87)
   // 
https://discuss.elastic.co/t/getting-availableprocessors-is-already-set-to-1-rejecting-1-illegalstateexception-exception/103082
   // 
https://discuss.elastic.co/t/elasticsearch-5-4-1-availableprocessors-is-already-set/88036
   System.setProperty("es.set.netty.runtime.available.processors", 
"false");
-  client = new PreBuiltTransportClient(settings);
-  for(HostnamePort hp : getIps(globalConfiguration)) {
+  TransportClient client = 
createTransportClient(settingsBuilder.build(), esSettings);
+  for (HostnamePort hp : getIps(globalConfiguration)) {
 client.addTransportAddress(
 new 
InetSocketTransportAddress(InetAddress.getByName(hp.hostname), hp.port)
 );
   }
-} catch (UnknownHostException exception){
+  return client;
+} catch (UnknownHostException exception) {
   throw new RuntimeException(exception);
 }
-return client;
+  }
+
+  private static Map getEsSettings(Map 
config) {
+return ConversionUtils
+.convertMap((Map) 
config.getOrDefault("es.client.settings", new HashMap()),
+String.class);
+  }
+
+  private static void setXPackSecurityOrNone(Settings.Builder 
settingsBuilder, Map esSettings) {
+if (esSettings.containsKey("es.xpack.password.file")) {
--- End diff --

@nickwallen and @wardbekker - how about we do 3 things here
1. Check for both keys
```
if (esSettings.containsKey("es.xpack.username") && 
esSettings.containsKey("es.xpack.password.file"))
```
2. Warn on only 1 of the 2 required keys being present
```
else if (esSettings.containsKey("es.xpack.username") ^ 
esSettings.containsKey("es.xpack.password.file"))
```
3. Do a null/empty check on username similar to the password file
```
if (StringUtils.isEmtpy(xpackUsername) {
throw new IllegalArgumentException("X-Pack username cannot be empty");
}
```


---

[jira] [Commented] (METRON-1465) X-pack support for Elasticsearch

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424418#comment-16424418
 ] 

ASF GitHub Bot commented on METRON-1465:


Github user mmiklavc commented on a diff in the pull request:

https://github.com/apache/metron/pull/946#discussion_r178923287
  
--- Diff: 
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/utils/ElasticsearchUtils.java
 ---
@@ -107,32 +113,94 @@ public static String getBaseIndexName(String 
indexName) {
 return parts[0];
   }
 
-  public static TransportClient getClient(Map 
globalConfiguration, Map optionalSettings) {
+  /**
+   * Instantiates an Elasticsearch client based on es.client.class, if 
set. Defaults to
+   * org.elasticsearch.transport.client.PreBuiltTransportClient.
+   *
+   * @param globalConfiguration Metron global config
+   * @return
+   */
+  public static TransportClient getClient(Map 
globalConfiguration) {
+Set customESSettings = new HashSet<>();
+customESSettings.addAll(Arrays.asList("es.client.class", 
"es.xpack.username", "es.xpack.password.file"));
 Settings.Builder settingsBuilder = Settings.builder();
-settingsBuilder.put("cluster.name", 
globalConfiguration.get("es.clustername"));
-settingsBuilder.put("client.transport.ping_timeout","500s");
-if (optionalSettings != null) {
-  settingsBuilder.put(optionalSettings);
+Map esSettings = getEsSettings(globalConfiguration);
+for (Map.Entry entry : esSettings.entrySet()) {
+  String key = entry.getKey();
+  String value = entry.getValue();
+  if (!customESSettings.contains(key)) {
+settingsBuilder.put(key, value);
+  }
 }
-Settings settings = settingsBuilder.build();
-TransportClient client;
-try{
+settingsBuilder.put("cluster.name", 
globalConfiguration.get("es.clustername"));
+settingsBuilder.put("client.transport.ping_timeout", 
esSettings.getOrDefault("client.transport.ping_timeout","500s"));
+setXPackSecurityOrNone(settingsBuilder, esSettings);
+
+try {
   LOG.info("Number of available processors in Netty: {}", 
NettyRuntimeWrapper.availableProcessors());
   // Netty sets available processors statically and if an attempt is 
made to set it more than
   // once an IllegalStateException is thrown by 
NettyRuntime.setAvailableProcessors(NettyRuntime.java:87)
   // 
https://discuss.elastic.co/t/getting-availableprocessors-is-already-set-to-1-rejecting-1-illegalstateexception-exception/103082
   // 
https://discuss.elastic.co/t/elasticsearch-5-4-1-availableprocessors-is-already-set/88036
   System.setProperty("es.set.netty.runtime.available.processors", 
"false");
-  client = new PreBuiltTransportClient(settings);
-  for(HostnamePort hp : getIps(globalConfiguration)) {
+  TransportClient client = 
createTransportClient(settingsBuilder.build(), esSettings);
+  for (HostnamePort hp : getIps(globalConfiguration)) {
 client.addTransportAddress(
 new 
InetSocketTransportAddress(InetAddress.getByName(hp.hostname), hp.port)
 );
   }
-} catch (UnknownHostException exception){
+  return client;
+} catch (UnknownHostException exception) {
   throw new RuntimeException(exception);
 }
-return client;
+  }
+
+  private static Map getEsSettings(Map 
config) {
+return ConversionUtils
+.convertMap((Map) 
config.getOrDefault("es.client.settings", new HashMap()),
+String.class);
+  }
+
+  private static void setXPackSecurityOrNone(Settings.Builder 
settingsBuilder, Map esSettings) {
+if (esSettings.containsKey("es.xpack.password.file")) {
--- End diff --

@nickwallen and @wardbekker - how about we do 3 things here
1. Check for both keys
```
if (esSettings.containsKey("es.xpack.username") && 
esSettings.containsKey("es.xpack.password.file"))
```
2. Warn on only 1 of the 2 required keys being present
```
else if (esSettings.containsKey("es.xpack.username") ^ 
esSettings.containsKey("es.xpack.password.file"))
```
3. Do a null/empty check on username similar to the password file
```
if (StringUtils.isEmtpy(xpackUsername) {
throw new IllegalArgumentException("X-Pack username cannot be empty");
}
```


> X-pack support for Elasticsearch
> 
>
> Key: METRON-1465
> URL: 

[jira] [Commented] (METRON-1462) Separate ES and Kibana from Metron Mpack

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424663#comment-16424663
 ] 

ASF GitHub Bot commented on METRON-1462:


Github user mmiklavc closed the pull request at:

https://github.com/apache/metron/pull/943


> Separate ES and Kibana from Metron Mpack
> 
>
> Key: METRON-1462
> URL: https://issues.apache.org/jira/browse/METRON-1462
> Project: Metron
>  Issue Type: Sub-task
>Reporter: Michael Miklavcic
>Assignee: Michael Miklavcic
>Priority: Major
>
> Need this to enable our ability to provide pluggable Solr support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (METRON-1462) Separate ES and Kibana from Metron Mpack

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424664#comment-16424664
 ] 

ASF GitHub Bot commented on METRON-1462:


GitHub user mmiklavc reopened a pull request:

https://github.com/apache/metron/pull/943

METRON-1462: Separate ES and Kibana from Metron Mpack

## Contributor Comments

https://issues.apache.org/jira/browse/METRON-1462

This splits ES and Kibana into their own MPacks. Two comments for reviewers:
- The original discuss thread mentioned putting this in metron-contrib. Are 
we dead set on this, or is my split in metron-deployment reasonable?
- I kept the Kibana templates and associated documentation in their current 
location and migrated them with the Kibana service. This is consistent with our 
current deployment and means we don't need to add a new set of features to the 
Metron MPack to publish them. A point in favor of moving this to Metron's MPack 
would be that we think this is in the purview of Metron and would make the 
Ambari design more consistent when we introduce Solr.

**Testing**
Spin up full dev and verify the Kibana dashboard is displaying information.

## Pull Request Checklist

In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
  ```
  mvn -q clean integration-test install && 
dev-utilities/build-utils/verify_licenses.sh 
  ```

- [x] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mmiklavc/metron es-mpack-split

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/943.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #943


commit f266600bf67dd11974a4c5faff7120c1b1044629
Author: Michael Miklavcic 
Date:   2018-02-21T16:58:42Z

Ready to test ES/Kibana MPack split. TODO: README updates

commit 941e767287e403873d893a304b5847033e4c9b16
Author: Michael Miklavcic 
Date:   2018-02-21T16:59:55Z

Merge branch 'master' into es-mpack-split

commit 96e4b6188b04a5518064a9a1cd59aeaf3059cdc1
Author: Michael Miklavcic 
Date:   2018-02-23T21:40:03Z

Document the ES and Kibana MPack split

commit 6c02ecea3dfde58d533b20c934641ab1e8716f7f
Author: Michael Miklavcic 
Date:   2018-04-02T16:33:31Z

Merge branch 'master' into es-mpack-split

commit d5f3bafba7bc6c24ad544e157cc8942defc58dde
Author: Michael Miklavcic 
Date:   2018-04-03T19:29:53Z

Move Kibana dashboard to Metron's MPack

commit b3bdbd375a5a7532e81a53772ab3e60b5bd85083
Author: Michael Miklavcic 
Date:   2018-04-03T21:21:38Z

fix extra command element




> Separate ES and Kibana from Metron Mpack
> 
>
> Key: METRON-1462
> URL: https://issues.apache.org/jira/browse/METRON-1462
> Project: Metron
>  Issue Type: Sub-task
>Reporter: Michael Miklavcic
>Assignee: Michael Miklavcic
>Priority: Major
>
> Need this to enable our ability to provide pluggable Solr support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] metron issue #943: METRON-1462: Separate ES and Kibana from Metron Mpack

[mmiklavc]

Github user mmiklavc commented on the issue:

https://github.com/apache/metron/pull/943
  
Kick Travis re: profiler test failure


---

[GitHub] metron pull request #943: METRON-1462: Separate ES and Kibana from Metron Mp...

[mmiklavc]

Github user mmiklavc closed the pull request at:

https://github.com/apache/metron/pull/943


---

[GitHub] metron pull request #943: METRON-1462: Separate ES and Kibana from Metron Mp...

[mmiklavc]

GitHub user mmiklavc reopened a pull request:

https://github.com/apache/metron/pull/943

METRON-1462: Separate ES and Kibana from Metron Mpack

## Contributor Comments

https://issues.apache.org/jira/browse/METRON-1462

This splits ES and Kibana into their own MPacks. Two comments for reviewers:
- The original discuss thread mentioned putting this in metron-contrib. Are 
we dead set on this, or is my split in metron-deployment reasonable?
- I kept the Kibana templates and associated documentation in their current 
location and migrated them with the Kibana service. This is consistent with our 
current deployment and means we don't need to add a new set of features to the 
Metron MPack to publish them. A point in favor of moving this to Metron's MPack 
would be that we think this is in the purview of Metron and would make the 
Ambari design more consistent when we introduce Solr.

**Testing**
Spin up full dev and verify the Kibana dashboard is displaying information.

## Pull Request Checklist

In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
  ```
  mvn -q clean integration-test install && 
dev-utilities/build-utils/verify_licenses.sh 
  ```

- [x] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mmiklavc/metron es-mpack-split

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/943.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #943


commit f266600bf67dd11974a4c5faff7120c1b1044629
Author: Michael Miklavcic 
Date:   2018-02-21T16:58:42Z

Ready to test ES/Kibana MPack split. TODO: README updates

commit 941e767287e403873d893a304b5847033e4c9b16
Author: Michael Miklavcic 
Date:   2018-02-21T16:59:55Z

Merge branch 'master' into es-mpack-split

commit 96e4b6188b04a5518064a9a1cd59aeaf3059cdc1
Author: Michael Miklavcic 
Date:   2018-02-23T21:40:03Z

Document the ES and Kibana MPack split

commit 6c02ecea3dfde58d533b20c934641ab1e8716f7f
Author: Michael Miklavcic 
Date:   2018-04-02T16:33:31Z

Merge branch 'master' into es-mpack-split

commit d5f3bafba7bc6c24ad544e157cc8942defc58dde
Author: Michael Miklavcic 
Date:   2018-04-03T19:29:53Z

Move Kibana dashboard to Metron's MPack

commit b3bdbd375a5a7532e81a53772ab3e60b5bd85083
Author: Michael Miklavcic 
Date:   2018-04-03T21:21:38Z

fix extra command element




---

[GitHub] metron issue #943: METRON-1462: Separate ES and Kibana from Metron Mpack

[mmiklavc]

Github user mmiklavc commented on the issue:

https://github.com/apache/metron/pull/943
  
I re-tested this via full dev spin-up from scratch. The dashboard comes up 
as expected.


---

[jira] [Commented] (METRON-1462) Separate ES and Kibana from Metron Mpack

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424788#comment-16424788
 ] 

ASF GitHub Bot commented on METRON-1462:


Github user mmiklavc commented on the issue:

https://github.com/apache/metron/pull/943
  
I re-tested this via full dev spin-up from scratch. The dashboard comes up 
as expected.


> Separate ES and Kibana from Metron Mpack
> 
>
> Key: METRON-1462
> URL: https://issues.apache.org/jira/browse/METRON-1462
> Project: Metron
>  Issue Type: Sub-task
>Reporter: Michael Miklavcic
>Assignee: Michael Miklavcic
>Priority: Major
>
> Need this to enable our ability to provide pluggable Solr support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] metron issue #943: METRON-1462: Separate ES and Kibana from Metron Mpack

[mmiklavc]

Github user mmiklavc commented on the issue:

https://github.com/apache/metron/pull/943
  
@ottobackwards @merrimanr @anandsubbu - I've moved the Kibana dashboard 
from the Elasticsearch MPack to the Metron one. Can you reaffirm your +1's or 
let me know if there's anything more I need to address?


---

[jira] [Commented] (METRON-1462) Separate ES and Kibana from Metron Mpack

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424662#comment-16424662
 ] 

ASF GitHub Bot commented on METRON-1462:


Github user mmiklavc commented on the issue:

https://github.com/apache/metron/pull/943
  
Kick Travis re: profiler test failure


> Separate ES and Kibana from Metron Mpack
> 
>
> Key: METRON-1462
> URL: https://issues.apache.org/jira/browse/METRON-1462
> Project: Metron
>  Issue Type: Sub-task
>Reporter: Michael Miklavcic
>Assignee: Michael Miklavcic
>Priority: Major
>
> Need this to enable our ability to provide pluggable Solr support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (METRON-1462) Separate ES and Kibana from Metron Mpack

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424658#comment-16424658
 ] 

ASF GitHub Bot commented on METRON-1462:


Github user mmiklavc commented on the issue:

https://github.com/apache/metron/pull/943
  
@ottobackwards @merrimanr @anandsubbu - I've moved the Kibana dashboard 
from the Elasticsearch MPack to the Metron one. Can you reaffirm your +1's or 
let me know if there's anything more I need to address?


> Separate ES and Kibana from Metron Mpack
> 
>
> Key: METRON-1462
> URL: https://issues.apache.org/jira/browse/METRON-1462
> Project: Metron
>  Issue Type: Sub-task
>Reporter: Michael Miklavcic
>Assignee: Michael Miklavcic
>Priority: Major
>
> Need this to enable our ability to provide pluggable Solr support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)