Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/1091
I (and I expect most in our community) would prefer separate commits. It
makes it easier to see changes you make in response to feedback. Also when I
pulled your recent commits I got a merge
[
https://issues.apache.org/jira/browse/METRON-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538519#comment-16538519
]
ASF GitHub Bot commented on METRON-1650:
Github user merrimanr commented on the issue:
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/1081
Can we merge this? Any other items you would like addressed @cestella?
---
[
https://issues.apache.org/jira/browse/METRON-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538525#comment-16538525
]
ASF GitHub Bot commented on METRON-1641:
Github user merrimanr commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538528#comment-16538528
]
ASF GitHub Bot commented on METRON-1555:
Github user merrimanr closed the pull request at:
Justin Leet created METRON-1657:
---
Summary: Parser aggregation in storm
Key: METRON-1657
URL: https://issues.apache.org/jira/browse/METRON-1657
Project: Metron
Issue Type: Bug
[
https://issues.apache.org/jira/browse/METRON-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538569#comment-16538569
]
ASF GitHub Bot commented on METRON-1655:
Github user cestella commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538571#comment-16538571
]
ASF GitHub Bot commented on METRON-1641:
Github user cestella commented on the issue:
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1081
+1, lgtm
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1084
Intermittent test failure, travis sorted now.
---
[
https://issues.apache.org/jira/browse/METRON-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538573#comment-16538573
]
ASF GitHub Bot commented on METRON-1644:
Github user cestella commented on the issue:
GitHub user justinleet opened a pull request:
https://github.com/apache/metron/pull/1099
METRON-1657: Parser aggregation in storm
## Contributor Comments
This PR allows for users to specify multiple parsers to be run in one
aggregated Storm topology.
Essentially, the
[
https://issues.apache.org/jira/browse/METRON-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538588#comment-16538588
]
ASF GitHub Bot commented on METRON-1657:
GitHub user justinleet opened a pull request:
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1099
As a heads up, this will have conflicts with
https://github.com/apache/metron/pull/1084
---
[
https://issues.apache.org/jira/browse/METRON-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538590#comment-16538590
]
ASF GitHub Bot commented on METRON-1657:
Github user justinleet commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jon Zeolla updated METRON-1658:
---
Description: We're currently running Bro 2.5.2, and two releases have come
out, both fixing some
[
https://issues.apache.org/jira/browse/METRON-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538612#comment-16538612
]
ASF GitHub Bot commented on METRON-1657:
Github user cestella commented on a diff in the pull
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1099#discussion_r201349285
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/ParserTopologyBuilder.java
---
@@ -91,14 +101,14 @@ public
[
https://issues.apache.org/jira/browse/METRON-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538616#comment-16538616
]
ASF GitHub Bot commented on METRON-1644:
Github user justinleet commented on the issue:
GitHub user justinleet reopened a pull request:
https://github.com/apache/metron/pull/1099
METRON-1657: Parser aggregation in storm
## Contributor Comments
This PR allows for users to specify multiple parsers to be run in one
aggregated Storm topology.
Essentially, the
[
https://issues.apache.org/jira/browse/METRON-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538688#comment-16538688
]
ASF GitHub Bot commented on METRON-1657:
Github user justinleet commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538690#comment-16538690
]
ASF GitHub Bot commented on METRON-1657:
GitHub user justinleet reopened a pull request:
[
https://issues.apache.org/jira/browse/METRON-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jon Zeolla reassigned METRON-1658:
--
Assignee: Jon Zeolla
> Upgrade bro to 2.5.4
>
>
> Key:
[
https://issues.apache.org/jira/browse/METRON-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538689#comment-16538689
]
ASF GitHub Bot commented on METRON-1657:
Github user justinleet closed the pull request at:
Github user justinleet closed the pull request at:
https://github.com/apache/metron/pull/1099
---
Jon Zeolla created METRON-1659:
--
Summary: The platform-info.sh should check for vagrant the
hostmanager plugin
Key: METRON-1659
URL: https://issues.apache.org/jira/browse/METRON-1659
Project: Metron
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1084
+1, once @ottobackwards is good with everything.
---
[
https://issues.apache.org/jira/browse/METRON-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538651#comment-16538651
]
ASF GitHub Bot commented on METRON-1657:
Github user justinleet commented on a diff in the pull
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/1099#discussion_r201356953
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/ParserTopologyBuilder.java
---
@@ -91,14 +101,14 @@ public
[
https://issues.apache.org/jira/browse/METRON-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538676#comment-16538676
]
ASF GitHub Bot commented on METRON-1657:
Github user cestella commented on a diff in the pull
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1099#discussion_r201361910
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/ParserTopologyBuilder.java
---
@@ -91,14 +101,14 @@ public
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1099
Kicking Travis
---
GitHub user JonZeolla opened a pull request:
https://github.com/apache/metron/pull/1100
METRON-1659: The platform-info.sh should check for vagrant the hostmanager
plugin
## Contributor Comments
Pretty self-explanitory, added a check for the hostmanager plugin to
[
https://issues.apache.org/jira/browse/METRON-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jon Zeolla updated METRON-1659:
---
Summary: The platform-info.sh should check for vagrant hostmanager plugin
(was: The
[
https://issues.apache.org/jira/browse/METRON-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538715#comment-16538715
]
ASF GitHub Bot commented on METRON-1659:
GitHub user JonZeolla opened a pull request:
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/993
Not a huge deal, but I noticed that one this one was merged it didn't
retain the JIRA reference.
---
[
https://issues.apache.org/jira/browse/METRON-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538739#comment-16538739
]
ASF GitHub Bot commented on METRON-1507:
Github user JonZeolla commented on the issue:
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1084
1 nit, other than that +1
---
[
https://issues.apache.org/jira/browse/METRON-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538979#comment-16538979
]
ASF GitHub Bot commented on METRON-1644:
Github user ottobackwards commented on a diff in the
GitHub user justinleet opened a pull request:
https://github.com/apache/metron/pull/1102
METRON-1660: On Solr, sorting by threat score fails
## Contributor Comments
Updated the metaalert schema to properly use a dynamic field for threat
triage scores, consistent with other
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/1098
---
[
https://issues.apache.org/jira/browse/METRON-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539058#comment-16539058
]
ASF GitHub Bot commented on METRON-1655:
Github user asfgit closed the pull request at:
Justin Leet created METRON-1660:
---
Summary: On Solr, sorting by threat score fails
Key: METRON-1660
URL: https://issues.apache.org/jira/browse/METRON-1660
Project: Metron
Issue Type: Bug
Ryan Merriman created METRON-1661:
-
Summary: Create Pcap Query Filter endpoint
Key: METRON-1661
URL: https://issues.apache.org/jira/browse/METRON-1661
Project: Metron
Issue Type: Sub-task
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1084#discussion_r201448152
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/message/metadata/EnvelopedRawMessageStrategy.java
---
@@ -0,0 +1,146 @@
[
https://issues.apache.org/jira/browse/METRON-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539068#comment-16539068
]
ASF GitHub Bot commented on METRON-1644:
Github user cestella commented on a diff in the pull
[
https://issues.apache.org/jira/browse/METRON-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539066#comment-16539066
]
ASF GitHub Bot commented on METRON-1562:
Github user cestella commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538876#comment-16538876
]
ASF GitHub Bot commented on METRON-1658:
GitHub user JonZeolla opened a pull request:
GitHub user JonZeolla opened a pull request:
https://github.com/apache/metron/pull/1101
METRON-1658: Upgrade bro to 2.5.4
## Contributor Comments
This upgrades bro to 2.5.4. The changes are all security or bugfix related
and shouldn't impact anything in the way of Metron
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1084#discussion_r201426118
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/message/metadata/EnvelopedRawMessageStrategy.java
---
@@ -0,0 +1,146
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1094
+1 by inspection
---
[
https://issues.apache.org/jira/browse/METRON-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539094#comment-16539094
]
ASF GitHub Bot commented on METRON-1660:
GitHub user justinleet opened a pull request:
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1101
+1 by inspection
---
[
https://issues.apache.org/jira/browse/METRON-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539138#comment-16539138
]
ASF GitHub Bot commented on METRON-1658:
Github user cestella commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539201#comment-16539201
]
ASF GitHub Bot commented on METRON-1364:
Github user cestella commented on the issue:
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/870
Thanks @JonZeolla I am planning to try to get around to cleaning this up a
bit this week. I have some concerns about its interactions with the sampling
stellar functions.
---
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/870
Happy to put some effort into running through this/testing if it's ready to
go @cestella
---
[
https://issues.apache.org/jira/browse/METRON-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539183#comment-16539183
]
ASF GitHub Bot commented on METRON-1364:
Github user JonZeolla commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539140#comment-16539140
]
ASF GitHub Bot commented on METRON-1660:
Github user cestella commented on the issue:
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1102
+1 by inspection
---
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/1084
---
[
https://issues.apache.org/jira/browse/METRON-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539189#comment-16539189
]
ASF GitHub Bot commented on METRON-1644:
Github user asfgit closed the pull request at:
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1065
@mmiklavc Can we get this merged?
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1097
+1 by inspection
---
[
https://issues.apache.org/jira/browse/METRON-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539193#comment-16539193
]
ASF GitHub Bot commented on METRON-1641:
Github user cestella commented on the issue:
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1081
@mmiklavc can you merge and close this PR?
---
[
https://issues.apache.org/jira/browse/METRON-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539192#comment-16539192
]
ASF GitHub Bot commented on METRON-1620:
Github user cestella commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539197#comment-16539197
]
ASF GitHub Bot commented on METRON-1656:
Github user cestella commented on the issue:
Github user mmiklavc closed the pull request at:
https://github.com/apache/metron/pull/1081
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/1081
Committed to the feature branch.
---
[
https://issues.apache.org/jira/browse/METRON-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539432#comment-16539432
]
ASF GitHub Bot commented on METRON-1641:
Github user mmiklavc commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539433#comment-16539433
]
ASF GitHub Bot commented on METRON-1641:
Github user mmiklavc closed the pull request at:
[
https://issues.apache.org/jira/browse/METRON-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539497#comment-16539497
]
ASF GitHub Bot commented on METRON-1650:
Github user jameslamb commented on the issue:
Github user jameslamb commented on the issue:
https://github.com/apache/metron/pull/1091
@merrimanr thank you, understood. I will try to reproduce the issue on my
end and see if I can find what is failing.
---
74 matches
Mail list logo
