[jira] [Commented] (METRON-1421) Create a SolrMetaAlertDao

2018-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469786#comment-16469786 ] ASF GitHub Bot commented on METRON-1421: Github user justinleet commented on the

[GitHub] metron issue #970: METRON-1421: Create a SolrMetaAlertDao

2018-05-09 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/970 @merrimanr I'll add a couple tests for those and see if I can get them reproduced. Since some of that is in the AbstractLucene dao I'm wondering if it also happens against master ES. When I take

[jira] [Commented] (METRON-1421) Create a SolrMetaAlertDao

2018-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469783#comment-16469783 ] ASF GitHub Bot commented on METRON-1421: Github user justinleet commented on the

[GitHub] metron issue #970: METRON-1421: Create a SolrMetaAlertDao

2018-05-09 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/970 @mmiklavc I'm also inclined to work on that fix against master, since it effects current ES metaalerts. Seem reasonable? ---

[jira] [Commented] (METRON-1421) Create a SolrMetaAlertDao

2018-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469778#comment-16469778 ] ASF GitHub Bot commented on METRON-1421: Github user justinleet commented on the

[GitHub] metron issue #970: METRON-1421: Create a SolrMetaAlertDao

2018-05-09 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/970 @mmiklavc Re: The index issue appears to be preexisting. https://github.com/apache/metron/blob/feature/METRON-1416-upgrade-solr/metron-platform/metron-solr/src/main/java/org/apache/metron/solr

[jira] [Commented] (METRON-1489) Retrofit UI tests to run reliably during nightly QE runs

2018-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469602#comment-16469602 ] ASF GitHub Bot commented on METRON-1489: Github user nickwallen commented on the

[GitHub] metron issue #1004: METRON-1489: Retrofit UI tests to run reliably

2018-05-09 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1004 @sardell What is the status of this? Are you happy with what you have? I was able to run the e2e tests successfully without any interventions this time. It took a couple of automated re

[jira] [Commented] (METRON-1421) Create a SolrMetaAlertDao

2018-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469582#comment-16469582 ] ASF GitHub Bot commented on METRON-1421: Github user merrimanr commented on the i

[GitHub] metron issue #970: METRON-1421: Create a SolrMetaAlertDao

2018-05-09 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/970 I spun this up in full dev and ran through all the tests in the test plan above. Everything in this plan worked. I also added a step in each test to perform a search on alert fields and verified

[GitHub] metron issue #970: METRON-1421: Create a SolrMetaAlertDao

2018-05-09 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/970 Just finished testing this in full dev. Everything basically looks good. I'll take another spin through the source code as well. This is a good test script @justinleet. Here are my finding

[jira] [Commented] (METRON-1421) Create a SolrMetaAlertDao

2018-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469561#comment-16469561 ] ASF GitHub Bot commented on METRON-1421: Github user mmiklavc commented on the is

[jira] [Commented] (METRON-1541) Mvn clean results in git status having deleted files.

2018-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469479#comment-16469479 ] ASF GitHub Bot commented on METRON-1541: Github user asfgit closed the pull reque

[GitHub] metron pull request #1003: METRON-1541: Mvn clean results in git status havi...

2018-05-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1003 ---

[jira] [Commented] (METRON-1541) Mvn clean results in git status having deleted files.

2018-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469478#comment-16469478 ] ASF GitHub Bot commented on METRON-1541: Github user nickwallen commented on the

[GitHub] metron issue #1003: METRON-1541: Mvn clean results in git status having dele...

2018-05-09 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1003 Sorry for the delay. My email filters are clearly filtering out my Github notifications. ---

[jira] [Commented] (METRON-1541) Mvn clean results in git status having deleted files.

2018-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469474#comment-16469474 ] ASF GitHub Bot commented on METRON-1541: Github user nickwallen commented on the

[GitHub] metron issue #1003: METRON-1541: Mvn clean results in git status having dele...

2018-05-09 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1003 > @justinleet Are we good to kill the old enrichment.properties.j2 files? Yes, I should have deleted that file in #984 . Thanks @justinleet for the clean-up on this. The enri

[jira] [Commented] (METRON-1461) MIN MAX stellar function should take a stats or list object and return min/max

2018-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469445#comment-16469445 ] ASF GitHub Bot commented on METRON-1461: Github user asfgit closed the pull reque

[GitHub] metron pull request #942: METRON-1461: Modify the MIN, MAX Stellar methods t...

2018-05-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/942 ---

[jira] [Commented] (METRON-1549) Add empty object test to WriterBoltIntegrationTest implementation

2018-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469421#comment-16469421 ] ASF GitHub Bot commented on METRON-1549: Github user nickwallen commented on a di

[jira] [Commented] (METRON-1549) Add empty object test to WriterBoltIntegrationTest implementation

2018-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469420#comment-16469420 ] ASF GitHub Bot commented on METRON-1549: Github user nickwallen commented on a di

[GitHub] metron pull request #1009: METRON-1549: Add empty object test to WriterBoltI...

2018-05-09 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1009#discussion_r187162573 --- Diff: metron-platform/metron-parsers/src/test/java/org/apache/metron/writers/integration/WriterBoltIntegrationTest.java --- @@ -88,9 +108,7 @@ publi

[jira] [Commented] (METRON-1549) Add empty object test to WriterBoltIntegrationTest implementation

2018-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469419#comment-16469419 ] ASF GitHub Bot commented on METRON-1549: Github user nickwallen commented on a di

[GitHub] metron pull request #1009: METRON-1549: Add empty object test to WriterBoltI...

2018-05-09 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1009#discussion_r187160397 --- Diff: metron-platform/metron-parsers/src/test/java/org/apache/metron/writers/integration/WriterBoltIntegrationTest.java --- @@ -166,6 +185,139 @@ pu

[GitHub] metron pull request #1009: METRON-1549: Add empty object test to WriterBoltI...

2018-05-09 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1009#discussion_r187161369 --- Diff: metron-platform/metron-parsers/src/test/java/org/apache/metron/writers/integration/WriterBoltIntegrationTest.java --- @@ -166,6 +185,139 @@ pu

[jira] [Commented] (METRON-1090) STELLAR Add Assignment capability to Stellar language

2018-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469313#comment-16469313 ] ASF GitHub Bot commented on METRON-1090: Github user cestella commented on the is

[GitHub] metron issue #687: METRON-1090 [DISCUSS] Add Assignment to Stellar Language

2018-05-09 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/687 I think I have a minor preference for 2, honestly. I like this work and don't want it to languish or grow too big. Entirely as an aside, we should probably have a set of microbenchmark tests for s

[GitHub] metron issue #687: METRON-1090 [DISCUSS] Add Assignment to Stellar Language

2018-05-09 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/687 Ok, so we are on the same page. I purposely did not put the update in the map resolver because I knew it warranted more discussion etc, and this is it. I just wasn't sure I was understanding

[jira] [Commented] (METRON-1090) STELLAR Add Assignment capability to Stellar language

2018-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469303#comment-16469303 ] ASF GitHub Bot commented on METRON-1090: Github user ottobackwards commented on t

[GitHub] metron issue #687: METRON-1090 [DISCUSS] Add Assignment to Stellar Language

2018-05-09 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/687 So, I guess I'm suggesting that this is like..3/4 of the way to a complete solution, which is for stellar to handle variable assignments completely. Specifically, I'd say that our dominant

[jira] [Commented] (METRON-1090) STELLAR Add Assignment capability to Stellar language

2018-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469278#comment-16469278 ] ASF GitHub Bot commented on METRON-1090: Github user cestella commented on the is

[jira] [Commented] (METRON-1184) EC2 Deployment - Updating control_path to accommodate for Linux

2018-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469256#comment-16469256 ] ASF GitHub Bot commented on METRON-1184: Github user ottobackwards commented on t

[GitHub] metron issue #754: METRON-1184 EC2 Deployment - Updating control_path to acc...

2018-05-09 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/754 Thanks for the contribution! Please take care of the Jira ---

[jira] [Commented] (METRON-1184) EC2 Deployment - Updating control_path to accommodate for Linux

2018-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469255#comment-16469255 ] ASF GitHub Bot commented on METRON-1184: Github user asfgit closed the pull reque

[GitHub] metron pull request #754: METRON-1184 EC2 Deployment - Updating control_path...

2018-05-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/754 ---

[jira] [Commented] (METRON-1184) EC2 Deployment - Updating control_path to accommodate for Linux

2018-05-09 Thread Ahmed Shah (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469249#comment-16469249 ] Ahmed Shah commented on METRON-1184: Horray!!! Ahmed Shah > EC2 Deployment - Upda

[jira] [Commented] (METRON-1184) EC2 Deployment - Updating control_path to accommodate for Linux

2018-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469239#comment-16469239 ] ASF GitHub Bot commented on METRON-1184: Github user ottobackwards commented on t

[GitHub] metron issue #754: METRON-1184 EC2 Deployment - Updating control_path to acc...

2018-05-09 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/754 @as22323 I need a real name to use in the commit ---

[jira] [Commented] (METRON-1184) EC2 Deployment - Updating control_path to accommodate for Linux

2018-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469235#comment-16469235 ] ASF GitHub Bot commented on METRON-1184: Github user ottobackwards commented on t

[GitHub] metron issue #754: METRON-1184 EC2 Deployment - Updating control_path to acc...

2018-05-09 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/754 +1 - i'll merge ---

[jira] [Commented] (METRON-1090) STELLAR Add Assignment capability to Stellar language

2018-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469063#comment-16469063 ] ASF GitHub Bot commented on METRON-1090: Github user ottobackwards commented on t

[GitHub] metron issue #687: METRON-1090 Add Assignment to Stellar Language

2018-05-09 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/687 I don't quite get what you are saying. I can't wrap my head around it. If you look at the example from the PR description under concept, that doesn't work without the resolver being updated.

[jira] [Updated] (METRON-1396) Fix .gitignore files to not ignore themselves

2018-05-09 Thread Justin Leet (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Leet updated METRON-1396: Fix Version/s: Next + 1 > Fix .gitignore files to not ignore themselves > -

[jira] [Updated] (METRON-1411) Fix sed command in Upgrading.md

2018-05-09 Thread Justin Leet (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Leet updated METRON-1411: Fix Version/s: Next + 1 > Fix sed command in Upgrading.md > --- > >

[jira] [Commented] (METRON-1090) STELLAR Add Assignment capability to Stellar language

2018-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468992#comment-16468992 ] ASF GitHub Bot commented on METRON-1090: Github user cestella commented on the is

[GitHub] metron issue #687: METRON-1090 Add Assignment to Stellar Language

2018-05-09 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/687 Sorry, @ottobackwards this got lost in the shuffle. What I was saying was that I think we should not adjust the VariableResolver infrastructure to update variables as the result of assignments, bu

[jira] [Commented] (METRON-1530) Default proxy config settings in metron-contrib need to be updated

2018-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468921#comment-16468921 ] ASF GitHub Bot commented on METRON-1530: Github user asfgit closed the pull reque

[GitHub] metron pull request #998: METRON-1530: Default proxy config settings in metr...

2018-05-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/998 ---

[jira] [Commented] (METRON-1530) Default proxy config settings in metron-contrib need to be updated

2018-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468917#comment-16468917 ] ASF GitHub Bot commented on METRON-1530: Github user merrimanr commented on the i

[GitHub] metron issue #998: METRON-1530: Default proxy config settings in metron-cont...

2018-05-09 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/998 Yes +1 from me. ---

[jira] [Commented] (METRON-1530) Default proxy config settings in metron-contrib need to be updated

2018-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468910#comment-16468910 ] ASF GitHub Bot commented on METRON-1530: Github user simonellistonball commented

[GitHub] metron issue #998: METRON-1530: Default proxy config settings in metron-cont...

2018-05-09 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/998 LGTM @merrimanr are you +1 on this now? ---

[jira] [Commented] (METRON-1532) Getting started documentation improvements

2018-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468908#comment-16468908 ] ASF GitHub Bot commented on METRON-1532: Github user simonellistonball commented

[GitHub] metron pull request #1001: METRON-1532: Getting started documentation improv...

2018-05-09 Thread simonellistonball
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/1001#discussion_r187058040 --- Diff: metron-deployment/development/centos6/README.md --- @@ -103,3 +103,8 @@ Tags are listed in the playbooks, some frequently used tags:

[jira] [Commented] (METRON-1549) Add empty object test to WriterBoltIntegrationTest implementation

2018-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468905#comment-16468905 ] ASF GitHub Bot commented on METRON-1549: Github user simonellistonball commented

[GitHub] metron issue #1009: 1549: Add empty object test to WriterBoltIntegrationTest...

2018-05-09 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1009 Looks like a typo on the title of the PR... "METRON-1549" ---

[jira] [Commented] (METRON-854) Create DHCPDump Parser

2018-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468617#comment-16468617 ] ASF GitHub Bot commented on METRON-854: --- Github user basvdl commented on the issue:

[GitHub] metron pull request #531: METRON-854 create dhcp dump parser

2018-05-09 Thread basvdl
Github user basvdl closed the pull request at: https://github.com/apache/metron/pull/531 ---

[jira] [Commented] (METRON-854) Create DHCPDump Parser

2018-05-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468618#comment-16468618 ] ASF GitHub Bot commented on METRON-854: --- Github user basvdl closed the pull request

[GitHub] metron issue #531: METRON-854 create dhcp dump parser

2018-05-09 Thread basvdl
Github user basvdl commented on the issue: https://github.com/apache/metron/pull/531 Closing PR, since we don't want to change the source code of DHCPdump. Bro should be able to deliver the same functionality. ---