[
https://issues.apache.org/jira/browse/METRON-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469421#comment-16469421
]
ASF GitHub Bot commented on METRON-1549:
----------------------------------------
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1009#discussion_r187162573
--- Diff:
metron-platform/metron-parsers/src/test/java/org/apache/metron/writers/integration/WriterBoltIntegrationTest.java
---
@@ -88,9 +108,7 @@ public void initialize(Map<String, Object>
validationConfig, Map<String, Object>
public static String parserConfigJSON;
@Test
- public void test() throws UnableToStartException, IOException,
ParseException {
-
- UnitTestHelper.setLog4jLevel(CSVParser.class,
org.apache.log4j.Level.FATAL);
+ public void
parser_with_global_validations_writes_bad_records_to_error_topic() throws
Exception {
--- End diff --
Maybe just a brief javadoc would help here. I have to read a lot of code
to understand what each of these tests are trying to do. One sentence of
javadoc would save me some time.
> Add empty object test to WriterBoltIntegrationTest implementation
> -----------------------------------------------------------------
>
> Key: METRON-1549
> URL: https://issues.apache.org/jira/browse/METRON-1549
> Project: Metron
> Issue Type: Test
> Reporter: Michael Miklavcic
> Assignee: Michael Miklavcic
> Priority: Major
>
> Verify expected output when empty objects returned by custom parsers.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
