[GitHub] JonZeolla commented on issue #23: [DEPENDS ON METRON-1910] METRON-1992: Support sending a log to multiple topics

JonZeolla commented on issue #23: [DEPENDS ON METRON-1910] METRON-1992: Support sending a log to multiple topics URL: https://github.com/apache/metron-bro-plugin-kafka/pull/23#issuecomment-463016771 Whups, it looks like I had butchered README earlier. That most recent commit should fix

[GitHub] ottobackwards commented on issue #20: METRON-1910: bro plugin segfaults on src/KafkaWriter.cc:72

ottobackwards commented on issue #20: METRON-1910: bro plugin segfaults on src/KafkaWriter.cc:72 URL: https://github.com/apache/metron-bro-plugin-kafka/pull/20#issuecomment-462993968 No I won't, this looks good to me, ran with docker, didn't see the error messages +1

[GitHub] merrimanr commented on a change in pull request #1335: METRON-1998: Only one sensor is flushed by tick tuple

merrimanr commented on a change in pull request #1335: METRON-1998: Only one sensor is flushed by tick tuple URL: https://github.com/apache/metron/pull/1335#discussion_r256192174 ## File path:

[GitHub] ottobackwards edited a comment on issue #20: METRON-1910: bro plugin segfaults on src/KafkaWriter.cc:72

ottobackwards edited a comment on issue #20: METRON-1910: bro plugin segfaults on src/KafkaWriter.cc:72 URL: https://github.com/apache/metron-bro-plugin-kafka/pull/20#issuecomment-462974152 So after review: The issue is that bro is calling finish and deleting the objects, and then later

[GitHub] ottobackwards edited a comment on issue #20: METRON-1910: bro plugin segfaults on src/KafkaWriter.cc:72

ottobackwards edited a comment on issue #20: METRON-1910: bro plugin segfaults on src/KafkaWriter.cc:72 URL: https://github.com/apache/metron-bro-plugin-kafka/pull/20#issuecomment-462972595 @nickwallen deleting something twice is an error. ```cpp #include int main() {

[GitHub] ottobackwards commented on issue #20: METRON-1910: bro plugin segfaults on src/KafkaWriter.cc:72

ottobackwards commented on issue #20: METRON-1910: bro plugin segfaults on src/KafkaWriter.cc:72 URL: https://github.com/apache/metron-bro-plugin-kafka/pull/20#issuecomment-462974152 So after review: The issue is that bro is calling finish and deleting the objects, and then later the

[GitHub] ottobackwards commented on issue #20: METRON-1910: bro plugin segfaults on src/KafkaWriter.cc:72

ottobackwards commented on issue #20: METRON-1910: bro plugin segfaults on src/KafkaWriter.cc:72 URL: https://github.com/apache/metron-bro-plugin-kafka/pull/20#issuecomment-462972595 @nickwallen deleting something twice is an error. ```cpp #include int main() {

[GitHub] JonZeolla commented on issue #23: [DEPENDS ON METRON-1910] METRON-1992: Support sending a log to multiple topics

JonZeolla commented on issue #23: [DEPENDS ON METRON-1910] METRON-1992: Support sending a log to multiple topics URL: https://github.com/apache/metron-bro-plugin-kafka/pull/23#issuecomment-462964591 I'm running this in my prod environment, no issues. Also replicated the fix in docker,

[GitHub] JonZeolla edited a comment on issue #23: [DEPENDS ON METRON-1910] METRON-1992: Support sending a log to multiple topics

JonZeolla edited a comment on issue #23: [DEPENDS ON METRON-1910] METRON-1992: Support sending a log to multiple topics URL: https://github.com/apache/metron-bro-plugin-kafka/pull/23#issuecomment-461897366 By the way, I found the following patch to

[GitHub] JonZeolla edited a comment on issue #23: [DEPENDS ON METRON-1910] METRON-1992: Support sending a log to multiple topics

JonZeolla edited a comment on issue #23: [DEPENDS ON METRON-1910] METRON-1992: Support sending a log to multiple topics URL: https://github.com/apache/metron-bro-plugin-kafka/pull/23#issuecomment-461897366 By the way, I found the following helpful when validating this works via docker.

[GitHub] ottobackwards commented on issue #24: METRON-2000: Fix bro plugin docker line counting for BRO_COUNT

ottobackwards commented on issue #24: METRON-2000: Fix bro plugin docker line counting for BRO_COUNT URL: https://github.com/apache/metron-bro-plugin-kafka/pull/24#issuecomment-462905374 +1, thanks! This is an automated

[GitHub] ottobackwards commented on issue #1330: METRON-1968: Messages are lost when a parser produces multiple messages and batch size is greater than 1

ottobackwards commented on issue #1330: METRON-1968: Messages are lost when a parser produces multiple messages and batch size is greater than 1 URL: https://github.com/apache/metron/pull/1330#issuecomment-462904714 really like that last change @merrimanr, nice

[GitHub] merrimanr commented on a change in pull request #1331: METRON-1993: Stellar REST_GET should handle responses when content length is less than zero

merrimanr commented on a change in pull request #1331: METRON-1993: Stellar REST_GET should handle responses when content length is less than zero URL: https://github.com/apache/metron/pull/1331#discussion_r256110527 ## File path:

[GitHub] merrimanr commented on issue #1331: METRON-1993: Stellar REST_GET should handle responses when content length is less than zero

merrimanr commented on issue #1331: METRON-1993: Stellar REST_GET should handle responses when content length is less than zero URL: https://github.com/apache/metron/pull/1331#issuecomment-462899309 The latest commit adds an optional check for the content length.

[GitHub] ottobackwards commented on issue #24: METRON-2000: Fix bro plugin docker line counting for BRO_COUNT

ottobackwards commented on issue #24: METRON-2000: Fix bro plugin docker line counting for BRO_COUNT URL: https://github.com/apache/metron-bro-plugin-kafka/pull/24#issuecomment-462898246 Tests all work like a champ now, good work. My +1 is waiting on the comments.

[GitHub] merrimanr commented on a change in pull request #1335: METRON-1998: Only one sensor is flushed by tick tuple

merrimanr commented on a change in pull request #1335: METRON-1998: Only one sensor is flushed by tick tuple URL: https://github.com/apache/metron/pull/1335#discussion_r256098100 ## File path:

[GitHub] merrimanr commented on issue #1330: METRON-1968: Messages are lost when a parser produces multiple messages and batch size is greater than 1

merrimanr commented on issue #1330: METRON-1968: Messages are lost when a parser produces multiple messages and batch size is greater than 1 URL: https://github.com/apache/metron/pull/1330#issuecomment-462882719 The latest commit converts `Map` to `List>` in the `BulkMessageWriter.write`

[GitHub] mmiklavc commented on a change in pull request #1335: METRON-1998: Only one sensor is flushed by tick tuple

mmiklavc commented on a change in pull request #1335: METRON-1998: Only one sensor is flushed by tick tuple URL: https://github.com/apache/metron/pull/1335#discussion_r256090130 ## File path:

[jira] [Updated] (METRON-2000) Fix bro plugin docker line counting for BRO_COUNT

[ https://issues.apache.org/jira/browse/METRON-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Zeolla updated METRON-2000: --- Summary: Fix bro plugin docker line counting for BRO_COUNT (was: Bro plugin docker tests fail for

[GitHub] nickwallen commented on issue #1305: METRON-1940:Check if not and install Elastic search templates / Solr collections when indexing server is restarted

nickwallen commented on issue #1305: METRON-1940:Check if not and install Elastic search templates / Solr collections when indexing server is restarted URL: https://github.com/apache/metron/pull/1305#issuecomment-462869887 I think this is looking good @MohanDV . Can you describe a set of

[jira] [Created] (METRON-2000) Bro plugin docker tests fail for x509 and http

Jon Zeolla created METRON-2000: -- Summary: Bro plugin docker tests fail for x509 and http Key: METRON-2000 URL: https://issues.apache.org/jira/browse/METRON-2000 Project: Metron Issue Type:

[jira] [Updated] (METRON-1964) Update metron-bro-plugin-kafka tests to use bro 2.6

[ https://issues.apache.org/jira/browse/METRON-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Zeolla updated METRON-1964: --- Description: We should update any metron-bro-plugin-kafka tests to use bro 2.6 (post-plugin 0.3

[GitHub] nickwallen commented on issue #1333: METRON-1996 : Index search using group for Solr throws NPE if the group parameter is null

nickwallen commented on issue #1333: METRON-1996 : Index search using group for Solr throws NPE if the group parameter is null URL: https://github.com/apache/metron/pull/1333#issuecomment-462862183 And under what conditions do we submit a request that triggers this problem? Is there some

[GitHub] nickwallen commented on issue #1333: METRON-1996 : Index search using group for Solr throws NPE if the group parameter is null

nickwallen commented on issue #1333: METRON-1996 : Index search using group for Solr throws NPE if the group parameter is null URL: https://github.com/apache/metron/pull/1333#issuecomment-462861329 Thanks @MohanDV . Can you include instructions for testing this out?

[jira] [Updated] (METRON-1985) Improve Error Handling When Cannot Connect to HBase

[ https://issues.apache.org/jira/browse/METRON-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Allen updated METRON-1985: --- Fix Version/s: Next + 1 > Improve Error Handling When Cannot Connect to HBase >

[GitHub] mmiklavc commented on a change in pull request #1331: METRON-1993: Stellar REST_GET should handle responses when content length is less than zero

mmiklavc commented on a change in pull request #1331: METRON-1993: Stellar REST_GET should handle responses when content length is less than zero URL: https://github.com/apache/metron/pull/1331#discussion_r256065405 ## File path:

[jira] [Updated] (METRON-1970) Add Metadata to Error Messages Generated During Parsing

[ https://issues.apache.org/jira/browse/METRON-1970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Allen updated METRON-1970: --- Fix Version/s: Next + 1 > Add Metadata to Error Messages Generated During Parsing >

[jira] [Updated] (METRON-1974) Batch Profiler Should Handle Errant Profiles Better

[ https://issues.apache.org/jira/browse/METRON-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Allen updated METRON-1974: --- Fix Version/s: Next + 1 > Batch Profiler Should Handle Errant Profiles Better >

[GitHub] asfgit closed pull request #1327: METRON-1985 Improve Error Handling When Cannot Connect to HBase

asfgit closed pull request #1327: METRON-1985 Improve Error Handling When Cannot Connect to HBase URL: https://github.com/apache/metron/pull/1327 This is an automated message from the Apache Git Service. To respond to the

[GitHub] asfgit closed pull request #1326: METRON-1974 Batch Profiler Should Handle Errant Profiles Better

asfgit closed pull request #1326: METRON-1974 Batch Profiler Should Handle Errant Profiles Better URL: https://github.com/apache/metron/pull/1326 This is an automated message from the Apache Git Service. To respond to the

[GitHub] asfgit closed pull request #1325: METRON-1970 Add Metadata to Error Messages Generated During Parsing

asfgit closed pull request #1325: METRON-1970 Add Metadata to Error Messages Generated During Parsing URL: https://github.com/apache/metron/pull/1325 This is an automated message from the Apache Git Service. To respond to

[jira] [Created] (METRON-1999) Adding validation against special characters to parser name field

Tibor Meller created METRON-1999: Summary: Adding validation against special characters to parser name field Key: METRON-1999 URL: https://issues.apache.org/jira/browse/METRON-1999 Project: Metron

[GitHub] justinleet commented on issue #1325: METRON-1970 Add Metadata to Error Messages Generated During Parsing

justinleet commented on issue #1325: METRON-1970 Add Metadata to Error Messages Generated During Parsing URL: https://github.com/apache/metron/pull/1325#issuecomment-462838439 +1, thanks for the contribution! This is an

[GitHub] merrimanr opened a new pull request #1335: METRON-1998: Only one sensor is flushed by tick tuple

merrimanr opened a new pull request #1335: METRON-1998: Only one sensor is flushed by tick tuple URL: https://github.com/apache/metron/pull/1335 ## Contributor Comments This PR fixes the bug described in the Jira by removing the incorrect return statement. I also added a unit test to

[GitHub] merrimanr closed pull request #1335: METRON-1998: Only one sensor is flushed by tick tuple

merrimanr closed pull request #1335: METRON-1998: Only one sensor is flushed by tick tuple URL: https://github.com/apache/metron/pull/1335 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] justinleet commented on a change in pull request #1335: METRON-1998: Only one sensor is flushed by tick tuple

justinleet commented on a change in pull request #1335: METRON-1998: Only one sensor is flushed by tick tuple URL: https://github.com/apache/metron/pull/1335#discussion_r256032128 ## File path:

[GitHub] merrimanr commented on a change in pull request #1331: METRON-1993: Stellar REST_GET should handle responses when content length is less than zero

merrimanr commented on a change in pull request #1331: METRON-1993: Stellar REST_GET should handle responses when content length is less than zero URL: https://github.com/apache/metron/pull/1331#discussion_r256017953 ## File path:

[GitHub] merrimanr commented on issue #1335: METRON-1998: Only one sensor is flushed by tick tuple

merrimanr commented on issue #1335: METRON-1998: Only one sensor is flushed by tick tuple URL: https://github.com/apache/metron/pull/1335#issuecomment-462806877 Latest commit changes the flushTimeouts method to use the real `BulkWriterComponent.flush` method. This will throw the

[GitHub] justinleet commented on a change in pull request #1331: METRON-1993: Stellar REST_GET should handle responses when content length is less than zero

justinleet commented on a change in pull request #1331: METRON-1993: Stellar REST_GET should handle responses when content length is less than zero URL: https://github.com/apache/metron/pull/1331#discussion_r255986967 ## File path:

[GitHub] merrimanr commented on a change in pull request #1335: METRON-1998: Only one sensor is flushed by tick tuple

merrimanr commented on a change in pull request #1335: METRON-1998: Only one sensor is flushed by tick tuple URL: https://github.com/apache/metron/pull/1335#discussion_r255978097 ## File path:

[GitHub] MohanDV commented on a change in pull request #1335: METRON-1998: Only one sensor is flushed by tick tuple

MohanDV commented on a change in pull request #1335: METRON-1998: Only one sensor is flushed by tick tuple URL: https://github.com/apache/metron/pull/1335#discussion_r255974233 ## File path:

[GitHub] nickwallen removed a comment on issue #1335: METRON-1998: Only one sensor is flushed by tick tuple

nickwallen removed a comment on issue #1335: METRON-1998: Only one sensor is flushed by tick tuple URL: https://github.com/apache/metron/pull/1335#issuecomment-462532334 +1 from me. Thanks for finding this bug! This addresses the most urgent portion of the problem. We can

[GitHub] nickwallen commented on a change in pull request #1335: METRON-1998: Only one sensor is flushed by tick tuple

nickwallen commented on a change in pull request #1335: METRON-1998: Only one sensor is flushed by tick tuple URL: https://github.com/apache/metron/pull/1335#discussion_r255969776 ## File path:

[GitHub] nickwallen commented on a change in pull request #1335: METRON-1998: Only one sensor is flushed by tick tuple

nickwallen commented on a change in pull request #1335: METRON-1998: Only one sensor is flushed by tick tuple URL: https://github.com/apache/metron/pull/1335#discussion_r255969428 ## File path:

[GitHub] MohanDV commented on a change in pull request #1335: METRON-1998: Only one sensor is flushed by tick tuple

MohanDV commented on a change in pull request #1335: METRON-1998: Only one sensor is flushed by tick tuple URL: https://github.com/apache/metron/pull/1335#discussion_r255929330 ## File path: