Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1268
This looks good to me. Good catch, +1 by inspection.
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1242
Just chiming in here in support of taking some care around javadoc. I tend
to agree that it goes stale and it can become misleading. I think the metric
(and this is just personal opinion here
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1014
Ok, this looks good. +1 to go to the feature branch
---
Github user cestella closed the pull request at:
https://github.com/apache/metron/pull/870
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1175
This looks good to me; I'm +1 on it by inspection. Good job, otto ;)
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1171#discussion_r213704549
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/paloalto/README.md
---
@@ -0,0 +1,15
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1178
This is really good work, @nickwallen. I'm +1 by inspection here, pending
@JonZeolla's +1
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1176
+1 by inspection pending full-dev validation.
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1134
Should this be closed out?
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1175#discussion_r213670531
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/syslog/Syslog5424Parser.java
---
@@ -0,0 +1,75
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1175#discussion_r213669448
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/syslog/Syslog5424Parser.java
---
@@ -0,0 +1,75
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1091
This gets a +1 from me too, great job!
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1052
+1 by inspection
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1131
+1 by inspection
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1130
+1 by inspection.
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1128
+1 by inspection
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1124
+1 by inspection; this puts a nice bow on the backend.
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1125
+1 by inspection
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1126
Ok, I spun this up in full-dev and smoketested the UIs that these licenses
touch.
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1122
Due to a bug in apache rat, our license checking component, it's ignoring
all license checks on typescript files. I have submitted a PR to up the rat
plugin version and have fixed it in m
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1118
Due to a bug in apache rat, our license checking component, it's ignoring
all license checks on typescript files. I have submitted a PR to up the rat
plugin version and have fixed it in m
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1121
Due to a bug in apache rat, our license checking component, it's ignoring
all license checks on typescript files. I have submitted a PR to up the rat
plugin version and have fixed it in m
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1119
Due to a bug in apache rat, our license checking component, it's ignoring
all license checks on typescript files. I have submitted a PR to up the rat
plugin version and have fixed it in m
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1103
I have submitted a PR to up the rat plugin version and have fixed it in
master #1126, let's make sure to add license headers here for new files added
in this branch though.
---
GitHub user cestella opened a pull request:
https://github.com/apache/metron/pull/1126
METRON-1687: Upgrade the rat plugin to 0.13-SNAPSHOT
## Contributor Comments
Due to https://issues.apache.org/jira/browse/RAT-234, the rat plugin is not
checking the typescript files for
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1103#discussion_r204137924
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-list/pcap-list.component.spec.ts
---
@@ -0,0 +1,53 @@
+import { async, ComponentFixture
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1103#discussion_r204138341
--- Diff:
metron-interface/metron-alerts/src/app/pcap/service/pcap.service.spec.ts ---
@@ -0,0 +1,1735 @@
+import { TestBed, async, inject } from
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1103#discussion_r204138476
--- Diff:
metron-interface/metron-alerts/src/app/pcap/service/pcap.service.ts ---
@@ -0,0 +1,10186 @@
+import {Injectable, NgZone} from '@angular
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1103#discussion_r204137964
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-list/pcap-list.component.ts ---
@@ -0,0 +1,22 @@
+import { Component, OnInit, Input } from
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1103#discussion_r204138121
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-packet-line/pcap-packet-line.component.spec.ts
---
@@ -0,0 +1,1266 @@
+import { async
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1103#discussion_r204138294
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-panel/pcap-panel.component.ts
---
@@ -0,0 +1,65 @@
+import { Component, OnInit, Input
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1103#discussion_r204137868
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts
---
@@ -0,0 +1,24 @@
+import { Component, OnInit, Input
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1103#discussion_r204138196
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-packet/pcap-packet.component.ts
---
@@ -0,0 +1,22 @@
+import { Component, OnInit, Input
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1103#discussion_r204137821
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.spec.ts
---
@@ -0,0 +1,29 @@
+import { async
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1103#discussion_r204138081
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-packet-line/pcap-packet-line.component.ts
---
@@ -0,0 +1,38 @@
+import { Component, OnInit
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1103#discussion_r204138244
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-panel/pcap-panel.component.spec.ts
---
@@ -0,0 +1,51 @@
+import { async, ComponentFixture
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1054
+1 by inspection
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1123
+1 by inspection, this looks very clean.
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1120#discussion_r203843748
--- Diff: metron-deployment/packaging/docker/rpm-docker/SPECS/metron.spec
---
@@ -419,6 +419,7 @@ This package installs the Metron Rest %{metron_home
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1120
+1 by inspection, this looks good.
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1120#discussion_r203803381
--- Diff: metron-interface/pom.xml ---
@@ -25,6 +25,9 @@
Interfaces for Metron
https://metron.apache.org
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1120#discussion_r203801015
--- Diff: metron-interface/metron-rest/src/main/scripts/pcap_to_pdml.sh ---
@@ -0,0 +1,19 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1120#discussion_r203800738
--- Diff: metron-interface/pom.xml ---
@@ -25,6 +25,9 @@
Interfaces for Metron
https://metron.apache.org
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1100
Hey @JonZeolla can you close this one manually, for some reason the
automatic close didn't work when I committed this.
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1106
Yeah, that makes sense. +1 by inspection, let's go to master.
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1109#discussion_r203502396
--- Diff:
metron-platform/metron-pcap/src/main/java/org/apache/metron/pcap/finalizer/PcapRestFinalizer.java
---
@@ -0,0 +1,46
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1110
+1 by inspection
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1108#discussion_r203383057
--- Diff:
metron-platform/metron-pcap/src/main/java/org/apache/metron/pcap/finalizer/PcapCliFinalizer.java
---
@@ -0,0 +1,37 @@
+/**
+ * Licensed
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1108#discussion_r203383137
--- Diff:
metron-platform/metron-pcap/src/main/java/org/apache/metron/pcap/finalizer/PcapRestFinalizer.java
---
@@ -16,27 +16,21 @@
* limitations
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1108#discussion_r203381697
--- Diff:
metron-platform/metron-pcap/src/main/java/org/apache/metron/pcap/finalizer/PcapFinalizerStrategies.java
---
@@ -0,0 +1,42
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1108#discussion_r203382448
--- Diff:
metron-platform/metron-pcap/src/main/java/org/apache/metron/pcap/finalizer/PcapFinalizer.java
---
@@ -0,0 +1,122 @@
+/**
+ * Licensed
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1099
Ok, so I want to capture the follow-on tasks:
* Change Ambari to accept quoted parser groups
* Decouple the ParserBolt from the Parse execution logic
* Allow the option for intermediate
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1099#discussion_r203115089
--- Diff: use-cases/parser_chaining/README.md ---
@@ -233,3 +233,10 @@ cat ~/data.log |
/usr/hdp/current/kafka-broker/bin/kafka-console-producer.sh --b
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1099#discussion_r203052754
--- Diff: use-cases/parser_chaining/aggregated_parser_chaining_flow.xml ---
@@ -0,0 +1
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1099#discussion_r203052624
--- Diff: use-cases/parser_chaining/aggregated_parser_chaining_flow.svg ---
@@ -0,0 +1,2 @@
+http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1099
@ottobackwards I agree, our bolts tend to do the same magic set of
incantations to set up stellar. It'd be better to either try to infer that
initialization where possible or to externalize
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1109#discussion_r203049598
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/utils/HDFSUtils.java
---
@@ -29,6 +29,16 @@
public class
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1108#discussion_r203049283
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/utils/HDFSUtils.java
---
@@ -29,6 +29,16 @@
public class
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1109#discussion_r203047956
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/utils/HDFSUtils.java
---
@@ -29,6 +29,16 @@
public class
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1109#discussion_r203047410
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/config/PcapJobSupplier.java
---
@@ -0,0 +1,53 @@
+/**
+ * Licensed to
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1109#discussion_r203046824
--- Diff:
metron-interface/metron-rest-client/src/main/java/org/apache/metron/rest/model/pcap/PcapRequest.java
---
@@ -17,75 +17,65
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1108#discussion_r203045196
--- Diff:
metron-platform/metron-job/src/main/java/org/apache/metron/job/Statusable.java
---
@@ -18,20 +18,45 @@
package org.apache.metron.job
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1108
Just pointing out, I will code review but not vote on this because I
contributed to this PR in an unattributed capacity.
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1108#discussion_r203035286
--- Diff:
metron-platform/metron-job/src/main/java/org/apache/metron/job/Statusable.java
---
@@ -18,20 +18,45 @@
package org.apache.metron.job
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1108#discussion_r203035500
--- Diff:
metron-platform/metron-job/src/test/java/org/apache/metron/job/manager/InMemoryJobManagerTest.java
---
@@ -0,0 +1,192 @@
+package
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1108#discussion_r203037439
--- Diff:
metron-interface/metron-rest-client/src/main/java/org/apache/metron/rest/model/pcap/PcapRequest.java
---
@@ -17,52 +17,57
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1099#discussion_r202817242
--- Diff: metron-platform/metron-parsers/README.md ---
@@ -82,6 +82,12 @@ topology in kafka. Errors are collected with the
context of the error
(e.g
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1099#discussion_r202814185
--- Diff: metron-platform/metron-parsers/README.md ---
@@ -82,6 +82,12 @@ topology in kafka. Errors are collected with the
context of the error
(e.g
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1099#discussion_r202813546
--- Diff: metron-platform/metron-parsers/README.md ---
@@ -82,6 +82,12 @@ topology in kafka. Errors are collected with the
context of the error
(e.g
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1099#discussion_r202809295
--- Diff: metron-platform/metron-parsers/README.md ---
@@ -82,6 +82,12 @@ topology in kafka. Errors are collected with the
context of the error
(e.g
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1099#discussion_r202805609
--- Diff: metron-platform/metron-parsers/README.md ---
@@ -82,6 +82,12 @@ topology in kafka. Errors are collected with the
context of the error
(e.g
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1099#discussion_r202803869
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/bolt/ParserBolt.java
---
@@ -182,40 +185,61 @@ public void prepare(Map
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1099#discussion_r202801374
--- Diff: metron-platform/metron-parsers/README.md ---
@@ -82,6 +82,12 @@ topology in kafka. Errors are collected with the
context of the error
(e.g
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1107
+1 by inspection, thanks!
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1104
+1 Great catch!
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1105
+1 by inspection; thanks!
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1099
This looks good to me, I'm +1 by inspection, but I want to make sure enough
time has passed so enough people can look at it. I'll hold my +1 until EOD
monday.
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/870
Thanks @JonZeolla I am planning to try to get around to cleaning this up a
bit this week. I have some concerns about its interactions with the sampling
stellar functions.
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1097
+1 by inspection
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1081
@mmiklavc can you merge and close this PR?
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1065
@mmiklavc Can we get this merged?
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1102
+1 by inspection
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1101
+1 by inspection
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1084#discussion_r201448152
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/message/metadata/EnvelopedRawMessageStrategy.java
---
@@ -0,0 +1,146
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1094
+1 by inspection
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1099#discussion_r201361910
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/ParserTopologyBuilder.java
---
@@ -91,14 +101,14 @@ public
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1099#discussion_r201349285
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/ParserTopologyBuilder.java
---
@@ -91,14 +101,14 @@ public
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1084
Intermittent test failure, travis sorted now.
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1081
+1, lgtm
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1098
+1 by inspection, this looks great!
---
GitHub user cestella reopened a pull request:
https://github.com/apache/metron/pull/1084
METRON-1644: Support parser chaining
## Contributor Comments
Currently we have only one layer of parsing prior to enrichment, but often
real data is more complex. For instance, often data
Github user cestella closed the pull request at:
https://github.com/apache/metron/pull/1084
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1084
Ok, more javadocs is definitely fair. I went through the core abstractions
and added javadocs. If I missed anything, let me know.
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1084
@ottobackwards Ok, I attempted to do that
[here](https://github.com/cestella/incubator-metron/blob/c4e4786e778d5b06cd16f7faa7d3522f620fc2ba/metron-platform/metron-parsers/ParserChaining.md).
Can
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1083
You got it [METRON-1655](https://issues.apache.org/jira/browse/METRON-1655)
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1084
Ok, the prerequisite tickets are merged here and this is ready for review.
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1083
I think a decent UI that would make this a hell of a lot easier, but also
not embedding stellar in JSON would help a lot. Something like:
```
match {
REGEXP_MATCH(pix_type, '^
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1083#discussion_r200675612
--- Diff: metron-platform/metron-parsers/README.md ---
@@ -337,6 +337,28 @@ The following config will rename the fields
`old_field` and
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1083
Sure, so the difference in the parser chaining example would be between the
following
# Stellar
```
"fieldTransformations" : [
{
"transformat
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1092
+1 by inspection
---
1 - 100 of 298 matches
Mail list logo
