[GitHub] metron pull request #1104: METRON-1670 Stellar WEEK_OF_YEAR test is locale s...

2018-07-17 Thread rgasiorek
Github user rgasiorek commented on a diff in the pull request: https://github.com/apache/metron/pull/1104#discussion_r202971175 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/DateFunctionsTest.java --- @@ -182,7 +182,8 @@ public void

[GitHub] metron pull request #1104: METRON-1670 Stellar WEEK_OF_YEAR test is locale s...

2018-07-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1104 ---

[GitHub] metron pull request #1104: METRON-1670 Stellar WEEK_OF_YEAR test is locale s...

2018-07-16 Thread simonellistonball
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/1104#discussion_r202600375 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/DateFunctionsTest.java --- @@ -182,7 +182,8 @@ publ

[GitHub] metron pull request #1104: METRON-1670 Stellar WEEK_OF_YEAR test is locale s...

2018-07-15 Thread rgasiorek
Github user rgasiorek commented on a diff in the pull request: https://github.com/apache/metron/pull/1104#discussion_r202558931 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/DateFunctionsTest.java --- @@ -182,7 +182,8 @@ public void

[GitHub] metron pull request #1104: METRON-1670 Stellar WEEK_OF_YEAR test is locale s...

2018-07-13 Thread simonellistonball
GitHub user simonellistonball opened a pull request: https://github.com/apache/metron/pull/1104 METRON-1670 Stellar WEEK_OF_YEAR test is locale sensitive ## Contributor Comments Tests were previously not local sensitive. Used a locale sensitive Calendar instance to creat