VedaKadam opened a new pull request #4504:
URL: https://github.com/apache/nifi/pull/4504
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
_Add a missing # at the end of descriptions of padLeft, padRight and plus._
[
https://issues.apache.org/jira/browse/NIFI-7778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Veda Kadam updated NIFI-7778:
-
Description: Add a missing # at the end of descriptions of padLeft,
padRight and plus. (was: Added a
Veda Kadam created NIFI-7778:
Summary: Correction in description of padLeft, padRight and plus
in EL Guide
Key: NIFI-7778
URL: https://issues.apache.org/jira/browse/NIFI-7778
Project: Apache NiFi
Andy LoPresto created NIFI-:
---
Summary: CompressContent should accept password
Key: NIFI-
URL: https://issues.apache.org/jira/browse/NIFI-
Project: Apache NiFi
Issue Type:
thenatog opened a new pull request #4503:
URL: https://github.com/apache/nifi/pull/4503
… certificates. Added tests.
NIFI-7767 - Fixed checkstyle.
NIFI-7767 - Fixed up TlsCertificateAuthorityTest to include SAN in tests.
Thank you for submitting a contribution to Apache
[
https://issues.apache.org/jira/browse/NIFI-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187993#comment-17187993
]
Mark Payne commented on NIFI-40:
Unlikely. This was one of the first Jiras created for the project and has
[
https://issues.apache.org/jira/browse/NIFI-7762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne updated NIFI-7762:
-
Fix Version/s: 1.13.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
>
markap14 commented on pull request #4491:
URL: https://github.com/apache/nifi/pull/4491#issuecomment-684004495
Thanks @humpfhumpf all looks good to me! Code makes sense. Was able to
verify behavior before and after. +1 merged to main.
[
https://issues.apache.org/jira/browse/NIFI-7762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187978#comment-17187978
]
ASF subversion and git services commented on NIFI-7762:
---
Commit
markap14 merged pull request #4491:
URL: https://github.com/apache/nifi/pull/4491
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
markap14 commented on pull request #4417:
URL: https://github.com/apache/nifi/pull/4417#issuecomment-683988248
Thanks @bbende looks good. Code is clean, clear & concise. Was able to
verify behavior by copying 1.11.4 version of the
record-seriation-services-bundle into 1.13.0-SNAPSHOT. Was
[
https://issues.apache.org/jira/browse/NIFI-7661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187972#comment-17187972
]
ASF subversion and git services commented on NIFI-7661:
---
Commit
markap14 merged pull request #4417:
URL: https://github.com/apache/nifi/pull/4417
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/NIFI-7661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne updated NIFI-7661:
-
Fix Version/s: 1.13.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
>
pgyori commented on pull request #4481:
URL: https://github.com/apache/nifi/pull/4481#issuecomment-683974569
@pvillard31 , I committed the changes that enable using SSL, with an SSL
context service.
This is an automated
turcsanyip commented on a change in pull request #4489:
URL: https://github.com/apache/nifi/pull/4489#discussion_r480261846
##
File path:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/hive/streaming/RecordsEOFException.java
##
@@ -0,0 +1,28
xasx opened a new pull request #4502:
URL: https://github.com/apache/nifi/pull/4502
Description of PR
Enables supporting an HTTP Proxy for JettyWebSocketClient; fixes bug
NIFI-7754.
In order to streamline the review of the contribution we ask you
to ensure the
xasx closed pull request #4485:
URL: https://github.com/apache/nifi/pull/4485
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
szaszm commented on a change in pull request #857:
URL: https://github.com/apache/nifi-minifi-cpp/pull/857#discussion_r480027949
##
File path: libminifi/include/ResourceClaim.h
##
@@ -45,8 +45,10 @@ extern std::string default_directory_path;
extern void
hunyadi-dev commented on a change in pull request #874:
URL: https://github.com/apache/nifi-minifi-cpp/pull/874#discussion_r480192949
##
File path:
extensions/standard-processors/tests/unit/YamlConnectionParserTest.cpp
##
@@ -0,0 +1,200 @@
+/**
+ *
+ * Licensed to the Apache
szaszm commented on a change in pull request #874:
URL: https://github.com/apache/nifi-minifi-cpp/pull/874#discussion_r480189463
##
File path:
extensions/standard-processors/tests/unit/YamlConnectionParserTest.cpp
##
@@ -0,0 +1,200 @@
+/**
+ *
+ * Licensed to the Apache
lordgamez opened a new pull request #888:
URL: https://github.com/apache/nifi-minifi-cpp/pull/888
This commit handles the case when flowfiles processed by MergeContent
could have common attributes, with the same value (like mime type)
which after the attribute merge would override the
szaszm commented on a change in pull request #874:
URL: https://github.com/apache/nifi-minifi-cpp/pull/874#discussion_r480185712
##
File path:
extensions/standard-processors/tests/unit/YamlConnectionParserTest.cpp
##
@@ -0,0 +1,200 @@
+/**
+ *
+ * Licensed to the Apache
adamdebreceni commented on a change in pull request #874:
URL: https://github.com/apache/nifi-minifi-cpp/pull/874#discussion_r480170258
##
File path:
extensions/standard-processors/tests/unit/YamlConnectionParserTest.cpp
##
@@ -0,0 +1,200 @@
+/**
+ *
+ * Licensed to the
adamdebreceni commented on a change in pull request #874:
URL: https://github.com/apache/nifi-minifi-cpp/pull/874#discussion_r480165898
##
File path: libminifi/src/core/yaml/CheckRequiredField.cpp
##
@@ -0,0 +1,55 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation
hunyadi-dev commented on a change in pull request #874:
URL: https://github.com/apache/nifi-minifi-cpp/pull/874#discussion_r480164518
##
File path:
extensions/standard-processors/tests/unit/YamlConnectionParserTest.cpp
##
@@ -0,0 +1,200 @@
+/**
+ *
+ * Licensed to the Apache
adamdebreceni commented on a change in pull request #874:
URL: https://github.com/apache/nifi-minifi-cpp/pull/874#discussion_r480151533
##
File path:
extensions/standard-processors/tests/unit/YamlConnectionParserTest.cpp
##
@@ -0,0 +1,200 @@
+/**
+ *
+ * Licensed to the
adamdebreceni commented on a change in pull request #874:
URL: https://github.com/apache/nifi-minifi-cpp/pull/874#discussion_r480146776
##
File path:
extensions/standard-processors/tests/unit/YamlConnectionParserTest.cpp
##
@@ -0,0 +1,200 @@
+/**
+ *
+ * Licensed to the
hunyadi-dev commented on a change in pull request #874:
URL: https://github.com/apache/nifi-minifi-cpp/pull/874#discussion_r480147201
##
File path:
extensions/standard-processors/tests/unit/YamlConnectionParserTest.cpp
##
@@ -0,0 +1,200 @@
+/**
+ *
+ * Licensed to the Apache
hunyadi-dev commented on a change in pull request #874:
URL: https://github.com/apache/nifi-minifi-cpp/pull/874#discussion_r480147201
##
File path:
extensions/standard-processors/tests/unit/YamlConnectionParserTest.cpp
##
@@ -0,0 +1,200 @@
+/**
+ *
+ * Licensed to the Apache
adamdebreceni commented on a change in pull request #874:
URL: https://github.com/apache/nifi-minifi-cpp/pull/874#discussion_r480146776
##
File path:
extensions/standard-processors/tests/unit/YamlConnectionParserTest.cpp
##
@@ -0,0 +1,200 @@
+/**
+ *
+ * Licensed to the
hunyadi-dev commented on a change in pull request #874:
URL: https://github.com/apache/nifi-minifi-cpp/pull/874#discussion_r480145721
##
File path:
extensions/standard-processors/tests/unit/YamlConnectionParserTest.cpp
##
@@ -0,0 +1,200 @@
+/**
+ *
+ * Licensed to the Apache
hunyadi-dev commented on pull request #884:
URL: https://github.com/apache/nifi-minifi-cpp/pull/884#issuecomment-683792142
I agree that some of the comments are redundant, but I considered cleaning
them up out-of-scope for this PR. I can add a commit cleaning them up though.
fgerlits commented on a change in pull request #885:
URL: https://github.com/apache/nifi-minifi-cpp/pull/885#discussion_r480137667
##
File path: libminifi/src/core/FlowConfiguration.cpp
##
@@ -67,33 +67,24 @@ std::shared_ptr
FlowConfiguration::createProvenanceReportTask()
simonbence closed pull request #4398:
URL: https://github.com/apache/nifi/pull/4398
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
adamdebreceni commented on a change in pull request #874:
URL: https://github.com/apache/nifi-minifi-cpp/pull/874#discussion_r480144761
##
File path:
extensions/standard-processors/tests/unit/YamlConnectionParserTest.cpp
##
@@ -0,0 +1,200 @@
+/**
+ *
+ * Licensed to the
simonbence commented on pull request #4398:
URL: https://github.com/apache/nifi/pull/4398#issuecomment-683791213
As this effects only older versions, changing the current main does not
seems to be a satisfying solution. This review will be abandoned, a different
approach is taken.
fgerlits commented on a change in pull request #885:
URL: https://github.com/apache/nifi-minifi-cpp/pull/885#discussion_r480131679
##
File path: libminifi/src/core/FlowConfiguration.cpp
##
@@ -67,33 +67,24 @@ std::shared_ptr
FlowConfiguration::createProvenanceReportTask()
fgerlits commented on a change in pull request #885:
URL: https://github.com/apache/nifi-minifi-cpp/pull/885#discussion_r480137667
##
File path: libminifi/src/core/FlowConfiguration.cpp
##
@@ -67,33 +67,24 @@ std::shared_ptr
FlowConfiguration::createProvenanceReportTask()
adamdebreceni commented on a change in pull request #874:
URL: https://github.com/apache/nifi-minifi-cpp/pull/874#discussion_r480136156
##
File path:
extensions/standard-processors/tests/unit/YamlConnectionParserTest.cpp
##
@@ -0,0 +1,200 @@
+/**
+ *
+ * Licensed to the
adarmiento commented on pull request #4441:
URL: https://github.com/apache/nifi/pull/4441#issuecomment-683779159
Hello @Fabryprog,
Whatever the outcome of the discussion with the community, I would
undersline that you are not actually interested in the null value itself (if I
fgerlits commented on a change in pull request #884:
URL: https://github.com/apache/nifi-minifi-cpp/pull/884#discussion_r480120751
##
File path: extensions/http-curl/tests/HTTPHandlers.h
##
@@ -428,7 +428,7 @@ class HeartbeatHandler : public ServerAwareHandler {
void
[
https://issues.apache.org/jira/browse/NIFI-7544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne resolved NIFI-7544.
--
Fix Version/s: 1.12.0
Resolution: Duplicate
> ReplaceText processor seems not thread-safe?
>
mgaido91 commented on pull request #4441:
URL: https://github.com/apache/nifi/pull/4441#issuecomment-683769823
I think you can maybe send an email in the community list to check whether
this is a feature many people need and in case of a favorable result we can go
ahead with the PR.
Fabryprog commented on pull request #4441:
URL: https://github.com/apache/nifi/pull/4441#issuecomment-683768322
> I don't see the usefulness of such a method and I am not sure it is worth
the big code change, sorry
Hello Marco! Thanks for your time!
In the past I've been use
szaszm commented on pull request #857:
URL: https://github.com/apache/nifi-minifi-cpp/pull/857#issuecomment-683763463
:eyes:
This is an automated message from the Apache Git Service.
To respond to the message, please log on
mgaido91 commented on pull request #4441:
URL: https://github.com/apache/nifi/pull/4441#issuecomment-683761763
I don't see the usefulness of such a method and I am not sure it is worth
the big code change, sorry
This is an
fgerlits commented on pull request #886:
URL: https://github.com/apache/nifi-minifi-cpp/pull/886#issuecomment-683755809
> cool stuff, as I understand it only aims to protect the user when they
(accidentally or intentionally) expose the `minifi.properties` file
Yes, that is true.
lordgamez commented on a change in pull request #878:
URL: https://github.com/apache/nifi-minifi-cpp/pull/878#discussion_r480091219
##
File path: docker/test/integration/minifi/__init__.py
##
@@ -413,7 +426,7 @@ def __init__(self,
self.controller_services =
Gabor Gyimesi created MINIFICPP-1345:
Summary: Add linter for scripts
Key: MINIFICPP-1345
URL: https://issues.apache.org/jira/browse/MINIFICPP-1345
Project: Apache NiFi MiNiFi C++
Issue
[
https://issues.apache.org/jira/browse/NIFI-7762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
humpfhumpf updated NIFI-7762:
-
Status: Patch Available (was: Open)
> Disabled state of Ports is lost when copy-pasted or instanciated
[
https://issues.apache.org/jira/browse/NIFI-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
humpfhumpf updated NIFI-7771:
-
Status: Patch Available (was: Open)
> Infinite loop on WebUI when node stopped in cluster
>
adamdebreceni commented on pull request #886:
URL: https://github.com/apache/nifi-minifi-cpp/pull/886#issuecomment-683731126
cool stuff, as I understand it only aims to protect the user when they
(accidentally or intentionally) expose the `minifi.properties` file
adamdebreceni opened a new pull request #887:
URL: https://github.com/apache/nifi-minifi-cpp/pull/887
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been
lordgamez commented on pull request #884:
URL: https://github.com/apache/nifi-minifi-cpp/pull/884#issuecomment-683664280
> > > > Is there a plan/jira ticket for also running these checks (with
possibly an additionally shellcheck for shell files and flake8/pylint check for
python files) in
fgerlits opened a new pull request #886:
URL: https://github.com/apache/nifi-minifi-cpp/pull/886
https://issues.apache.org/jira/browse/MINIFICPP-1323
Encrypt sensitive properties in the `minifi.properties` file. The change
has two parts:
1. implement a new command-line tool
hunyadi-dev edited a comment on pull request #884:
URL: https://github.com/apache/nifi-minifi-cpp/pull/884#issuecomment-683658116
> > > Is there a plan/jira ticket for also running these checks (with
possibly an additionally shellcheck for shell files and flake8/pylint check for
python
hunyadi-dev edited a comment on pull request #884:
URL: https://github.com/apache/nifi-minifi-cpp/pull/884#issuecomment-683658116
> > > Is there a plan/jira ticket for also running these checks (with
possibly an additionally shellcheck for shell files and flake8/pylint check for
python
hunyadi-dev commented on pull request #884:
URL: https://github.com/apache/nifi-minifi-cpp/pull/884#issuecomment-683658116
> > > Is there a plan/jira ticket for also running these checks (with
possibly an additionally shellcheck for shell files and flake8/pylint check for
python files) in
lordgamez commented on pull request #884:
URL: https://github.com/apache/nifi-minifi-cpp/pull/884#issuecomment-683651016
> > Is there a plan/jira ticket for also running these checks (with possibly
an additionally shellcheck for shell files and flake8/pylint check for python
files) in the
hunyadi-dev opened a new pull request #885:
URL: https://github.com/apache/nifi-minifi-cpp/pull/885
I tried to predict what kind of URL the function meant to parse and changed
the implementation based on that. The only important change in logic is that
now the function looks for "buckets"
Adam Hunyadi created MINIFICPP-1344:
---
Summary: Investigate and fix FlowConfiguration payload URLs
Key: MINIFICPP-1344
URL: https://issues.apache.org/jira/browse/MINIFICPP-1344
Project: Apache NiFi
ecerulm commented on pull request #4465:
URL: https://github.com/apache/nifi/pull/4465#issuecomment-683601046
I believe that maybe we should follow the same conventions as `service`
* start: 0 only if nifi is started or already running.
* stop: 0 if nifi is stopped at the end of
[
https://issues.apache.org/jira/browse/MINIFICPP-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Debreceni resolved MINIFICPP-1339.
---
Resolution: Fixed
> Revive rocksdb database when the disk has space
>
hunyadi-dev commented on pull request #884:
URL: https://github.com/apache/nifi-minifi-cpp/pull/884#issuecomment-683593188
> Is there a plan/jira ticket for also running these checks (with possibly
an additionally shellcheck for shell files and flake8/pylint check for python
files) in the
65 matches
Mail list logo
