[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553793221 ## File path: libminifi/include/utils/ProcessorConfigUtils.h ## @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553788782 ## File path: libminifi/src/utils/StringUtils.cpp ## @@ -46,8 +46,13 @@ std::string StringUtils::trim(const std::string& s) { return

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r538358865 ## File path: libminifi/test/TestBase.h ## @@ -200,7 +199,7 @@ class LogTestController { } my_properties_->set("logger.root",

[GitHub] [nifi] mattyb149 commented on pull request #4735: NIFI-8101: Add refresh cached table schema property for PutDatabaseRe…

2021-01-07 Thread GitBox
mattyb149 commented on pull request #4735: URL: https://github.com/apache/nifi/pull/4735#issuecomment-756457668 I left a comment on the Jira to discuss this use case and related ones. Since these comments get posted to Jira we can continue the conversation here or there, whichever you

[jira] [Commented] (NIFI-8101) Improvement PutDatabaseRecord for refresh table schema cache

2021-01-07 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260889#comment-17260889 ] Matt Burgess commented on NIFI-8101: This looks related to NIFI-7862, except here the use case is that

[GitHub] [nifi] mattyb149 commented on a change in pull request #4739: NIFI-7906 Fix a Cypher bug that was missed during initial review

2021-01-07 Thread GitBox
mattyb149 commented on a change in pull request #4739: URL: https://github.com/apache/nifi/pull/4739#discussion_r553652199 ## File path: nifi-nar-bundles/nifi-graph-bundle/nifi-graph-processors/src/main/java/org/apache/nifi/processors/graph/ExecuteGraphQueryRecord.java ## @@

[GitHub] [nifi] mattyb149 opened a new pull request #4750: NIFI-7989: Add Update Field Names and Record Writer to UpdateHiveTable processors

2021-01-07 Thread GitBox
mattyb149 opened a new pull request #4750: URL: https://github.com/apache/nifi/pull/4750 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR Hive is mostly case-insensitive but in the case

[jira] [Reopened] (NIFI-7989) Add Hive "data drift" processor

2021-01-07 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess reopened NIFI-7989: Reopening to add Update Field Names and Record Writer properties to the processors > Add Hive "data

[GitHub] [nifi] NissimShiman commented on pull request #4563: NIFI-7738 Reverse Provenance Query

2021-01-07 Thread GitBox
NissimShiman commented on pull request #4563: URL: https://github.com/apache/nifi/pull/4563#issuecomment-756430322 This is what I have so far... I have the field labels at 12px and "Exclude from search results" in the brownish like color and thickness as I have seen these used

[jira] [Updated] (NIFI-8121) ListenHTTP should support inferred Client Authentication

2021-01-07 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-8121: --- Status: Patch Available (was: In Progress) > ListenHTTP should support inferred Client

[GitHub] [nifi] exceptionfactory opened a new pull request #4749: NIFI-8121 Updated ListenHTTP with inferred Client Authentication Policy

2021-01-07 Thread GitBox
exceptionfactory opened a new pull request #4749: URL: https://github.com/apache/nifi/pull/4749 Description of PR NIFI-8121 Updates `ListenHTTP` with an additional configuration option for the `Client Authentication` property to support automatic configuration of requiring or

[jira] [Resolved] (NIFI-7924) Fallback claim(s) support in OIDC based authentication

2021-01-07 Thread Joey Frazee (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joey Frazee resolved NIFI-7924. --- Resolution: Fixed > Fallback claim(s) support in OIDC based authentication >

[jira] [Updated] (NIFI-7924) Fallback claim(s) support in OIDC based authentication

2021-01-07 Thread Joey Frazee (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joey Frazee updated NIFI-7924: -- Fix Version/s: 1.13.0 > Fallback claim(s) support in OIDC based authentication >

[jira] [Commented] (NIFI-7924) Fallback claim(s) support in OIDC based authentication

2021-01-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260831#comment-17260831 ] ASF subversion and git services commented on NIFI-7924: --- Commit

[GitHub] [nifi] jfrazee closed pull request #4630: NIFI-7924: add fallback claims for identifying user

2021-01-07 Thread GitBox
jfrazee closed pull request #4630: URL: https://github.com/apache/nifi/pull/4630 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (NIFI-8123) NiFi startup: add option to wait for NiFi to fully load before exiting startup script

2021-01-07 Thread Peter Gyori (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Gyori updated NIFI-8123: -- Fix Version/s: 1.13.0 Status: Patch Available (was: In Progress) > NiFi startup: add option

[GitHub] [nifi] pgyori opened a new pull request #4748: NIFI-8123: Added support for --wait-for-init when NiFi started with t…

2021-01-07 Thread GitBox
pgyori opened a new pull request #4748: URL: https://github.com/apache/nifi/pull/4748 …he 'start' command Description of PR Enables starting NiFi with "bin/nifi.sh start --wait-for-init N" (where N is a positive integer) in which case the startup script will wait (up to

[jira] [Updated] (NIFI-8124) Allow Cookie Preservation in Redirects for InvokeHTTP

2021-01-07 Thread Shawn Weeks (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Weeks updated NIFI-8124: -- Description: Some authentication systems like 2-way ssl on an F5 Appliance use session cookies during

[jira] [Created] (NIFI-8124) Allow Cookie Preservation in Redirects for InvokeHTTP

2021-01-07 Thread Shawn Weeks (Jira)
Shawn Weeks created NIFI-8124: - Summary: Allow Cookie Preservation in Redirects for InvokeHTTP Key: NIFI-8124 URL: https://issues.apache.org/jira/browse/NIFI-8124 Project: Apache NiFi Issue

[jira] [Created] (NIFI-8123) NiFi startup: add option to wait for NiFi to fully load before exiting startup script

2021-01-07 Thread Peter Gyori (Jira)
Peter Gyori created NIFI-8123: - Summary: NiFi startup: add option to wait for NiFi to fully load before exiting startup script Key: NIFI-8123 URL: https://issues.apache.org/jira/browse/NIFI-8123 Project:

[GitHub] [nifi] jfrazee commented on a change in pull request #4630: NIFI-7924: add fallback claims for identifying user

2021-01-07 Thread GitBox
jfrazee commented on a change in pull request #4630: URL: https://github.com/apache/nifi/pull/4630#discussion_r553486148 ## File path:

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
szaszm commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553477912 ## File path: libminifi/src/utils/StringUtils.cpp ## @@ -46,8 +46,13 @@ std::string StringUtils::trim(const std::string& s) { return

[GitHub] [nifi] mark-weghorst commented on pull request #4508: NIFI-6576 add basic auth to confluent schema registry service

2021-01-07 Thread GitBox
mark-weghorst commented on pull request #4508: URL: https://github.com/apache/nifi/pull/4508#issuecomment-756264341 Thank you @exceptionfactory for your help getting this pushed over the finishing line over the holidays!

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
szaszm commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553241026 ## File path: extensions/librdkafka/rdkafka_utils.cpp ## @@ -0,0 +1,115 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
fgerlits commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553417399 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,553 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
fgerlits commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553426694 ## File path: extensions/librdkafka/docker_tests/CMakeLists.txt ## @@ -0,0 +1,36 @@ +# Review comment: > These are manual tests that are

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
fgerlits commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553422538 ## File path: extensions/librdkafka/rdkafka_utils.cpp ## @@ -0,0 +1,115 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Updated] (NIFI-8122) Support "upsert" functionality in ConvertJSONtoSQL processor

2021-01-07 Thread Romeo Kienzer (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Romeo Kienzer updated NIFI-8122: Summary: Support "upsert" functionality in ConvertJSONtoSQL processor (was: Support "upsert"

[jira] [Created] (NIFI-8122) Support "upsert" functionality in PutSQL processor

2021-01-07 Thread Romeo Kienzer (Jira)
Romeo Kienzer created NIFI-8122: --- Summary: Support "upsert" functionality in PutSQL processor Key: NIFI-8122 URL: https://issues.apache.org/jira/browse/NIFI-8122 Project: Apache NiFi Issue

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
fgerlits commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553417399 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,553 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
fgerlits commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553412286 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,582 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Created] (NIFI-8121) ListenHTTP should support inferred Client Authentication

2021-01-07 Thread David Handermann (Jira)
David Handermann created NIFI-8121: -- Summary: ListenHTTP should support inferred Client Authentication Key: NIFI-8121 URL: https://issues.apache.org/jira/browse/NIFI-8121 Project: Apache NiFi

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
fgerlits commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553410984 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,553 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553403462 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,569 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553402893 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,569 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553402707 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,562 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553402295 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,553 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Updated] (NIFI-8120) Improve HandleHttpResponse processing of Runtime Exceptions

2021-01-07 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-8120: --- Status: Patch Available (was: In Progress) > Improve HandleHttpResponse processing of

[GitHub] [nifi] exceptionfactory opened a new pull request #4747: NIFI-8120 Added RuntimeException handling on HttpContextMap.complete()

2021-01-07 Thread GitBox
exceptionfactory opened a new pull request #4747: URL: https://github.com/apache/nifi/pull/4747 Description of PR NIFI-8120 Adds `RuntimeException` handling for both invocations of `HttpContextMap.complete()` in `HandleHttpResponse` Processor. PR #1567 for NIFI-3517

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553396875 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,569 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553392644 ## File path: libminifi/test/TestBase.h ## @@ -200,7 +199,7 @@ class LogTestController { } my_properties_->set("logger.root",

[GitHub] [nifi-minifi-cpp] arpadboda opened a new pull request #973: MINIFICPP-1446 - SQL extension doesn't compile on Debian

2021-01-07 Thread GitBox
arpadboda opened a new pull request #973: URL: https://github.com/apache/nifi-minifi-cpp/pull/973 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[jira] [Assigned] (MINIFICPP-1446) SQL extension doesn't compile on Debian

2021-01-07 Thread Arpad Boda (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpad Boda reassigned MINIFICPP-1446: - Assignee: Arpad Boda (was: Kalmár Róbert) > SQL extension doesn't compile on

[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #972: MINIFICPP-1446 SQL extension doesn't compile on Debian

2021-01-07 Thread GitBox
arpadboda closed pull request #972: URL: https://github.com/apache/nifi-minifi-cpp/pull/972 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Created] (NIFI-8120) Improve HandleHttpResponse processing of Runtime Exceptions

2021-01-07 Thread David Handermann (Jira)
David Handermann created NIFI-8120: -- Summary: Improve HandleHttpResponse processing of Runtime Exceptions Key: NIFI-8120 URL: https://issues.apache.org/jira/browse/NIFI-8120 Project: Apache NiFi

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553348682 ## File path: libminifi/include/core/FlowFile.h ## @@ -134,7 +135,9 @@ class FlowFile : public CoreComponent, public ReferenceContainer {

[GitHub] [nifi] exceptionfactory commented on pull request #4734: NIFI-8023 Added toLocalDate() and updated toDate() in DataTypeUtils

2021-01-07 Thread GitBox
exceptionfactory commented on pull request #4734: URL: https://github.com/apache/nifi/pull/4734#issuecomment-756137595 Thanks for the feedback and testing @turcsanyip. I will run some additional tests using the flow configuration described.

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553346870 ## File path: extensions/librdkafka/tests/ConsumeKafkaTests.cpp ## @@ -0,0 +1,593 @@ + +/** + * Licensed to the Apache Software Foundation

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
szaszm commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553344804 ## File path: extensions/librdkafka/rdkafka_utils.cpp ## @@ -0,0 +1,115 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553339414 ## File path: extensions/librdkafka/tests/ConsumeKafkaTests.cpp ## @@ -0,0 +1,593 @@ + +/** + * Licensed to the Apache Software Foundation

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553336826 ## File path: extensions/librdkafka/tests/ConsumeKafkaTests.cpp ## @@ -0,0 +1,593 @@ + +/** + * Licensed to the Apache Software Foundation

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553336826 ## File path: extensions/librdkafka/tests/ConsumeKafkaTests.cpp ## @@ -0,0 +1,593 @@ + +/** + * Licensed to the Apache Software Foundation

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553324753 ## File path: extensions/librdkafka/tests/ConsumeKafkaTests.cpp ## @@ -0,0 +1,593 @@ + +/** + * Licensed to the Apache Software Foundation

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553324753 ## File path: extensions/librdkafka/tests/ConsumeKafkaTests.cpp ## @@ -0,0 +1,593 @@ + +/** + * Licensed to the Apache Software Foundation

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553322983 ## File path: extensions/librdkafka/tests/ConsumeKafkaTests.cpp ## @@ -0,0 +1,593 @@ + +/** + * Licensed to the Apache Software Foundation

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553322678 ## File path: extensions/librdkafka/tests/ConsumeKafkaTests.cpp ## @@ -0,0 +1,593 @@ + +/** + * Licensed to the Apache Software Foundation

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553321849 ## File path: extensions/librdkafka/tests/ConsumeKafkaTests.cpp ## @@ -0,0 +1,593 @@ + +/** + * Licensed to the Apache Software Foundation

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553321709 ## File path: extensions/librdkafka/tests/ConsumeKafkaTests.cpp ## @@ -0,0 +1,593 @@ + +/** + * Licensed to the Apache Software Foundation

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553318298 ## File path: extensions/librdkafka/rdkafka_utils.cpp ## @@ -0,0 +1,115 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553317390 ## File path: extensions/librdkafka/rdkafka_utils.cpp ## @@ -0,0 +1,115 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553316698 ## File path: extensions/librdkafka/rdkafka_utils.cpp ## @@ -0,0 +1,115 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553315141 ## File path: extensions/librdkafka/rdkafka_utils.cpp ## @@ -0,0 +1,115 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553314598 ## File path: extensions/librdkafka/rdkafka_utils.cpp ## @@ -0,0 +1,115 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553313955 ## File path: extensions/librdkafka/docker_tests/CMakeLists.txt ## @@ -0,0 +1,36 @@ +# Review comment: These are manual tests that are

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553313197 ## File path: extensions/librdkafka/ConsumeKafka.h ## @@ -0,0 +1,175 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553312121 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,553 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Updated] (NIFI-8119) ExecuteSQL does not properly free database ressources

2021-01-07 Thread Christian Gumpert (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Gumpert updated NIFI-8119: Description: We are using Nifi to ingest data from a Teradata database into our S3-based

[jira] [Created] (NIFI-8119) ExecuteSQL does not properly free database ressources

2021-01-07 Thread Christian Gumpert (Jira)
Christian Gumpert created NIFI-8119: --- Summary: ExecuteSQL does not properly free database ressources Key: NIFI-8119 URL: https://issues.apache.org/jira/browse/NIFI-8119 Project: Apache NiFi

[jira] [Created] (NIFI-8118) Create a Google PubSub Sink

2021-01-07 Thread Pierre Villard (Jira)
Pierre Villard created NIFI-8118: Summary: Create a Google PubSub Sink Key: NIFI-8118 URL: https://issues.apache.org/jira/browse/NIFI-8118 Project: Apache NiFi Issue Type: New Feature

[jira] [Updated] (NIFI-8118) Create a Google PubSub Sink

2021-01-07 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-8118: - Description: We have a set of sinks as of today (kafka, database, prometheus, etc) that can be

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #970: MINIFICPP-1396 Create FetchS3Object processor

2021-01-07 Thread GitBox
lordgamez commented on a change in pull request #970: URL: https://github.com/apache/nifi-minifi-cpp/pull/970#discussion_r553234200 ## File path: libminifi/test/aws-tests/FetchS3ObjectTests.cpp ## @@ -0,0 +1,174 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #970: MINIFICPP-1396 Create FetchS3Object processor

2021-01-07 Thread GitBox
lordgamez commented on a change in pull request #970: URL: https://github.com/apache/nifi-minifi-cpp/pull/970#discussion_r553233970 ## File path: libminifi/test/aws-tests/FetchS3ObjectTests.cpp ## @@ -0,0 +1,174 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #970: MINIFICPP-1396 Create FetchS3Object processor

2021-01-07 Thread GitBox
lordgamez commented on a change in pull request #970: URL: https://github.com/apache/nifi-minifi-cpp/pull/970#discussion_r553233677 ## File path: libminifi/test/aws-tests/FetchS3ObjectTests.cpp ## @@ -0,0 +1,174 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #970: MINIFICPP-1396 Create FetchS3Object processor

2021-01-07 Thread GitBox
lordgamez commented on a change in pull request #970: URL: https://github.com/apache/nifi-minifi-cpp/pull/970#discussion_r553233432 ## File path: PROCESSORS.md ## @@ -389,6 +390,40 @@ In the list below, the names of required properties appear in bold. Any other pr

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553229661 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,553 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
szaszm commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553216382 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,553 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Updated] (NIFI-8034) PropertyValue.isExpressionLanguagePresent always returns true for non-null values

2021-01-07 Thread Peter Turcsanyi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-8034: -- Status: Patch Available (was: Open) > PropertyValue.isExpressionLanguagePresent always returns

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553202896 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,553 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553202896 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,553 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi] turcsanyip opened a new pull request #4746: NIFI-8034: Fixed PropertyValue.isExpressionLanguagePresent always ret…

2021-01-07 Thread GitBox
turcsanyip opened a new pull request #4746: URL: https://github.com/apache/nifi/pull/4746 …urns true for non-null values Expression Language is NOT present if the 'expressions' list is empty or it contains a single StringLiteralExpression. Otherwise EL is considered to be

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553197371 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,553 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553194936 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,553 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553187713 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,553 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553186818 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,553 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553186818 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,553 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553176879 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,553 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Updated] (NIFI-8117) @OnRemoved method is called for version and classpath changes

2021-01-07 Thread Peter Radden (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Radden updated NIFI-8117: --- Description: To allow the method to have different behaviour depending on the reason for removal,

[jira] [Updated] (NIFI-8117) @OnRemoved method is called for version and classpath changes

2021-01-07 Thread Peter Radden (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Radden updated NIFI-8117: --- Description: To allow the method to have different behaviour depending on the reason for removal,

[jira] [Created] (NIFI-8117) @OnRemoved method is called for version and classpath changes

2021-01-07 Thread Peter Radden (Jira)
Peter Radden created NIFI-8117: -- Summary: @OnRemoved method is called for version and classpath changes Key: NIFI-8117 URL: https://issues.apache.org/jira/browse/NIFI-8117 Project: Apache NiFi

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553173662 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,553 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553173662 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,553 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi] s9514171 commented on pull request #4720: NIFI-1440 Allow Remote Process Group Target URI to change after creation

2021-01-07 Thread GitBox
s9514171 commented on pull request #4720: URL: https://github.com/apache/nifi/pull/4720#issuecomment-755962979 Hi @markap14 I have created another JIRA and PR https://github.com/apache/nifi/pull/4745 for the bug I encountered Please help to review Thanks

[GitHub] [nifi] s9514171 closed pull request #4720: NIFI-1440 Allow Remote Process Group Target URI to change after creation

2021-01-07 Thread GitBox
s9514171 closed pull request #4720: URL: https://github.com/apache/nifi/pull/4720 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553171856 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,553 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553170430 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,553 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
szaszm commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553169167 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,553 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553168700 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,553 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #940: MINIFICPP-1373 - Implement ConsumeKafka

2021-01-07 Thread GitBox
hunyadi-dev commented on a change in pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553166725 ## File path: extensions/librdkafka/ConsumeKafka.cpp ## @@ -0,0 +1,553 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one