[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1090: MINIFICPP-1561 - Allow rocksdb encryption

2021-07-06 Thread GitBox
adamdebreceni commented on a change in pull request #1090: URL: https://github.com/apache/nifi-minifi-cpp/pull/1090#discussion_r664333508 ## File path: extensions/rocksdb-repos/encryption/RocksDbEncryptionProvider.cpp ## @@ -0,0 +1,119 @@ +/** + * + * Licensed to the Apache

[jira] [Updated] (NIFI-8759) ExecuteSQL and ExecuteSQLRecord unnecessarily fall back to default decimal scale

2021-07-06 Thread Denes Arvay (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Denes Arvay updated NIFI-8759: -- Description: If the database returns 0 as scale of a decimal field ExecuteSQL and ExecuteSQLRecord

[jira] [Created] (NIFI-8759) ExecuteSQL and ExecuteSQLRecord unnecessarily fall back to default decimal scale

2021-07-06 Thread Denes Arvay (Jira)
Denes Arvay created NIFI-8759: - Summary: ExecuteSQL and ExecuteSQLRecord unnecessarily fall back to default decimal scale Key: NIFI-8759 URL: https://issues.apache.org/jira/browse/NIFI-8759 Project:

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1090: MINIFICPP-1561 - Allow rocksdb encryption

2021-07-06 Thread GitBox
adamdebreceni commented on a change in pull request #1090: URL: https://github.com/apache/nifi-minifi-cpp/pull/1090#discussion_r664320998 ## File path: libminifi/include/utils/crypto/ciphers/Aes256Ecb.h ## @@ -0,0 +1,69 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1090: MINIFICPP-1561 - Allow rocksdb encryption

2021-07-06 Thread GitBox
adamdebreceni commented on a change in pull request #1090: URL: https://github.com/apache/nifi-minifi-cpp/pull/1090#discussion_r664318601 ## File path: libminifi/src/utils/crypto/ciphers/Aes256Ecb.cpp ## @@ -0,0 +1,122 @@ +/** + * + * Licensed to the Apache Software Foundation

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1090: MINIFICPP-1561 - Allow rocksdb encryption

2021-07-06 Thread GitBox
adamdebreceni commented on a change in pull request #1090: URL: https://github.com/apache/nifi-minifi-cpp/pull/1090#discussion_r664315450 ## File path: libminifi/src/utils/crypto/ciphers/Aes256Ecb.cpp ## @@ -0,0 +1,122 @@ +/** + * + * Licensed to the Apache Software Foundation

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1090: MINIFICPP-1561 - Allow rocksdb encryption

2021-07-06 Thread GitBox
adamdebreceni commented on a change in pull request #1090: URL: https://github.com/apache/nifi-minifi-cpp/pull/1090#discussion_r664312849 ## File path: libminifi/src/utils/crypto/ciphers/Aes256Ecb.cpp ## @@ -0,0 +1,122 @@ +/** + * + * Licensed to the Apache Software Foundation

[GitHub] [nifi] simonbence commented on a change in pull request #4948: NIFI-8273 Adding Scripted Record processors

2021-07-06 Thread GitBox
simonbence commented on a change in pull request #4948: URL: https://github.com/apache/nifi/pull/4948#discussion_r664305254 ## File path: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ScriptedRouterProcessor.java

[GitHub] [nifi] simonbence commented on a change in pull request #4948: NIFI-8273 Adding Scripted Record processors

2021-07-06 Thread GitBox
simonbence commented on a change in pull request #4948: URL: https://github.com/apache/nifi/pull/4948#discussion_r664303688 ## File path: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ScriptedRouterProcessor.java

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1116: MINIFICPP-1573 Make AppendHostInfo platform independent

2021-07-06 Thread GitBox
martinzink commented on a change in pull request #1116: URL: https://github.com/apache/nifi-minifi-cpp/pull/1116#discussion_r664302952 ## File path: extensions/standard-processors/processors/AppendHostInfo.cpp ## @@ -23,90 +23,88 @@ #define __USE_POSIX #endif /* __USE_POSIX

[GitHub] [nifi] simonbence commented on a change in pull request #4948: NIFI-8273 Adding Scripted Record processors

2021-07-06 Thread GitBox
simonbence commented on a change in pull request #4948: URL: https://github.com/apache/nifi/pull/4948#discussion_r664303269 ## File path: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ScriptedRouterProcessor.java

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1116: MINIFICPP-1573 Make AppendHostInfo platform independent

2021-07-06 Thread GitBox
martinzink commented on a change in pull request #1116: URL: https://github.com/apache/nifi-minifi-cpp/pull/1116#discussion_r664302857 ## File path: libminifi/src/utils/NetworkInterfaceInfo.cpp ## @@ -0,0 +1,155 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [nifi] simonbence commented on a change in pull request #4948: NIFI-8273 Adding Scripted Record processors

2021-07-06 Thread GitBox
simonbence commented on a change in pull request #4948: URL: https://github.com/apache/nifi/pull/4948#discussion_r664302911 ## File path: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ScriptedTransformRecord.java

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1124: MINIFICPP-1367 Add option to disable NanoFi build

2021-07-06 Thread GitBox
lordgamez commented on a change in pull request #1124: URL: https://github.com/apache/nifi-minifi-cpp/pull/1124#discussion_r664302266 ## File path: cmake/BuildTests.cmake ## @@ -39,51 +39,54 @@ if(NOT EXCLUDE_BOOST) endif() function(appendIncludes testName) -

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1116: MINIFICPP-1573 Make AppendHostInfo platform independent

2021-07-06 Thread GitBox
martinzink commented on a change in pull request #1116: URL: https://github.com/apache/nifi-minifi-cpp/pull/1116#discussion_r664301931 ## File path: libminifi/src/utils/NetworkInterfaceInfo.cpp ## @@ -0,0 +1,155 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1124: MINIFICPP-1367 Add option to disable NanoFi build

2021-07-06 Thread GitBox
lordgamez commented on a change in pull request #1124: URL: https://github.com/apache/nifi-minifi-cpp/pull/1124#discussion_r664302166 ## File path: bstrp_functions.sh ## @@ -368,6 +390,7 @@ show_supported_features() { echo "W. Openwsman Support

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1124: MINIFICPP-1367 Add option to disable NanoFi build

2021-07-06 Thread GitBox
lordgamez commented on a change in pull request #1124: URL: https://github.com/apache/nifi-minifi-cpp/pull/1124#discussion_r664301389 ## File path: CMakeLists.txt ## @@ -589,12 +592,12 @@ if (NOT DISABLE_CURL AND NOT DISABLE_CONTROLLER) endif() -if (NOT DISABLE_CURL) -

[GitHub] [nifi] simonbence commented on a change in pull request #4948: NIFI-8273 Adding Scripted Record processors

2021-07-06 Thread GitBox
simonbence commented on a change in pull request #4948: URL: https://github.com/apache/nifi/pull/4948#discussion_r664299724 ## File path: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ScriptedRouteRecord.java

[GitHub] [nifi] simonbence commented on a change in pull request #4948: NIFI-8273 Adding Scripted Record processors

2021-07-06 Thread GitBox
simonbence commented on a change in pull request #4948: URL: https://github.com/apache/nifi/pull/4948#discussion_r664295102 ## File path: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ScriptedProcessor.java ##

[GitHub] [nifi] simonbence commented on a change in pull request #4948: NIFI-8273 Adding Scripted Record processors

2021-07-06 Thread GitBox
simonbence commented on a change in pull request #4948: URL: https://github.com/apache/nifi/pull/4948#discussion_r664290717 ## File path: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ScriptedPartitionRecord.java

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1090: MINIFICPP-1561 - Allow rocksdb encryption

2021-07-06 Thread GitBox
adamdebreceni commented on a change in pull request #1090: URL: https://github.com/apache/nifi-minifi-cpp/pull/1090#discussion_r664290173 ## File path: extensions/rocksdb-repos/FlowFileRepository.cpp ## @@ -220,17 +231,24 @@ void FlowFileRepository::initialize_repository() {

[GitHub] [nifi] simonbence commented on a change in pull request #4948: NIFI-8273 Adding Scripted Record processors

2021-07-06 Thread GitBox
simonbence commented on a change in pull request #4948: URL: https://github.com/apache/nifi/pull/4948#discussion_r664287047 ## File path: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ScriptedPartitionRecord.java

[GitHub] [nifi] simonbence commented on a change in pull request #4948: NIFI-8273 Adding Scripted Record processors

2021-07-06 Thread GitBox
simonbence commented on a change in pull request #4948: URL: https://github.com/apache/nifi/pull/4948#discussion_r664285857 ## File path: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ScriptedPartitionRecord.java

[GitHub] [nifi] simonbence commented on a change in pull request #4948: NIFI-8273 Adding Scripted Record processors

2021-07-06 Thread GitBox
simonbence commented on a change in pull request #4948: URL: https://github.com/apache/nifi/pull/4948#discussion_r664285050 ## File path: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ScriptedPartitionRecord.java

[GitHub] [nifi] simonbence commented on a change in pull request #4948: NIFI-8273 Adding Scripted Record processors

2021-07-06 Thread GitBox
simonbence commented on a change in pull request #4948: URL: https://github.com/apache/nifi/pull/4948#discussion_r664280132 ## File path: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ScriptedPartitionRecord.java

[GitHub] [nifi] simonbence commented on a change in pull request #4948: NIFI-8273 Adding Scripted Record processors

2021-07-06 Thread GitBox
simonbence commented on a change in pull request #4948: URL: https://github.com/apache/nifi/pull/4948#discussion_r664276040 ## File path:

<    1   2