[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6775: [NIFI-10877] Conversion of nifi-framework-core tests from Junit4 to J…

2022-12-12 Thread GitBox
exceptionfactory commented on code in PR #6775: URL: https://github.com/apache/nifi/pull/6775#discussion_r1046647523 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/wali/EncryptedSequentialAccessWriteAheadLogTest.groovy: #

[GitHub] [nifi] github-actions[bot] commented on pull request #5745: NIFI-9492: Fix for Chinese VPCE - Tests included

2022-12-12 Thread GitBox
github-actions[bot] commented on PR #5745: URL: https://github.com/apache/nifi/pull/5745#issuecomment-1347561235 Automated review is marking this PR as stale due to lack of updates in the past four months. This PR will be closed in 15 days if the stale label is not removed. This stale label

[GitHub] [nifi] Lehel44 commented on a diff in pull request #6670: NIFI-10832: Create PutSalesforceObject processor

2022-12-12 Thread GitBox
Lehel44 commented on code in PR #6670: URL: https://github.com/apache/nifi/pull/6670#discussion_r1046534890 ## nifi-nar-bundles/nifi-salesforce-bundle/nifi-salesforce-processors/src/main/java/org/apache/nifi/processors/salesforce/PutSalesforceObject.java: ## @@ -0,0 +1,207 @@ +/

[GitHub] [nifi] emiliosetiadarma commented on pull request #6545: NIFI-9697: Implemented AzureKeyVaultSecretsParameterProvider and Azur…

2022-12-12 Thread GitBox
emiliosetiadarma commented on PR #6545: URL: https://github.com/apache/nifi/pull/6545#issuecomment-1347548297 Hi @VadimBabich, Thank you for reaching out, I am gonna file a new issue to capture this as well as making the AzureKeyVaultSecretsParameterProvider just more robust in gener

[jira] [Created] (NIFI-10971) Improve edge-cases during parameter fetching using AzureKeyVaultSecretsParameterProvider

2022-12-12 Thread Emilio Setiadarma (Jira)
Emilio Setiadarma created NIFI-10971: Summary: Improve edge-cases during parameter fetching using AzureKeyVaultSecretsParameterProvider Key: NIFI-10971 URL: https://issues.apache.org/jira/browse/NIFI-10971

[GitHub] [nifi] dan-s1 commented on a diff in pull request #6775: [NIFI-10877] Conversion of nifi-framework-core tests from Junit4 to J…

2022-12-12 Thread GitBox
dan-s1 commented on code in PR #6775: URL: https://github.com/apache/nifi/pull/6775#discussion_r1046532506 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/repository/crypto/EncryptedFileSystemRepositoryTest.groovy:

[GitHub] [nifi] dan-s1 commented on a diff in pull request #6775: [NIFI-10877] Conversion of nifi-framework-core tests from Junit4 to J…

2022-12-12 Thread GitBox
dan-s1 commented on code in PR #6775: URL: https://github.com/apache/nifi/pull/6775#discussion_r1046502289 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/repository/crypto/EncryptedFileSystemRepositoryTest.groovy:

[GitHub] [nifi] dan-s1 commented on a diff in pull request #6775: [NIFI-10877] Conversion of nifi-framework-core tests from Junit4 to J…

2022-12-12 Thread GitBox
dan-s1 commented on code in PR #6775: URL: https://github.com/apache/nifi/pull/6775#discussion_r1046502289 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/repository/crypto/EncryptedFileSystemRepositoryTest.groovy:

[GitHub] [nifi] dan-s1 commented on a diff in pull request #6775: [NIFI-10877] Conversion of nifi-framework-core tests from Junit4 to J…

2022-12-12 Thread GitBox
dan-s1 commented on code in PR #6775: URL: https://github.com/apache/nifi/pull/6775#discussion_r1046502289 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/repository/crypto/EncryptedFileSystemRepositoryTest.groovy:

[GitHub] [nifi] dan-s1 commented on a diff in pull request #6775: [NIFI-10877] Conversion of nifi-framework-core tests from Junit4 to J…

2022-12-12 Thread GitBox
dan-s1 commented on code in PR #6775: URL: https://github.com/apache/nifi/pull/6775#discussion_r1046502289 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/repository/crypto/EncryptedFileSystemRepositoryTest.groovy:

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6775: [NIFI-10877] Conversion of nifi-framework-core tests from Junit4 to J…

2022-12-12 Thread GitBox
exceptionfactory commented on code in PR #6775: URL: https://github.com/apache/nifi/pull/6775#discussion_r1046493258 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/repository/crypto/EncryptedFileSystemRepositoryTes

[GitHub] [nifi] dan-s1 commented on a diff in pull request #6775: [NIFI-10877] Conversion of nifi-framework-core tests from Junit4 to J…

2022-12-12 Thread GitBox
dan-s1 commented on code in PR #6775: URL: https://github.com/apache/nifi/pull/6775#discussion_r1046487866 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/repository/crypto/EncryptedFileSystemRepositoryTest.groovy:

[jira] [Comment Edited] (NIFI-10877) Refactor nifi-framework-bundle to use JUnit 5 Part 2

2022-12-12 Thread Daniel Stieglitz (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645405#comment-17645405 ] Daniel Stieglitz edited comment on NIFI-10877 at 12/12/22 9:48 PM:

[jira] [Updated] (NIFI-10958) Documentation is not generated for some components in Java 17

2022-12-12 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-10958: Fix Version/s: 1.20.0 Resolution: Fixed Status: Resolved (was: Patch Available)

[jira] [Commented] (NIFI-10958) Documentation is not generated for some components in Java 17

2022-12-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646342#comment-17646342 ] ASF subversion and git services commented on NIFI-10958: Commit c

[GitHub] [nifi] mattyb149 closed pull request #6774: NIFI-10958 Adjust Script Engine handling to avoid errors on Java 17

2022-12-12 Thread GitBox
mattyb149 closed pull request #6774: NIFI-10958 Adjust Script Engine handling to avoid errors on Java 17 URL: https://github.com/apache/nifi/pull/6774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [nifi] mattyb149 commented on pull request #6774: NIFI-10958 Adjust Script Engine handling to avoid errors on Java 17

2022-12-12 Thread GitBox
mattyb149 commented on PR #6774: URL: https://github.com/apache/nifi/pull/6774#issuecomment-1347381540 +1 LGTM, thanks for the improvement! Merging to main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [nifi] turcsanyip commented on a diff in pull request #6777: NIFI-10969: Created extension point for Signer Override in AWS S3 pro…

2022-12-12 Thread GitBox
turcsanyip commented on code in PR #6777: URL: https://github.com/apache/nifi/pull/6777#discussion_r1046417139 ## nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/signer/AwsCustomSignerFactory.java: ## @@ -0,0 +1,25 @@ +/

[GitHub] [nifi] turcsanyip commented on a diff in pull request #6777: NIFI-10969: Created extension point for Signer Override in AWS S3 pro…

2022-12-12 Thread GitBox
turcsanyip commented on code in PR #6777: URL: https://github.com/apache/nifi/pull/6777#discussion_r1046417139 ## nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/signer/AwsCustomSignerFactory.java: ## @@ -0,0 +1,25 @@ +/

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6775: [NIFI-10877] Conversion of nifi-framework-core tests from Junit4 to J…

2022-12-12 Thread GitBox
exceptionfactory commented on code in PR #6775: URL: https://github.com/apache/nifi/pull/6775#discussion_r1046366136 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/controller/StandardFlowServiceTest.java: ## @@ -111,13

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6775: [NIFI-10877] Conversion of nifi-framework-core tests from Junit4 to J…

2022-12-12 Thread GitBox
exceptionfactory commented on code in PR #6775: URL: https://github.com/apache/nifi/pull/6775#discussion_r1046364814 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/repository/crypto/EncryptedFileSystemRepositoryTes

[GitHub] [nifi] dan-s1 commented on a diff in pull request #6775: [NIFI-10877] Conversion of nifi-framework-core tests from Junit4 to J…

2022-12-12 Thread GitBox
dan-s1 commented on code in PR #6775: URL: https://github.com/apache/nifi/pull/6775#discussion_r1046364030 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/controller/StandardFlowServiceTest.java: ## @@ -111,13 +112,16 @@

[GitHub] [nifi] dan-s1 commented on a diff in pull request #6775: [NIFI-10877] Conversion of nifi-framework-core tests from Junit4 to J…

2022-12-12 Thread GitBox
dan-s1 commented on code in PR #6775: URL: https://github.com/apache/nifi/pull/6775#discussion_r1046356567 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/repository/crypto/EncryptedFileSystemRepositoryTest.groovy:

[jira] [Updated] (NIFI-10970) Add a 'count' function to RecordPath

2022-12-12 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-10970: -- Fix Version/s: 1.20.0 Status: Patch Available (was: Open) > Add a 'count' function to Recor

[GitHub] [nifi] markap14 opened a new pull request, #6778: NIFI-10970: Added a count RecordPath function

2022-12-12 Thread GitBox
markap14 opened a new pull request, #6778: URL: https://github.com/apache/nifi/pull/6778 # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps pr

[jira] [Created] (NIFI-10970) Add a 'count' function to RecordPath

2022-12-12 Thread Mark Payne (Jira)
Mark Payne created NIFI-10970: - Summary: Add a 'count' function to RecordPath Key: NIFI-10970 URL: https://issues.apache.org/jira/browse/NIFI-10970 Project: Apache NiFi Issue Type: New Feature

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6775: [NIFI-10877] Conversion of nifi-framework-core tests from Junit4 to J…

2022-12-12 Thread GitBox
exceptionfactory commented on code in PR #6775: URL: https://github.com/apache/nifi/pull/6775#discussion_r1046275711 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/controller/StandardProcessorNodeIT.java: ## @@ -206,9 +

[GitHub] [nifi] exceptionfactory commented on pull request #6775: [NIFI-10877] Conversion of nifi-framework-core tests from Junit4 to J…

2022-12-12 Thread GitBox
exceptionfactory commented on PR #6775: URL: https://github.com/apache/nifi/pull/6775#issuecomment-1347129068 Thanks for resolving the conflicts @dan-s1. I had made some of the related changes under NIFI-10941 as part of removing TestNG references, I will review the changes in this PR. --

[GitHub] [nifi] pvillard31 commented on pull request #6589: NIFI-10710 implement processor for AWS Polly, Textract, Translate, Tr…

2022-12-12 Thread GitBox
pvillard31 commented on PR #6589: URL: https://github.com/apache/nifi/pull/6589#issuecomment-1347061165 Note - I do see the additionalDetails page on the pull request but it's not showing in the usage page of the processor. Maybe something wrong somewhere when building the documentation?

[GitHub] [nifi] tpalfy commented on a diff in pull request #6670: NIFI-10832: Create PutSalesforceObject processor

2022-12-12 Thread GitBox
tpalfy commented on code in PR #6670: URL: https://github.com/apache/nifi/pull/6670#discussion_r1046116928 ## nifi-nar-bundles/nifi-salesforce-bundle/nifi-salesforce-processors/src/main/java/org/apache/nifi/processors/salesforce/PutSalesforceObject.java: ## @@ -0,0 +1,207 @@ +/*

[GitHub] [nifi] tpalfy commented on a diff in pull request #6670: NIFI-10832: Create PutSalesforceObject processor

2022-12-12 Thread GitBox
tpalfy commented on code in PR #6670: URL: https://github.com/apache/nifi/pull/6670#discussion_r1046116928 ## nifi-nar-bundles/nifi-salesforce-bundle/nifi-salesforce-processors/src/main/java/org/apache/nifi/processors/salesforce/PutSalesforceObject.java: ## @@ -0,0 +1,207 @@ +/*

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6777: NIFI-10969: Created extension point for Signer Override in AWS S3 pro…

2022-12-12 Thread GitBox
exceptionfactory commented on code in PR #6777: URL: https://github.com/apache/nifi/pull/6777#discussion_r1046061504 ## nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/signer/AwsCustomSignerFactory.java: ## @@ -0,0 +1,25

[GitHub] [nifi-minifi-cpp] martinzink commented on pull request #1471: MINIFICPP-2012 - Make free unconditional

2022-12-12 Thread GitBox
martinzink commented on PR #1471: URL: https://github.com/apache/nifi-minifi-cpp/pull/1471#issuecomment-1346665510 Awesome find :pray: thanks for digging this out. Could you please add the explanation here or in the Jira how this could cause a memory leak? Also adding a unit te

[GitHub] [nifi] dan-s1 commented on pull request #6775: [NIFI-10877] Conversion of nifi-framework-core tests from Junit4 to J…

2022-12-12 Thread GitBox
dan-s1 commented on PR #6775: URL: https://github.com/apache/nifi/pull/6775#issuecomment-1346580500 @exceptionfactory Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

2022-12-12 Thread GitBox
fgerlits commented on code in PR #1424: URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1045813064 ## extensions/sftp/tests/ListSFTPTests.cpp: ## @@ -187,7 +180,7 @@ TEST_CASE_METHOD(ListSFTPTestsFixture, "ListSFTP list one file", "[ListSFTP][bas TEST_CA

[GitHub] [nifi-minifi-cpp] adamdebreceni opened a new pull request, #1471: MINIFICPP-2012 - Make free unconditional

2022-12-12 Thread GitBox
adamdebreceni opened a new pull request, #1471: URL: https://github.com/apache/nifi-minifi-cpp/pull/1471 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been take

[jira] [Created] (MINIFICPP-2012) Possible leak

2022-12-12 Thread Adam Debreceni (Jira)
Adam Debreceni created MINIFICPP-2012: - Summary: Possible leak Key: MINIFICPP-2012 URL: https://issues.apache.org/jira/browse/MINIFICPP-2012 Project: Apache NiFi MiNiFi C++ Issue Type: Bu

[jira] [Created] (MINIFICPP-2011) Add the CollectKubernetesPodMetrics processor to PROCESSORS.md

2022-12-12 Thread Ferenc Gerlits (Jira)
Ferenc Gerlits created MINIFICPP-2011: - Summary: Add the CollectKubernetesPodMetrics processor to PROCESSORS.md Key: MINIFICPP-2011 URL: https://issues.apache.org/jira/browse/MINIFICPP-2011 Projec

[GitHub] [nifi-site] szaszm merged pull request #70: MINIFICPP-1998 Add MiNiFi C++ 0.13.0 to the downloads page

2022-12-12 Thread GitBox
szaszm merged PR #70: URL: https://github.com/apache/nifi-site/pull/70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.or